#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by ddrake):
Replying to [comment:170 ppurka]:
> The `#!/usr/bin/env bash` syntax is
[http://en.wikipedia.org/wiki/Shebang_(Unix)#Portability recommended for
portability].
>
> As for the bash script, are you looking at the output of the bash script
or only at the return status.
There's a doctest in sage/interfaces/jmoldata.py (line 90) that looks like
this:
{{{
result = subprocess.call([testjavapath],stdout=jout)
}}}
[http://docs.python.org/library/subprocess.html#subprocess.call The
documentation for subprocess.call] says it returns the returncode
attribute, but the current script AFAICT always returns 0. I think we
should be using `check_output` if we want the output. We can do either
thing, but it seems like right now the script and the doctest are not
consistent.
> In this case, the script can be shortened significantly
> {{{
> #!/usr/bin/env bash
> type -atp java > /dev/null && java -version 2>&1 | grep
version.*[1]\.[567] > /dev/null
> echo $?
> }}}
That's certainly an option, but perhaps the verbose-but-obvious script
would be easier to maintain, in case someone who's not much of a bash
expert needs to change it. :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:172>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
