#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by jhpalmieri):
I wasn't paying enough attention earlier. Since we're already using
subprocess, I would suggest this color for the bike shed:
{{{
#!diff
diff --git a/sage/interfaces/jmoldata.py b/sage/interfaces/jmoldata.py
--- a/sage/interfaces/jmoldata.py
+++ b/sage/interfaces/jmoldata.py
@@ -87,7 +87,12 @@ class JmolData(SageObject):
scratchout = os.path.join(jmolscratch,"jmolout.txt")
jout=open(scratchout,'w')
testjavapath = os.path.join(SAGE_LOCAL, "share", "jmol",
"testjava.sh")
- result = subprocess.call([testjavapath],stdout=jout)
+ try:
+ version = subprocess.check_output(['java', '-version'],
stderr=subprocess.STDOUT)
+ import re
+ result = re.search("version.*[1]\.[567]", version)
+ except (subprocess.CalledProcessError, OSError):
+ result = False
jout.close()
if (result == 0):
return (True)
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:173>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
