#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by gutow):
Replying to [comment:172 ddrake]:
> the current script AFAICT always returns 0. I think we should be using
`check_output` if we want the output. We can do either thing, but it
seems like right now the script and the doctest are not consistent.
1) The current script returns a result code of 1 (and so should ppurka's
short script) if the java command is not available or if the version is
not 1.5.x, 1.6,x or 1.7.x. This is the desired behavior for use by the
jmoldata.py function that tests for the proper JVM.
2) subprocess.check_output raises an error of its own. Since there are a
number of other kinds of errors I also expect to be specific to
jmoldata.py functionality, I prefer testing the result code myself before
generating jmoldata.py specific errors.
3) Ultimately, I hope this discussion is moot, as I would like to test
directly inside python, using syntax similar to that suggested in
comment:160 and comment:173. However, my objection to using the
{{{subprocess.CalledProcessError}}} still stands.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:174>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
