#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by gutow):
Replying to [comment:170 ppurka]:
> The `#!/usr/bin/env bash` syntax is
[http://en.wikipedia.org/wiki/Shebang_(Unix)#Portability recommended for
portability].
>
I worry about all the caveats for failures and race conditions that are
also mentioned in this link. I'm not sure it is an improvement, but am no
expert.
> As for the bash script, are you looking at the output of the bash script
or only at the return status. In the former case, you probably want to
echo back only the $OUT. In this case, the script can be shortened
significantly
> {{{
> #!/usr/bin/env bash
> type -atp java > /dev/null && java -version 2>&1 | grep
version.*[1]\.[567] > /dev/null
> echo $?
> }}}
>
This short version looks like it works properly on a system with java 1.6
needs tests on a system without java and with 1.4. To completely minimize
it the last "echo" could be commented out as well.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:171>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
