#12299: Upgrade Jmol to 12.3.27, Advance Jmol Interactive Features in Flask
Notebook
--------------------------------------------------------------+-------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-pending
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Fixed upstream, in a later stable release. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503,#13121 | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by gutow):
Replying to [comment:178 ppurka]:
> The bash script currently shipped in the spkg does not return the
correct exit codes.
Yes it does. It does not send them to the standard output, but it does
return the correct values to the $? variable that {{{subprocess.call}}}
gets the result value from. Otherwise we would never get the error
message on machines that don't have java or the correct version and we do.
If you want to check that the script works simply do this on a machine
with java 1.5-7
{{{
>./testjava.sh
>echo $?
0
}}}
On a machine with a different java or no java you will see
{{{
>./testjava.sh
>echo $?
1
}}}
If you don't have a machine without java you can check it by changing the
grep statement to
{{{
grep version.*[1]\.[2]
}}}
Then run the script again. You will find and exit code of 1.
I verified this on ubuntu and MacOS.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:179>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
