Dan Price wrote: <snip>
> I would suggest that upload be enabled via a separate flag. Already done (after Shawn's e-mail) as -U flag. > -O was really intended to be an ON specific hack, when I added it. > Some consolidations (like packaging and the installer) are using > defect.opensolaris.org and -O doesn't really help them. Aha. I have removed some sanity checks and made sure that -O is orthogonal to other options. > I suggest: > > webrev -u <rsync argument> > webrev -U (i.e. do it all automagically) > > That way, I could do: > > webrev -u cr.opensolaris.org:name_i_want > > If I want to be picky about what I name the webrev. > > Or even webrev -u username at cr.opensolaris.org:name_i_want > > Anyway, mostly I'd like -O to not get muddled up with other > functionality-- that just makes it harder to kill it off later. Instead of aggregating everything under one optarg, I split it. Like this the following scenarios can happen: - OSol developer, basic case (uploads via SSH to cr.opensolaris.org and has .ssh/config entry) webrev -O -U - OSol developer who likes to check before upload webrev -O webrev -n -U - non-OSol developer, remote only supports SFTP/SCP (no shell) webrev -U -u some_restricted_user -h foobar.org - rsync user with remote host webrev -r -U -h some_host.org - rsync user with custom directory (local file-system copy, just for demonstration) webrev -r -U -d /foo/bar/fix.webrev The defaults (subject to change based on feedback) are: - remote host: cr.opensolaris.org - transport: SSH - remote directory: $WDIR (which is basically basename($CODEMGR_WS)) webrev refreshed. > I haven't looked at the code yet but will try to find the time to do > so. Thanks, waiting for your comments. v.
