On Fri, Sep 26, 2008 at 03:01:20PM +0200, Vladimir Kotal wrote: > - rsync user with remote host > webrev -r -U -h some_host.org > > - rsync user with custom directory > (local file-system copy, just for demonstration) > webrev -r -U -d /foo/bar/fix.webrev
Please don't use -r to indicate rsync; I want to reserve that for "revision", to enable the ability to create a webrev based on one or more revisions in a tree. I have working code for this, but it was rejected some time ago (didn't take care of some unusual corner cases, I think) and I haven't had time to make those fixes. I think that given that cr.os.o uses rsync, webrev should use rsync by default. In fact, it should probably try rsync, then fall back to scp if rsync failed. I also think that you should just use user at host:directory notation like rsync and scp, rather than littering webrev with a bunch of options that only have to do with this rather minor functionality. Danek
