D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  Looks great to me! I guess it really is true that aesthetics are subjective. 
:)
  
  But it wasn't just about that. Check out the list of bugs this patch fixed. 
This was not just because we though ti looked prettier but also because the old 
emblems were much buggier.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: safaalfulaij, bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, 
michaelh

D16421: Improve emblem contrast, legibility and consistency

[Safa Alfulaij]

safaalfulaij added a comment.


  mmm, sorry. I saw this today and I just took a minute to understand it. How 
does this looks consistent with the theme, or even nice (really sorry)? Please 
teach me.
  Thank you.
  F6529631: Screenshot_٢٠١٩٠١٠٦_١٣١٠٠٤.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: safaalfulaij, bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, 
michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks fantastic. Fabulous work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg, ngraham
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44410.
ndavis added a comment.


  Add emblem-readonly

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44313=44410

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-locked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-readonly.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-locked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-readonly.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-readonly.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-locked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-readonly.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#349331 , @ngraham wrote:
  
  > Thanks for the updates. I know it's a PITA, but would you mind updating the 
image in the Summary section?
  
  
  Done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44313.
ndavis added a comment.


  Add 16 and 22 px versions of previous change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44308=44313

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-locked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-locked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-locked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44308.
ndavis added a comment.


  Add dark versions of previous change

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44304=44308

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-locked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the updates. I know it's a PITA, but would you mind updating the 
image in the Summary section?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44304.
ndavis added a comment.


  Improve arrow visibility on vcs emblems
  Add emblem-encrypted-locked
  Change emblem-locked back to orange

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44248=44304

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#349083 , @ngraham wrote:
  
  > In D16421#349082 , @ndavis wrote:
  >
  > > In D16421#349081 , @ngraham 
wrote:
  > >
  > > > This would all require some additional changes in Dolphin and Folder 
view, of course.
  > >
  > >
  > > So should I change `emblem-added` and `emblem-remove` back to their 
original colors? It wouldn't be any worse than it currently is for Dolphin 
before any changes are applied to it.
  >
  >
  > Well, we should discuss that first. :)
  >
  > An LXR search 
 reveals that all 
users of these emblem use them in the same way. We have two options for how we 
want to change things:
  >
  > - Use new iconography (such as my proposed checkmark) for `emblem-added` 
and `emblem-remove`
  > - Create new emblems for this and then over time change our apps to use 
them. This seems less desirable since then `emblem-added` and `emblem-remove` 
will then just be unused, and also it requires code changes to those apps.
  >
  >   So if we want to further improve these emblems, my vote is for changing 
the existing icons rather than making new ones.
  
  
  So keep the blue color for now?
  
  Something that I plan to do in the future is re-do the package management 
icons and I was hoping to reuse emblem-added and emblem-removed for that. 
Currently, the package management icons are action icons, but they are hard to 
read and they blur the line between action and state the way they are used, 
which is why I'm planning to make them emblems instead.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#349082 , @ndavis wrote:
  
  > In D16421#349081 , @ngraham 
wrote:
  >
  > > This would all require some additional changes in Dolphin and Folder 
view, of course.
  >
  >
  > So should I change `emblem-added` and `emblem-remove` back to their 
original colors? It wouldn't be any worse than it currently is for Dolphin 
before any changes are applied to it.
  
  
  Well, we should discuss that first. :)
  
  An LXR search  
reveals that all users of these emblem use them in the same way. We have two 
options for how we want to change things:
  
  - Use new iconography (such as my proposed checkmark) for `emblem-added` and 
`emblem-remove`
  - Create new emblems for this and then over time change our apps to use them. 
This seems less desirable since then `emblem-added` and `emblem-remove` will 
then just be unused, and also it requires code changes to those apps.
  
  So if we want to further improve these emblems, my vote is for changing the 
existing icons rather than making new ones.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#349081 , @ngraham wrote:
  
  > This would all require some additional changes in Dolphin and Folder view, 
of course.
  
  
  So should I change `emblem-added` and `emblem-remove` back to their original 
colors? It wouldn't be any worse than it currently is for Dolphin before any 
changes are applied to it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#349080 , @ndavis wrote:
  
  > Something just occurred to me: Why do we use emblems as if they were action 
buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and 
`list-remove` instead of `emblem-added` and `emblem-remove`?
  
  
  I had the same thought today. Perhaps we should have them look like 
checkboxes: when you hover over the icon, you see an empty checkbox, and when 
you click on it, it becomes a checked checkbox. This would be more semantically 
correct and also re-use people's existing familiarity with the concept of 
checkboxes. If we do this, I'd also like to see the checked checkbox remain 
visible when the icon is selected. This is how item selection is typically 
handled on mobile operating systems as well, and it's nice and clear.
  
  This would all require some additional changes in Dolphin and Folder view, of 
course.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  Something just occurred to me: Why do we use emblems as if they were action 
buttons in Dolphin? Would it be so bad if Dolphin used `list-add` and 
`list-remove` instead of `emblem-added` and `emblem-remove`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#349075 , @bruns wrote:
  
  > There may also be a conceptual issue here - previously, the `emblem-locked` 
which is used for unaccessible (e.g. root owned) files was a lock with orange 
background, now it is green. For locked encrypted files green may be suitable, 
for unacessible files not so much.
  
  
  That's true. Probably we need a new emblem `emblem-readonly` that can be used 
for read-only files and directories. It's always been kind of an abuse of the 
iconography to re-use the lock for this. Only now as we're better defining the 
visuals of the lock emblem does it become really obvious.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#349075 , @bruns wrote:
  
  > @ndavis - can you upload the `git format-patch -1` output somewhere 
(temporary)?
  
  
  https://hastebin.com/egepiwurab.diff
  
  > There may also be a conceptual issue here - previously, the `emblem-locked` 
which is used for unaccessible (e.g. root owned) files was a lock with orange 
background, now it is green. For locked encrypted files green may be suitable, 
for unacessible files not so much.
  
  You're right. Perhaps we should introduce some new emblems?
  
  Some ideas:
  
  `emblem-select` (`emblem-added` sounds like it should be used for things that 
were successfully added)
  `emblem-deselect` (in some contexts, `emblem-remove` would be destructive)
  `emblem-encrypted-locked` (to match the existing `emblem-encrypted-unlocked`, 
Papirus has this)
  `emblem-readonly` (Papirus has this)
  
  Here's a list of emblems from the Papirus theme: 
https://hastebin.com/asuquwoyap.css
  I'm not saying we should use all of these, but we can use that list to pick 
compatible names and having icons that match the context is a good thing.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#349072 , @ngraham wrote:
  
  > After manual application, the alignment is perfect for me too. So that's 
not a blocker; must be some local issye on your end, @ndavis. I think we're 
really close (or ready?) to being able to land this! @bruns, are your comments 
about the question mark a blocker, or are you satisfied?
  
  
  
  
  > I've pinged #syadmin about being unable to apply the patch; hopefully they 
can help us out!
  
  @ndavis - can you upload the `git format-patch -1` output somewhere 
(temporary)?
  
  In D16421#348960 , @ngraham wrote:
  
  > In D16421#348959 , @bruns wrote:
  >
  > > Tried to reproduce it here, but for me the bottom-right emblem just 
renders fine here:
  > >
  > > F6363939: Unpatched_locked_link_48.png 

  >
  
  
  There may also be a conceptual issue here - previously, the `emblem-locked` 
which is used for unaccessible (e.g. root owned) files was a lock with orange 
background, now it is green. For locked encrypted files green may be suitable, 
for unacessible files not so much.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  After manual application, the alignment is perfect for me too. So that's not 
a blocker; must be some local issye on your end, @ndavis. I think we're really 
close (or ready?) to being able to land this! @bruns, are your comments about 
the question mark a blocker, or are you satisfied?
  
  I've pinged #syadmin about being unable to apply the patch; hopefully they 
can help us out!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348960 , @ngraham wrote:
  
  > I wish I could test but I have not gotten the patch to apply so far. Did 
`arc apply D16421` work for you, or did you have to apply it by hand?
  
  
  No, I just copied a few of the icons manually into my installation.
  
  Neither arc patch nor downloading the raw diff and applying it with `patch 
-p1` works.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348959 , @bruns wrote:
  
  > Tried to reproduce it here, but for me the bottom-right emblem just renders 
fine here:
  >
  > F6363939: Unpatched_locked_link_48.png 

  
  
  I wish I could test but I have not gotten the patch to apply so far. Did `arc 
apply D16421` work for you, or did you have to apply it by hand?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348609 , @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.
  
  
  Tried to reproduce it here, but for me the bottom-right emblem just renders 
fine here:
  
  F6363939: Unpatched_locked_link_48.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348866 , @bruns wrote:
  
  > In D16421#348860 , @ndavis wrote:
  >
  > > The other issue with using a font based question mark is I also have to 
use that for the 8px icon if I want consistency.
  >
  >
  > There is nothing wrong with using the font outline as a starting point and 
tweaking it for pixel grid alignment manually.
  >
  > > Is a 6pt Noto Sans question mark legible enough?
  > > 
  > > normal 6pt Noto Sans F6363258: Screenshot_20181026_073539.png 

  > > 
  > > Bold 6pt Noto Sans F6363273: Screenshot_20181026_074013.png 

  >
  > I think the bold one is.
  >
  > > drawn F6363264: Screenshot_20181026_073837.png 

  >
  > The hand drawn is actually 7px high ...
  
  
  Yeah, I cheated on the drawn one because I'd have to come up with a brand new 
style to make it fit in a 6px area. I've also made the exclaimation marks and 
'i's of the 8px emblems 7px high to improve the ratio of dot to body.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348860 , @ndavis wrote:
  
  > The other issue with using a font based question mark is I also have to use 
that for the 8px icon if I want consistency.
  
  
  There is nothing wrong with using the font outline as a starting point and 
tweaking it for pixel grid alignment manually.
  
  > Is a 6pt Noto Sans question mark legible enough?
  > 
  > normal 6pt Noto Sans F6363258: Screenshot_20181026_073539.png 

  > 
  > Bold 6pt Noto Sans F6363273: Screenshot_20181026_074013.png 

  
  I think the bold one is.
  
  > drawn F6363264: Screenshot_20181026_073837.png 

  
  The hand drawn is actually 7px high ...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348857 , @bruns wrote:
  
  > In D16421#348826 , @ndavis wrote:
  >
  > > I could, but then I'm running into this issue: T9898 

  > >
  > > I made that task when I was trying to come up with a more legible style 
for emblem-question. I chose this style for consistency, but there is already a 
consistency problem.
  >
  >
  > Fair point.
  >  The used fonts seem to be (for the question marks):
  >
  > - Noto Sans or Droid Sans, but rectangular dot?
  > - 2x homegrown
  > - 2x Nimbus Sans Bold
  > - Oxygen Sans
  
  
  The other issue with using a font based question mark is I also have to use 
that for the 8px icon if I want consistency.
  
  Is a 6pt Noto Sans question mark legible enough? F6363258: 
Screenshot_20181026_073539.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348826 , @ndavis wrote:
  
  > I could, but then I'm running into this issue: T9898 

  >
  > I made that task when I was trying to come up with a more legible style for 
emblem-question. I chose this style for consistency, but there is already a 
consistency problem.
  
  
  Fair point.
  The used fonts seem to be (for the question marks):
  
  - Noto Sans or Droid Sans, but rectangular dot?
  - 2x homegrown
  - 2x Nimbus Sans Bold
  - Oxygen Sans

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  Slight change to make the 16 and 22 px icons look more like the 8px icon:
  F6363210: Screenshot_20181026_072203.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44248.
ndavis added a comment.


  Widen the circular portion of 16/22 px emblem-question icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44230=44248

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348825 , @bruns wrote:
  
  > In D16421#348664 , @ndavis wrote:
  >
  > > In D16421#348594 , @ngraham 
wrote:
  > >
  > > > Now that I stare at the summary graphics again, the white question mark 
looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? 
Other than that, everything looks pretty much perfect to me.
  > >
  > >
  > > How is this?
  > >  F6356555: Screenshot_20181025_193720.png 

  >
  >
  > Much better (weight matches), but I don't like the sharp corner in the 
center to much. Can you try using the question mark from "Noto Sans"?
  
  
  I could, but then I'm running into this issue: 
https://phabricator.kde.org/T9898
  
  I made that task when I was trying to come up with a more legible style for 
emblem-question. I chose this style for consistency, but there is already a 
consistency problem.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348664 , @ndavis wrote:
  
  > In D16421#348594 , @ngraham 
wrote:
  >
  > > Now that I stare at the summary graphics again, the white question mark 
looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? 
Other than that, everything looks pretty much perfect to me.
  >
  >
  > How is this?
  >  F6356555: Screenshot_20181025_193720.png 

  
  
  Much better (weight matches), but I don't like the sharp corner in the center 
to much. Can you try using the question mark from "Noto Sans"?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44230.
ndavis added a comment.


  Make emblem-question symbol thicker

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44211=44230

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348702 , @ngraham wrote:
  
  > Does this problem still happen after you delete your icon cache? (`rm 
~/.cache/icon-cache.kcache`)
  
  
  Yes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348664 , @ndavis wrote:
  
  > How is this?
  >  F6356555: Screenshot_20181025_193720.png 

  
  
  Much better! That looks great.
  
  In D16421#348675 , @ndavis wrote:
  
  > It's not that the symlink emblem gets trimmed, it's just normally off.
  
  
  That's really weird. I don't see any code that's looking for this specific 
emblem and drawing it in a different position. Does this problem still happen 
after you delete your icon cache? (`rm ~/.cache/icon-cache.kcache`)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348609 , @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.
  
  
  It's not that the symlink emblem gets trimmed, it's just normally off. In 
this image, I changed the background of the symlink emblem to take up the whole 
canvas and it's 2 pixels farther in than the vcs-normal emblem.F6356652: 
Screenshot_20181025_195954.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348594 , @ngraham wrote:
  
  > Now that I stare at the summary graphics again, the white question mark 
looks a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? 
Other than that, everything looks pretty much perfect to me.
  
  
  How is this?
  F6356555: Screenshot_20181025_193720.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348609 , @ngraham wrote:
  
  > JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.
  
  
  You could try to convert the emblem to PNG and see if it is aligned correctly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  JFYI, I dug through `KIconLoader` today and couldn't find anything that 
explicitly or implicitly trims the bounds of loaded images that could account 
for the link emblem not having its original bounds respected and results in it 
being drawn too high. Either I missed the part that does this (which is quite 
possible), or it's some implicit thing in the SVG image itself (which is also 
possible, since I know nothing about SVG images), or it's something else 
entirely.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  Now that I stare at the summary graphics again, the white question mark looks 
a bit wispy and insubstantial at the 16px and 22px sizes. Do you agree? Other 
than that, everything looks pretty much perfect to me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44211.
ndavis added a comment.


  Change style of emblem-symbolic-link at 22px

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44210=44211

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348516 , @ndavis wrote:
  
  > F6350488: Screenshot_20181025_100526.png 

  
  
  //Perfect!//

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348513 , @bruns wrote:
  
  > The center link looks slightly too heavy, but imho still better. Might be 
possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, 
it should not make it too fuzzy.
  
  
  Here is how that looks:
  F6350488: Screenshot_20181025_100526.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  In D16421#348507 , @ndavis wrote:
  
  > In D16421#348504 , @bruns wrote:
  >
  > > In D16421#348502 , @ndavis 
wrote:
  > >
  > > > Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  > > >  F6350193: Screenshot_20181025_093800.png 

  > >
  > >
  > > Also better, but can you also try to make the center link full solid?
  >
  >
  > Here is how that looks:
  >  F6350381: Screenshot_20181025_095315.png 

  
  
  The center link looks slightly too heavy, but imho still better. Might be 
possible to shave off 1/2 pixel from the link top/bottom. As its a solid area, 
it should not make it too fuzzy.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348507 , @ndavis wrote:
  
  > F6350381: Screenshot_20181025_095315.png 

  
  
  Good! How about making the center link a tiny bit thinner? I'll look into the 
code in `KIconLoader` that positions the emblems to see why it's not getting 
centered.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44210.
ndavis added a comment.


  Change style of emblem-symbolic-link

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44201=44210

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  icons/emblems/16/vcs-conflicting.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348506 , @ngraham wrote:
  
  > In D16421#348502 , @ndavis wrote:
  >
  > > F6350185: Screenshot_20181025_093827.png 

  > >  F6350193: Screenshot_20181025_093800.png 

  >
  >
  > +1, those are excellent. I agree that the rectangle should be vertically 
centered on the same line as the other emblems. You can probably do this by 
giving the the link emblem's file the same dimensions as other emblems, but 
positioning the actual emblem itself vertically centered inside it. Also +1 to 
seeing if making the center link solid would look better for the larger sizes 
too.
  
  
  That is actually how it currently is, Dolphin or whatever is responsible for 
displaying the emblems just posisions the symlink emblem in a different way 
from the other emblems.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  
  
  In D16421#348502 , @ndavis wrote:
  
  > F6350185: Screenshot_20181025_093827.png 

  >  F6350193: Screenshot_20181025_093800.png 

  
  
  +1, those are excellent. I agree that the rectangle should be vertically 
centered on the same line as the other emblems. You can probably do this by 
giving the the link emblem's file the same dimensions as other emblems, but 
positioning the actual emblem itself vertically centered inside it. Also +1 to 
seeing if making the center link solid would look better for the larger sizes 
too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  BTW, +1 for all the icons!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348487 , @bruns wrote:
  
  > Can you try the following:
  >
  > - Make the center link solid and narower (e.g. 2px height for the 16px one)
  > - Reduce the height of the right and left links
  
  
  Like this?
  F6350185: Screenshot_20181025_093827.png 

  Also, here is the 22px version adjusted to have a similar shape to your 
suggested 16px version.
  F6350193: Screenshot_20181025_093800.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Stefan Brüns]

bruns added a comment.


  Can you try the following:
  
  - Make the center link solid and narower (e.g. 2px height for the 16px one)
  - Reduce the height of the right and left links

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: bruns, ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  Here are what the changes look like:
  
  8px symlink emblem, 16px emblem-remove:
  F6349477: Screenshot_20181025_041309.png 

  Pretty crowded.
  
  16px symlink emblem, 16px emblem-remove:
  F6349480: Screenshot_20181025_041224.png 

  Still pretty crowded
  
  22px symlink emblem, 22px emblem-remove:
  F6349485: Screenshot_20181025_041121.png 

  It's OK I guess.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis updated this revision to Diff 44201.
ndavis added a comment.


  Change emblem-remove color to Plasma Blue, Change style of 
emblem-symbolic-link

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16421?vs=44194=44201

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg
  icons/emblems/16/emblem-symbolic-link.svg
  icons/emblems/16/emblem-unavailable.svg
  icons/emblems/16/emblem-unlocked.svg
  icons/emblems/16/emblem-unmounted.svg
  icons/emblems/16/emblem-warning.svg
  icons/emblems/16/rating-unrated.svg
  icons/emblems/16/rating.svg
  icons/emblems/16/vcs-added.svg
  

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348381 , @ndavis wrote:
  
  > Here's how that looks: F6349192: Screenshot_20181024_234540.png 

  
  
  Looks good to me!
  
  In D16421#348361 , @ndavis wrote:
  
  > Here's another attempt:
  >  F6349199: Screenshot_20181024_235038.png 

  >
  > F6349201: Screenshot_20181024_235027.png 

  >
  > F6349203: Screenshot_20181024_235012.png 

  
  
  I see what you mean. I think it looks great at the two larger sizes bug agree 
that the smaller one isn't as good. However, it's still an improvement over the 
status quo: F6349218: Screenshot_20181024_220645.png 

  
  At that small a size, it's currently illegible. So this is at least no worse.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348363 , @ngraham wrote:
  
  > Yeah I understand. I'm not the hugest fan of the orange either, and now 
that I think about it, semantically it's not really accurate either since that 
color is for warning or unusual states. Maybe it should just be blue like 
`emblem-added` is?
  
  
  Here's how that looks: F6349192: Screenshot_20181024_234540.png 

  
  > 
  > 
  > In D16421#348361 , @ndavis wrote:
  > 
  >> > Another thing is the `emblem-symbolic-link` icon. It's the only 
common-ish one that doesn't follow the pattern of having a colored background 
with a border, which might muddy the design language you've chosen (which I 
love).
  >>
  >> You're right, but I also like how the chain link looks. How is this? 
F6349126: Screenshot_20181024_222138.png 
  > 
  > 
  > With that, it doesn't look so much like a chain link anymore because the 
two sides of it are so close together. Could we basically use the existing 
chain link shape but put it within a background? Maybe it doesn't even need to 
be square; it could be rectangular, or even pill-shaped.
  
  The problem with changing `emblem-symbolic-link` to have a background is that 
it doesn't shrink down very well. You have to distort it to make it fit at all 
and retain the same look. At 8px, it's simply impossible to make the middle 
section of the chain without needing to use up the entire horizontal width.
  Here's another attempt:
  F6349199: Screenshot_20181024_235038.png 

  
  F6349201: Screenshot_20181024_235027.png 

  
  F6349203: Screenshot_20181024_235012.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added a comment.


  In D16421#348361 , @ndavis wrote:
  
  > I agree with you, but I also don't like the look of orange. It's just not a 
color that I would expect. I would be OK with making `emblem-added` and 
`emblem-remove` grey like the reporter (Tyson Tan) from bug#399968 asked for, 
but I don't know if that would work well for programs besides Dolphin.
  >  Here's what orange would look like:
  >  F6349094: Screenshot_20181024_215403.png 

  
  
  Yeah I understand. I'm not the hugest fan of the orange either, and now that 
I think about it, semantically it's not really accurate either since that color 
is for warning or unusual states. Maybe it should just be blue like 
`emblem-added` is?
  
  In D16421#348361 , @ndavis wrote:
  
  > > Another thing is the `emblem-symbolic-link` icon. It's the only 
common-ish one that doesn't follow the pattern of having a colored background 
with a border, which might muddy the design language you've chosen (which I 
love).
  >
  > You're right, but I also like how the chain link looks. How is this? 
F6349126: Screenshot_20181024_222138.png 
  
  
  With that, it doesn't look so much like a chain link anymore because the two 
sides of it are so close together. Could we basically use the existing chain 
link shape but put it within a background? Maybe it doesn't even need to be 
square; it could be rectangular, or even pill-shaped.
  
  >> Since this fixes all three bugs, you can replace
  >> 
  >>   https://bugs.kde.org/show_bug.cgi?id=399356
  >>   https://bugs.kde.org/show_bug.cgi?id=399357
  >>   https://bugs.kde.org/show_bug.cgi?id=399968
  >> 
  >> 
  >> with
  >> 
  >>   BUG: 399356
  >>   BUG: 399357
  >>   BUG: 399968
  >>   FIXED-IN: 5.52
  > 
  > You mean I should change the summary to say that?
  
  Exactly!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis added a comment.


  In D16421#348347 , @ngraham wrote:
  
  > Wow, these are truly excellent. I think you've done an amazing job!
  
  
  Thanks!
  
  > One thing I'd like to discuss is whether or not we want the `emblem-remove` 
icon to be red. This color is typically reserved for destructive actions and 
error conditions, and the emblem as far as I can tell is only used in 
Dolphin--where its usage denotes something that is neither destructive nor an 
error. Users might be worried that clicking on it will actually remove the 
item! I wonder if a the Icon Orange color might be more suitable. What do you 
think?
  
  I agree with you, but I also don't like the look of orange. It's just not a 
color that I would expect. I would be OK with making `emblem-added` and 
`emblem-remove` grey like the reporter (Tyson Tan) from bug#399968 asked for, 
but I don't know if that would work well for programs besides Dolphin.
  Here's what orange would look like:
  F6349094: Screenshot_20181024_215403.png 

  
  > Another thing is the `emblem-symbolic-link` icon. It's the only common-ish 
one that doesn't follow the pattern of having a colored background with a 
border, which might muddy the design language you've chosen (which I love).
  
  You're right, but I also like how the chain link looks. How is this? 
F6349126: Screenshot_20181024_222138.png 
  
  > Also, I don't think the filled-in background really works: F6349078: link 
icon.png 
  
  That's fair and after using it for a little while, it's actually pretty bad 
with the dark theme. I just saw D16307 , so 
it seems to be unnecessary anyway.
  
  > Since this fixes all three bugs, you can replace
  > 
  >   https://bugs.kde.org/show_bug.cgi?id=399356
  >   https://bugs.kde.org/show_bug.cgi?id=399357
  >   https://bugs.kde.org/show_bug.cgi?id=399968
  > 
  > 
  > with
  > 
  >   BUG: 399356
  >   BUG: 399357
  >   BUG: 399968
  >   FIXED-IN: 5.52
  
  You mean I should change the summary to say that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Nathaniel Graham]

ngraham added subscribers: bcooksley, ngraham.
ngraham added a comment.


  Wow, these are truly excellent. I think you've done an amazing job!
  
  One thing I'd like to discuss is whether or not we want the `emblem-remove` 
icon to be red. This color is typically reserved for destructive actions and 
error conditions, and the emblem as far as I can tell is only used in 
Dolphin--where its usage denotes something that is neither destructive nor an 
error. Users might be worried that clicking on it will actually remove the 
item! I wonder if a the Icon Orange color might be more suitable. What do you 
think?
  
  Another thing is the `emblem-symbolic-link` icon. It's the only common-ish 
one that doesn't follow the pattern of having a colored background with a 
border, which might muddy the design language you've chosen (which I love). 
Also, I don't think the filled-in background really works: F6349078: link 
icon.png 
  
  Just throwing out some discussion points, but those are pretty minor and 
overall this is already a big improvement IMHO.
  
  ---
  
  Since this fixes all three bugs, you can replace
  
https://bugs.kde.org/show_bug.cgi?id=399356
https://bugs.kde.org/show_bug.cgi?id=399357
https://bugs.kde.org/show_bug.cgi?id=399968
  
  with
  
BUG: 399356
BUG: 399357
BUG: 399968
FIXED-IN: 5.52
  
  ---
  
  Unfortunately, the patch does not apply cleanly, and I don't think it's your 
fault:
  
arc patch D16421

[...]

Checking patch icons/emblems/22/emblem-pause.svg...
Checking patch icons/emblems/22/emblem-mounted.svg...
Checking patch dev/null => icons/emblems/22/emblem-locked.svg...
error: dev/null: does not exist in index
Checking patch icons/emblems/22/emblem-information.svg...
Checking patch icons/emblems/22/emblem-important.svg...
Checking patch dev/null => icons/emblems/22/emblem-favorite.svg...
error: dev/null: does not exist in index
Checking patch icons/emblems/22/emblem-error.svg...
Checking patch icons/emblems/22/emblem-encrypted-unlocked.svg...
[...]
Checking patch icons-dark/emblems/22/emblem-mounted.svg...
Checking patch dev/null => icons-dark/emblems/22/emblem-locked.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/emblems/22/emblem-information.svg...
Checking patch icons-dark/emblems/22/emblem-important.svg...
Checking patch dev/null => icons-dark/emblems/22/emblem-favorite.svg...
error: dev/null: does not exist in index
Checking patch icons-dark/emblems/22/emblem-error.svg...
Checking patch icons-dark/emblems/22/emblem-encrypted-unlocked.svg...
  
  What's going on here is that some symlinks are being replaced with new files, 
and other files are being replaced with symlinks. `arc` doesn't seem too happy 
about this. @bcooksley or anyone else from #sysadmin 
, any idea what to do here?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16421

To: ndavis, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Added outlines to 16 and 22 px icons
  Improved the legibility of 8px icons
  Added new 8, 16 and 22 px versions of existing emblems
  Improved the consistency of emblem icons
  
  Related bugs:
  https://bugs.kde.org/show_bug.cgi?id=399356
  https://bugs.kde.org/show_bug.cgi?id=399357
  https://bugs.kde.org/show_bug.cgi?id=399968

REPOSITORY
  R266 Breeze Icons

BRANCH
  emblem-outlines (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16421

AFFECTED FILES
  icons-dark/emblems/16/checkmark.svg
  icons-dark/emblems/16/emblem-added.svg
  icons-dark/emblems/16/emblem-checked.svg
  icons-dark/emblems/16/emblem-encrypted-unlocked.svg
  icons-dark/emblems/16/emblem-error.svg
  icons-dark/emblems/16/emblem-favorite.svg
  icons-dark/emblems/16/emblem-important.svg
  icons-dark/emblems/16/emblem-information.svg
  icons-dark/emblems/16/emblem-locked.svg
  icons-dark/emblems/16/emblem-mounted.svg
  icons-dark/emblems/16/emblem-pause.svg
  icons-dark/emblems/16/emblem-question.svg
  icons-dark/emblems/16/emblem-remove.svg
  icons-dark/emblems/16/emblem-shared.svg
  icons-dark/emblems/16/emblem-success.svg
  icons-dark/emblems/16/emblem-symbolic-link.svg
  icons-dark/emblems/16/emblem-unavailable.svg
  icons-dark/emblems/16/emblem-unlocked.svg
  icons-dark/emblems/16/emblem-unmounted.svg
  icons-dark/emblems/16/emblem-warning.svg
  icons-dark/emblems/16/rating-unrated.svg
  icons-dark/emblems/16/rating.svg
  icons-dark/emblems/16/vcs-added.svg
  icons-dark/emblems/16/vcs-conflicting.svg
  icons-dark/emblems/16/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/16/vcs-locally-modified.svg
  icons-dark/emblems/16/vcs-normal.svg
  icons-dark/emblems/16/vcs-removed.svg
  icons-dark/emblems/16/vcs-update-required.svg
  icons-dark/emblems/22/checkmark.svg
  icons-dark/emblems/22/emblem-added.svg
  icons-dark/emblems/22/emblem-checked.svg
  icons-dark/emblems/22/emblem-encrypted-unlocked.svg
  icons-dark/emblems/22/emblem-error.svg
  icons-dark/emblems/22/emblem-favorite.svg
  icons-dark/emblems/22/emblem-important.svg
  icons-dark/emblems/22/emblem-information.svg
  icons-dark/emblems/22/emblem-locked.svg
  icons-dark/emblems/22/emblem-mounted.svg
  icons-dark/emblems/22/emblem-pause.svg
  icons-dark/emblems/22/emblem-question.svg
  icons-dark/emblems/22/emblem-remove.svg
  icons-dark/emblems/22/emblem-shared.svg
  icons-dark/emblems/22/emblem-success.svg
  icons-dark/emblems/22/emblem-symbolic-link.svg
  icons-dark/emblems/22/emblem-unavailable.svg
  icons-dark/emblems/22/emblem-unlocked.svg
  icons-dark/emblems/22/emblem-unmounted.svg
  icons-dark/emblems/22/emblem-warning.svg
  icons-dark/emblems/22/rating-unrated.svg
  icons-dark/emblems/22/rating.svg
  icons-dark/emblems/22/vcs-added.svg
  icons-dark/emblems/22/vcs-conflicting.svg
  icons-dark/emblems/22/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/22/vcs-locally-modified.svg
  icons-dark/emblems/22/vcs-normal.svg
  icons-dark/emblems/22/vcs-removed.svg
  icons-dark/emblems/22/vcs-update-required.svg
  icons-dark/emblems/8/emblem-added.svg
  icons-dark/emblems/8/emblem-checked.svg
  icons-dark/emblems/8/emblem-encrypted-unlocked.svg
  icons-dark/emblems/8/emblem-error.svg
  icons-dark/emblems/8/emblem-favorite.svg
  icons-dark/emblems/8/emblem-important.svg
  icons-dark/emblems/8/emblem-information.svg
  icons-dark/emblems/8/emblem-locked.svg
  icons-dark/emblems/8/emblem-mounted.svg
  icons-dark/emblems/8/emblem-pause.svg
  icons-dark/emblems/8/emblem-question.svg
  icons-dark/emblems/8/emblem-remove.svg
  icons-dark/emblems/8/emblem-shared.svg
  icons-dark/emblems/8/emblem-symbolic-link.svg
  icons-dark/emblems/8/emblem-unavailable.svg
  icons-dark/emblems/8/emblem-unlocked.svg
  icons-dark/emblems/8/emblem-unmounted.svg
  icons-dark/emblems/8/emblem-warning.svg
  icons-dark/emblems/8/rating-unrated.svg
  icons-dark/emblems/8/rating.svg
  icons-dark/emblems/8/vcs-added.svg
  icons-dark/emblems/8/vcs-conflicting.svg
  icons-dark/emblems/8/vcs-locally-modified-unstaged.svg
  icons-dark/emblems/8/vcs-locally-modified.svg
  icons-dark/emblems/8/vcs-normal.svg
  icons-dark/emblems/8/vcs-removed.svg
  icons-dark/emblems/8/vcs-update-required.svg
  icons/emblems/16/checkmark.svg
  icons/emblems/16/emblem-added.svg
  icons/emblems/16/emblem-checked.svg
  icons/emblems/16/emblem-encrypted-unlocked.svg
  icons/emblems/16/emblem-error.svg
  icons/emblems/16/emblem-favorite.svg
  icons/emblems/16/emblem-important.svg
  icons/emblems/16/emblem-information.svg
  icons/emblems/16/emblem-locked.svg
  icons/emblems/16/emblem-mounted.svg
  icons/emblems/16/emblem-pause.svg
  icons/emblems/16/emblem-question.svg
  icons/emblems/16/emblem-remove.svg
  icons/emblems/16/emblem-shared.svg
  icons/emblems/16/emblem-success.svg