[chromium-dev] waterfall and memory tests

2010-01-17 Thread Nicolas Sylvain
Hi, The number of memory tests bots has been increasing rapidly recently, and since the main buildbot console view was getting too big and slow, I decided to move the memory tests in their own buildbot master. HOWEVER, this does not indicate in any ways that they are less important. On http://bui

Re: [chromium-dev] Red Tree 2010/1/6

2010-01-07 Thread Nicolas Sylvain
On Thu, Jan 7, 2010 at 11:22 AM, James Robinson wrote: > Thanks a lot, Chase. > > When will it become feasible to run the perf tests as part of the WebKit > canary process? We seem to have all the code necessary to catch these > regressions at the exact WebKit revision that causes them. > We've

Re: [chromium-dev] LATEST symlink missing for win builds

2010-01-06 Thread Nicolas Sylvain
On Wed, Jan 6, 2010 at 3:32 PM, Kenneth Russell wrote: > It looks like the LATEST symlink was deleted out of the directory > http://build.chromium.org/buildbot/continuous/win/ . It's there for > Mac and Linux. Could someone please take a look? > It should be fixed now. Feel free to send me a pri

Re: [chromium-dev] buildbot cycle time dashboard?

2009-12-14 Thread Nicolas Sylvain
On Tue, Dec 8, 2009 at 3:00 PM, James Hawkins wrote: > Thanks for the link Eric! Can someone explain what the "Percentage of > failures" graph is representing? > # failed build / # total builds. (over the last 300 builds). if it's 10, then that means that in the last 300 builds, 10% of them w

Re: [chromium-dev] gcl commit throwing SVN server error

2009-12-04 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 4:03 PM, Dan Kegel wrote: > If you're a committer, you should have recieved instructions on how > to set up your client (it will have an svn rather than an http url) > when you got your commit password. > Or for new people to the team, your mentor should guide you through

[chromium-dev] Re: Something smells weird on the buildbot

2009-12-03 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 10:25 AM, Ojan Vafai wrote: > On Thu, Dec 3, 2009 at 10:21 AM, Dimitri Glazkov > wrote: > > How about we turn red for unexpected crashiness? >> > > Makes sense to me. We can just not retry tests that unexpectedly crash. > > On Thu, Dec 3, 2009 at 10:09 AM, Dirk Pranke wr

[chromium-dev] Re: Something smells weird on the buildbot

2009-12-03 Thread Nicolas Sylvain
On Thu, Dec 3, 2009 at 10:09 AM, Dimitri Glazkov wrote: > On Thu, Dec 3, 2009 at 10:07 AM, Ojan Vafai wrote: > > +chromium-dev as others who look at the waterfall might also be confused. > > On Thu, Dec 3, 2009 at 8:50 AM, Dimitri Glazkov > wrote: > >> > >> Sending out random people, because it'

[chromium-dev] GTTF: results. WAS: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-12-02 Thread Nicolas Sylvain
Hi, It looks like our discussion here helped a lot. The tree has never been that green. In the past 6 months, we averaged at about 60-65% tree open during work hours (pacific time). But in the last month, we are at about 85-90%. This is really great! Thanks to all the sheriffs! I attached a gra

Re: [chromium-dev] [GTTF] running tests that fail most often early in the queue

2009-11-19 Thread Nicolas Sylvain
On Thu, Nov 19, 2009 at 10:48 AM, Paweł Hajdan jr wrote: > Nicolas, what do you think about applying the reordering to our bots? we should do it. > > > On Thu, Nov 12, 2009 at 20:10, Pam Greene wrote: > >> On Thu, Nov 12, 2009 at 1:52 AM, Paweł Hajdan Jr. >>> wrote: >>> > I was just looking at

Re: [chromium-dev] Status of Linux 64 Memory Tests?

2009-11-11 Thread Nicolas Sylvain
>From irc: I've only narrowed the webkit roll down by half, compile problems I have to look at more closely - badness is after 50610 and before 50633 Steve: Maybe we should disable the test while you work on it? Nicolas On Wed, Nov 11, 2009 at 8:49 AM, Anthony LaForge wrote: > It's seems the

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
On Wed, Nov 4, 2009 at 12:16 PM, Peter Kasting wrote: > On Wed, Nov 4, 2009 at 12:08 PM, James Robinson wrote: > >> I don't see who this benefits - assuming that a given patch is broken and >> needs a small delta to be correct, it's just as easy to submit a patch with >> a small delta as it is t

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
On Wed, Nov 4, 2009 at 11:40 AM, Peter Kasting wrote: > On Tue, Nov 3, 2009 at 6:05 PM, John Abd-El-Malek wrote: > >> But this means that the person didn't use the trybot. >> >> I think we need to be harsher on people who commit with changes that >> didn't complete or failed on the trybot. >> > >

[chromium-dev] Re: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
;>> Interesting. WebKit has similar functionality as: >>> bugzilla-tool rollout 12345 >>> >>> We've found that git reverts are at least an order of magnitude faster >>> than SVN reverse merges. >>> >>> I wonder what bugzilla-tool/dr

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-04 Thread Nicolas Sylvain
hrough other means in the debug version. No, they do not currently build the release version. Nicolas > > -atw > > > On Tue, Nov 3, 2009 at 7:30 PM, Nicolas Sylvain wrote: > >> >> >> On Tue, Nov 3, 2009 at 7:46 PM, Kenneth Russell wrote: >> >>&g

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
On Tue, Nov 3, 2009 at 7:46 PM, Kenneth Russell wrote: > On Tue, Nov 3, 2009 at 6:05 PM, John Abd-El-Malek > wrote: > > But this means that the person didn't use the trybot. > > I think we need to be harsher on people who commit with changes that > didn't > > complete or failed on the trybot. T

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
+1 On Tue, Nov 3, 2009 at 3:38 PM, Avi Drissman wrote: > I'm OK with that. > > Just make it clear that the sheriff does have authority. One time when I > was sheriff I wanted to revert a broken patch. The author insisted on > patching it over and over. He finally got it working about about seven

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
d a clobber. We can't just blindly revert changes. Nicolas > > On Tue, Nov 3, 2009 at 2:52 PM, Nicolas Sylvain > wrote: > > +1 > > > > On Tue, Nov 3, 2009 at 3:38 PM, Avi Drissman wrote: > >> > >> I'm OK with that. > >> > &g

[chromium-dev] Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
Hi One of the goal of the Green Tree Task Force was to make reverting a change easy and fast. This is really important to keep the tree green and open. The old saying is "Revert now, think later"... If a change broke the build and the fix would take more than 1 or 2 minutes to be committed, or if

[chromium-dev] Re: revert now, ask questions later? WAS: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
On Tue, Nov 3, 2009 at 7:08 PM, Ben Goodger (Google) wrote: > I am supportive of auto-revert as long as we apply it universally. So many > times the tree has been busted forever because of a vacuum of action by the > sheriff. > > Also FYI - the trybots never work for me on my home system. No idea

[chromium-dev] Re: Reverting a change, the fast way

2009-11-03 Thread Nicolas Sylvain
that this is still the case. > Good point, it should have a way to specify which url it should use to checkout from. by default it uses the internal url. I'll try to find a way to fix that. Nicolas > > On Tue, Nov 3, 2009 at 1:53 PM, Nicolas Sylvain > wrote: > > Hi &g

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

2009-10-24 Thread Nicolas Sylvain
On Fri, Oct 23, 2009 at 2:16 PM, Andrew Scherkus wrote: > On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain > wrote: > >> >> >> On Fri, Oct 23, 2009 at 12:21 PM, Andrew Scherkus >> wrote: >> >>> I've never witnessed these tests taki

[chromium-dev] Re: revising the output from run_webkit_tests

2009-10-23 Thread Nicolas Sylvain
On Fri, Oct 23, 2009 at 3:43 PM, Dirk Pranke wrote: > > If you've never run run_webkit_tests to run the layout test > regression, or don't care about it, you can stop reading ... > > If you have run it, and you're like me, you've probably wondered a lot > about the output ... questions like: > >

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

2009-10-23 Thread Nicolas Sylvain
ings by maxing out my CPU then > running layout tests but even then they run smoothly. > This machine is one of the oldest linux machine we have in the lab. I'll recreate it, make sure it run fast, and see if it helps. Nicolas > Andrew > > On Fri, Oct 23, 2009 at 12:02 PM, Nicola

[chromium-dev] Re: Flaky layout tests and WebKit Linux (dbg)(3)

2009-10-23 Thread Nicolas Sylvain
On Fri, Oct 23, 2009 at 11:59 AM, Andrew Scherkus wrote: > I've been trying to get the media layout tests passing consistently, but > WebKit Linux (dbg)(3) takes an absurdly longer time to run tests and I don't > know why. > For example: > > http://src.chromium.org/viewvc/chrome/trunk/src/webkit/t

[chromium-dev] Re: New Tab Cold 20% perf regression on xp-release

2009-10-16 Thread Nicolas Sylvain
On Fri, Oct 16, 2009 at 2:35 PM, Erik Arvidsson wrote: > > The performance for New Tab Cold has regressed without about 20% > sometime before rev28918. > This seems to be when i changed the hardware where this test is running. Where is the reference build? Nicolas > > > http://build.chromium.o

[chromium-dev] Re: layout test dashboard goofup

2009-10-14 Thread Nicolas Sylvain
On Wed, Oct 14, 2009 at 4:53 PM, Ojan Vafai wrote: > The data is stored in a single file per bot. For example, the webkit > release bot's results are at > http://build.chromium.org/buildbot/layout_test_results/webkit-rel/results.json. > That > file holds all the historical data for that bot and

[chromium-dev] Re: [LTTF][WebKit Gardening]: Keeping up with the weeds.

2009-10-13 Thread Nicolas Sylvain
On Tue, Oct 13, 2009 at 10:45 AM, Peter Kasting wrote: > On Tue, Oct 13, 2009 at 10:43 AM, Dimitri Glazkov > wrote: > >> Let's not conflate the two. There are flakes, and there are clearly, >> consistently failing tests, arriving in chunks every day via WebKit >> rolls. > > > OK, I'm just saying

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
On Mon, Oct 12, 2009 at 7:58 AM, Thomas Van Lenten wrote: > > > On Mon, Oct 12, 2009 at 10:45 AM, Nicolas Sylvain > wrote: > >> >> >> On Sun, Oct 11, 2009 at 6:50 PM, Thomas Van Lenten > > wrote: >> >>> Looks like the failures link needs to b

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
On Sun, Oct 11, 2009 at 6:50 PM, Thomas Van Lenten wrote: > Looks like the failures link needs to be updated in waterfall header. I'm pretty sure I did, can you show me which one is not updated? > > TVL > > > On Sat, Oct 10, 2009 at 9:25 PM, Nicolas Sylvain wrote:

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
json=213 > > Kind Regards, > > Anthony Laforge > Technical Program Manager > Mountain View, CA > > > On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain wrote: > >> Hello, >> Today I upgraded buildbot to the latest version. >> >> If you have a bo

[chromium-dev] Re: Buildbot upgrade

2009-10-12 Thread Nicolas Sylvain
s > > On Sat, Oct 10, 2009 at 6:25 PM, Nicolas Sylvain wrote: > >> Hello, >> Today I upgraded buildbot to the latest version. >> >> If you have a bookmark for the "failures only" waterfall, you will need to >> change it. Previously it >> was "

[chromium-dev] Buildbot upgrade

2009-10-10 Thread Nicolas Sylvain
Hello, Today I upgraded buildbot to the latest version. If you have a bookmark for the "failures only" waterfall, you will need to change it. Previously it was "failures=1" and it is now "show_events=true&failures_only=true" Other than that, nothing should have changed. If you see any issues with

[chromium-dev] Re: How to deal with flaky unit tests

2009-10-07 Thread Nicolas Sylvain
Oct 6, 2009 at 5:02 PM, Nicolas Sylvain wrote: > >> Hello, >> We currently have more than 50 unit tests that are disabled. Most of them >> because they were flaky. >> >> Disabling tests is bad because we lose complete coverage on them, so I >> implemented a way to ma

[chromium-dev] How to deal with flaky unit tests

2009-10-06 Thread Nicolas Sylvain
Hello, We currently have more than 50 unit tests that are disabled. Most of them because they were flaky. Disabling tests is bad because we lose complete coverage on them, so I implemented a way to mark tests as "flaky". The same way you disable a test with DISABLED_ at the beginning of its name,

[chromium-dev] Re: gclient fails to update gyp files

2009-10-01 Thread Nicolas Sylvain
On Tue, Sep 29, 2009 at 11:37 AM, Chris Guillory wrote: > Dominic and I starting running into this today also. We both don't have the > src/native_client directory. And I don't see it listed in the directory list > at http://src.chromium.org/svn/trunk/src/. gclient update will fetch it since it'

[chromium-dev] Re: gclient fails to update gyp files

2009-09-29 Thread Nicolas Sylvain
you need to edit your .gclient and remove the line that says: "src/native_client": None Is native_client really required? Why? We don't want to build this by default, do we? it's too big and it does not fit in the tarball, so it has been excluded there. Nicolas On Tue, Sep 29, 2009 at 12:40 P

[chromium-dev] Re: src.chromium.org is down

2009-09-29 Thread Nicolas Sylvain
The server has been stable enough in the last 20 minutes, so I think it is fixed now. If you have problems with the server today, please let me know. Thanks Nicolas On Tue, Sep 29, 2009 at 7:45 AM, Nicolas Sylvain wrote: > src.chromium.org is down for a few minutes... while we try to fix

[chromium-dev] src.chromium.org is down

2009-09-29 Thread Nicolas Sylvain
src.chromium.org is down for a few minutes... while we try to fix the disk error. Sorry for the inconvenience, Nicolas --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: h

[chromium-dev] Re: Webkit merges and tree closures

2009-09-23 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 10:47 PM, David Levin wrote: > Actionable items for keeping the tree green (in addition to blaming the > WebKit gardener for [insert action here]): > >- *Get people putting in chromium patches upstream to run their changes >through trybots, etc*. imo, patches from

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-23 Thread Nicolas Sylvain
On Wed, Sep 23, 2009 at 8:55 AM, Paweł Hajdan Jr. wrote: > On Tue, Sep 22, 2009 at 18:06, Dimitri Glazkov wrote: > >> Today wasn't a happy day for p...@. He did a seemingly innocuous roll >> that broke the world: selenium, ui tests, layout tests. I am sure it >> was stressful and probably added un

[chromium-dev] Re: WebKit Hygiene: Please be kind. Test your patches. Warn about two-sided patches.

2009-09-22 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 6:35 PM, Adam Barth wrote: > > On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek > wrote: > > Is this even possible? i.e. I had uploaded a WebKit patch on codereview > but > > none of the patchsets got run on the try server > > http://codereview.chromium.org/178030/show

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Nicolas Sylvain
. Nicolas > J > > On Tue, Sep 22, 2009 at 5:50 PM, Paweł Hajdan Jr. > wrote: > >> On Tue, Sep 22, 2009 at 17:40, Nicolas Sylvain wrote: >> >>> 3 PM : two failing ui tests are disabled by the webkit sheriff >>> >> >> I was looking at the UI

[chromium-dev] Re: Webkit merges and tree closures

2009-09-22 Thread Nicolas Sylvain
On Tue, Sep 22, 2009 at 6:08 PM, Adam Barth wrote: > On Tue, Sep 22, 2009 at 5:40 PM, Nicolas Sylvain > wrote: > > If this is an issue, I am proposing that Webkit merges be done outside > peak > > hours (11am-5pm pacific). > > This seems backwards. Don't we wa

[chromium-dev] Webkit merges and tree closures

2009-09-22 Thread Nicolas Sylvain
Hi, In the last few weeks I've been trying to be aware as much as possible about the reasons we close the tree, and my gut feeling seems to match what I'm seeing: Webkit merges is the main cause. Now, I understand that Webkit merges are not easy, and really, kudos to the team for keeping up with t

[chromium-dev] Re: debugging the browser started by UI tests

2009-09-22 Thread Nicolas Sylvain
On windows just use windbg, and tell it to attach to child processes. I can show you if you want. Nicolas On Tue, Sep 22, 2009 at 4:10 PM, Scott Violet wrote: > > WAIT_FOR_DEBUGGER_ON_OPEN predates the Linux port. It may work on > Linux, I just haven't tried it. > > -Scott > > On Tue, Sep 22,

[chromium-dev] Re: [Green Tree] Week 1

2009-09-22 Thread Nicolas Sylvain
o implement some alert mechanism. Nicolas > > On Mon, Sep 21, 2009 at 10:31 AM, Jeremy Orlow wrote: > >> On Mon, Sep 21, 2009 at 8:25 AM, Nicolas Sylvain >> wrote: >> >>> Hi chromium-dev, >>> A small group of us joined forces to create a "Green T

[chromium-dev] Re: [Green Tree] Week 1

2009-09-21 Thread Nicolas Sylvain
on, Sep 21, 2009 at 8:25 AM, Nicolas Sylvain > wrote: > > Hi chromium-dev, > > A small group of us joined forces to create a "Green Tree" task force. > The > > goal of this task > > force is to make sure the tree stays green most of the time. The 2 main >

[chromium-dev] [Green Tree] Week 1

2009-09-21 Thread Nicolas Sylvain
Hi chromium-dev, A small group of us joined forces to create a "Green Tree" task force. The goal of this task force is to make sure the tree stays green most of the time. The 2 main pain points that we are attacking at this time are "reducing the buildbot cycle time", to catch errors earlier, an

[chromium-dev] Re: Is it possible to run Chromium in a Windows Job?

2009-09-18 Thread Nicolas Sylvain
On Thu, Sep 17, 2009 at 6:25 PM, Marc-Antoine Ruel wrote: > > There are issues with the sandbox because it is creating the renderer > and plugin processes in a job object. > > I recall runas has issues too because of the CREATE_BREAKAWAY_FROM_JOB > flag is not working. > This is right. When you c

[chromium-dev] Re: Missing symbols for Chrome 2.0.172.43

2009-09-14 Thread Nicolas Sylvain
Symbols are being copied. If it still does not work for you, let us know. Thanks Nicolas On Mon, Sep 14, 2009 at 10:00 AM, Huan Ren wrote: > On Sat, Sep 12, 2009 at 5:49 PM, yuhong wrote: > > > > Yes, notice the symbol path that begins with > http://build.chromium.org/buildbot/symsrv/. > > >

[chromium-dev] Re: Argh: Rebuilding installer_util on every F5

2009-09-09 Thread Nicolas Sylvain
+maruel, who changed this code yesterday Nicolas On Wed, Sep 9, 2009 at 5:29 PM, Peter Kasting wrote: > Somehow, starting today, I'm now rebuilding installer_util (recompiling a > half dozen files, which then causes me to relink chrome.dll) every time I > hit F5. Deleting chrome.{ncb,suo} and r

[chromium-dev] Re: linux startup regression

2009-09-03 Thread Nicolas Sylvain
[from my @chromium.org this time] In theory this is not required, because a more recent (or older) startup_test binary should be able to drive any chrome binary. I think it's fair to assume that the regression is not in startup_test directly, but in chrome. On Thu, Sep 3, 2009 at 9:50 AM, Michael

[chromium-dev] Re: The webkit canary bots, now with performance tests!

2009-08-27 Thread Nicolas Sylvain
And now it is also running test_shell_tests in purify and valgrind: http://build.chromium.org/buildbot/waterfall.fyi/waterfall?branch=&builder=Webkit+(purify+webkit.org)&builder=Webkit+Linux+(valgrind+webkit.org)

[chromium-dev] Re: Problem with try servers?

2009-08-27 Thread Nicolas Sylvain
On Thu, Aug 27, 2009 at 3:17 AM, Ben Laurie wrote: > > If I do a gcl try, I get prompted for a password for 'ben', which is > my login name on my FreeBSD machine. Whatever I enter, the script then > hangs - investigation shows that this is because it is prompting for a > username, but gcl is swal

[chromium-dev] Splitting up chrome.dll

2009-08-25 Thread Nicolas Sylvain
Hello, In the past a lot of you have asked to split up chrome.dll in multiple DLLs. For this quarter, I had a goal to see how feasible this is. Background information: Breaking up chrome.dll would make linking time faster and use less memory. It would also enforce a cleaner cut between our modul

[chromium-dev] Re: fighting the test flakiness

2009-08-24 Thread Nicolas Sylvain
phajdan: Feel free to add a link at the top of the waterfall. Maybe beside "perf" at the top left corner. You just need to edit http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/master.chromium/public_html/announce.html?view=markup

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-10 Thread Nicolas Sylvain
On Mon, Aug 10, 2009 at 10:35 AM, Jeremy Orlow wrote: > On Mon, Aug 10, 2009 at 9:59 AM, Ojan Vafai wrote: > >> On Mon, Aug 10, 2009 at 3:12 AM, Jeremy Orlow wrote: >> >>> On Sun, Aug 9, 2009 at 9:07 AM, Nicolas Sylvain >>> wrote: >>> >>&g

[chromium-dev] Re: Stack traces on layout test crashes

2009-08-09 Thread Nicolas Sylvain
Some things to consider: 1. On windows, breakpad used to be wired in test_shell. And I'm pretty sure we used to archive crash dumps for the layout tests too. It should not be hard to do that again. Huan also write a nice script to dump to stdio the crashing stacks of all crashes that happened in a

[chromium-dev] Re: flaky compilation of sandbox on Vista

2009-08-07 Thread Nicolas Sylvain
On Fri, Aug 7, 2009 at 11:02 AM, Paweł Hajdan Jr. wrote: > Example: > http://build.chromium.org/buildbot/waterfall/builders/Modules%20Vista%20(dbg)/builds/13568/steps/compile_3/logs/stdio > C:\Windows\system32\cmd.exe /c src\third_party\python_24\python_slave.exe > ..\..\..\scripts\slave\compile.p

[chromium-dev] Re: Running UI test in parallel (experimental)

2009-08-06 Thread Nicolas Sylvain
On Thu, Aug 6, 2009 at 1:06 PM, John Abd-El-Malek wrote: > This is very cool, but I ran into a few problems when I tried to run it: > a:\chrome2\src\chrome>tools\test\smoketests.py --tests=ui > > >> You must have your local path of trunk/src/tools/python added to your > PYTHONPATH.<< > > Tracebac

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Nicolas Sylvain
On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet wrote: > > Not sure, perhaps Huan could answer that. That said, --enable-dcheck > certainly works on the Chromium release builds from the buildbot: > http://build.chromium.org/buildbot/continuous/LATEST/ . Yes, --enable-dcheck is supposed to be disab

[chromium-dev] Re: fighting the flakiness - resource bundle issues?

2009-07-28 Thread Nicolas Sylvain
On Tue, Jul 28, 2009 at 4:37 PM, Evan Martin wrote: > > On Tue, Jul 28, 2009 at 4:35 PM, Paweł Hajdan > Jr. wrote: > > On Tue, Jul 28, 2009 at 16:30, Evan Martin wrote: > >> > >> This happens semi-frequently. It's related to the grit resources > >> rebuilding. Something like: not remapping IDR

[chromium-dev] Re: fighting the flakiness - resource bundle issues?

2009-07-24 Thread Nicolas Sylvain
, so it will rebuild correctly that part). I guess someone should try it ;) Nicolas > > On Fri, Jul 24, 2009 at 11:00 AM, Nicolas Sylvain > wrote: > > Tony, just to make sure, are you certain that this is a IB only issue? > > I used to be convinced that it was happening with vi

[chromium-dev] Re: fighting the flakiness - resource bundle issues?

2009-07-24 Thread Nicolas Sylvain
Tony, just to make sure, are you certain that this is a IB only issue? I used to be convinced that it was happening with visual studio too. If this is a IB only problem, we should create a repro case and send it to them, they are usually really responsive. [For some reasons, I thought it was beca

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Nicolas Sylvain
On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin wrote: > On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvain > wrote: > > gclient has nothing to do with this case. "svn update src/" was trying to > > add a directory called "src/bleh", but "src/bleh&quo

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Nicolas Sylvain
On Wed, Jul 22, 2009 at 9:15 PM, Mark Larson (Google) wrote: > > > On Wed, Jul 22, 2009 at 20:27, Dan Kegel wrote: > >> >> Stop me if you've heard this one before. >> >> Today, a new directory was added to the source tree, and shortly >> thereafter was reverted. >> Should have been no problem, bu

[chromium-dev] Re: FYI: Upcoming O3D integration changes.

2009-07-22 Thread Nicolas Sylvain
On Wed, Jul 22, 2009 at 11:47 AM, Greg Spencer wrote: > > > On Wed, Jul 22, 2009 at 11:27 AM, Nicolas Sylvain > wrote: > >> "src/third_party/nixysa/files": >>> >> why in a subdir called "files"? >> > > A leftover from conver

[chromium-dev] Re: FYI: Upcoming O3D integration changes.

2009-07-22 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 4:30 PM, Greg Spencer wrote: > Hello Chromium Devs, > The O3D team is working on getting O3D integrated into the Chromium build, > and we're close to being able to complete our first step towards > integration: To build the O3D plugin as part of the Chromium code base, an

[chromium-dev] Re: No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 12:18 PM, Erik Kay wrote: > On Tue, Jul 21, 2009 at 11:53 AM, Nicolas Sylvain > wrote: > >> On Tue, Jul 21, 2009 at 11:37 AM, Aaron Boodman wrote: >> >>> Nicolas, >>> >>> Are you going to be turning back on the extensi

[chromium-dev] Re: No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Nicolas Sylvain
on still 30secs? If it can be changed to 2 or 5 minutes I will reenable it. Nicolas > > > - a > > On Tue, Jul 21, 2009 at 8:27 AM, Nicolas Sylvain > wrote: > > Hi, > > Last week a lot of people on this list said that they like the idea of > > disabling the aut

[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!

2009-07-21 Thread Nicolas Sylvain
On Tue, Jul 21, 2009 at 8:31 AM, Paweł Hajdan Jr. wrote: > Can we have a trybot with that configuration, which would just compile the > code? I think it would really save people's time. I never build with > TOOLKIT_VIEWS, and in case of breakage I would have to immediately revert > and then invest

[chromium-dev] Re: Please keep TOOLKIT_VIEWS green!

2009-07-21 Thread Nicolas Sylvain
On Mon, Jul 20, 2009 at 5:50 PM, Ben Goodger (Google) wrote: > > This mostly applies to people working on UI. > > Sometime tonight or tomorrow we'll be moving the TOOLKIT_VIEWS builder > to the front page of the waterfall. Right now it's building just the > chrome target, and running no tests, but

[chromium-dev] No more buildbot auto-refresh - Update your bookmark!

2009-07-21 Thread Nicolas Sylvain
Hi, Last week a lot of people on this list said that they like the idea of disabling the auto-reload for our buildbot waterfall and console view. This is now implemented. If you do want to keep the page auto-refreshing, please update your bookmark. just add the query parameter "reload=X", where X

[chromium-dev] Re: Unable to download Chrome Source Code

2009-07-20 Thread Nicolas Sylvain
On Sat, Jul 18, 2009 at 1:56 AM, Pradeep wrote: > > Hi All, > > From past several days I am trying to download the source code, but > for some reason the download quits after completion of 17 - 18 MB. what is the URL of the file you are downloading? Have you tried other browsers? Does it work

[chromium-dev] Re: Code coverage

2009-07-17 Thread Nicolas Sylvain
get go? > > -Scott > > On Fri, Jul 17, 2009 at 9:37 AM, Nicolas Sylvain > wrote: > > > > > > On Fri, Jul 17, 2009 at 8:39 AM, Scott Violet wrote: > >> > >> I'm interested in seeing code coverage. We have a code coverage page > >> (ht

[chromium-dev] Re: Code coverage

2009-07-17 Thread Nicolas Sylvain
On Fri, Jul 17, 2009 at 8:39 AM, Scott Violet wrote: > > I'm interested in seeing code coverage. We have a code coverage page > (http://build.chromium.org/buildbot/perf/dashboard/coverage.html), but > I can't make heads or tails of this. Is there a page that shows > coverage per file, so that we

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Nicolas Sylvain
On Fri, Jul 17, 2009 at 7:40 AM, Dan Kegel wrote: > On Fri, Jul 17, 2009 at 2:34 PM, Thomas Van Lenten > wrote: > >> We're already running at -O1 on Linux, so there isn't much improvement > >> left to be had, I suspect. It might be worth it, dunno. > > > > There is a lot of code cut out by bein

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Nicolas Sylvain
On Fri, Jul 17, 2009 at 6:48 AM, Thomas Van Lenten wrote: > We've finished the shuffle of the Mac Valgrind bots over to release builds. > It looks like some of the slower tests now run 2x as fast, so the cycles > types seem to be a lot better (fewer cls per cycle). Great! Should we do the same

[chromium-dev] Re: Purify - instrumentation fails on XP Unit (purify) bot

2009-07-16 Thread Nicolas Sylvain
On Thu, Jul 16, 2009 at 1:04 PM, Sverrir Á. Berg wrote: > > http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Unit%20(purify) I cleaned up the machine and restarted it. Sometimes it's enough to make it work. Nicolas

[chromium-dev] Re: Buildbot performance issue.

2009-07-14 Thread Nicolas Sylvain
On Tue, Jul 14, 2009 at 2:25 PM, Evan Martin wrote: > On Tue, Jul 14, 2009 at 2:18 PM, Nicolas Sylvain > wrote: > > The underlying problem with buildbot is the database format, which is > just > > hundred of > > thousand of files on the harddrive, with no "

[chromium-dev] Buildbot performance issue.

2009-07-14 Thread Nicolas Sylvain
Hello, We reached a point where we have too many build slaves and too many users to get good performance/latency out of our current buildbot waterfall and console view page. We've been tweaking the page a lot lately to make it faster to load, but the number of new slaves every day, and the num

[chromium-dev] Re: [chromium-checkins] r20238 - trunk/tools/buildbot/config/master.chromium.fyi

2009-07-09 Thread Nicolas Sylvain
linux2 there is the platform, as in linux with kernel 2.*. >>> import sys >>> print sys.platform linux2 Nicolas On Thu, Jul 9, 2009 at 12:34 AM, PhistucK wrote: > Should this not be changed also?" m_webkit_linux_v8_latest = > chromium_factory.ChromiumFactory('src/build', >

[chromium-dev] Re: running browser_tests on more bots

2009-07-08 Thread Nicolas Sylvain
On Wed, Jul 8, 2009 at 9:42 AM, Paweł Hajdan Jr. wrote: > > I noticed that browser_tests run on the "Chromium XP" buildbot, but I > couldn't see them on other official (non-FYI) buildbots, and they > don't run on trybots. What's blocking us from enabling these tests on > more buildbots? Hmmm. Th

[chromium-dev] Re: Clobber third_party/ffmpeg/binaries before syncing

2009-07-07 Thread Nicolas Sylvain
On Tue, Jul 7, 2009 at 9:05 AM, Erik Kay wrote: > With a gclient sync this morning, it seems very confused about > ffmpeg/binaries. First the sync failed saying that ffmpeg/binaries was from > a different repository. Then I removed the directory and did a sync where > it pulled down ffmpeg/bina

[chromium-dev] Re: Rev 19669 and WebFrame::GetPrintPageShrink()

2009-07-07 Thread Nicolas Sylvain
On Tue, Jul 7, 2009 at 7:25 AM, Marc-Antoine Ruel wrote: > On Mon, Jul 6, 2009 at 6:28 PM, Marshall Greenblatt < > magreenbl...@gmail.com> wrote: > >> On Mon, Jul 6, 2009 at 6:09 PM, Darin Fisher wrote: >> >>> I'm not sure what would be best. I was just describing the problem. It >>> might help

[chromium-dev] Re: Trac

2009-07-01 Thread Nicolas Sylvain
On Wed, Jul 1, 2009 at 7:40 PM, Jeremy Orlow wrote: > Can I do something like this with ViewVC? > http://trac.webkit.org/changeset?new=45...@trunk&old=45...@trunk > Also, > is there any reason we can't implement multiple tools? I

[chromium-dev] Re: WebKit Sheriffing Documentation Update

2009-06-26 Thread Nicolas Sylvain
On Fri, Jun 26, 2009 at 12:10 PM, Amanda Walker wrote: > On Fri, Jun 26, 2009 at 2:42 PM, Ojan Vafai wrote: > > For the layout tests steps, why do you we need to build test_shell > locally, > > rebaseline and then add the other platforms to tests_fixable? Can't we > just > > use the rebaseline to

[chromium-dev] New waterfall mode for sheriffs

2009-06-25 Thread Nicolas Sylvain
Hello, The console view is not the best for sheriffs since it does not show in details the current state of the tree. The waterfall has always been better for that. But since our waterfall is really big, it can be hard to scroll all the time and keep track of all the failures. For that, I modifie

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Nicolas Sylvain
On Thu, Jun 25, 2009 at 7:03 AM, Evan Martin wrote: > On Thu, Jun 25, 2009 at 6:27 AM, Nicolas Sylvain > wrote: > > > > > > On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee > wrote: > >> > >> I just took a look at what was happening on one of the Linux

[chromium-dev] Re: Linux buildbots, which locale?

2009-06-25 Thread Nicolas Sylvain
On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee wrote: > > I just took a look at what was happening on one of the Linux > buildbots. It looks like we completely clear the env and just > explicitly set a few things. We need to add LANG=en_US.UTF-8 to that > list of things. Any takers? I can add

[chromium-dev] Re: Is it possible to do a gclient sync without running hooks?

2009-06-23 Thread Nicolas Sylvain
On Tue, Jun 23, 2009 at 5:53 PM, Daniel Cowx wrote: > > When I run "gclient sync", it automatically runs the hooks; which > causes various non-versioned files to get generated within my tree > (most notably *.vcproj and *.sln files, but there may be others). I'd > like to be able to do a sync *wi

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Nicolas Sylvain
On Fri, Jun 19, 2009 at 11:15 AM, Mike Pinkerton wrote: > On Fri, Jun 19, 2009 at 2:11 PM, Peter Kasting wrote: > > On Fri, Jun 19, 2009 at 11:07 AM, Nicolas Sylvain > > > wrote: > >> > >> We should say that we prefer "#if defined(OS_WIN)" over &qu

[chromium-dev] Re: Conventions and patterns for multi-platform development

2009-06-19 Thread Nicolas Sylvain
On Fri, Jun 19, 2009 at 9:42 AM, Brett Wilson wrote: > > Our team has had somewhat of an ad-hoc approach to organizing code > that's different across platforms. In many cases our approach has been > quite good. In others, less so, and there have also been questions > about what the preferred meth

[chromium-dev] Re: Viewvc on src.chromium.org is down

2009-06-18 Thread Nicolas Sylvain
back online thanks Nicolas On Thu, Jun 18, 2009 at 10:56 AM, Nicolas Sylvain wrote: > Hello, > we've had a couple of problems with viewvc on src.chromium.org in the last > day, so I turned it off for now. > > I'll try to fix it in the next hours. > > in

[chromium-dev] Viewvc on src.chromium.org is down

2009-06-18 Thread Nicolas Sylvain
Hello, we've had a couple of problems with viewvc on src.chromium.org in the last day, so I turned it off for now. I'll try to fix it in the next hours. in the mean time you can still use src.chromium.org to fetch your files, and http://src.chromium.org/svn to browse the repo. Thanks Nicolas -

[chromium-dev] Re: What's the TabRestoreUITest bug 1215881?

2009-06-17 Thread Nicolas Sylvain
I filed this bug with this comment:-- TabRestoreUITest.RestoreToDifferentWindow fails on win2k debug. I disabled it. This is not reproducible outside the buildbot environment. The problem seems to be that chrome cannot access a font. I was not able to determine what the font was. --- Later on I

[chromium-dev] Re: FYI: Layout test failures for and if you don't have FFmpeg dlls

2009-06-12 Thread Nicolas Sylvain
On Fri, Jun 12, 2009 at 4:43 PM, Alpha Lam wrote: > (This only applies to Windows, if you are not developing on Windows and you > don't care about layout tests, you can stop reading now.) > > Hi all, > I enabled about 150 layout tests for media today, they are mostly > sitting inside: > w

[chromium-dev] Re: Can I have sandbox/linux?

2009-06-12 Thread Nicolas Sylvain
On Fri, Jun 12, 2009 at 2:48 PM, Adam Langley wrote: > On Fri, Jun 12, 2009 at 2:40 PM, Nicolas Sylvain > wrote: > > In theory sandbox/ should be fetched from DEPS pointing to > > http://code.google.com/p/rollcage , but since we don't really have a lot > of > > c

[chromium-dev] Re: Can I have sandbox/linux?

2009-06-12 Thread Nicolas Sylvain
On Fri, Jun 12, 2009 at 2:35 PM, Adam Langley wrote: > > sandbox/ is contains the Windows sandbox. However, we'll soon have > need for somewhere to put Linux sandboxing code. sandbox/linux is what > I'm using in my branch at the moment, but I'm open to suggestions. In theory sandbox/ should be

[chromium-dev] Re: No symbols for Google Chrome 2.0.172.30

2009-06-10 Thread Nicolas Sylvain
Looks like it did not. I'll investigate why. thanks Nicolas On Wed, Jun 10, 2009 at 1:00 AM, Dean McNamee wrote: > Hey Nicolas, > > Did these symbols ever get uploaded? > > Thanks > > On Sun, Jun 7, 2009 at 2:55 AM, yuhong wrote: > > > > SYMSRV: > http://build.chromium.org/buildbot/symsrv/chr

  1   2   >