GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/93
Add to blueprinting-tips
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs blueprint-tips
Alternatively you can
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/211
I've been looking at how we can do this more generally (entirely in
`MachineLifecycleEffectorTasks`, so it's not jclouds-specific). That makes the
code easier to follow and easi
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/266
BROOKLYN-264: refactor wait-for-provision
We now mark the internal state as provisioning entirely in
MachineLifecycleEffectorTasks, and that is also where we wait for it
on stop
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/264
@iyovcheva I've created https://github.com/iyovcheva/brooklyn-server/pull/1
to show how we can write unit tests for this.
The absolute must is that we "do no harm"
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71313422
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -379,20 +418,30
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71313855
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -379,20 +418,30
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71313969
--- Diff:
software/base/src/test/java/org/apache/brooklyn/entity/ExpungingJcloudsLocationLiveTest.java
---
@@ -1,186 +0,0
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71314400
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -444,9 +493,6
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/266#discussion_r71316462
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -444,9 +493,6
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/44#discussion_r71323238
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeImpl.java
---
@@ -99,15 +108,51 @@ public boolean
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/44#discussion_r71323278
--- Diff:
software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakNodeImpl.java
---
@@ -99,15 +108,51 @@ public boolean
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/44
Thanks @grkvlt - I'm going to merge now. I made one other minor comment
that is perhaps worth addressing, but not worth holding up this PR for.
---
If your project is set up for it
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/265
@bostko worth adding unit test(s) when making changes like this They should
be easy to write.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/267
Fix for BROOKLYN-314
Try-catch in getOptionalNode/getOptionalImage (e.g. if called by user
in rebind code, then donât fail outright if cloud throws exception
You can merge this pull
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/267
@nakomis not particularly easily is the answer, for writing a test to
recreate BROOKLYN-314! Would need to stub-out the a JcloudsLocation to simulate
the failure, and to write a custom
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/262
Thanks @neykov - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/137#discussion_r71403945
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/flags/TypeCoercions.java ---
@@ -138,6 +139,9 @@ private TypeCoercions
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/52
Fix riak (configureInternalNetwork throwing NPE)
Calling `configureInternalNetworking()` in `getRequiredOpenPorts()` always
caused an NPE, because the driver was not yet initialised. Also
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/93#discussion_r71514755
--- Diff: guide/yaml/blueprinting-tips.md ---
@@ -54,26 +69,64 @@ container (i.e. no install artifacts from previous
runs), while taking advantage
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/93
Thanks @drigodwin @sjcorbett - I've incorporated those changes. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/52
Thanks @iyovcheva - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/49
This is just adding an integration test. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71565538
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -827,6 +827,82 @@ public ToStringHelper string
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71565876
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -827,6 +827,82 @@ public ToStringHelper string
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71566145
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -931,6 +1007,7 @@ public ToStringHelper string
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71566328
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -827,6 +827,82 @@ public ToStringHelper string
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71566442
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -827,6 +827,82 @@ public ToStringHelper string
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/264#discussion_r71566594
--- Diff: server-cli/src/main/java/org/apache/brooklyn/cli/Main.java ---
@@ -827,6 +827,82 @@ public ToStringHelper string
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/264
Merging now. I'll address my most recent comments in a new PR later this
evening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/268
cleanOrphanedState: minor tidies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
cleanPersistedState-tidies
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/270
[REVIEW ONLY] State transformations: support deletions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/272
orphaned-state deletion: keep PortForwardManagers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
delete
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/270
Thanks @nakomis - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/96
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/277
Fix TestCases, and add TestSensor.abortConditions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
fix/test
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72585710
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java ---
@@ -39,4 +43,22 @@ public static InetAddress
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72585871
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,80
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72586282
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,80
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72586500
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/NetworkingEffectors.java
---
@@ -0,0 +1,80
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/276#discussion_r72586637
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcess.java
---
@@ -147,6 +147,8 @@
@SetFromFlag
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/276
It would be good to have test(s). Have you thought about how to write those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/278
rest api: entity/spec returns unquoted text/x-yaml
Previously it returned json:
* it wrapped it in quotes.
* it did strange things with \n: the result rendered as â\nâ rather
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/277#discussion_r72638625
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/TargetableTestComponentImpl.java
---
@@ -116,4 +125,14 @@ private static
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/277
@neykov interesting discussion. The "validConditions" makes a lot of sense.
I was imagining we'd list abortConditions as {on-fire, stopping, stopped,
destroyed} (which i
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/97#discussion_r72654950
--- Diff: guide/start/policies.md ---
@@ -435,14 +435,14 @@ you could use a load generator like jmeter, or use a
script such as the one show
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/97#discussion_r72659467
--- Diff: guide/start/policies.md ---
@@ -355,8 +355,8 @@ Tomcat on the vagrant VMs named "byon1" to "byon4":
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/98
Improve location docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-docs improve-location-docs
Alternatively you
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/51
jenkins build failure is unrelated - @grkvlt is kicking it off again:
```
Parsing POMs
Downloaded artifact
http://repository.apache.org/snapshots/org/apache/brooklyn
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/51
@grkvlt I agree this is too hard to write a test here for! We'd need to
generate a certificate for the specific IP address of the server that the test
is running against, then have
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/279
@grkvlt test failures look plausibly related: failures in
`JcloudsLocationTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/279#discussion_r72820800
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -527,7 +531,7 @@ public ComputeService
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/279
The jenkins test failures look plausibly related: `JcloudsLocationTest`
tests are failing.
@grkvlt please add test(s) for this. See the existing tests like those in
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/280
@grkvlt Can you add a test to demonstrate what you're fixing please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/279#discussion_r72821487
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -527,7 +531,7 @@ public ComputeService
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
Suggest you add the following tests to
`org.apache.brooklyn.entity.software.base.VanillaSoftwareProcessTest`:
@Test
public void
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/277
To clarify what I meant by "validConditions sounds like it could be a valid
termination condition"...
I mean that if someone is writing a test-case or is reading some
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/278
Thanks @m4rkmckenna - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/283
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/281
@grkvlt test failure since your last commit looks like a real failure:
`ConfigInheritanceYamlTest.testInheritsParentConfig`.
---
If your project is set up for it, you can reply to this
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73140636
--- Diff: guide/yaml/winrm/index.md ---
@@ -312,7 +312,7 @@ The script works for most of the Windows images out
there version 2008 and later
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/55#discussion_r73174941
--- Diff:
software/webapp/src/main/java/org/apache/brooklyn/entity/proxy/AbstractControllerImpl.java
---
@@ -287,7 +287,7 @@ protected String
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/284
Add TestCase.ON_ERROR_SPEC
Instantiates and executes this entity if there is an error while executing
the test-cases.
You can merge this pull request into a Git repository by running
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/286
BROOKLYN-322: feeds donât poll if entity unmanaged
Fixes https://issues.apache.org/jira/browse/BROOKLYN-322. See the
description in that jira issue.
You can merge this pull request
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/286
Thanks @bostko - merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73409488
--- Diff: guide/ops/locations/_AWS.md ---
@@ -111,3 +125,15 @@ You can then deploy blueprints to the subnet, allowing
VPC hardware instance typ
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73412004
--- Diff: guide/ops/locations/_GCE.md ---
@@ -43,4 +82,10 @@ For example, for dev/demo purposes an "everything"
network could be cr
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73412865
--- Diff: guide/ops/locations/_cloudstack.md ---
@@ -0,0 +1,138 @@
+---
+section: Openstack
+title: Openstack
+section_type: inline
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73416291
--- Diff: guide/ops/locations/_openstack.md ---
@@ -1,18 +1,66 @@
---
-section: Openstack
-title: Openstack
+section: OpenStack
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/98#discussion_r73418206
--- Diff: guide/ops/locations/_openstack.md ---
@@ -32,12 +80,16 @@ Do this by setting the desired values id as an option
in the
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/98
Thanks @drigodwin @andreaturli @mikezaccardo - I've incorporated those
comments, and am merging now.
The only ones I didn't incorporate were:
* I left the Blue Box ex
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-docs/pull/99
Move entropy/ulimit docs to troubleshooting
They were previously in website/documentation/increase-entropy.md and
in the faq. Now they are top-level pages in troubleshooting.
You can
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/99
Thanks @drigodwin - I've made that change. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/290
All our PR builds are failing with:
```
Parsing POMs
Modules changed, recalculating dependency graph
Established TCP socket on 42783
maven32-agent.jar already up to
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/290
LGTM; merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/54
LGTM; thanks @drigodwin - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/289
LGTM - the previous version of the test is most confusing as to what the
expected behaviour was! The new assertions look much more correct. Merging now.
---
If your project is set up for
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73672524
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java ---
@@ -1698,6 +1698,7 @@ public void add(Policy policy
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73672833
--- Diff:
core/src/main/java/org/apache/brooklyn/core/entity/internal/EntityConfigMap.java
---
@@ -132,7 +132,11 @@ public EntityConfigMap
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73673275
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java ---
@@ -421,6 +421,7 @@ public void setDisplayName(String
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73673387
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalPolicyFactory.java
---
@@ -125,7 +124,6 @@ public InternalPolicyFactory
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73673522
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicy.java
---
@@ -0,0 +1,105
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r73673667
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicy.java
---
@@ -0,0 +1,105
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r73674452
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/http/HttpExecutor.java ---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r73674530
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/http/HttpExecutorFactory.java
---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/285#discussion_r73674575
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/http/HttpTool.java ---
@@ -319,7 +318,7 @@ public HttpClientBuilder trustSelfSigned
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/282
+1 to suggestion from @neykov - having `attributeWhenReady` and `attribute`
is extremely confusing. I initially expected your `attribute` DSL function to
give me the immediate value
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/56
@grkvlt what tests should we run to confirm that this hasn't broken
previous use-cases, and that it now supports the use-case that motivated you
to make this change?
---
If your pr
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/58
LGTM; merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/284
Thanks @drigodwin - as per our offline conversation, I've also added: 1)
more logging for if we do or don't create the on-error entity; 2) the
on_error_spec is now not inherite
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/277
`testPersistenceVolumeFastNoTrigger` failed in jenkins PR build, but that
is unrelated to this PR. I've added a comment to
`testPersistenceVolumeFastNoTrigger` to explain what I thin
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/277
Merging this now. I agree that `validConditions` is also worth having. We
can add that later.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/294
Adds brooklyn-rest-client feature
@neykov can you take a look please?
Useful for any downstream projects that depend on brooklyn-rest-client and
that want to run in Karaf.
You
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/294
@neykov thanks for the great comments! I'm made those changes and confirmed
it works in a downstream project.
For the `javax.annotation` bundle, I now get version 1.2 al
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/287#discussion_r74306037
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicyTest.java
---
@@ -0,0 +1,113
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/287
LGTM - one very minor comment for how to dramatically reduce the test time
from 3 seconds to a few milliseconds. It adds up to a surprisingly high number
when too many of our tests did
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/296
Various minor things
Mostly improvements to tests (including failing tests for BROOKLYN-328 and
BROOKLYN-329). See individual commits for explanation and details.
You can merge this pull
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/293
LGTM; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74409198
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java ---
@@ -19,24 +19,52 @@
package
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74410202
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java ---
@@ -19,24 +19,52 @@
package
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/292#discussion_r74410438
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/BrooklynNetworkUtils.java ---
@@ -19,24 +19,52 @@
package
1 - 100 of 2333 matches
Mail list logo
