Re: [VOTE] Apache Kudu 1.6.0 RC1

2017-12-05 Thread David Alves
+1 built and ran debug/release tests on macso high sierra. -david On Tue, Dec 5, 2017 at 7:16 PM, Dan Burkert wrote: > +1 built and ran tests on macos. > > - Dan > > On Tue, Dec 5, 2017 at 7:06 PM, Mike Percy wrote: > >> +1 >> >> I built 1.6.0-RC1 on RHEL 7 in RELEASE mode. >> >> - Checksums an

Re: Adding extra data to Kudu::Status

2017-04-24 Thread David Alves
I'd be pro having an _optional_ PB or some other optional way to keep extra metadata in a status. In most cases (no extra metadata) this wouldn't have an additional cost when we're copying statuses around and the PB would have the obvious advantage of being easy to send to clients, when we need mor

[ANNOUNCE] Jordan Birdsell joining the Kudu PMC

2016-11-08 Thread David Alves
Congrats Jordan! Well deserved indeed. -david > Congrats Jordan! Great work. -Will

Re: Flaky tablet_history_gc-itest

2016-10-12 Thread David Alves
rge chunks of time to spend on this before Monday, though. > > Mike > > -- > Mike Percy > Software Engineer, Cloudera > > > On Wed, Oct 12, 2016 at 11:23 PM, David Alves > wrote: > > > No, you're right. I was looking at another test in that file. > &g

Re: Flaky tablet_history_gc-itest

2016-10-12 Thread David Alves
> > workload.Setup(); // Convenient way to create a table. > > > > Did I miss something? I.e. should I toggle just another control knob > somewhere? > > > Thanks, > > Alexey > > On Wed, Oct 12, 2016 at 1:43 PM, David Alves > wrote: > > > H

Re: Flaky tablet_history_gc-itest

2016-10-12 Thread David Alves
Hi Alexey Thanks for going down the rabbit hole. Could you try your patch without tablet replication for that test? If the problem persists it's unlikely that it's related to the current consistency gaps we have. I'm a bit suspicious in that it seems to be doing snapshot scans without retrying, wh

Re: [VOTE] Apache Kudu 1.0.1 RC1

2016-10-10 Thread David Alves
+0 Compiled thirdparty successfully, but couldn't compile the sources in macOS Sierra/XCode 8 as this is missing https://gerrit.cloudera.org/#/c/4482/ and https://gerrit.cloudera.org/#/c/4495/ Since this is just a bug fix/doc update release and this problem only affects macOS (macOS is only suppor

Re: Kudu 1.0.1 patch release

2016-10-06 Thread David Alves
I'd like to get "Address alter_table_randomized-test flakyness on ResultTracker" https://gerrit.cloudera.org/#/c/4629/ merged in. Rare race but potential for SIGSEGV on a highly battered cluster. Patch/fix/bug is simple enough that side-effects are very unlikely if not impossible. -david On Thu,

Re: Initial draft of consistency/isolation scoping document

2016-10-05 Thread David Alves
Same doc, shortened/unbroken URL: https://s.apache.org/7VCo -david On Tue, Oct 4, 2016 at 5:11 PM, David Alves wrote: > Hi All > > Some users have manifested interest/concern about consistency/isolation > in Kudu. I've written a doc that describes what we're missing

Initial draft of consistency/isolation scoping document

2016-10-04 Thread David Alves
Hi All Some users have manifested interest/concern about consistency/isolation in Kudu. I've written a doc that describes what we're missing and tries to suggest some kind of roadmap: https://docs.google.com/document/d/1EaKlJyQdMBz6G- Xn5uktY-d_x0uRmjMCrDGP5rZ7AoI/edit?usp=sharing It's a w

Re: Translating Kudu documentation from English into Brazilian Portuguese

2016-09-22 Thread David Alves
Hi Adalberto I share Todd's concern about maintenance, particularly if we're setting out to translate the whole set. As native portuguese speaker though, I'd love to see more portuguese writing on Kudu. I'd be happy to review blog posts or any other kind of written format contribution, just le

RFC: removing raft_consensus-test (mock-based)

2016-09-20 Thread David Alves
+1, we've since broadened our coverage in other tests that those cases are covered elsewhere. Plus I agree that with the queue taking more responsibility mocking it becomes a hardship. -david > I'm doing a bit of Consensus refactoring, and finding that the > raft_consensus-test mock-based test

Re: 'tidy-bot' now running (experimentally)

2016-09-19 Thread David Alves
+1 to keep, abbreviating from the definition seems evil. -david On Mon, Sep 19, 2016 at 2:19 PM, Adar Dembo wrote: > Personally I haven't seen much of a need for abbreviated parameter > names. I'd vote for keeping the warning. > > On Mon, Sep 19, 2016 at 2:14 PM, Todd Lipcon wrote: > > How do

Re: A couple more python patches

2016-09-14 Thread David Alves
Hi Jordan Feel free to add reviewers to your patches (you can do so in gerrit's web ui, or at push time), that way folks get notified when you do a push (if they aren't subscribed to the whole set of notifications, for instance). Usually we name a couple of folks that we feel are the ones that

Re: [VOTE] Apache Kudu 1.0.0 RC1

2016-09-14 Thread David Alves
+1 Downloaded and built on mac osx el capitan. Ran all tests (in serial), all passed. -david On Tue, Sep 13, 2016 at 12:39 AM, Todd Lipcon wrote: > Hi, > > The Apache Kudu team is happy to announce the first release candidate for > Apache Kudu 1.0.0. > > After approximately a year of beta rele

Re: [ANNOUNCE] Two new Kudu committer/PMC members

2016-09-12 Thread David Alves
Congrats Alexey and Will!! On Mon, Sep 12, 2016 at 3:55 PM, Todd Lipcon wrote: > Hi Kudu community, > > It's my great pleasure to announce that the PMC has voted to add both > Alexey Serbin and Will Berkeley as committers and PMC members. > > Alexey has been contributing for a few months, includ

Re: Potential Java client issue?

2016-09-11 Thread David Alves
Look at it for a bit and think I figured out the problem and fixed it (put on the ip2client map is synchronized with the put on client2tablets so it makes sense that the removing is too). The problem is that I'm having a hard time reproing the first failure. I'll ask JD's opinion tomorrow. -david

Re: Projection schema drops key

2016-09-09 Thread David Alves
/jtbirdsell/e376a7fa21f3b1893efa7e1ddac408d7 > > > On Fri, Sep 9, 2016 at 11:38 AM David Alves wrote: > > > Wait, If you _do_ set a projection on the scanner that does not include > the > > keys, then they won't be returned (and won't appear on the projectio

Re: Projection schema drops key

2016-09-09 Thread David Alves
; > >1. Check if all key columns are in the projection, and if so, > maintain > > >the key. > > >2. Provide an optional parameter to be able to set the key to users > > >preference for the new projection. This would be beneficial for > cases > > >

Re: Projection schema drops key

2016-09-09 Thread David Alves
y to users >preference for the new projection. This would be beneficial for cases > where >the user may want to create a new table based on their projection. > > Thoughts? > > Jordan > > On Fri, Sep 9, 2016 at 11:08 AM David Alves wrote: > > > Hi Jord

Re: Projection schema drops key

2016-09-09 Thread David Alves
Hi Jordan KuduScanner::GetProjectionSchema returns the schema of the projection that was previously set on the scanner. If you don't a projection it should indeed return all the columns. Are you sure you didn't set a projection (with SetProjectedColumnNames or SetProjectedColumnIndexes) that e

Re: KUDU-1593 Patch

2016-09-06 Thread David Alves
Hi Jordan Thanks for contributing. I've left some comments. Best David On 9/6/16, Jordan Birdsell wrote: > Hey all, > > I've submitted a patch for KUDU-1593 > . This patch exposes the > num_replicas method for the KuduTableCreator class to th