GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2460
[FLINK-4562] table examples make an divided module in flink-examples
only move table examle code to a divided module in flink-examples.
Table API module should't contain example code.
[
https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457733#comment-15457733
]
ASF GitHub Bot commented on FLINK-4562:
---
GitHub user shijinkui opened a pull request
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2459
Hi @shijinkui, thanks for opening pull request. Unfortunately, this pull
request cause a problem with maven shading plugin
(https://issues.apache.org/jira/browse/MSHADE-200). Due to the problem, F
[
https://issues.apache.org/jira/browse/FLINK-4561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457750#comment-15457750
]
ASF GitHub Bot commented on FLINK-4561:
---
Github user chiwanpark commented on the iss
[
https://issues.apache.org/jira/browse/FLINK-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457773#comment-15457773
]
Simone Robutti commented on FLINK-4513:
---
I noticed that this is true for the docs of
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2447
Looking into it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457779#comment-15457779
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457902#comment-15457902
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77309411
--- Diff:
flink-mesos/src/main/scala/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManager.scala
---
@@ -19,20 +19,19 @@
package org.apa
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2397
Could you rebase to master again, so that the build turns green?
https://travis-ci.org/apache/flink/builds/155979197
Thank you!
---
If your project is set up for it, you can reply to this em
[
https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457905#comment-15457905
]
ASF GitHub Bot commented on FLINK-4439:
---
Github user rmetzger commented on the issue
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77310204
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
---
@@ -104,16 +107,17 @@ public String
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457918#comment-15457918
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77310357
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/PartialInputChannelDeploymentDescriptor.java
---
@@ -44,15 +44,15 @@
p
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457923#comment-15457923
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2418
ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457926#comment-15457926
]
ASF GitHub Bot commented on FLINK-4245:
---
Github user zentol commented on the issue:
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/2345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77310730
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java
---
@@ -104,16 +107,17 @@ public String
[
https://issues.apache.org/jira/browse/FLINK-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457932#comment-15457932
]
ASF GitHub Bot commented on FLINK-4340:
---
Github user aljoscha closed the pull reques
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457930#comment-15457930
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r7737
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/Instance.java ---
@@ -84,22 +90,22 @@
* Constructs an instance reflectin
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457936#comment-15457936
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457941#comment-15457941
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77311597
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/InstanceManager.java
---
@@ -147,7 +148,7 @@ public boolean reportHeartBeat(Inst
[
https://issues.apache.org/jira/browse/FLINK-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457967#comment-15457967
]
Maximilian Michels commented on FLINK-4485:
---
Thanks a lot for the minimal exampl
[
https://issues.apache.org/jira/browse/FLINK-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457975#comment-15457975
]
ASF GitHub Bot commented on FLINK-4544:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2445
Version 2 is up. Essentially, we now attempt to use the methods before
registering the metrics. I've also adjusted the new CPU metrics.
---
If your project is set up for it, you can reply to this ema
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77313861
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotSharingGroupAssignment.java
---
@@ -576,7 +560,7 @@ private void internalDis
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457976#comment-15457976
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457980#comment-15457980
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77314097
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/ConnectionID.java
---
@@ -41,7 +41,7 @@
private final int connec
Github user chobeat commented on the issue:
https://github.com/apache/flink/pull/2152
Is travis still broken? I see it worked for one build but failed for the
others. Is there anything more to review on this PR or we can proceed?
---
If your project is set up for it, you can reply to
[
https://issues.apache.org/jira/browse/FLINK-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457984#comment-15457984
]
ASF GitHub Bot commented on FLINK-3920:
---
Github user chobeat commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457992#comment-15457992
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on the issue
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2425
T2-3 is not about the web interface netty, its about the data transfer
netty
In Flink, we are using netty for (at least) three things:
- Akka is using Netty. This is addressed in the pull re
Github user gheo21 commented on the issue:
https://github.com/apache/flink/pull/2397
Sure, did it. Let's see if it get's green! Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
[
https://issues.apache.org/jira/browse/FLINK-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457997#comment-15457997
]
ASF GitHub Bot commented on FLINK-4439:
---
Github user gheo21 commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15457995#comment-15457995
]
Timo Walther commented on FLINK-4260:
-
[~miaoever] Do you still plan to implement this
Chesnay Schepler created FLINK-4563:
---
Summary: [metrics] scope caching not adjusted for multiple
reporters
Key: FLINK-4563
URL: https://issues.apache.org/jira/browse/FLINK-4563
Project: Flink
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77317356
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotAllocationFuture.java
---
@@ -20,73 +20,125 @@
import
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458026#comment-15458026
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458030#comment-15458030
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77317670
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotOwner.java
---
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apac
Chesnay Schepler created FLINK-4564:
---
Summary: [metrics] Delimiter should be configured per reporter
Key: FLINK-4564
URL: https://issues.apache.org/jira/browse/FLINK-4564
Project: Flink
Iss
Timo Walther created FLINK-4565:
---
Summary: Support for SQL IN operator
Key: FLINK-4565
URL: https://issues.apache.org/jira/browse/FLINK-4565
Project: Flink
Issue Type: Improvement
Com
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77318844
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/DummyEnvironment.java.orig
---
@@ -1,185 +0,0 @@
-/*
--- End
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458051#comment-15458051
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2447
Really good changes @StephanEwen. +1 for merging.
I had only some minor comments.
I guess that replacing the `ActorGateways` in the `Slots` and preparing the
`Scheduler` to wor
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458061#comment-15458061
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user tillrohrmann commented on the i
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320094
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -99,7 +110,43 @@ public void channelRead0(Chann
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320247
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -426,4 +440,11 @@ void unregisterConnection(BlobServerConnection c
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458071#comment-15458071
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458073#comment-15458073
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77320960
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -682,6 +774,91 @@ public static File
getYarnPropertiesLocation(
[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458082#comment-15458082
]
ASF GitHub Bot commented on FLINK-3930:
---
Github user rmetzger commented on a diff in
Stephan Ewen created FLINK-4566:
---
Summary: ProducerFailedException does not properly preserve
Exception causes
Key: FLINK-4566
URL: https://issues.apache.org/jira/browse/FLINK-4566
Project: Flink
Till Rohrmann created FLINK-4568:
Summary: Replace ActorGateway in WebRuntimeMonitor
Key: FLINK-4568
URL: https://issues.apache.org/jira/browse/FLINK-4568
Project: Flink
Issue Type: Improveme
Stephan Ewen created FLINK-4567:
---
Summary: Enhance SerializedThrowable to properly preserver cause
chains
Key: FLINK-4567
URL: https://issues.apache.org/jira/browse/FLINK-4567
Project: Flink
I
[
https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels reassigned FLINK-4348:
-
Assignee: Maximilian Michels (was: zhangjing)
> Implement slot allocation protoc
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2449
Looks good to me, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458101#comment-15458101
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user StephanEwen commented on the is
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2447
We can do either that follow-up, or we can add an RPC gateway in the
`flip-6` branch and remove the ActorGateway after merging the feature and
master branch.
Will address the comments an
GitHub user wangzhijiang999 opened a pull request:
https://github.com/apache/flink/pull/2461
[FLINK-4505][Cluster Management] Implement TaskManagerFactory to brinâ¦
Implement TaskExecutorFactory that should be an abstract class with the
helper methods to bring up the TaskManager. T
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2449
Tests have passed locally. Will rebase check again on Travis and then merge
the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
[
https://issues.apache.org/jira/browse/FLINK-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458119#comment-15458119
]
ASF GitHub Bot commented on FLINK-4490:
---
Github user StephanEwen commented on the is
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458121#comment-15458121
]
ASF GitHub Bot commented on FLINK-4505:
---
GitHub user wangzhijiang999 opened a pull r
[
https://issues.apache.org/jira/browse/FLINK-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458118#comment-15458118
]
ASF GitHub Bot commented on FLINK-4455:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2450
Will rebase on the latest master and #2449 to run the travis tests again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458128#comment-15458128
]
ASF GitHub Bot commented on FLINK-4458:
---
Github user tillrohrmann commented on the i
Robert Metzger created FLINK-4569:
-
Summary: JobRetrievalITCase.testJobRetrieval() does not forward
exceptions to parent thread.
Key: FLINK-4569
URL: https://issues.apache.org/jira/browse/FLINK-4569
P
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2275
Running some last tests before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458147#comment-15458147
]
ASF GitHub Bot commented on FLINK-3929:
---
Github user mxm commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2418
I've updated the PR.
* reverted back to creating a new Hashtable and filtering all keys and
values
* introduced the notion of a "logical scope"; in other words the group
hierarchy without spec
[
https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458151#comment-15458151
]
ASF GitHub Bot commented on FLINK-4245:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458159#comment-15458159
]
Simone Robutti commented on FLINK-2312:
---
Should we reconsider this implementation?
[
https://issues.apache.org/jira/browse/FLINK-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458168#comment-15458168
]
ASF GitHub Bot commented on FLINK-4547:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77326124
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -189,7 +191,49 @@ public void stop() {
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2455
I think the subject line of this PR is a little bit misleading. The
`RpcService` won't return the same gateway object upon calling `connect` with
the same parameters. But the returned gateways a
[
https://issues.apache.org/jira/browse/FLINK-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458179#comment-15458179
]
ASF GitHub Bot commented on FLINK-4547:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77326942
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java
---
@@ -84,4 +89,35 @@ public void run() {
[
https://issues.apache.org/jira/browse/FLINK-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458182#comment-15458182
]
ASF GitHub Bot commented on FLINK-4547:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458190#comment-15458190
]
Till Rohrmann commented on FLINK-2312:
--
We've merged FLINK-2259 which might already f
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2461#discussion_r77327741
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/YarnTaskExecutorFactory.java
---
@@ -0,0 +1,198 @@
+package org.apache.f
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458199#comment-15458199
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user tillrohrmann commented on a dif
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@mxm , The {{StandaloneTaskExecutorFactory}} can be used for mini cluster
or testing mode I think, and the {{YarnTaskExecutorFactory}} used for yarn
mode. After you confirm the implementatio
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458203#comment-15458203
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user wangzhijiang999 commented on th
Github user wangzhijiang999 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2461#discussion_r77329068
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/YarnTaskExecutorFactory.java
---
@@ -0,0 +1,198 @@
+package org.apach
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458217#comment-15458217
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user wangzhijiang999 commented on a
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
Thanks for the contribution @wangzhijiang999.
I think the abstraction is not right. The `StandaloneFactory` and the
`YarnFactory` should actually only differ in the class of the `TaskExe
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458228#comment-15458228
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user tillrohrmann commented on the i
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/2461
@tillrohrmann , the current implementation is just follow the previous
process for yarn and standalone modes. And I agree your opinion and actually it
is not very clear for current ways. I th
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458249#comment-15458249
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user wangzhijiang999 commented on th
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
I think we don't need the distinction between standalone and yarn in the
TaskManager startup. They should actually be the same. The difference will be
the `StandaloneRunner`, `YarnRunner` and `M
[
https://issues.apache.org/jira/browse/FLINK-4505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458340#comment-15458340
]
ASF GitHub Bot commented on FLINK-4505:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2451#discussion_r77335889
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/UnmatchedLeaderSessionIDException.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2451#discussion_r77335925
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/UnmatchedLeaderSessionIDException.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2451#discussion_r77335961
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/UnmatchedLeaderSessionIDException.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458347#comment-15458347
]
ASF GitHub Bot commented on FLINK-4535:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458350#comment-15458350
]
ASF GitHub Bot commented on FLINK-4535:
---
Github user tillrohrmann commented on a dif
1 - 100 of 203 matches
Mail list logo
