Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/795
TS-4655: Remove SessionAccept pointer from SSLNetVConnection.
SSLNetVConnection never uses the SessionAccept pointer, so remove
it and the associated setter and getter. Tidy up the
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/794
This looks alright to me. The one part I'm a little concerned about is the
changes to the dirent allocation, but I don't think there will be any problems
with too-long filenames i
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/796
TS-4660: Improve remap.config error messages.
Improve some of the confusion about which error message buffer to
use in remap_parse_config_bti. The final message is now constructed
to
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/796
@zwoop This is a stopgap to fix the error messages until we can do the
larger refactoring in TS-4660.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/797
TS-4659: Log format errors on startup.
Remove extraneous field name constants which accidentally match
with strstr().
You can merge this pull request into a Git repository by running
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/795
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/797
The original code used the enum value as a sentinel so it would never have
hit the empty strings at the ends of the lists.
---
If your project is set up for it, you can reply to this email
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/796
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/799
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/801#discussion_r71073791
--- Diff: proxy/ProxyClientSession.cc ---
@@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id)
this->api_current = N
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/801#discussion_r71073823
--- Diff: proxy/ProxyClientSession.cc ---
@@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id)
this->api_current = N
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/805
The documentation for this API family is in
{{doc/developer-guide/api/functions/TSInstallDirGet.en.rst}}, Just mention the
new API there.
---
If your project is set up for it, you can reply
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/805
This follows the pattern of the other APIs, but I notice the initialization
is not thread safe. Shall we file a separate JIRA for that?
---
If your project is set up for it, you can reply to
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/802
I don't think this change is correct. It seems to me that the invariant is
that ``server_session`` and ``server_entry`` should be NULL or non-NULL
together. So if we
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/801
I had to re-read this code to refresh my memory on how this works. I think
that the invariant that the ``ProxyClientSession`` requires is that the API
hooks are the first and last operations
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/779#discussion_r71102843
--- Diff: plugins/experimental/ts_lua/ts_lua_http.c ---
@@ -29,8 +29,36 @@ typedef enum {
TS_LUA_CACHE_LOOKUP_SKIPPED
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/779#discussion_r71103039
--- Diff: plugins/experimental/ts_lua/ts_lua.c ---
@@ -140,13 +141,15 @@ TSRemapDoRemap(void *ih, TSHttpTxn rh,
TSRemapRequestInfo *rri
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/779#discussion_r71103080
--- Diff: plugins/experimental/ts_lua/ts_lua.c ---
@@ -117,7 +117,7 @@ TSRemapDeleteInstance(void *ih)
}
TSRemapStatus
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/807
TS-4672: Add lifecycle events to hook-trace example plugin.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4672
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/808
TS-4673: Remove unused HttpSM::historical_action.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4873
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78403317
--- Diff: proxy/ProxyClientSession.h ---
@@ -184,6 +184,25 @@ class ProxyClientSession : public VConnection
return get_netvc() == NULL
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1007
@ogoodman can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1007
```
Making all in example
...
make[1]: *** No rule to make target `protocol-stack/protocol-stack.c',
needed by `protocol-stack/protocol-stack.lo'. Stop.
make[1]: *
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1008#discussion_r78404752
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2055,9 +2055,12 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1008#discussion_r78407210
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2055,9 +2055,11 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/996
@gtenev See my comments here and in the bug. I think that these new metrics
should follow the existing conventions of the cache system.
---
If your project is set up for it, you can reply to
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78408638
--- Diff: example/Makefile.am ---
@@ -68,6 +69,7 @@ lifecycle_plugin_la_SOURCES =
lifecycle-plugin/lifecycle-plugin.c
null_transform_la_SOURCES
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78408588
--- Diff: doc/reference/api/TSClientProtocolStack.en.rst ---
@@ -0,0 +1,79 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78408986
--- Diff: example/protocol-stack/protocol-stack.cc ---
@@ -0,0 +1,62 @@
+/** @file
+
+ an example hello world plugin
+
+ @section
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78409027
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -566,6 +570,17 @@ class NetVConnection : public VConnection
is_transparent = state
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78409374
--- Diff: iocore/net/NetVConnection.cc ---
@@ -43,3 +44,39 @@ NetVConnection::cancel_OOB()
{
return;
}
+
+const char
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78409866
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2055,8 +2055,12 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410082
--- Diff: lib/records/RecHttp.cc ---
@@ -618,6 +633,30 @@ ts_session_protocol_well_known_name_indices_init
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410287
--- Diff: lib/records/RecHttp.cc ---
@@ -618,6 +633,30 @@ ts_session_protocol_well_known_name_indices_init
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410540
--- Diff: proxy/InkAPI.cc ---
@@ -9193,3 +9193,71 @@ TSHttpTxnIdGet(TSHttpTxn txnp)
return (uint64_t)sm->sm
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410759
--- Diff: proxy/InkAPI.cc ---
@@ -9193,3 +9193,71 @@ TSHttpTxnIdGet(TSHttpTxn txnp)
return (uint64_t)sm->sm
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78410969
--- Diff: proxy/InkAPI.cc ---
@@ -9193,3 +9193,71 @@ TSHttpTxnIdGet(TSHttpTxn txnp)
return (uint64_t)sm->sm
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1008#discussion_r78411363
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2055,9 +2055,12 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78411573
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -243,6 +243,32 @@ class Http2ClientSession : public ProxyClientSession
return "h
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1007#discussion_r78411137
--- Diff: proxy/api/ts/ts.h ---
@@ -2419,6 +2419,16 @@ tsapi const TSUuid TSProcessUuidGet(void);
*/
tsapi const char *TSHttpTxnPluginTagGet
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/834#discussion_r78412928
--- Diff: proxy/ParentConsistentHash.cc ---
@@ -63,21 +66,104 @@ ParentConsistentHash::getPathHash(HttpRequestData
*hrdata, ATSHash64 *h
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1000#discussion_r78414024
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -75,17 +75,32 @@ ServerSessionPool::match(HttpServerSession *ss,
sockaddr const *addr, INK_MD5 co
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1000#discussion_r78414308
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -75,17 +75,32 @@ ServerSessionPool::match(HttpServerSession *ss,
sockaddr const *addr, INK_MD5 co
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1000#discussion_r78414549
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -98,7 +113,10 @@ ServerSessionPool::acquireSession(sockaddr const *addr,
INK_MD5 const &hostn
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1000#discussion_r78414689
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -75,17 +75,32 @@ ServerSessionPool::match(HttpServerSession *ss,
sockaddr const *addr, INK_MD5 co
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78418739
--- Diff: iocore/net/SSLConfig.cc ---
@@ -81,6 +81,13 @@ SSLConfigParams::SSLConfigParams()
ssl_session_cache_timeout= 0
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78418970
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -951,6 +955,11 @@ SSLNetVConnection::sslStartHandShake(int event, int
&err)
re
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78419692
--- Diff: mgmt/RecordsConfig.cc ---
@@ -1302,6 +1302,24 @@ static const RecordElement RecordsConfig
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78421317
--- Diff: proxy/http/HttpConfig.cc ---
@@ -1178,6 +1180,8 @@ HttpConfig::reconfigure()
params->oride.proxy_response_hsts_max_
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/990
@SolidWallOfCode can you please look at the WKS changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/990
@masaori335 Any thoughts about tests for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78422101
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1895,10 +1963,17 @@ ssl_store_ssl_context(const SSLConfigParams
*params, SSLCertLookup *lookup, cons
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78428701
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78429115
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78429490
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78429941
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78430050
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78430063
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78430195
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78430728
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78431322
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78432072
--- Diff: mgmt/RecordsConfig.cc ---
@@ -103,10 +103,10 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78433010
--- Diff: mgmt/RecordsConfig.cc ---
@@ -192,33 +192,33 @@ static const RecordElement RecordsConfig[] =
//#L diags.log
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78433236
--- Diff: mgmt/RecordsConfig.cc ---
@@ -192,33 +192,33 @@ static const RecordElement RecordsConfig[] =
//#L diags.log
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78433612
--- Diff: mgmt/RecordsConfig.cc ---
@@ -233,19 +233,19 @@ static const RecordElement RecordsConfig[] =
//# Local Manager
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78434138
--- Diff: mgmt/RecordsConfig.cc ---
@@ -815,33 +815,33 @@ static const RecordElement RecordsConfig[] =
#endif
RECU_DYNAMIC, RR_NULL
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/887
@zwoop Other than the configs I have marked, I think the rest of the
changes are correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1010
@kawaiirice Can you please take a look at
[this}(https://cwiki.apache.org/confluence/display/TS/CommitPolicies) and
update the commit message accordingly? thanks
---
If your project is set
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1011
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1012
TS-4840 Crash when reattaching to C++ API Stats.
The change in TS-4793 regressed the C++ API Stat object. What happens is
that if you restart traffic_server without traffic_manager, the
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1014
TS-4861: Turn ECONNRESET into an end-of-file.
If you do traffic_ctl server restart, then traffic_manager is getting
an ECONNRESET error on the management socket after traffic_server
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1013#discussion_r78638850
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1629,7 +1629,8 @@ SSLInitServerContext(const SSLConfigParams *params,
const ssl_user_config *sslMu
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1016
TS-4862: Unable to clear metrics.
Fix ``traffic_ctl metrics clear``.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1015#discussion_r78650646
--- Diff: plugins/experimental/url_sig/url_sig.c ---
@@ -561,7 +561,9 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp,
TSRemapRequestInfo *rri
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1014
This is running on ``docs`` on top of latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1015
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1017
TS-4863: Remove non-existent proxy.node.num_processes metric.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1013
ð This looks pretty reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1004#discussion_r78665705
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -2510,12 +2510,15 @@ HostDB
The filename to persist hostdb to on disk
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1017#discussion_r78670899
--- Diff: plugins/experimental/epic/epic.cc ---
@@ -50,120 +50,192 @@
static TSHRTime epic_period;
static char *epic_prefix
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1017
@shinrich There's still a gratuitous C++11 commit here, but in the second
commit it is now very obvious what the change is.
---
If your project is set up for it, you can reply to this
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/990#discussion_r78773240
--- Diff: iocore/net/SSLNetVConnection.cc ---
@@ -951,6 +955,11 @@ SSLNetVConnection::sslStartHandShake(int event, int
&err)
re
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1012
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1014
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/981
@PSUdaemon don't forget to update the docs when you land this ... there are
sections that talk about dependencies and building from source.
---
If your project is set up for it, you can
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1021
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78998966
--- Diff: mgmt/RecordsConfig.cc ---
@@ -103,10 +103,10 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1023
TS-4871: Check for TSStatCreate failure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4871
Alternatively
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1022#discussion_r79010553
--- Diff: mgmt/RecordsConfig.cc ---
@@ -834,6 +860,61 @@ static const RecordElement RecordsConfig
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1022#discussion_r79010160
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -657,9 +656,6 @@ config_reload_records()
config_read_int("proxy.config.cop.source
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1025
TS-4872: Fix clang-analyzer leak error on LogObject.cc _checkout_write.
We could not quite figure out why it reports this (smells almost like a bug
in clang-analyzer), but some refactoring
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1024#discussion_r79039044
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2052,6 +2052,7 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
@jacksontj @zwoop Can we please run this on docs for a few days?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/872
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
1 - 100 of 711 matches
Mail list logo