emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173353923
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -68,7 +68,7 @@ public void testUnderlying(
[
https://issues.apache.org/jira/browse/KAFKA-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Purshotam Chauhan resolved KAFKA-14827.
---
Fix Version/s: 3.5.0
Reviewer: Manikumar Reddy
Resolution: Fixed
> S
[
https://issues.apache.org/jira/browse/KAFKA-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Purshotam Chauhan closed KAFKA-14827.
-
> Support for StandardAuthorizer in Benchmark
> ---
dengziming commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1173247022
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have be
rondagostino commented on PR #13532:
URL: https://github.com/apache/kafka/pull/13532#issuecomment-1517118288
Merged to 3.5, 3.4, 3.3, 3.2, 3.1, 3.0, 2.8, and 2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14887:
--
Fix Version/s: 2.7.3
3.2.4
3.1.3
3.0.3
[
https://issues.apache.org/jira/browse/KAFKA-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14887:
--
Fix Version/s: 3.5.0
> ZK session timeout can cause broker to shutdown
> -
rondagostino commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173188783
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -77,7 +77,7 @@ public void testDelegationOfA
rondagostino commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1173187845
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegatio
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173179837
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Founda
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173177108
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Founda
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173174594
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache Software Fo
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173172297
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Fo
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1173171410
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -266,7 +266,7 @@ public synchronized TransactionalRequestResult beg
kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1173167778
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -968,13 +968,31 @@ private void transitionTo(State target) {
}
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714770#comment-17714770
]
Matthias J. Sax commented on KAFKA-14922:
-
{quote}We could add a warning with th
mjsax commented on PR #13614:
URL: https://github.com/apache/kafka/pull/13614#issuecomment-1517029646
Thanks all of you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vcrfxia opened a new pull request, #13622:
URL: https://github.com/apache/kafka/pull/13622
This PR updates docs for
[KIP-914](https://cwiki.apache.org/confluence/display/KAFKA/KIP-914%3A+DSL+Processor+Semantics+for+Versioned+Stores).
### Committer Checklist (excluded from commit mes
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173127962
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
assertTrue(firstProducerI
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173116859
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the acti
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173116859
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the acti
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173109856
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -222,7 +245,7 @@ private boolean isValidStateChange(MigrationDriverState
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173092055
##
metadata/src/main/resources/common/metadata/ZkMigrationRecord.json:
##
@@ -18,7 +18,9 @@
"type": "metadata",
"name": "ZkMigrationStateRecord",
// Version 0
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173091174
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -396,18 +418,36 @@ class WaitForControllerQuorumEvent extends MigrationEv
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173089410
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -222,7 +245,7 @@ private boolean isValidStateChange(MigrationDriverState
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173089106
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -222,7 +245,7 @@ private boolean isValidStateChange(MigrationDriverState
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173082868
##
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##
@@ -105,14 +130,15 @@ private void writeFeatureLevels(ImageWriter writer,
ImageWriterOptions op
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173082641
##
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##
@@ -105,14 +130,15 @@ private void writeFeatureLevels(ImageWriter writer,
ImageWriterOptions op
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173081897
##
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##
@@ -37,19 +39,30 @@
* This class is thread-safe.
*/
public final class FeaturesImage {
-
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173081897
##
metadata/src/main/java/org/apache/kafka/image/FeaturesImage.java:
##
@@ -37,19 +39,30 @@
* This class is thread-safe.
*/
public final class FeaturesImage {
-
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173080760
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173079770
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173079249
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173078385
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173076552
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173073635
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1123,29 +1165,104 @@ private void claim(int epoch) {
// Prepend the act
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173072509
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1085,7 +1123,11 @@ private void maybeCompleteAuthorizerInitialLoad() {
}
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173069848
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -304,6 +338,13 @@ public void replay(FeatureLevelRecord record) {
}
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173068660
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -232,13 +248,20 @@ private ApiError updateMetadataVersion(
Consumer rec
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173068660
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -232,13 +248,20 @@ private ApiError updateMetadataVersion(
Consumer rec
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173066452
##
core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala:
##
@@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest {
}
@ClusterTest(clus
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173062692
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
assertTrue(firstProducer
cmccabe commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1173062239
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {
assertTrue(firstProducer
szalapski commented on PR #5876:
URL: https://github.com/apache/kafka/pull/5876#issuecomment-1516905377
Sad that this didn't get in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1173050527
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java:
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Founda
philipnee commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1516893617
Failing tests don't seem to be related.
```
Build / JDK 8 and Scala 2.12 /
testReplicationIsCreatingTopicsUsingProvidedForwardingAdmin() –
org.apache.kafka.connect.mirror.inte
philipnee commented on PR #12149:
URL: https://github.com/apache/kafka/pull/12149#issuecomment-1516893160
Hey @jolshan - Thanks for the review. i reverted those
documentation/comment changes in the senderTest.java (for the produceResponse
authorization error).
--
This is an automated me
[
https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-14904.
Resolution: Fixed
> Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()
> -
[
https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reopened KAFKA-14884:
I'm confused by all my blockers 🤦♀️
> Include check transaction is still ongoing right befor
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172953390
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172945841
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172946358
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Found
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939909
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939598
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ClientAssignorTest.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172939142
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundat
divijvaidya commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1516728614
Hey @cmccabe, we can have a community discussion over the mailing list but I
am not following one of your statements here.
> since it will allow multiple Kafka servers to be sta
cmccabe commented on PR #13572:
URL: https://github.com/apache/kafka/pull/13572#issuecomment-1516694321
Hi all,
Unfortunately I had to revert this. This is a change to our public API since
it will allow multiple Kafka servers to be started on the same port. This kind
of change needs
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172892464
##
clients/src/test/java/org/apache/kafka/common/utils/SkippableChunkedBytesStreamTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172889948
##
clients/src/main/java/org/apache/kafka/common/utils/SkippableChunkedBytesStream.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172884561
##
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172883282
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -157,7 +186,14 @@ public InputStream wrapForInput(ByteBuffer buffer, byte
messa
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172883027
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buff
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172882018
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -108,12 +117,18 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buf
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1172881788
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -90,8 +95,13 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer
[
https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-14884.
Resolution: Fixed
> Include check transaction is still ongoing right before append
>
[
https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-14916:
---
Description:
KAFKA-14561 wrote code that assumed that if a transactional ID was included,
a
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172850344
##
server-common/src/test/java/org/apache/kafka/server/immutable/DelegationChecker.java:
##
@@ -139,6 +163,16 @@ public void doFunctionDelegationCheck() {
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
emissionnebula commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172848492
##
server-common/src/test/java/org/apache/kafka/server/immutable/pcollections/PCollectionsImmutableMapTest.java:
##
@@ -225,77 +225,59 @@ public void testDelegat
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172839235
##
server-common/src/main/java/org/apache/kafka/deferred/DeferredEvent.java:
##
@@ -15,12 +15,12 @@
* limitations under the License.
*/
-package org.apache.kafka.
tinaselenge commented on PR #13459:
URL: https://github.com/apache/kafka/pull/13459#issuecomment-1516631750
@showuon Thank you so much. I have addressed the comments but left couple of
them to clarify first.
--
This is an automated message from the Apache Git Service.
To respond to the m
jolshan commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1516624342
Will also cherry-pick to 3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
jolshan merged PR #13579:
URL: https://github.com/apache/kafka/pull/13579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jolshan commented on PR #13579:
URL: https://github.com/apache/kafka/pull/13579#issuecomment-1516620151
Many many connect failures still 😔
Failures appear to be unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
tinaselenge commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1172832601
##
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##
@@ -307,25 +294,24 @@ private static void update(String op, Admin admin,
Map up
rreddy-22 commented on code in PR #13443:
URL: https://github.com/apache/kafka/pull/13443#discussion_r1172824513
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##
@@ -0,0 +1,499 @@
+/*
+ * Licensed to the Apache Software Fo
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172793737
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been
gharris1727 commented on code in PR #13429:
URL: https://github.com/apache/kafka/pull/13429#discussion_r1172772709
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -139,10 +171,103 @@ public void close() {
protected void handleReco
rondagostino commented on code in PR #13437:
URL: https://github.com/apache/kafka/pull/13437#discussion_r1172661731
##
server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableNavigableSet.java:
##
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172738445
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been st
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172735940
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been st
clolov commented on PR #13621:
URL: https://github.com/apache/kafka/pull/13621#issuecomment-1516499410
Heya @cadonna! I hope this attempt is what you had in mind? Unless I am
wrong the removals detailed in the pull request are sensible as Mockito should
be returning empty collections for me
clolov opened a new pull request, #13621:
URL: https://github.com/apache/kafka/pull/13621
This pull request takes a similar approach as the one outlined in
https://github.com/apache/kafka/pull/13529 to move each mock separately to ease
reviewing the code.
Once https://github.com/apac
jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172724317
##
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been
jeffkbkim commented on PR #13603:
URL: https://github.com/apache/kafka/pull/13603#issuecomment-1516453173
@dajac
```
org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.
shouldWorkWithRebalance
kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()
```
mumrah commented on PR #13461:
URL: https://github.com/apache/kafka/pull/13461#issuecomment-1516441727
> Should we wrap the calls to quotaEntityConsumer.accept (and other
consumers) so that if it throws an exception, we log an ERROR message to log4j
to let us know what failed?
Yes, t
jeffkbkim commented on PR #13604:
URL: https://github.com/apache/kafka/pull/13604#issuecomment-1516438325
@dajac i see Selector test failures that pass locally. Can we re-trigger the
build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dajac commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172674549
##
server-common/src/main/java/org/apache/kafka/purgatory/Purgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been started, but no
[
https://issues.apache.org/jira/browse/KAFKA-14923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714612#comment-17714612
]
Vikash Mishra commented on KAFKA-14923:
---
[~yash.mayya] Awesome, thanks for the det
mumrah commented on code in PR #13461:
URL: https://github.com/apache/kafka/pull/13461#discussion_r1172646961
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -174,12 +173,12 @@ private boolean areZkBrokersReadyForMigration() {
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172621475
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
mumrah commented on code in PR #13407:
URL: https://github.com/apache/kafka/pull/13407#discussion_r1172621439
##
metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java:
##
@@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta del
jeffkbkim commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172600639
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Found
dengziming commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172598460
##
server-common/src/main/java/org/apache/kafka/purgatory/Purgatory.java:
##
@@ -26,10 +26,9 @@
/**
* The purgatory which holds events that have been started, b
[
https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714597#comment-17714597
]
Jørgen commented on KAFKA-14922:
An _improvement_ would be to only return topics that ex
dajac commented on code in PR #13537:
URL: https://github.com/apache/kafka/pull/13537#discussion_r1172597532
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundatio
tinaselenge commented on code in PR #13459:
URL: https://github.com/apache/kafka/pull/13459#discussion_r1172577875
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14877:
Assignee: Divij Vaidya
> refactor InMemoryLeaderEpochCheckpoint
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714594#comment-17714594
]
Divij Vaidya commented on KAFKA-14877:
--
I will pick this up if there is no objectio
1 - 100 of 139 matches
Mail list logo