Re: [PR] IGNITE-22075 GC doesn't wait for RO transactions [ignite-3]

2024-04-25 Thread via GitHub
tkalkirill merged PR #3650: URL: https://github.com/apache/ignite-3/pull/3650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1578374314 ## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java: ## @@ -118,35 +129,56 @@ public Collection states() {

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579026948 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTransactionTestUtils.java: ## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

2024-04-25 Thread via GitHub
alievmirza closed pull request #3422: IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys URL: https://github.com/apache/ignite-3/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-25 Thread via GitHub
denis-chudov commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1579029801 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItTxResourcesVacuumTest.java: ## @@ -0,0 +1,559 @@ +/* + * Licensed to the Apache Softw

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1579037309 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/HashJoinNode.java: ## @@ -0,0 +1,718 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1167,14 +1180,9 @@ public void catalogActivationTime() throw

Re: [PR] IGNITE-21850 Enable LogSinkTest [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander merged PR #3646: URL: https://github.com/apache/ignite-3/pull/3646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579071207 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1719,14 +1728,11 @@ public void testColumnEvents() {

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579069437 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1167,14 +1180,9 @@ public void catalogActivationTime() throw

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
AMashenkov commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579072271 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1748,19 +1754,12 @@ public void userFutureCompletesAfterClu

Re: [PR] IGNITE-22095 Remove compute job jars from the repo [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander commented on code in PR #3655: URL: https://github.com/apache/ignite-3/pull/3655#discussion_r1579100049 ## modules/compute/jobs.gradle: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreem

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579110626 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1719,14 +1728,11 @@ public void testColumnEvents() { @T

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579111608 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java: ## @@ -1748,19 +1754,12 @@ public void userFutureCompletesAfterClust

[PR] Custom Metrics : + LongValueMetric exampls [ignite]

2024-04-25 Thread via GitHub
Vladsz83 opened a new pull request, #11332: URL: https://github.com/apache/ignite/pull/11332 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] IGNITE-21938 Sql. Cover SQL F041-07 feature by tests [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich commented on code in PR #3642: URL: https://github.com/apache/ignite-3/pull/3642#discussion_r1579147174 ## modules/sql-engine/src/integrationTest/sql/join/inner/test_table_from_outer_join_used_in_inner.test: ## @@ -0,0 +1,55 @@ +# name: sql/join/inner/test_table_fr

Re: [PR] IGNITE-22093: Sql. Rename PlannerPhase::HEP_DECORRELATE [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich merged PR #3652: URL: https://github.com/apache/ignite-3/pull/3652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo opened a new pull request, #3659: URL: https://github.com/apache/ignite-3/pull/3659 https://issues.apache.org/jira/browse/IGNITE-22105 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

[PR] IGNITE-21953: Cover SQL E021-01(Character string types. CHARACTER data type) feature by tests [ignite-3]

2024-04-25 Thread via GitHub
ygerzhedovich opened a new pull request, #3660: URL: https://github.com/apache/ignite-3/pull/3660 https://issues.apache.org/jira/browse/IGNITE-21953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] IGNITE-22095 Remove compute job jars from the repo [ignite-3]

2024-04-25 Thread via GitHub
PakhomovAlexander merged PR #3655: URL: https://github.com/apache/ignite-3/pull/3655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579468084 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extend

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
rpuch commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579306454 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private ClusterSta

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579471498 ## modules/cluster-management/src/test/java/org/apache/ignite/internal/cluster/management/raft/AbstractClusterStateStorageTest.java: ## @@ -371,11 +330,26 @@ void sn

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579473233 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private Cluste

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579522019 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java: ## @@ -104,19 +102,16 @@ void setUp() { () ->

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579524843 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -91,11 +92,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
rpuch commented on code in PR #3659: URL: https://github.com/apache/ignite-3/pull/3659#discussion_r1579525030 ## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java: ## @@ -350,52 +352,66 @@ private ClusterSta

Re: [PR] IGNITE-22105 Add busy lock to RocksDbClusterStateStorage [ignite-3]

2024-04-25 Thread via GitHub
sashapolo merged PR #3659: URL: https://github.com/apache/ignite-3/pull/3659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579528313 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/CatalogTestUtils.java: ## @@ -126,10 +124,8 @@ public void beforeNodeStop() { }

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579572557 ## modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientHandlerModule.java: ## @@ -228,10 +230,16 @@ public void stop() throws Exception {

Re: [PR] Bump com.github.johnrengelman.shadow from 7.1.2 to 8.1.1 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3397: URL: https://github.com/apache/ignite-3/pull/3397#issuecomment-2077338901 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump org.threeten:threetenbp from 1.6.8 to 1.6.9 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3494: URL: https://github.com/apache/ignite-3/pull/3494#issuecomment-2077339983 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3648: URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077339817 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579578818 ## modules/client/src/test/java/org/apache/ignite/client/TestServer.java: ## @@ -315,10 +317,11 @@ public FakePlacementDriver placementDriver() { /** {@inheritDoc}

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579590642 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579604057 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579604057 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579605232 ## modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitStoreImplTest.java: ## @@ -102,12 +102,12 @@ public void setup() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579617708 ## modules/compute/src/test/java/org/apache/ignite/internal/compute/ComputeComponentImplTest.java: ## @@ -477,12 +478,12 @@ void remoteExecutionReleasesStopLock() throw

Re: [PR] IGNITE-21830 [ignite]

2024-04-25 Thread via GitHub
Vladsz83 commented on code in PR #11327: URL: https://github.com/apache/ignite/pull/11327#discussion_r1579619834 ## modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java: ## @@ -7287,10 +7287,18 @@ private InetSocketAddress checkConnection(List addrs, i

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579636368 ## modules/core/src/main/java/org/apache/ignite/internal/manager/IgniteComponent.java: ## @@ -47,7 +47,7 @@ default void beforeNodeStop() { * Stops the component.

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579640666 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java: ## @@ -1175,24 +1176,58 @@ public static byte[] byteBufferToByteArray(ByteBuffer buffer

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579648035 ## modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/distributionzones/ItIgniteDistributionZoneManagerNodeRestartTest.java: ## @@ -297,7 +3

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579654791 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/BaseDistributionZoneManagerTest.java: ## @@ -138,11 +134,11 @@ public void tear

Re: [PR] Bump com.github.johnrengelman.shadow from 7.1.2 to 8.1.1 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn merged PR #3397: URL: https://github.com/apache/ignite-3/pull/3397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump org.threeten:threetenbp from 1.6.8 to 1.6.9 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn merged PR #3494: URL: https://github.com/apache/ignite-3/pull/3494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn commented on PR #3648: URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077487178 Build failed. @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] commented on PR #3648: URL: https://github.com/apache/ignite-3/pull/3648#issuecomment-2077487393 OK, I won't notify you about version 11.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] closed pull request #3648: Bump fr.inria.gforge.spoon:spoon-core from 10.4.3-beta-20 to 11.0.1-beta-3 URL: https://github.com/apache/ignite-3/pull/3648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Bump netty from 4.1.108.Final to 4.1.109.Final [ignite-3]

2024-04-25 Thread via GitHub
ptupitsyn merged PR #3657: URL: https://github.com/apache/ignite-3/pull/3657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22104 : Documentation of Custom Metrics [ignite]

2024-04-25 Thread via GitHub
NSAmelchev commented on code in PR #11331: URL: https://github.com/apache/ignite/pull/11331#discussion_r1579675414 ## docs/_docs/monitoring-metrics/custom-metrics.adoc: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor lic

Re: [PR] IGNITE-22104 : Documentation of Custom Metrics [ignite]

2024-04-25 Thread via GitHub
NSAmelchev commented on code in PR #11331: URL: https://github.com/apache/ignite/pull/11331#discussion_r1579679939 ## docs/_docs/monitoring-metrics/custom-metrics.adoc: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor lic

Re: [PR] IGNITE-22104 : Documentation of Custom Metrics [ignite]

2024-04-25 Thread via GitHub
NSAmelchev commented on code in PR #11331: URL: https://github.com/apache/ignite/pull/11331#discussion_r1579683015 ## docs/_docs/monitoring-metrics/custom-metrics.adoc: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor lic

Re: [PR] IGNITE-22104 : Documentation of Custom Metrics [ignite]

2024-04-25 Thread via GitHub
NSAmelchev commented on code in PR #11331: URL: https://github.com/apache/ignite/pull/11331#discussion_r1579687570 ## docs/_docs/monitoring-metrics/custom-metrics.adoc: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor lic

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
alievmirza commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579656780 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -363,6 +361,30 @@ public CompletableFuture compactCatalog(long t

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579694364 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -226,7 +226,10 @@ private void createAndStartComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22104 : Documentation of Custom Metrics [ignite]

2024-04-25 Thread via GitHub
NSAmelchev commented on code in PR #11331: URL: https://github.com/apache/ignite/pull/11331#discussion_r1579683015 ## docs/_docs/monitoring-metrics/custom-metrics.adoc: ## @@ -0,0 +1,67 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor lic

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579697076 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageManagerImplTest.java: ## @@ -139,9 +139,9 @@ void setUp(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579701159 ## modules/index/src/test/java/org/apache/ignite/internal/index/IndexManagerTest.java: ## @@ -123,8 +123,8 @@ public void setUp() { } @AfterEach -void t

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579702498 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java: ## @@ -363,6 +361,30 @@ public CompletableFuture compactCatalog(long tim

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579703433 ## modules/metastorage/src/integrationTest/java/org/apache/ignite/internal/metastorage/impl/ItMetaStorageServiceTest.java: ## @@ -201,8 +201,8 @@ private static class N

[PR] Bump io.github.bonede:tree-sitter from 0.22.2 to 0.22.5 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] opened a new pull request, #3661: URL: https://github.com/apache/ignite-3/pull/3661 Bumps [io.github.bonede:tree-sitter](https://github.com/bonede/tree-sitter-ng) from 0.22.2 to 0.22.5. Release notes Sourced from https://github.com/bonede/tree-sitter-ng/releases";>

[PR] Bump org.openapi.generator from 7.4.0 to 7.5.0 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] opened a new pull request, #3662: URL: https://github.com/apache/ignite-3/pull/3662 Bumps org.openapi.generator from 7.4.0 to 7.5.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.openapi.ge

[PR] Bump bouncycastle from 1.76 to 1.78.1 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] opened a new pull request, #3663: URL: https://github.com/apache/ignite-3/pull/3663 Bumps `bouncycastle` from 1.76 to 1.78.1. Updates `org.bouncycastle:bcprov-jdk18on` from 1.76 to 1.78.1 Commits See full diff in https://github.com/bcgit/bc-java/commits";>comp

[PR] Bump io.github.bonede:tree-sitter-json from 0.20.1 to 0.21.0 [ignite-3]

2024-04-25 Thread via GitHub
dependabot[bot] opened a new pull request, #3664: URL: https://github.com/apache/ignite-3/pull/3664 Bumps [io.github.bonede:tree-sitter-json](https://github.com/bonede/tree-sitter-ng) from 0.20.1 to 0.21.0. Release notes Sourced from https://github.com/bonede/tree-sitter-ng/releas

Re: [PR] IGNITE-21859 Causality token stays 0 for default zone [ignite-3]

2024-04-25 Thread via GitHub
korlov42 commented on code in PR #3653: URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579707204 ## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/storage/NewZoneEntry.java: ## @@ -72,13 +72,17 @@ public CatalogEventParameters createEventParamet

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579723031 ## modules/network/src/testFixtures/java/org/apache/ignite/internal/network/utils/ClusterServiceTestUtils.java: ## @@ -178,24 +177,12 @@ public CompletableFuture start(

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724136 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/Node.java: ## @@ -52,13 +55,13 @@ class Node implements AutoCloseable {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579724921 ## modules/placement-driver/src/integrationTest/java/org/apache/ignite/internal/placementdriver/PlacementDriverManagerTest.java: ## @@ -209,14 +209,14 @@ private void s

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579728997 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -221,8 +221,8 @@ String name() { } void

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579727992 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLearnersTest.java: ## @@ -120,8 +120,8 @@ Peer asPeer() { } void start()

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579729570 ## modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItRaftGroupServiceTest.java: ## @@ -258,7 +258,10 @@ void beforeNodeStop() throws Exception {

[PR] IGNITE-22064 General MapReduce API [ignite-3]

2024-04-25 Thread via GitHub
valepakh opened a new pull request, #3665: URL: https://github.com/apache/ignite-3/pull/3665 https://issues.apache.org/jira/browse/IGNITE-22064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579823834 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/ItSimpleCounterServerTest.java: ## @@ -97,14 +100,12 @@ void before() throws Exception {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579824596 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java: ## @@ -171,7 +173,7 @@ protected JraftServerImpl startServer(int idx, Co

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579841013 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579840663 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579846730 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -698,7 +698,9 @@ public CompletableFuture> dataNode

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857130 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java: ## @@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extend

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579857581 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579859118 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579860866 ## modules/catalog/src/testFixtures/java/org/apache/ignite/internal/catalog/BaseCatalogManagerTest.java: ## @@ -104,19 +102,16 @@ void setUp() { () ->

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579864902 ## modules/runner/src/main/java/org/apache/ignite/internal/app/LifecycleManager.java: ## @@ -148,12 +153,11 @@ private synchronized void stopAllComponents() {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579866759 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java: ## @@ -452,7 +452,13 @@ public synchronized void stop() throws Excepti

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579867816 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -53,18 +53,18 @@ public class DdlC

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579870204 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
sanpwc commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880267 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ## @@ -142,20 +143,26 @@ public CompletableFuture start() { } @Ov

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579880642 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -1180,16 +1181,24 @@ private RuntimeException handleStartException(Throwable e) {

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579885185 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ddl/DdlCommandHandlerExceptionHandlingTest.java: ## @@ -53,18 +53,18 @@ public class DdlC

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579887023 ## modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildingManager.java: ## @@ -142,20 +143,26 @@ public CompletableFuture start() { } @Ov

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579892848 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579893056 ## modules/replicator/src/integrationTest/java/org/apache/ignite/internal/replicator/ItPlacementDriverReplicaSideTest.java: ## @@ -195,19 +197,19 @@ public void beforeT

Re: [PR] IGNITE-22071 Async component stop [ignite-3]

2024-04-25 Thread via GitHub
Cyrill commented on code in PR #3629: URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579896240 ## modules/raft/src/integrationTest/java/org/apache/ignite/raft/server/JraftAbstractTest.java: ## @@ -171,7 +173,7 @@ protected JraftServerImpl startServer(int idx, Co

  1   2   >