How to review an entire application?

2010-02-22 Thread skip
I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url & fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a n

Re: ReviewBoard Error while posting review for GIT

2010-02-22 Thread Kunjal
Any update on this one? I am again stuck here... Kunjal On Feb 11, 2:01 pm, Kunjal wrote: > So, you are saying that Path variable in Admin GUI should be empty and > Mirror Path: should list the git repository? > > Path: Empty string > Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo

Re: ReviewBoard Error while posting review for GIT

2010-02-22 Thread Christian Hammond
Never saw this e-mail. Must have missed it while on vacation. With the raw URL stuff, actually you can set Path as the git repo, because we'll never use it to access files. cgit has to run on the upstream git repository, so on mobcom-git.sj.broadcom.com probably. *Something* needs local access to

Update dev build instructions

2010-02-22 Thread Raja
When browsing through the dev list, I got the instructions to build reviewboard from source here: http://www.reviewboard.org/docs/codebase/dev/getting-started/ The instructions seem out-of-date with the current trunk and seem to need 2 more dependency packages. Can someone please update the dev b

Re: Setting up developer environment

2010-02-22 Thread Raja
It looks like you need to get django_evolution from easy_install django_evolution or code.google.com/p/django-evolution/ I just created a post with missing packages in the dependency list, but missed this one (as I had installed reviewboard earlier using easy_install). -- Raja On Feb 18, 12:10

Re: Update dev build instructions

2010-02-22 Thread Christian Hammond
Hi Raja, Would you mind filing a bug for tracking purposes? Or if you want to quickly update them yourself, you could even modify the docs yourself (reviewboard/docs/codebase/getting-started.txt) and submit a patch to http://reviews.reviewboard.org/. Christian -- Christian Hammond - chip...@chi

Re: How to review an entire application?

2010-02-22 Thread Christian Hammond
Hi Skip, Your versions of post-review and Review Board sound pretty out-of-date, first of all, so I'd recommend setting aside some time to do an upgrade. Let me see if I have this right. You have a directory full of committed code that hasn't been reviewed yet. This code may span multiple revisio

Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The use

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stephen Gallagher
On 02/22/2010 03:10 PM, Stodge wrote: > I'm using the remote user middleware/backend to support basic http > authentication: > > 'django.contrib.auth.middleware.RemoteUserMiddleware', > > and it seems to work nicely with Review Board. Apache forces a user to > login and then this middleware/backend

Re: How to review an entire application?

2010-02-22 Thread skip
Christian> Let me see if I have this right. You have a directory full of Christian> committed code that hasn't been reviewed yet. This code may Christian> span multiple revisions. You want to put that code up for Christian> review. Is that correct? Yup. Christian> There's no

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Stodge
Thanks. So I would need to write a custom backend/middleware instead? On Feb 22, 3:20 pm, Stephen Gallagher wrote: > On 02/22/2010 03:10 PM, Stodge wrote:> I'm using the remote user > middleware/backend to support basic http > > authentication: > > > 'django.contrib.auth.middleware.RemoteUserMid

Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address

2010-02-22 Thread Christian Hammond
Or we should figure out a scheme to allow for setting that on other backends. Could check an attribute on the backend. Maybe assume that we can set that info and have a flag for turning it off, which LDAP, NIS, etc. can do. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http