Re: Review Request 54471: AMBARI-19025. Add livy.spark.master to livy.conf and update spark-blacklist.conf

2016-12-06 Thread Jeff Zhang
> On Dec. 7, 2016, 5:43 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/configuration/livy-conf.xml, > > line 21 > > > > > > If these are new config types - should they b

Re: Review Request 54447: Add timeout for LogSearch and Infra Solr metainfo.xml

2016-12-06 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54447/#review158308 --- Ship it! Ship It! - Attila Doroszlai On Dec. 6, 2016, 9:51 p

Re: Review Request 54471: AMBARI-19025. Add livy.spark.master to livy.conf and update spark-blacklist.conf

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54471/#review158307 --- ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/co

Review Request 54471: AMBARI-19025. Add livy.spark.master to livy.conf and update spark-blacklist.conf

2016-12-06 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54471/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Re: Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA

2016-12-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/#review158291 --- ambari-web/app/messages.js (lines 1408 - 1409)

Review Request 54466: AMBARI-19118 - Ranger Admin Start failed while enabling NameNode HA

2016-12-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54466/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-19118

Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-06 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54460/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. Bugs: A

Re: Review Request 54405: HDP 3.0 support for HDFS with configs, kerberos, widgets, metrics, quicklinks, and themes

2016-12-06 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54405/#review158285 --- ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/ker

Re: Review Request 54404: HDP 3.0 support for ZK with metainfo

2016-12-06 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54404/#review158286 --- Ship it! Ship It! - Swapan Shridhar On Dec. 6, 2016, 1 a.m.,

Re: Review Request 54402: HDP 3.0 TP - bootstrap the stack with metainfo, cluster-env, repos, and hooks

2016-12-06 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54402/#review158284 --- Ship it! - Swapan Shridhar On Dec. 6, 2016, 12:33 a.m., Aleja

Review Request 54444: AMBARI-19116. Hive2/HiveServer2 (HSI) heap size calculation to be based on LLAP concurrency.

2016-12-06 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Re: Review Request 54444: AMBARI-19116. Hive2/HiveServer2 (HSI) heap size calculation to be based on LLAP concurrency.

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review158283 --- Ship it! Ship It! - Sumit Mohanty On Dec. 7, 2016, 1:05 a.m.

Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.

2016-12-06 Thread alice alice
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/ --- (Updated 十二月 7, 2016, 12:53 a.m.) Review request for Ambari, Zhe (Joe) Wang and

Re: Review Request 54458: HDP 3.0 support for YARN/MR with configs, kerberos, widgets, metrics, quicklinks, and themes

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54458/#review158276 --- Ship it! Ship It! - Sumit Mohanty On Dec. 7, 2016, 12:07 a.m

Re: Review Request 54406: Improve and Fix "Wizard pages" after new guidelines

2016-12-06 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54406/ --- (Updated Dec. 6, 2016, 4:40 p.m.) Review request for Ambari, Jaimin Jetly, Rich

Re: Review Request 54405: HDP 3.0 support for HDFS with configs, kerberos, widgets, metrics, quicklinks, and themes

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54405/#review158275 --- Ship it! Ship It! - Sumit Mohanty On Dec. 6, 2016, 1:03 a.m.

Re: Review Request 54404: HDP 3.0 support for ZK with metainfo

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54404/#review158271 --- Ship it! Ship It! - Sumit Mohanty On Dec. 6, 2016, 1 a.m., A

Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.

2016-12-06 Thread alice alice
> On 十二月 6, 2016, 3:03 p.m., Jonathan Hurley wrote: > > I normally don't review web client requests since I have little experience > > with that part of the codebase... OK,thank you all the same for your swift respondence. - alice ---

Re: Review Request 54402: HDP 3.0 TP - bootstrap the stack with metainfo, cluster-env, repos, and hooks

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54402/#review158268 --- Ship it! Ship It! - Sumit Mohanty On Dec. 6, 2016, 12:33 a.m

Re: Review Request 54402: HDP 3.0 TP - bootstrap the stack with metainfo, cluster-env, repos, and hooks

2016-12-06 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54402/#review158266 --- ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_

Re: Review Request 54406: Improve and Fix "Wizard pages" after new guidelines

2016-12-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54406/#review158264 --- Ship it! Ship It! - Richard Zang On Dec. 6, 2016, 1:44 a.m.,

Re: Review Request 53727: AMBARI-18874 : Provide SSL related configurations for Ranger-Tagsync.

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53727/#review158261 --- ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/c

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54002/#review158259 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 2, 2016, 3:5

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review158258 --- Fix it, then Ship it! At some point we also need a cmd-line dri

Re: Review Request 54450: AMBARI-19114 Update hardcoded stack version warning to be more general than saying hdp

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54450/#review158257 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 6, 2016, 10:

Re: Review Request 54447: Add timeout for LogSearch and Infra Solr metainfo.xml

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54447/#review158256 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 6, 2016, 8:5

Review Request 54458: HDP 3.0 support for YARN/MR with configs, kerberos, widgets, metrics, quicklinks, and themes

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54458/ --- Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle. Bugs:

Re: Review Request 54457: AMBARI-19089 - Manage Journalnode Wizard is stuck at Add/Remove JournalNodes in Kerberized Cluster

2016-12-06 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54457/#review158252 --- Ship it! Ship It! - Jaimin Jetly On Dec. 6, 2016, 11:15 p.m.

Review Request 54457: AMBARI-19089 - Manage Journalnode Wizard is stuck at Add/Remove JournalNodes in Kerberized Cluster

2016-12-06 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54457/ --- Review request for Ambari, Jaimin Jetly and Yusaku Sako. Bugs: AMBARI-19089

Re: Review Request 54447: Add timeout for LogSearch and Infra Solr metainfo.xml

2016-12-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54447/#review158244 --- Ship it! Ship It! - Miklos Gergely On Dec. 6, 2016, 8:51 p.m

Re: Review Request 54450: AMBARI-19114 Update hardcoded stack version warning to be more general than saying hdp

2016-12-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54450/#review158242 --- Ship it! Ship It! - Tim Thorpe On Dec. 6, 2016, 10:18 p.m.,

Review Request 54450: AMBARI-19114 Update hardcoded stack version warning to be more general than saying hdp

2016-12-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54450/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19114 https://issues

Re: Review Request 54431: AMBARI-19111: Ambari server upgrade log printout refactoring

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/#review158224 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 6, 2016, 7:3

Review Request 54447: Add timeout for LogSearch and Infra Solr metainfo.xml

2016-12-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54447/ --- Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, S

Re: Review Request 54431: AMBARI-19111: Ambari server upgrade log printout refactoring

2016-12-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/#review158208 --- Ship it! Ship It! - Tim Thorpe On Dec. 6, 2016, 7:30 p.m., D

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review158205 --- Fix it, then Ship it! Mostly nits to cleanup and clarify... a

Re: Review Request 54431: AMBARI-19111: Ambari server upgrade log printout refactoring

2016-12-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/ --- (Updated Dec. 6, 2016, 7:30 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-12-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54002/#review158200 --- Ship it! Ship It! - Sid Wagle On Dec. 2, 2016, 3:57 p.m., At

Re: Review Request 54431: AMBARI-19111: Ambari server upgrade log printout refactoring

2016-12-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/#review158199 --- ambari-common/src/main/python/ambari_commons/logging_utils.py (li

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Dec. 6, 2016, 8:44 p.m.) Review request for Ambari, Jonathan Hurley an

Re: Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54425/ --- (Updated Dec. 6, 2016, 6:20 p.m.) Review request for Ambari and Aleksandr Koval

Review Request 54431: AMBARI-19111: Ambari server upgrade log printout refactoring

2016-12-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/ --- Review request for Ambari, Alejandro Fernandez and Tim Thorpe. Bugs: AMBARI-191

Re: Review Request 54424: AMBARI-19107 False warning about NTP not running on SUSE12

2016-12-06 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54424/#review158193 --- Ship it! Ship It! - Sid Wagle On Dec. 6, 2016, 3:38 p.m., At

Re: Review Request 54357: AMBARI-19077: Ambari-server: Gather dependent configuration types and password properties for a service component

2016-12-06 Thread Nate Cole
> On Dec. 5, 2016, 4:36 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 376-379 > > > > > > Do clients matter here? Clients have no START but do use conf

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review158177 --- Ship it! Ship It! - Nate Cole On Dec. 6, 2016, 11:29 a.m., D

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Dec. 6, 2016, 6:29 p.m.) Review request for Ambari, Jonathan Hurley an

Re: Review Request 54080: Auto-fix common issues found by the DB consistency checker

2016-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Dec. 6, 2016, 6:24 p.m.) Review request for Ambari, Jonathan Hurley an

Re: Review Request 54357: AMBARI-19077: Ambari-server: Gather dependent configuration types and password properties for a service component

2016-12-06 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54357/ --- (Updated Dec. 6, 2016, 8:23 a.m.) Review request for Ambari, Jonathan Hurley, N

Re: Review Request 53727: AMBARI-18874 : Provide SSL related configurations for Ranger-Tagsync.

2016-12-06 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53727/ --- (Updated Dec. 6, 2016, 4:02 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 53727: Provide SSL related configurations for Ranger-Tagsync.

2016-12-06 Thread Vishal Suvagia
> On Nov. 30, 2016, 6:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml, > > line 23 > > > > > > EU/RU will have to change t

Re: Review Request 54392: Putting a service or process in Maintenance Mode doesn't take it off of the "Restart All Required" list

2016-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54392/#review158166 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 5, 2016, 11:4

Re: Review Request 53727: Provide SSL related configurations for Ranger-Tagsync.

2016-12-06 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53727/ --- (Updated Dec. 6, 2016, 3:56 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 54423: Kerberos wizard is broken if stacks doesn't contain Ranger

2016-12-06 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54423/#review158165 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 6, 2016, 2:49

Review Request 54424: AMBARI-19107 False warning about NTP not running on SUSE12

2016-12-06 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54424/ --- Review request for Ambari, Alejandro Fernandez, Masahiro Tanaka, Sebastian Toade

Re: Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-06 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54425/#review158162 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 6, 2016, 3:2

Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54425/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-19108 https

Re: Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing.

2016-12-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51640/#review158159 --- I normally don't review web client requests since I have little ex

Review Request 54423: Kerberos wizard is broken if stacks doesn't contain Ranger

2016-12-06 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54423/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-19106 https:

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54378/#review158149 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 6, 2016, 1:57

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54378/ --- (Updated Dec. 6, 2016, 11:57 a.m.) Review request for Ambari and Dmitro Lisnich

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
> On Dec. 5, 2016, 4:01 p.m., Sumit Mohanty wrote: > > Can we modify the description property in the stack definition? Done - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54378/#rev

Re: Review Request 54378: Clean up how dfs.cluster.administrators is handled wrt user/group creation

2016-12-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54378/ --- (Updated Dec. 6, 2016, 11:56 a.m.) Review request for Ambari and Dmitro Lisnich

Re: Review Request 54379: Host Ordered upgrade should not show as an Upgrade option in UI

2016-12-06 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54379/#review158138 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 6, 2016, 10:

Re: Review Request 54379: Host Ordered upgrade should not show as an Upgrade option in UI

2016-12-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54379/ --- (Updated Dec. 6, 2016, 10:22 a.m.) Review request for Ambari and Aleksandr Kova

Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration

2016-12-06 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54413/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshresht

Re: Review Request 54403: AMBARI-19101 : Merge AMS service check support for HA from trunk

2016-12-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54403/#review158137 --- Ship it! Ship It! - Dmytro Sen On Дек. 6, 2016, 12:42 д.п.,

Re: Review Request 54412: AMBARI-19080 Ambari stack-advisor error while adding knox service

2016-12-06 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54412/#review158136 --- Ship it! Ship It! - Gautam Borad On Dec. 6, 2016, 9 a.m., Mu

Review Request 54412: AMBARI-19080 Ambari stack-advisor error while adding knox service

2016-12-06 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54412/ --- Review request for Ambari, Alejandro Fernandez and Gautam Borad. Bugs: AMBARI-1

Re: Review Request 54399: Broken links in ambari-server/docs/api/v1/schemas.md

2016-12-06 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54399/#review158130 --- Ship it! Ship It! - Sandor Magyari On Dec. 6, 2016, 12:06 a.