[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3586/1//COMMIT_MSG Commit Message: Line 9: TabletClient

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3586 to look at the new patch set (#2). Change subject: [java-client] Fix a hang in TabletClient .. [java-client] Fix a

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3586/1//COMMIT_MSG Commit Message: Line 9: Table

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2224/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3586 To unsubscribe, visit http://gerrit.

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 2: Looks fine, but the cascading series of fixes to this code has left me with zero confidence that we got it

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] Fix a hang in TabletClient .. Patch Set 2: > Looks fine, but the cascading series of fixes to this code has left > me with zero confidence th

[kudu-CR] WIP: ts-cli: add commands to trigger step-down and copying tablets

2016-07-07 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: ts-cli: add commands to trigger step-down and copying tablets .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3582/1/src/kudu/tools/ts-cl

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: RFC [java client] Redo how we manage exceptions .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2225/ -- To view, visit http://gerrit.cloude

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#2). Change subject: RFC [java client] Redo how we manage exceptions .. RFC [java cli

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: RFC [java client] Redo how we manage exceptions .. Patch Set 2: Latest patch is just a rebase since many things changed in the Java client (although I did

[kudu-CR] [java-client] Fix a hang in TabletClient

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java-client] Fix a hang in TabletClient .. [java-client] Fix a hang in TabletClient TabletClient#sendRpc has been changing a lot lately, and it's

[kudu-CR] master: only use tablet reports to notify master of altered tablets

2016-07-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: only use tablet reports to notify master of altered tablets .. Patch Set 2: > would you mind looping alter_table-test a bit to make sure this > doesn't ca

[kudu-CR] master: only use tablet reports to notify master of altered tablets

2016-07-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: master: only use tablet reports to notify master of altered tablets .. master: only use tablet reports to notify master of altered tablets One or more alt

[kudu-CR] master: handle RPC responses on reactor threads

2016-07-07 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: master: handle RPC responses on reactor threads .. master: handle RPC responses on reactor threads The introduction of the election rwlock requires that th

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: RFC [java client] Redo how we manage exceptions .. Patch Set 1: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/2225/ : FAILURE This is a real

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#3). Change subject: RFC [java client] Redo how we manage exceptions .. RFC [java cli

[kudu-CR] RFC [java client] Redo how we manage exceptions

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: RFC [java client] Redo how we manage exceptions .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2226/ -- To view, visit http://gerrit.cloude

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3501/5/src/kudu/consensus/consensus_q

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 1: (6 comments) didn't do a detailed look at the actual algorithm, mostly some nitty type stuf

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3593 Change subject: Add ComputeIfAbsent methods to map-util .. Add ComputeIfAbsent methods to map-util This adds two new ComputeIfAbse

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2227/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3593 to look at the new patch set (#2). Change subject: Add ComputeIfAbsent methods to map-util .. Add ComputeIfAbsent m

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2228/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2229/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3593 to look at the new patch set (#3). Change subject: Add ComputeIfAbsent methods to map-util .. Add ComputeIfAbsent m

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3593/3/src/kudu/gutil/map-util.h File src/kudu/gutil/map-

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3593 to look at the new patch set (#4). Change subject: Add ComputeIfAbsent methods to map-util .. Add ComputeIfAbsent m

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/3593/3/src/kudu/gutil/map-util.h File src/kudu/gu

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2230/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3593/4/src/kudu/gutil/map-util.h File src/ku

[kudu-CR](gh-pages) kudu flume sink blog post

2016-07-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: kudu flume sink blog post .. Patch Set 1: (27 comments) Sorry for the delay, I was out of town for a while. Because the date already passed, let's shoot for a pub

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3593/4/src/kudu/gutil/map-util.h File src/kudu/gut

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-07 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 1: (9 comments) I just did a skim; will leave the detailed review for Todd. http://gerrit.cloud

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3593 to look at the new patch set (#5). Change subject: Add ComputeIfAbsent methods to map-util .. Add Comp

[kudu-CR] Add ComputeIfAbsent methods to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add ComputeIfAbsent methods to map-util .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2231/ -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3594 Change subject: Add a FindPointeeOrNull method to map-util .. Add a FindPointeeOrNull method to map-util This adds a new FindPoint

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-07 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a FindPointeeOrNull method to map-util .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2232/ -- To view, visit http://gerrit.cloudera.or

[kudu-CR] Add a FindPointeeOrNull method to map-util

2016-07-07 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a FindPointeeOrNull method to map-util .. Patch Set 1: Verified+1 unrelated failures -- To view, visit http://gerrit.cloudera.org:8080/3594 To unsubs