Re: [webkit-dev] Removing support for CSS regions

2017-08-02 Thread Andreas Kling
> On 2 Aug 2017, at 09:00, Ryosuke Niwa wrote: > > On Tue, Aug 1, 2017 at 11:40 PM, Andreas Kling <mailto:akl...@apple.com>> wrote: >> >>> On 2 Aug 2017, at 01:03, Ryosuke Niwa wrote: >>> >>> On Mon, Jul 31, 2017 at 1:49 AM, Andreas Kling

Re: [webkit-dev] Removing support for CSS regions

2017-08-01 Thread Andreas Kling
> On 2 Aug 2017, at 01:03, Ryosuke Niwa wrote: > > On Mon, Jul 31, 2017 at 1:49 AM, Andreas Kling wrote: >> Some time has passed, and it seems that adoption of CSS regions on the web >> is not gonna happen. >> >> Blink has long since removed their support. &g

Re: [webkit-dev] Removing support for CSS regions

2017-08-01 Thread Andreas Kling
> On 1 Aug 2017, at 15:38, Dean Jackson wrote: > > I've been told that Amazon's Kindle Cloud Reader uses CSS Regions if > available, and gets a significant performance boost. It has a fallback though. Hi Dean! I’ve WebInspected around in a few books using Kindle Cloud Reader and can’t find a

[webkit-dev] Removing support for CSS regions

2017-07-31 Thread Andreas Kling
Hi folks, Some time has passed, and it seems that adoption of CSS regions on the web is not gonna happen. Blink has long since removed their support. Firefox never supported it AFAIK. (The new) IE has some amount of support behind a prefix, but no plans to unprefix AFAIK. I think it’s time we

Re: [webkit-dev] Should overridden methods use 'virtual' keyword in addition to 'override'?

2016-03-03 Thread Andreas Kling
Huh, I thought we had already decided on this and have been writing new code in this style :) Andreas > On Mar 3, 2016, at 8:24 PM, Brent Fulgham wrote: > > +1. I am in favor of this as well! > > -Brent > >> On Mar 3, 2016, at 11:23 AM, Saam barati wrote: >> >> +1. >> I like how “override”

Re: [webkit-dev] A quick note on Ref and RefPtr changes

2015-03-19 Thread Andreas Kling
> On Mar 19, 2015, at 12:43 PM, Adam Bergkvist > wrote: > > On 17/02/15 10:28, Adam Bergkvist wrote: >> On 15/12/14 19:59, Andreas Kling wrote: >>> PS. Once the kinks are ironed out, I’ll also be updating the RefPtr >>> documentation on webkit.org. >>

[webkit-dev] A quick note on Ref and RefPtr changes

2014-12-15 Thread Andreas Kling
Howdy folks, Thanks to the magic of C++11, we don’t need PassRef and PassRefPtr anymore, as we can use rvalue references and move semantics to achieve churn-free ownership transfers. I’ve already removed PassRef entirely, and PassRefPtr will be next. Given how widely it’s used in the codebase,

[webkit-dev] Pratik Solanki is now a WebKit reviewer

2014-06-27 Thread Andreas Kling
Hi WebKittens! I’m happy to announce that Pratik is now a WebKit reviewer. He’s been with the project for a long time, though he spent most of his time hacking on Apple’s internal iOS branch of WebKit. Now that iOS WebKit lives on trunk, so does Pratik! He’s forgotten more than I know about iOS

[webkit-dev] Spatial Navigation: any users?

2014-02-17 Thread Andreas Kling
Hi WebKittens! Is anyone using the spatial navigation feature in WebCore? (Navigating with up/down/left/right arrows instead of mouse/touch interaction.) -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/li

Re: [webkit-dev] Web Components development will continue in a branch in near future

2014-02-15 Thread Andreas Kling
On Feb 15, 2014, at 4:07 PM, Ryosuke Niwa wrote: > Hi all, > > Now that we've removed all of the existing shadow DOM implementations from > trunk in http://trac.webkit.org/changeset/164131, I'm intending to work on > new web components implementations in a branch based on the feedback Apple >

Re: [webkit-dev] Credit change set & author when merging changes

2014-02-14 Thread Andreas Kling
> On Feb 14, 2014, at 1:38 AM, Sergio Villar Senin wrote: > > En 14/02/14 10:09, Gyuyoung Kim escribiu: >> Hi, >> >> When we merge own blink patch into WebKit, should we credit the original >> author in ChangeLog ? > > In those cases I don't personally do that. Right. There is no need to menti

Re: [webkit-dev] Proposal: Remove ENABLE(SVG)

2014-01-28 Thread Andreas Kling
This sounds good to me. A WebKit without SVG support is scarcely a WebKit at all. On Jan 28, 2014, at 4:13 PM, Sam Weinig wrote: > Hi Everyone, > > While we are discussing removing #ifdefs that everyone has enabled, I’d like > to propose removing ENABLE(SVG), as every port has SVG enabled. T

Re: [webkit-dev] When to use "auto"? (I usually consider it harmful)

2014-01-04 Thread Andreas Kling
On Jan 4, 2014, at 4:14 PM, Alex Christensen wrote: > Call me an extremist, but I would be in favor of a complete ban on auto. I've > been involved in another project deciding to not use auto at all. It forces > programmers to be explicit and careful, it shows the effects of type changes > wi

Re: [webkit-dev] When to use "auto"? (I usually consider it harmful)

2014-01-03 Thread Andreas Kling
On Jan 3, 2014, at 8:28 PM, Geoffrey Garen wrote: >> However I also feel the "harm" here is debatable enough that people working >> on/reviewing the code should make decisions instead of there being a project >> level dictate. It is a new thing, the appropriate usage hasn't yet settled >> and

[webkit-dev] Introducing RenderPtr!

2013-12-30 Thread Andreas Kling
Sup WebKittens, I’ve just added a “RenderPtr" smart pointer to the rendering code and am in the process of switching code from using raw pointers to this. Check out the code here: (note that I’ve since renamed createRenderObject to createRenderer per Antti’s su

[webkit-dev] Is anyone building without ENABLE(REQUEST_ANIMATION_FRAME)?

2013-11-13 Thread Andreas Kling
Hi WebKittens. Are there any ports building with ENABLE(REQUEST_ANIMATION_FRAME) turned off? If not, I’d like to get rid of the flag. -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Bugzilla editbugs-bit for fred DOT wang AT free DOT fr

2013-10-09 Thread Andreas Kling
The following changes have been made to the user account fred.w...@free.fr: • The account has been added to the editbugs group. -Kling On Oct 9, 2013, at 8:46 AM, Frédéric WANG wrote: > Hi all, > > Could someone please give me the editbugs permission on Bugzilla? > > Here are a few

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
running an ubuntu 32bit machine > only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has gcc 4.6.3 > version. I think the 32bit buildbot needs to be upgraded. I will do it. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: &

Re: [webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
ildbots are being ran > on two machines. As far as I know, those are based on Ubuntu 13.04 and have > same gcc 4.7.3. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > Hi folks, > > I recently landed a patch that makes use o

[webkit-dev] GCC version consistency on EFL bots?

2013-10-06 Thread Andreas Kling
Hi folks, I recently landed a patch that makes use of lowercased “override” and “final” in WebKit, and now the EFL build is failing. The EFL EWS bots didn’t have any problem with the patch however, which brings me to my question: Are the main/EWS bots running different versions of GCC? And if so

Re: [webkit-dev] Changes in QtWebKit development

2013-09-26 Thread Andreas Kling
On Sep 25, 2013, at 12:40 PM, Allan Sandfeld Jensen wrote: > On Saturday 14 September 2013, Andreas Kling wrote: >> On Sep 14, 2013, at 11:24 AM, Allan Sandfeld Jensen > wrote: >>> That said, in all likelihood the Qt port will not remain part of WebKit >>> forev

Re: [webkit-dev] Changes in QtWebKit development

2013-09-14 Thread Andreas Kling
On Sep 14, 2013, at 11:24 AM, Allan Sandfeld Jensen wrote: >> >> When "modules" of Qt are put on "maintenance", it is basically a synonym >> to "it's unmaintained, just let it die". I am very unexcited about >> having one of those in the tree along the live development from everyone >> else. >> I

Re: [webkit-dev] Can we disable "control reaches end of non-void function" warning on Qt?

2013-09-12 Thread Andreas Kling
On Sep 13, 2013, at 12:45 AM, Allan Sandfeld Jensen wrote: > Don't worry we are still here, just in fewer numbers, and with fewer things > to > support. Can you give us more details on what’s no longer supported? -Andreas___ webkit-dev mailing list

Re: [webkit-dev] Proposal: Remove Pointer Lock API

2013-08-19 Thread Andreas Kling
ts.webkit.org] On Behalf Of Gyuyoung Kim > Sent: 18 August 2013 03:38 > To: Andreas Kling > Cc: WebKit Development > Subject: Re: [webkit-dev] Proposal: Remove Pointer Lock API > > Hi Andreas, > > EFL port has not supported it yet. So, I think we don't mind to r

[webkit-dev] Changes to main Frame creation in WebCore

2013-08-18 Thread Andreas Kling
Hello everyone! Just a friendly heads-up that I’m planning to land some changes to the way main Frames are created in WebCore soon. Previously, the WebKit layer would create a Frame with no owner element, and Frame::create() would implicitly tell Page that this is going to be the Page::mainFra

[webkit-dev] Proposal: Remove Pointer Lock API

2013-08-17 Thread Andreas Kling
Hi WebKittens, I’d like to propose removing the Pointer Lock API code from WebKit. The code hasn’t been touched for 12 months, and AFAICT no ports are building with ENABLE(POINTER_LOCK). Is anyone currently building (and shipping / planning to ship) this API? Other thoughts? -Kling __

Re: [webkit-dev] Proposal: Remove Microdata support

2013-08-06 Thread Andreas Kling
Another +1 here. The complexity:usefulness ratio of this feature always seemed off to me. -Kling On Aug 5, 2013, at 10:44 PM, Brady Eidson wrote: > +1. > > I see no benefit to keeping the code around right now. > > ~Brady > > On Aug 5, 2013, at 1:16 PM, Sam Weinig wrote: > >> Hello, >> >

Re: [webkit-dev] Quick intro: FINAL and OVERRIDE

2013-07-26 Thread Andreas Kling
This e-mail had a fatal bug! Anders::dance() obviously needs to be marked FINAL for the inlining to occur :-) -Andreas On Jul 26, 2013, at 7:43 PM, Andreas Kling wrote: > Hi WebKittens! > > I’m about to re-land <http://webkit.org/b/115977> now that the OS X bots have &g

[webkit-dev] Quick intro: FINAL and OVERRIDE

2013-07-26 Thread Andreas Kling
Hi WebKittens! I’m about to re-land now that the OS X bots have had their clang installations updated. Let me take a moment to explain what FINAL and OVERRIDE do, and how to apply them. OVERRIDE is used to decorate virtual methods that override a method inherited

Re: [webkit-dev] All development moved private?

2013-07-12 Thread Andreas Kling
There’s also https://www.webkit.org/blog/ where we blog regularly about things going on, both small and large. -Andreas On Jul 12, 2013, at 8:06 PM, Oliver Hunt wrote: > Webkit development occurs on trunk and most communication is on IRC and in > bugs.webkit.org. If you rely on email to see

Re: [webkit-dev] For your consideration: Naming scheme for fooIfExists/ensureFoo

2013-06-19 Thread Andreas Kling
On Jun 19, 2013, at 6:37 PM, Timothy Hatcher wrote: > What about? > > StyleResolver* existingStyleResolver() > StyleResolver& styleResolver() +1 to these two. -Kling AKA the guy who named the methods we’re bike shedding about. :|___ webkit-dev mailin

Re: [webkit-dev] Use BlinkMergeCandidate to merge/back port Blink changes

2013-05-23 Thread Andreas Kling
On May 23, 2013, at 6:26 PM, Darin Adler wrote: > On May 23, 2013, at 8:42 AM, Sergio Villar Senin wrote: > >> There is an interesting question about merging fixes from Blink. Should we >> keep the original author in the ChangeLog appending the name of the merger >> maybe? > > Generally spea

Re: [webkit-dev] We should delete ENABLE_SHADOW_DOM

2013-05-16 Thread Andreas Kling
Second that. Seems pointless to keep code in the tree if nobody is building it. -Andreas On May 16, 2013, at 7:09 PM, Ryosuke Niwa wrote: > Hi, > > It appears that not a single port enables SHADOW_DOM build flag at this > point, and WebKit doesn't even compile with that option enabled. (There

Re: [webkit-dev] What do we do with various Web component features?

2013-04-29 Thread Andreas Kling
On Fri 2013-04-26, at 9:46 PM, Ryosuke Niwa wrote: > There appears to be a lot of Web component related features in WebKit that > used to be maintained by Chromium contributors; specifically those related to > Shadow DOM and node distributions. > > What do we do with them? The specification is

Re: [webkit-dev] Feature removal: CSS variables

2013-04-07 Thread Andreas Kling
On Sun 2013-04-07, at 9:19 PM, Ryosuke Niwa wrote: > On Sun, Apr 7, 2013 at 9:36 AM, Andreas Kling wrote: > I'd like to remove the CSS variable feature from the tree now that Chromium > has left, as they were the only ones shipping it AFAIK. > > If we were to keep the feat

[webkit-dev] Feature removal: CSS variables

2013-04-07 Thread Andreas Kling
Hi WebKittens! I'd like to remove the CSS variable feature from the tree now that Chromium has left, as they were the only ones shipping it AFAIK. The feature is awkwardly implemented, the syntax has not been well received by web developers, and in the CSS WG priorities poll[1] last October, the

Re: [webkit-dev] WebKit + OpenCL

2012-11-23 Thread Andreas Kling
Hi folks, Do we really think it's a good idea to add yet another implementation of filters? We already have generic, NEON-optimized and WTF::ParallelJobs (which includes generic, OpenMP and libdispatch backends) implementations of this code, and now we're adding OpenCL too. On the WebKit Proj

[webkit-dev] On returning mutable pointers from const methods

2012-10-25 Thread Andreas Kling
Yo WebKittens! After some mild morning discussion in #webkit, I'm wondering if we should amend our style guide to disallow returning mutable pointers (Foo*) from const methods, like so: - Foo* foo() const; While this is useful when you want to be able to take a strong reference to the returned o

Re: [webkit-dev] WebKit memory instrumentation

2012-07-23 Thread Andreas Kling
Hi guys, First off, this is a really neat addition for web and WebKit developers alike, so thanks for hacking it! We're already using the "reference class with same size as original class" pattern to guard against object size regression for some of our very high-volume objects. While that's fine

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Andreas Kling
On Thu, Jul 19, 2012 at 7:20 PM, Filip Pizlo wrote: > > dataLog("foo %d bar %x baz %p\n", a, b, c); > Reasoning and valid arguments aside, that actually looks totally beautiful. Do want. -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org h

Re: [webkit-dev] Easing printf based debugging in WebKit with an helper.

2012-07-19 Thread Andreas Kling
On Tue, Jul 10, 2012 at 4:52 PM, Brady Eidson wrote: > > On Jul 10, 2012, at 5:25 AM, Alexis Menard > wrote: > > > On Mon, Jul 9, 2012 at 6:53 PM, Brady Eidson wrote: > >> > >> On Jul 9, 2012, at 2:43 PM, Alexis Menard > wrote: > >> > >>> Hi, > >>> > >>> For those who "secretly" use printf deb

Re: [webkit-dev] Eliminate potential null pointer dereference?

2012-04-21 Thread Andreas Kling
On Sat, Apr 21, 2012 at 9:45 AM, Antti Koivisto wrote: > There is generally too much pointless drive-by refactoring going on in the > project. I think we should take harder line against these "No new test / > code cleanup only" type patches to reduce noise level. > +1 to this. Furthermore, I t

Re: [webkit-dev] Asking for review by pinging bugs---another approach

2012-01-05 Thread Andreas Kling
On Thu, Jan 5, 2012 at 7:49 AM, Adam Barth wrote: > Not to pick on anyone in particular, but when reading bugmail I > occasionally see messages like "pinging for review." I review a lot > of patches, but I don't find these messages particularly helpful > because I don't know whether I'm supposed

[webkit-dev] Removing support for the RVCT compiler

2011-12-10 Thread Andreas Kling
Hola WebKittens! Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. -Kling ___ webkit-dev mailing list webkit

[webkit-dev] On the hazards of fast attribute lookup

2011-10-18 Thread Andreas Kling
Hey WebKittens! WebCore::Element has two functions covering with most of your attribute retrieval use cases: const AtomicString& getAttribute(const QualifiedName&) const; bool hasAttribute(const QualifiedName&) const; An optimization was introduced in to

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 10:43 PM, Darin Adler wrote: > On Sep 29, 2011, at 1:40 PM, Andreas Kling wrote: > > > Good idea in general, though it doesn't work for InlineBox since its bits > are spread across public, protected and private. > > I'm not sure it's wo

Re: [webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
On Thu, Sep 29, 2011 at 9:11 PM, Simon Fraser wrote: > > On Sep 29, 2011, at 11:40 AM, Andreas Kling wrote: > > > Dear WebKittens, > > > > I'd like to add some compile-time assertions for the sizes of various > objects. The motivation comes a patch fixing bloat

[webkit-dev] Compile-time assertions for object sizes

2011-09-29 Thread Andreas Kling
Dear WebKittens, I'd like to add some compile-time assertions for the sizes of various objects. The motivation comes a patch fixing bloat in InlineBox[1]. There are two major problems with this: 1. The sizes will differ on 32- and 64-bit platforms. 2. The sizes will differ based on compiler flag

[webkit-dev] Ceasing development of current QtWebKit API's

2011-07-04 Thread Andreas Kling
(Cross-posting from webkit-qt since it may interest people who are not on that list.) Hello QtWebKit users and contributors! Now that the Nokia N9 has finally been announced, many of you probably know it ships with a WebKit2-based browser. Following this we've started discussing where to go with

Re: [webkit-dev] phonon and qtwebkit modifications to make it work

2011-07-04 Thread Andreas Kling
Hiya, The Phonon implementation of MediaPlayer was removed from WebKit in https://bugs.webkit.org/show_bug.cgi?id=63448 -Kling On Mon, Jul 4, 2011 at 8:04 PM, Mihai Adrian wrote: > Hello, > > I use an older version of qtwebkit, but no modification have been done in > the phonon backend part ( M

Re: [webkit-dev] Why does Ahem have different vertical metrics in Qt?

2011-04-06 Thread Andreas Kling
On 02/08/2011 08:42 PM, ext Dan Bernstein wrote: What is causing this difference? How does it affect other fonts and real websites? Is there a way to fix this? This is caused by the behavior of QFontMetricsF::descent() which returns the descent minus one for historical reasons. I've opened h

[webkit-dev] CoreGraphics input wanted on GraphicsContext Path refactor

2010-11-20 Thread Andreas Kling
Hey folks, Could someone who knows their way around CGContext & co have a look at http://webkit.org/b/48516 please? I'm refactoring GraphicsContext to take const Path& arguments instead of having a "current path" coupled to it. This reduces complexity of both call-sites and implementations (

Re: [webkit-dev] Platform specific editing behaviors

2010-10-28 Thread Andreas Kling
On 10/27/2010 11:17 PM, ext Antonio Gomes wrote: Before anything I would like to point it our here, and hear from the port maintainers any possible objection about it, specially from the cross-platform ones, including Chromium and Qt. This sounds like what we want for Qt, so no objections here

Re: [webkit-dev] [webkit-changes] [68146] trunk/WebCore

2010-09-24 Thread Andreas Kling
On 09/23/2010 09:25 PM, ext Alexey Proskuryakov wrote: I'm sorry if this came across as an attack on you. My goal was to encourage reviewers to ensure that patches have adequate documentation and test coverage, and that's why I chose to bring this up on the list. Point taken. It was my mistake

Re: [webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-19 Thread Andreas Kling
On 09/19/2010 11:28 AM, ext Nikolas Zimmermann wrote: To summarize: Let's go for platform specific variants of Path::createCircle/Path::createEllipse, but change the DRT dumps. For primitive shapes, we shouldn't dump any path data _at all_ (eg. circle / ellipse / rect etc) but instead just dump "

[webkit-dev] Path::createEllipse() - why not leverage port paths?

2010-09-18 Thread Andreas Kling
Hey folks, Is there a reason we're manually creating the ellipses in Path::createEllipse() instead of using the port-specific Path::addEllipse()? For the SVG version of the benchmark at http://www.themaninblue.com/writing/perspective/2010/03/22/ we're spending roughly 25% of runtime in Path:

[webkit-dev] Canvas component in Bugzilla

2010-09-14 Thread Andreas Kling
Hey folks! I propose we add a "Canvas" component in Bugzilla. Thoughts? -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Canvas performance and memory usage

2010-08-04 Thread Andreas Kling
On 08/04/2010 03:55 AM, ext Martin Robinson wrote: Resent from the proper address: On Tue, Aug 3, 2010 at 6:00 PM, Martin Robinson wrote: I notice that Qt added imageForRendering() and felt they could not use image() for some reason. I'd be curious if a Qt expert could weigh in on that, sinc

[webkit-dev] Higher --exit-after-n-failures threshold on commit bot

2010-06-12 Thread Andreas Kling
Any chance we could up the --exit-after-n-failures value a bit on the commit bot? The current value (1) makes it really cumbersome for someone who doesn't have access to all testing platforms. Something like 10 would seem affordable, giving you useful data if you break a couple of tests that