[incubator-pinot] branch switch-ui-to-sql updated (26586a1 -> 3db7c2b)
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch switch-ui-to-sql
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 26586a1 move sql parser to calcite parser again
discard 91958f9 move sql back to pql parser
discard 1e56284 Address comments
discard 9fdae26 Adding sql endpoint in controller
discard d83f270 Update TransformExpressionTree.java
discard c2c557c Make sql as default query format.
add 995ad83 Calcite SQL compiler syntax support for order by expression
and set LENIENT SQL conformance (#5005)
add 3db7c2b Make sql as default query format.
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (26586a1)
\
N -- N -- N refs/heads/switch-ui-to-sql (3db7c2b)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../request/PqlAndCalciteSqlCompatibilityTest.java | 28
.../request/transform/TransformExpressionTree.java | 5 +
.../utils/BrokerRequestComparisonUtils.java| 47 ++-
.../parsers/PinotQuery2BrokerRequestConverter.java | 7 +-
.../pinot/pql/parsers/pql2/ast/SelectAstNode.java | 20 +--
.../apache/pinot/sql/parsers/CalciteSqlParser.java | 11 +-
.../apache/pinot/pql/parsers/Pql2CompilerTest.java | 14 ++
.../pinot/sql/parsers/CalciteSqlCompilerTest.java | 77 ++-
...notQueryResource.java => PqlQueryResource.java} | 149 +
.../src/main/resources/static/js/init.js | 23 ++--
.../src/main/resources/webapp/js/init.js | 23 ++--
11 files changed, 242 insertions(+), 162 deletions(-)
rename
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/{PinotQueryResource.java
=> PqlQueryResource.java} (60%)
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging [#4994](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/995ad8331ccde0cc4e5d85dde7f326a61e2ba1e6?src=pr=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4994 +/- ## - Coverage 57.03% 56.97% -0.07% Complexity 12 12 Files 1179 1179 Lines 6276362799 +36 Branches 9213 9216 +3 - Hits 3579635778 -18 - Misses2434824389 +41 - Partials 2619 2632 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...t/controller/api/resources/PinotQueryResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90UXVlcnlSZXNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `56.09% <0%> (-8.54%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | | | [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0%> (-7.15%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `57.31% <0%> (-6.1%)` | `0% <0%> (ø)` | | | [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90UmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `76.92% <0%> (-5.13%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `58.73% <0%> (-4.77%)` | `0% <0%> (ø)` | | | [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `76.92% <0%> (-3.3%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `58.06% <0%> (-3.23%)` | `0% <0%> (ø)` | | | [...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==) | `51.49% <0%> (-1.8%)` | `0% <0%> (ø)` | | | ... and [16 more](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-pinot] harleyjj opened a new pull request #5012: [TE] frontend - harleyjj/alert-details - fix anomaly chart mapping to…
harleyjj opened a new pull request #5012: [TE] frontend - harleyjj/alert-details - fix anomaly chart mapping to… URL: https://github.com/apache/incubator-pinot/pull/5012 … be robust against imprecision 1) Anomaly endTime sometimes does not align to granularity, so we change the stopping condition for mapping anomalies over current time stamps to account for this 2) Consolidate the repeated logic for mapping new and old anomaly sets into a helper function _mapAnomaliesToTimeSeries This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5013: For RANGE predicate queries touching offline segments, use sorted inverted index.
siddharthteotia opened a new pull request #5013: For RANGE predicate queries touching offline segments, use sorted inverted index. URL: https://github.com/apache/incubator-pinot/pull/5013 Motivation: Currently, we don't leverage inverted index (sorted or bitmap) for RANGE predicates. Rather we resort to scan based iterator. If a column is sorted and has RANGE predicates like: WHERE COL >= 2 WHERE COL >= 2 AND COL <= 25000 . Using sorted inverted index is better in such cases since the predicate evaluator can quickly give us the matching dictionary IDs, these are already sorted. All we need now is get the startDocId for dictid[0] and endDocId for dictId[dictids.length - 1]. This change is made in SortedInvertedIndexBasedFilterOperator. Later we can iterate on these or intersect. We can only do this for offline segments since for realtime segments, until the conversion happens the records aren't really sorted. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch switch-ui-to-sql updated (3db7c2b -> be1a84f)
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch switch-ui-to-sql
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 3db7c2b Make sql as default query format.
add 27ab5ad Make sql as default query format.
add 26efdf8 Update TransformExpressionTree.java
add fbcd0b9 Adding sql endpoint in controller
add 7fe59d7 Address comments
add 41b873d move sql back to pql parser
add be1a84f move sql parser to calcite parser again
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (3db7c2b)
\
N -- N -- N refs/heads/switch-ui-to-sql (be1a84f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.../request/transform/TransformExpressionTree.java | 5 -
...lQueryResource.java => PinotQueryResource.java} | 149 -
.../src/main/resources/static/js/init.js | 23 ++--
.../src/main/resources/webapp/js/init.js | 23 ++--
4 files changed, 143 insertions(+), 57 deletions(-)
rename
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/{PqlQueryResource.java
=> PinotQueryResource.java} (60%)
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4994: Make sql as default query format.
codecov-io edited a comment on issue #4994: Make sql as default query format. URL: https://github.com/apache/incubator-pinot/pull/4994#issuecomment-575616116 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=h1) Report > Merging [#4994](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/995ad8331ccde0cc4e5d85dde7f326a61e2ba1e6?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4994 +/- ## - Coverage 57.03% 56.95% -0.08% Complexity 12 12 Files 1179 1179 Lines 6276362767 +4 Branches 9213 9214 +1 - Hits 3579635749 -47 - Misses2434824399 +51 Partials 2619 2619 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...mon/request/transform/TransformExpressionTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC90cmFuc2Zvcm0vVHJhbnNmb3JtRXhwcmVzc2lvblRyZWUuamF2YQ==) | `72.85% <0%> (-4.42%)` | `0 <0> (ø)` | | | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `25% <0%> (-56.25%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9NVlNjYW5Eb2NJZEl0ZXJhdG9yLmphdmE=) | `46.03% <0%> (-17.47%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `48.78% <0%> (-15.86%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `48.78% <0%> (-14.64%)` | `0% <0%> (ø)` | | | [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0NsdXN0ZXJDaGFuZ2VNZWRpYXRvci5qYXZh) | `74.72% <0%> (-5.5%)` | `0% <0%> (ø)` | | | [...g/apache/pinot/common/utils/helix/HelixHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvSGVsaXhIZWxwZXIuamF2YQ==) | `50.89% <0%> (-2.4%)` | `0% <0%> (ø)` | | | [...time/impl/dictionary/OffHeapMutableBytesStore.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvT2ZmSGVhcE11dGFibGVCeXRlc1N0b3JlLmphdmE=) | `88.88% <0%> (-2.23%)` | `0% <0%> (ø)` | | | [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `44.61% <0%> (-1.54%)` | `0% <0%> (ø)` | | | [.../java/org/apache/pinot/spi/data/TimeFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9UaW1lRmllbGRTcGVjLmphdmE=) | `92.59% <0%> (-1.24%)` | `0% <0%> (ø)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-pinot/pull/4994/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4994?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats.
codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#issuecomment-574887413 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=h1) Report > Merging [#4989](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/29c6b39d34d51bb4165b0be63b17a427a45ebf52?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4989 +/- ## === - Coverage 51.82% 51.8% -0.02% Complexity 12 12 === Files 11761179 +3 Lines 62388 62763 +375 Branches 91679213 +46 === + Hits 32331 32513 +182 - Misses27577 27757 +180 - Partials 24802493 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/pinot/core/operator/ExecutionStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9FeGVjdXRpb25TdGF0aXN0aWNzLmphdmE=) | `95.83% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/core/operator/docidsets/SizeBasedDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvU2l6ZUJhc2VkRG9jSWRTZXQuamF2YQ==) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `47.22% <ø> (-8.34%)` | `0 <0> (ø)` | | | [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `78.12% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ator/query/DictionaryBasedAggregationOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWRBZ2dyZWdhdGlvbk9wZXJhdG9yLmphdmE=) | `89.28% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/core/operator/docidsets/SortedDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvU29ydGVkRG9jSWRTZXQuamF2YQ==) | `71.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...filter/SortedInvertedIndexBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvU29ydGVkSW52ZXJ0ZWRJbmRleEJhc2VkRmlsdGVyT3BlcmF0b3IuamF2YQ==) | `60% <0%> (-12%)` | `0% <0%> (ø)` | | | [.../core/segment/index/readers/BloomFilterReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvQmxvb21GaWx0ZXJSZWFkZXIuamF2YQ==) | `64.28% <0%> (-7.15%)` | `0% <0%> (ø)` | | | [...apache/pinot/core/query/reduce/CombineService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQ29tYmluZVNlcnZpY2UuamF2YQ==) | `55.76% <0%> (-5.77%)` | `0% <0%> (ø)` | | | ... and [44 more](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=footer). Last update [29c6b39...eb5716a](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=lastupdated). Read the [comment
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5005: Make calcite parser support order by expression
codecov-io edited a comment on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577528692 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=h1) Report > Merging [#5005](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `5.5%`. > The diff coverage is `36.58%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5005 +/- ## - Coverage 57.29% 51.78% -5.51% Complexity 12 12 Files 1179 1179 Lines 6273162762 +31 Branches 9204 9213 +9 - Hits 3594432504-3440 - Misses2410627770+3664 + Partials 2681 2488 -193 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `87.79% <100%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=) | `87.68% <100%> (+4.1%)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/pql/parsers/pql2/ast/SelectAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TZWxlY3RBc3ROb2RlLmphdmE=) | `97.89% <100%> (+0.04%)` | `0 <0> (ø)` | :arrow_down: | | [...ot/parsers/utils/BrokerRequestComparisonUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wYXJzZXJzL3V0aWxzL0Jyb2tlclJlcXVlc3RDb21wYXJpc29uVXRpbHMuamF2YQ==) | `23.92% <13.33%> (-8.17%)` | `0 <0> (ø)` | | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | | | [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | | | [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | | | ... and [202 more](https://codecov.io/gh/apache/incubator-pinot/pull/5005/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5005?src=pr=continue). > **Legend** - [Click here to learn
[incubator-pinot] branch update_docker_images created (now 435b34e)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 435b34e update docker image location This branch includes the following new commits: new 435b34e update docker image location The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5007: update docker image location
fx19880617 opened a new pull request #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007 Update all pinot related docker images to `apachepinot` repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch update_docker_images updated (435b34e -> 49d0a2b)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 435b34e update docker image location add 49d0a2b update docker image location This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (435b34e) \ N -- N -- N refs/heads/update_docker_images (49d0a2b) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: kubernetes/helm/README.md | 3 +++ kubernetes/helm/templates/broker/statefulset.yml | 2 +- kubernetes/helm/templates/controller/statefulset.yaml | 2 +- kubernetes/helm/templates/server/statefulset.yml | 2 +- kubernetes/helm/values.yaml | 3 +++ 5 files changed, 9 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5007: update docker image location
codecov-io commented on issue #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007#issuecomment-577614102 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=h1) Report > Merging [#5007](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `5.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5007 +/- ## - Coverage 57.29% 51.82% -5.48% Complexity 12 12 Files 1179 1179 Lines 6273162731 Branches 9204 9204 - Hits 3594432511-3433 - Misses2410627731+3625 + Partials 2681 2489 -192 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | | | [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | | | [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `1.49% <0%> (-83.59%)` | `0% <0%> (ø)` | | | [...pache/pinot/server/starter/helix/SegmentLocks.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TG9ja3MuamF2YQ==) | `0% <0%> (-83.34%)` | `0% <0%> (ø)` | | | [...tools/query/comparison/StarTreeQueryGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU3RhclRyZWVRdWVyeUdlbmVyYXRvci5qYXZh) | `0% <0%> (-82.84%)` | `0% <0%> (ø)` | | | [...server/starter/helix/HelixInstanceDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXIuamF2YQ==) | `0% <0%> (-82.82%)` | `0% <0%> (ø)` | | | ... and [198 more](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #5007: update docker image location
codecov-io edited a comment on issue #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007#issuecomment-577614102 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=h1) Report > Merging [#5007](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `5.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5007 +/- ## - Coverage 57.29% 51.82% -5.48% Complexity 12 12 Files 1179 1179 Lines 6273162731 Branches 9204 9204 - Hits 3594432511-3433 - Misses2410627731+3625 + Partials 2681 2489 -192 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0% <0%> (ø)` | | | [...converter/stats/RealtimeSegmentStatsContainer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVTZWdtZW50U3RhdHNDb250YWluZXIuamF2YQ==) | `0% <0%> (-94.45%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/tools/utils/KafkaStarterUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3V0aWxzL0thZmthU3RhcnRlclV0aWxzLmphdmE=) | `0% <0%> (-93.19%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0% <0%> (ø)` | | | [...ot/tools/query/comparison/SegmentInfoProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU2VnbWVudEluZm9Qcm92aWRlci5qYXZh) | `0% <0%> (-88.68%)` | `0% <0%> (ø)` | | | [.../transform/function/MapValueTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTWFwVmFsdWVUcmFuc2Zvcm1GdW5jdGlvbi5qYXZh) | `0% <0%> (-85.3%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `1.49% <0%> (-83.59%)` | `0% <0%> (ø)` | | | [...pache/pinot/server/starter/helix/SegmentLocks.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50TG9ja3MuamF2YQ==) | `0% <0%> (-83.34%)` | `0% <0%> (ø)` | | | [...tools/query/comparison/StarTreeQueryGenerator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL3F1ZXJ5L2NvbXBhcmlzb24vU3RhclRyZWVRdWVyeUdlbmVyYXRvci5qYXZh) | `0% <0%> (-82.84%)` | `0% <0%> (ø)` | | | [...server/starter/helix/HelixInstanceDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXIuamF2YQ==) | `0% <0%> (-82.82%)` | `0% <0%> (ø)` | | | ... and [198 more](https://codecov.io/gh/apache/incubator-pinot/pull/5007/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5007?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not
[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (cadbd0d -> 38ee798)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard cadbd0d Make calcite parser support order by expression add 38ee798 Make calcite parser support order by expression This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (cadbd0d) \ N -- N -- N refs/heads/fixing_calcite_parser_for_groupby_functions (38ee798) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../pinot/pql/parsers/pql2/ast/SelectAstNode.java| 20 +++- .../apache/pinot/pql/parsers/Pql2CompilerTest.java | 1 + 2 files changed, 12 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging [#4954](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `5.59%`. > The diff coverage is `43.14%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=tree) ```diff @@Coverage Diff @@ ## master #4954 +/- ## == - Coverage 57.29% 51.7% -5.6% Complexity 12 12 == Files 11791186 +7 Lines 62731 62872+141 Branches 92049225 +21 == - Hits 35944 32508 -3436 - Misses24106 27871 +3765 + Partials 26812493-188 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/io/reader/impl/IntSingleValueDataFileReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC9JbnRTaW5nbGVWYWx1ZURhdGFGaWxlUmVhZGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `80.56% <ø> (-0.41%)` | `0 <0> (ø)` | | | [...inot/tools/admin/command/CreateSegmentCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQ3JlYXRlU2VnbWVudENvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `34% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0 <0> (ø)` | | | [...not/core/query/pruner/DataSchemaSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvRGF0YVNjaGVtYVNlZ21lbnRQcnVuZXIuamF2YQ==) | `50% <0%> (-30%)` | `0 <0> (ø)` | | | [...ore/segment/index/readers/SingleIntDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlSW50RGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../segment/index/readers/SingleDoubleDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlRG91YmxlRGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0 <0> (ø)` | | | [...e/segment/index/readers/SingleFloatDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlRmxvYXREaWN0aW9uYXJ5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | ... and [245 more](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered
[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5006: Add FieldConfig.
kishoreg commented on a change in pull request #5006: Add FieldConfig.
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r369983270
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##
@@ -82,7 +88,8 @@ public TableConfig() {
private TableConfig(String tableName, TableType tableType,
SegmentsValidationAndRetentionConfig validationConfig,
TenantConfig tenantConfig, IndexingConfig indexingConfig,
TableCustomConfig customConfig,
@Nullable QuotaConfig quotaConfig, @Nullable TableTaskConfig taskConfig,
@Nullable RoutingConfig routingConfig,
- @Nullable Map
instanceAssignmentConfigMap) {
+ @Nullable Map
instanceAssignmentConfigMap,
+ @Null List fieldConfigList) {
Review comment:
what is @ Null, is it suppose to be @ Nullable?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5006: Add FieldConfig.
siddharthteotia opened a new pull request #5006: Add FieldConfig. URL: https://github.com/apache/incubator-pinot/pull/5006 TableConfig can take a list of FieldConfig to encapsulate storage, indexing and any other information for a field. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] haibow commented on a change in pull request #4954: Support schema evolution for consuming segments
haibow commented on a change in pull request #4954: Support schema evolution
for consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4954#discussion_r369991242
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##
@@ -467,13 +483,22 @@ public SegmentMetadata getSegmentMetadata() {
return physicalColumnNames;
}
+ @Override
+ public Set getColumnNamesForSelectStar() {
+return Sets.union(getPhysicalColumnNames(),
_newlyAddedColumnsFieldMap.keySet());
+ }
+
@Override
public ColumnDataSource getDataSource(String columnName) {
FieldSpec fieldSpec = _schema.getFieldSpecFor(columnName);
-if (fieldSpec.isVirtualColumn()) {
+if ((fieldSpec == null &&
_newlyAddedColumnsFieldMap.containsKey(columnName)) ||
fieldSpec.isVirtualColumn()) {
Review comment:
I don't see a strong reason to create another column provider factory just
for this. I have updated the MutableSegmentImpl to cache the provider, and only
initialize the provider or update row count when needed. This optimization will
help other virtual columns ($segmentName and $hostName) too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5006: Add FieldConfig.
siddharthteotia commented on a change in pull request #5006: Add FieldConfig.
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r369984530
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##
@@ -82,7 +88,8 @@ public TableConfig() {
private TableConfig(String tableName, TableType tableType,
SegmentsValidationAndRetentionConfig validationConfig,
TenantConfig tenantConfig, IndexingConfig indexingConfig,
TableCustomConfig customConfig,
@Nullable QuotaConfig quotaConfig, @Nullable TableTaskConfig taskConfig,
@Nullable RoutingConfig routingConfig,
- @Nullable Map
instanceAssignmentConfigMap) {
+ @Nullable Map
instanceAssignmentConfigMap,
+ @Null List fieldConfigList) {
Review comment:
Yes that was a typo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments
codecov-io edited a comment on issue #4954: Support schema evolution for consuming segments URL: https://github.com/apache/incubator-pinot/pull/4954#issuecomment-570396099 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=h1) Report > Merging [#4954](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `5.59%`. > The diff coverage is `43.14%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=tree) ```diff @@Coverage Diff @@ ## master #4954 +/- ## == - Coverage 57.29% 51.7% -5.6% Complexity 12 12 == Files 11791186 +7 Lines 62731 62872+141 Branches 92049225 +21 == - Hits 35944 32508 -3436 - Misses24106 27871 +3765 + Partials 26812493-188 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/io/reader/impl/IntSingleValueDataFileReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby9yZWFkZXIvaW1wbC9JbnRTaW5nbGVWYWx1ZURhdGFGaWxlUmVhZGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (?)` | | | [.../pinot/core/segment/index/SegmentMetadataImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `80.56% <ø> (-0.41%)` | `0 <0> (ø)` | | | [...inot/tools/admin/command/CreateSegmentCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3Rvb2xzL2FkbWluL2NvbW1hbmQvQ3JlYXRlU2VnbWVudENvbW1hbmQuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `34% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `0% <0%> (-96.16%)` | `0 <0> (ø)` | | | [...not/core/query/pruner/DataSchemaSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvRGF0YVNjaGVtYVNlZ21lbnRQcnVuZXIuamF2YQ==) | `50% <0%> (-30%)` | `0 <0> (ø)` | | | [...ore/segment/index/readers/SingleIntDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlSW50RGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../segment/index/readers/SingleDoubleDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlRG91YmxlRGljdGlvbmFyeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `0% <0%> (-92.31%)` | `0 <0> (ø)` | | | [...e/segment/index/readers/SingleFloatDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvU2luZ2xlRmxvYXREaWN0aW9uYXJ5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | | | ... and [245 more](https://codecov.io/gh/apache/incubator-pinot/pull/4954/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4954?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats.
codecov-io edited a comment on issue #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#issuecomment-574887413 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=h1) Report > Merging [#4989](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/29c6b39d34d51bb4165b0be63b17a427a45ebf52?src=pr=desc) will **increase** coverage by `5.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4989 +/- ## + Coverage 51.82% 57.34% +5.52% Complexity 12 12 Files 1176 1179 +3 Lines 6238862731 +343 Branches 9167 9204 +37 + Hits 3233135976+3645 + Misses2757724080-3497 - Partials 2480 2675 +195 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pache/pinot/core/operator/ExecutionStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9FeGVjdXRpb25TdGF0aXN0aWNzLmphdmE=) | `95.83% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/core/operator/docidsets/SizeBasedDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvU2l6ZUJhc2VkRG9jSWRTZXQuamF2YQ==) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9Tb3J0ZWREb2NJZEl0ZXJhdG9yLmphdmE=) | `55.55% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/core/operator/docidsets/BitmapDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvQml0bWFwRG9jSWRTZXQuamF2YQ==) | `78.12% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ator/query/DictionaryBasedAggregationOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9xdWVyeS9EaWN0aW9uYXJ5QmFzZWRBZ2dyZWdhdGlvbk9wZXJhdG9yLmphdmE=) | `89.28% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/core/operator/docidsets/SortedDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZHNldHMvU29ydGVkRG9jSWRTZXQuamF2YQ==) | `71.42% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/core/operator/CombineOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9Db21iaW5lT3BlcmF0b3IuamF2YQ==) | `66.29% <0%> (-2.25%)` | `0% <0%> (ø)` | | | [...mon/request/transform/TransformExpressionTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC90cmFuc2Zvcm0vVHJhbnNmb3JtRXhwcmVzc2lvblRyZWUuamF2YQ==) | `77.27% <0%> (-1.76%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/spi/plugin/PluginClassLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvcGx1Z2luL1BsdWdpbkNsYXNzTG9hZGVyLmphdmE=) | `24.52% <0%> (-1.4%)` | `0% <0%> (ø)` | | | ... and [228 more](https://codecov.io/gh/apache/incubator-pinot/pull/4989/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4989?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[GitHub] [incubator-pinot] codecov-io commented on issue #5006: Add FieldConfig
codecov-io commented on issue #5006: Add FieldConfig URL: https://github.com/apache/incubator-pinot/pull/5006#issuecomment-577589208 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=h1) Report > Merging [#5006](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f15a7b02cef262b9283b16c29b0ba2413165789f?src=pr=desc) will **increase** coverage by `0.29%`. > The diff coverage is `94.11%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5006 +/- ## + Coverage 57.04% 57.34% +0.29% Complexity 12 12 Files 1175 1180 +5 Lines 6242162762 +341 Branches 9182 9207 +25 + Hits 3560735989 +382 + Misses2416724098 -69 - Partials 2647 2675 +28 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/org/apache/pinot/common/config/FieldConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0ZpZWxkQ29uZmlnLmphdmE=) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `84.64% <88.23%> (+0.8%)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/plugin/inputformat/parquet/ParquetUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L3BhcnF1ZXQvUGFycXVldFV0aWxzLmphdmE=) | `58.09% <0%> (-10.66%)` | `0% <0%> (ø)` | | | [...a/org/apache/pinot/core/transport/QueryServer.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvUXVlcnlTZXJ2ZXIuamF2YQ==) | `79.31% <0%> (-9.98%)` | `0% <0%> (ø)` | | | [.../realtime/impl/ThreadSafeMutableRoaringBitmap.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL1RocmVhZFNhZmVNdXRhYmxlUm9hcmluZ0JpdG1hcC5qYXZh) | `92.85% <0%> (-7.15%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `43.01% <0%> (-5.38%)` | `0% <0%> (ø)` | | | [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0RlZmF1bHRSZWFsdGltZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `61.9% <0%> (-4.77%)` | `0% <0%> (ø)` | | | [...rg/apache/pinot/server/starter/ServerInstance.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9TZXJ2ZXJJbnN0YW5jZS5qYXZh) | `85.07% <0%> (-2.62%)` | `0% <0%> (ø)` | | | [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `81.1% <0%> (-2.28%)` | `0% <0%> (ø)` | | | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `68.67% <0%> (-1.96%)` | `0% <0%> (ø)` | | | ... and [105 more](https://codecov.io/gh/apache/incubator-pinot/pull/5006/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5006?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute
[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (3558d26 -> cadbd0d)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3558d26 Make calcite parser support order by expression add cadbd0d Make calcite parser support order by expression This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (3558d26) \ N -- N -- N refs/heads/fixing_calcite_parser_for_groupby_functions (cadbd0d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../request/PqlAndCalciteSqlCompatibilityTest.java | 28 + .../utils/BrokerRequestComparisonUtils.java| 47 +- .../parsers/PinotQuery2BrokerRequestConverter.java | 7 +++- .../apache/pinot/pql/parsers/Pql2CompilerTest.java | 13 ++ 4 files changed, 92 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] 01/01: update docker image location
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch update_docker_images in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 435b34e9c099e219bebe4d1a145d0de50eda0b82 Author: Xiang Fu AuthorDate: Thu Jan 23 01:30:11 2020 -0800 update docker image location --- docker/images/pinot-presto/README.md | 4 ++-- docker/images/pinot-superset/Makefile | 2 +- docker/images/pinot-superset/README.md| 2 +- docker/images/pinot/README.md | 16 docker/images/pinot/docker-compose.yml| 6 +++--- kubernetes/helm/README.md | 4 ++-- kubernetes/helm/pinot-realtime-quickstart.yml | 8 kubernetes/helm/presto-coordinator.yaml | 2 +- kubernetes/helm/presto-worker.yaml| 2 +- kubernetes/helm/values.yaml | 4 ++-- kubernetes/skaffold/gke/pinot-broker.yml | 2 +- kubernetes/skaffold/gke/pinot-controller.yml | 2 +- kubernetes/skaffold/gke/pinot-realtime-quickstart.yml | 4 ++-- kubernetes/skaffold/gke/pinot-server.yml | 2 +- 14 files changed, 30 insertions(+), 30 deletions(-) diff --git a/docker/images/pinot-presto/README.md b/docker/images/pinot-presto/README.md index 8a39b75..9ac39a0 100644 --- a/docker/images/pinot-presto/README.md +++ b/docker/images/pinot-presto/README.md @@ -35,13 +35,13 @@ You can also build directly with `docker build` command by setting arguments: ```bash docker build \ --build-arg PRESTO_BRANCH=master \ - --tag fx19880617/pinot-presto:0.1 \ + --tag apachepinot/pinot-presto:latest \ --target build . ``` ## How to push ```bash -docker push fx19880617/pinot-presto:0.1 +docker push apachepinot/pinot-presto:latest ``` ## Configuration diff --git a/docker/images/pinot-superset/Makefile b/docker/images/pinot-superset/Makefile index 85fb778..5a4ef94 100644 --- a/docker/images/pinot-superset/Makefile +++ b/docker/images/pinot-superset/Makefile @@ -17,7 +17,7 @@ # under the License. # -image := fx19880617/pinot-superset +image := apachepinot/pinot-superset stages := build dist final shells := $(foreach stage,$(stages),shell@$(stage)) diff --git a/docker/images/pinot-superset/README.md b/docker/images/pinot-superset/README.md index 8e35f3b..fedbf61 100644 --- a/docker/images/pinot-superset/README.md +++ b/docker/images/pinot-superset/README.md @@ -41,7 +41,7 @@ docker build \ --build-arg NODE_VERSION=latest \ --build-arg PYTHON_VERSION=3.6 \ --build-arg SUPERSET_VERSION=0.34.1 \ - --tag fx19880617/pinot-superset:0.34.1 \ + --tag apachepinot/pinot-superset:0.34.1 \ --target build . ``` ## How to push diff --git a/docker/images/pinot/README.md b/docker/images/pinot/README.md index f18aa79..c7cfdc9 100644 --- a/docker/images/pinot/README.md +++ b/docker/images/pinot/README.md @@ -58,24 +58,24 @@ Script `docker-push.sh` publishes a given docker image to your docker registry. In order to push to your own repo, the image needs to be explicitly tagged with the repo name. -* Example of publishing a image to [winedepot/pinot](https://cloud.docker.com/u/winedepot/repository/docker/winedepot/pinot) dockerHub repo. +* Example of publishing a image to [apachepinot/pinot](https://cloud.docker.com/u/apachepinot/repository/docker/apachepinot/pinot) dockerHub repo. ```SHELL -./docker-push.sh winedepot/pinot:latest +./docker-push.sh apachepinot/pinot:latest ``` * Tag a built image, then push. SHELL -docker tag pinot:release-0.1.0 winedepot/pinot:release-0.1.0 -docker push winedepot/pinot:release-0.1.0 +docker tag pinot:release-0.1.0 apachepinot/pinot:release-0.1.0 +docker push apachepinot/pinot:release-0.1.0 Script `docker-build-and-push.sh` builds and publishes this docker image to your docker registry after build. -* Example of building and publishing a image to [winedepot/pinot](https://cloud.docker.com/u/winedepot/repository/docker/winedepot/pinot) dockerHub repo. +* Example of building and publishing a image to [apachepinot/pinot](https://cloud.docker.com/u/apachepinot/repository/docker/apachepinot/pinot) dockerHub repo. ```SHELL -./docker-build-and-push.sh winedepot/pinot:latest master https://github.com/apache/incubator-pinot.git +./docker-build-and-push.sh apachepinot/pinot:latest master https://github.com/apache/incubator-pinot.git ``` ## How to Run it @@ -131,12 +131,12 @@ docker-compose -f docker-compose.yml up Below is the script to create airlineStats table ```SHELL -docker run --network=docker_default winedepot/pinot:0.3.0-SNAPSHOT AddTable -schemaFile examples/stream/airlineStats/airlineStats_schema.json -tableConfigFile examples/stream/airlineStats/docker/airlineStats_realtime_table_config.json -controllerHost
[GitHub] [incubator-pinot] haibow opened a new pull request #5010: Exclude slf4j from hadoop-common
haibow opened a new pull request #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010 `slf4j-log4j12` is included in `hadoop-common`, causing logger resolution issues in several places. We are at the mercy of JVM to pick a logger when there are multiple SLF4J bindings. For example, in `pinot-integration-tests`, log4j is not initialized properly, and no logs are printed. ``` Running org.apache.pinot.integration.tests.HybridClusterIntegrationTest SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.11.2/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] Using random seed: 1579807901023, isDirectAlloc: false, isConsumerDirConfigured: false, enableLeadControllerResource: false log4j:WARN No appenders could be found for logger (org.apache.zookeeper.server.ZooKeeperServerMain). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. ``` This happened in other modules too. ``` Running org.apache.pinot.plugin.inputformat.parquet.ParquetRecordReaderTest SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.11.2/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] log4j:WARN No appenders could be found for logger (org.apache.hadoop.util.Shell). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. ``` ``` Running org.apache.pinot.tools.TestDataAndQueryAnonymizer SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.11.2/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory] ``` Excluding `slf4j-log4j12` from `hadoop-common` to resolve those issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370348191
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.config;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Properties;
+import javax.annotation.Nullable;
+
+
+public class FieldConfig extends BaseJsonConfig {
+ private String _name;
+ private EncodingType _encodingType;
+ private IndexType _indexType;
+ private Properties _properties;
Review comment:
I don't think we need the functionalities provided by Properties class,
maybe Map is enough?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.
Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats. URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370276146 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/SizeBasedDocIdSet.java ## @@ -21,7 +21,7 @@ import org.apache.pinot.core.common.BlockDocIdIterator; import org.apache.pinot.core.operator.dociditerators.SizeBasedDocIdIterator; - +// Rename this class to MatchAllDocIdSet. Review comment: Add `TODO: ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] elonazoulay opened a new issue #5008: Add TestContainer
elonazoulay opened a new issue #5008: Add TestContainer URL: https://github.com/apache/incubator-pinot/issues/5008 Add TestContainer to help with testing. This can also be used by external projects that interact with pinot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…
xiaohui-sun commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r370329916 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java ## @@ -530,6 +535,11 @@ private DetectionConfigDTO generateDetectionConfig(Map yamlConfi config.setActive(MapUtils.getBooleanValue(yamlConfigMap, PROP_ACTIVE, true)); config.setYaml(yamlConfig); +//TODO: data-availability trigger is only enabled for detections running on PINOT only Review comment: Why this is a TODO? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5000: [TE] frontend - harleyjj/alert-details - show bounds for minute and d…
xiaohui-sun merged pull request #5000: [TE] frontend - harleyjj/alert-details - show bounds for minute and d… URL: https://github.com/apache/incubator-pinot/pull/5000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (c3117d0 -> 0819c1e)
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from c3117d0 Handle sun.nio.ch.DirectBuffer cleaner behavior for jdk 8+ (#5002) add 0819c1e [TE] frontend - harleyjj/alert-details - show bounds for minute and day granularity in Alert Overview (#5000) No new revisions were added by this update. Summary of changes: .../app/pods/components/alert-details/component.js| 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.
Jackie-Jiang commented on a change in pull request #4989: Add documentation to
fields of important query execution stats.
URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370275890
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/ExecutionStatistics.java
##
@@ -22,8 +22,13 @@
* The ExecutionStatistics class contains the operator statistics
during execution time.
*/
public class ExecutionStatistics {
+ // The number of documents scanned post filtering.
private long _numDocsScanned;
+ // The number of entries (single value entry contains 1 entry, multi-value
entry may contain multiple entries) in the
+ // filtering phase of the query execution: could be larger than the total
scanned doc num because of multiple
+ // filtering predicates and multi-value entry.
Review comment:
The number of entries (single-value entry contains 1 **value**, multi-value
entry may contain multiple **values**) **scanned** in the filtering phase of
the query execution. Could be larger than the number of documents scanned
because of multiple filtering predicates.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4989: Add documentation to fields of important query execution stats.
Jackie-Jiang commented on a change in pull request #4989: Add documentation to
fields of important query execution stats.
URL: https://github.com/apache/incubator-pinot/pull/4989#discussion_r370276395
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/docidsets/SizeBasedDocIdSet.java
##
@@ -49,6 +49,7 @@ public void setEndDocId(int endDocId) {
@Override
public long getNumEntriesScannedInFilter() {
+// No value scanned because all docs are matches and will be returned.
Review comment:
`matched`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…
vincentchenjl opened a new pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009 …t cron This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370279960
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.config;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Properties;
+import javax.annotation.Nullable;
+
+
+public class FieldConfig extends BaseJsonConfig {
+ private String _name;
+ private EncodingType _encodingType;
+ private IndexType _indexType;
+ private Properties _properties;
+
+ @JsonCreator
+ FieldConfig (@JsonProperty(value = "name", required = true) String name,
Review comment:
public?
Also need to reformat
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370279280
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.config;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Properties;
+import javax.annotation.Nullable;
+
+
+public class FieldConfig extends BaseJsonConfig {
+ private String _name;
Review comment:
Make them final?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370277724
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/FieldConfig.java
##
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.config;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.Properties;
+import javax.annotation.Nullable;
+
+
+public class FieldConfig extends BaseJsonConfig {
+ private String _name;
+ private EncodingType _encodingType;
+ private IndexType _indexType;
+ private Properties _properties;
+
+ @JsonCreator
+ FieldConfig (@JsonProperty(value = "name", required = true) String name,
+ @JsonProperty(value = "encodingType") @Nullable EncodingType
encodingType,
+ @JsonProperty(value = "indexType") @Nullable IndexType indexType,
+ @JsonProperty(value = "properties") @Nullable Properties properties) {
+_name = name;
+_encodingType = encodingType;
+_indexType = indexType;
+_properties = properties;
+ }
+
+ // If null, we will create raw forward index
Review comment:
Should we use dictionary encoding by default?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370324802
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##
@@ -177,7 +188,7 @@ public static TableConfig fromJsonConfig(JsonNode
jsonConfig)
if (childConfigNode == null || childConfigNode.isNull()) {
return null;
}
-if (childConfigNode.isObject()) {
+if (childConfigNode.isObject() || childConfigNode instanceof ArrayNode) {
Review comment:
Same here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
Jackie-Jiang commented on a change in pull request #5006: Add FieldConfig
URL: https://github.com/apache/incubator-pinot/pull/5006#discussion_r370324742
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TableConfig.java
##
@@ -157,7 +168,7 @@ public static TableConfig fromJsonConfig(JsonNode
jsonConfig)
if (childConfigNode == null || childConfigNode.isNull()) {
return null;
}
-if (childConfigNode.isObject()) {
+if (childConfigNode.isObject() || childConfigNode instanceof ArrayNode) {
Review comment:
Equivalent to `childConfigNode.isContainerNode()`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5010: Exclude slf4j from hadoop-common
codecov-io commented on issue #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010#issuecomment-577910671 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=h1) Report > Merging [#5010](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c3117d0ed32438a75bebf5f53be0b259f5a64aac?src=pr=desc) will **decrease** coverage by `0.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5010 +/- ## - Coverage 57.29% 56.97% -0.33% Complexity 12 12 Files 1179 1179 Lines 6273162731 Branches 9204 9204 - Hits 3594435741 -203 - Misses2410624364 +258 + Partials 2681 2626 -55 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `25% <0%> (-56.25%)` | `0% <0%> (ø)` | | | [...mon/metadata/segment/OfflineSegmentZKMetadata.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0YWRhdGEvc2VnbWVudC9PZmZsaW5lU2VnbWVudFpLTWV0YWRhdGEuamF2YQ==) | `64.4% <0%> (-25.43%)` | `0% <0%> (ø)` | | | [.../starter/helix/HelixInstanceDataManagerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXJDb25maWcuamF2YQ==) | `69.23% <0%> (-23.08%)` | `0% <0%> (ø)` | | | [.../apache/pinot/core/transport/DataTableHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS90cmFuc3BvcnQvRGF0YVRhYmxlSGFuZGxlci5qYXZh) | `88% <0%> (-12%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `52.68% <0%> (-11.83%)` | `0% <0%> (ø)` | | | [...e/pinot/core/common/datatable/DataTableImplV2.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vZGF0YXRhYmxlL0RhdGFUYWJsZUltcGxWMi5qYXZh) | `89.41% <0%> (-9.02%)` | `0% <0%> (ø)` | | | [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `51.61% <0%> (-6.46%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `52.68% <0%> (-6.46%)` | `0% <0%> (ø)` | | | [...e/startree/v2/builder/StarTreeV2BuilderConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL1N0YXJUcmVlVjJCdWlsZGVyQ29uZmlnLmphdmE=) | `41.66% <0%> (-6.25%)` | `0% <0%> (ø)` | | | ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/5010/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5010?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…
xiaohui-sun commented on a change in pull request #5011: [TE] endpoint -
harleyjj/yamlresource - add dataset as an optional pa…
URL: https://github.com/apache/incubator-pinot/pull/5011#discussion_r370397132
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##
@@ -907,8 +907,28 @@ public Response toggleActivation(
*/
@GET
@Path("/list")
+ @ApiOperation("Get the list of all detection YAML configurations as JSON
enhanced with additional information, optionally filtered")
@Produces(MediaType.APPLICATION_JSON)
- public List> listYamls() throws ExecutionException {
-return
this.detectionConfigDAO.findAll().parallelStream().map(this.detectionConfigFormatter::format).collect(Collectors.toList());
+ public List> listYamls(
+ @ApiParam("Dataset the detection configurations should be filtered by")
@QueryParam("dataset") String dataset) throws ExecutionException {
+List> yamls;
+if (dataset == null) {
+ yamls = this.detectionConfigDAO
+ .findAll()
+ .parallelStream()
+ .map(this.detectionConfigFormatter::format)
+ .collect(Collectors.toList());
+} else {
+ yamls = this.detectionConfigDAO
+ .findAll()
+ .parallelStream()
+ .map(this.detectionConfigFormatter::format)
+ .filter(y -> {
+List thisYaml = (List)y.get("datasetNames");
Review comment:
variable "thisYaml" is not needed in this case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou…
vincentchenjl commented on a change in pull request #5009: [TE] auto enable data-availaibity trigger for PINOT detections withou… URL: https://github.com/apache/incubator-pinot/pull/5009#discussion_r370381169 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java ## @@ -530,6 +535,11 @@ private DetectionConfigDTO generateDetectionConfig(Map yamlConfi config.setActive(MapUtils.getBooleanValue(yamlConfigMap, PROP_ACTIVE, true)); config.setYaml(yamlConfig); +//TODO: data-availability trigger is only enabled for detections running on PINOT only Review comment: Ideally, data availability trigger should be enabled if the cron is specified. However, due to the current prod setup, we only get events for Pinot dataset. We should remove the check for Pinot dataset when we get update events for other data source. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5001: Supress runtime logging warnings for java 11
fx19880617 merged pull request #5001: Supress runtime logging warnings for java 11 URL: https://github.com/apache/incubator-pinot/pull/5001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (1f876c6 -> 4d61045)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1f876c6 update docker image location (#5007) add 4d61045 Supress runtime logging warnings for java 11 (#5001) No new revisions were added by this update. Summary of changes: pinot-tools/pom.xml| 14 -- pinot-tools/src/main/resources/appAssemblerScriptTemplate | 5 + pinot-tools/src/main/resources/conf/pinot-admin-log4j2.xml | 4 .../src/main/resources/conf/pinot-broker-log4j2.xml| 1 + .../src/main/resources/conf/pinot-controller-log4j2.xml| 1 + .../src/main/resources/conf/pinot-ingestion-job-log4j2.xml | 1 + .../src/main/resources/conf/pinot-server-log4j2.xml| 1 + pinot-tools/src/main/resources/conf/pinot-tools-log4j2.xml | 4 pinot-tools/src/main/resources/conf/quickstart-log4j2.xml | 4 9 files changed, 21 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (0819c1e -> 1f876c6)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0819c1e [TE] frontend - harleyjj/alert-details - show bounds for minute and day granularity in Alert Overview (#5000) add 1f876c6 update docker image location (#5007) No new revisions were added by this update. Summary of changes: docker/images/pinot-presto/README.md | 4 ++-- docker/images/pinot-superset/Makefile | 2 +- docker/images/pinot-superset/README.md| 2 +- docker/images/pinot/README.md | 16 docker/images/pinot/docker-compose.yml| 6 +++--- kubernetes/helm/README.md | 7 +-- kubernetes/helm/pinot-realtime-quickstart.yml | 8 kubernetes/helm/presto-coordinator.yaml | 2 +- kubernetes/helm/presto-worker.yaml| 2 +- kubernetes/helm/templates/broker/statefulset.yml | 2 +- kubernetes/helm/templates/controller/statefulset.yaml | 2 +- kubernetes/helm/templates/server/statefulset.yml | 2 +- kubernetes/helm/values.yaml | 7 +-- kubernetes/skaffold/gke/pinot-broker.yml | 2 +- kubernetes/skaffold/gke/pinot-controller.yml | 2 +- kubernetes/skaffold/gke/pinot-realtime-quickstart.yml | 4 ++-- kubernetes/skaffold/gke/pinot-server.yml | 2 +- 17 files changed, 39 insertions(+), 33 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5007: update docker image location
fx19880617 merged pull request #5007: update docker image location URL: https://github.com/apache/incubator-pinot/pull/5007 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj opened a new pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…
harleyjj opened a new pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa… URL: https://github.com/apache/incubator-pinot/pull/5011 …ram for yaml/list 1) Makes dataset an optional param for returning a filtered list of detection yaml configurations 2) Adds some Swagger annotations for yaml/list endpoint This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5010: Exclude slf4j from hadoop-common
fx19880617 merged pull request #5010: Exclude slf4j from hadoop-common URL: https://github.com/apache/incubator-pinot/pull/5010 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (4d61045 -> 94c7675)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4d61045 Supress runtime logging warnings for java 11 (#5001) add 94c7675 Exclude slf4j from pom (#5010) No new revisions were added by this update. Summary of changes: pinot-plugins/pinot-input-format/pinot-parquet/pom.xml | 4 pinot-tools/pom.xml| 4 2 files changed, 8 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (38ee798 -> ff02093)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 38ee798 Make calcite parser support order by expression add ff02093 Set SqlConformanceEnum.LENIENT to CalciteParser No new revisions were added by this update. Summary of changes: .../apache/pinot/sql/parsers/CalciteSqlParser.java | 2 + .../pinot/sql/parsers/CalciteSqlCompilerTest.java | 53 +++--- 2 files changed, 48 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch switch-ui-to-sql updated (b2b5779 -> 26586a1)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch switch-ui-to-sql in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b2b5779 move sql back to pql parser discard edea63b Address comments discard 05da777 Adding sql endpoint in controller discard 8a1371c Update TransformExpressionTree.java discard fb06855 Make sql as default query format. add c6065ae [TE] weekly detection - time zone daily boundary alignment (#5004) add c3117d0 Handle sun.nio.ch.DirectBuffer cleaner behavior for jdk 8+ (#5002) add 0819c1e [TE] frontend - harleyjj/alert-details - show bounds for minute and day granularity in Alert Overview (#5000) add 1f876c6 update docker image location (#5007) add 4d61045 Supress runtime logging warnings for java 11 (#5001) add 94c7675 Exclude slf4j from pom (#5010) add c2c557c Make sql as default query format. add d83f270 Update TransformExpressionTree.java add 9fdae26 Adding sql endpoint in controller add 1e56284 Address comments add 91958f9 move sql back to pql parser add 26586a1 move sql parser to calcite parser again This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (b2b5779) \ N -- N -- N refs/heads/switch-ui-to-sql (26586a1) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: docker/images/pinot-presto/README.md | 4 +- docker/images/pinot-superset/Makefile | 2 +- docker/images/pinot-superset/README.md | 2 +- docker/images/pinot/README.md | 16 +- docker/images/pinot/docker-compose.yml | 6 +- kubernetes/helm/README.md | 7 +- kubernetes/helm/pinot-realtime-quickstart.yml | 8 +- kubernetes/helm/presto-coordinator.yaml| 2 +- kubernetes/helm/presto-worker.yaml | 2 +- kubernetes/helm/templates/broker/statefulset.yml | 2 +- .../helm/templates/controller/statefulset.yaml | 2 +- kubernetes/helm/templates/server/statefulset.yml | 2 +- kubernetes/helm/values.yaml| 7 +- kubernetes/skaffold/gke/pinot-broker.yml | 2 +- kubernetes/skaffold/gke/pinot-controller.yml | 2 +- .../skaffold/gke/pinot-realtime-quickstart.yml | 4 +- kubernetes/skaffold/gke/pinot-server.yml | 2 +- .../api/resources/PinotQueryResource.java | 34 +++- .../pinot/core/segment/memory/PinotByteBuffer.java | 12 +- .../org/apache/pinot/core/util/CleanerUtil.java| 199 + .../pinot-input-format/pinot-parquet/pom.xml | 4 + pinot-tools/pom.xml| 18 +- .../src/main/resources/appAssemblerScriptTemplate | 5 + .../src/main/resources/conf/pinot-admin-log4j2.xml | 4 + .../main/resources/conf/pinot-broker-log4j2.xml| 1 + .../resources/conf/pinot-controller-log4j2.xml | 1 + .../resources/conf/pinot-ingestion-job-log4j2.xml | 1 + .../main/resources/conf/pinot-server-log4j2.xml| 1 + .../src/main/resources/conf/pinot-tools-log4j2.xml | 4 + .../src/main/resources/conf/quickstart-log4j2.xml | 4 + .../app/pods/components/alert-details/component.js | 11 +- .../pinot/thirdeye/detection/DetectionUtils.java | 6 +- .../detection/components/HoltWintersDetector.java | 18 +- .../components/PercentageChangeRuleDetector.java | 11 +- 34 files changed, 325 insertions(+), 81 deletions(-) create mode 100644 pinot-core/src/main/java/org/apache/pinot/core/util/CleanerUtil.java - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5005: Make calcite parser support order by expression
Jackie-Jiang commented on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577932630 We don't support such queries yet, so what is the current behavior with this pr checked in? Will the engine throw exception or just ignore the order by? Throwing exception is better IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Make calcite parser support order by expression
fx19880617 commented on issue #5005: Make calcite parser support order by expression URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577933473 > We don't support such queries yet, so what is the current behavior with this pr checked in? Will the engine throw exception or just ignore the order by? Throwing exception is better IMO. @npawar added the support for group by order by aggregation functions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression
fx19880617 commented on a change in pull request #5005: Make calcite parser
support order by expression
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418027
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
I think I committed another change for supporting `LIMIT offset,count` into
this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression
fx19880617 commented on a change in pull request #5005: Make calcite parser
support order by expression
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418027
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
I think I committed another change for supporting `LIMIT offset,numRecords`
into this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5005: Make calcite parser support order by expression
siddharthteotia commented on a change in pull request #5005: Make calcite
parser support order by expression
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370417690
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
Why is this needed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Make calcite parser support order by expression
fx19880617 commented on a change in pull request #5005: Make calcite parser
support order by expression
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370418278
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
basically calcite parser cannot parse `LIMIT X,Y` until this conformance is
added.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.
siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577935875 This is supported on all paths right? (1) PQL -> PqlCompiler -> BrokerRequest (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() (3) SQL -> Calcite parser -> PinotQuery This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch fixing_calcite_parser_for_groupby_functions updated (ff02093 -> fa4001c)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_calcite_parser_for_groupby_functions in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard ff02093 Set SqlConformanceEnum.LENIENT to CalciteParser add fa4001c Set SqlConformanceEnum.LENIENT to CalciteParser This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (ff02093) \ N -- N -- N refs/heads/fixing_calcite_parser_for_groupby_functions (fa4001c) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .../java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.
fx19880617 commented on a change in pull request #5005: Calcite SQL compiler
syntax support for order by expression and Limit offset, count.
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370421179
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
> This is supported on all paths right?
>
> (1) PQL -> PqlCompiler -> BrokerRequest
> (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery ->
brokerRequest.setPinotQuery()
> (3) SQL -> Calcite parser -> PinotQuery
For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest
Query processing still depends on BrokerRequest.
Also plan to make query console default to go through path 3 in PR
https://github.com/apache/incubator-pinot/pull/4994
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count. URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577938204 > This is supported on all paths right? > > (1) PQL -> PqlCompiler -> BrokerRequest > (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() > (3) SQL -> Calcite parser -> PinotQuery For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest Query processing still depends on BrokerRequest. Also plan to make query console default to go through path 3 in PR #4994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and Limit offset, count.
fx19880617 commented on a change in pull request #5005: Calcite SQL compiler
syntax support for order by expression and Limit offset, count.
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370421179
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
> This is supported on all paths right?
>
> (1) PQL -> PqlCompiler -> BrokerRequest
> (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery ->
brokerRequest.setPinotQuery()
> (3) SQL -> Calcite parser -> PinotQuery
For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest
Query processing still depends on BrokerRequest.
Also plan to make query console default to go through path 3 in PR
https://github.com/apache/incubator-pinot/pull/4994
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
npawar commented on a change in pull request #5005: Calcite SQL compiler syntax
support for order by expression and set LENIENT SQL conformance
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370427425
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
@siddharthteotia we did an exercise at LI wherein we passed all possible
used queries though Calcite parser. We caught certain things which do not pass
under the default sql conformance level (`!=` and `LIMIT offset, count`). One
of the solutions for that we discussed was to set the conformance to be more
lenient.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
npawar commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577944366 This LGTM. I see you've also included the change to use LIMIT in group by queries. Please call that out as well in the description. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
siddharthteotia commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945733 > > This is supported on all paths right? > > (1) PQL -> PqlCompiler -> BrokerRequest > > (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() > > (3) SQL -> Calcite parser -> PinotQuery > > For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest > Query processing still depends on BrokerRequest. Just to be on the same page (and this is not really related to this PR), for path 3, once we have the PinotQuery, we are only going to set it inside BrokerRequest -- we are not going to build a full fledged broker request all together by converting PinotQuery to BrokerRequest. So the desired end state here is to have the BrokerRequest as just a wrapper thrift definition over PinotQuery and the servers should build their execution plan from the information stored in brokerRequest.getPinotQuery() -- this should be sufficient to build the plan. In fact, since PinotQuery is a thrift object on its own, we should be sending that to the servers and migrate each and every operator to work off PinotQuery -> QueryContext as described in this doc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945931 > This LGTM. > I see you've also included the change to use LIMIT in group by queries. Please call that out as well in the description. sure, I think also for SQL parser, we actually don't support TOP, so LIMIT is used. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
siddharthteotia edited a comment on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577945733 > > This is supported on all paths right? > > (1) PQL -> PqlCompiler -> BrokerRequest > > (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() > > (3) SQL -> Calcite parser -> PinotQuery > > For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest > Query processing still depends on BrokerRequest. Just to be on the same page (and this is not really related to this PR), for path 3, once we have the PinotQuery, we are only going to set it inside BrokerRequest -- we are not going to build a full fledged broker request all together by converting PinotQuery to BrokerRequest. So the desired end state here is to have the BrokerRequest as just a wrapper thrift definition over PinotQuery and the servers should build their execution plan from the information stored in brokerRequest.getPinotQuery() -- this should be sufficient to build the plan. In fact, since PinotQuery is a thrift object on its own, we should be sending that to the servers and migrate each and every operator to work off PinotQuery -> QueryContext as described in this doc https://docs.google.com/document/d/1uNIq0cybUtVtdtJ38-4ewFNEQorbg-2KYr-CMSj6H_8/edit?ts=5ddda014=1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
siddharthteotia commented on a change in pull request #5005: Calcite SQL
compiler syntax support for order by expression and set LENIENT SQL conformance
URL: https://github.com/apache/incubator-pinot/pull/5005#discussion_r370429986
##
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##
@@ -111,6 +112,7 @@ private static void setOptions(PinotQuery pinotQuery,
List optionsStatem
private static PinotQuery compileCalciteSqlToPinotQuery(String sql) {
SqlParser.ConfigBuilder parserBuilder = SqlParser.configBuilder();
parserBuilder.setLex(PINOT_LEX);
+parserBuilder.setConformance(SqlConformanceEnum.LENIENT);
Review comment:
Got it. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
fx19880617 commented on issue #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005#issuecomment-577946390 > > > This is supported on all paths right? > > > (1) PQL -> PqlCompiler -> BrokerRequest > > > (2) PQL -> PqlCompiler -> BrokerRequest -> PinotQuery -> brokerRequest.setPinotQuery() > > > (3) SQL -> Calcite parser -> PinotQuery > > > > > > For path 3 it's SQL -> Calcite parser -> PinotQuery -> BrokerRequest > > Query processing still depends on BrokerRequest. > > Just to be on the same page (and this is not really related to this PR), for path 3, once we have the PinotQuery, we are only going to set it inside BrokerRequest -- we are not going to build a full fledged broker request all together by converting PinotQuery to BrokerRequest. > > So the desired end state here is to have the BrokerRequest as just a wrapper thrift definition over PinotQuery and the servers should build their execution plan from the information stored in brokerRequest.getPinotQuery() -- this should be sufficient to build the plan. > > In fact, since PinotQuery is a thrift object on its own, we should be sending that to the servers and migrate each and every operator to work off PinotQuery -> QueryContext as described in this doc Currently we are still convert PinotQuery to internal BrokerRequest fields objects. The end goal is to use fields inside PinotQuery for internal query processing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[incubator-pinot] branch master updated (94c7675 -> 995ad83)
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 94c7675 Exclude slf4j from pom (#5010) add 995ad83 Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance (#5005) No new revisions were added by this update. Summary of changes: .../request/PqlAndCalciteSqlCompatibilityTest.java | 28 .../utils/BrokerRequestComparisonUtils.java| 47 - .../parsers/PinotQuery2BrokerRequestConverter.java | 7 +- .../pinot/pql/parsers/pql2/ast/SelectAstNode.java | 20 +++--- .../apache/pinot/sql/parsers/CalciteSqlParser.java | 11 ++-- .../apache/pinot/pql/parsers/Pql2CompilerTest.java | 14 .../pinot/sql/parsers/CalciteSqlCompilerTest.java | 77 +- 7 files changed, 185 insertions(+), 19 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance
fx19880617 merged pull request #5005: Calcite SQL compiler syntax support for order by expression and set LENIENT SQL conformance URL: https://github.com/apache/incubator-pinot/pull/5005 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5011: [TE] endpoint - harleyjj/yamlresource - add dataset as an optional pa…
harleyjj commented on a change in pull request #5011: [TE] endpoint -
harleyjj/yamlresource - add dataset as an optional pa…
URL: https://github.com/apache/incubator-pinot/pull/5011#discussion_r370435266
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##
@@ -907,8 +907,28 @@ public Response toggleActivation(
*/
@GET
@Path("/list")
+ @ApiOperation("Get the list of all detection YAML configurations as JSON
enhanced with additional information, optionally filtered")
@Produces(MediaType.APPLICATION_JSON)
- public List> listYamls() throws ExecutionException {
-return
this.detectionConfigDAO.findAll().parallelStream().map(this.detectionConfigFormatter::format).collect(Collectors.toList());
+ public List> listYamls(
+ @ApiParam("Dataset the detection configurations should be filtered by")
@QueryParam("dataset") String dataset) throws ExecutionException {
+List> yamls;
+if (dataset == null) {
+ yamls = this.detectionConfigDAO
+ .findAll()
+ .parallelStream()
+ .map(this.detectionConfigFormatter::format)
+ .collect(Collectors.toList());
+} else {
+ yamls = this.detectionConfigDAO
+ .findAll()
+ .parallelStream()
+ .map(this.detectionConfigFormatter::format)
+ .filter(y -> {
+List thisYaml = (List)y.get("datasetNames");
Review comment:
I added metric as an optional param, as well. Would this comment still
apply to the updated code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
