Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-14 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1857019408

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 17 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 51s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 58s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m 10s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  15m  0s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   4m 16s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   8m 47s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   7m 30s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 39s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 40s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m  5s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   5m 15s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 35s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 35s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m  2s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |  15m  2s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   8m 55s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   7m 35s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 38s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +0 :ok: |  spotbugs  |   0m 35s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  32m 31s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 37s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  20m  2s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 259m 25s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 105m 52s |  |  
hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 51s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 39s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  22m  3s |  |  hadoop-yarn-services-core in 
the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 46s |  |  hadoop-client-check-invariants 
in the patch passed.  |
   | +1 :green_heart: |  unit  |   0m 44s |  |  
hadoop-client-check-test-invariants

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-08 Thread via GitHub 


steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420351865


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
   I have no idea what happens with DLLs and shaded libs. probably messy. 
   
   Does byte buddy *ever* get used? if not, can we exclude it from the base 
import and so no problems downstream.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-08 Thread via GitHub 


steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420352516


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
   ...given what bytebuddy does, I suspect its used a lot...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-08 Thread via GitHub 


saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420202409


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
   Looks like its dlls will come in the minicluster jar. Reason being, 
mockito-core has a compile-dependency on byte-buddy-agent (so creating jar of 
minicluster bring in mockito-core, but also byte-buddy-agent by transitivity). 
The use of mockito-core as compile in minicluster looks like its there to help 
hadoop-hdfs test-jar run in integeration-test.
   
   Now, mockito-core may need these dlls in the flow defined by  -> 
https://github.com/mockito/mockito/blob/d86bca62a4e9500567ffe97826865460a9c30f18/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java#L133
 -> which creates an object of VirtualMachine.  These dlls would be used here: 
https://github.com/raphw/byte-buddy/blob/master/byte-buddy-agent/src/main/java/net/bytebuddy/agent/VirtualMachine.java#L1269.
   
   These dlls come on the root of the minicluster jar, and the VirtualMachine 
will be in org.apache.hadoop.shaded.net.bytebuddy.agent.VirtualMachine. The 
only concern is if the VirtualMachine triggering from NativeLibrary API from 
shaded path can take up the dll on the root or if it has to be relocated to 
shaded path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-08 Thread via GitHub 


saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1420202409


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
   Looks like its dlls will come in the minicluster jar. Reason being, 
mockito-core has a compile-dependency on byte-buddy-agent (so creating jar of 
minicluster bring in mockito-core, but also byte-buddy-agent by transitivity). 
The use of mockito-core as compile in minicluster looks like its there to help 
hadoop-hdfs test-jar run in integeration-test.
   
   Now, mockito-core may need these dlls in the flow defined by  -> 
https://github.com/mockito/mockito/blob/d86bca62a4e9500567ffe97826865460a9c30f18/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java#L133
 -> which creates an object of VirtualMachine.  These dlls would be used here: 
https://github.com/raphw/byte-buddy/blob/master/byte-buddy-agent/src/main/java/net/bytebuddy/agent/VirtualMachine.java#L1269.
   
   These dlls come on the root of the minicluster jar, and the VirtualMachine 
will be in org.apache.hadoop.shaded.net.bytebuddy.agent.VirtualMachine. The 
only concern is if the VirtualMachine triggering NativeLibrary API from shaded 
path can take up the dll on the root or if it has to be relocated to shaded 
path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-07 Thread via GitHub 


steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1419369703


##
hadoop-client-modules/hadoop-client-minicluster/pom.xml:
##
@@ -400,6 +400,7 @@
 
   org.mockito
   mockito-core
+  ${mockito.version}

Review Comment:
   yes, it must be removed to stop inconsistencies ever surfacing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-06 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1843718075

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   1m 21s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +0 :ok: |  xmllint  |   0m  1s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 17 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 18s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  37m 39s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  19m 44s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  17m 26s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  checkstyle  |   4m 53s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   9m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m  4s |  |  trunk passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   7m 48s |  |  trunk passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 33s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 33s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 35s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  36m 24s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  36m 50s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  19m 10s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 28s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  17m 28s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 59s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +1 :green_heart: |  javac  |  14m 59s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  5s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   9m 30s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m  3s |  |  the patch passed with JDK 
Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m 11s |  |  the patch passed with JDK 
Private Build-1.8.0_392-8u392-ga-1~20.04-b08  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  32m 22s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 36s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  19m 56s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 264m 50s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 105m 57s |  |  
hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 51s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 32s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart:

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub 


anmolanmol1234 commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416851730


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
   These are coming from byte-buddy-agent module and not the mockito-bom one. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub 


anmolanmol1234 commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1416850390


##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
 jackson-dataformat-cbor
 ${jackson2.version}
   
+  
+org.mockito
+mockito-bom
+${mockito.version}
+pom

Review Comment:
   I agree with the decision to remove the 'mockito-bom' dependency. However, 
I've encountered an issue where the DLL files are not being included due to the 
removal of this dependency. The DLL files are originally included as part of 
the 'byte-buddy-agent' POM, and 'mockito-core' has a dependency on this module. 
Despite setting the value of 'mockito-core' as optional in 
'hadoop-minicluster,' the transitive dependency is still affecting 
'hadoop-client-check-test-invariants,' resulting in an error during the check 
for jar contents due to disallowed DLL values. Consequently, I've addressed 
this by adding the necessary expressions to allow these DLL files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-05 Thread via GitHub 


steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414157394


##
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -69,6 +69,10 @@ allowed_expr+="|^krb5_udp-template.conf$"
 allowed_expr+="|^jetty-dir.css$"
 # Snappy java is native library. We cannot relocate it to under 
org/apache/hadoop.
 allowed_expr+="|^org/xerial/"
+allowed_expr+="|^win32-x86/$"
+allowed_expr+="|^win32-x86/attach_hotspot_windows.dll$"

Review Comment:
yes, these seem android related. if we keep the android dependencies out, 
we don't need these



##
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -58,6 +58,10 @@ 
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
 allowed_expr+="|^java.policy$"
 #   * Used by javax.annotation
 allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-12-04 Thread via GitHub 


steveloughran commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1414155674


##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
 jackson-dataformat-cbor
 ${jackson2.version}
   
+  
+org.mockito
+mockito-bom
+${mockito.version}
+pom

Review Comment:
   be safer to just pull in the ones we know we need



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-29 Thread via GitHub 


saxenapranav commented on code in PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#discussion_r1410207987


##
hadoop-project/pom.xml:
##
@@ -1288,10 +1288,22 @@
 jackson-dataformat-cbor
 ${jackson2.version}
   
+  
+org.mockito
+mockito-bom
+${mockito.version}
+pom

Review Comment:
   This would import the dependency-management of mockito-bom. From, 
https://central.sonatype.com/artifact/org.mockito/mockito-bom, looks like it 
also has mockito-android. Was curious that if the dll files are coming because 
of this. Also, do we need the bom, since we are adding dependencies for both 
mockito-core and mockito-inline (because we would be importing many other 
dependencies which might not be of use). 



##
hadoop-client-modules/hadoop-client-minicluster/pom.xml:
##
@@ -400,6 +400,7 @@
 
   org.mockito
   mockito-core
+  ${mockito.version}

Review Comment:
   I think we can remove it. Since, hadoop-project is parent of this pom, and 
in that, there is dependency-management which has this dependency with a 
version. This would pick that version, if we remove version here.



##
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -58,6 +58,10 @@ 
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
 allowed_expr+="|^java.policy$"
 #   * Used by javax.annotation
 allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"

Review Comment:
   same for the other shell file.



##
hadoop-client-modules/hadoop-client-check-test-invariants/src/test/resources/ensure-jars-have-correct-contents.sh:
##
@@ -58,6 +58,10 @@ 
allowed_expr+="|^org.apache.hadoop.application-classloader.properties$"
 allowed_expr+="|^java.policy$"
 #   * Used by javax.annotation
 allowed_expr+="|^jndi.properties$"
+allowed_expr+="|^win32-x86/$"

Review Comment:
   mockito-core is an optional dependency in minicluster -> it should not be 
transitive and also would not be coming into classpath of this project (ref: 
https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html#how-do-optional-dependencies-work).
 Was curious, what is the reason for these dll coming here.
   Would be awesome, if you can add comment for the reasoning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-29 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1832695256

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 17 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 12s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 29s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m 24s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 57s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   4m 15s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   9m 27s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m  8s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m 10s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 44s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m  9s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  16m 21s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 35s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 35s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |  15m  7s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  8s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   9m 27s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m  4s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m  7s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +1 :green_heart: |  shadedclient  |  32m 43s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 36s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  20m  2s |  |  hadoop-common in the patch 
passed.  |
   | -1 :x: |  unit  | 258m 36s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6275/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  unit  | 106m 50s |  |  
hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-29 Thread via GitHub 


anmolanmol1234 commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1831603487

   > actually, I'm trying to understand this.
   > 
   > > we changed the scope of the mockito-core dependency to compile.
   > 
   > why do we need this? and why can't it just be marked as "provided" so it 
doesn't get picked up by everything downstream on what is meant to be a 
low-dependency component
   
   Have changed the explicit mention of scope as a part of new iteration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-23 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1824847734

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  1s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  1s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  shelldocs  |   0m  1s |  |  Shelldocs was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 17 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 36s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  31m 12s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m 10s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 58s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   4m 16s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   9m 33s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m 40s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m 46s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output 
file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 19s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  32m 44s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  16m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 38s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 38s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 53s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |  14m 53s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  8s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  10m  2s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  0s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   8m 40s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m 39s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 35s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 39s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-integration-tests has no data from spotbugs 
 |
   | +1 :green_heart: |  shadedclient  |  32m 49s |  |  patch has no errors 
when building and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  19m 55s |  |  hadoop-common in the patch 
passed.  |
   | +1 :green_heart: |  unit  | 261m 54s |  |  hadoop-hdfs in the patch 
passed.  |
   | +1 :green_heart: |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-22 Thread via GitHub 


anmolanmol1234 commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823838318

   Hi @steveloughran, I have made the changes for shaded client checks that 
were failing on the mockito upgrade. Requesting your review for the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-22 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1823806436

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 55s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 17 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 26s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 56s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m 16s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 50s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   4m 14s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  11m 16s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   9m 56s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   9m 53s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 36s |  |  
branch/hadoop-client-modules/hadoop-client-api no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
branch/hadoop-client-modules/hadoop-client-check-invariants no spotbugs output 
file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-check-test-invariants no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-integration-tests no spotbugs output 
file (spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 39s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  33m  3s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  29m  4s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 37s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 52s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |  14m 52s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  8s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  11m 24s |  |  the patch passed  |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  |  No new issues.  |
   | +1 :green_heart: |  javadoc  |   9m 47s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   9m 54s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 34s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
hadoop-client-modules/hadoop-client-api has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-invariants has no data from spotbugs  
|
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-check-test-invariants has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-21 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1822155782

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 55s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 15 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 40s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 59s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m  9s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 57s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   4m 14s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   9m 27s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   8m  9s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m  9s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 41s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-api no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 38s |  |  
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  32m 27s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  32m 51s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 36s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  27m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 37s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 49s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |  14m 49s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  2s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   9m 21s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   8m  3s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   8m 10s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 35s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-api has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 37s |  |  
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 39s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | -1 :x: |  shadedclient  |  32m 43s |  |  patch has errors when building 
and testing our client artifacts.  |
    _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  |  hadoop-project in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  19m 25s |  |  hadoop-common in the patch 
passed.  |
   | -1 :x: |  unit  | 260m 57s | 
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6275/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
 |  hadoop-hdfs in the patch passed.  |
   | +1 :green_heart: |  unit  | 105m 54s |  |  
hadoop-yarn-server-resourcemanager in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 50s |  |  hadoop-yarn-server-nodemanager 
in the patch passed.  |
   | +1 :green_heart: |  unit  |  24m 20s |  |  hadoop-hdfs-rbf in the patch 
passed.  |
   | +1 :green_heart: |  unit  |  21m 59s |  |

Re: [PR] Hadoop 18860: Upgrade mockito version to 4.11.0 [hadoop]

2023-11-21 Thread via GitHub 


hadoop-yetus commented on PR #6275:
URL: https://github.com/apache/hadoop/pull/6275#issuecomment-1820696613

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |::|--:|:|::|:---:|
   | +0 :ok: |  reexec  |   0m 56s |  |  Docker mode activated.  |
    _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  2s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 15 new or modified test files.  |
    _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m  9s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  30m 30s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  16m  7s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  14m 38s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  checkstyle  |   4m 18s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  40m  9s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |  28m 55s |  |  trunk passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |  26m 34s |  |  trunk passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 19s |  |  branch/hadoop-project no spotbugs 
output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 21s |  |  
branch/hadoop-hdfs-project/hadoop-hdfs-native-client no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 27s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests
 no spotbugs output file (spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 24s |  |  
branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 26s |  |  
branch/hadoop-client-modules/hadoop-client-api no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 26s |  |  
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file 
(spotbugsXml.xml)  |
   | +0 :ok: |  spotbugs  |   0m 26s |  |  
branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file 
(spotbugsXml.xml)  |
   | +1 :green_heart: |  shadedclient  |  31m 51s |  |  branch has no errors 
when building and testing our client artifacts.  |
   | -0 :warning: |  patch  |  32m 12s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
    _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 37s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  47m 39s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  15m 31s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  15m 31s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  14m 49s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +1 :green_heart: |  javac  |  14m 49s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   4m  4s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |  39m 47s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |  28m 50s |  |  the patch passed with JDK 
Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |  26m 24s |  |  the patch passed with JDK 
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05  |
   | +0 :ok: |  spotbugs  |   0m 20s |  |  hadoop-project has no data from 
spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 22s |  |  
hadoop-hdfs-project/hadoop-hdfs-native-client has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 27s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-tests has 
no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 24s |  |  
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 25s |  |  
hadoop-client-modules/hadoop-client-api has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 28s |  |  
hadoop-client-modules/hadoop-client-runtime has no data from spotbugs  |
   | +0 :ok: |  spotbugs  |   0m 27s |  |  
hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs  |
   | -1 :x: |  shadedclient  |  30m 20s |  |  patch has errors when building