Bug#1034394: unblock: zabbix/1:6.0.14+dfsg-1
Dear Paul and Release team, Thank you for allowing this upload to become part of the upcoming release. On Saturday, 6 May 2023 4:38:23 PM AEST Paul Gevers wrote: > For future reference, can we discuss this in advance? I.e. when you knew > the fix for php-8.2 was coming late in our freeze. I had no idea that such release was expected. Zabbix team have decent development transparency but they do not announce their development priorities. Frankly, I was not even aware of the compatibility issue that was reported just days prior to upstream release that corrected it. > Referring that uploading an upstream stable release has been done in > the past in the > security archive would have helped too. Noted. I did not remember about that and would not think that mentioning that would be relevant. Zabbix is a well-governed, 18 years old software that we have in Debian for a long time. I don't recall ever having problems or regressions in their minor releases. > Anyways, unblocked (because upstream seems to have a matching stable > release policy). Awesome. Thanks again for your help and sorry for troubles with late upload. -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- Continuous effort - not strength or intelligence - is the key to unlocking our potential. -- Winston Churchill --- https://maskscience.org/ - your ultimate reference of (anti-)mask science. signature.asc Description: This is a digitally signed message part.
Bug#1034394: unblock: zabbix/1:6.0.14+dfsg-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Affects: -1 zabbix Dear release team, Please consider unblocking "zabbix/1:6.0.14+dfsg-1" in order to fix PHP-8.2 compatibility issues (#1033241). Thank you. -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- To suppress free speech is a double wrong. It violates the rights of the hearer as well as those of the speaker. It is just as criminal to rob a man of his right to speak and hear as it would be to rob him of his money... -- Frederick Douglass signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Tuesday, 2 February 2021 4:18:02 PM AEDT Anthony Fok wrote: > Would both podman 2 and podman 3 be a possibility? > I.e., we could keep the existing "podman" package at 2.1.1, while > creating a new "podman3" or "podman-3" package? > > Feasible solution? :-) IMHO definitely not worth the effort... It is only a matter of one upstream bug... -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- There is no such thing as public opinion. There is only published opinion. -- Winston Churchill --- COVID-19 (excess) mortalities: viral cause impossible—drugs with key role in about 200,000 extra deaths in Europe and the US alone https://realnewsaustralia.com/2020/10/01/covid-19-excess-mortalities-viral-cause-impossible-drugs-with-key-role-in-about-20-extra-deaths-in-europe-and-the-us-alone/ signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
rtain packages until better times - unwanted but small inconvenience. We can still incorporate Nomad+driver-Podman+Podman_2 into next release but desire for Podman_3 is a classic dilemma of "better" being the enemy of "good"... Reinhard, if you really want Podman-3 in the next Debian release then go for it and upload to "unstable". We are yet to build confidence in Nomad-driver-Podman adaptations for new API... If that not happens in time then so be it and we either won't be able to run Podman containers under Nomad or would have to install packages directly from testing/unstable/snapshots. Sigh... -- Best wishes, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- Truth — Something somehow discreditable to someone. -- H. L. Mencken, 1949 --- As of 19 March 2020, COVID-19 is no longer considered to be a high consequence infectious disease (HCID) in the UK. -- https://www.gov.uk/guidance/high-consequence-infectious-diseases-hcid signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
Hi Faidon, On Tuesday, 2 February 2021 4:37:14 AM AEDT Faidon Liambotis wrote: > 2) upgrading both nomad-driver-podman and podman to their latest > upstream releases. These are seemingly compatible with each other, but > breaking one particular use case, which while niche, happens to be > unfortunately the maintainer's primary use case. > > IMHO option (2) is the reasonable choice here, and one that benefits the > most users across the board. It sucks for Dmitry, I get that; but I > don't see how option (1) would work. It means that we'll get stuck on an > older stack, with no end date in sight. > > The fact that as has been mentioned in this thread a) bullseye is around > the corner b) nomad-driver-podman isn't even in testing right now, c) > podman itself is a much more popular package than nomad-driver-podman > (or nomad for that matter), are all very strong points in favor of > option (2), but are all *on top* of the original point -- again, IMHO. Good reasoning and, I admit, you've almost convinced me. However, release or not release, it is bad to break things in "testing" and "unstable". We do have users that rely on those suites, myself included. Also consider the discouragement factor. Me, maintainer of podman, nomad, nomad-driver-podman as well as their countless dependency packages, is at the verge of saying "whatever" and stop caring or even walk away from the mess since the moment when technology become useless to me. Too bad I've invested so much time stabilising it if "release concerns" require me to break it... I'll think more about all this. -- All the best, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- The strongest argument for socialism is that it sounds good. The strongest argument against socialism is that it doesn't work. But those who live by words will always have a soft spot in their hearts for socialism because it sounds so good. -- Thomas Sowell --- Multiple errors in the New York Times article about Sweden’s corona strategy -- Emanuel Karlsten, https://emanuelkarlsten.se/multiple-errors-in-the-new-york-times-article-about-swedens-corona-strategy/ signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Monday, 1 February 2021 8:07:36 AM AEDT Reinhard Tartler wrote: > Have you considered keeping your NFS share with the OCI images, > but using a registry just for distribution to your cluster? > This way your registry is basically just a cache. All the down sides and no benefits. Space creep would still be there plus another moving part to maintain plus it is another single point of failure. By the way I'm not using NFS but a different technology... > I can follow your thinking, and I sympathize, but ultimately, I > still think that on the compromise between keeping varlink and podman > at version 2.1, and updating to podman 3.0 and getting docker-compose > functionality, Debian's users are better served by having podman 3.0 > in bullseye. Maybe... But we should not break testing/unstable for that matter. This very conversation suggests that the technology is too unstable and too volatile for "stable" (Bullseye). IMHO docker compose is unimportant and redundant while Podman-based Nomad-driven cluster orchestration have much more potential. If upstreams fix the problem quick enough then we should be able to make Podman-3.0 ready in time. There still a chance. -- Kind regards, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- Your Facebook friends are wrong about the lockdown. A non-hysterics's guide to COVID-19 by Tom Woods. -- https://wrongaboutlockdown.com/ signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Sunday, 31 January 2021 7:29:16 PM AEDT Shengjing Zhu wrote: > I do run a private registry with my CI, many images are pushed and > deleted daliy. But I haven't noticed disk space leaks. Upstream have many bugs about that... Here are just a few (I've seen more of those...): https://github.com/distribution/distribution/issues/1844 https://github.com/distribution/distribution/issues/2190 Even with "docker-registry garbage-collect" some images are never deleted... Also have a look at the following project (there are more but this one works) - it have more relevant upstream bugs referenced: https://github.com/mortensteenrasmussen/docker-registry-manifest-cleanup I'm not sure about the following one: https://github.com/TranceMaster86/docker-reg-gc > > IMHO just saving built images to network share is the best, easiest, most > > reliable way of deploying local images. It is the best to avoid Docker > > registry whenever possible. > > However only the registry is able to dedup the image layers. But Docker Registry is also the single point of failure. In otherwise redundant cluster such as Nomad one can strive to avoid single point of failure. Network share on clustered file systems (e.g. MooseFS, LizardFS, GfarmFS, etc.) can be more reliable than a NFS share from single server or a single instance of Docker Registry. -- Kind regards, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- The trouble with our times is that the future is not what it used to be. -- Paul Valery --- "A closer look at U.S. deaths due to COVID-19" 2020-11-26, The Johns Hopkins News-Letter -- https://notthebee.com/article/a-few-days-ago-johns-hopkins-published-a-study-saying-corona-is-nbd-they-then-deleted-it-read-it-here-in-its-entirety -- https://web.archive.org/web/20201126223119/https://www.jhunewsletter.com/article/2020/11/a-closer-look-at-u-s-deaths-due-to-covid-19 signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Sunday, 31 January 2021 1:08:36 PM AEDT Reinhard Tartler wrote: > A low-effort workaround could be to add a build-dependency on podman to > prevent it from building on mipsen. Thank you for advise. I shall do that to allow migration. > > No it hasn't... :( There is a serious regression: > > https://github.com/hashicorp/nomad-driver-podman/issues/69 > > I'm having a hard time considering this a "serious" regression. The problem > as far as I understand is that while the driver does work fine with the > new REST interface, it doesn't allow you to upload images in OCI format > from local disk. > If you instead chose to have imaged pulled from a (local) image registry, > the driver would work fine. Do you have experience operating local container registry?? I have and I can tell that it is not fun, to say the least. Docker registry leaks disk space because it does not garbage collect some images... Neither does it like Buildah/Podman's native image format, although it can be remedied by building images with "export BUILDAH_FORMAT=docker". IMHO just saving built images to network share is the best, easiest, most reliable way of deploying local images. It is the best to avoid Docker registry whenever possible. > Blocking podman 3.0 because of this is something I can't get behind. > But maybe I'm missing something else here? I hope my answer above helps to understand the issue... -- Cheers, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- Weakness of attitude becomes weakness of character. -- Albert Einstein --- Your Facebook friends are wrong about the lockdown. A non-hysterics's guide to COVID-19 by Tom Woods. -- https://wrongaboutlockdown.com/ signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Monday, 25 January 2021 10:47:25 PM AEDT Reinhard Tartler wrote: > It seems that https://packages.qa.debian.org/n/nomad-driver-podman.html > has never made it to testing, which makes me wonder whether > it'll make it to bullseye. Nothing should stop it from getting to "testing". It was blocked on due to "autopkgtest-pkg-go" which is useless for binary-only packages. At a time I did not mind because I was not sure whether it is good enough for "testing". Either way, it would be bad break perfectly working "nomad-driver-podman" in "unstable" even though it has never been in "testing" yet. > On the tradeoff "podman 3.0 with docker-compose" support vs. > a "nomad driver for podman", I see more value for (more of) > our users for the newer podman. I base that on popcon numbers: > > - nomand: 35 > - nomad-driver-podman: 4 > - podman: 340 IMHO Nomad with Podman is more useful. Docker-compose is somewhat redundant and with Nomad we have a proper container-based cluster orchestration with service auto-discovery. > > I'm running some of my infrastructure on "nomad-driver-podman" and loss > > of Varlink is not acceptable to me until Podman and nomad-driver-podman > > resolve some of the issues. I might happen soon, let's hope, but we > > wouldn't know until it happen... > > Ouch, that's indeed unfortunate. It is not unfortunate. Everything works as expected and how else would I know whether technology is good enough for the next release? "Fix it for yourself and for everyone else" has been my philosophy for some time. :) The only unfortunate thing is regression on Podman side that is holding back upgrade of "nomad-driver-podman" and de-commissioning of Varlink... > Luckily it seems that issue > has been fixed in latest master of nomad-driver-podman, cf. No it hasn't... :( There is a serious regression: https://github.com/hashicorp/nomad-driver-podman/issues/69 > Maybe you can integrate that change into the Debian package? As soon as the fix is available... -- All the best, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- It is a mistake to try to look too far ahead. The chain of destiny can only be grasped one link at a time. -- Winston Churchill --- 2014-2015 influenza vaccination was -17% efficient. -- https://pubmed.ncbi.nlm.nih.gov/27025838/ signature.asc Description: This is a digitally signed message part.
Re: Podman 3.0 and Debian bullseye
On Monday, 25 January 2021 12:02:26 PM AEDT Reinhard Tartler wrote: > - Podman 3 drops the legacy varlink interface. To the best of my > knowledge, there are no packages in debian/testing that would require > varlink (please correct me if I'm wrong here). Not having to support > varlink in Debian seems a support benefit, there is little to no love > for it upstream. Varlink is needed by Nomad/nomad-driver-podman. Unfortunately "nomad-driver-podman" is not ready for new HTTP API due to some problems with it (strangely enough Varlink interface is more mature at this point). I'm running some of my infrastructure on "nomad-driver-podman" and loss of Varlink is not acceptable to me until Podman and nomad-driver-podman resolve some of the issues. I might happen soon, let's hope, but we wouldn't know until it happen... -- Regards, Dmitry Smirnov GPG key : 4096R/52B6BBD953968D1B --- The very same people who say that government has no right to interfere with sexual activity between consenting adults believe that the government has every right to interfere with economic activity between consenting adults. -- Thomas Sowell signature.asc Description: This is a digitally signed message part.
Bug#915362: RM: rkt [armhf] -- ROM; FTBFS
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Affects: rkt Please remove [armhf] binaries of "rkt" from "testing". "arm64" flavor of [armhf] architecture is not supported by "rkt" and old binaries prevent migration of "rkt" to "testing". Thanks. -- Regards, Dmitry Smirnov. --- Democracy is a pathetic belief in the collective wisdom of individual ignorance. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#864330: unblock: redmine-plugin-pretend/0.0.2+git20130821-4
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Affects: -1 redmine-plugin-pretend Please unblock redmine-plugin-pretend/0.0.2+git20130821-4 This change fixes compatibility with current Redmine in Stretch. Thanks. -- All the best, Dmitry Smirnov. The information contained in this email and any attached files are strictly private and confidential. This email should be read only by the intended addressee only. If the recipient of this message is not the intended addressee, please call Staples Australia Pty Limited on +61 2 9335 0555 or Staples New Zealand Limited on +64 9 271 7600 and promptly delete this email and any attachments. The intended recipient of this email may only use, reproduce, disclose or distribute the information contained in this email and any attached files with the prior written permission of StaplesTM. If you are not the intended addressee, you are strictly prohibited from using, reproducing, disclosing or distributing the information contained in this email and any attached files. StaplesTM advises that this email and any attached files should be scanned to detect viruses. StaplesTM accepts no liability for loss or damage (whether caused by negligence or not) resulting from the use of any attache! d files. diff --git a/debian/changelog b/debian/changelog index 37e74ac..71f40a2 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +redmine-plugin-pretend (0.0.2+git20130821-4) unstable; urgency=medium + + * New upstream patch for compatibility with Redmine v3.2+. + + -- Dmitry Smirnov <only...@debian.org> Sun, 21 May 2017 14:38:49 +1000 + redmine-plugin-pretend (0.0.2+git20130821-3) unstable; urgency=medium * "no_route_match.patch" updated as per upstream commit. diff --git a/debian/patches/3.2.patch b/debian/patches/3.2.patch new file mode 100644 index 000..6b9298a --- /dev/null +++ b/debian/patches/3.2.patch @@ -0,0 +1,202 @@ +Last-Update: 2017-05-19 +Origin: upstream, https://github.com/batizhevsky/redmine_pretend/commit/08919a20bedf38430068aea0fdbe84a1d4178d15 +From: Leonid Batizhevsky <l.batizhev...@fun-box.ru> +Date: Wed, 20 Jan 2016 23:25:04 +0400 +Subject: redmine 3.2 support, drop support of < 2 + +--- /dev/null b/app/helpers/pretend_helper.rb +@@ -0,0 +1,9 @@ ++module PretendHelper ++ def can_user_pretend_to?(user) ++!session[:real_user_id] && User.current.admin? && User.current != user ++ end ++ ++ def current_unpretended_user ++User.find_by_id(session[:real_user_id]) ++ end ++end +--- a/app/views/user/_pretend_to.html.erb b/app/views/user/_pretend_to.html.erb +@@ -1,4 +1,4 @@ +-<%= link_to l(:button_pretend), pretend_to_path(@user), :class => 'icon', :method => :post if !session[:real_user_id] && User.current.admin? %> ++<%= link_to l(:button_pretend), pretend_to_path(@user), :class => 'icon', :method => :post if can_user_pretend_to?(@user) %> + + + +--- a/app/views/user/_unpretend.html.erb b/app/views/user/_unpretend.html.erb +@@ -1,6 +1,6 @@ + <% if session[:real_user_id] %> + +-<%= l(:pretend_message) %> <%= User.find_by_id(User.active.find(session[:real_user_id])) %> ++<%= l(:pretend_message) %> <%= current_unpretended_user %> + <%= link_to l(:button_unpretend), unpretend_path, :class => 'icon', :method => :post %> + +-<% end %> +\ No newline at end of file ++<% end %> +--- a/config/routes.rb b/config/routes.rb +@@ -1,11 +1,4 @@ +-if Rails::VERSION::MAJOR >= 3 +- RedmineApp::Application.routes.draw do +-post 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to' +-post 'admin/unpretend' => 'application#unpretend', :as => 'unpretend' +- end +-else +- ActionController::Routing::Routes.draw do |map| +-map.pretend_to 'admin/pretend_to/:id', :controller => 'application', :action => 'pretend_to' +-map.unpretend 'admin/unpretend', :controller => 'application', :action => 'unpretend' +- end ++RedmineApp::Application.routes.draw do ++ post 'admin/pretend_to/:id' => 'application#pretend_to', :as => 'pretend_to' ++ post 'admin/unpretend' => 'application#unpretend', :as => 'unpretend' + end +--- a/init.rb b/init.rb +@@ -1,31 +1,23 @@ + require 'redmine' + + require_dependency 'redmine_pretend/hooks' + +-if Rails::VERSION::MAJOR >= 3 +- Rails.logger.info 'Starting Pretend plugin for RedMine' +-else +- RAILS_DEFAULT_LOGGER.info 'Starting Pretend plugin for RedMine' +-end ++Rails.logger.info 'Starting Pretend plugin for RedMine' + + Redmine::Plugin.register :redmine_pretend do + name 'Redmine Pretend plugin' + author 'Leonid Batizhevsky' + description 'Plugin to pretend selected user' +- version '0.0.3' ++ version '2.0.0' + url 'https://github.com/leonko/redmine_pretend' + +- requires_redmine :versio
Bug#864084: unblock: zabbix/1:3.0.7+dfsg-3
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Affects: -1 zabbix
X-Debbugs-CC: j...@debian.org
Please unblock zabbix/1:3.0.7+dfsg-3
I would like to accommodate two attached diffs to Stretch please.
One fixes defunctional UI (broken by incompatible libjs-jquery) and
another fixes two security vulnerabilities as per #863584.
Thanks.
--
All the best,
Dmitry Smirnov.
signature.asc
Description: This is a digitally signed message part.
diff --git a/debian/changelog b/debian/changelog
index d570c6d..755bc59 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+zabbix (1:3.0.7+dfsg-2) unstable; urgency=medium
+
+ * Frontend-PHP: switch to private jQuery (Closes: #857287).
+
+ -- Dmitry Smirnov <only...@debian.org> Sun, 21 May 2017 13:56:56 +1000
+
zabbix (1:3.0.7+dfsg-1) unstable; urgency=medium
* New upstream release [December 2016].
diff --git a/debian/control b/debian/control
index d989f84..c0f275f 100644
--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,7 @@ Build-Depends: debhelper (>= 9), automake, dh-autoreconf, dh-systemd (>= 1.5), d
## dh-linktree:
,libjs-prototype
,libjs-jquery-ui (>= 1.10.1)
-,libjs-jquery (>= 1.10.1)
+# ,libjs-jquery (>= 1.10.1)
## java-gateway deps:
,javahelper
Build-Depends-Indep: default-jdk
diff --git a/debian/zabbix-frontend-php.linktrees b/debian/zabbix-frontend-php.linktrees
index 7308d0c..9dc6cc8 100644
--- a/debian/zabbix-frontend-php.linktrees
+++ b/debian/zabbix-frontend-php.linktrees
@@ -4,5 +4,5 @@ replace /usr/share/javascript/prototype/prototype.js /usr/share/zabbix/js/vend
## libjs-jquery-ui (1.10.1 vs 1.10.3)
replace /usr/share/javascript/jquery-ui/jquery-ui.js /usr/share/zabbix/js/vendors/jquery-ui.js
-## libjs-jquery (1.11.3 vs 1.10.2)
-replace /usr/share/javascript/jquery/jquery.js /usr/share/zabbix/js/vendors/jquery.js
+## libjs-jquery (3.1.1 vs 1.10.2)
+#replace /usr/share/javascript/jquery/jquery.js /usr/share/zabbix/js/vendors/jquery.js
diff --git a/debian/changelog b/debian/changelog
index 755bc59..d1c4c64 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+zabbix (1:3.0.7+dfsg-3) unstable; urgency=high
+
+ * CVE-2017-2824, CVE-2017-2825: new upstream patches
+"ZBX-12075_r67082.patch", "ZBX-12075_r67270.patch" (Closes: #863584).
+
+ -- Dmitry Smirnov <only...@debian.org> Sun, 04 Jun 2017 17:14:06 +1000
+
zabbix (1:3.0.7+dfsg-2) unstable; urgency=medium
* Frontend-PHP: switch to private jQuery (Closes: #857287).
diff --git a/debian/patches/ZBX-12075_r67082.patch b/debian/patches/ZBX-12075_r67082.patch
new file mode 100644
index 000..59bf622
--- /dev/null
+++ b/debian/patches/ZBX-12075_r67082.patch
@@ -0,0 +1,44 @@
+Bug-Upstream: https://support.zabbix.com/browse/ZBX-12075
+From 089f0d90b3d94c577263e8bdfe08ce3f33f9e178 Mon Sep 17 00:00:00 2001
+Origin: upstream
+Date: Wed, 5 Apr 2017 15:31:59 +
+Subject: [DEV-567] added validation of discovered host IP addresses
+
+--- a/src/libs/zbxcommon/misc.c
b/src/libs/zbxcommon/misc.c
+@@ -1872,17 +1872,9 @@
+ **
+ **/
+ int is_ip(const char *ip)
+ {
+- zabbix_log(LOG_LEVEL_DEBUG, "In is_ip() ip:'%s'", ip);
+-
+- if (SUCCEED == is_ip4(ip))
+- return SUCCEED;
+-#if defined(HAVE_IPV6)
+- if (SUCCEED == is_ip6(ip))
+- return SUCCEED;
+-#endif
+- return FAIL;
++ return SUCCEED == is_ip4(ip) ? SUCCEED : is_ip6(ip);
+ }
+
+ /**
+ **
+--- a/src/libs/zbxdbhigh/proxy.c
b/src/libs/zbxdbhigh/proxy.c
+@@ -2561,8 +2561,14 @@
+
+ if (FAIL == zbx_json_value_by_name(_row, ZBX_PROTO_TAG_IP, ip, sizeof(ip)))
+ goto json_parse_error;
+
++ if (SUCCEED != is_ip(ip))
++ {
++ zabbix_log(LOG_LEVEL_DEBUG, "\"%s\" is not a valid IP address", ip);
++ goto next;
++ }
++
+ if (SUCCEED == zbx_json_value_by_name(_row, ZBX_PROTO_TAG_PORT, tmp, sizeof(tmp)))
+ port = atoi(tmp);
+
+ zbx_json_value_by_name(_row, ZBX_PROTO_TAG_KEY, key_, sizeof(key_));
diff --git a/debian/patches/ZBX-12075_r67270.patch b/debian/patches/ZBX-12075_r67270.patch
new file mode 100644
index 000..10a403c
--- /dev/null
+++ b/debian/patches/ZBX-12075_r67270.patch
@@ -0,0 +1,93 @@
+Bug-Upstream: https://support.zabbix.com/browse/ZBX-12075
+From 17a159950db846a1c6365027c647b25a4bb02b94 Mon Sep 17 00:00:00 2001
+Origin: upstream
+Date: Wed, 12 Apr 2017 06:17:40 +
+Subject: [DEV-567] resurrected old IP check function to check SourceIP config file parameter taking into account IPv6 support enabled/disabled at compile time
+
+--- a/include/common.h
b/include/common.h
+@@ -981,8 +981,9 @@
+ #i
Bug#858224: unblock: lizardfs/3.10.4+dfsg-4
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Affects: -1 lizardfs
Please unblock lizardfs/3.10.4+dfsg-4
This upload fixes serious run-time regression preventing master node from
synchronising with other nodes and/or loading metadata after upgrade.
It is crucial to include this fix in order to avoid upgrade problems.
Thank you.
--
Cheers,
Dmitry Smirnov
GPG key : 4096R/52B6BBD953968D1B
diff --git a/debian/changelog b/debian/changelog
index 22ea9ae..eb8e428 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+lizardfs (3.10.4+dfsg-4) unstable; urgency=high
+
+ * New backported "526_gcc6.2.patch" to fix serious run-time regression.
+
+ -- Dmitry Smirnov <only...@debian.org> Sat, 11 Mar 2017 14:35:50 +1100
+
lizardfs (3.10.4+dfsg-3) unstable; urgency=medium
* Build-Depends: libgtest-dev --> googletest (Closes: #844893).
diff --git a/debian/patches/526_gcc6.2.patch b/debian/patches/526_gcc6.2.patch
new file mode 100644
index 000..7b0b7d0
--- /dev/null
+++ b/debian/patches/526_gcc6.2.patch
@@ -0,0 +1,54 @@
+Last-Update: 2017-03-11
+Forwarded: not-needed
+Bug-Upstream: https://github.com/lizardfs/lizardfs/issues/526
+Origin: upstream, https://github.com/lizardfs/lizardfs/commit/422175eb1aa8c2a1e4d0727ee3fe8190e1ae1340
+From: Hazeman <haze...@skytechnology.pl>
+Date: Mon, 6 Mar 2017 13:57:16 +0100
+Description: common: Fix aliasing issue in compact_vector
+ This commit fixes pointer/data storage aliasing issue that occurs in gcc 6.2.
+
+ Change-Id: I39307532f168eabfc1b39b81e6c1fbb8eb1b3fce
+
+--- a/src/common/compact_vector.h
b/src/common/compact_vector.h
+@@ -162,10 +162,10 @@
+ }
+
+ private:
+ union {
+- pointer ptr_;
+- uint8_t data_[sizeof(pointer)];
++ volatile pointer ptr_;
++ uint8_t data_[sizeof(pointer)];
+ };
+ size_type size_;
+ };
+
+@@ -278,10 +278,10 @@
+ }
+
+ private:
+ union {
+- uint64_t ptr_;
+- uint8_t data_[8];
++ volatile uint64_t ptr_;
++ uint8_t data_[8];
+ };
+ #if !defined(NDEBUG) || defined(LIZARDFS_TEST_POINTER_OBFUSCATION)
+ pointer debug_ptr_;
+ #endif
+--- a/src/common/compact_vector_unittest.cc
b/src/common/compact_vector_unittest.cc
+@@ -179,4 +179,12 @@
+
+ vec1.assign(6, 1);
+ EXPECT_NE(vec1.data(), (uint8_t *));
+ }
++
++TEST(CompactVectorTest, GCC6) {
++ compact_vector sessionid;
++ uint32_t val = 1978;
++
++ sessionid.push_back(val);
++ EXPECT_EQ(sessionid[0], val);
++}
diff --git a/debian/patches/series b/debian/patches/series
index 5d1ed75..bcb035e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,4 +1,5 @@
2749_69686d59.diff
+526_gcc6.2.patch
#build-hurd.patch
conf-add-mfshdd-comment.patch
conf-default-ignoregid.patch
signature.asc
Description: This is a digitally signed message part.
Re: final decision about MySQL r-deps needed / cleaning up the MySQL mess
On Monday, 17 October 2016 3:33:29 PM AEDT Rene Engelhard wrote: > - mysql-connector-c++s upstream is Oracle, so they obviously do not care >about MariaDB and (can) just require MySQL > - mysql-workbench (also Oracle I think) in newer versions apparently needs > mysql-connector-c++ >= 1.1.7 > - mysql-connector-c++ starting from 1.1.5 (IIRC) needs MySQL >= 5.6 to > build (and doesn't build with MariaDB) and mysql-connector-c++ 1.1.7 needs > even MySQL >= 5.7 Sadly it is true that Oracle couldn't care less about mysql-workbench compatibility with anything but MySQL 5.7... New versions of mysql-workbench FTBFS with mysql-5.6 and with mariadb. mysql-workbench is stuck at v6.3.4 because upstream refuses to recognise/resolve FTBFS in newer versions that upstream build against MySQL 5.7. >(Interestingly, the mysql-workbench "maintainer" didn't do *any* action > or offer to help to fix https://bugs.debian.org/836731, which is why sid > is stuck with 1.1.3) * mysql-workbench maintainer is not even mentioned in #836731 let alone he is not a maintainer of "mysql-connector-c++"... * #836731 was silently merged with related #835185 at which mysql-workbench maintainer looked but unfortunately couldn't find anything with his limited knowledge of C++. He then tagged bug #835185 "help". * mysql-workbench maintainer have no shortage of excuses for his inactivity: among other issues that affect his performance there are new job, illness (from which he did not recover yet) and sudden death of a family member in an accident... * mysql-workbench maintainer is unable to deal with complex C++ issues on his own and upstream is not helpful (or at least ignores comments about compatibility raised in their bug tracker). mysql-workbench maintainer wishes he could be more useful but there is only little he can do... :( -- Best wishes, Dmitry Smirnov. --- Criticism may not be agreeable, but it is necessary. It fulfils the same function as pain in the human body. It calls attention to an unhealthy state of things. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
Re: final decision about MySQL r-deps needed / cleaning up the MySQL mess
Hi Rene, On Monday, 17 October 2016 9:01:24 PM AEDT Rene Engelhard wrote: > This means I'll orphan mysql-connector-c++ (well, remove myself from > Uploaders:, which makes it having no Uploader at all). Dmitry, if you > want/need it for mysql-connector-c++ feel free to add yourself and upload > 1.1.7 to whatever you want and it actually works. (Eventually) I'll see what I can do but at the moment I have no capacity to take care of mysql-connector-c++... Is there a public repository for its packaging anywhere? Newer versions of MySQL Workbench FTBFS with mysql-connector-c++ in "experimental" but that's upstream problem which I'm unable to fix... Thanks for looking after mysql-connector-c++ all those years. -- All the best, Dmitry Smirnov. --- Good luck happens when preparedness meets opportunity. signature.asc Description: This is a digitally signed message part.
Bug#835170: transition: protobuf
On Wednesday, 24 August 2016 6:08:00 AM AEST Niels Thykier wrote: > Please review https://wiki.debian.org/Teams/ReleaseTeam/Transitions for > the next transition. Most of the preparation can be done in your own > cadence and you can request the slot in parallel with the final > preparation on your side. Duly noted. Thanks for this information, Niels. -- Cheers, Dmitry Smirnov. --- Perhaps is is better to be irresponsible and right, than to be responsible and wrong. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
Bug#835170: [Pkg-protobuf-devel] Bug#835170: transition: protobuf
On Wednesday, 24 August 2016 1:28:32 AM AEST Sebastiaan Couwenberg wrote: > On 08/23/16 16:45, Dmitry Smirnov wrote: > > On Tuesday, 23 August 2016 11:32:10 AM AEST Sebastiaan Couwenberg wrote: > >> protobuf (3.0.0-1) FTBFS pretty much everywhere. :-( > >> > >> Using -Werror may be a bit much based on the buildlogs. > > > > I think it may not be the problem in this particular case... > > I disagree. A patch is for this issue (reported by Aaron M. Ucko in > #835266) is available. Adding -Wno-error=misleading-indentation whenever > -Werror is used solves the FTBFS in my i386 sid chroot. Thank you very much for patch. I will upload it shortly. Unfortunately I'm still unable to reproduce FTBFS in clean pbuilder environment... -- Regards, Dmitry Smirnov. --- Belief means not wanting to know what is true. -- Friedrich Nietzsche signature.asc Description: This is a digitally signed message part.
Bug#835170: transition: protobuf
On Tuesday, 23 August 2016 8:51:23 PM AEST Adam D. Barratt wrote: > That's not an excuse for causing disruption in unstable. I'm not sure when it is OK to cause disruption in unstable. For example uploading new GCC seems to cause a lot of problems despite attempts to mitigate FTBFS. Also do you have a clue why protobuf FTBFS on build servers? I'm unable to reproduce the problem... > There are other > packages that need transitions that I'm sure the maintainers also > believe are "crucial". Indeed. Yet protobuf-3 is long overdue and we absolutely must have it as its absence caused a lot of disruption on its own... Apologies for inconvenience. -- Regards, Dmitry Smirnov. --- The surest way to corrupt a youth is to instruct him to hold in higher esteem those who think alike than those who think differently. -- Friedrich Nietzsche signature.asc Description: This is a digitally signed message part.
Bug#835170: transition: protobuf
On Tuesday, 23 August 2016 11:32:10 AM AEST Sebastiaan Couwenberg wrote: > > Dmitry, have you tested the reverse dependencies if they still build? No... We will have to deal with fallout, if any... It is crucial to have protobuf-3 from life cycle prospective. Also several golang dependencies require protobuf v3 so upload actually allows to fix numerous problems. Apologies for inconvenience... > First the many build failures need to be resolved: > > https://buildd.debian.org/status/package.php?p=protobuf I've noticed that but I'm unable to reproduce neither on amd64 not on i386. Even now when GCC 6.2 propagated to my local mirror... I'm completely puzzled by those build failures after spending hours trying to reproduce the problem... > protobuf (3.0.0-1) FTBFS pretty much everywhere. :-( > > Using -Werror may be a bit much based on the buildlogs. I think it may not be the problem in this particular case... Thank you. -- Regards, Dmitry Smirnov. --- Faith: not wanting to know what the truth is. -- Friedrich Nietzsche signature.asc Description: This is a digitally signed message part.
Bug#826443: jessie-pu: package zabbix/1:2.2.7+dfsg-2+deb8u1
Package: release.debian.org Severity: normal Tags: jessie User: release.debian@packages.debian.org Usertags: pu Control: affects -1 zabbix Dear release team, I'd like to upload fix for CVE-2016-4338 / ZBX-10741: mysql.size shell command injection in zabbix-agent (Closes: #823329). Diff is attached, please advise if upload is authorised. Thanks. -- Best wishes, Dmitry Smirnov. --- Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so. -- Mahatma Gandhi signature.asc Description: This is a digitally signed message part. >From 2ffd39e5afbee52833e911f869df975a904b48f1 Mon Sep 17 00:00:00 2001 From: Dmitry Smirnov <only...@member.fsf.org> Date: Sat, 28 May 2016 17:35:08 +1000 Subject: [PATCH] Upstream patch to fix CVE-2016-4338: mysql.size shell command injection in zabbix-agent --- debian/changelog | 7 +++ debian/patches/ZBX-10741.patch | 21 + debian/patches/series | 1 + 3 files changed, 29 insertions(+) create mode 100644 debian/patches/ZBX-10741.patch diff --git a/debian/changelog b/debian/changelog index b5d9188..9e6a32c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +zabbix (1:2.2.7+dfsg-2+deb8u1) stable; urgency=medium + + * CVE-2016-4338 / ZBX-10741: fixed mysql.size shell command injection +in zabbix-agent (Closes: #823329). + + -- Dmitry Smirnov <only...@debian.org> Sat, 28 May 2016 17:04:31 +1000 + zabbix (1:2.2.7+dfsg-2) unstable; urgency=high * CVE-2014-9450 (ZBX-8582) fixed SQL injection vulnerability diff --git a/debian/patches/ZBX-10741.patch b/debian/patches/ZBX-10741.patch new file mode 100644 index 000..19b6716 --- /dev/null +++ b/debian/patches/ZBX-10741.patch @@ -0,0 +1,21 @@ +Last-Update: 2016-05-09 +Forwarded: not-needed +Origin: upstream, svn://svn.zabbix.com/branches/2.2@59942 +Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823329 +Bug-Zabbix: https://support.zabbix.com/browse/ZBX-10741 +Description: CVE-2016-4338 fix zabbix-agent/mysql.size shell command injection + enforced bash usage in mysql.size user parameter configuration script to + avoid issues with different default shells + +--- a/conf/zabbix_agentd/userparameter_mysql.conf b/conf/zabbix_agentd/userparameter_mysql.conf +@@ -11,8 +11,8 @@ + # Type may be "data", "index", "free" or "both". Both is a sum of data and index. Default is "both". + # Database is mandatory if a table is specified. Type may be specified always. + # Returns value in bytes. + # 'sum' on data_length or index_length alone needed when we are getting this information for whole database instead of a single table +-UserParameter=mysql.size[*],echo "select sum($(case "$3" in both|"") echo "data_length+index_length";; data|index) echo "$3_length";; free) echo "data_free";; esac)) from information_schema.tables$([[ "$1" = "all" || ! "$1" ]] || echo " where table_schema='$1'")$([[ "$2" = "all" || ! "$2" ]] || echo "and table_name='$2'");" | HOME=/var/lib/zabbix mysql -N ++UserParameter=mysql.size[*],bash -c 'echo "select sum($(case "$3" in both|"") echo "data_length+index_length";; data|index) echo "$3_length";; free) echo "data_free";; esac)) from information_schema.tables$([[ "$1" = "all" || ! "$1" ]] || echo " where table_schema=\"$1\"")$([[ "$2" = "all" || ! "$2" ]] || echo "and table_name=\"$2\"");" | HOME=/var/lib/zabbix mysql -N' + + UserParameter=mysql.ping,HOME=/var/lib/zabbix mysqladmin ping | grep -c alive + UserParameter=mysql.version,mysql -V diff --git a/debian/patches/series b/debian/patches/series index 0e81f68..d296cba 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,4 @@ +ZBX-10741.patch ZBX-8582.patch config_debianisation.patch config_frontend-conffile-in-etc.patch -- 2.8.1
Re: Bug#814589: otrs2: source-less files; undocumented copyrights/licenses; abuse of lintian-overrides; systematic DFSG violations
Dear Patrick, On Wed, 2 Mar 2016 12:36:46 PM Patrick Matthäi wrote: > Am 15.02.2016 um 14:14 schrieb Dmitry Smirnov: > > And this is why I provided some hints how you can address those problems > > in my bug report. This is why I wrote to you after when I stabilised > > "ckeditor" so you could use it. > > I can use it, until ckeditor OR otrs upstreams broke it again, like with > jquery. Thank you for checking. I think using bundled ckeditor is not an option because it is source-less and shipped as minified blobs. jQuery is a lot easier to handle because it is just one file. > Also it would prevent backports of otrs to jessie. I'm already working on that. "ckbuilder" is in backports/NEW and once accepted I'll upload "ckeditor" (which I need in backports for one of my packages as well). > >> and mostly it is not possible to replace the > >> libjs thirdparty foo with the packages from Debian, mostly because of > >> version missmatches. As I've said, you don't have to replace all bundled JS libraries with system ones as it might make package needlessly fragile and difficult to backport. What you have to do is to find original/uncompressed JS files and ship them in "debian/missing-sources" ideally replacing minified files as well. It is easy to do and safe and it will help your package to comply with DFSG requirements. > You reported a very general bug about the whole javascript mess. > Replacing ckeditor will not solve the other problems or all those > minified files and so on. You have to start somewhere don't you? I'm not even Otrs2 user (let alone maintainer) so why do expect more from me? > Investing work in removing those files will not realy help and just > burden the whole packaging and eat time to fix realy serious issues - > like embedded libs. I think DFSG compliance is not optional in Debian. Shipping missing sources in "debian/missing-sources" shouldn't take too much effort... Did you consider this option? -- Regards, Dmitry Smirnov. --- Odious ideas are not entitled to hide from criticism behind the human shield of their believers' feelings. -- Richard Stallman signature.asc Description: This is a digitally signed message part.
Bug#781569: RM: gfarm(2fs) -- RoM; outdated (too old for stable), probably unsupported upstream
Package: release.debian.org Severity: wishlist User: release.debian@packages.debian.org Usertags: rm Dear release team, Please consider removing the following packages from testing: gfarm gfarm2fs gfarm and gfarm2fs packages were last updated early 2011 (plus NMU in early 2012). Current version of Gfarm in Jessie (2.4) is too old and doesn't have data integrity features that were introduced in version 2.6. Seemingly upstream do not support 2.4 any more (I've seen only references to VCS updates to 2.5 and 2.6). Gfarm 2.6 is a very good distributed parallel storage system. IMHO at the moment (until LizardFS will be accepted from NEW) Gfarm is the best such system in Debian -- certainly better and more reliable than Ceph (I wish I knew that earlier so I wouldn't spend so much time fixing Ceph)... Unfortunately Gfarm is still little known: current popcon score is only 18 for gfarm and 8 for gfarm2fs (I'm pretty sure my servers account for at least quarter of this score). IMHO it will be unfortunate if someone would try outdated Gfarm from Jessie and I doubt that 2.4 would be responsible for popcon growth. Besides I've never used version 2.4 and have no intention to use or to support it. Therefore I recommend to remove outdated gfarm and gfarm2fs packages from testing. Thanks. -- Regards, Dmitry Smirnov GPG key : 4096R/53968D1B --- In questions of science, the authority of a thousand is not worth the humble reasoning of a single individual. -- Galileo Galilei signature.asc Description: This is a digitally signed message part.
Bug#781569: RM: gfarm(2fs) -- RoM; outdated (too old for stable), probably unsupported upstream
On Tue, 31 Mar 2015 07:37:24 Adam D. Barratt wrote: gfarm maintainer - any comment on the below? I am the (only) maintainer, see #715446. Earlier this year I've discovered Gfarm and took over its maintenance. At the moment all new uploads (v2.6) are contained in experimental as per freeze policy: https://tracker.debian.org/media/packages/g/gfarm/changelog-2.6.2%2Bdfsg-1 https://tracker.debian.org/media/packages/g/gfarm2fs/changelog-1.2.9.7-3 -- Cheers, Dmitry Smirnov. --- Success consists of going from failure to failure without loss of enthusiasm. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
Bug#781569: RM: gfarm(2fs) -- RoM; outdated (too old for stable), probably unsupported upstream
On Tue, 31 Mar 2015 07:53:44 Adam D. Barratt wrote: Ah, I see, sorry - that wasn't particularly clear from the fact that you suggested removing the packages, at least in my part-way-through-first-coffee state. (Not helped by the fact that the maintainer in unstable and thus displayed by dak rm isn't you, for the reasons you explained above). Removal hints added. Thanks. :) -- Regards, Dmitry Smirnov. --- Good luck happens when preparedness meets opportunity. signature.asc Description: This is a digitally signed message part.
Bug#770414: unblock: gtk+3.0/3.14.5-1
On Thu, 20 Nov 2014 22:38:23 Matthew Horan wrote: A gtk+3.0 version recently uploaded to unstable fixes one important bug: A new version already? I hope it's not going to break KDE GTK-3 themes as almost every new release of gtk+3.0 does... :( It is particularly challenging to backport an isolated fix for this issue? -- Best wishes, Dmitry Smirnov GPG key : 4096R/53968D1B --- All that is necessary for the triumph of evil is that good men do nothing. signature.asc Description: This is a digitally signed message part.
Bug#769849: unblock: redmine-plugin-pretend/0.0.2+git20130821-2
Dear Niels, On Mon, 17 Nov 2014 07:36:45 Niels Thykier wrote: Unblocked, thanks. Thank you very much but I have to ask you to consider extending your unblock to redmine-plugin-pretend/0.0.2+git20130821-3 I'm terribly sorry for making last minute changes but after discussion with upstream I felt that it is necessary to update patch as it were committed upstream. Upstream prefers to change GET method to POST due to security reasons hence I've uploaded 0.0.2+git20130821-3 with the only change to patch which is now matches upstream commit exactly: http://anonscm.debian.org/cgit/collab-maint/redmine-plugin-pretend.git/commit/?id=53292f87bcffe22dd20f86fa7b5e8367c69f3d39 Once again let me apologise for troubles and bad timing. Thank you. -- Best wishes, Dmitry Smirnov. --- For every complex problem there is an answer that is clear, simple, and wrong. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#769849: unblock: redmine-plugin-pretend/0.0.2+git20130821-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock redmine-plugin-pretend/0.0.2+git20130821-2 Please unblock the above package. It contains an essential Redmine compatibility adaptation which is necessary to avoid the following error on start or upgrade of Redmine: An error occurred while loading the routes definition of redmine_pretend plugin (/usr/share/redmine/plugins/redmine_pretend/config/routes.rb): You should not use the `match` method in your router without specifying an HTTP method. If you want to expose your action to both GET and POST, add `via: [:get, :post]` option. If you want to expose your action to GET, use `get` in the router: Instead of: match controller#action Do: get controller#action. Error when running rake db:migrate, check database configuration. Patch is trivial and only changes match to get in config/routes.rb: --- a/config/routes.rb +++ b/config/routes.rb @@ -1,8 +1,8 @@ if Rails::VERSION::MAJOR = 3 RedmineApp::Application.routes.draw do - match 'admin/pretend_to/:id' = 'application#pretend_to', :as = 'pretend_to' - match 'admin/unpretend' = 'application#unpretend', :as = 'unpretend' + get 'admin/pretend_to/:id' = 'application#pretend_to', :as = 'pretend_to' + get 'admin/unpretend' = 'application#unpretend', :as = 'unpretend' end else ActionController::Routing::Routes.draw do |map| map.pretend_to 'admin/pretend_to/:id', :controller = 'application', :action = 'pretend_to' See full list of changes in repository: http://anonscm.debian.org/cgit/collab-maint/redmine-plugin-pretend.git/log/ Thank you. -- All the best, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#767190: unblock: oxygen-gtk3/1.4.1-1
FYI #762337 is why unblock was necessary. signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
Hi Ivo, Julien, On Sat, 1 Nov 2014 12:33:51 Ivo De Decker wrote: This is a bug in the auto-removal system. I expect mariadb-5.5 to be removed before 2014-12-01, solving the issue in this case, but if you get the second notification about this auto-removal, please ping this bug, and I'll prevent the auto-removal manually. I found that mysql-workbench actually do not require mysql client therefore I've decided to demote virtual-mysql-client to Recommends and also (after discussion with Julien) to add mysql-client as first alternative as follows: mysql-client | virtual-mysql-client The updated mysql-workbench/6.2.3+dfsg-7 is in unstable so you may consider to unblock it if you think it may serve as easier solution to the AUTORM problem. Thank you. -- Best wishes, Dmitry Smirnov. --- It is impossible to imagine Goethe or Beethoven being good at billiards or golf. -- H. L. Mencken signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
On Mon, 3 Nov 2014 13:36:48 Julien Cristau wrote: mariadb-5.5 is already removed so I don't think the autorm is an issue anymore, but in any case that change is an improvement IMO so I've just unblocked 6.2.3+dfsg-7. Thanks! That is awesome, Julien, thank you very much. :) -- All the best, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org I just got the following notice mysql-workbench 6.2.3+dfsg-6 is marked for autoremoval from testing on 2014-12-01 It (build-)depends on packages with these RC bugs: 765664: mariadb-5.5: Multiple security fixes from October 2014 CPU could affect MariaDB which makes me worry whether mysql-workbench will be part of Jessie. Mysql-workbench depends on virtual-mysql-client provided by * mariadb-client-10.0 * mariadb-client-5.5 * mysql-client-5.5 * mysql-client-5.6 * percona-xtradb-cluster-client-5.5 I think it is a bit harsh to remove mysql-workbench from testing (merely) due to problems in one of the alternatives providing client for MySQL connectivity. Besides client package is probably not even affected by the security issues... What can we do to avoid auto-removal of mysql-workbench from Jessie? Please advise. -- Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- It is a fine thing to be honest, but it is also very important to be right. -- Winston Churchill signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
On Sat, 1 Nov 2014 19:12:15 Julien Cristau wrote: A dependency on a virtual package with multiple providers and no real alternative is a serious bug in mysql-workbench. Please make the dependency mysql-client | virtual-mysql-client. What makes you think it is a serious bug? It would be serious in case of Build-Depends on virtual package without alternative but mysql-workbench (binary package) Depends on just virtual-mysql-client because there is no preference regarding which client package to use at run time... I've realised that virtual-mysql-client can be demoted to Recommends -- please advise if that change warrants an unblock in which case I will upload to unstable. Thank you. -- All the best, Dmitry Smirnov. --- Believing is easier than thinking. Hence so many more believers than thinkers. -- Bruce Calvert signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
On Sat, 1 Nov 2014 20:49:39 Julien Cristau wrote: There *has* to be a preference (preferrably a common one across the archive). Otherwise the package manager gets to choose a random provider, which is the worst possible outcome. I do not understand why there has to be a preference. I understand behaviour of package manager and I've deliberately chosen not to have a preference. I do not see any benefits of having prefered client package in this case. Why do you insist that virtual-only dependency is wrong? It is hardly a worst possible outcome when all alternatives are equally suitable. I've realised that virtual-mysql-client can be demoted to Recommends -- please advise if that change warrants an unblock in which case I will upload to unstable. Thank you. Not if it stays virtual-only. Would you be satisfied if I add an alternative as follows? virtual-mysql-client | mysql-client Thanks. -- All the best, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#767587: please prevent auto-removal of mysql-workbench from testing
On Sat, 1 Nov 2014 21:08:56 Julien Cristau wrote: It is hardly a worst possible outcome when all alternatives are equally suitable. But they're clearly not. Let's distinguish generic statement from the particular case please. From mysql-workbench prospective there might be no difference in which client package to use. Let's consider hypothetical example: M-W uses `mysql` command line client only to check DB connectivity (in fact it is not how M-W really checks connectivity). All packages providing virtual-mysql-client have `mysql` executable taking exactly the same command line options and capable to connect to any server. Why prefer a particular client? Here you're failing to answer my questions... The default mysql client is the mysql-client package. Why do you insist that it isn't? I've never claimed otherwise. I merely see little reason to prefer default client. But I would agree if you'd say that it would be a good idea to recommend mysql-client as first alternative archive-wide to ensure that it is always a default client. However it would hardly explain why you consider lack of such alternative as serious bug. I've realised that virtual-mysql-client can be demoted to Recommends -- please advise if that change warrants an unblock in which case I will upload to unstable. Thank you. Not if it stays virtual-only. C'mon, why does it matter in Recommends as much as you say it matters in Depends? I'm OK to upload M-W to unstable with Recommends: mysql-client | virtual-mysql-client instead of Depends: virtual-mysql-client I'm willing to comply because you insist, not because I'm convinced. IMHO this issue is not worth arguing and I recognise (however little) benefit from defaulting to default mysql-client client even if it makes no functional difference for recommending package. If you believe it's better -- that is enough for me. Please advise if I shall proceed with upload. Thanks. -- Cheers, Dmitry Smirnov. --- Science embraces facts and debates opinion; religion embraces opinion and debates the facts. -- Tom Heehler, The Well-Spoken Thesaurus. signature.asc Description: This is a digitally signed message part.
Bug#767191: unblock: zabbix/1:2.2.7+dfsg-1
On Thu, 30 Oct 2014 12:56:34 Jonathan Wiltshire wrote: Aged to 5 days. Awesome, thank you. :) -- Regards, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#767190: unblock: oxygen-gtk3/1.4.1-1
On Thu, 30 Oct 2014 21:43:01 Niels Thykier wrote: Thanks, I have added an unblock hint for oxygen-gtk3/1.4.1-1 (rather than ageing it). Much appreciated, thank you. -- Regards, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#767190: unblock: oxygen-gtk3/1.4.1-1
Hi Niels, On Wed, 29 Oct 2014 22:19:38 Niels Thykier wrote: Could you clarify what the improved compatibility with GTK involves/means? What we would gain from accepting the changes, what are the consequences of not accepting them? I'm not sure about the consequences but here is my (limited) understanding of situation: oxygen-gtk3 depends on gtk+3.0 which historically had little respect for backward compatibility so oxygen-gtk3 suffered from regressions with nearly every release of the gtk+3.0. You can get some insights into situation from the following URL: https://igurublog.wordpress.com/2012/11/05/gnome-et-al-rotting-in-threes/ New follow-up releases of oxygen-gtk3 typically fix regressions and improve compatibility with gtk+3.0. Although there were no regressions reported, our timing is not good and from past experience I'm beginning to feel uncomfortable knowing that last upload of oxygen-gtk3 was in July 2014 while new versions of gtk+3.0 were uploaded in August, September and October 2014. In the src/oxygenthemingengine.cpp of just released oxygen-gtk3 I see conditions like #if !GTK_CHECK_VERSION( 3, 13, 7 ) appeared to disable code block for current (and later) GTK so it is affecting code paths. There are also some other changes, see top 7 commits in upstream repository https://projects.kde.org/projects/playground/artwork/oxygen-gtk/repository/changes?rev=vgtk3-1.4.1 down to be5a6f98 2014-07-02 09:50am bumped revision (previous release 1.4.0). From past experience I can tell that such small changes are usually significant although I'm not always able to say exactly what is going to be affected. Overall I have a gut feeling that it might be important and given that there is still a little time left before freeze I hope that it's not too late to accommodate all fixes of 1.4.1. Looking through history of changes in upstream git I see that among others 1.4.1 fixes the following problem: * Bug 338538 - checkboxes are no more rendered since gtk+ 3.13.7 * https://bugs.kde.org/show_bug.cgi?id=338538 I vaguely recall that I may have seen this somewhere... IMHO it looks significant to warrant an unblock hence I've decided to trouble you with it... Thanks for considering and I hope it makes sense... -- Regards, Dmitry Smirnov. --- Free speech is the bedrock of liberty and a free society. And yes, it includes the right to blaspheme and offend. -- Ayaan Hirsi Ali, 2010 signature.asc Description: This is a digitally signed message part.
Bug#767190: unblock: oxygen-gtk3/1.4.1-1
Package: release.debian.org Severity: minor User: release.debian@packages.debian.org Usertags: unblock oxygen-gtk3/1.4.1-1 Please unblock the above package (or reduce unstable-to-testing migration delay to allow package propagation to testing before freeze). Upstream just released a minor update to oxygen-gtk3/1.4 without even bothering to describe the changes. However by comparing previous 1.4.0 to the current 1.4.1 release I see that updates are mostly focused on improving (much needed) compatibility with GTK. Since there is still some time before freeze I'd like to ask you to consider inclusion of oxygen-gtk3/1.4.1 to Jessie. Brief run-time testing revealed no (obvious) problems and I think that probability of regression is low. I shall be happy to provide debdiff if needed. Thank you. -- All the best, Dmitry Smirnov. --- The great enemy of the truth is very often not the lie -- deliberate, contrived and dishonest, but the myth, persistent, persuasive, and unrealistic. Belief in myths allows the comfort of opinion without the discomfort of thought. -- John F Kennedy signature.asc Description: This is a digitally signed message part.
Bug#767191: unblock: zabbix/1:2.2.7+dfsg-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock zabbix/1:2.2.7+dfsg-1 Please unblock the above package (or reduce unstable-to-testing migration delay to allow package propagation to testing before freeze). As per upstream Life Cycle Release Policy [1] Zabbix 2.2 is a long term support (LTS) release which just received its 7th update fixing over 30 issues. Point release LTS updates are conservative bugfix-only updates (see list of changes in [2]). As bugfix-only update I believe Zabbix_2.2.7 is eligible for Jessie and including latest point release 2.2.7 will provide strategic advantages for future updates. I estimate low risk of regression and recommend 2.2.7 for inclusion to Jessie. Thank you. [1]: http://www.zabbix.com/life_cycle_and_release_policy.php [2]: http://www.zabbix.com/rn2.2.7.php -- Best wishes, Dmitry Smirnov GPG key : 4096R/53968D1B --- Reality is that which, when you stop believing in it, doesn't go away. -- Philip K. Dick signature.asc Description: This is a digitally signed message part.
Bug#767192: unblock: xpra/0.14.10+dfsg-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock xpra/0.14.10+dfsg-1 Please unblock the above package (or reduce unstable-to-testing migration delay to allow package propagation to testing before freeze). Xpra-0.14.10 is a bug-fix update for long-term supported branch. Here is how upstream described the latest changes in the announce: This minor update fixes some important bugs, some of which can cause crashes or deadlocks. Upgrading is strongly recommended: * fix crash with JPEG encoding and OpenGL * fix deadlocks with sound on connection shutdown * fix server errors with clients supporting very limited encodings * fix compatibility with Fedora 21+ Xorg suid script * fix compatibility with some login shells (ie: tcsh) * fix warnings with NVENC and newer Nvidia driver versions * fix warning with newer versions of Python Pillow As conservative update fixing serious problems such as crash and deadlock I believe xpra/0.14.10+dfsg-1 is eligible for Jessie hence I recommend to include Xpra 0.14.10 to Jessie. IMHO it should be safe due to low probability of regression. Thank you. -- Best wishes, Dmitry Smirnov GPG key : 4096R/53968D1B --- The persistence of erroneous beliefs exacerbates the widespread anachronistic failure to recognize the urgent problems that face humanity on this planet. -- Murray Gell-Mann, Quark and the Jaguar signature.asc Description: This is a digitally signed message part.
Bug#740909: Bug#753503: opu: zabbix/1:1.8.2-1squeeze6
Hi Adam, Moritz, On Wed, 9 Jul 2014 20:13:46 Adam D. Barratt wrote: zabbix maintainers: ping? Sorry for delay. I completely support removal of Zabbix from Squeeze. Upstream was doing us a favour by providing some patches for old version of Zabbix. It will be a relief for them and for us to move on. I'm sure nobody wants to carry the burden of supporting Zabbix 1.8.2 longer than necessary. Please remove it from Squeeze. Thanks. -- All the best, Dmitry Smirnov. --- Believing is easier than thinking. Hence so many more believers than thinkers. -- Bruce Calvert signature.asc Description: This is a digitally signed message part.
Bug#725757: opu: zabbix/1:1.8.2-1squeeze5
On Sun, 13 Oct 2013 04:52:54 Adam D. Barratt wrote: Based on another review and your comments above, I'm going to cross my fingers, say please go ahead and hope everything turns out fine. Please bear in mind that the upload window for 6.0.8 closes this weekend. Adam, thank you for thorough review, feedback, trust and warm comments. :) I just uploaded the package and I also hope that everything goes well. Cheers, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201310131157.53397.only...@debian.org
Bug#726018: RM: bmon/1:2.1.1~pre1-1 -- RoM
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Dear release team, Please remove package bmon/1:2.1.1~pre1-1 from unstable (and testing). In new version 3.1 upstream introduced hard dependency on libnl so bmon no longer builds on kfreebsd-any and hurd hence it can't migrate to testing and replace older version. Besides bmon/1:2.1.1~pre1-1 has non-free file(s) and therefore unsuitable to stay in archive... Thank you. -- Cheers, Dmitry Smirnov. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201310111947.23321.only...@debian.org
Bug#725757: opu: zabbix/1:1.8.2-1squeeze5
On Fri, 11 Oct 2013 05:00:41 you wrote: For the record, that all comes to 8 files changed, 6906 insertions(+), 5 deletions(-), which is considerably more than I was expecting, given how close we are to the update window closing. A lot of it appears to be a (possibly over-cautious) belt and braces approach to * CVE-2013-5743: fixed SQL injection vulnerability. escaping basically every use of a string anywhere near an SQL statement. I do hope that someone's actually checked that none of those additions of zbx_dbstr() introduces any bugs; I certainly don't know what any of the variables might contain in order to judge. :-( Well, that's a heavy patch but it was specifically made by upstream developers for the very version of Zabbix that we have in Squeeze. I applied it as-is without any modifications. If you wish we can ask upstream for comments. In Squeeze I tested instance of Zabbix-1.8.2 with this patch applied and couldn't see any regressions. I doubt there is anything more I could possibly do to ensure the safety of this patch. There's also * CVE-2011-3263: prevent zabbix_agentd DoS attack with vfs.file.cksum. patches/ZBX-3794+ZBX-3830.patch | 540 +++ There's quite a lot of noise in that patch, of the general form ++int ret = SYSINFO_RET_FAIL; [...] +-if (num_param(param) 1) +-return SYSINFO_RET_FAIL; ++if (1 num_param(param)) ++goto err; [...] +-return SYSINFO_RET_OK; ++ret = SYSINFO_RET_OK; ++err: ++return ret; afaics, the net affect of that change is nothing. I realise (having let git-svn chew through the branch) that the noise is in upstream's original patch, but it really doesn't make it easy to review. Apologies if this patch is not perfect. This particular patch I backported long time ago and (unlike SQL injections that I find difficult to test) I verified that patch fixes DoS attack on vfs.file.cksum on Zabbix-1.8.2/Squeeze. I'm quite confident that it works as expected. I don't remember whether renaming of those variables were necessary to apply other patches... I built Zabbix packages using `qemubuilder` and tested 'em in dedicated Squeeze VM. Adam, please advise if you feel more confident with uploading just patch for SQL injection and leaving all other changes behind. -- Best wishes, Dmitry Smirnov. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201310111316.11689.only...@debian.org
Bug#711336: pu: package gitg/0.2.4-1.1+deb7u1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: pu Dear release team, Due to defective patch to replace deprecated gdk_window_get_pointer in `gitg` the latter started to crash and lost most of its drag'n'drop functionality. Also it becomes very noisy on console during mouse movements: (gitg:26390): Gdk-CRITICAL **: gdk_window_get_device_position: assertion `GDK_IS_DEVICE (device)' failed Fortunately user provided corrected patch that fixed all the run time problems as far as I can see. With your permission I'd very much like to fix this mess in Wheezy. Please find attached .diff file with all the changes. Please advise if it is OK to upload. Thank you. Regards, Dmitry Smirnov GPG key : 4096R/53968D1B diff --git a/debian/changelog b/debian/changelog index 4eb9d50..b616917 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +gitg (0.2.4-1.1+deb7u1) stable; urgency=low + + * Replaced incorrect ftbfs patch to fix run-time crashes +and drag'n'drop functionality (Closes: #705886, #674001). + + -- Dmitry Smirnov only...@debian.org Thu, 06 Jun 2013 18:56:48 +1000 + gitg (0.2.4-1.1) unstable; urgency=low * Non-maintainer upload. diff --git a/debian/patches/ftbfs b/debian/patches/ftbfs deleted file mode 100644 index 340c578..000 --- a/debian/patches/ftbfs +++ /dev/null @@ -1,27 +0,0 @@ -Description: Replaced deprecated gdk_window_get_pointer API. -Author: Jiang Wu masterwuji...@gmail.com -Bug-Debian: http://bugs.debian.org/666232 -Last-Update: 2012-04-29 - gitg-0.2.4.orig/gitg/gitg-dnd.c -+++ gitg-0.2.4/gitg/gitg-dnd.c -@@ -513,7 +513,7 @@ vertical_autoscroll (GitgDndData *data) - gint offset; - gfloat value; - -- gdk_window_get_pointer (gtk_tree_view_get_bin_window (data-tree_view), NULL, y, NULL); -+ gdk_window_get_device_position (gtk_tree_view_get_bin_window (data-tree_view), GDK_SOURCE_MOUSE, NULL, y, NULL); - gtk_tree_view_convert_bin_window_to_tree_coords (data-tree_view, 0, y, NULL, y); - - gtk_tree_view_get_visible_rect (data-tree_view, visible_rect); gitg-0.2.4.orig/gitg/gitg-commit-view.c -+++ gitg-0.2.4/gitg/gitg-commit-view.c -@@ -967,7 +967,7 @@ get_info_at_pointer (GitgCommitView *vie - /* Get where the pointer really is. */ - GdkWindow *win = gtk_text_view_get_window (textview, GTK_TEXT_WINDOW_TEXT); - -- gdk_window_get_pointer (win, x, y, NULL); -+ gdk_window_get_device_position (win, GDK_SOURCE_MOUSE, x, y, NULL); - - width = gdk_window_get_width (win); - height = gdk_window_get_height (win); diff --git a/debian/patches/ftbfs.patch b/debian/patches/ftbfs.patch new file mode 100644 index 000..5a750a5 --- /dev/null +++ b/debian/patches/ftbfs.patch @@ -0,0 +1,39 @@ +Description: Replaced deprecated gdk_window_get_pointer API. +Author: Rodolfo rodolf...@gmail.com +Bug-Debian: http://bugs.debian.org/666232 +Bug-Debian: http://bugs.debian.org/705886 +Bug-Debian: http://bugs.debian.org/674001 +Last-Update: 2013-06-06 + +--- a/gitg/gitg-dnd.c b/gitg/gitg-dnd.c +@@ -512,9 +512,13 @@ + gint y; + gint offset; + gfloat value; + +- gdk_window_get_pointer (gtk_tree_view_get_bin_window (data-tree_view), NULL, y, NULL); ++ GdkWindow *win = gtk_tree_view_get_bin_window (data-tree_view); ++ GdkDeviceManager *device_manager = gdk_display_get_device_manager(gdk_window_get_display(win)); ++ GdkDevice *pointer = gdk_device_manager_get_client_pointer (device_manager); ++ gdk_window_get_device_position (win, pointer, NULL, y, NULL); ++ + gtk_tree_view_convert_bin_window_to_tree_coords (data-tree_view, 0, y, NULL, y); + + gtk_tree_view_get_visible_rect (data-tree_view, visible_rect); + +--- a/gitg/gitg-commit-view.c b/gitg/gitg-commit-view.c +@@ -966,9 +966,11 @@ + + /* Get where the pointer really is. */ + GdkWindow *win = gtk_text_view_get_window (textview, GTK_TEXT_WINDOW_TEXT); + +- gdk_window_get_pointer (win, x, y, NULL); ++ GdkDeviceManager *device_manager = gdk_display_get_device_manager(gdk_window_get_display(win)); ++ GdkDevice *pointer = gdk_device_manager_get_client_pointer (device_manager); ++ gdk_window_get_device_position (win, pointer, x, y, NULL); + + width = gdk_window_get_width (win); + height = gdk_window_get_height (win); + diff --git a/debian/patches/series b/debian/patches/series index 758d0b8..21bba92 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1,3 +1,3 @@ 0001-Change-Categories-to-Development-RevisionControl.patch 0002-libgitg-make-a-static-library.patch -ftbfs +ftbfs.patch signature.asc Description: This is a digitally signed message part.
Bug#711336: pu: package gitg/0.2.4-1.1+deb7u1
On Thu, 6 Jun 2013 22:16:46 Adam D. Barratt wrote: Please don't rename patches in a stable update; it makes the actual changes more difficult to spot and check. OK, I won't rename next time. I did it for consistency as all other patches are ending with .patch. I now understand that it made your review a bit more difficult, sorry. Other than that, please go ahead; thanks. Uploaded, thanks. :) Best wishes, Dmitry Smirnov. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201306062250.03909.only...@debian.org
Re: [Pkg-mozext-maintainers] Handling of HTTPS Everywhere updates
On Fri, 31 May 2013 12:33:29 Paul Wise wrote: I always wondered why the plugin was bundled with a snapshot of data that by definition is continuously changing. Would it not be better for the plugin to ship with a snapshot of data and then automatically update it as needed? Or push this out into DNS or something else. I'm with you Paul as indeed separating volatile data and the plugin code makes perfect sense. I doubt the importance of receiving frequent updates to https-everywhere. Surely I do not visit most of the eleven thousand web sites covered by its rules and for small subset of those web sites that I visit I'm not sure if I would welcome any sudden and unexpected changes introduced by update. There is a lovely https-everywhere companion plugin maintained by yours truly: https-finder. It probes any web site for HTTPS and allows one to easily create a rule for https-everywhere. So I can control whenever I want HTTPS by default on the sites that I visit often and for other web sites there is an automatic HTTPS detection which IMHO makes frequent updates to https-everywhere not that important as long as the latter is accompanied by https-finder. Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- I do not fear death, in view of the fact that I had been dead for billions and billions of years before I was born, and had not suffered the slightest inconvenience from it. -- Mark Twain signature.asc Description: This is a digitally signed message part.
Bug#711281: RM: scummvm(-data)[hurd,kfreebsd]@testing
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Please remove package scummvm from testing but only on hurd and kfreebsd-* architectures. The story is this: new version of scummvm FTBFS on those arches, I contacted upstream [1] and they replied that they've fixed incorrect fallback in `configure` which was producing unusable executables on unsupported architectures. I got access to kfreebsd-i386 and hurd-i386 and verified that `scummvm` is just crashing there with following error: scummvm: common/system.cpp:130: virtual FilesystemFactory* OSystem::getFilesystemFactory(): Assertion `_fsFactory' failed. So removing is necessary to get rig of invalid executables and let new version to migrate to testing. Thank you. [1]: https://sourceforge.net/tracker/?func=detailatid=418820aid=3614268group_id=37116 (ownerless is my ID on sourceforge). Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B signature.asc Description: This is a digitally signed message part.
Bug#709942: RM: gir1.2-libgsf-1
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: rm Please remove package gir1.2-libgsf-1 from testing. As per #695599 this package was renamed in unstable: gir1.2-libgsf-1 -- gir1.2-gsf-1 but libgsf can't migrate to testing because of (missing 1 binary: gir1.2-libgsf-1) What's the best practice to handle such situation? Please advise if libgsf migration can be ensured without removal of gir1.2-libgsf-1. Thank you. Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201305270833.21281.only...@debian.org
Bug#698997: unblock: italc/1:1.0.13-1.4
On Mon, 28 Jan 2013 03:27:00 Adam D. Barratt wrote: On Sat, 2013-01-26 at 22:49 +1100, Dmitry Smirnov wrote: In other words I'm removing failure point: unnecessary check for library in wrong location. Simply removing the error message is enough to fix the problem. I hope it makes sense. Well, yes, but it would have been better to fix the test to properly detect the libraries in the face of multi-arch, imho. Why? Linker looks for library in more than one location. If linker can't find library it'll FTBFS with better error message than the erroneous check produces. Therefore the test is completely redundant. From maintainability point of view because the check is redundant it's better to drop it completely and reduce maintenance burden. However, on the basis that it does appear to resolve the issue in this case; unblocked. Thank you. :) -- Best wishes, Dmitry Smirnov GPG key : 4096R/53968D1B --- The man who does not do his own thinking is a slave, and is a traitor to himself and to his fellow-men. -- Robert G. Ingersoll, The Liberty of Man, Woman and Child 1877 -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201301280432.44717.only...@member.fsf.org
Bug#698997: unblock: italc/1:1.0.13-1.4
On Sat, 26 Jan 2013 21:50:14 Adam D. Barratt wrote: + added new qtpath.patch to avoid fatal error for wrong path to libraries. I may be missing something here, but the patch simply removes the error message. Presumably the fact that the error is being raised in the first place indicates an actual problem? If not then the test seems somewhat redundant in the first place. It is a *fatal* error message that is always wrong because it looking for library in hardcoded non-multiarch location. Therefore removing it is a minimalistic change to fix the problem which is exactly a failure to find library where it can't be. Of course there are different ways to fix it but I've chosen an easy and straightforward one which works. In other words I'm removing failure point: unnecessary check for library in wrong location. Simply removing the error message is enough to fix the problem. I hope it makes sense. -- Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- Believing is easier than thinking. Hence so many more believers than thinkers. -- Bruce Calvert -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201301262249.51582.only...@member.fsf.org
Bug#698997: unblock: italc/1:1.0.13-1.4
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock X-Debbugs-CC: glaub...@physik.fu-berlin.de Please unblock package 'italc' unblock italc/1:1.0.13-1.4 This version fixes two FTBFS bugs: italc: FTBFS: Couldn't find any Qt4 libraries (#671489) FTBFS with GCC-4.7 (wrong bug number in previous NMU) Diff is attached, new changelog entries as below: ## italc (1:1.0.13-1.4) unstable; urgency=medium * Non-maintainer upload. * fixed FTBFS (Closes: #671489). + added new qtpath.patch to avoid fatal error for wrong path to libraries. + introduced dh-autoreconf to regenerate configure script using corrected acinclude.m4 file. -- Dmitry Smirnov only...@member.fsf.org Thu, 08 Nov 2012 15:08:19 +1100 italc (1:1.0.13-1.3) unstable; urgency=low * Non maintainer upload. * Fix build failure with GCC 4.7. Closes: #667203. -- Matthias Klose d...@debian.org Fri, 04 May 2012 08:37:15 +0200 ## I've just realized that #667203 is incorrect bug number; I verified the corresponding patch to build with GCC-4.7 and found that the patch is necessary and it works. Thank you. -- Cheers, Dmitry Smirnov --- Every decent man is ashamed of the government he lives under. -- H. L. Mencken diff --git a/italc-1.0.13/debian/changelog b/italc-1.0.13/debian/changelog index 92d6f38..9a12d7b 100644 --- a/italc-1.0.13/debian/changelog +++ b/italc-1.0.13/debian/changelog @@ -1,3 +1,21 @@ +italc (1:1.0.13-1.4) unstable; urgency=medium + + * Non-maintainer upload. + * fixed FTBFS (Closes: #671489). ++ added new qtpath.patch to avoid fatal error for wrong path + to libraries. ++ introduced dh-autoreconf to regenerate configure script using + corrected acinclude.m4 file. + + -- Dmitry Smirnov only...@member.fsf.org Thu, 08 Nov 2012 15:08:19 +1100 + +italc (1:1.0.13-1.3) unstable; urgency=low + + * Non maintainer upload. + * Fix build failure with GCC 4.7. Closes: #667203. + + -- Matthias Klose d...@debian.org Fri, 04 May 2012 08:37:15 +0200 + italc (1:1.0.13-1.2) unstable; urgency=low * Non-maintainer upload. diff --git a/italc-1.0.13/debian/control b/italc-1.0.13/debian/control index fdd63ce..8ad39b6 100644 --- a/italc-1.0.13/debian/control +++ b/italc-1.0.13/debian/control @@ -2,7 +2,7 @@ Source: italc Section: x11 Priority: optional Maintainer: Patrick Winnertz win...@debian.org -Build-Depends: cdbs, debhelper (= 5.0), libqt4-dev, zlib1g-dev, libjpeg-dev, libssl-dev, imagemagick, libxtst-dev +Build-Depends: cdbs, debhelper (= 5.0), dh-autoreconf, libqt4-dev, zlib1g-dev, libjpeg-dev, libssl-dev, imagemagick, libxtst-dev Standards-Version: 3.9.1 Homepage: http://italc.sourceforge.net/home.php diff --git a/italc-1.0.13/debian/patches/ftbfs-gcc-4.7.diff b/italc-1.0.13/debian/patches/ftbfs-gcc-4.7.diff new file mode 100644 index 000..0d0f24d --- /dev/null +++ b/italc-1.0.13/debian/patches/ftbfs-gcc-4.7.diff @@ -0,0 +1,78 @@ +Index: italc-1.0.13/ica/Makefile.am +=== +--- italc-1.0.13.orig/ica/Makefile.am 2010-12-14 14:51:19.0 + italc-1.0.13/ica/Makefile.am 2012-05-04 06:40:07.019771287 + +@@ -97,7 +97,7 @@ + endif + + ica_LDADD = $(QT_LDADD) $(QT_LIB_GUI) -lz -ljpeg $(LIBSSL_LDADD) $(IVSLDADD) $(WIN32_RES_LDADD) -L../lib -litalc_core +-ica_LDFLAGS = $(LDFLAGS) -mwindows -rpath $(pkglibdir) ++ica_LDFLAGS = $(LDFLAGS) -rpath $(pkglibdir) + + AM_CXXFLAGS = $(QT_CXXFLAGS) -O2 -DBUILD_ICA $(CXXFLAGS_ADD) + AM_CFLAGS = -O2 -DBUILD_ICA -DVNCSHARED -DFOREVER -DNOREPEAT=0 -DNOPW=1 -DREMOTE_CONTROL=0 -DEXTERNAL_COMMANDS=0 -DFILEXFER=0 -DNOGUI -DSMALL_FOOTPRINT=1 -w +Index: italc-1.0.13/ica/Makefile.in +=== +--- italc-1.0.13.orig/ica/Makefile.in 2011-01-06 10:46:18.0 + italc-1.0.13/ica/Makefile.in 2012-05-04 06:40:07.023771287 + +@@ -377,7 +377,7 @@ + @HAVE_LIBSSL_TRUE@LIBSSL_LDADD = -lssl -lcrypto + @BUILD_WIN32_TRUE@WIN32_RES_LDADD = ica_win_resources.o -L. -lvnchooks + ica_LDADD = $(QT_LDADD) $(QT_LIB_GUI) -lz -ljpeg $(LIBSSL_LDADD) $(IVSLDADD) $(WIN32_RES_LDADD) -L../lib -litalc_core +-ica_LDFLAGS = $(LDFLAGS) -mwindows -rpath $(pkglibdir) ++ica_LDFLAGS = $(LDFLAGS) -rpath $(pkglibdir) + AM_CXXFLAGS = $(QT_CXXFLAGS) -O2 -DBUILD_ICA $(CXXFLAGS_ADD) + AM_CFLAGS = -O2 -DBUILD_ICA -DVNCSHARED -DFOREVER -DNOREPEAT=0 -DNOPW=1 -DREMOTE_CONTROL=0 -DEXTERNAL_COMMANDS=0 -DFILEXFER=0 -DNOGUI -DSMALL_FOOTPRINT=1 -w + INCLUDES = $(IVS_INCLUDES) -I$(srcdir)/../lib/include -I$(srcdir)/../lib/include/rfb -I$(srcdir)/src -I$(top_srcdir) +Index: italc-1.0.13/ima/Makefile.am +=== +--- italc-1.0.13.orig/ima/Makefile.am 2010-12-14 14:51:19.0 + italc-1.0.13/ima/Makefile.am
Bug#687916: Zabbix 2.x for Debain in testing
Dear Martin, On Fri, 11 Jan 2013 10:31:42 Martin Hollerweger wrote: will there be a upgradeable 2.x realease of Zabbix in testing in the near feature? There are open security issues in 1.8.11: https://security-tracker.debian.org/tracker/CVE-2012-3435 We can only tell that there will be no Zabbix-1.8 in testing. Whenever 2.x will be allowed to Wheezy is up to release team. I hope 2.0.2 can be shipped but if not we'll maintain it in backports. At the moment you can get 2.0.2 from unstable or most recent release from experimental. -- Cheers, Dmitry Smirnov GPG key : 4096R/53968D1B --- We must respect the other fellow's religion, but only in the sense and to the extent that we respect his theory that his wife is beautiful and his children smart. (H. L. Mencken) -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130235.37807.only...@member.fsf.org
Bug#691115: unblock libdvdread/4.2.0+20120521-3
On Sat, 15 Dec 2012 07:37:50 intrigeri wrote: Waht would you do? If there was a bug I really wanted to see fixed in Wheezy, I would 1. talk to the maintainer and possibly 2. prepare an upload for t-p-u. Thanks, we'll see how it goes. Now I'd prefer to leave it with maintainer. The effects of this bug on a package that is not in testing is hardly relevant to the requested unblock. Please find a more relevant example to illustrate the case :) I don't need to -- the original bug reporter (#688574) was not aware of similar cases. He had a perfect example of a problem and I just had a misfortune to discover another case of similar crash. If two confirmed crashes is not enough for you, how many do you need? ;) If it's worth it, going through t-p-u might be an option. Understood thanks. IMHO Daniel will be the best person to take care of this. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212152157.10736.only...@member.fsf.org
Bug#691115: unblock libdvdread/4.2.0+20120521-3
On Wed, 12 Dec 2012 21:30:14 intrigeri wrote: Dmitry Smirnov wrote (12 Dec 2012 01:16:15 GMT) : There were no reply from maintainer in #688574 so perhaps it would be better to set Daniel as owner of this bug... Please do it if you feel it's useful. Waht would you do? A full new upstream version was uploaded to unstable since then, so an update in testing would now have to go through t-p-u. Thank you, I didn't notice that new libdvdread was uploaded. Given the crash fixed by 4.2.0+20120521-3 has severity normal, I'm unsure it's worth the effort. I'm not sure if normal is an adequate severity for crash. For example handbrake (not in testing) was unusable (crashing on DVD open) with libdvdread prior to 4.2.0+20120521-3. Dmitry, you filed the unblock request that is now outdated, what do you think? We can close it if you think that's the right thing to do. What else we can do? IMHO even if fix is not implemented properly it is still prevent certain crashes which can't be worse than what's in testing right now. I'm not sure this would be worse than what's in testing right now, but let's acknowledge that the fix has potential for future regressions, and does not only bring good: using internal implementation details of other libraries results in code that can break without notice, in the future, when the depended upon library is updated. I'm with you. Indeed that's choosing between bad and the worse. However decision making here is simple -- on one hand we have a certain (confirmed) crash when on the other we have potential for regressions that may or may not be manifested. To me crash is too serious to ignore because the whole functionality of the package is compromised. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212130940.05955.only...@member.fsf.org
Bug#691115: unblock libdvdread/4.2.0+20120521-3
On Wed, 12 Dec 2012 12:04:23 intrigeri wrote: Ping? There were no reply from maintainer in #688574 so perhaps it would be better to set Daniel as owner of this bug... IMHO even if fix is not implemented properly it is still prevent certain crashes which can't be worse than what's in testing right now. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212121216.15562.only...@member.fsf.org
Bug#687916: Zabbix: 1.8.11-1__to__2.0.2+dfsg-4
On Sat, 8 Dec 2012 19:15:36 Yves-Alexis Perez wrote: I didnd't see the debdiff, but I'm not sure that's something they'll really want to migrate at that time of the freeze. I'm attaching the diff (1.8.11-1/testing :: 2.0.2+dfsg-4/unstable) but I doubt if it'll be helpful: with more than 200 commits we rewrote ~85% of debian/* contents. Regards, Dmitry. zabbix_1.8.11-1__to__2.0.2-4.diff.gz Description: GNU Zip compressed data
Bug#687916: unblock: zabbix/1:2.0.2+dfsg-4
Hi Julien, On Sun, 9 Dec 2012 00:45:28 Julien Cristau wrote: On Mon, Oct 1, 2012 at 20:07:07 +0200, Moritz Mühlenhoff wrote: For stable-security backporting security issues wasn't feasible due to a lack of continued upstream support for 1.8.x and invasive/complex changes. This shouldn't happen again. If there's no commitment from upstream to support a long term branch it should rather be removed from testing. Dmitry, is there such a commitment for 2.0.x for wheezy's lifetime? Yes, I believe there is but I'm not sure how to support it with evidence. First of all I feel that Moritz' statement regarding upstream support for 1.8.x may be a bit inaccurate. As you can see from http://www.zabbix.com/rn2.0.4.php last released Zabbix 1.8.15 was published on 2012-08-20 so I'm not sure if we can already declare lack of continued upstream support for 1.8.x. Just today I was looking into old CVEs to close in stable as per discussion in #683273. I found that whenever CVE was reported to upstream using bug tracker they commit corresponding fix into dedicated branch that later got merged into trunk and 1.8 branches so it's not that difficult to isolate the changes. Of course when upstream applied security fix to version 1.8.11 it may be not too easy to backport it to 1.8.2 but I suspect this problem is not unique to Zabbix. I have very limited experience with security fixes in Zabbix (and in Debian in general) so please don't take my words as granted without feedback from Christoph and Moritz who are far more experienced that I am. However to put this situation to proper context I'd like to mention mysql- workbench package (maintained by yours truly) where upstream doesn't have public VCS at all. Backporting fixes is only possible by reverse-engineering new tarballs releases by comparing huge changesets and trying to make sense of changes. To make matters worse upstream is not updating changelog accurate enough so you can imagine the challenges. I believe Zabbix is much better in that regards. We can't be sure how well Zabbix will be supporting 1.8.x in the future. Obviously they've switched focus to Zabbix 2.0.x and that makes it better for us to upgrade to 2.0. While we can't be sure regarding future support for 1.8 and backporting fixes was proven to be challenging (according to feedback from Christoph and Moritz) I think we're all agree that 1.8 is better to be removed from testing to minimise the risks and the maintenance burden. (I think at the moment security fixes are applied to 2.0 first, so even the delay before fix will be applicable to 1.8 is bad enough.) Personally I hope that unblocking 2.0 may be considered as current version in unstable was remarkably free of troubles but that's just my inexperienced opinion. I think Christoph is quite excited about the idea of maintaining Zabbix in backports so the tough decision regarding Zabbix' destiny in Debian is with you. :) Thank you. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212090141.46740.only...@member.fsf.org
Bug#688729: unblock xpra/0.3.9+dfsg-2
On Sat, 1 Dec 2012 23:46:44 Julien Cristau wrote: Please unblock package 'xpra' Unblocked. Thank you so much Julien. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201212020814.43852.only...@member.fsf.org
Bug#691386: unblock: mc/3:4.8.3-10
Package: release.debian.org
Severity: minor
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package 'mc'
unblock mc/3:4.8.3-10
This version fixes bug #689258 that Luca Falavigna dktrkr...@debian.org
commented:
I'd love to have this fix in Wheezy (and eventually in
squeeze-backports)
Diff is attached, alternatively the following commit represent all
the changes since mc/3:4.8.3-9:
http://anonscm.debian.org/gitweb/?p=collab-maint/mc.git;a=commitdiff;h=d755826edf3afad66cbdbea09c39b522f07f6a7c
Thank you.
Regards,
Dmitry.
diff --git a/debian/changelog b/debian/changelog
index 4e38404..b595c85 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -0,0 +1,7 @@
+mc (3:4.8.3-10) unstable; urgency=low
+
+ * New backported patch to fix diff.gz inspection from symlink
+(Closes: #689258).
+
+ -- Dmitry Smirnov only...@member.fsf.org Tue, 02 Oct 2012 19:09:51 +1000
+
diff --git a/debian/patches/2910.patch b/debian/patches/2910.patch
new file mode 100644
index 000..0d2c48d
--- /dev/null
+++ b/debian/patches/2910.patch
@@ -0,0 +1,47 @@
+Last-Update: 2012-10-04
+Forwarded: not-needed,backported
+Author: Dmitry Smirnov only...@member.fsf.org
+Bug-MC: https://www.midnight-commander.org/ticket/2910
+Bug-Debian: http://bugs.debian.org/689258
+Description: backported fix for q{empty diff.gz if entered from symlink}
+
+--- a/src/vfs/extfs/helpers/patchfs.in
b/src/vfs/extfs/helpers/patchfs.in
+@@ -380,25 +380,31 @@
+ or error Can't write to archive;
+ }
+
++my $fin = $ARGV[1];
++
++# resolve symlink
++while (-l $fin) {
++$fin = readlink $fin;
++}
+
+ if ($ARGV[0] eq 'list') {
+-open I, myin($ARGV[1]).'|';
+-list ($ARGV[1]);
++open I, myin($fin).'|';
++list ($fin);
+ exit 0;
+ } elsif ($ARGV[0] eq 'copyout') {
+-open I, myin($ARGV[1]).|;
++open I, myin($fin).|;
+ copyout ($ARGV[2], $ARGV[3]);
+ exit 0;
+ } elsif ($ARGV[0] eq 'rm') {
+-open I, myin($ARGV[1]).|;
+-rm ($ARGV[1], $ARGV[2]);
++open I, myin($fin).|;
++rm ($fin, $ARGV[2]);
+ exit 0;
+ } elsif ($ARGV[0] eq 'rmdir') {
+ exit 0;
+ } elsif ($ARGV[0] eq 'mkdir') {
+ exit 0;
+ } elsif ($ARGV[0] eq 'copyin') {
+-copyin ($ARGV[1], $ARGV[2], $ARGV[3]);
++copyin ($fin, $ARGV[2], $ARGV[3]);
+ exit 0;
+ }
+ exit 1;
diff --git a/debian/patches/series b/debian/patches/series
index b830a76..ec275f7 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -34,0 +35 @@ fix_nospace.patch
+2910.patch
signature.asc
Description: This is a digitally signed message part.
Bug#691115: unblock libdvdread/4.2.0+20120521-3
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package 'libdvdread4' unblock libdvdread/4.2.0+20120521-3 This update fix crashes (#688574). Full diff is attached. Thank you. Regards, Dmitry. diff --git a/debian/changelog b/debian/changelog index 261169d..aab071b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -0,0 +1,7 @@ +libdvdread (4.2.0+20120521-3) unstable; urgency=low + + * Adding patch from Peter Van Eynde pvane...@debian.org to fix +miscompilation leading to a segfault (Closes: #688574). + + -- Daniel Baumann daniel.baum...@progress-technologies.net Mon, 24 Sep 2012 17:00:28 +0200 + diff --git a/debian/patches/09-segfault.patch b/debian/patches/09-segfault.patch new file mode 100644 index 000..82c16ea --- /dev/null +++ b/debian/patches/09-segfault.patch @@ -0,0 +1,14 @@ +Author: Peter Van Eynde pvane...@debian.org +Description: Fix miscompilation leading to a segfault (Closes: #688574). + +diff -Naurp libdvdread.orig/src/dvd_reader.c libdvdread/src/dvd_reader.c +--- libdvdread.orig/src/dvd_reader.c 2012-09-24 16:55:49.681245164 +0200 libdvdread/src/dvd_reader.c 2012-09-24 16:56:06.845356530 +0200 +@@ -30,6 +30,7 @@ + #include string.h + #include ctype.h + #define _GNU_SOURCE ++#define __USE_GNU + #include unistd.h + #include limits.h + #include dirent.h diff --git a/debian/patches/series b/debian/patches/series index 79e397c..2eb96d6 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -8,0 +9 @@ +09-segfault.patch signature.asc Description: This is a digitally signed message part.
Bug#688729: unblock xpra/0.3.11+dfsg-1
retitle 688729 unblock xpra/0.3.11+dfsg-1
--
Please unblock package xpra.
unblock xpra/0.3.11+dfsg-1
All upstream 0.3.x releases are bugfix-only.
Upstream changelog as below:
v0.3.11 (2012-10-05)
==
-- fix bencoder to properly handle dicts with non-string keys
-- take shortcut if there is nothing to send
-- fix password file handling: exceptions and ignore carriage returns
On top of that our changhes as below (full diff is attached):
xpra (0.3.11+dfsg-1) unstable; urgency=low
* New upstream release.
* New backported patch to fix crash on pop-up tooltip windows.
* VCS links are updated for new repository at collab-maint.
To my knowledge we didn't have any regressions since 0.3.2 (in testing)
so all the bugs that we fixed in unstable are present in 0.3.2 as well.
In our recent discussion upstream expressed concerns regarding 0.3.2.
In his own words:
0.3.2 is full of holes
Just occurred to me that 0.3.2 won't even connect to a 0.7.0 server
due to one of those bugs (or the other way around - cannot remember)
So we have a very buggy version in testing which is notorious for poor
compatibility, crashes, problems with clipboard, undocumented Xdummy support
which is critical for resolve #1 (most popular) support request i.e. menus
opened off-screen etc.
We could file few RC bugs to ourselves but I hope that won't be necessary.
Please unblock.
Thanks in advance,
Dmitry.
signature.asc
Description: This is a digitally signed message part.
diff --git a/debian/changelog b/debian/changelog
index e2c7feb..2100220 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,13 @@
+xpra (0.3.11+dfsg-1) unstable; urgency=low
+
+ * New upstream release.
+ * New backported patch to fix crash on pop-up tooltip windows.
+ * VCS links are updated for new repository at collab-maint.
+
+ -- Dmitry Smirnov only...@member.fsf.org Tue, 09 Oct 2012 13:13:52 +1100
+
xpra (0.3.10+dfsg-1) unstable; urgency=low
* New upstream release.
-- أحمد المحمودي (Ahmed El-Mahmoudy) aelmahmo...@sabily.org Wed, 26 Sep 2012 16:03:44 +0200
diff --git a/debian/control b/debian/control
index dc75373..2e0fb2f 100644
--- a/debian/control
+++ b/debian/control
@@ -18,12 +18,12 @@ Build-Depends: cython ( 0.14.0),
python-all-dev (= 2.6.6-2),
python-gobject-dev,
python-gtk2-dev
Standards-Version: 3.9.3
Homepage: http://xpra.org/
-Vcs-Svn: svn://svn.debian.org/python-apps/packages/xpra/trunk/
-Vcs-Browser: http://svn.debian.org/viewsvn/python-apps/packages/xpra/trunk/
+Vcs-Git: git://anonscm.debian.org/collab-maint/xpra.git
+Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/xpra.git
DM-Upload-Allowed: yes
Package: xpra
Architecture: any
Depends: ${misc:Depends},
diff --git a/debian/patches/r1854-fix-crash.patch b/debian/patches/r1854-fix-crash.patch
new file mode 100644
index 000..396603d
--- /dev/null
+++ b/debian/patches/r1854-fix-crash.patch
@@ -0,0 +1,56 @@
+Last-Update: 2012-10-08
+Author: Dmitry Smirnov only...@member.fsf.org
+Origin: https://www.xpra.org/svn/Xpra/trunk@1854
+Forwarded: not-needed,backported
+Bug-Xpra: https://www.xpra.org/trac/ticket/191
+Description: fix crash on pop-up tooltip windows
+
+--- a/xpra/server.py
b/xpra/server.py
+@@ -2227,30 +2227,34 @@
+ self.keys_pressed[keycode] = keyname
+ xtest_fake_key(gtk.gdk.display_get_default(), keycode, True)
+ self._key_repeat(wid, True, keyname, keyval, keycode, modifiers, self.key_repeat_interval)
+
++def _process_mouse_common(self, proto, wid, pointer, modifiers):
++self._make_keymask_match(modifiers, self.xkbmap_mod_pointermissing)
++window = self._id_to_window.get(wid)
++if not window:
++log(_process_mouse_common() invalid window id: %s, wid)
++return
++def raise_and_move():
++self._desktop_manager.raise_window(window)
++self._move_pointer(pointer)
++trap.call(raise_and_move)
++
+ def _process_button_action(self, proto, packet):
+-(wid, button, pressed, pointer, modifiers) = packet[1:6]
+-self._make_keymask_match(modifiers, ignored_modifier_keynames=self.xkbmap_mod_pointermissing)
+-self._desktop_manager.raise_window(self._id_to_window[wid])
+-self._move_pointer(pointer)
++wid, button, pressed, pointer, modifiers = packet[1:6]
++self._process_mouse_common(proto, wid, pointer, modifiers)
+ try:
+-trap.call_unsynced(xtest_fake_button,
++trap.call_synced(xtest_fake_button,
+gtk.gdk.display_get_default(),
+button, pressed)
+ except XError:
+ log.warn(Failed to pass on (un)press of mouse button %s
+ + (perhaps your Xvfb does not support mousewheels?),
+ button)
+
+ def
Bug#687916: unblock: zabbix/1:2.0.2+dfsg-4
On Sun, 30 Sep 2012 06:07:18 Julien Cristau wrote: At this point my preference would go towards removing zabbix from wheezy. The new version was uploaded too late for the freeze, and if nobody's fixing 1.8 then there's no point shipping that. It is true that 1.8 have problems that we already fixed in 2.0. So it comes down to the question is 2.0 good enough to replace 1.8. Removing Zabbix 1.8 feels like punishing for my poor timing. (Personally I have a pretty good excuse for it). Yes 2.0 was uploaded late, but it is done well. Now it is 45 days without new bugs. I don't want to see Zabbix removed and this won't help our relationships with upstream. I was not involved to 1.8 maintenance and therefore it is a bit challenging for me to get into it quick enough. Looking after both versions is more difficult but I'll see what I can do. Meanwhile I'd like to discuss pros and cons of replacing 1.8 with 2.0 please. Regards, Dmitry. signature.asc Description: This is a digitally signed message part.
Bug#688729: unblock xpra/0.3.10+dfsg-1
retitle 688729 unblock xpra/0.3.10+dfsg-1 -- We've just uploaded another update to 0.3.x branch: 0.3.10+dfsg-1. Our packaging hasn't change since 0.3.9+dfsg-2. Upstream changelog as below: v0.3.10 (2012-09-25) == -- fix missing key frames with x264/vpx: always reset the video encoder when we skip some frames (forces a new key frame) -- fix server crash on invalid keycodes (zero or negative) -- fix latency: isolate per-window latency statistics from each other -- drop support for servers older than v0.3.0 unblock xpra/0.3.10+dfsg-1 Thank you. Regards, Dmitry. signature.asc Description: This is a digitally signed message part.
Bug#687909: unblock: mc/3:4.8.3-9
retitle 687909 unblock: mc/3:4.8.3-9
--
Updating according to new version uploaded to unstable (full diff from
previous version is attached):
mc (3:4.8.3-9) unstable; urgency=low
* new backported patch to fix ESC+TAB completion on paths
starting with ~ (Closes: #688075).
Thank you.
Regards,
Dmitry.
diff --git a/debian/changelog b/debian/changelog
index 4d3b026..4e38404 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,11 @@
+mc (3:4.8.3-9) unstable; urgency=low
+
+ * new backported patch to fix ESC+TAB completion on paths
+starting with ~ (Closes: #688075).
+
+ -- Dmitry Smirnov only...@member.fsf.org Mon, 24 Sep 2012 01:36:11 +1000
+
mc (3:4.8.3-8) unstable; urgency=low
* New backported patches:
+ to fix cannot Copy/Move files with filename encoding change.
diff --git a/debian/patches/2898.patch b/debian/patches/2898.patch
new file mode 100644
index 000..1758655
--- /dev/null
+++ b/debian/patches/2898.patch
@@ -0,0 +1,35 @@
+Last-Update: 2012-09-24
+Author: Dmitry Smirnov only...@member.fsf.org
+Origin: https://www.midnight-commander.org/changeset/dac67d1380c7d0dd6c71ecef8c334a28c3f6f17e
+Forwarded: not-needed
+Bug-MC: https://www.midnight-commander.org/ticket/2898
+Description: backported fix for q{ESC+TAB completion on ~}
+ fixes minor regression introduced in MC#2874
+
+--- a/lib/widget/input_complete.c
b/lib/widget/input_complete.c
+@@ -120,7 +120,7 @@
+ static char *
+ filename_completion_function (const char *text, int state, input_complete_t flags)
+ {
+-static DIR *directory;
++static DIR *directory = NULL;
+ static char *filename = NULL;
+ static char *dirname = NULL;
+ static char *users_dirname = NULL;
+@@ -169,7 +169,6 @@
+ dirname = g_strdup (.);
+ filename = g_strdup (text);
+ }
+-dirname_vpath = vfs_path_from_str (dirname);
+
+ /* We aren't done yet. We also support the ~user syntax. */
+
+@@ -177,6 +176,7 @@
+ users_dirname = dirname;
+ dirname = tilde_expand (dirname);
+ canonicalize_pathname (dirname);
++dirname_vpath = vfs_path_from_str (dirname);
+
+ /* Here we should do something with variable expansion
+and `command`.
diff --git a/debian/patches/series b/debian/patches/series
index b55fa04..b830a76 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -30,4 +30,5 @@ fix_nospace.patch
2832.patch
2833.patch
2807.patch
2874.patch
+2898.patch
signature.asc
Description: This is a digitally signed message part.
Bug#687913: unblock: abiword/2.9.2+svn20120603-7
retitle 687913 unblock: abiword/2.9.2+svn20120603-7
--
Updating according to new version uploaded to unstable (full diff from
previous version is attached):
abiword (2.9.2+svn20120603-7) unstable; urgency=low
* new backported patches:
+ r31854_bug-13397-RTF-import-fix-missing-text.patch
to fix missing numbers in beginning of lines on RTF/DOC import
(Closes: #688552).
+ r31855_gtk3-bug-13405.patch
+ r31877_start-layout-only-after-document-is-fully-loaded.patch
- removed unused (duplicate) patch file.
This version fixing serious bug when abiword dropping numbers from beginning
of lines on document open.
Thank you.
Regards,
Dmitry.
diff --git a/debian/changelog b/debian/changelog
index 3834422..fb2ce87 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,16 @@
+abiword (2.9.2+svn20120603-7) unstable; urgency=low
+
+ * new backported patches:
++ r31854_bug-13397-RTF-import-fix-missing-text.patch
+ to fix missing numbers in beginning of lines on RTF/DOC import
+ (Closes: #688552).
++ r31855_gtk3-bug-13405.patch
++ r31877_start-layout-only-after-document-is-fully-loaded.patch
+- removed unused (duplicate) patch file.
+
+ -- Dmitry Smirnov only...@member.fsf.org Mon, 24 Sep 2012 11:10:44 +1000
+
abiword (2.9.2+svn20120603-6) unstable; urgency=low
* debian/watch to find all available versions with fallback to latest-dev.
* new patch to fix collab backend if built --with-gtk2 and to fix FTBFS
diff --git a/debian/patches/r31847_fix-program-hanging-during-paste-unformatted.patch b/debian/patches/r31847_fix-program-hanging-during-paste-unformatted.patch
index 64c3c57..a35b71f 100644
--- a/debian/patches/r31847_fix-program-hanging-during-paste-unformatted.patch
+++ b/debian/patches/r31847_fix-program-hanging-during-paste-unformatted.patch
@@ -3,15 +3,8 @@ Author: Dmitry Smirnov only...@member.fsf.org
Forwarded: not-needed
Description: backported patch
Bug 13401: fix program hanging during paste unformatted
-git-svn-id: http://svn.abisource.com/abiword/trunk@31847 bcba8976-2d24-0410-9c9c-aab3bd5fdfd6
- src/text/ptbl/xp/pd_Document.cpp | 17 +
- src/text/ptbl/xp/pd_Document.h |3 ++-
- src/wp/impexp/xp/ie_imp.cpp |5 +++--
- 3 files changed, 18 insertions(+), 7 deletions(-)
-
--- a/src/text/ptbl/xp/pd_Document.cpp
+++ b/src/text/ptbl/xp/pd_Document.cpp
@@ -1327,10 +1327,9 @@
* If pAttrProp is set to NULL, the text will be set to exactly
diff --git a/debian/patches/r31854_bug-13397-RTF-import-fix-missing-text.patch b/debian/patches/r31854_bug-13397-RTF-import-fix-missing-text.patch
new file mode 100644
index 000..6148460
--- /dev/null
+++ b/debian/patches/r31854_bug-13397-RTF-import-fix-missing-text.patch
@@ -0,0 +1,43 @@
+Last-Update: 2012-09-24
+Author: Dmitry Smirnov only...@member.fsf.org
+Forwarded: not-needed
+Origin: r31854
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688552
+Bug-Abiword: http://bugzilla.abisource.com/show_bug.cgi?id=13397
+Description: backported patch to fix missing text on RTF/DOC import
+ fixes RTF importer: Use PopRTFState on a closing
+ backet if PushRTFState was called on the corresponding
+ opening bracket.
+
+--- a/src/wp/impexp/xp/ie_imp_RTF.cpp
b/src/wp/impexp/xp/ie_imp_RTF.cpp
+@@ -2638,6 +2638,13 @@
+ UT_DEBUGMSG((FlushStoredChars()\n));
+ }
+ }
++
++ /* m_stateStack.getDepth() == 0 if the functions PushRTFState and PopRTFState
++ have been called the same number of times. Each call to PushRTFState on an
++ opening bracket ({) should be followed by a call to PopRTFState on the
++ corresponding closing bracket (}).*/
++ UT_ASSERT(m_stateStack.getDepth() == 0);
++
+ // UT_DEBUGMSG((dumping document\n));
+ // getDoc()-__dump(stderr);
+ return ok ? UT_OK : UT_ERROR;
+@@ -8905,6 +8912,7 @@
+ PD_DocumentRDFMutationHandle m = rdf-createMutation();
+ /*UT_Error e = */loadRDFXML( m, rdfxml );
+ m-commit();
++ PopRTFState();
+ UT_DEBUGMSG((rdf triples after read of rdf tag size:%ld\n, (long)rdf-size() ));
+ return true;
+ }
+@@ -12525,6 +12533,7 @@
+ break;
+ }
+ } while ((tokenType != RTF_TOKEN_CLOSE_BRACE) || (nested = 0));
++ PopRTFState();
+ return true;
+ }
+
diff --git a/debian/patches/r31855_gtk3-bug-13405.patch b/debian/patches/r31855_gtk3-bug-13405.patch
new file mode 100644
index 000..c488194
--- /dev/null
+++ b/debian/patches/r31855_gtk3-bug-13405.patch
@@ -0,0 +1,18 @@
+Last-Update: 2012-09-24
+Author: Dmitry Smirnov only...@member.fsf.org
+Forwarded: not-needed
+Origin: r31855
+Bug-Abiword: http://bugzilla.abisource.com/show_bug.cgi?id=13405
+Description: backported patch to fix GTK3 bug
+
+--- a/src/wp/ap/gtk/abiwidget.cpp
b/src/wp/ap/gtk/abiwidget.cpp
+@@ -2022,7 +2022,7 @@
+ gtk_widget_set_can_focus(GTK_WIDGET(abi), true);
+ gtk_widget_set_receives_default(GTK_WIDGET(abi), true);
+ gtk_widget_set_can_default(GTK_WIDGET(abi), true);
+- gtk_widget_set_has_window(GTK_WIDGET(abi
Bug#688729: unblock xpra/0.3.9+dfsg-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Please unblock package 'xpra' This is major strategically important update. Upstream treat 0.3.x versions as most conservative bugfix-only branch. Earlier development moved to 0.4.x (deprecated) then to 0.5.x (current stable) and recently to 0.6.x (experimental). Upstream changelog (below) highlighting many important fixes for protocol and clipboard bugs rendering package unusable in some cases. According to upstream 0.3.9 is expected to be a last update to 0.3.x branch. It is providing important changes for protocol compatibility with later versions. #680244 is also expressing some concerns regarding current state of 0.3.2 in testing. As for packaging, we apologise for the number of introduced changes (see attached diff). One of the most important ones we had to do is to expose python modules publicly for interaction with frontends as xpra is both application and a module. ## Changelog: xpra (0.3.9+dfsg-2) unstable; urgency=low * Override dh_compress to prevent compression of example conf file. (Closes: #688235) xpra (0.3.9+dfsg-1) unstable; urgency=low * New upstream release. * debian/README.Debian: Remove Known issues section, it is invalidated with 0.3.6 release. * debian/rules: Allow overriding of VER in get-orig-source. [ Dmitry Smirnov ] * debian/rules: export LDFLAGS using DEB_LDFLAGS_MAINT_APPEND. * debian/xpra.install: install only *.png icons. * Remove debian/parti.* (we're not shipping parti). * Publicly expose xpra modules. + Dropped private-pkg.diff patch. + debian/xpra.install: install xpra modules publicly. * debian/watch: corrected version mangle (Closes: #674964) * Removing debian/repack in favour of get-orig-source * binary and source compression to xz: + debian/rules: added override for dh_builddeb + Added debian/source/options * debian/copyright: add missing copyright paragraph. xpra (0.3.6+dfsg-1) unstable; urgency=low * debian/control: Added Dmitry Smirnov to Uploaders * New upstream release. (Closes: #683133) [ Dmitry Smirnov ] * Remove debian/docs * debian/copyright: + Consolidated and updated copyright info. + Update copyright format. * debian/control: added Recommends: xserver-xorg-video-dummy * debian/rules: avoid dropping LDFLAGS when passing --as-needed (fixes Hardening) * install sample 'dummy.xorg.conf' and README.Debian with instructions how to use Xdummy (Closes: #681051). * separating man pages from .install to .manpages xpra (0.3.4+dfsg-1) unstable; urgency=low * New upstream release. xpra (0.3.3+dfsg-1) unstable; urgency=low * New upstream release. ## ## Upstream Changelog: v0.3.9 (2012-09-08) == -- fix man page typo -- fix non bash login shell compatibility -- fix xpra screenshot argument parsing error handling v0.3.8 (2012-09-05) == -- zlib compatibility fix: use chunked decompression when supported (newer versions) v0.3.7 (2012-08-29) == -- fix zlib compression in raw packet mode: always flush the buffer -- fix big clipboard packets causing disconnection: just drop them instead -- force disconnection after irrecoverable network parsing error -- support compressed cursors -- fix incomplete cloning of attributes causing default values to be used -- fix window refresh: do not skip all windows after a hidden one! v0.3.6 (2012-08-16) == -- fix clipboard atom packing (was more noticeable with qt and Java applications) -- fix clipboard selection for non X11 clients: only 'multiple' codepath requires X11 bindings -- fix python3 build -- fix potential double free in x264 error path -- fix logging format error on window dimensions have changed.. (parameter grouping was wrong) -- fix colour bleeding with x264 (ie: green on black text) -- remove incorrect and unnecessary callback to setup_xprops which may have caused the pulseaudio flag to use the wrong value -- delay 'check packet size' to allow the limit to be raised - important over slower links where it triggers more easily v0.3.5 (2012-07-31) == -- fix clipboard bugs -- robustify cython version string parsing -- fix source files changed detection during build v0.3.4 (2012-07-23) == -- fix window size hints not applied -- fix free uninitialized pointers in error codepath -- fix crash with 1 pixel wide/high windows -- fix keyboard support for MS Windows and OSX clients -- explicitly include all icons -- handle invalid packets in the correct thread -- try harder to exit cleanly -- ensure all
Bug#687914: unblock: tupi/0.1+git12-7
Package: release.debian.org
Severity: minor
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package 'tupi'
This is a minor update mainly to fix Hardening in plugins:
Changelog:
tupi (0.1+git12-7) unstable; urgency=low
* xz compression for binary packages.
* pass all required build flags to fix Hardening.
* lintian-overrides for Hardening false-positives.
See all the changes in the attached diff.
unblock tupi/0.1+git12-7
Thank you.
Regards,
Dmitry.
diff --git a/debian/changelog b/debian/changelog
index 351dc08..cf4c6e6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,4 +1,12 @@
+tupi (0.1+git12-7) unstable; urgency=low
+
+ * xz compression for binary packages.
+ * pass all required build flags to fix Hardening.
+ * lintian-overrides for Hardening false-positives.
+
+ -- Dmitry Smirnov only...@member.fsf.org Fri, 31 Aug 2012 07:23:07 +1000
+
tupi (0.1+git12-6) unstable; urgency=low
* new patch for ruby1.9 compatibility (Closes: #676121)
* removed '©' characters from debian/copyright
diff --git a/debian/copyright b/debian/copyright
index 2f2231f..83fe56d 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -46,9 +46,9 @@ Copyright: 1998-2005 Gilles Vollant
License: GPL-3+
Files: 3rdparty/quazip/zip.* 3rdparty/quazip/unzip.* 3rdparty/quazip/crypt.h
Copyright: 1998-2005 Gilles Vollant
-Copyright: 1999-2000 Info-ZIP
+ 1999-2000 Info-ZIP
License:
This software is provided 'as-is', without any express or implied
warranty. In no event will the authors be held liable for any damages
arising from the use of this software.
diff --git a/debian/rules b/debian/rules
index c39a567..6cbfaf4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,11 +6,8 @@
PDIR := $(CURDIR)/debian/tupi
QM_FILES := $(patsubst %.ts, %.qm, $(wildcard src/shell/data/translations/*.ts))
-export LFLAGS= -Wl,--as-needed $(LDFLAGS)
-$(info LFLAGS=$(LFLAGS))
-
%:
dh $@
$(QM_FILES):
@@ -41,9 +38,12 @@ override_dh_auto_configure: $(QM_FILES)
--libdir=$(PDIR)/usr/lib/tupi \
--sharedir=$(PDIR)-data/usr/share/tupi \
--includedir=$(PDIR)-dev/usr/include/tupi
# force qmake-generated Makefiles to respect dpkg-provided flags
- perl -pi -e 'local $$/; $$_=; s{((CX?X?|L)FLAGS\s*)=}{$$1+=}g;' `find . -name Makefile`
+ perl -0pi -e 's[(CXXFLAGS\s*=)][$$1 $$ENV{CFLAGS} $$ENV{CPPFLAGS}]; \
+ s[(LFLAGS\s*=)][$$1 -Wl,--as-needed $$ENV{LDFLAGS}]; \
+ s[(CFLAGS\s*=)][$$1 $$ENV{CFLAGS} $$ENV{CPPFLAGS}];' \
+ $$(find . -name Makefile)
override_dh_auto_install:
dh_auto_install
$(RM) $(PDIR)/usr/share/man/man1/tupi.1.gz
@@ -64,6 +64,9 @@ override_dh_makeshlibs:
override_dh_strip:
dh_strip -v --dbg-package=tupi-dbg
+override_dh_builddeb:
+ dh_builddeb -- -Zxz
+
get-orig-source:
uscan --noconf --verbose --force-download --rename --repack --destdir=. --download-current-version
diff --git a/debian/tupi.lintian-overrides b/debian/tupi.lintian-overrides
new file mode 100644
index 000..b1295fd
--- /dev/null
+++ b/debian/tupi.lintian-overrides
@@ -0,0 +1,4 @@
+## false-positives:
+hardening-no-fortify-functions usr/lib/tupi/bin/tupi.bin
+hardening-no-fortify-functions usr/lib/tupi/libtupi.so.1.0.0
+hardening-no-fortify-functions usr/lib/tupi/libtupifwgui.so.1.0.0
signature.asc
Description: This is a digitally signed message part.
Bug#684576: unblock: libssh2/1.4.2-1.1
Dear Adam, I'm happy to report that 'libssh2/1.4.2-1.1' has been uploaded and now after 5 days in 'unstable' it is ready for migration. Thank you. Cheers, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201208201405.33525.only...@member.fsf.org
Bug#685176: unblock: mc/3:4.8.3-5
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package 'mc'
mc/3:4.8.3-5 fixes two regressions from previous versions as per quote from
Changelog:
* new backported patches:
+ to fix Garbage directory listing in ftpfs
(Closes: #681515, #675921).
+ to fix hex search: can't find 00 (zeroes) in patterns.
* mc.desktop is validated with 'desktop-file-validate' and corrected.
As long as I can recall 'ftpfs' was working correctly in Squeeze and this
defect has a potential for data corruption.
Fixes are implemented using backported patches from newer release.
See all the changes in the attached diff.
unblock mc/3:4.8.3-5
Thank you.
Regards,
Dmitry.
diff --git a/debian/changelog b/debian/changelog
index e3c317c..472cfc4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,19 @@
+mc (3:4.8.3-5) unstable; urgency=low
+
+ * 2800.patch is corrected to avoid crash on entering archives.
+
+ -- Dmitry Smirnov only...@member.fsf.org Sun, 05 Aug 2012 21:52:36 +1000
+
+mc (3:4.8.3-4) unstable; urgency=low
+
+ * new backported patches:
++ to fix Garbage directory listing in ftpfs
+ (Closes: #681515, #675921).
++ to fix hex search: can't find 00 (zeroes) in patterns.
+ * mc.desktop is validated with 'desktop-file-validate' and corrected.
+
+ -- Dmitry Smirnov only...@member.fsf.org Sun, 05 Aug 2012 09:51:58 +1000
+
mc (3:4.8.3-3) unstable; urgency=high
* added new backported patch to fix issue which may cause loss of data
diff --git a/debian/mc.desktop b/debian/mc.desktop
index b50456e..f159e65 100644
--- a/debian/mc.desktop
+++ b/debian/mc.desktop
@@ -16,5 +16,4 @@ Exec=mc
Icon=MidnightCommander
Terminal=true
Type=Application
-Categories=ConsoleOnly;Utility;FileManager;
-# vi: encoding=utf-8
+Categories=ConsoleOnly;Utility;FileManager;System;FileTools;
diff --git a/debian/patches/2795.patch b/debian/patches/2795.patch
new file mode 100644
index 000..8a9b2bc
--- /dev/null
+++ b/debian/patches/2795.patch
@@ -0,0 +1,283 @@
+Last-Update: 2012-08-05
+Author: Dmitry Smirnov only...@member.fsf.org
+Applied-Upstream: 2.8.4
+Forwarded: not-needed
+Bug-MC: https://www.midnight-commander.org/ticket/2795
+Description: backported fix for hex search: can't find 00 (zeroes) in patterns
+
+--- a/lib/filehighlight/ini-file-read.c
b/lib/filehighlight/ini-file-read.c
+@@ -162,7 +162,7 @@
+
+ mc_filter = g_new0 (mc_fhl_filter_t, 1);
+ mc_filter-type = MC_FLHGH_T_FREGEXP;
+-mc_filter-search_condition = mc_search_new (buf-str, -1);
++mc_filter-search_condition = mc_search_new (buf-str, buf-len);
+ mc_filter-search_condition-is_case_sensitive =
+ mc_config_get_bool (fhl-config, group_name, extensions_case, TRUE);
+ mc_filter-search_condition-search_type = MC_SEARCH_T_REGEX;
+--- a/lib/search.h
b/lib/search.h
+@@ -13,7 +13,8 @@
+
+ /*** typedefs(not structures) and defined constants **/
+
+-typedef int (*mc_search_fn) (const void *user_data, gsize char_offset);
++typedef int (*mc_search_fn) (const void *user_data, gsize char_offset, int *current_char);
++typedef int (*mc_update_fn) (const void *user_data, gsize char_offset);
+
+ #define MC_SEARCH__NUM_REPLACE_ARGS 64
+
+@@ -77,12 +78,11 @@
+ mc_search_fn search_fn;
+
+ /* function, used for updatin current search status. NULL if not used */
+-mc_search_fn update_fn;
++mc_update_fn update_fn;
+
+ /* type of search */
+ mc_search_type_t search_type;
+
+-
+ /* public output data */
+
+ /* some data for normal */
+--- a/lib/search/internal.h
b/lib/search/internal.h
+@@ -47,7 +47,7 @@
+
+ gchar *mc_search__get_one_symbol (const char *, const char *, gsize, gboolean *);
+
+-int mc_search__get_char (mc_search_t *, const void *, gsize);
++mc_search_cbret_t mc_search__get_char (mc_search_t *, const void *, gsize, int *);
+
+ GString *mc_search__tolower_case_str (const char *, const char *, gsize);
+
+--- a/lib/search/lib.c
b/lib/search/lib.c
+@@ -137,15 +137,18 @@
+
+ /* - */
+
+-int
+-mc_search__get_char (mc_search_t * lc_mc_search, const void *user_data, gsize current_pos)
++mc_search_cbret_t
++mc_search__get_char (mc_search_t * lc_mc_search, const void *user_data, gsize current_pos,
++ int *current_char)
+ {
+-char *data;
+-if (lc_mc_search-search_fn)
+-return (lc_mc_search-search_fn) (user_data, current_pos);
++unsigned char *data;
+
+-data = (char *) user_data;
+-return (int) (unsigned char) data[current_pos];
++if (lc_mc_search-search_fn != NULL)
++return lc_mc_search-search_fn (user_data, current_pos, current_char);
++
++data = (unsigned char *) user_data;
++*current_char = (int) data[current_pos];
++return (*current_char == 0) ? MC_SEARCH_CB_ABORT
Bug#684576: Libssh2: patch Applied-Upstream
Today upstream applied the proposed patch as is, without changes. https://trac.libssh2.org/changeset/e470738a0cf302abfd2891b80dbac4ac3e7eedd2/libssh2 Package is now waiting for sponsor. Thanks. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201208140939.09153.only...@member.fsf.org
Bug#684576: unblock: libssh2/1.4.2-1.1
On Mon, 13 Aug 2012 07:18:50 Adam D. Barratt wrote: Correct, at the moment it's on Mentors: http://mentors.debian.net/package/libssh2 Okay, then you should have made that clear in the mail. Unblock implies that the package is already in unstable. My apologies - I didn't know that. It's my very first 'unblock' request... It looks okay at first glance; the bug report suggests there was already an offer of sponsorship though? So far that person didn't reply... In worst case I might need to file a sponsorship-requests... Given that there's an upstream bug linked from the patch, why hasn't it been sent there as well? I sent the patch upstream over the weekend. However linssh2 bug tracker is pre-moderated so if patch is still not publicly visible the only reason I can think of is that nobody pre-approved new posts to bug tracker yet. Thank you. Regards, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201208131047.02443.only...@member.fsf.org
Bug#684576: unblock: libssh2/1.4.2-1.1
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
Please unblock package libssh2
1.4.2-1.1 fixes two bugs:
#675785 - FTBFS in packages linking with libssh2.
#675782 - safe cosmetic fix bundled with the important change above.
Maintainer of libssh2 advised to proceed with NMU
which was reviewed by Bart Martens who advised to file unblock request.
Changelog entry:
* Non-maintainer upload.
* Added patch to fix pkg-config/libgcrypt dependency (Closes: #675785).
* Install upstream ChangeLog (Closes: #675782).
* debian/control:
+ libssh2-1-dev to depend on libgcrypt11-dev.
+ added Homepage field.
See all the changes in the attached diff.
unblock libssh2/1.4.2-1.1
Thank you.
Regards,
Dmitry.
diff -U2 -Nr libssh2-1.4.2-1/debian/changelog libssh2-1.4.2-1.1/debian/changelog
--- libssh2-1.4.2-1/debian/changelog 2012-05-29 01:42:24.0 +1000
+++ libssh2-1.4.2-1.1/debian/changelog 2012-08-06 18:29:39.0 +1000
@@ -1,2 +1,13 @@
+libssh2 (1.4.2-1.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Added patch to fix pkg-config/libgcrypt dependency (Closes: #675785).
+ * Install upstream ChangeLog (Closes: #675782).
+ * debian/control:
++ libssh2-1-dev to depend on libgcrypt11-dev.
++ added Homepage field.
+
+ -- Dmitry Smirnov only...@member.fsf.org Sat, 04 Aug 2012 19:13:21 +1000
+
libssh2 (1.4.2-1) unstable; urgency=low
diff -U2 -Nr libssh2-1.4.2-1/debian/control libssh2-1.4.2-1.1/debian/control
--- libssh2-1.4.2-1/debian/control 2012-05-29 01:42:24.0 +1000
+++ libssh2-1.4.2-1.1/debian/control 2012-08-04 19:20:15.0 +1000
@@ -5,4 +5,5 @@
Build-Depends: debhelper (= 9), dh-autoreconf, libgcrypt11-dev, zlib1g-dev, chrpath
Standards-Version: 3.9.3
+Homepage: http://libssh2.org/
Package: libssh2-1
@@ -21,5 +22,5 @@
Section: libdevel
Architecture: any
-Depends: libssh2-1 (= ${binary:Version}), ${misc:Depends}
+Depends: libssh2-1 (= ${binary:Version}), ${misc:Depends}, libgcrypt11-dev
Description: SSH2 client-side library (development headers)
libssh2 is a client-side C library implementing the SSH2 protocol.
diff -U2 -Nr libssh2-1.4.2-1/debian/patches/series libssh2-1.4.2-1.1/debian/patches/series
--- libssh2-1.4.2-1/debian/patches/series 1970-01-01 10:00:00.0 +1000
+++ libssh2-1.4.2-1.1/debian/patches/series 2012-08-04 19:17:46.0 +1000
@@ -0,0 +1 @@
+with-libgcrypt.patch
diff -U2 -Nr libssh2-1.4.2-1/debian/patches/with-libgcrypt.patch libssh2-1.4.2-1.1/debian/patches/with-libgcrypt.patch
--- libssh2-1.4.2-1/debian/patches/with-libgcrypt.patch 1970-01-01 10:00:00.0 +1000
+++ libssh2-1.4.2-1.1/debian/patches/with-libgcrypt.patch 2012-08-11 21:01:22.0 +1000
@@ -0,0 +1,20 @@
+Last-Update: 2012-08-04
+Author: Dmitry Smirnov only...@member.fsf.org
+Forwarded: 2012-08-11
+Bug-Debian: http://bugs.debian.org/675785
+Bug-Libssh2: http://trac.libssh2.org/ticket/225
+Description: Fixes pkg-config in libssh2-1-dev
+ This patch addresses the problem causing FTBFS
+ in packages linking with libssh2.
+
+--- a/configure.ac
b/configure.ac
+@@ -102,7 +102,7 @@
+ # Look for libgcrypt
+ if test $ac_cv_libssl != yes test $use_libgcrypt != no; then
+ AC_LIB_HAVE_LINKFLAGS([gcrypt], [], [#include gcrypt.h])
+- LIBSREQUIRED=libgcrypt
++ LIBS=$LIBS -lgcrypt
+ fi
+
+ AC_SUBST(LIBSREQUIRED)
diff -U2 -Nr libssh2-1.4.2-1/debian/rules libssh2-1.4.2-1.1/debian/rules
--- libssh2-1.4.2-1/debian/rules 2012-05-29 01:42:24.0 +1000
+++ libssh2-1.4.2-1.1/debian/rules 2012-08-04 19:38:39.0 +1000
@@ -16,4 +16,7 @@
dh_installexamples -a -X .deps -X Makefile -X .gitignore
+override_dh_installchangelogs:
+ dh_installchangelogs NEWS
+
#
# mansyntax.sh test duplicates functionality of debhelper and requires presence
signature.asc
Description: This is a digitally signed message part.
Bug#684576: unblock: libssh2/1.4.2-1.1
On Sat, 11 Aug 2012 21:36:56 Adam D. Barratt wrote: 1.4.2-1.1 fixes two bugs: and appears not to be in the archive? Correct, at the moment it's on Mentors: http://mentors.debian.net/package/libssh2 Bart Martens advised to get your approvall first, then I hope someone will sponsor. Thanks. Cheers, Dmitry. -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/201208112156.46750.only...@member.fsf.org
