[jira] [Assigned] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ganesh Murthy reassigned DISPATCH-1541:
---
Assignee: Ganesh Murthy
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Assignee: Ganesh Murthy
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> =
> inter-routerout 13
> 2000 00 0 104104 0 000024
> 0 0 250 -
> {noformat}
> {noformat}
> routerB
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
>
> inter-routerin 13
> 250 00 0 83 00 0022 04 0
> 0 250 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[ANNOUNCE] Apache Qpid Broker-J 7.1.7 released
The Apache Qpid (http://qpid.apache.org) community is pleased to announce the immediate availability of Apache Qpid Broker-J 7.1.7. This is the latest release of pure java implementation of messaging broker supporting the Advanced Message Queuing Protocol 1.0 (AMQP 1.0, ISO/IEC 19464, http://www.amqp.org) and legacy AMQP protocols 0-10, 0-91, 0-9 and 0-8. Please visit Qpid project site for more details: http://qpid.apache.org/components/broker-j/index.html The release is available now from our website: http://qpid.apache.org/download.html The release brings a number of improvements and bug fixes. The release notes can be found at: http://qpid.apache.org/releases/qpid-broker-j-7.1.7/release-notes.html Thanks to all involved, Alex - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1397) Doc qdstat state dump
[ https://issues.apache.org/jira/browse/DISPATCH-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-1397. Fix Version/s: 1.10.0 Resolution: Fixed > Doc qdstat state dump > - > > Key: DISPATCH-1397 > URL: https://issues.apache.org/jira/browse/DISPATCH-1397 > Project: Qpid Dispatch > Issue Type: Task > Components: Documentation >Reporter: Ben Hardesty >Priority: Major > Fix For: 1.10.0 > > > Doc the new qdstat --all-routers and --all-entities options, and update the > qdstat man page. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1470) Doc max message size and max connections for a user
[ https://issues.apache.org/jira/browse/DISPATCH-1470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-1470. Fix Version/s: 1.10.0 Resolution: Fixed > Doc max message size and max connections for a user > --- > > Key: DISPATCH-1470 > URL: https://issues.apache.org/jira/browse/DISPATCH-1470 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: 1.10.0 > > > [https://qpid.apache.org/releases/qpid-dispatch-1.9.0/user-guide/index.html#configuring-vhost-policies-router] > describes the resource limits you can apply to a user group. The def list of > attributes is missing the max connections and max message size attributes. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1469) Doc password masking
[ https://issues.apache.org/jira/browse/DISPATCH-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-1469. Fix Version/s: 1.10.0 Resolution: Fixed > Doc password masking > > > Key: DISPATCH-1469 > URL: https://issues.apache.org/jira/browse/DISPATCH-1469 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: 1.10.0 > > > The "passwordFile" attribute has been deprecated in favor of "password" and > "saslPassword", but the new attributes have not been documented consistently. > They should be described consistently in each instance. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1472) qdstat --general option not documented in qdstat man page
[ https://issues.apache.org/jira/browse/DISPATCH-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-1472. Fix Version/s: 1.10.0 Resolution: Fixed > qdstat --general option not documented in qdstat man page > - > > Key: DISPATCH-1472 > URL: https://issues.apache.org/jira/browse/DISPATCH-1472 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Affects Versions: 1.9.0 >Reporter: Ganesh Murthy >Assignee: Ben Hardesty >Priority: Major > Fix For: 1.10.0 > > > The qdstat command's man page does not document the qdstat -g option. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1144) Improve overview and getting started doc
[ https://issues.apache.org/jira/browse/DISPATCH-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-1144. Fix Version/s: 1.8.0 Resolution: Fixed > Improve overview and getting started doc > > > Key: DISPATCH-1144 > URL: https://issues.apache.org/jira/browse/DISPATCH-1144 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: 1.8.0 > > > Improve the Dispatch Router doc so that a user can quickly get up to speed > and get started with the router. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-852) Add dispatch router installation procedure to main book
[ https://issues.apache.org/jira/browse/DISPATCH-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-852. --- Resolution: Fixed > Add dispatch router installation procedure to main book > --- > > Key: DISPATCH-852 > URL: https://issues.apache.org/jira/browse/DISPATCH-852 > Project: Qpid Dispatch > Issue Type: Sub-task > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: Backlog > > > The QDR installation procedure [1] should be included in the main Dispatch > Router book. It should include both installing from source and installing > from a package on Linux [2]. > [1] - > https://git-wip-us.apache.org/repos/asf?p=qpid-dispatch.git;a=blob_plain;f=README;hb=0.8.0 > [2] - https://qpid.apache.org/packages.html -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-850) Implement new Dispatch Router Book
[ https://issues.apache.org/jira/browse/DISPATCH-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Hardesty resolved DISPATCH-850. --- Resolution: Fixed > Implement new Dispatch Router Book > -- > > Key: DISPATCH-850 > URL: https://issues.apache.org/jira/browse/DISPATCH-850 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Documentation >Reporter: Ben Hardesty >Assignee: Ben Hardesty >Priority: Major > Fix For: Backlog > > > A new Dispatch Router user guide is available in /doc/new-book/. This new doc > needs to be made available on the Qpid Dispatch website, and integrated into > the Dispatch Router build tooling. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016344#comment-17016344
]
ASF GitHub Bot commented on DISPATCH-1541:
--
codecov-io commented on issue #663: DISPATCH-1541: Sets the presettled flag on
large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#issuecomment-574796328
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=h1)
Report
> Merging
[#663](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc)
will **increase** coverage by `0.13%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree)
```diff
@@Coverage Diff @@
## master #663 +/- ##
==
+ Coverage 86.47% 86.61% +0.13%
==
Files 92 92
Lines 2102221027 +5
==
+ Hits1817918212 +33
+ Misses 2843 2815 -28
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.03% <100%> (+0.62%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.24% <100%> (+0.01%)` | :arrow_up: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.17% <0%> (-0.19%)` | :arrow_down: |
|
[src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j)
| `86.73% <0%> (+0.12%)` | :arrow_up: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `94.12% <0%> (+0.22%)` | :arrow_up: |
|
[src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==)
| `91.3% <0%> (+0.39%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `93.9% <0%> (+0.48%)` | :arrow_up: |
|
[src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j)
| `71.22% <0%> (+0.58%)` | :arrow_up: |
| ... and [3
more](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree-more)
| |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=footer).
Last update
[992cf13...a2c3ca5](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer
[jira] [Commented] (DISPATCH-1435) Special handling of SSL password text is not documented nor consistent with SASL
[ https://issues.apache.org/jira/browse/DISPATCH-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016347#comment-17016347 ] Ben Hardesty commented on DISPATCH-1435: [~kgiusti] I believe this was resolved in DISPATCH-1440, and doc'd in DISPATCH-1469. If so, can we close this jira? > Special handling of SSL password text is not documented nor consistent with > SASL > > > Key: DISPATCH-1435 > URL: https://issues.apache.org/jira/browse/DISPATCH-1435 > Project: Qpid Dispatch > Issue Type: Bug > Components: Documentation, Management Agent >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Priority: Minor > > The router currently checks the SSL password for the prefixes "env:" or > "literal:" - see > [qd_config_ssl_profile_process_password()|https://github.com/apache/qpid-dispatch/blob/master/src/connection_manager.c#L213] > Two issues with this: > 1) It is not documented. It needs to be documented in the qdrouter.json file > as well as in the configuration section of the user guide > 2) the SASL password does not provide the same feature - should it be added > there as well? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded …
codecov-io edited a comment on issue #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded … URL: https://github.com/apache/qpid-dispatch/pull/663#issuecomment-574796328 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=h1) Report > Merging [#663](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc) will **increase** coverage by `0.13%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) ```diff @@Coverage Diff @@ ## master #663 +/- ## == + Coverage 86.47% 86.61% +0.13% == Files 92 92 Lines 2102221027 +5 == + Hits1817918212 +33 + Misses 2843 2815 -28 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.03% <100%> (+0.62%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.24% <100%> (+0.01%)` | :arrow_up: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.19%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.73% <0%> (+0.12%)` | :arrow_up: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.12% <0%> (+0.22%)` | :arrow_up: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `91.3% <0%> (+0.39%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.9% <0%> (+0.48%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `71.22% <0%> (+0.58%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=footer). Last update [992cf13...a2c3ca5](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[ https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016342#comment-17016342 ] ASF GitHub Bot commented on DISPATCH-1513: -- codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1) Report > Merging [#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) ```diff @@Coverage Diff @@ ## master #660 +/- ## == + Coverage 86.53% 86.57% +0.03% == Files 91 92 +1 Lines 2065221022 +370 == + Hits1787218200 +328 - Misses 2780 2822 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `70.63% <0%> (-5.05%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `80.55% <0%> (-3.71%)` | :arrow_down: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.65% <0%> (-0.8%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.17%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.11% <0%> (-0.04%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85% <0%> (ø)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0%> (ø)` | :arrow_up: | | [src/router\_core/core\_events.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfZXZlbnRzLmM=) | `100% <0%> (ø)` | :arrow_up: | | [...uter\_core/modules/edge\_router/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvY29ubmVjdGlvbl9tYW5hZ2VyLmM=) | `96.87% <0%> (ø)` | :arrow_up: | | [src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j) | `91.83% <0%> (ø)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer). Last update [655145d...54aeeae](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > system_tests_http failing with libwebsockets 3.2 on Fedora 31 > - > > Key: DISPATCH-1513 > URL: https://issues.apache.org/jira/browse/DISPATCH-1513 > Project: Qpid Dispatch >
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
codecov-io edited a comment on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1) Report > Merging [#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) ```diff @@Coverage Diff @@ ## master #660 +/- ## == + Coverage 86.53% 86.57% +0.03% == Files 91 92 +1 Lines 2065221022 +370 == + Hits1787218200 +328 - Misses 2780 2822 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `70.63% <0%> (-5.05%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `80.55% <0%> (-3.71%)` | :arrow_down: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.65% <0%> (-0.8%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.17%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.11% <0%> (-0.04%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85% <0%> (ø)` | :arrow_up: | | [...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j) | `78.69% <0%> (ø)` | :arrow_up: | | [src/router\_core/core\_events.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfZXZlbnRzLmM=) | `100% <0%> (ø)` | :arrow_up: | | [...uter\_core/modules/edge\_router/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvY29ubmVjdGlvbl9tYW5hZ2VyLmM=) | `96.87% <0%> (ø)` | :arrow_up: | | [src/router\_core/modules/edge\_router/addr\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvYWRkcl9wcm94eS5j) | `91.83% <0%> (ø)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer). Last update [655145d...54aeeae](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (QPIDIT-138) Change Amqp.netlite shims to run on dotnet
[ https://issues.apache.org/jira/browse/QPIDIT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet resolved QPIDIT-138. - Resolution: Fixed > Change Amqp.netlite shims to run on dotnet > -- > > Key: QPIDIT-138 > URL: https://issues.apache.org/jira/browse/QPIDIT-138 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > Currently, amqp.netlite shims are compiled and run with mono. Change to using > dotnet core v.2.1 (and possibly v.3.1). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (QPIDIT-138) Change Amqp.netlite shims to run on dotnet
[ https://issues.apache.org/jira/browse/QPIDIT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016322#comment-17016322 ] ASF subversion and git services commented on QPIDIT-138: Commit 9a39c6b10b3cadd70d80fc2be2c984bb73094bcc in qpid-interop-test's branch refs/heads/master from Kim van der Riet [ https://gitbox.apache.org/repos/asf?p=qpid-interop-test.git;h=9a39c6b ] QPIDIT-138: Changed amqp.netlite shims to use dotnet rather than mono > Change Amqp.netlite shims to run on dotnet > -- > > Key: QPIDIT-138 > URL: https://issues.apache.org/jira/browse/QPIDIT-138 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > Currently, amqp.netlite shims are compiled and run with mono. Change to using > dotnet core v.2.1 (and possibly v.3.1). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (QPIDIT-138) Change Amqp.netlite shims to run on dotnet
[ https://issues.apache.org/jira/browse/QPIDIT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim van der Riet reassigned QPIDIT-138: --- Assignee: Kim van der Riet > Change Amqp.netlite shims to run on dotnet > -- > > Key: QPIDIT-138 > URL: https://issues.apache.org/jira/browse/QPIDIT-138 > Project: Apache QPID Interoperability Test Suite > Issue Type: Task >Reporter: Kim van der Riet >Assignee: Kim van der Riet >Priority: Major > > Currently, amqp.netlite shims are compiled and run with mono. Change to using > dotnet core v.2.1 (and possibly v.3.1). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Created] (QPIDIT-138) Change Amqp.netlite shims to run on dotnet
Kim van der Riet created QPIDIT-138: --- Summary: Change Amqp.netlite shims to run on dotnet Key: QPIDIT-138 URL: https://issues.apache.org/jira/browse/QPIDIT-138 Project: Apache QPID Interoperability Test Suite Issue Type: Task Reporter: Kim van der Riet Currently, amqp.netlite shims are compiled and run with mono. Change to using dotnet core v.2.1 (and possibly v.3.1). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016314#comment-17016314
]
ASF GitHub Bot commented on DISPATCH-1513:
--
ganeshmurthy commented on pull request #660: DISPATCH-1513 - Fixed router crash
when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367099480
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
We do have c code that is conditionally compiled using an extra flag based
on the version of LWS available on the system. The python tests have to be
dealt with separately as well, so we test the version in the
cmake/FindLibWebSockets.cmake file
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
ganeshmurthy commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367099480
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
We do have c code that is conditionally compiled using an extra flag based
on the version of LWS available on the system. The python tests have to be
dealt with separately as well, so we test the version in the
cmake/FindLibWebSockets.cmake file
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Updated] (QPID-8399) [Broker-J] Release Qpid Broker-J version 7.1.7
[ https://issues.apache.org/jira/browse/QPID-8399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8399: - Status: Reviewable (was: In Progress) > [Broker-J] Release Qpid Broker-J version 7.1.7 > -- > > Key: QPID-8399 > URL: https://issues.apache.org/jira/browse/QPID-8399 > Project: Qpid > Issue Type: Task > Components: Broker-J >Reporter: Alex Rudyy >Assignee: Alex Rudyy >Priority: Major > Fix For: qpid-java-broker-7.1.7 > > > Release Qpid Broker-J version 7.1.7 as per instructions at > [https://github.com/apache/qpid-broker-j/blob/master/doc/developer-guide/src/main/markdown/release-instructions.md] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016284#comment-17016284
]
ASF GitHub Bot commented on DISPATCH-1541:
--
kgiusti commented on pull request #663: DISPATCH-1541: Sets the presettled flag
on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#discussion_r367074784
##
File path: src/router_node.c
##
@@ -355,6 +355,16 @@ static bool AMQP_rx_handler(void* context, qd_link_t
*link)
// Message has been marked for discard, no further processing necessary
//
if (receive_complete) {
+// If this discarded delivery has already been settled by proton,
+// set the presettled flag on the delivery to true if it is not
already true.
+// Since the entire message has already been received, we directly
call the
+// function to set the pre-settled flag since we cannot go thru
the core-thread
+// to do this since the delivery has been discarded.
+// Discarded streaming deliveries are not put thru the core thread
via the continue action.
+if (pn_delivery_settled(pnd))
+qdr_delivery_set_presettled(delivery);
Review comment:
Careful! the delivery pointer may be null here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> =
> inter-routerout 13
> 2000 00 0 104104 0 000024
> 0 0 250 -
> {noformat}
> {noformat}
> routerB
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
>
> inter-routerin 13
> 250 00 0 83 00 0022 04 0
> 0 250 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016283#comment-17016283
]
ASF GitHub Bot commented on DISPATCH-1541:
--
kgiusti commented on pull request #663: DISPATCH-1541: Sets the presettled flag
on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#discussion_r367075860
##
File path: src/router_core/delivery.c
##
@@ -124,6 +124,11 @@ bool qdr_delivery_is_aborted(const qdr_delivery_t
*delivery)
return qd_message_aborted(delivery->msg);
}
+void qdr_delivery_set_presettled(qdr_delivery_t *delivery)
+{
+if (! delivery->presettled)
+delivery->presettled = true;
Review comment:
Why the conditional check - it's not necessary. Simply set
delivery->presettled.
Or change the check to be sure delivery != 0 instead up to you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> =
> inter-routerout 13
> 2000 00 0 104104 0 000024
> 0 0 250 -
> {noformat}
> {noformat}
> routerB
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
>
> inter-routerin 13
> 250 00 0 83 00 0022 04 0
> 0 250 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded …
kgiusti commented on a change in pull request #663: DISPATCH-1541: Sets the
presettled flag on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#discussion_r367074784
##
File path: src/router_node.c
##
@@ -355,6 +355,16 @@ static bool AMQP_rx_handler(void* context, qd_link_t
*link)
// Message has been marked for discard, no further processing necessary
//
if (receive_complete) {
+// If this discarded delivery has already been settled by proton,
+// set the presettled flag on the delivery to true if it is not
already true.
+// Since the entire message has already been received, we directly
call the
+// function to set the pre-settled flag since we cannot go thru
the core-thread
+// to do this since the delivery has been discarded.
+// Discarded streaming deliveries are not put thru the core thread
via the continue action.
+if (pn_delivery_settled(pnd))
+qdr_delivery_set_presettled(delivery);
Review comment:
Careful! the delivery pointer may be null here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded …
kgiusti commented on a change in pull request #663: DISPATCH-1541: Sets the
presettled flag on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#discussion_r367075860
##
File path: src/router_core/delivery.c
##
@@ -124,6 +124,11 @@ bool qdr_delivery_is_aborted(const qdr_delivery_t
*delivery)
return qd_message_aborted(delivery->msg);
}
+void qdr_delivery_set_presettled(qdr_delivery_t *delivery)
+{
+if (! delivery->presettled)
+delivery->presettled = true;
Review comment:
Why the conditional check - it's not necessary. Simply set
delivery->presettled.
Or change the check to be sure delivery != 0 instead up to you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
ChugR commented on a change in pull request #660: DISPATCH-1513 - Fixed router
crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367075938
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
These are compile-time tests that build software with or without some
features. Don't we really want code that is compiled to handle both cases and
then detect what to do at run-time?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016281#comment-17016281
]
ASF GitHub Bot commented on DISPATCH-1513:
--
ChugR commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367075938
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
These are compile-time tests that build software with or without some
features. Don't we really want code that is compiled to handle both cases and
then detect what to do at run-time?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail:
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016272#comment-17016272
]
ASF GitHub Bot commented on DISPATCH-1513:
--
kgiusti commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367072994
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
"runnung"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016271#comment-17016271
]
ASF GitHub Bot commented on DISPATCH-1513:
--
kgiusti commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367073048
##
File path: src/http-libwebsockets.c
##
@@ -354,7 +354,11 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
+#if (LWS_LIBRARY_VERSION_MAJOR == 3 && LWS_LIBRARY_VERSION_MINOR >= 2)
Review comment:
What happens when LWS_LIBRARY_VERSION_MAJOR == 4?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367073048
##
File path: src/http-libwebsockets.c
##
@@ -354,7 +354,11 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
+#if (LWS_LIBRARY_VERSION_MAJOR == 3 && LWS_LIBRARY_VERSION_MINOR >= 2)
Review comment:
What happens when LWS_LIBRARY_VERSION_MAJOR == 4?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r367072994
##
File path: tests/system_tests_http.py.in
##
@@ -250,8 +250,9 @@ def listener(**kwargs):
self.assert_get("https://localhost:%s; % r.ports[0])
# requireSsl=false Allows simple-ssl HTTP
-# Commenting out the following assert until DISPATCH-1513 is fixed.
-#self.assert_get("http://localhost:%s; % r.ports[0])
+# The following test will be commented out if you are runnung a
version lower than
Review comment:
"runnung"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016260#comment-17016260
]
ASF subversion and git services commented on DISPATCH-1488:
---
Commit 2536f69c58166e4c746a2d173509da238fae59b0 in qpid-dispatch's branch
refs/heads/master from Ken Giusti
[ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=2536f69 ]
DISPATCH-1488: add test to verify transanction handling
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[
https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016258#comment-17016258
]
ASF GitHub Bot commented on DISPATCH-1488:
--
kgiusti commented on pull request #638: DISPATCH-1488: add test to verify
transanction handling
URL: https://github.com/apache/qpid-dispatch/pull/638
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> link-routed transaction coordination broken due to 'declared' state truncation
> --
>
> Key: DISPATCH-1488
> URL: https://issues.apache.org/jira/browse/DISPATCH-1488
> Project: Qpid Dispatch
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.10.0
>Reporter: Robbie Gemmell
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 1.10.0
>
>
> The 1.9.0 release and current master for 1.10.0 both truncate the 'declared'
> transaction delivery state when routing a transaction coordinator link to a
> broker peer, omitting the contained txn-id and breaking all ability to link
> route transactional work through the router.
> Some output while trying this to debug an unrelated issue is detailed below.
> First, a message transfer arrives at the router with body requesting a
> transaction declare. The router sends the link-routed transfer onward to the
> broker:
> {noformat}
> [0x2251560]:1 <- @transfer(20) [handle=0, delivery-id=0,
> delivery-tag=b"\x00", message-format=0, settled=false] (7) "\x00Sw\x00S1E"
> [0x21ddf40]:0 -> @transfer(20) [handle=1, delivery-id=0,
> delivery-tag=b"\x00", message-format=0] (7) "\x00Sw\x00S1E"
> {noformat}
> (Not shown, after the above in the case being debugged, there was a
> non-transactional transfer on a second session across the same client->router
> connection, then forwarded on the same router->broker connection).
> The broker peer establishes a transaction and responds with disposition to
> indicate it is declared, and providing the mandatory txn-id. The router
> relays this disposition, but critically drops the txn-id from the delivery
> state:
> {noformat}
> [0x21ddf40]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"4a12a39a-09fe-11ea-91ae-000c29e9f622"]]
> [0x2251560]:1 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) null]
> {noformat}
> The recipient client then barfs at this point since txn-id is mandatory for
> the declared state.
> Using 1.8.0, the declared state transited the router fine:
> {noformat}
> [0x1f49530]:0 <- @disposition(21) [role=true, first=0, last=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> [0x1fc2b20]:2 -> @disposition(21) [role=true, first=0, settled=true,
> state=@declared(51) [txn-id=b"78dabc4f-0a00-11ea-bb46-000c29e9f622"]]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti merged pull request #638: DISPATCH-1488: add test to verify transanction handling
kgiusti merged pull request #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1488) link-routed transaction coordination broken due to 'declared' state truncation
[ https://issues.apache.org/jira/browse/DISPATCH-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016256#comment-17016256 ] ASF GitHub Bot commented on DISPATCH-1488: -- codecov-io commented on issue #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561209005 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=h1) Report > Merging [#638](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc) will **increase** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) ```diff @@Coverage Diff @@ ## master #638 +/- ## == + Coverage 86.47% 86.57% +0.09% == Files 92 92 Lines 2102221022 == + Hits1817918200 +21 + Misses 2843 2822 -21 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.19%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.73% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.12% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.98% <0%> (+0.56%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `71.22% <0%> (+0.58%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.68%)` | :arrow_up: | | [src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=) | `88.97% <0%> (+0.78%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0%> (+1.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=footer). Last update [992cf13...e1b5df7](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > link-routed transaction coordination broken due to 'declared' state truncation > -- > > Key: DISPATCH-1488 > URL: https://issues.apache.org/jira/browse/DISPATCH-1488 > Project: Qpid Dispatch > Issue Type: Bug >Affects Versions: 1.9.0, 1.10.0 >Reporter: Robbie Gemmell >Assignee: Ken Giusti >Priority: Blocker > Fix For: 1.10.0 > > > The 1.9.0 release and current master for 1.10.0 both truncate the 'declared' > transaction delivery state when routing a transaction coordinator link to a > broker peer, omitting the contained txn-id and breaking all ability to link > route transactional work through the router. > Some output while trying this to debug an unrelated issue is detailed below. > First, a message transfer arrives at the router with body requesting a > transaction declare. The router sends the link-routed transfer onward
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #638: DISPATCH-1488: add test to verify transanction handling
codecov-io edited a comment on issue #638: DISPATCH-1488: add test to verify transanction handling URL: https://github.com/apache/qpid-dispatch/pull/638#issuecomment-561209005 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=h1) Report > Merging [#638](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc) will **increase** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) ```diff @@Coverage Diff @@ ## master #638 +/- ## == + Coverage 86.47% 86.57% +0.09% == Files 92 92 Lines 2102221022 == + Hits1817918200 +21 + Misses 2843 2822 -21 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.19%)` | :arrow_down: | | [src/server.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3NlcnZlci5j) | `86.73% <0%> (+0.12%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `94.12% <0%> (+0.22%)` | :arrow_up: | | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `89.98% <0%> (+0.56%)` | :arrow_up: | | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `71.22% <0%> (+0.58%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.68%)` | :arrow_up: | | [src/router\_core/terminus.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3Rlcm1pbnVzLmM=) | `88.97% <0%> (+0.78%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/638/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0%> (+1.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=footer). Last update [992cf13...e1b5df7](https://codecov.io/gh/apache/qpid-dispatch/pull/638?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] codecov-io edited a comment on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
codecov-io edited a comment on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1) Report > Merging [#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) ```diff @@Coverage Diff @@ ## master #660 +/- ## == - Coverage 86.53% 86.53% -0.01% == Files 91 92 +1 Lines 2065221022 +370 == + Hits1787218192 +320 - Misses 2780 2830 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `70.63% <0%> (-5.05%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `80.55% <0%> (-3.71%)` | :arrow_down: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.65% <0%> (-0.8%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.79% <0%> (-0.21%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.16% <0%> (-0.19%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.17%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.8% <0%> (-0.1%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.11% <0%> (-0.04%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85% <0%> (ø)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer). Last update [655145d...65f2f16](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[ https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016243#comment-17016243 ] ASF GitHub Bot commented on DISPATCH-1513: -- codecov-io commented on issue #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#issuecomment-573859128 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=h1) Report > Merging [#660](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/655145d8e5c9d3a947e407e8bbf08deb13830db3?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) ```diff @@Coverage Diff @@ ## master #660 +/- ## == - Coverage 86.53% 86.53% -0.01% == Files 91 92 +1 Lines 2065221022 +370 == + Hits1787218192 +320 - Misses 2780 2830 +50 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/route\_tables.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlX3RhYmxlcy5j) | `70.63% <0%> (-5.05%)` | :arrow_down: | | [src/router\_pynode.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9weW5vZGUuYw==) | `80.55% <0%> (-3.71%)` | :arrow_down: | | [src/python\_embedded.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3B5dGhvbl9lbWJlZGRlZC5j) | `77.65% <0%> (-0.8%)` | :arrow_down: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `93.17% <0%> (-0.74%)` | :arrow_down: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.79% <0%> (-0.21%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.16% <0%> (-0.19%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.17% <0%> (-0.17%)` | :arrow_down: | | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL21lc3NhZ2UuYw==) | `90.8% <0%> (-0.1%)` | :arrow_down: | | [src/router\_core/exchange\_bindings.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2V4Y2hhbmdlX2JpbmRpbmdzLmM=) | `91.11% <0%> (-0.04%)` | :arrow_down: | | [src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=) | `85% <0%> (ø)` | :arrow_up: | | ... and [13 more](https://codecov.io/gh/apache/qpid-dispatch/pull/660/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=footer). Last update [655145d...65f2f16](https://codecov.io/gh/apache/qpid-dispatch/pull/660?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > system_tests_http failing with libwebsockets 3.2 on Fedora 31 > - > > Key: DISPATCH-1513 > URL: https://issues.apache.org/jira/browse/DISPATCH-1513 > Project: Qpid Dispatch > Issue Type: Bug > Components: Tests >Reporter: Ganesh Murthy >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Fedora 31 has the latest
[GitHub] [qpid-dispatch] kgiusti closed pull request #501: DISPATCH-1310: refactor delivery peer handling
kgiusti closed pull request #501: DISPATCH-1310: refactor delivery peer handling URL: https://github.com/apache/qpid-dispatch/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on issue #501: DISPATCH-1310: refactor delivery peer handling
kgiusti commented on issue #501: DISPATCH-1310: refactor delivery peer handling URL: https://github.com/apache/qpid-dispatch/pull/501#issuecomment-574800659 Closing as this is far too stale. The corresponding JIRA DISPATCH-1310 remains open. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016229#comment-17016229 ] ASF GitHub Bot commented on DISPATCH-1310: -- kgiusti commented on issue #501: DISPATCH-1310: refactor delivery peer handling URL: https://github.com/apache/qpid-dispatch/pull/501#issuecomment-574800659 Closing as this is far too stale. The corresponding JIRA DISPATCH-1310 remains open. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: delivery-refactor > > In the current design all changes to a delivery's disposition and settlement > state has to move through the core thread. > Contrast this with the data associated with a delivery (held in the message > content object) - data is moved between I/O threads without passing through > the core thread. > Moving the disposition and settlement state propagation to the I/O threads > (like delivery data) will simplify its synchronization (2 thread rather than > 3) and will (likely) improve performance. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1310) Move delivery settlement and disposition propagation out of the core thread
[ https://issues.apache.org/jira/browse/DISPATCH-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016230#comment-17016230 ] ASF GitHub Bot commented on DISPATCH-1310: -- kgiusti commented on pull request #501: DISPATCH-1310: refactor delivery peer handling URL: https://github.com/apache/qpid-dispatch/pull/501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Move delivery settlement and disposition propagation out of the core thread > --- > > Key: DISPATCH-1310 > URL: https://issues.apache.org/jira/browse/DISPATCH-1310 > Project: Qpid Dispatch > Issue Type: Improvement > Components: Router Node >Affects Versions: 1.6.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Labels: delivery-refactor > > In the current design all changes to a delivery's disposition and settlement > state has to move through the core thread. > Contrast this with the data associated with a delivery (held in the message > content object) - data is moved between I/O threads without passing through > the core thread. > Moving the disposition and settlement state propagation to the I/O threads > (like delivery data) will simplify its synchronization (2 thread rather than > 3) and will (likely) improve performance. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016220#comment-17016220
]
ASF GitHub Bot commented on DISPATCH-1541:
--
codecov-io commented on issue #663: DISPATCH-1541: Sets the presettled flag on
large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663#issuecomment-574796328
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=h1)
Report
> Merging
[#663](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=desc) into
[master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc)
will **increase** coverage by `0.08%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree)
```diff
@@Coverage Diff @@
## master #663 +/- ##
==
+ Coverage 86.47% 86.56% +0.08%
==
Files 92 92
Lines 2102221026 +4
==
+ Hits1817918201 +22
+ Misses 2843 2825 -18
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `90.03% <100%> (+0.62%)` | :arrow_up: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.24% <100%> (+0.01%)` | :arrow_up: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `93.79% <0%> (-0.12%)` | :arrow_down: |
|
[src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=)
| `89.34% <0%> (-0.02%)` | :arrow_down: |
|
[src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j)
| `82.35% <0%> (+0.18%)` | :arrow_up: |
|
[src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j)
| `95.17% <0%> (+0.68%)` | :arrow_up: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `94.14% <0%> (+0.73%)` | :arrow_up: |
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `86.57% <0%> (+1.75%)` | :arrow_up: |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=footer).
Last update
[992cf13...5cfd769](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
>
[GitHub] [qpid-dispatch] codecov-io commented on issue #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded …
codecov-io commented on issue #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded … URL: https://github.com/apache/qpid-dispatch/pull/663#issuecomment-574796328 # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=h1) Report > Merging [#663](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/992cf139319bddd72442846583540f52b4e7d193?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) ```diff @@Coverage Diff @@ ## master #663 +/- ## == + Coverage 86.47% 86.56% +0.08% == Files 92 92 Lines 2102221026 +4 == + Hits1817918201 +22 + Misses 2843 2825 -18 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=) | `90.03% <100%> (+0.62%)` | :arrow_up: | | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `93.24% <100%> (+0.01%)` | :arrow_up: | | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `93.79% <0%> (-0.12%)` | :arrow_down: | | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `89.34% <0%> (-0.02%)` | :arrow_down: | | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL2NvbnRhaW5lci5j) | `82.35% <0%> (+0.18%)` | :arrow_up: | | [src/router\_core/forwarder.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL2ZvcndhcmRlci5j) | `95.17% <0%> (+0.68%)` | :arrow_up: | | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `94.14% <0%> (+0.73%)` | :arrow_up: | | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/663/diff?src=pr=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `86.57% <0%> (+1.75%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=footer). Last update [992cf13...5cfd769](https://codecov.io/gh/apache/qpid-dispatch/pull/663?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1541) released and modified counters can get incremented for presettled deliveries
[
https://issues.apache.org/jira/browse/DISPATCH-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016176#comment-17016176
]
ASF GitHub Bot commented on DISPATCH-1541:
--
ganeshmurthy commented on pull request #663: DISPATCH-1541: Sets the presettled
flag on large streaming discarded …
URL: https://github.com/apache/qpid-dispatch/pull/663
…messages. This will help set the correct presettled related counters on the
link
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> released and modified counters can get incremented for presettled deliveries
>
>
> Key: DISPATCH-1541
> URL: https://issues.apache.org/jira/browse/DISPATCH-1541
> Project: Qpid Dispatch
> Issue Type: Bug
>Reporter: Gordon Sim
>Priority: Major
>
> Have two routers with sender on one, receiver on other. Send multi-frame
> presettled messages. Kill both sender and receiver midstream (can't get a
> super simple reproducer as yet) and keep repeating. Eventually may see
> non-zero rel and mod stats on downstream router even though messages are
> presettled.
>
> {noformat}
> routerA
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
> =
> inter-routerout 13
> 2000 00 0 104104 0 000024
> 0 0 250 -
> {noformat}
> {noformat}
> routerB
> Router Links
> typedir conn id id peer class addr phs
> cap pri undel unsett deliv presett psdrop acc rej rel mod delay
> rate stuck cred blkd
>
>
> inter-routerin 13
> 250 00 0 83 00 0022 04 0
> 0 250 -
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded …
ganeshmurthy opened a new pull request #663: DISPATCH-1541: Sets the presettled flag on large streaming discarded … URL: https://github.com/apache/qpid-dispatch/pull/663 …messages. This will help set the correct presettled related counters on the link This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1544) Coverity false positive use-after-free error
[ https://issues.apache.org/jira/browse/DISPATCH-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016119#comment-17016119 ] ASF subversion and git services commented on DISPATCH-1544: --- Commit 992cf139319bddd72442846583540f52b4e7d193 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=992cf13 ] DISPATCH-1544: mask coverity false positive delivery use-after-free > Coverity false positive use-after-free error > > > Key: DISPATCH-1544 > URL: https://issues.apache.org/jira/browse/DISPATCH-1544 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > > Coverity static analysis has started reporting use-after-free errors in the > delivery state update logic. I've reviewed these errors and I believe these > are false positives. I suspect that Coverity doesn't have enough context to > understand the delivery refcount management done by this code to prevent > use-after-free of the reported deliveries. > I've created a patch that adds assert checking of the refcounts to enforce > the ownership state expected by the code. This appears to "fix" the coverity > issue in so much as when a CMAKE_BUILD_TYPE=Debug build is submitted for > analysis (the asserts are present in Debug) the errors are resolved. > Non-Debug builds still report the error however so I'm also going update the > patch to include annotations to ignore the errors. > I'm opening this Jira to solicit additional eyes on the problem in case I'm > missing something and these errors are legit. > > - > 4 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity > Scan. > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > * > ** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Calling "qdr_delivery_settled_CT" dereferences freed pointer "dlv". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Passing freed pointer "dlv" as an argument to "qdr_delivery_settled_CT". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > * > ** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > 743 // > 744 if (dlv_moved) > 745 qdr_delivery_decref_CT(core, dlv, "qdr_delivery_anycast_update CT - dlv > removed from unsettled"); > 746 if (peer_moved) > 747 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > peer removed from unsettled"); > 748 if (peer) > >>> CID 353021: (USE_AFTER_FREE) > >>> Passing freed pointer "peer" as an argument to "qdr_delivery_decref_CT". > 749 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > allow free of peer"); > 750 > 751 return error_assigned; > 752 } > 753 > 754 > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > 735 if (dlink &&
[jira] [Resolved] (DISPATCH-1544) Coverity false positive use-after-free error
[ https://issues.apache.org/jira/browse/DISPATCH-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1544. -- Resolution: Fixed > Coverity false positive use-after-free error > > > Key: DISPATCH-1544 > URL: https://issues.apache.org/jira/browse/DISPATCH-1544 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > > Coverity static analysis has started reporting use-after-free errors in the > delivery state update logic. I've reviewed these errors and I believe these > are false positives. I suspect that Coverity doesn't have enough context to > understand the delivery refcount management done by this code to prevent > use-after-free of the reported deliveries. > I've created a patch that adds assert checking of the refcounts to enforce > the ownership state expected by the code. This appears to "fix" the coverity > issue in so much as when a CMAKE_BUILD_TYPE=Debug build is submitted for > analysis (the asserts are present in Debug) the errors are resolved. > Non-Debug builds still report the error however so I'm also going update the > patch to include annotations to ignore the errors. > I'm opening this Jira to solicit additional eyes on the problem in case I'm > missing something and these errors are legit. > > - > 4 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity > Scan. > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > * > ** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Calling "qdr_delivery_settled_CT" dereferences freed pointer "dlv". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Passing freed pointer "dlv" as an argument to "qdr_delivery_settled_CT". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > * > ** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > 743 // > 744 if (dlv_moved) > 745 qdr_delivery_decref_CT(core, dlv, "qdr_delivery_anycast_update CT - dlv > removed from unsettled"); > 746 if (peer_moved) > 747 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > peer removed from unsettled"); > 748 if (peer) > >>> CID 353021: (USE_AFTER_FREE) > >>> Passing freed pointer "peer" as an argument to "qdr_delivery_decref_CT". > 749 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > allow free of peer"); > 750 > 751 return error_assigned; > 752 } > 753 > 754 > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > 735 if (dlink && dlink->core_endpoint) > 736 qdrc_endpoint_do_update_CT(core, dlink->core_endpoint, dlv, settled); > 737 > 738 if (push || peer_moved) > >>> CID 353021: (USE_AFTER_FREE) > >>> Passing freed pointer "peer" as an argument to "qdr_delivery_push_CT". > 739 qdr_delivery_push_CT(core, peer); > 740 > 741 // >
[GitHub] [qpid-dispatch] kgiusti merged pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
kgiusti merged pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1544) Coverity false positive use-after-free error
[ https://issues.apache.org/jira/browse/DISPATCH-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016118#comment-17016118 ] ASF GitHub Bot commented on DISPATCH-1544: -- kgiusti commented on pull request #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Coverity false positive use-after-free error > > > Key: DISPATCH-1544 > URL: https://issues.apache.org/jira/browse/DISPATCH-1544 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > > Coverity static analysis has started reporting use-after-free errors in the > delivery state update logic. I've reviewed these errors and I believe these > are false positives. I suspect that Coverity doesn't have enough context to > understand the delivery refcount management done by this code to prevent > use-after-free of the reported deliveries. > I've created a patch that adds assert checking of the refcounts to enforce > the ownership state expected by the code. This appears to "fix" the coverity > issue in so much as when a CMAKE_BUILD_TYPE=Debug build is submitted for > analysis (the asserts are present in Debug) the errors are resolved. > Non-Debug builds still report the error however so I'm also going update the > patch to include annotations to ignore the errors. > I'm opening this Jira to solicit additional eyes on the problem in case I'm > missing something and these errors are legit. > > - > 4 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity > Scan. > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > * > ** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Calling "qdr_delivery_settled_CT" dereferences freed pointer "dlv". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Passing freed pointer "dlv" as an argument to "qdr_delivery_settled_CT". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > * > ** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > 743 // > 744 if (dlv_moved) > 745 qdr_delivery_decref_CT(core, dlv, "qdr_delivery_anycast_update CT - dlv > removed from unsettled"); > 746 if (peer_moved) > 747 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > peer removed from unsettled"); > 748 if (peer) > >>> CID 353021: (USE_AFTER_FREE) > >>> Passing freed pointer "peer" as an argument to "qdr_delivery_decref_CT". > 749 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > allow free of peer"); > 750 > 751 return error_assigned; > 752 } > 753 > 754 >
[jira] [Commented] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016116#comment-17016116 ] ASF GitHub Bot commented on DISPATCH-1508: -- kgiusti commented on pull request #653: DISPATCH-1508: clean up qd_listener_t objects on shutdown. URL: https://github.com/apache/qpid-dispatch/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Leak of qd_listener_t's on shutdown > --- > > Key: DISPATCH-1508 > URL: https://issues.apache.org/jira/browse/DISPATCH-1508 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.11.0 > > > Leaks of qd_listener_t's show up when running ctest on a > CMAKE_BUILD_TYPE=Debug build. > Example: > 19: Router solo debug dump file: > 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved DISPATCH-1508. -- Resolution: Fixed > Leak of qd_listener_t's on shutdown > --- > > Key: DISPATCH-1508 > URL: https://issues.apache.org/jira/browse/DISPATCH-1508 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.11.0 > > > Leaks of qd_listener_t's show up when running ctest on a > CMAKE_BUILD_TYPE=Debug build. > Example: > 19: Router solo debug dump file: > 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1508) Leak of qd_listener_t's on shutdown
[ https://issues.apache.org/jira/browse/DISPATCH-1508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016117#comment-17016117 ] ASF subversion and git services commented on DISPATCH-1508: --- Commit 0c7fb1e2a817851bfd2d9f25840915323849b7e6 in qpid-dispatch's branch refs/heads/master from Ken Giusti [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=0c7fb1e ] DISPATCH-1508: clean up qd_listener_t objects on shutdown. This closes #653 > Leak of qd_listener_t's on shutdown > --- > > Key: DISPATCH-1508 > URL: https://issues.apache.org/jira/browse/DISPATCH-1508 > Project: Qpid Dispatch > Issue Type: Bug > Components: Router Node >Affects Versions: 1.9.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Minor > Fix For: 1.11.0 > > > Leaks of qd_listener_t's show up when running ctest on a > CMAKE_BUILD_TYPE=Debug build. > Example: > 19: Router solo debug dump file: > 19: alloc.c: Items of type 'qd_listener_t' remain allocated at shutdown: 4 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti merged pull request #653: DISPATCH-1508: clean up qd_listener_t objects on shutdown.
kgiusti merged pull request #653: DISPATCH-1508: clean up qd_listener_t objects on shutdown. URL: https://github.com/apache/qpid-dispatch/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1544) Coverity false positive use-after-free error
[ https://issues.apache.org/jira/browse/DISPATCH-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016092#comment-17016092 ] ASF GitHub Bot commented on DISPATCH-1544: -- kgiusti commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574715180 The patch also annotates the code so coverity won't report the use after free issue (see the /* coverity */ comments this patch adds). The asserts are there to prevent future code changes from inadvertently messing up the reference counters - which _could_ introduce a real use-after-free bug which coverity will ignore due to the annotation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Coverity false positive use-after-free error > > > Key: DISPATCH-1544 > URL: https://issues.apache.org/jira/browse/DISPATCH-1544 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > > Coverity static analysis has started reporting use-after-free errors in the > delivery state update logic. I've reviewed these errors and I believe these > are false positives. I suspect that Coverity doesn't have enough context to > understand the delivery refcount management done by this code to prevent > use-after-free of the reported deliveries. > I've created a patch that adds assert checking of the refcounts to enforce > the ownership state expected by the code. This appears to "fix" the coverity > issue in so much as when a CMAKE_BUILD_TYPE=Debug build is submitted for > analysis (the asserts are present in Debug) the errors are resolved. > Non-Debug builds still report the error however so I'm also going update the > patch to include annotations to ignore the errors. > I'm opening this Jira to solicit additional eyes on the problem in case I'm > missing something and these errors are legit. > > - > 4 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity > Scan. > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > * > ** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Calling "qdr_delivery_settled_CT" dereferences freed pointer "dlv". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Passing freed pointer "dlv" as an argument to "qdr_delivery_settled_CT". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > * > ** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > 743 // > 744 if (dlv_moved) > 745 qdr_delivery_decref_CT(core, dlv, "qdr_delivery_anycast_update CT - dlv > removed from unsettled"); > 746 if (peer_moved) > 747 qdr_delivery_decref_CT(core, peer,
[GitHub] [qpid-dispatch] kgiusti commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
kgiusti commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574715180 The patch also annotates the code so coverity won't report the use after free issue (see the /* coverity */ comments this patch adds). The asserts are there to prevent future code changes from inadvertently messing up the reference counters - which _could_ introduce a real use-after-free bug which coverity will ignore due to the annotation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016090#comment-17016090
]
ASF GitHub Bot commented on DISPATCH-1513:
--
kgiusti commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366935052
##
File path: src/http-libwebsockets.c.in
##
@@ -354,7 +354,7 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
+(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT
${OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER}) |
Review comment:
libwebsockets exports its version as the following:
LWS_LIBRARY_VERSION_MAJOR
LWS_LIBRARY_VERSION_MINOR
you should be able to simply do
#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
set the HTTPS_ON_HTTPS_LISTENER flags etc
#endif
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016088#comment-17016088
]
ASF GitHub Bot commented on DISPATCH-1513:
--
kgiusti commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366935052
##
File path: src/http-libwebsockets.c.in
##
@@ -354,7 +354,7 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
+(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT
${OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER}) |
Review comment:
libwebsockets exports its version as the following:
LWS_LIBRARY_VERSION_MAJOR
LWS_LIBRARY_VERSION_MINOR
you should be able to simply do
#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
#endif
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end closed connection without"
> http.client.RemoteDisconnected: Remote end closed connection without
> response--
> Ran 1 test in 0.164s {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (DISPATCH-1513) system_tests_http failing with libwebsockets 3.2 on Fedora 31
[
https://issues.apache.org/jira/browse/DISPATCH-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016087#comment-17016087
]
ASF GitHub Bot commented on DISPATCH-1513:
--
kgiusti commented on pull request #660: DISPATCH-1513 - Fixed router crash when
running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366918885
##
File path: cmake/FindLibWebSockets.cmake
##
@@ -60,6 +60,20 @@ else()
LIBWEBSOCKETS DEFAULT_MSG LIBWEBSOCKETS_VERSION_STRING
LIBWEBSOCKETS_LIBRARIES LIBWEBSOCKETS_INCLUDE_DIRS)
endif()
+
+if (LIBWEBSOCKETS_FOUND)
+ # This is a fix for DISPATCH-1513. libwebsockets versions 3.2.0 introduces a
new flag called LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER
+ # The new flag allows (as the flag says) HTTP pver HTTPS listeners. Since
this flag is not available before lws 3.2.0 we need
+ # to selectively include the flag in http-libwebsockets.c
+ set(OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "")
+ set(TEST_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "#")
+ set(LWS_VERSION_WITH_SSL_FIX "3.2.0")
+ if (LIBWEBSOCKETS_VERSION_STRING AND (LIBWEBSOCKETS_VERSION_STRING
VERSION_GREATER_EQUAL LWS_VERSION_WITH_SSL_FIX))
+ set(OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "|
LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER")
Review comment:
Can you instead check the libwebsockets version directly in
http-libwebsockets.c?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_http failing with libwebsockets 3.2 on Fedora 31
> -
>
> Key: DISPATCH-1513
> URL: https://issues.apache.org/jira/browse/DISPATCH-1513
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tests
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Major
> Fix For: 1.11.0
>
>
> Fedora 31 has the latest libwebsockets v 3.2.0 and system_tests_http is
> failing -
> To reproduce
> # cd qpid-dispatch/dockerfiles
> # Open the file Dockerfile-fedora and comment out the line ENTRYPOINT
> ["qdrouterd"] and uncomment CMD ["/bin/bash"]. Save the file.
> # sudo docker build -t fedora31/dispatch --file=Dockerfile-fedora .
> # sudo docker run -i -t fedora31/dispatch
> # cd /main/qpid-dispatch/build
> # ctest -V -R system_tests_http. You will see the following error
> I am commenting out the failing test until the underlying problem is fixed.
> {noformat}
> [root@13552f9cbb69 build]# /usr/bin/python
> "/main/qpid-dispatch/build/tests/run.py" "-m" "unittest" "-v"
> "system_tests_http.RouterTestHttp.test_https_get"
> test_https_get (system_tests_http.RouterTestHttp) ...
> /main/qpid-dispatch/tests/system_tests_http.py:54: DeprecationWarning:
> cafile, capath and cadefault are deprecated, use a custom context instead.
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> ERROR==
> ERROR: test_https_get (system_tests_http.RouterTestHttp)
> --
> Traceback (most recent call last):
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 252, in
> test_https_get
> self.assert_get("http://localhost:%s; % r.ports[0])
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 83, in
> assert_get
> self.assertEqual(u'HTTP test\n', self.get("%s/system_tests_http.txt" %
> url))
> File "/main/qpid-dispatch/tests/system_tests_http.py", line 54, in get
> http_data = urlopen(url, cafile=cls.ssl_file('ca-certificate.pem'))
> File "/usr/lib64/python3.7/urllib/request.py", line 222, in urlopen
> return opener.open(url, data, timeout)
> File "/usr/lib64/python3.7/urllib/request.py", line 525, in open
> response = self._open(req, data)
> File "/usr/lib64/python3.7/urllib/request.py", line 543, in _open
> '_open', req)
> File "/usr/lib64/python3.7/urllib/request.py", line 503, in _call_chain
> result = func(*args)
> File "/usr/lib64/python3.7/urllib/request.py", line 1345, in http_open
> return self.do_open(http.client.HTTPConnection, req)
> File "/usr/lib64/python3.7/urllib/request.py", line 1320, in do_open
> r = h.getresponse()
> File "/usr/lib64/python3.7/http/client.py", line 1344, in getresponse
> response.begin()
> File "/usr/lib64/python3.7/http/client.py", line 306, in begin
> version, status, reason = self._read_status()
> File "/usr/lib64/python3.7/http/client.py", line 275, in _read_status
> raise RemoteDisconnected("Remote end
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366935052
##
File path: src/http-libwebsockets.c.in
##
@@ -354,7 +354,7 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
+(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT
${OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER}) |
Review comment:
libwebsockets exports its version as the following:
LWS_LIBRARY_VERSION_MAJOR
LWS_LIBRARY_VERSION_MINOR
you should be able to simply do
#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
set the HTTPS_ON_HTTPS_LISTENER flags etc
#endif
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed
router crash when running http requests over ht…
URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366935052
##
File path: src/http-libwebsockets.c.in
##
@@ -354,7 +354,7 @@ static void listener_start(qd_http_listener_t *hl,
qd_http_server_t *hs) {
info.options |=
LWS_SERVER_OPTION_DO_SSL_GLOBAL_INIT |
-(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT) |
+(config->ssl_required ? 0 :
LWS_SERVER_OPTION_ALLOW_NON_SSL_ON_SSL_PORT
${OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER}) |
Review comment:
libwebsockets exports its version as the following:
LWS_LIBRARY_VERSION_MAJOR
LWS_LIBRARY_VERSION_MINOR
you should be able to simply do
#if LWS_LIBRARY_VERSION_MAJOR > 3 || (LWS_LIBRARY_VERSION_MAJOR == 3 &&
LWS_LIBRARY_VERSION_MINOR >= 2)
#endif
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht…
kgiusti commented on a change in pull request #660: DISPATCH-1513 - Fixed router crash when running http requests over ht… URL: https://github.com/apache/qpid-dispatch/pull/660#discussion_r366918885 ## File path: cmake/FindLibWebSockets.cmake ## @@ -60,6 +60,20 @@ else() LIBWEBSOCKETS DEFAULT_MSG LIBWEBSOCKETS_VERSION_STRING LIBWEBSOCKETS_LIBRARIES LIBWEBSOCKETS_INCLUDE_DIRS) endif() + +if (LIBWEBSOCKETS_FOUND) + # This is a fix for DISPATCH-1513. libwebsockets versions 3.2.0 introduces a new flag called LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER + # The new flag allows (as the flag says) HTTP pver HTTPS listeners. Since this flag is not available before lws 3.2.0 we need + # to selectively include the flag in http-libwebsockets.c + set(OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "") + set(TEST_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "#") + set(LWS_VERSION_WITH_SSL_FIX "3.2.0") + if (LIBWEBSOCKETS_VERSION_STRING AND (LIBWEBSOCKETS_VERSION_STRING VERSION_GREATER_EQUAL LWS_VERSION_WITH_SSL_FIX)) + set(OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER "| LWS_SERVER_OPTION_ALLOW_HTTP_ON_HTTPS_LISTENER") Review comment: Can you instead check the libwebsockets version directly in http-libwebsockets.c? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2135) C, cpp, and fuzz tests do not set TEST_ENV on Linux
[
https://issues.apache.org/jira/browse/PROTON-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016046#comment-17016046
]
ASF GitHub Bot commented on PROTON-2135:
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574690671
I can quickly test this by building all bindings, and then do `ctest -N -VV`
on Linux and Windows, and diff outputs before and after changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C, cpp, and fuzz tests do not set TEST_ENV on Linux
> ---
>
> Key: PROTON-2135
> URL: https://issues.apache.org/jira/browse/PROTON-2135
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> % cmake .. -DRUNTIME_CHECK=memcheck
> % ctest -V -N
> {noformat}
> 2: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
> Test #2: c-core-test
> 8: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
> "@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
> Test #8: fuzz-message-decode
> {noformat}
> I'd've expected to see the execution wrapped in the env.py script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1547) Route table flush on loss of router takes too long
[ https://issues.apache.org/jira/browse/DISPATCH-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016048#comment-17016048 ] ASF GitHub Bot commented on DISPATCH-1547: -- kgiusti commented on pull request #662: DISPATCH-1547: add tests for router table updates URL: https://github.com/apache/qpid-dispatch/pull/662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Route table flush on loss of router takes too long > -- > > Key: DISPATCH-1547 > URL: https://issues.apache.org/jira/browse/DISPATCH-1547 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.10.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.11.0 > > > Create a router network of 3 routers connected linearly: > > RouterA <—> RouterB <—> RouterC > > Add subscribers to RouterA. Wait until subscribers mobile addresses show up > on RouterC. Then kill RouterA. > Expect: the mobile addresses on RouterC should be flush relatively quickly > Action: the mobile addresses on RouterC remain until the link is marked as > stale (60 seconds in the default config) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti opened a new pull request #662: DISPATCH-1547: add tests for router table updates
kgiusti opened a new pull request #662: DISPATCH-1547: add tests for router table updates URL: https://github.com/apache/qpid-dispatch/pull/662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1544) Coverity false positive use-after-free error
[ https://issues.apache.org/jira/browse/DISPATCH-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016045#comment-17016045 ] ASF GitHub Bot commented on DISPATCH-1544: -- ganeshmurthy commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574690566 This commit only adds asserts ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Coverity false positive use-after-free error > > > Key: DISPATCH-1544 > URL: https://issues.apache.org/jira/browse/DISPATCH-1544 > Project: Qpid Dispatch > Issue Type: Improvement >Affects Versions: 1.11.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Trivial > Fix For: 1.11.0 > > > Coverity static analysis has started reporting use-after-free errors in the > delivery state update logic. I've reviewed these errors and I believe these > are false positives. I suspect that Coverity doesn't have enough context to > understand the delivery refcount management done by this code to prevent > use-after-free of the reported deliveries. > I've created a patch that adds assert checking of the refcounts to enforce > the ownership state expected by the code. This appears to "fix" the coverity > issue in so much as when a CMAKE_BUILD_TYPE=Debug build is submitted for > analysis (the asserts are present in Debug) the errors are resolved. > Non-Debug builds still report the error however so I'm also going update the > patch to include annotations to ignore the errors. > I'm opening this Jira to solicit additional eyes on the problem in case I'm > missing something and these errors are legit. > > - > 4 new defect(s) introduced to Apache Qpid dispatch-router found with Coverity > Scan. > New defect(s) Reported-by: Coverity Scan > Showing 4 of 4 defect(s) > * > ** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353022: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Calling "qdr_delivery_settled_CT" dereferences freed pointer "dlv". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 729 in > qdr_delivery_anycast_update_CT() > 723 assert(sys_atomic_get(>ref_count) > 1); > 724 assert(sys_atomic_get(>ref_count) > 1); > 725 qdr_delivery_unlink_peers_CT(core, dlv, peer); > 726 } > 727 > 728 if (dlink) > >>> CID 353022: (USE_AFTER_FREE) > >>> Passing freed pointer "dlv" as an argument to "qdr_delivery_settled_CT". > 729 dlv_moved = qdr_delivery_settled_CT(core, dlv); > 730 } > 731 > 732 // > 733 // If the delivery's link has a core endpoint, notify the endpoint of > the update > 734 // > * > ** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 739 in > qdr_delivery_anycast_update_CT() > > * > ** > *** CID 353021: (USE_AFTER_FREE) > /home/kgiusti/work/dispatch/qpid-dispatch/src/router_core/delivery.c: 749 in > qdr_delivery_anycast_update_CT() > 743 // > 744 if (dlv_moved) > 745 qdr_delivery_decref_CT(core, dlv, "qdr_delivery_anycast_update CT - dlv > removed from unsettled"); > 746 if (peer_moved) > 747 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > peer removed from unsettled"); > 748 if (peer) > >>> CID 353021: (USE_AFTER_FREE) > >>> Passing freed pointer "peer" as an argument to "qdr_delivery_decref_CT". > 749 qdr_delivery_decref_CT(core, peer, "qdr_delivery_anycast_update_CT - > allow free of peer"); > 750 > 751 return error_assigned; >
[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574690671 I can quickly test this by building all bindings, and then do `ctest -N -VV` on Linux and Windows, and diff outputs before and after changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free
ganeshmurthy commented on issue #657: DISPATCH-1544: mask coverity false positive delivery use-after-free URL: https://github.com/apache/qpid-dispatch/pull/657#issuecomment-574690566 This commit only adds asserts ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Resolved] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Murthy resolved DISPATCH-1540. - Resolution: Fixed > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016041#comment-17016041 ] ASF GitHub Bot commented on DISPATCH-1540: -- asfgit commented on pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (DISPATCH-1540) multiframe presettled messages not included in presettled count on downstream router
[ https://issues.apache.org/jira/browse/DISPATCH-1540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016040#comment-17016040 ] ASF subversion and git services commented on DISPATCH-1540: --- Commit 9d3bf33f840b6fcce53db6db50365a3ee0bbb3de in qpid-dispatch's branch refs/heads/master from Ganesh Murthy [ https://gitbox.apache.org/repos/asf?p=qpid-dispatch.git;h=9d3bf33 ] DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery and its peers on large streaming messages. This will allow the presettled counters to be updated correctly. This closes #658. > multiframe presettled messages not included in presettled count on downstream > router > - > > Key: DISPATCH-1540 > URL: https://issues.apache.org/jira/browse/DISPATCH-1540 > Project: Qpid Dispatch > Issue Type: Bug > Components: Container >Affects Versions: 1.10.0 >Reporter: Gordon Sim >Assignee: Ganesh Murthy >Priority: Major > Fix For: 1.11.0 > > > Set up two routers connected to each other. Attach receiver to one, sender to > the other and send a large message (such that it is sent as multiple transfer > frames). > > Then look at the inter-router link stats for each router. The downstream > router (i.e. that to which receiver is attached), does not record the > delivery as presettled. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-dispatch] asfgit closed pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery …
asfgit closed pull request #658: DISPATCH-1540 - Set the pre-settled flag appropriately on a delivery … URL: https://github.com/apache/qpid-dispatch/pull/658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2135) C, cpp, and fuzz tests do not set TEST_ENV on Linux
[
https://issues.apache.org/jira/browse/PROTON-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016027#comment-17016027
]
ASF GitHub Bot commented on PROTON-2135:
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625
And I just wanted to run leak check with proton-python! :(
OK, so the test registration instances I need to unify looks like this
```
macro(add_cpp_test test)
add_executable (${test} src/${test}.cpp)
target_link_libraries (${test} qpid-proton-cpp ${PLATFORM_LIBS})
add_test (NAME cpp-${test}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_EXE_PREFIX_CMD}
$ ${ARGN})
endmacro(add_cpp_test)
add_test (NAME python-test
COMMAND ${PN_ENV_SCRIPT}
"PATH=${py_path}" "PYTHONPATH=${py_pythonpath}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -- ${python_coverage_options}
"${py_tests}/proton-test")
add_test (NAME python-tox-test
COMMAND ${PN_ENV_SCRIPT} --
"PATH=${py_path}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
"SWIG=${SWIG_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -m tox)
macro(add_ruby_test script)
get_filename_component(name ${script} NAME_WE)
string(REPLACE "_" "-" name "ruby-${name}")
add_test(
NAME ${name}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_WRAP_PREFIX_CMD}
${RUBY_EXECUTABLE} ${script} -v
${ARGN})
endmacro()
add_test (NAME ${test} COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $
"@${CMAKE_CURRENT_BINARY_DIR}/${test}-files")
add_test(NAME c-threaderciser COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C, cpp, and fuzz tests do not set TEST_ENV on Linux
> ---
>
> Key: PROTON-2135
> URL: https://issues.apache.org/jira/browse/PROTON-2135
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> % cmake .. -DRUNTIME_CHECK=memcheck
> % ctest -V -N
> {noformat}
> 2: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
> Test #2: c-core-test
> 8: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
> "@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
> Test #8: fuzz-message-decode
> {noformat}
> I'd've expected to see the execution wrapped in the env.py script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Commented] (PROTON-2135) C, cpp, and fuzz tests do not set TEST_ENV on Linux
[
https://issues.apache.org/jira/browse/PROTON-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016028#comment-17016028
]
ASF GitHub Bot commented on PROTON-2135:
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625
And I just wanted to run leak check with proton-python! :(
OK, so the test registration instances I need to unify look like this
```
macro(add_cpp_test test)
add_executable (${test} src/${test}.cpp)
target_link_libraries (${test} qpid-proton-cpp ${PLATFORM_LIBS})
add_test (NAME cpp-${test}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_EXE_PREFIX_CMD}
$ ${ARGN})
endmacro(add_cpp_test)
add_test (NAME python-test
COMMAND ${PN_ENV_SCRIPT}
"PATH=${py_path}" "PYTHONPATH=${py_pythonpath}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -- ${python_coverage_options}
"${py_tests}/proton-test")
add_test (NAME python-tox-test
COMMAND ${PN_ENV_SCRIPT} --
"PATH=${py_path}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
"SWIG=${SWIG_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -m tox)
macro(add_ruby_test script)
get_filename_component(name ${script} NAME_WE)
string(REPLACE "_" "-" name "ruby-${name}")
add_test(
NAME ${name}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_WRAP_PREFIX_CMD}
${RUBY_EXECUTABLE} ${script} -v
${ARGN})
endmacro()
add_test (NAME ${test} COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $
"@${CMAKE_CURRENT_BINARY_DIR}/${test}-files")
add_test(NAME c-threaderciser COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> C, cpp, and fuzz tests do not set TEST_ENV on Linux
> ---
>
> Key: PROTON-2135
> URL: https://issues.apache.org/jira/browse/PROTON-2135
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
>Affects Versions: proton-c-0.29.0
>Reporter: Jiri Daněk
>Assignee: Jiri Daněk
>Priority: Major
>
> % cmake .. -DRUNTIME_CHECK=memcheck
> % ctest -V -N
> {noformat}
> 2: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/c-core-test"
> Test #2: c-core-test
> 8: Test command:
> /nix/store/xdwjprbhnq2g0425al1anx3d5jpwgqsl-valgrind-3.15.0/bin/valgrind
> "--tool=memcheck" "--leak-check=full" "--error-exitcode=42" "--quiet"
> "--suppressions=/home/jdanek/repos/qpid/qpid-proton/tests/valgrind.supp"
> "/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode"
> "@/home/jdanek/repos/qpid/qpid-proton/build/c/tests/fuzz/fuzz-message-decode-files"
> Test #8: fuzz-message-decode
> {noformat}
> I'd've expected to see the execution wrapped in the env.py script.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625
And I just wanted to run leak check with proton-python! :(
OK, so the test registration instances I need to unify looks like this
```
macro(add_cpp_test test)
add_executable (${test} src/${test}.cpp)
target_link_libraries (${test} qpid-proton-cpp ${PLATFORM_LIBS})
add_test (NAME cpp-${test}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_EXE_PREFIX_CMD}
$ ${ARGN})
endmacro(add_cpp_test)
add_test (NAME python-test
COMMAND ${PN_ENV_SCRIPT}
"PATH=${py_path}" "PYTHONPATH=${py_pythonpath}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -- ${python_coverage_options}
"${py_tests}/proton-test")
add_test (NAME python-tox-test
COMMAND ${PN_ENV_SCRIPT} --
"PATH=${py_path}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
"SWIG=${SWIG_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -m tox)
macro(add_ruby_test script)
get_filename_component(name ${script} NAME_WE)
string(REPLACE "_" "-" name "ruby-${name}")
add_test(
NAME ${name}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_WRAP_PREFIX_CMD}
${RUBY_EXECUTABLE} ${script} -v
${ARGN})
endmacro()
add_test (NAME ${test} COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $
"@${CMAKE_CURRENT_BINARY_DIR}/${test}-files")
add_test(NAME c-threaderciser COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[GitHub] [qpid-proton] jdanekrh edited a comment on issue #207: PROTON-2135 Set TEST_ENV more consistently
jdanekrh edited a comment on issue #207: PROTON-2135 Set TEST_ENV more
consistently
URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625
And I just wanted to run leak check with proton-python! :(
OK, so the test registration instances I need to unify look like this
```
macro(add_cpp_test test)
add_executable (${test} src/${test}.cpp)
target_link_libraries (${test} qpid-proton-cpp ${PLATFORM_LIBS})
add_test (NAME cpp-${test}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_EXE_PREFIX_CMD}
$ ${ARGN})
endmacro(add_cpp_test)
add_test (NAME python-test
COMMAND ${PN_ENV_SCRIPT}
"PATH=${py_path}" "PYTHONPATH=${py_pythonpath}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -- ${python_coverage_options}
"${py_tests}/proton-test")
add_test (NAME python-tox-test
COMMAND ${PN_ENV_SCRIPT} --
"PATH=${py_path}"
"SASLPASSWD=${CyrusSASL_Saslpasswd_EXECUTABLE}"
"SWIG=${SWIG_EXECUTABLE}"
${TEST_ENV}
${TEST_WRAP_PREFIX_CMD} ${PYTHON_EXECUTABLE} -m tox)
macro(add_ruby_test script)
get_filename_component(name ${script} NAME_WE)
string(REPLACE "_" "-" name "ruby-${name}")
add_test(
NAME ${name}
COMMAND ${PN_ENV_SCRIPT} -- ${test_env} ${TEST_WRAP_PREFIX_CMD}
${RUBY_EXECUTABLE} ${script} -v
${ARGN})
endmacro()
add_test (NAME ${test} COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $
"@${CMAKE_CURRENT_BINARY_DIR}/${test}-files")
add_test(NAME c-threaderciser COMMAND ${PN_ENV_SCRIPT} -- ${test_env}
${TEST_EXE_PREFIX_CMD} $)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Assigned] (DISPATCH-1547) Route table flush on loss of router takes too long
[ https://issues.apache.org/jira/browse/DISPATCH-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti reassigned DISPATCH-1547: Assignee: Ken Giusti > Route table flush on loss of router takes too long > -- > > Key: DISPATCH-1547 > URL: https://issues.apache.org/jira/browse/DISPATCH-1547 > Project: Qpid Dispatch > Issue Type: Bug > Components: Routing Engine >Affects Versions: 1.10.0 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Major > Fix For: 1.11.0 > > > Create a router network of 3 routers connected linearly: > > RouterA <—> RouterB <—> RouterC > > Add subscribers to RouterA. Wait until subscribers mobile addresses show up > on RouterC. Then kill RouterA. > Expect: the mobile addresses on RouterC should be flush relatively quickly > Action: the mobile addresses on RouterC remain until the link is marked as > stale (60 seconds in the default config) -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
[jira] [Closed] (QPID-8391) qpid-cpp-1.39.0.tar.gz appears on the download page as 2 different items
[ https://issues.apache.org/jira/browse/QPID-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell closed QPID-8391. Resolution: Information Provided > qpid-cpp-1.39.0.tar.gz appears on the download page as 2 different items > > > Key: QPID-8391 > URL: https://issues.apache.org/jira/browse/QPID-8391 > Project: Qpid > Issue Type: Bug >Reporter: Sebb >Priority: Major > > The file qpid-cpp-1.39.0.tar.gz appears twice on the download page: > Qpid Messaging API C++ > and > C++ broker > The above names link to different pages: > http://qpid.apache.org/components/messaging-api/index.html > and > http://qpid.apache.org/components/cpp-broker/index.html > but the sources and hashes are the same. > That does not seem right. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
