[GitHub] xrmx commented on issue #4324: Cannot create a visualisation given a nested query
xrmx commented on issue #4324: Cannot create a visualisation given a nested query URL: https://github.com/apache/incubator-superset/issues/4324#issuecomment-362519363 A bit puzzled by the fact you are posting a picture with the query executed :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362523601 Facing the same issue, @szmate1618 do you have a possible fix implementation for this ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362523601 Facing the same issue, @szmate1618 do you have a possible fix implementation for this ? Also this is limited to chrome/chromium, it works fine in firefox. Haven't checked IE or Safari This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362523601 Facing the same issue, @szmate1618 do you have a possible fix implementation for this ? Also this is limited to chrome/chromium, it works fine in firefox. Haven't check IE or Safari This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362523601 Facing the same issue, @szmate1618 do you have a possible fix implementation for this ? Also this is limited to chrome/chromium, it works fine in firefox. Haven't checked IE or Safari. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vishalg1994 commented on issue #2540: Getting error when querying a marginally longer running query
vishalg1994 commented on issue #2540: Getting error when querying a marginally longer running query URL: https://github.com/apache/incubator-superset/issues/2540#issuecomment-362527853 any solution yet. I am also experiencing the same problem... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] javiesm8 commented on issue #4324: Cannot create a visualisation given a nested query
javiesm8 commented on issue #4324: Cannot create a visualisation given a nested query URL: https://github.com/apache/incubator-superset/issues/4324#issuecomment-362533349 Hi @xrmx if you can elaborate on what aspect of the fact, then I would be happy to explain. I assumed as much information as possible would help others help me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4311: [feature] Mapbox Polygon support
xrmx commented on issue #4311: [feature] Mapbox Polygon support URL: https://github.com/apache/incubator-superset/pull/4311#issuecomment-362541001 Please rebase instead of pushing other people commits This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szmate1618 commented on issue #1906: Filters fail to refresh
szmate1618 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362542445 No, unfortunately. That workaround was good enough for me, so I never dug into this any deeper, sorry. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] prasar-ashutosh commented on issue #4311: [feature] Mapbox Polygon support
prasar-ashutosh commented on issue #4311: [feature] Mapbox Polygon support URL: https://github.com/apache/incubator-superset/pull/4311#issuecomment-362562275 Thanks for the suggestion. Will create a new clean pull request and close this one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4311: [feature] Mapbox Polygon support
xrmx commented on issue #4311: [feature] Mapbox Polygon support URL: https://github.com/apache/incubator-superset/pull/4311#issuecomment-362562450 @prasar-ashutosh no need to open a new PR please, just update the branch and force push it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dimaslv opened a new pull request #4329: Druid v0.6 compatibility (second try)
dimaslv opened a new pull request #4329: Druid v0.6 compatibility (second try) URL: https://github.com/apache/incubator-superset/pull/4329 These commits allowed me to set up latest superset with our company's Druid v0.6 cluster. I have tried not to break anything for any newer versions. This is second try for those changes to merge into upstream, first pull request was here https://github.com/apache/incubator-superset/pull/2331. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] prasar-ashutosh commented on issue #4311: [feature] Mapbox Polygon support
prasar-ashutosh commented on issue #4311: [feature] Mapbox Polygon support URL: https://github.com/apache/incubator-superset/pull/4311#issuecomment-362563036 Sorry i deleted the old fork and branch, will have to create a new one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4329: Druid v0.6 compatibility (second try)
xrmx commented on issue #4329: Druid v0.6 compatibility (second try) URL: https://github.com/apache/incubator-superset/pull/4329#issuecomment-362564316 Just a couple of thoughts: - any chance that pydruid sqlalchemy dialect already handles that? - passing the version as parameter on an object does not look that nice, either storing the version as an attribute in the object or creating a subclass for older apis may look better This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] prasar-ashutosh closed pull request #4311: [feature] Mapbox Polygon support
prasar-ashutosh closed pull request #4311: [feature] Mapbox Polygon support URL: https://github.com/apache/incubator-superset/pull/4311 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] prasar-ashutosh opened a new pull request #4330: Adding support for Mapbox with Polygon
prasar-ashutosh opened a new pull request #4330: Adding support for Mapbox with Polygon URL: https://github.com/apache/incubator-superset/pull/4330 ***Mapbox Polygon support*** This pull request is an attempt to implement the feature: https://github.com/apache/incubator-superset/issues/2675 **Background** We are using superset with Druid in our project at Dataspark, Singtel, Singapore. We needed Mapbox with Polygon support in our project. So we have attempted to solve this problem using react-map-gl , deck.gl and d3. The new visualization is called "Mapbox with Polygon". **Usage** - Create a new slice - Select the datasource as : "birth_france_by_region" - Select the visualization type : *Mapbox with Polygon* and click on "create a new Slice" https://user-images.githubusercontent.com/17263748/35559750-6fa4a804-05e6-11e8-9c01-e4f2f4765d51.png";> - In the Query section , select the DEPT_ID under "Codes of region/province/department" and select a metric. - Click on Query. Zoom in/out to adjust if needed. hover around the map to see the details. https://user-images.githubusercontent.com/17263748/35560622-da72c2f4-05e8-11e8-84ce-447618cd4316.png";> **Features** The visualisation supports the following filters/selectors 1. Time https://user-images.githubusercontent.com/17263748/35560125-7beb3622-05e7-11e8-87dd-38c0031e6e1d.png";> 2. Query https://user-images.githubusercontent.com/17263748/35560190-9ccd9150-05e7-11e8-8807-18aeb79b3dc8.png";> 3. Options - GeoJosn : select the geojson layer - RGB color sheme : select the Color scheme - Map Style : Select the map style https://user-images.githubusercontent.com/17263748/35560262-e01cdf42-05e7-11e8-9c39-6e7e8411f8d3.png";> 4. Viewport https://user-images.githubusercontent.com/17263748/35560395-3cd652d6-05e8-11e8-9be7-4f042a2e59bc.png";> 5. SQL https://user-images.githubusercontent.com/17263748/35560724-25337770-05e9-11e8-86c8-8ba738670a3b.png";> 6. Filters https://user-images.githubusercontent.com/17263748/35560752-374dafa2-05e9-11e8-80ef-d2ad924b3e1e.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] brylie opened a new issue #4331: Simple, automatic install option(s)
brylie opened a new issue #4331: Simple, automatic install option(s) URL: https://github.com/apache/incubator-superset/issues/4331 Currently, the [Superset installation instructions](https://superset.incubator.apache.org/installation.html) are several pages long, including many manual steps. This may be reasonable for people with a background in managing systems, but is likely to discourage adoption by a wider audience. Taking examples from other projects other projects, such as Re:dash, it would be worthwhile to provide one or more 'automated' installation packages, such as: - Docker image - Helm chart - AWS installation script - Linux package (deb, rpm, etc.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362575580 I have tried digging but I ain't much of a react dev so what I went with finally is: `turn off instant filtering` Multiple filters work the way I intend them to with this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] heaven00 commented on issue #1906: Filters fail to refresh
heaven00 commented on issue #1906: Filters fail to refresh URL: https://github.com/apache/incubator-superset/issues/1906#issuecomment-362575580 I have tried digging but I ain't much of a react dev so what I went with finally is: `turn off instant filtering` Multiple filters work the way they are intend to with this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] angelcervera commented on a change in pull request #2953: [WiP] ElasticSearch connector integration
angelcervera commented on a change in pull request #2953: [WiP] ElasticSearch
connector integration
URL:
https://github.com/apache/incubator-superset/pull/2953#discussion_r165644190
##
File path: superset/config.py
##
@@ -190,6 +190,7 @@
DEFAULT_MODULE_DS_MAP = OrderedDict([
('superset.connectors.sqla.models', ['SqlaTable']),
('superset.connectors.druid.models', ['DruidDatasource']),
+('superset.connectors.elastic.models', ['ElasticDatasource']),
Review comment:
Maybe is good don't short the name and call it `.elasticsearch.` and
`ElasticseachDatasource` to avoid confusion with other future datasources.
I don't know at the moment, but maybe in the future people wants integration
with other products, for example, _Elastic Query_ from Azure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] FloPit opened a new issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source
FloPit opened a new issue #4332: Filter Box: "No Data" although filterbox slice
and time series slice in dashboard have same source
URL: https://github.com/apache/incubator-superset/issues/4332
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if any
- [x] I have reproduced the issue with at least the latest released version
of superset
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
{"version": "0.21.1", "GIT_SHA": ""}
### Expected results
Data is displayed in the time series line chart slice.
### Actual results
Time series line chart slice says "No data".
### Steps to reproduce
1. use a table X as data source (in my case, maria DB is underlying DB, and
a View from Maria DB is used)
2. create a filter box slice (column "machine_name" for sorting), based on
that data source
3. create a time series line chart slice (this has no filter, displays data
in preview), based on that data source
4. Use both the filter box slice (from 2) and the time series line chart
slice (from 3) in a dashboard
5. Open dashboard, choose one machine_name (or more) from the filter box
slice
6. In the dashboard in the time series line chart, it says "No data."
The count(*) indicates that there are some records for specific machine_name
selected!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] gregroberts commented on issue #3905: Pivot table can not sort by names of metrics in custom order
gregroberts commented on issue #3905: Pivot table can not sort by names of metrics in custom order URL: https://github.com/apache/incubator-superset/issues/3905#issuecomment-362611567 +1 Here. producing a pivot table showing for example Leads, Bookings, Conversion, it seems absurd I should have to rename my metrics 1. Leads, 2. Bookings 3. Conversion just to make this work. What if I wanted to make another report from the same data showing Bookings, Repeat Bookings & New Bookings? I'd have to define new metrics for the new order! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] amancevice commented on issue #4307: Adaptative Formatting month and Quarter
amancevice commented on issue #4307: Adaptative Formatting month and Quarter URL: https://github.com/apache/incubator-superset/issues/4307#issuecomment-362618331 The only way I was able to find to get month-to-date results was to use the string: `one day after last month eom`, which is hilarious but seems to have worked. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Benji81 commented on issue #3496: Added button on slice for export D3js graph to png
Benji81 commented on issue #3496: Added button on slice for export D3js graph to png URL: https://github.com/apache/incubator-superset/pull/3496#issuecomment-362634897 Hello, Any progress on this PR? It is a very nice feature This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Benji81 commented on a change in pull request #4185: Add new visualization for custom X-Y axes
Benji81 commented on a change in pull request #4185: Add new visualization for
custom X-Y axes
URL:
https://github.com/apache/incubator-superset/pull/4185#discussion_r165701861
##
File path: superset/assets/javascripts/explore/stores/controls.jsx
##
@@ -560,6 +595,59 @@ export const controls = {
}),
},
+ columns_and_metrics_y: {
+type: 'SelectControl',
+multi: true,
+label: t('Y Axis'),
+default: [],
+description: t('Columns or metrics to display'),
+mapStateToProps: (state) => {
+ let choices = [];
+ if (state.controls && state.datasource) {
Review comment:
? not grouped by
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs
Mogball commented on issue #3974: [Bugfix] _add_filters_from_pre_query doesn't handle dim specs URL: https://github.com/apache/incubator-superset/pull/3974#issuecomment-362650097 What version of superset are you using? I think this is in version 0.21.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] graceguo-supercat closed pull request #4326: [explore] fix missing CacheLabel
graceguo-supercat closed pull request #4326: [explore] fix missing CacheLabel
URL: https://github.com/apache/incubator-superset/pull/4326
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
b/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
index 30b47994eb..0faf164df4 100644
--- a/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreChartHeader.jsx
@@ -74,7 +74,7 @@ class ExploreChartHeader extends React.PureComponent {
json_endpoint: getExploreUrl(formData, 'json'),
standalone_endpoint: getExploreUrl(formData, 'standalone'),
};
-
+const chartSucceeded = ['success',
'rendered'].indexOf(this.props.chart.chartStatus) > 0;
return (
}
- {this.props.chart.chartStatus === 'success' && queryResponse &&
+ {chartSucceeded && queryResponse &&
- }
- {this.props.chart.chartStatus === 'success' &&
- queryResponse &&
- queryResponse.is_cached &&
-
-
- }
+/>}
+ {chartSucceeded && queryResponse && queryResponse.is_cached &&
+}
{
+ let wrapper;
+ beforeEach(() => {
+wrapper = shallow();
+ });
+
+ it('is valid', () => {
+expect(
+ React.isValidElement(),
+).to.equal(true);
+ });
+
+ it('renders', () => {
+expect(wrapper.find(EditableTitle)).to.have.lengthOf(1);
+expect(wrapper.find(ExploreActionButtons)).to.have.lengthOf(1);
+ });
+});
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on issue #4329: Druid v0.6 compatibility (second try)
mistercrunch commented on issue #4329: Druid v0.6 compatibility (second try) URL: https://github.com/apache/incubator-superset/pull/4329#issuecomment-362676177 @xrmx doesn't have SQL support at all. I think SQLAlchemy access to druid might require `0.10` or `0.11`+ Druid backend This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4329: Druid v0.6 compatibility (second try)
mistercrunch commented on a change in pull request #4329: Druid v0.6
compatibility (second try)
URL:
https://github.com/apache/incubator-superset/pull/4329#discussion_r165731054
##
File path: superset/connectors/druid/models.py
##
@@ -119,7 +119,11 @@ def get_druid_version(self):
endpoint = (
'http://{obj.coordinator_host}:{obj.coordinator_port}/status'
).format(obj=self)
-return json.loads(requests.get(endpoint).text)['version']
+ver = json.loads(requests.get(endpoint).text)['version']
+if ver is None:
Review comment:
`return ver or "0"` instead of the 4 lines
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4329: Druid v0.6 compatibility (second try)
mistercrunch commented on a change in pull request #4329: Druid v0.6
compatibility (second try)
URL:
https://github.com/apache/incubator-superset/pull/4329#discussion_r165730864
##
File path: superset/connectors/druid/models.py
##
@@ -207,13 +211,14 @@ def refresh(self, datasource_names, merge_flag,
refreshAll):
if datatype == 'hyperUnique' or datatype == 'thetaSketch':
col_obj.count_distinct = True
# Allow sum/min/max for long or double
-if datatype == 'LONG' or datatype == 'DOUBLE':
+if datatype == 'LONG' or datatype == 'DOUBLE' or datatype
== 'FLOAT':
Review comment:
let's use `datetype in ('foo', 'bar')`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rumbin commented on issue #4324: Cannot create a visualisation given a nested query
rumbin commented on issue #4324: Cannot create a visualisation given a nested query URL: https://github.com/apache/incubator-superset/issues/4324#issuecomment-362678431 I understand @javiesm8 in trying to visualize the result of this SQLLab query as a Big Number slice. While the query works for SQLLab, the transfer to Visualize is failing somehow. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source
xrmx commented on issue #4332: Filter Box: "No Data" although filterbox slice and time series slice in dashboard have same source URL: https://github.com/apache/incubator-superset/issues/4332#issuecomment-362682110 Friendly reminder to always reproduce with latest release which unfortunately 0.21.1 is not. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4333: Add hour grain to SQLite
betodealmeida opened a new pull request #4333: Add hour grain to SQLite URL: https://github.com/apache/incubator-superset/pull/4333 This PR adds an hourly grain to SQLite by truncating the datetime. I used this code while developing the time scrubber, since I was testing with the `long_lat` data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4334: Add default value for point_radius_fixed
betodealmeida opened a new pull request #4334: Add default value for point_radius_fixed URL: https://github.com/apache/incubator-superset/pull/4334 As the title says. I came across this bug when developing the time scrubber. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4333: Add hour grain to SQLite
xrmx commented on issue #4333: Add hour grain to SQLite URL: https://github.com/apache/incubator-superset/pull/4333#issuecomment-362686251 Is the __init__.py hunk supposed to be here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4333: Add hour grain to SQLite
xrmx commented on issue #4333: Add hour grain to SQLite URL: https://github.com/apache/incubator-superset/pull/4333#issuecomment-362686251 Is the `data/__init__.py` hunk supposed to be here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4334: Add default value for point_radius_fixed
mistercrunch commented on issue #4334: Add default value for point_radius_fixed URL: https://github.com/apache/incubator-superset/pull/4334#issuecomment-362687836 I think it's fixed on the client side of things now here: https://github.com/apache/incubator-superset/pull/4261 Can you check that this commit was not in your branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4334: Add default value for point_radius_fixed
mistercrunch commented on issue #4334: Add default value for point_radius_fixed URL: https://github.com/apache/incubator-superset/pull/4334#issuecomment-362687836 I think it's fixed on the client side of things now here: https://github.com/apache/incubator-superset/pull/4261 Should be impossible to return null at this point. Can you check that this commit was not in your branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4324: Cannot create a visualisation given a nested query
mistercrunch commented on issue #4324: Cannot create a visualisation given a nested query URL: https://github.com/apache/incubator-superset/issues/4324#issuecomment-362688368 Stack trace / error msg / which database engine was used would help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4331: Simple, automatic install option(s)
mistercrunch commented on issue #4331: Simple, automatic install option(s) URL: https://github.com/apache/incubator-superset/issues/4331#issuecomment-362690091 If people in the community can share and maintain those it would be great. It's already a considerable amount of work to handle the PyPI and eventually the Apache releases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4328: Filter box doesnot applies to mapbox
mistercrunch commented on issue #4328: Filter box doesnot applies to mapbox URL: https://github.com/apache/incubator-superset/issues/4328#issuecomment-362692302 The columns need to be checked as "Filtereable" in the table editor. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #2540: Getting error when querying a marginally longer running query
mistercrunch commented on issue #2540: Getting error when querying a marginally longer running query URL: https://github.com/apache/incubator-superset/issues/2540#issuecomment-362693300 I think the stack trace here isn't the stack trace we need to debug this. Maybe the stack trace is on the worker's logs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4245: build master branch failed
mistercrunch commented on issue #4245: build master branch failed URL: https://github.com/apache/incubator-superset/issues/4245#issuecomment-362693975 I have no idea... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #3905: Pivot table can not sort by names of metrics in custom order
mistercrunch commented on issue #3905: Pivot table can not sort by names of metrics in custom order URL: https://github.com/apache/incubator-superset/issues/3905#issuecomment-362694532 Side note: we need to re-write the table and pivot table visulizations to move away from the current "datatables" library and into a React lib, probably react-virtualized to support large result sets. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] davelpz opened a new issue #4335: Not quoting column name when doing a time series
davelpz opened a new issue #4335: Not quoting column name when doing a time
series
URL: https://github.com/apache/incubator-superset/issues/4335
Make sure these boxes are checked before submitting your issue - thank you!
- [X ] I have checked the superset logs for python stacktraces and included
it here as text if any
- [X] I have reproduced the issue with at least the latest released version
of superset
- [X] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
Commit
1f8fccc0f923de0b119b22303e504e9efeeff417
### Expected results
time series should work if column name has a space in it
### Actual results
get sql error because column is not properly quoted
### Steps to reproduce
Have a table with columns where column names have spaces, including
date columns, for example 'CREATED DATE'
Create a slice and in the Time section select a column with a space in the
name.
Also select a 'Time Grain' of 'Time Column'. When you run the query, you
will see that the
generated query is not quoting the column like it should.
I've been debugging this and I think the problem lies in
superset/connectors/sqla/models.py
I think the get_timestamp_expression function should return column at end of
function
and not literal_column
def get_timestamp_expression(self, time_grain):
"""Getting the time component of the query"""
expr = self.expression or self.column_name
if not self.expression and not time_grain:
return column(expr, type_=DateTime).label(DTTM_ALIAS)
if time_grain:
pdf = self.python_date_format
if pdf in ('epoch_s', 'epoch_ms'):
# if epoch, translate to DATE using db specific conf
db_spec = self.table.database.db_engine_spec
if pdf == 'epoch_s':
expr = db_spec.epoch_to_dttm().format(col=expr)
elif pdf == 'epoch_ms':
expr = db_spec.epoch_ms_to_dttm().format(col=expr)
grain = self.table.database.grains_dict().get(time_grain,
'{col}')
expr = grain.function.format(col=expr)
return literal_column(expr, type_=DateTime).label(DTTM_ALIAS)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] davelpz commented on issue #4335: Not quoting column name when doing a time series
davelpz commented on issue #4335: Not quoting column name when doing a time
series
URL:
https://github.com/apache/incubator-superset/issues/4335#issuecomment-362708686
Upon further debugging I think this is the correct fix (below)
I changed `if not self.expression and not time_grain:` to
`if not self.expression and (not time_grain or time_grain == u'Time Column')
:`
```python
def get_timestamp_expression(self, time_grain):
"""Getting the time component of the query"""
expr = self.expression or self.column_name
if not self.expression and (not time_grain or time_grain == u'Time
Column') :
return column(expr, type_=DateTime).label(DTTM_ALIAS)
if time_grain:
pdf = self.python_date_format
if pdf in ('epoch_s', 'epoch_ms'):
# if epoch, translate to DATE using db specific conf
db_spec = self.table.database.db_engine_spec
if pdf == 'epoch_s':
expr = db_spec.epoch_to_dttm().format(col=expr)
elif pdf == 'epoch_ms':
expr = db_spec.epoch_ms_to_dttm().format(col=expr)
grain = self.table.database.grains_dict().get(time_grain,
'{col}')
expr = grain.function.format(col=expr)
return literal_column(expr, type_=DateTime).label(DTTM_ALIAS)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] davelpz commented on issue #4335: Not quoting column name when doing a time series
davelpz commented on issue #4335: Not quoting column name when doing a time series URL: https://github.com/apache/incubator-superset/issues/4335#issuecomment-362709093 I'd be happy to submit a pull request of people think this is correct. thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4241: [cli] permission cleanup on 'superset init'
hug commented on issue #4241: [cli] permission cleanup on 'superset init' URL: https://github.com/apache/incubator-superset/pull/4241#issuecomment-362714827 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on issue #4333: Add hour grain to SQLite
betodealmeida commented on issue #4333: Add hour grain to SQLite URL: https://github.com/apache/incubator-superset/pull/4333#issuecomment-362722184 @xrmx, I thought it made sense to update the sample data to have higher than daily resolution, but I can remove that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4316: [WiP] fix caching issues
mistercrunch commented on issue #4316: [WiP] fix caching issues URL: https://github.com/apache/incubator-superset/pull/4316#issuecomment-362725606 @john-bodley I think I've got it mostly nailed down now at this point. This turned out to be a much more complex headache then I thought originally. Especially in the area of caching properly multi-queries visualizations. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4316: [WiP] fix caching issues
mistercrunch commented on a change in pull request #4316: [WiP] fix caching issues URL: https://github.com/apache/incubator-superset/pull/4316#discussion_r165776347 ## File path: superset/assets/package.json ## @@ -93,8 +93,8 @@ "react-sortable-hoc": "^0.6.7", "react-split-pane": "^0.1.66", "react-syntax-highlighter": "^5.7.0", -"react-virtualized": "^9.3.0", -"react-virtualized-select": "^2.4.0", +"react-virtualized": "9.3.0", Review comment: Unrelated but that fixed the build This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on issue #4334: Add default value for point_radius_fixed
betodealmeida commented on issue #4334: Add default value for point_radius_fixed URL: https://github.com/apache/incubator-superset/pull/4334#issuecomment-362730700 You're right, this is now fixed and no longer needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida closed pull request #4334: Add default value for point_radius_fixed
betodealmeida closed pull request #4334: Add default value for
point_radius_fixed
URL: https://github.com/apache/incubator-superset/pull/4334
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/viz.py b/superset/viz.py
index e59835b60b..18a3d3ab70 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -1956,7 +1956,8 @@ def get_properties(self, d):
def get_data(self, df):
fd = self.form_data
-self.point_radius_fixed = fd.get('point_radius_fixed')
+self.point_radius_fixed = (
+fd.get('point_radius_fixed') or {'type': 'fix', 'value': 500})
self.fixed_value = None
self.dim = self.form_data.get('dimension')
if self.point_radius_fixed.get('type') != 'metric':
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] betodealmeida opened a new pull request #4336: Play scrubber
betodealmeida opened a new pull request #4336: Play scrubber
URL: https://github.com/apache/incubator-superset/pull/4336
@mistercrunch, this is the play slider/scrobbler for Deck.gl scatterplot. I
started creating an NPM package for the `` component, but the
layout and style is coupled with Superset, so I thought it would be better to
have it here.
One thing I'm worried about these changes is that in order to get the
start/end values for the slider the code is scanning the payload to get the
min/max timestamps from the data. This has some advantages:
- If you select a wide range of data (the `long_lat` sample table has a
query since 2004, IIRC) the play slider will cover only the available data,
making it better for exploring the results.
- We don't need to parse the freetext ("now", "7 days ago") in Javascript.
The only downside is that it could be slow. Let me know what you think.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
