[Freeciv-Dev] [patch #3770] better defense when GameLoss is a military unit
URL: http://gna.org/patch/?3770 Summary: better defense when GameLoss is a military unit Project: Freeciv Submitted by: imhotep Submitted on: Mon 04 Mar 2013 10:38:17 AM GMT Category: ai Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Background: I modified Ancients modpack so that the Leader is a weak military unit, to incite human players to take a bit of a risk and make the game more interesting. Unfortunately, this works for AIs, too. To win, I only have to wait until all AI leaders are killed by barbarians. Patch (against Freeciv version 2.4.99-dev r22446): This little hack prevents AIs from using the Leader to defend cities (so other units will be produced to do this). Second, if no DefendGood units can be produced, DefendOk will do. ___ File Attachments: --- Date: Mon 04 Mar 2013 10:38:17 AM GMT Name: gameloss_defend_22466.patch Size: 817B By: imhotep http://gna.org/patch/download.php?file_id=17384 ___ Reply to this item at: http://gna.org/patch/?3770 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2
Follow-up Comment #11, bug #20551 (project freeciv): file #17357 fixes the bug for me; see also svn 2.5 at https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv ___ Reply to this item at: http://gna.org/bugs/?20551 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c
URL:
http://gna.org/bugs/?20585
Summary: variable 'punit' set but not used in citytools.c
Project: Freeciv
Submitted by: syntron
Submitted on: Mon 04 Mar 2013 10:35:16 PM CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: svn22473
Discussion Lock: Any
Operating System: None
Planned Release:
___
Details:
I get the following error on opensuse 12.3 (see
https://build.opensuse.org/package/live_build_log?arch=x86_64package=freeciv-2.4svnproject=home%3Asyntron%3Afreecivrepository=openSUSE_12.3_Update_standard).
The build uses '--enable-debug=yes'.
[ 608s] citytools.c: In function 'transfer_city_units':
[ 608s] citytools.c:724:3: error: variable 'punit' set but not used
[-Werror=unused-but-set-variable]
[ 608s] cc1: all warnings being treated as errors
[ 608s] make[3]: *** [citytools.lo] Error 1
[ 608s] make[3]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473/server'
[ 608s] make[2]: *** [all-recursive] Error 1
[ 608s] make[2]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473/server'
[ 608s] make[1]: *** [all-recursive] Error 1
[ 608s] make[1]: Leaving directory
`/home/abuild/rpmbuild/BUILD/freeciv-2.4.svn.22473'
[ 608s] make: *** [all] Error 2
[ 608s] error: Bad exit status from /var/tmp/rpm-tmp.4s0bpV (%build)
It's the following code:
#ifdef DEBUG
unit_list_iterate(pcity-units_supported, punit) {
fc_assert(punit-homecity == pcity-id);
fc_assert(unit_owner(punit) == pplayer);
} unit_list_iterate_end;
#endif /* DEBUG */
opensuse 12.3 will be released on 13.03. I do not know which additional test
is activated there ...
___
Reply to this item at:
http://gna.org/bugs/?20585
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20542] in unit_virtual_destroy() [unit.c::1881]: assertion '!unit_transported(punit)' failed
Update of bug #20542 (project freeciv): Category:None = client Planned Release: = 2.4.0,2.5.0 ___ Follow-up Comment #1: I'm seeing this assertion/backtrace too, on S2_4 r22473. It's a client-side assertion. Just load the attached savefile and then quit. (file #17386) ___ Additional Item Attachment: File name: americans-T0222-Y01610-manual.sav.bz2 Size:52 KB ___ Reply to this item at: http://gna.org/bugs/?20542 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c
Update of bug #20585 (project freeciv): Release:svn22473 = S2_4 svn22473 Planned Release: = 2.4.0,2.5.0 ___ Reply to this item at: http://gna.org/bugs/?20585 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20586] fix tolua_clinet.pkg and tolua_common_a.pkg
URL: http://gna.org/bugs/?20586 Summary: fix tolua_clinet.pkg and tolua_common_a.pkg Project: Freeciv Submitted by: syntron Submitted on: Mon 04 Mar 2013 10:54:10 PM CET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: svn22472 Discussion Lock: Any Operating System: None Planned Release: ___ Details: switching from lua 5.1 to 5.2 needs changes to unpack() see also patch #3230 ___ File Attachments: --- Date: Mon 04 Mar 2013 10:54:10 PM CET Name: 0002-fix-tolua_clinet.pkg-and-tolua_common_a.pkg.patch Size: 2kB By: syntron http://gna.org/bugs/download.php?file_id=17387 ___ Reply to this item at: http://gna.org/bugs/?20586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20586] fix tolua_client.pkg and tolua_common_a.pkg
Update of bug #20586 (project freeciv): Summary: fix tolua_clinet.pkg and tolua_common_a.pkg = fix tolua_client.pkg and tolua_common_a.pkg ___ Reply to this item at: http://gna.org/bugs/?20586 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20585] variable 'punit' set but not used in citytools.c
Follow-up Comment #1, bug #20585 (project freeciv): Well, I could see this could happen if DEBUG and NDEBUG were both defined. Our configure stuff should only define NDEBUG with --enable-debug=no. Is it possible that the environment defines NDEBUG? ___ Reply to this item at: http://gna.org/bugs/?20585 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20587] Autosettlers only consider enemy land units dangerous
URL: http://gna.org/bugs/?20587 Summary: Autosettlers only consider enemy land units dangerous Project: Freeciv Submitted by: jtn Submitted on: Mon Mar 4 22:07:33 2013 Category: ai Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: Undefended autosettlers gained the ability to run away from threatening units in patch #3384. However, they currently only consider land units threats, so coastal workers will still blithely ignore battleships. cazfi said: To make it work well, a bit more work is needed. It should not abort work when settler is not on the coast, but still the sea unit is within checked range, or when sea unit is not able to coastal bombardment... I'll leave that to future tickets (and probably TRUNK only) (Comments in patch #3383 may also be relevant?) ___ Reply to this item at: http://gna.org/bugs/?20587 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3384] autosettler check current danger
Follow-up Comment #10, patch #3384 (project freeciv): I'll leave that to future tickets (and probably TRUNK only). Raised bug #20587 for safe-keeping. ___ Reply to this item at: http://gna.org/patch/?3384 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20572] AI observer timeout display badly off
Follow-up Comment #1, bug #20572 (project freeciv): If you think of a solution for this, it'll help with bug #18664 too. ___ Reply to this item at: http://gna.org/bugs/?20572 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18664] unitwaittime - client needs an indicator
Follow-up Comment #4, bug #18664 (project freeciv): What I'm worried about is the rush of events at turn change that means there might be a significant delay between the server starting a timer and sending a packet and the client processing that packet and starting its timer. I suspect that can cause discrepancies with the server and client's view of the timeout today [...] Confirmed: bug #20572. ___ Reply to this item at: http://gna.org/bugs/?18664 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20567] Lua random() not really random
Follow-up Comment #3, bug #20567 (project freeciv): Hm. Not directly relevant to the patch (which seems like a fine idea), but the random Lua-generated labels, it would be kind of nice if they were generated from mapseed rather than gameseed, so that if I pick a mapseed I like, I get fixed labels as well. But would it perhaps be too much to force every Lua function hooked off the map_generated signal to get mapseed-derived randomness? If we did, we'd want to ensure that game-start events could have access to gameseed-derived randomness; is the ability to hook onto the turn_started signal sufficient? I'd rather not explicitly expose two different random sources concurrently to Lua. ___ Reply to this item at: http://gna.org/bugs/?20567 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20567] Lua random() not really random
Follow-up Comment #4, bug #20567 (project freeciv): The map generation random seed would be the same on the second attempt as on first if main gameseed would have been succesfully restored after first attempt. time(NULL) is munged into map.server.seed when it's zero in map_fractal_generate(), which I think explains this? (Which I think means any autogame where the first map generation failed will not be reproducible. It feels to me that the right thing to do in that case is to continue subsequent map generations with the mapseed random state, i.e. move the random state management out of map_fractal_generate() entirely.) ___ Reply to this item at: http://gna.org/bugs/?20567 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20588] Scorched spot etc not localised
URL: http://gna.org/bugs/?20588 Summary: Scorched spot etc not localised Project: Freeciv Submitted by: jtn Submitted on: Mon Mar 4 23:52:24 2013 Category: rulesets Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: jtn Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: 2.5.0 ___ Details: The map labels in data/classic/script.lua are not marked for i18n: * Highest Peak * Deep Trench * Scorched spot * Frozen lake Not submitting patch until the fix for bug #20543 is committed, as it will clash horribly. (While there, sort out capitalisation. Also I've been vaguely wondering about more flowery / evocative labels, but I haven't thought of anything. HIC SVNT DRACONES) ___ Reply to this item at: http://gna.org/bugs/?20588 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20588] Scorched spot etc not localised
Update of bug #20588 (project freeciv): Depends on: = bugs #20543 ___ Reply to this item at: http://gna.org/bugs/?20588 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20561] Move translations from freeciv-server to the clients.
Follow-up Comment #3, bug #20561 (project freeciv): I don't see anything relevant in r22161 -- did you mean another revision? I think that either client-side or server-side-client-specific localisation would require all construction of strings from localisable parts to be done by approved means, and format strings and arguments kept in some unflattened data structure until fan-out to invididual clients in low-level functions; so that requires a massive audit, and those functions need to be capable of all the compositions that we want (that are currently happening in ad-hoc ways in situation-specific code); and probably there are tedious memory ownership and freeing issues to worry about. So I can't see us getting around to it, to be honest. But if you are going to all that trouble, I think the server-side localisation is clearly superior. Is modpack-specific text can be translated now? Well, um. A keen server operator could certainly add modpack strings to the message catalogue used by the server. I don't know that any do. ___ Reply to this item at: http://gna.org/bugs/?20561 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20589] Client uses different safe filename logic to everything else
URL: http://gna.org/bugs/?20589 Summary: Client uses different safe filename logic to everything else Project: Freeciv Submitted by: jtn Submitted on: Tue Mar 5 00:28:34 2013 Category: client Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.3.4,2.4.0-beta1 Discussion Lock: Any Operating System: Any Planned Release: 2.3.5,2.4.0,2.5.0 ___ Details: In connectdlg_common.c, the client rolls its own safe filename function is_filename_safe(), rather than using is_safe_filename() in shared.c. The latter throws out strictly more potentially-dodgy characters and constructs. (The increased strictness will not impact current usage, which is for single_want_hack.) Also add some more comments on the topic. ___ Reply to this item at: http://gna.org/bugs/?20589 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20589] Client uses different safe filename logic to everything else
Update of bug #20589 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: trunk-S2_4-S2_3-client-hack-safe-filename.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?20589 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20555] Client fails to kill server when it fails to get 'hack' access
Update of bug #20555 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.3.5,2.4.0,2.5.0 ___ Follow-up Comment #1: Patch attached. In S2_3 version, string change split out to separate patch, to be applied if we decide to break string freeze on S2_3 for a future release. (file #17389, file #17390, file #17391) ___ Additional Item Attachment: File name: trunk-S2_4-client-spawn-hack-fail.patch Size:2 KB File name: S2_3-client-spawn-hack-fail.patch Size:1 KB File name: S2_3-client-spawn-hack-fail-msg.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?20555 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20551] failed to compile luasql: not compatible with Lua 5.2
Update of bug #20551 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20551 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #3771] Rename luasql-2.1.1 directory as luasql
URL: http://gna.org/patch/?3771 Summary: Rename luasql-2.1.1 directory as luasql Project: Freeciv Submitted by: cazfi Submitted on: Tue 05 Mar 2013 09:27:44 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0 ___ Details: Included luasql is now version 2.3.0 so current directory name is misleading. In general there seems to be no need to ever have multiple versions of luasql present, so attached patch handles directory rename to just versionless. Actual directory rename must be done separately, the patch contains just configure.ac and Makefile.am changes. ___ File Attachments: --- Date: Tue 05 Mar 2013 09:27:44 AM EET Name: LuasqlVerName.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=17392 ___ Reply to this item at: http://gna.org/patch/?3771 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20498] Pirate archers alone in the water
Update of bug #20498 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20498 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
