[Freeciv-Dev] [patch #5011] civ2civ3: default to team_pooled_research=FALSE

2014-08-24 Thread Jacob Nevins
Follow-up Comment #4, patch #5011 (project freeciv):

 We know that that doesn't work well with 
 team_pooled_research=TRUE, and probably won't be fixed until 
 2.6.0 (bug #22058).
In fact pepeto has committed fixes for that bug to S2_4/S2_5. So maybe this
ticket's redundant? I haven't checked whether any of the other research bugs
only fixed on trunk will cause trouble.

___

Reply to this item at:

  http://gna.org/patch/?5011

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20058] Invalid string conversion from UTF-8 to CP1252 with Turkish leader name

2014-08-24 Thread Jacob Nevins
Follow-up Comment #12, bug #20058 (project freeciv):

 Close as probably fixed by some Gtk upgrade?
 See also bug #21935, comment 0 described at bug number 3. 
Since that was reported against 2.4.2, which I think is using the same Gtk
versions as current releases, I don't think we can assume this is fixed by a
Gtk upgrade; rather than I just didn't manage to find the conditions necessary
to reproduce it.

___

Reply to this item at:

  http://gna.org/bugs/?20058

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5082] Remove [help_villages]

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5082

 Summary: Remove [help_villages]
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 12:45:51 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

As rulesets provide help for the huts extras (called Minor Tribe Village in
most rulesets), there's no point in having also hardcoded Villages entry.
Move the text from helpdata.txt to helptext of the extras in the rulesets.
Also take advantage of the possibility to fix it per-ruleset basis: alien
ruleset gets completely rewritten text, civ1 ruleset gets overflight behavior
correctly.




___

File Attachments:


---
Date: Sun 24 Aug 2014 12:45:51 PM EEST  Name: VillageHelp.patch  Size: 8kB  
By: cazfi

http://gna.org/patch/download.php?file_id=21820

___

Reply to this item at:

  http://gna.org/patch/?5082

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5071] [Metaticket] Help updates for gen-extras

2014-08-24 Thread Marko Lindqvist
Update of patch #5071 (project freeciv):

  Depends on: = patch #5082


___

Reply to this item at:

  http://gna.org/patch/?5071

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5083] Remove Pillage rmcause from huts

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5083

 Summary: Remove Pillage rmcause from huts
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 12:59:49 PM EEST
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

So far Pillage has been valid placeholder value (unlike empty ) for
rmcauses of the hut extras rmcauses field, and has had no ill effects as hut
is always removed when the unit that could pillage it enters the tile, before
unit can actually pillage it.

Now that help entries for all extras have been added, telling that huts can be
pillaged is confusing at best. Remove the Pillage rmcause from all hut
extras in supplied rulesets.



___

File Attachments:


---
Date: Sun 24 Aug 2014 12:59:49 PM EEST  Name: HutPillage.patch  Size: 3kB  
By: cazfi

http://gna.org/patch/download.php?file_id=21821

___

Reply to this item at:

  http://gna.org/patch/?5083

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5071] [Metaticket] Help updates for gen-extras

2014-08-24 Thread Marko Lindqvist
Update of patch #5071 (project freeciv):

  Depends on: = patch #5083


___

Reply to this item at:

  http://gna.org/patch/?5071

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5082] Remove [help_villages]

2014-08-24 Thread Marko Lindqvist
Follow-up Comment #1, patch #5082 (project freeciv):

Help also lists requirements to build Village which could be avoided by
setting buildable = FALSE but really the code should check if causes has
anything that corresponds to building activity - or maybe it just should list
causes in addition to requirements (River can be placed by mapgenerator
land tile)

___

Reply to this item at:

  http://gna.org/patch/?5082

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5084] Help about extra causes

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5084

 Summary: Help about extra causes
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 02:19:24 PM EEST
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

In extra help tell how the extra appears. Also fixes the case mentioned in
patch #5082 that extra without no cause to be considered building it still get
building requirement listed.



___

File Attachments:


---
Date: Sun 24 Aug 2014 02:19:24 PM EEST  Name: HelpEC.patch  Size: 1kB   By:
cazfi

http://gna.org/patch/download.php?file_id=21822

___

Reply to this item at:

  http://gna.org/patch/?5084

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5082] Remove [help_villages]

2014-08-24 Thread Marko Lindqvist
Follow-up Comment #2, patch #5082 (project freeciv):

comment #1 was meant for patch #5083, but the issue itself is now being solved
in patch #5084.

___

Reply to this item at:

  http://gna.org/patch/?5082

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5085] Merge CleanPollution and CleanFallout

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5085

 Summary: Merge CleanPollution and CleanFallout
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 02:56:29 PM EEST
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

It seems rather wasteful to assign two separate keys for cleaning p)ollution
and n)uclear waste just for the very rare situation that the tile has both and
user has to be able to select which one to clean. I'm for merging the
activities to single Clean activity.
In the first phase (this ticket) handle both-on-same-tile case simply by
cleaning what prev_extra_in_tile() suggests. That's regression for player in
that (s)he cannot control what gets cleaned. At least in theory ruleset author
can influence this by listing extras in right order.

In some future ticket it's possible handle this like pillage - if there's just
one cleanable extra in the tile, automatically clean that one, but if there's
multiple, open a selection dialog.





___

Reply to this item at:

  http://gna.org/patch/?5085

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5086] Culture effect on migration score

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5086

 Summary: Culture effect on migration score
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 03:41:04 PM EEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add city culture points to migration score, adjusted by percentage given in a
ruleset.



___

File Attachments:


---
Date: Sun 24 Aug 2014 03:41:05 PM EEST  Name: MigrateAfterCulture.patch  Size:
7kB   By: cazfi

http://gna.org/patch/download.php?file_id=21823

___

Reply to this item at:

  http://gna.org/patch/?5086

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22507] Alien terrain.ruleset fails to load

2014-08-24 Thread Marko Lindqvist
Update of bug #22507 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22507

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Bugs: Crash loading game in FreeCiv 2.4.x and two others

2014-08-24 Thread Marko Lindqvist
On 23 August 2014 19:51, Matthias Basler matthiasbas...@earthflight.org wrote:
 Hi freeciv developers.

 I just  want to report a bug which I encountered in FreeCiv 2.4 beta and
 2.4.3 alike und Windows 7, 64 bit, German, in single-player mode (local
 server):

 This bug is 100% reproducable:
 1. Start or load and start a saved game.
 2. Quit the game (but not the application)
 3. Load and start a saved game
 4. Quit the game (but not the application)
 5. Load and start a saved game
 6. Quit the game (but not the application)
 7. Load and start a saved game (for the fourth time)
 Freeciv will now crash. See attached screenshot.

 

 Speaking of bugs - there is another nasty one:
 Whenever I try to save a game with special characters in them, such as
 Umlauts (ä,ö,ü) or question mark, the game will quietly not be saved.
 Instead Freeciv seems to continue normally, but at the end of the round
 (when pressing  Done!) the game crashes as well. This is also 100%
 reproducable.

 

 And there is a small glitch:
 In the city window, on the Production tab, if I change the order of two
 different items selected for production, which results in a different item
 being produced right now, the production progress bar doesn't update. It
 still shows the progress for the previously ordered item. See second
 screenshot.

 Matthias Basler
 matthiasbas...@earthflight.org


 Thank you for reporting these, but could you please report them (as 3
separate reports) to our bugtracker so we can keep track of them and
they won't get forgotten as one email once sent to the mailing list:
http://gna.org/bugs/?func=additemgroup=freeciv


-  ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5068] New diplomatic relationship requirement type property foreign

2014-08-24 Thread Sveinung Kvilhaugsvik
Update of patch #5068 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5068

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22506] Undocumented max distance in steal tech

2014-08-24 Thread Sveinung Kvilhaugsvik
Update of bug #22506 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22506

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] [Freeciv-commits] r26014 - in /trunk: common/fc_types.h common/player.c common/player.h common/requirements.c doc/README.effects

2014-08-24 Thread Marko Lindqvist
On 24 August 2014 17:10,  sveinun...@users.sourceforge.net wrote:
 Author: sveinung
 Date: Sun Aug 24 16:10:20 2014
 New Revision: 26014

 URL: http://svn.gna.org/viewcvs/freeciv?rev=26014view=rev
 Log:
 New diplomatic relationship requirement type property foreign

 Only support the local range since that is the only place it makes sense.

 See patch #5068

 Modified:
 trunk/common/fc_types.h
 trunk/common/player.c
 trunk/common/player.h
 trunk/common/requirements.c
 trunk/doc/README.effects

 No fc_version there - obviously no network capability string change.

 -/* Asymmetric diplomatic relations.
 +/* Other diplomatic relation properties.
   *
   * The first element here is numbered DS_LAST
   */

 There's no comment that this is part of network protocol. Is that really so?
 How is the DiplRel requirement sent to client so that these values do
not matter?

 -#define SPECENUM_NAME diplrel_asym
 -#define SPECENUM_VALUE7 DRA_GIVES_SHARED_VISION
 +#define SPECENUM_NAME diplrel_other
 +#define SPECENUM_VALUE7 DRO_GIVES_SHARED_VISION
  #define SPECENUM_VALUE7NAME N_(Gives shared vision)
 -#define SPECENUM_VALUE8 DRA_RECEIVES_SHARED_VISION
 +#define SPECENUM_VALUE8 DRO_RECEIVES_SHARED_VISION
  #define SPECENUM_VALUE8NAME N_(Receives shared vision)
 -#define SPECENUM_VALUE9 DRA_HOSTS_EMBASSY
 +#define SPECENUM_VALUE9 DRO_HOSTS_EMBASSY
  #define SPECENUM_VALUE9NAME N_(Hosts embassy)
 -#define SPECENUM_VALUE10 DRA_HAS_EMBASSY
 +#define SPECENUM_VALUE10 DRO_HAS_EMBASSY
  #define SPECENUM_VALUE10NAME N_(Has embassy)
 -#define SPECENUM_VALUE11 DRA_HOSTS_REAL_EMBASSY
 +#define SPECENUM_VALUE11 DRO_HOSTS_REAL_EMBASSY
  #define SPECENUM_VALUE11NAME N_(Hosts real embassy)
 -#define SPECENUM_VALUE12 DRA_HAS_REAL_EMBASSY
 +#define SPECENUM_VALUE12 DRO_HAS_REAL_EMBASSY
  #define SPECENUM_VALUE12NAME N_(Has real embassy)
 -#define SPECENUM_VALUE13 DRA_HAS_CASUS_BELLI
 +#define SPECENUM_VALUE13 DRO_HAS_CASUS_BELLI
  #define SPECENUM_VALUE13NAME N_(Has Casus Belli)
 -#define SPECENUM_VALUE14 DRA_PROVIDED_CASUS_BELLI
 +#define SPECENUM_VALUE14 DRO_PROVIDED_CASUS_BELLI
  #define SPECENUM_VALUE14NAME N_(Provided Casus Belli)
 +#define SPECENUM_VALUE15 DRO_FOREIGN
 +#define SPECENUM_VALUE15NAME N_(Is foreign)
  #include specenum_gen.h


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22514] Diplomatic relations aren't reported to be a part of the network protocol

2014-08-24 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?22514

 Summary: Diplomatic relations aren't reported to be a part of
the network protocol
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 24 Aug 2014 02:26:06 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Reported by Marko Lindqvist cazfi on the mailing list




___

Reply to this item at:

  http://gna.org/bugs/?22514

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22514] Some enums used in universal aren't marked as a part of the network protocol

2014-08-24 Thread Sveinung Kvilhaugsvik
Update of bug #22514 (project freeciv):

  Status:None = In Progress
 Assigned to:None = sveinung   
 Summary: Diplomatic relations aren't reported to be a part of
the network protocol = Some enums used in universal aren't marked as a part
of the network protocol

___

Follow-up Comment #1:

This is also true for other enums sent as universals. The reason for this is
that I used Java Freeciv Protocol Implementation to generate the list of stuff
relevant for the network protocol in bug #19868. Java Freeciv Protocol
Implementation starts in packets.def and pulls in stuff referenced in it as
dependencies. It don't add the dependencies of universals_u.

___

Reply to this item at:

  http://gna.org/bugs/?22514

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22500] Unimplemented set_city_names_font_sizes

2014-08-24 Thread mir3x
Update of bug #22500 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22500

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5064] Qt-client: Viewport fix

2014-08-24 Thread mir3x
Update of patch #5064 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = mir3x  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5064

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5087] Qt-client: Economy report update

2014-08-24 Thread mir3x
URL:
  http://gna.org/patch/?5087

 Summary: Qt-client: Economy report update
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sun 24 Aug 2014 07:08:15 PM CEST
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2, 2.6.0

___

Details:

Added check for NULL displayed sprites.
Also unit sprites are scaled now to fit in cells.



___

File Attachments:


---
Date: Sun 24 Aug 2014 07:08:15 PM CEST  Name: QtEcoRepFix.patch  Size: 2kB  
By: mir3x

http://gna.org/patch/download.php?file_id=21824

___

Reply to this item at:

  http://gna.org/patch/?5087

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5088] CMA enable/disable button icon

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5088

 Summary: CMA enable/disable button icon
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 08:25:44 PM EEST
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Icon in Qt-clients Enable CMA button works opposite to the gtk-clients one.
The gtk logic is that it shows current state - green when governor is enabled
and working correctly, red when disabled - qt client logic is that it shows
what the toggle button would do - red when it would disable currently active
governor, green when it would enable currently disabled governor.

I prefer gtk-clients solution of displaying green when everything is ok, but I
see how that could be problematic in a button that would toggle it to not-ok
when pressed.

Could we have the icon moved out of the button? So that there would be green
or red light telling governor's current state separately, and the button to
toggle it would have just the enable or disable text.




___

Reply to this item at:

  http://gna.org/patch/?5088

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22503] Client connect failures not giving proper error message

2014-08-24 Thread Marko Lindqvist
Update of bug #22503 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22503

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22514] Some enums used in universal aren't marked as a part of the network protocol

2014-08-24 Thread Sveinung Kvilhaugsvik
Update of bug #22514 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: universal_enums_are_used_in_the_network_protocol.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?22514

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user

2014-08-24 Thread Marko Lindqvist
Follow-up Comment #6, bug #20556 (project freeciv):

Implementation that adds commandline parameter --Hackless to debug builds.

(file #21826)
___

Additional Item Attachment:

File name: Hackless.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?20556

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] Client guidelines

2014-08-24 Thread Marko Lindqvist
Our commit rules in the wiki say that only the default client is
required to be kept up-to-date with every commit, and it's the job of
gui-maintainers to keep up with the general development. That,
obviously, assumes that there's active gui maintainers. Which is not
the case today. So, we should have an agreement how to develop in
respect to each gui. I'll start discussion with this proposal.

This is mainly about features that have an interface to freeciv
outside the client gui itself - anything initiated by the server, or
read from the common data files. Improvements to the any gui itself
can be made, it makes no sense to require some other gui to get the
feature first (especially if it's something that is technologically
harder to implement on that other client, but is cheap in particular
gui)

gtk-clients are the primary clients, which must get support for new
features on initial commit (if any client gets). It's hard to say
which one is more important at the moment. There's not much point in
adding features to gtk2-client, going to be obsolete at some point,
but leaving out from gtk3-client that's going to be the future.
Neither does it make much sense to leave feature out from gtk2-client
that is currently the default one. Good thing is that porting features
between the two is usually easy.

Qt- and sdl2-clients are in no regressions allowed -state. While
these clients are only catching up in general, they should support any
new features as soon as possible. They should be catching up, not
constantly behind the gtk-clients. When a new feature is added, there
should be at least plan (and tickets created) to add it to these
clients even if not added in the initial commit. Failures of Qt- or
sdl2-client to support some feature added to freeciv in that version
should be considered stable release blockers.
sdl-client is not as important as it's going away anyway, but often
porting from sdl2-client is so easy it's worth it.

xaw-client should be kept in compiling state


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21639] Minimized chat-view after reconnect

2014-08-24 Thread Marko Lindqvist
Update of bug #21639 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.4.4, 2.5.0-beta2, 2.6.0

___

Follow-up Comment #1:

There was an gtk-assert failing about gdk_window_process_updates() being fed
non-window parameter when reproducing this. Fix for that was easy (don't try
to refresh mapview when there's not one) and it seems it was somehow causing
this problem too (not really surprising as there is clear link in that it was
mapview display expanding that caused message area shrinkage)

(file #21827)
___

Additional Item Attachment:

File name: FlushNULLCanvas.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?21639

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21692] Flag display mangled + assertion failures

2014-08-24 Thread Marko Lindqvist
Update of bug #21692 (project freeciv):

  Status:None = Duplicate  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 

___

Follow-up Comment #2:

I think bug #22457 fixed all this.

___

Reply to this item at:

  http://gna.org/bugs/?21692

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20305] Closing helpbrowser gives gtk assert

2014-08-24 Thread Marko Lindqvist
Update of bug #20305 (project freeciv):

 Planned Release: 2.4.1, 2.5.0, 2.6.0 =

___

Follow-up Comment #2:

Cannot reproduce any more.

___

Reply to this item at:

  http://gna.org/bugs/?20305

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22517] Endianness check reversed in RGB24 to RGBA32 conversion

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?22517

 Summary: Endianness check reversed in RGB24 to RGBA32
conversion
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 01:59:43 AM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.4, 2.5.0-beta2, 2.6.0

___

Details:

Fix attached.



___

File Attachments:


---
Date: Mon 25 Aug 2014 01:59:43 AM EEST  Name: RGB24RightEndian.patch  Size:
502B   By: cazfi

http://gna.org/bugs/download.php?file_id=21828

___

Reply to this item at:

  http://gna.org/bugs/?22517

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5089] difficulty.[ch]

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5089

 Summary: difficulty.[ch]
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 02:36:56 AM EEST
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Move AI difficulty related things from stdinhand.c to new ai/difficulty.[ch]
module.



___

File Attachments:


---
Date: Mon 25 Aug 2014 02:36:56 AM EEST  Name: DifficultyModule.patch  Size:
14kB   By: cazfi

http://gna.org/patch/download.php?file_id=21829

___

Reply to this item at:

  http://gna.org/patch/?5089

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5090] Minimum gtk3 version to 3.8

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5090

 Summary: Minimum gtk3 version to 3.8
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 03:11:10 AM EEST
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

- There's notable theming changes in gtk+ between 3.6 and 3.8. It might be a
burden to try to maintain compatibility with pre-3.8 theming as we work on
improving it (it's possible that we already depend on 3.8 in a way, themes not
working as well in older versions)
- Default client in 2.5 is gtk2, so the issue of people using gtk3-client
there and wanting to upgrade to freeciv-2.6 is not so critical. Anyway, even
gtk+-3.8 is an relatively old version by the time freeciv-2.6 comes out
(latest gtk+ is already 3.12)

Thus attached patch bumps minimum gtk3 requirement from 3.6 to 3.8. While it
doesn't magically break the code from working with 3.6, it makes us free not
to care about 3.6 compatibility. We should later check any constructs
deprecated in 3.8 in our codebase (we can't fix later deprecations as there
wouldn't be alternative way to do things in 3.8)



___

File Attachments:


---
Date: Mon 25 Aug 2014 03:11:10 AM EEST  Name: Gtk38.patch  Size: 3kB   By:
cazfi

http://gna.org/patch/download.php?file_id=21830

___

Reply to this item at:

  http://gna.org/patch/?5090

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5065] Logging level as parameter to sockaddr_debug()

2014-08-24 Thread Marko Lindqvist
Update of patch #5065 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5065

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5091] Show git commit on clients

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5091

 Summary: Show git commit on clients
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 04:57:47 AM EEST
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2, 2.6.0

___

Details:

- gtk and Qt clients show git commit id as part of the version number, in
multiple lines and alignments adjusted

- sdl and xaw clients do not have enough space in version number area, so they
just print it to chat window



___

File Attachments:


---
Date: Mon 25 Aug 2014 04:57:47 AM EEST  Name:
0001-Display-git-revision-on-all-clients-when-configured-.patch  Size: 9kB  
By: cazfi

http://gna.org/patch/download.php?file_id=21831
---
Date: Mon 25 Aug 2014 04:57:47 AM EEST  Name: GitrevShow-S2_5.patch  Size: 8kB
  By: cazfi

http://gna.org/patch/download.php?file_id=21832

___

Reply to this item at:

  http://gna.org/patch/?5091

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5092] Show git commit id on modpack installers

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5092

 Summary: Show git commit id on modpack installers
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 05:40:55 AM EEST
Category: module installer
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0-beta2, 2.6.0

___

Details:





___

File Attachments:


---
Date: Mon 25 Aug 2014 05:40:55 AM EEST  Name:
0001-Show-git-commit-id-on-modpack-installers-when-config.patch  Size: 3kB  
By: cazfi

http://gna.org/patch/download.php?file_id=21833

___

Reply to this item at:

  http://gna.org/patch/?5092

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5093] Show freeciv version on freeciv-ruledit opening display

2014-08-24 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5093

 Summary: Show freeciv version on freeciv-ruledit opening
display
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 25 Aug 2014 05:42:03 AM EEST
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Mon 25 Aug 2014 05:42:03 AM EEST  Name:
0002-Show-freeciv-version-on-freeciv-ruledit.patch  Size: 2kB   By: cazfi

http://gna.org/patch/download.php?file_id=21834

___

Reply to this item at:

  http://gna.org/patch/?5093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev