Change in ...gr-gsm[master]: Fix sub_slot assignment in the universal_ctrl_chans_demapper block
ptrkrysik has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14946 ) Change subject: Fix sub_slot assignment in the universal_ctrl_chans_demapper block .. Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 Gerrit-Change-Number: 14946 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: ptrkrysik Gerrit-Comment-Date: Wed, 04 Sep 2019 05:53:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 770s] ar: `u' modifier ignored since `D' is the default (see `U') [ 770s] libtool: link: ranlib .libs/libtransceiver_common.a [ 770s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 770s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 771s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 771s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 771s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 771s] collect2: error: ld returned 1 exit status [ 771s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 771s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 771s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 771s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 771s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 771s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 771s] make[1]: *** [Makefile:444: all] Error 2 [ 771s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 771s] dh_auto_build: make -j1 returned exit code 2 [ 771s] make: *** [debian/rules:6: build] Error 255 [ 771s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 771s] [ 771s] lamb56 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Wed Sep 4 05:14:12 UTC 2019. [ 771s] [ 771s] ### VM INTERACTION START ### [ 774s] [ 739.039673] sysrq: SysRq : Power Off [ 774s] [ 739.056801] reboot: Power down [ 774s] ### VM INTERACTION END ### [ 774s] [ 774s] lamb56 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Wed Sep 4 05:14:15 UTC 2019. [ 774s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 628s] ar: `u' modifier ignored since `D' is the default (see `U') [ 628s] libtool: link: ranlib .libs/libtransceiver_common.a [ 628s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 628s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 629s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 629s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 629s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 629s] collect2: error: ld returned 1 exit status [ 629s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 629s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 629s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 629s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 629s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 629s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 629s] make[1]: *** [Makefile:444: all] Error 2 [ 629s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 629s] dh_auto_build: make -j1 returned exit code 2 [ 629s] make: *** [debian/rules:6: build] Error 255 [ 629s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 630s] [ 630s] lamb28 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Wed Sep 4 04:59:05 UTC 2019. [ 630s] [ 630s] ### VM INTERACTION START ### [ 633s] [ 610.621128] sysrq: SysRq : Power Off [ 633s] [ 610.643152] reboot: Power down [ 633s] ### VM INTERACTION END ### [ 633s] [ 633s] lamb28 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Wed Sep 4 04:59:09 UTC 2019. [ 633s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-ttcn3-hacks[master]: sgsn: implement commonid as alt_step
daniel has removed a vote on this change. Change subject: sgsn: implement commonid as alt_step .. Removed Code-Review+1 by daniel -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d4d0aa83c0365969039613d7539d0e7d816afa7 Gerrit-Change-Number: 15398 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote
Change in ...osmo-ttcn3-hacks[master]: sgsn: implement commonid as alt_step
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398 )
Change subject: sgsn: implement commonid as alt_step
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/15398/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15398/1/sgsn/SGSN_Tests.ttcn@550
PS1, Line 550: [gb_idx >= NUM_GB]
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi))) {
is_gb(gb_idx)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3d4d0aa83c0365969039613d7539d0e7d816afa7
Gerrit-Change-Number: 15398
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:46:53 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp_index with gb_idx
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400 ) Change subject: sgsn: replace variable bssgp_index with gb_idx .. Patch Set 1: Same. gssbp_idx or ran_idx or whatever. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307 Gerrit-Change-Number: 15400 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:45:02 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp with gb_idx
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399 )
Change subject: sgsn: replace variable bssgp with gb_idx
..
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/15399/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15399/1/sgsn/SGSN_Tests.ttcn@2368
PS1, Line 2368: friend function
f_routing_area_update(RoutingAreaIdentificationV ra, integer gb_idx := 0,
boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
Please, if you are at it, change it to bssgp_idx or ran_idx.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
Gerrit-Change-Number: 15399
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:44:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
lynxis lazus has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 )
Change subject: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
..
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@525
PS2, Line 525: function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo,
integer gb_index := 0, boolean initial := false) runs on BSSGP_ConnHdlr {
> May have more sense to have an array of initial states (boolean) in
> BSSGP_ConnHdlr with size equal t […]
good idea. @laforge, what do you think about this?
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@644
PS2, Line 644: var IntegrityProtectionAlgorithm
uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
> why is this commented?
0 means UIA1. I'll change the comment to be more specific
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@646
PS2, Line 646:
//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
> why is this commented out? because sgsn should send it but it doesn't?
there is a seperate patch for this later in the chain.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433
Gerrit-Change-Number: 15171
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:44:08 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397 )
Change subject: sgsn: add TC_geran_attach_iu_rau
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn
File sgsn/SGSN_Tests_Iu.ttcn:
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@57
PS1, Line 57: private function f_TC_geran_attach_iu_rau(charstring id) runs on
BSSGP_ConnHdlr {
Again, write a description on top of function about what does the test check
please.
https://gerrit.osmocom.org/#/c/15397/1/sgsn/SGSN_Tests_Iu.ttcn@74
PS1, Line 74: vc_conn.done;
Missing f_cleanup();
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
Gerrit-Change-Number: 15397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:42:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: implement commonid as alt_step
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398 ) Change subject: sgsn: implement commonid as alt_step .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15398/1/sgsn/SGSN_Tests.ttcn File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/15398/1/sgsn/SGSN_Tests.ttcn@667 PS1, Line 667: f_sleep(1.0); I dislike the speculative sleeps to receive messages, but seeing that this has been done below as well (and I don't have a better idea right now) I'm fine with it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d4d0aa83c0365969039613d7539d0e7d816afa7 Gerrit-Change-Number: 15398 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Tue, 03 Sep 2019 18:40:51 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: extend f_routing_area_update() to support Iu
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396 )
Change subject: sgsn: extend f_routing_area_update() to support Iu
..
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2358
PS1, Line 2358: friend function
f_routing_area_update(RoutingAreaIdentificationV ra, integer bssgp := 0,
boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
Is ptmsi sent only on Iu? Then why not simply do inside the function:
if (is_iu(bssgp))
p_tmsi := g_pars.p_tmsi;
https://gerrit.osmocom.org/#/c/15396/1/sgsn/SGSN_Tests.ttcn@2391
PS1, Line 2391: var IntegrityProtectionAlgorithm
uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
Again, why all these commented stuff?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b
Gerrit-Change-Number: 15396
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:40:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: L3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signature
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15395 ) Change subject: L3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signature .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15395/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15395/1//COMMIT_MSG@9 PS1, Line 9: Iu packets needs to contain an ptmsi as tlv in difference to Gb. a ptmsi as opposed to? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ba51a28524261dd1c7f4f2586ee6ebc970ea944 Gerrit-Change-Number: 15395 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:38:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 )
Change subject: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
..
Patch Set 2:
(4 comments)
https://gerrit.osmocom.org/#/c/15171/2//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/#/c/15171/2//COMMIT_MSG@10
PS2, Line 10: which sends L3 messages for Iu and Gb at the same time.
Not at the same time. It sends L3 messages over the requested L2 layer
(controlled by gb_index).
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@525
PS2, Line 525: function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo,
integer gb_index := 0, boolean initial := false) runs on BSSGP_ConnHdlr {
May have more sense to have an array of initial states (boolean) in
BSSGP_ConnHdlr with size equal to values available in gb_index (btw, can we
call it ran_index?). This way initial state is maintained inside this function
and tests don't need to care about whether they are sending initial message or
not (and they can still play with the value by modifying the array directly if
needed).
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@644
PS2, Line 644: var IntegrityProtectionAlgorithm
uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/
why is this commented?
https://gerrit.osmocom.org/#/c/15171/2/sgsn/SGSN_Tests.ttcn@646
PS2, Line 646:
//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
why is this commented out? because sgsn should send it but it doesn't?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433
Gerrit-Change-Number: 15171
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels
Gerrit-CC: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:35:28 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:33:48 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 to look at the new patch set (#5). Change subject: ipa: ipa_server_link_close() add checks of link state .. ipa: ipa_server_link_close() add checks of link state When closing a link which failed on open, ipa_server_link_close() would crash it when calling osmo_fd_unregister. Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 --- M src/input/ipa.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/15387/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_iu_attach_geran_rau
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163 ) Change subject: sgsn: add TC_iu_attach_geran_rau .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie043639638a640a2041324fc910964385a41c77d Gerrit-Change-Number: 15163 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:24:52 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_iu_attach_geran_rau
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163 )
Change subject: sgsn: add TC_iu_attach_geran_rau
..
Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn
File sgsn/SGSN_Tests_Iu.ttcn:
https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@38
PS2, Line 38: private function f_TC_iu_attach_geran_rau(charstring id) runs on
BSSGP_ConnHdlr {
Would be great if you could describe what the test does in a comment on the
line prior to the function definition:
/* First perform regular attach through RANAP, then RAU over GERAN */
https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@41
PS2, Line 41: /* first perform regular attach */
over RANAP/Iu
https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@45
PS2, Line 45: f_routing_area_update(g_pars.ra);
over GERAN?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie043639638a640a2041324fc910964385a41c77d
Gerrit-Change-Number: 15163
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-Comment-Date: Tue, 03 Sep 2019 18:24:48 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: add Iu Attach Request
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 ) Change subject: sgsn: add Iu Attach Request .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/13866/6/sgsn/SGSN_Tests_Iu.ttcn File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/#/c/13866/6/sgsn/SGSN_Tests_Iu.ttcn@34 PS6, Line 34: vc_conn.done; Missing f_cleanup(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66069e31c30d33934ad57cc2b8794f56ffd5c7d6 Gerrit-Change-Number: 13866 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:20:52 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...pysim[master]: pySim-prog: Use CSV format with headers
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15313 ) Change subject: pySim-prog: Use CSV format with headers .. Patch Set 3: I refactored the code and split it up into different commits as well. There were quite a few corner cases we weren't handling before, and there should be less now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: daniel Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:19:21 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp_index with gb_idx
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400
Change subject: sgsn: replace variable bssgp_index with gb_idx
..
sgsn: replace variable bssgp_index with gb_idx
gb_idx is common used as variable for the index of the bssgb array.
Be consistent and use the same variable name everywhere.
Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/00/15400/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index c486be1..0a8aef0 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -676,12 +676,12 @@
deactivate(di);
}
-function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer bssgp_index := 0) runs on
BSSGP_ConnHdlr {
+function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer gb_idx := 0) runs on
BSSGP_ConnHdlr {
g_pars.p_tmsi := p_tmsi;
/* update TLLI */
g_pars.tlli_old := g_pars.tlli;
g_pars.tlli := g_pars.p_tmsi or4b 'c000'O;
- f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli,
BSSGP_PROC[bssgp_index]);
+ f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli,
BSSGP_PROC[gb_idx]);
}
function f_process_attach_accept(PDU_GMM_AttachAccept aa) runs on
BSSGP_ConnHdlr {
@@ -713,7 +713,7 @@
/* T3302, T3319, T3323, T3312_ext, T3324 */
}
-function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer
bssgp_index := 0) runs on BSSGP_ConnHdlr {
+function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer
gb_idx := 0) runs on BSSGP_ConnHdlr {
/* mandatory IE */
g_pars.ra := ra.routingAreaId;
if (ispresent(ra.allocatedPTMSI)) {
@@ -721,7 +721,7 @@
setverdict(fail, "unexpected P-TMSI allocation");
mtc.stop;
}
-
f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,
bssgp_index);
+
f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,
gb_idx);
}
if (ispresent(ra.msIdentity)) {
setverdict(fail, "unexpected TMSI allocation in non-combined
attach");
@@ -1099,10 +1099,10 @@
}
/* general GPRS DETACH helper */
-function f_detach_mo(BIT3 detach_type, boolean power_off, boolean
expect_purge, integer bssgp_index := 0) runs on BSSGP_ConnHdlr {
+function f_detach_mo(BIT3 detach_type, boolean power_off, boolean
expect_purge, integer gb_idx := 0) runs on BSSGP_ConnHdlr {
var PDU_L3_SGSN_MS l3_mt;
timer T := 5.0;
- f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), bssgp_index);
+ f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), gb_idx);
if (expect_purge) {
GSUP.receive(tr_GSUP_PURGE_MS_REQ(g_pars.imsi,
OSMO_GSUP_CN_DOMAIN_PS));
GSUP.send(ts_GSUP_PURGE_MS_RES(g_pars.imsi));
@@ -1113,7 +1113,7 @@
setverdict(fail, "Unexpected GSUP PURGE MS for unregistered
TLLI");
mtc.stop;
}
- [power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) -> value
l3_mt {
+ [power_off] BSSGP[gb_idx].receive(tr_GMM_DET_ACCEPT_MT) -> value l3_mt {
g_pars.ra := omit;
setverdict(fail, "Unexpected DETACH ACCEPT in power-off
DETACH");
mtc.stop;
@@ -1122,12 +1122,12 @@
[power_off] T.timeout {
setverdict(pass);
}
- [not power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) ->
value l3_mt {
+ [not power_off] BSSGP[gb_idx].receive(tr_GMM_DET_ACCEPT_MT) -> value
l3_mt {
g_pars.ra := omit;
setverdict(pass);
/* TODO: check if any PDP contexts are deactivated on network
side? */
}
- [] BSSGP[bssgp_index].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {
+ [] BSSGP[gb_idx].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {
if (power_off) {
setverdict(fail, "Unexpected Layer 3 package received
in power-off DETACH");
} else {
@@ -1135,7 +1135,7 @@
}
mtc.stop;
}
- [] BSSGP[bssgp_index].receive { repeat; }
+ [] BSSGP[gb_idx].receive { repeat; }
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307
Gerrit-Change-Number: 15400
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: sgsn: implement commonid as alt_step
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398
Change subject: sgsn: implement commonid as alt_step
..
sgsn: implement commonid as alt_step
Change-Id: I3d4d0aa83c0365969039613d7539d0e7d816afa7
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/98/15398/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index d210182..e4a5cbf 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -546,6 +546,12 @@
}
}
+altstep as_ranap_common_id(integer gb_idx) runs on BSSGP_ConnHdlr {
+ [gb_idx >= NUM_GB]
BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi))) {
+ repeat;
+ }
+}
+
altstep as_mm_identity(integer gb_idx := 0) runs on BSSGP_ConnHdlr {
var MobileL3_CommonIE_Types.MobileIdentityLV mi;
[is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_ID_REQ('001'B)) {
@@ -591,6 +597,7 @@
var PDU_L3_MS_SGSN l3_mo;
var PDU_L3_SGSN_MS l3_mt;
var default di := activate(as_mm_identity(gb_idx));
+ var default commonid := activate(as_ranap_common_id(gb_idx));
if (g_pars.net.expect_auth) {
var GSUP_IE auth_tuple;
var template AuthenticationParameterAUTNTLV autn;
@@ -655,7 +662,9 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen :=
0; /*standard_UMTS_integrity_algorithm_UIA1;*/
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
-
//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
+
+ /* allow to common id to be received */
+ f_sleep(1.0);
}
}
} else {
@@ -663,6 +672,7 @@
f_sleep(1.0);
}
+ deactivate(commonid);
deactivate(di);
}
@@ -2359,6 +2369,7 @@
var PDU_L3_SGSN_MS l3_mt;
var PDU_DTAP_PS_MT mt;
var template OCT4 p_tmsi := omit;
+ var default commonid := activate(as_ranap_common_id(bssgp));
if (send_ptmsi) {
p_tmsi := g_pars.p_tmsi;
@@ -2390,11 +2401,15 @@
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 0;
/*standard_UMTS_integrity_algorithm_UIA1;*/
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
-
//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
+
+ /* allow to common id to be received */
+ f_sleep(1.0);
}
[is_gb(bssgp)] BSSGP[bssgp].receive { repeat; }
[is_iu(bssgp)] BSSAP.receive { repeat; }
}
+
+ deactivate(commonid);
}
private function f_TC_attach_rau_a_a(charstring id) runs on BSSGP_ConnHdlr {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15398
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I3d4d0aa83c0365969039613d7539d0e7d816afa7
Gerrit-Change-Number: 15398
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable bssgp with gb_idx
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399
Change subject: sgsn: replace variable bssgp with gb_idx
..
sgsn: replace variable bssgp with gb_idx
gb_idx is common used as variable for the index of the bssgb array.
Be consistent and use the same variable name everywhere.
Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
---
M sgsn/SGSN_Tests.ttcn
M sgsn/SGSN_Tests_Iu.ttcn
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/99/15399/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index e4a5cbf..c486be1 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2365,7 +2365,7 @@
f_cleanup();
}
-friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer
bssgp := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
+friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer
gb_idx := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
var PDU_L3_SGSN_MS l3_mt;
var PDU_DTAP_PS_MT mt;
var template OCT4 p_tmsi := omit;
@@ -2375,29 +2375,29 @@
p_tmsi := g_pars.p_tmsi;
}
/* then send RAU */
- f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra,
false, omit, omit, p_tmsi), bssgp, initial := true);
+ f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra,
false, omit, omit, p_tmsi), gb_idx, initial := true);
alt {
- [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {
-
f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
- f_send_l3(ts_GMM_RAU_COMPL, bssgp);
+ [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt
{
+
f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, gb_idx);
+ f_send_l3(ts_GMM_RAU_COMPL, gb_idx);
setverdict(pass);
}
- [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) ->
value mt {
-
f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
- f_send_l3(ts_GMM_RAU_COMPL, bssgp);
+ [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) ->
value mt {
+
f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, gb_idx);
+ f_send_l3(ts_GMM_RAU_COMPL, gb_idx);
setverdict(pass);
}
- [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_REJECT) {
+ [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_RAU_REJECT) {
setverdict(fail, "Unexpected RAU Reject");
mtc.stop;
}
- [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {
+ [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {
setverdict(fail, "Unexpected RAU Reject");
mtc.stop;
}
- [is_iu(bssgp)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?,
uia_key := oct2bit(g_pars.vec.ik),
+ [is_iu(gb_idx)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?,
uia_key := oct2bit(g_pars.vec.ik),
key_sts := ?)) {
var IntegrityProtectionAlgorithm uia_chosen := 0;
/*standard_UMTS_integrity_algorithm_UIA1;*/
BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
@@ -2405,8 +2405,8 @@
/* allow to common id to be received */
f_sleep(1.0);
}
- [is_gb(bssgp)] BSSGP[bssgp].receive { repeat; }
- [is_iu(bssgp)] BSSAP.receive { repeat; }
+ [is_gb(gb_idx)] BSSGP[gb_idx].receive { repeat; }
+ [is_iu(gb_idx)] BSSAP.receive { repeat; }
}
deactivate(commonid);
diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index 50118c7..c0830ee 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -61,7 +61,7 @@
f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false,
gb_idx := 0);
/* do a routing area update */
- f_routing_area_update(g_pars.ra, bssgp := 3, send_ptmsi := true);
+ f_routing_area_update(g_pars.ra, gb_idx := 3, send_ptmsi := true);
setverdict(pass);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8
Gerrit-Change-Number: 15399
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: sgsn: add Iu Attach Request
lynxis lazus has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 ) Change subject: sgsn: add Iu Attach Request .. sgsn: add Iu Attach Request MS -> SGSN: Attach Request IMSI MS <- SGSN: Identity Request IMEI MS -> SGSN: Identity Response IMEI MS <- SGSN: Auth Request MS -> SGSN: Auth Response MS <- SGSN: Attach Accept MS -> SGSN: Attach Complete Change-Id: I66069e31c30d33934ad57cc2b8794f56ffd5c7d6 --- M sgsn/SGSN_Tests.ttcn A sgsn/SGSN_Tests_Iu.ttcn 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/13866/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66069e31c30d33934ad57cc2b8794f56ffd5c7d6 Gerrit-Change-Number: 13866 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: L3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signature
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15395
Change subject: L3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signature
..
L3 Templates: PDU_L3_MS_SGSN: export ptmsi in template signature
Iu packets needs to contain an ptmsi as tlv in difference to Gb.
Change-Id: I7ba51a28524261dd1c7f4f2586ee6ebc970ea944
---
M library/L3_Templates.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/95/15395/1
diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn
index bc0e797..98bc758 100644
--- a/library/L3_Templates.ttcn
+++ b/library/L3_Templates.ttcn
@@ -2126,7 +2126,8 @@
RoutingAreaIdentificationV old_ra,
boolean follow_on_pending := false,
template (omit) MobileStationClassmark2_TLV cm2_tlv,
- template (omit) MobileStationClassmark3_TLV cm3_tlv
+ template (omit) MobileStationClassmark3_TLV cm3_tlv,
+ template (omit) OCT4 p_tmsi := omit
) := {
discriminator := ''B, /* overwritten */
tiOrSkip := {
@@ -2144,7 +2145,7 @@
readyTimerValue := omit,
drxParameter := omit,
tmsiStatus := omit,
- ptmsi := omit,
+ ptmsi := ts_MI_TMSI_TLV(p_tmsi),
mSNetworkCapability := omit,
pdpContextStatus := omit, /* TODO */
pC_LCSCapability := omit,
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15395
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I7ba51a28524261dd1c7f4f2586ee6ebc970ea944
Gerrit-Change-Number: 15395
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: sgsn: extend f_routing_area_update() to support Iu
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396
Change subject: sgsn: extend f_routing_area_update() to support Iu
..
sgsn: extend f_routing_area_update() to support Iu
Allow Iu tests to use f_routing_area_update()
Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 28 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/96/15396/1
diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index 6e82c56..d210182 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -2355,22 +2355,45 @@
f_cleanup();
}
-private function f_routing_area_update(RoutingAreaIdentificationV ra, integer
bssgp := 0) runs on BSSGP_ConnHdlr {
+friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer
bssgp := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {
var PDU_L3_SGSN_MS l3_mt;
+ var PDU_DTAP_PS_MT mt;
+ var template OCT4 p_tmsi := omit;
+ if (send_ptmsi) {
+ p_tmsi := g_pars.p_tmsi;
+ }
/* then send RAU */
- f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra,
false, omit, omit), bssgp);
+ f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra,
false, omit, omit, p_tmsi), bssgp, initial := true);
alt {
- [] BSSGP[bssgp].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {
+ [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {
f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
f_send_l3(ts_GMM_RAU_COMPL, bssgp);
setverdict(pass);
}
- [] BSSGP[bssgp].receive(tr_GMM_RAU_REJECT) {
+ [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) ->
value mt {
+
f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);
+ f_send_l3(ts_GMM_RAU_COMPL, bssgp);
+ setverdict(pass);
+ }
+
+ [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_REJECT) {
setverdict(fail, "Unexpected RAU Reject");
mtc.stop;
}
- [] BSSGP[bssgp].receive { repeat; }
+ [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {
+ setverdict(fail, "Unexpected RAU Reject");
+ mtc.stop;
+ }
+
+ [is_iu(bssgp)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?,
uia_key := oct2bit(g_pars.vec.ik),
+ key_sts := ?)) {
+ var IntegrityProtectionAlgorithm uia_chosen := 0;
/*standard_UMTS_integrity_algorithm_UIA1;*/
+ BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));
+
//BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));
+ }
+ [is_gb(bssgp)] BSSGP[bssgp].receive { repeat; }
+ [is_iu(bssgp)] BSSAP.receive { repeat; }
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15396
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic03952a04c00a4fc437ef39c5ee046549c122c8b
Gerrit-Change-Number: 15396
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Hello pespin, laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
to look at the new patch set (#3).
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure. All test cases fail on my
machine because of an unbound reference object.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_iu_attach_geran_rau
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163 to look at the new patch set (#2). Change subject: sgsn: add TC_iu_attach_geran_rau .. sgsn: add TC_iu_attach_geran_rau do a GMM attach on Iu do a GMM Routing Area Update on GMM Change-Id: Ie043639638a640a2041324fc910964385a41c77d fixme: This will crash the SGSN atm :) --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/15163/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie043639638a640a2041324fc910964385a41c77d Gerrit-Change-Number: 15163 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: introduce f_send_l3() to allow one function for Gb & Iu
Hello neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 to look at the new patch set (#2). Change subject: sgsn: introduce f_send_l3() to allow one function for Gb & Iu .. sgsn: introduce f_send_l3() to allow one function for Gb & Iu f_send_l3() replaces f_send_l3_gmm_llc() to have one function which sends L3 messages for Iu and Gb at the same time. This allows to share most of the tests between Iu & Gb. Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 129 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/15171/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If47ad2be459ca7b87d9071d9ff020a51821e4433 Gerrit-Change-Number: 15171 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
Change in ...osmo-ttcn3-hacks[master]: sgsn: add TC_geran_attach_iu_rau
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
Change subject: sgsn: add TC_geran_attach_iu_rau
..
sgsn: add TC_geran_attach_iu_rau
Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
---
M sgsn/SGSN_Tests_Iu.ttcn
1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/97/15397/1
diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn
index d6007b3..50118c7 100644
--- a/sgsn/SGSN_Tests_Iu.ttcn
+++ b/sgsn/SGSN_Tests_Iu.ttcn
@@ -54,10 +54,31 @@
vc_conn.done;
}
+private function f_TC_geran_attach_iu_rau(charstring id) runs on
BSSGP_ConnHdlr {
+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));
+
+ /* first perform regular attach */
+ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false,
gb_idx := 0);
+
+ /* do a routing area update */
+ f_routing_area_update(g_pars.ra, bssgp := 3, send_ptmsi := true);
+ setverdict(pass);
+}
+
+testcase TC_geran_attach_iu_rau() runs on test_CT {
+ var BSSGP_ConnHdlr vc_conn;
+ g_ranap_enable := true;
+ f_init();
+ f_sleep(1.0);
+ vc_conn := f_start_handler(refers(f_TC_geran_attach_iu_rau),
testcasename(), g_gb, 1003);
+ vc_conn.done;
+}
+
control {
execute( TC_iu_attach() );
/* FIXME: will crash the sgsn
-* execute( TC_iu_attach_geran_rau() ); */
+* execute( TC_iu_attach_geran_rau() );
+* execute( TC_geran_attach_iu_rau() ); */
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15397
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id23244aa6ca329579300b66b73ce238bd4d01eef
Gerrit-Change-Number: 15397
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...pysim[master]: Add an option to read the iccid and batch-program the new card data
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/15394
Change subject: Add an option to read the iccid and batch-program the new card
data
..
Add an option to read the iccid and batch-program the new card data
This can be used to reprogram everything including IMSI on the card:
while true; do
./pySim-prog.py -p 0 -t sysmoUSIM-SJS1 --source=csv --read-csv=cards.csv
--read-iccid &&
paplay complete.oga
sleep 2
done
Change-Id: Ib343a29141b5255f67a59ab76959b51e162b7916
---
M pySim-prog.py
1 file changed, 26 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/94/15394/1
diff --git a/pySim-prog.py b/pySim-prog.py
index 2ac4dad..8abce0a 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -39,7 +39,7 @@
from pySim.commands import SimCardCommands
from pySim.cards import _cards_classes
-from pySim.utils import h2b, swap_nibbles, rpad, derive_milenage_opc,
calculate_luhn
+from pySim.utils import h2b, swap_nibbles, rpad, derive_milenage_opc,
calculate_luhn, dec_iccid
from pySim.ts_51_011 import EF
def parse_options():
@@ -131,6 +131,9 @@
parser.add_option("--read-imsi", dest="read_imsi", action="store_true",
help="Read the IMSI from the CARD", default=False
)
+ parser.add_option("--read-iccid", dest="read_iccid",
action="store_true",
+ help="Read the ICCID from the CARD", default=False
+ )
parser.add_option("-z", "--secret", dest="secret", metavar="STR",
help="Secret used for ICCID/IMSI autogen",
)
@@ -171,8 +174,8 @@
return options
if options.source == 'csv':
- if (options.imsi is None) and (options.batch_mode is False) and
(options.read_imsi is False):
- parser.error("CSV mode needs either an IMSI,
--read-imsi or batch mode")
+ if (options.imsi is None) and (options.batch_mode is False) and
(options.read_imsi is False) and (options.read_iccid is False):
+ parser.error("CSV mode needs either an IMSI,
--read-imsi, --read-iccid or batch mode")
if options.read_csv is None:
parser.error("CSV mode requires a CSV input file")
elif options.source == 'cmdline':
@@ -444,7 +447,7 @@
cw.writerow([params[x] for x in row])
f.close()
-def _read_params_csv(opts, imsi):
+def _read_params_csv(opts, iccid=None, imsi=None):
import csv
f = open(opts.read_csv, 'r')
cr = csv.DictReader(f)
@@ -452,11 +455,15 @@
if not 'iccid' in cr.fieldnames:
raise Exception("CSV file in wrong format!")
for row in cr:
- if opts.num is not None and opts.read_imsi is False:
+ if opts.num is not None and opts.read_iccid is False and
opts.read_imsi is False:
if opts.num == i:
f.close()
return row;
i += 1
+ if row['iccid'] == iccid:
+ f.close()
+ return row;
+
if row['imsi'] == imsi:
f.close()
return row;
@@ -464,8 +471,8 @@
f.close()
return None
-def read_params_csv(opts, imsi):
- row = _read_params_csv(opts, imsi)
+def read_params_csv(opts, imsi=None, iccid=None):
+ row = _read_params_csv(opts, iccid=iccid, imsi=imsi)
if row is not None:
row['mcc'] = int(row.get('mcc', row['imsi'][0:3]))
row['mnc'] = int(row.get('mnc', row['imsi'][3:5]))
@@ -655,7 +662,17 @@
if opts.source == 'cmdline':
cp = gen_parameters(opts)
elif opts.source == 'csv':
- if opts.read_imsi:
+imsi = None
+iccid = None
+ if opts.read_iccid:
+ if opts.dry_run:
+ # Connect transport
+ print "Insert card now (or CTRL-C to
cancel)"
+ sl.wait_for_card(newcardonly=not first)
+ (res,_) = scc.read_binary(['3f00', '2fe2'],
length=10)
+ iccid = dec_iccid(res)
+print iccid
+elif opts.read_imsi:
if opts.dry_run:
# Connect transport
print "Insert card now (or CTRL-C to
cancel)"
@@ -664,7 +681,7 @@
imsi = swap_nibbles(res)[3:]
else:
imsi = opts.imsi
Change in ...pysim[master]: pySim-prog: Print out hex-escaped pin_adm in card parameters
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/15392
Change subject: pySim-prog: Print out hex-escaped pin_adm in card parameters
..
pySim-prog: Print out hex-escaped pin_adm in card parameters
Use h2b to convert pin_adm back to binary form for sysmoSIMgr2
Change-Id: Ia178c9938f3e6a4fbac24d767437894297d1e708
---
M pySim-prog.py
M pySim/cards.py
2 files changed, 10 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/92/15392/1
diff --git a/pySim-prog.py b/pySim-prog.py
index 2638eef..7edadd7 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -406,14 +406,15 @@
def print_parameters(params):
print """Generated card parameters :
- > Name: %(name)s
- > SMSP: %(smsp)s
- > ICCID : %(iccid)s
- > MCC/MNC : %(mcc)d/%(mnc)d
- > IMSI: %(imsi)s
- > Ki : %(ki)s
- > OPC : %(opc)s
- > ACC : %(acc)s
+ > Name : %(name)s
+ > SMSP : %(smsp)s
+ > ICCID: %(iccid)s
+ > MCC/MNC : %(mcc)d/%(mnc)d
+ > IMSI : %(imsi)s
+ > Ki : %(ki)s
+ > OPC : %(opc)s
+ > ACC : %(acc)s
+ > ADM1(hex): %(pin_adm)s
"""% params
diff --git a/pySim/cards.py b/pySim/cards.py
index 55282aa..cda337a 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -496,7 +496,7 @@
# P2: CHV number, as in VERIFY CHV for PIN, and as in UNBLOCK
CHV for PUK
# P3: 08, CHV length (curiously the PUK is also 08 length,
instead of 10)
if p['pin_adm']:
- pin = p['pin_adm']
+ pin = h2b(p['pin_adm'])
else:
pin = h2b("")
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/15392
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia178c9938f3e6a4fbac24d767437894297d1e708
Gerrit-Change-Number: 15392
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in ...pysim[master]: pySim-prog: Add option for hex ADM keys
daniel has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/15393
Change subject: pySim-prog: Add option for hex ADM keys
..
pySim-prog: Add option for hex ADM keys
pySim-prog would implicitly try to use the raw or hex-escaped format
depending on the length of the parameter, now there is the option "-A"
to explicitly specify the hex-escaped ADM1 key.
pysim-test.sh: Explicitly use the "-A" option to pass the hex adm1 key
for wavemobile cards
Change-Id: Id75a03482aa7f8cc3bdbb8d5967f1e8ab45c179a
---
M pySim-prog.py
M pysim-testdata/Wavemobile-SIM.data
M tests/Wavemobile-SIM.data.example
M tests/pysim-test.sh
4 files changed, 28 insertions(+), 10 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/93/15393/1
diff --git a/pySim-prog.py b/pySim-prog.py
index e00c2d0..2ac4dad 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -73,6 +73,9 @@
parser.add_option("-a", "--pin-adm", dest="pin_adm",
help="ADM PIN used for provisioning (overwrites
default)",
)
+ parser.add_option("-A", "--pin-adm-hex", dest="pin_adm_hex",
+ help="ADM PIN used for provisioning, as hex string (16
characters long",
+ )
parser.add_option("-e", "--erase", dest="erase", action='store_true',
help="Erase beforehand [default: %default]",
default=False,
@@ -376,17 +379,27 @@
else:
opc = ''.join(['%02x' % random.randrange(0,256) for i in
range(16)])
+
+ pin_adm = None
+
if opts.pin_adm is not None:
if len(opts.pin_adm) <= 8:
pin_adm = ''.join(['%02x'%(ord(x)) for x in
opts.pin_adm])
pin_adm = rpad(pin_adm, 16)
- elif len(opts.pin_adm) == 16:
- pin_adm = opts.pin_adm
- else:
- raise ValueError("PIN-ADM needs to be <=8 digits
(ascii) or exactly 16 digits (raw hex)")
- else:
- pin_adm = None
+ else:
+ raise ValueError("PIN-ADM needs to be <=8 digits
(ascii)")
+
+if opts.pin_adm_hex is not None:
+ if len(opts.pin_adm_hex) == 16:
+ pin_adm = opts.pin_adm_hex
+ # Ensure that it's hex-encoded
+ try:
+ try_encode = h2b(pin_adm)
+ except ValueError:
+ raise ValueError("PIN-ADM needs to be hex encoded
using this option")
+ else:
+ raise ValueError("PIN-ADM needs to be exactly 16 digits
(hex encoded)")
# Return that
return {
diff --git a/pysim-testdata/Wavemobile-SIM.data
b/pysim-testdata/Wavemobile-SIM.data
index 46690b4..0c3379a 100644
--- a/pysim-testdata/Wavemobile-SIM.data
+++ b/pysim-testdata/Wavemobile-SIM.data
@@ -1,5 +1,5 @@
MCC=001
MNC=01
IMSI=00101000102
-ADM=15E31383624FDC8A
+ADM_HEX=15E31383624FDC8A
diff --git a/tests/Wavemobile-SIM.data.example
b/tests/Wavemobile-SIM.data.example
index e9ba965..bdf2d65 100644
--- a/tests/Wavemobile-SIM.data.example
+++ b/tests/Wavemobile-SIM.data.example
@@ -1,5 +1,5 @@
MCC=001
MNC=01
IMSI=00101000102
-ADM=0123456789ABCDEF
+ADM_HEX=0123456789ABCDEF
diff --git a/tests/pysim-test.sh b/tests/pysim-test.sh
index 5af7a93..f97722d 100755
--- a/tests/pysim-test.sh
+++ b/tests/pysim-test.sh
@@ -156,9 +156,14 @@
OPC=
IMSI=0010101
ADM=
+ ADM_OPT="-a"
- . "$CARD_NAME.data"
- python $PYSIM_PROG -p $I -t $CARD_NAME -o $OPC -k $KI -x $MCC -y $MNC
-i $IMSI -s $ICCID -a $ADM
+ source "$CARD_NAME.data"
+ if [ -n "$ADM_HEX" ]; then
+ ADM_OPT="-A"
+ ADM=$ADM_HEX
+ fi
+ python $PYSIM_PROG -p $I -t $CARD_NAME -o $OPC -k $KI -x $MCC -y $MNC
-i $IMSI -s $ICCID $ADM_OPT $ADM
check_card $I $CARD_NAME
echo ""
done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/15393
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id75a03482aa7f8cc3bdbb8d5967f1e8ab45c179a
Gerrit-Change-Number: 15393
Gerrit-PatchSet: 1
Gerrit-Owner: daniel
Gerrit-MessageType: newchange
Change in ...pysim[master]: pySim-prog: Use CSV format with headers
daniel has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/15313 ) Change subject: pySim-prog: Use CSV format with headers .. pySim-prog: Use CSV format with headers This way we can have optional fields like pin_adm in the file Also require iccid as identifier for the SIM card Set defaults for optional card parameters. Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 --- A csv-format M pySim-prog.py 2 files changed, 44 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/15313/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 PS5, Line 802: rc = 0; > I hope at some point this "rc = 0" is moved up in order to set rc if !ue > condition is hit, otherwise […] rc is initilized with -1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 18:08:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:44:55 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15180 ) Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15180/5/src/iu_client.c@802 PS5, Line 802: rc = 0; I hope at some point this "rc = 0" is moved up in order to set rc if !ue condition is hit, otherwise it looks like rc will be returned uninitialized. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:43:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15182 ) Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:42:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 ) Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound .. Patch Set 2: I'm surprised about this patch. Which tests fail in your case? which testsuite? AFAIU this function is only called so far for SGSN_Tests and ba exists there, and tests pass in my setup and in jenkins. How can you call f_Ran_adapter_cleanup() with ba being unbound? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef Gerrit-Change-Number: 15391 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 17:39:49 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Hello pespin, laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
to look at the new patch set (#2).
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure. All test cases fail on my
machine because of an unbound reference object.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 to look at the new patch set (#10). Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. iu_client: introduce ranap_iu_free_ue() to free the UE connections When freeing the UE connection object, disconnect the SCCP connection. Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/61/15161/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 9: (2 comments) https://gerrit.osmocom.org/#/c/15161/6//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15161/6//COMMIT_MSG@9 PS6, Line 9: SCTP > SCCP Done https://gerrit.osmocom.org/#/c/15161/6/include/osmocom/ranap/iu_client.h File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/#/c/15161/6/include/osmocom/ranap/iu_client.h@75 PS6, Line 75: SCTP > SCCP Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 16:45:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@139 PS8, Line 139: osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0); > So far, the SGSN doesn't know so much about sccp connection (since 2g isn't > connection oriented). […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 16:42:17 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 to look at the new patch set (#9). Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. iu_client: introduce ranap_iu_free_ue() to free the UE connections When freeing the UE connection object, disconnect the SCTP connection. Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/61/15161/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 to look at the new patch set (#9). Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 --- M src/iu_client.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/15182/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: don't decode empty disconnect indications
Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 to look at the new patch set (#5). Change subject: iu_client: sccp_sap_up: don't decode empty disconnect indications .. iu_client: sccp_sap_up: don't decode empty disconnect indications Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 --- M src/iu_client.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/80/15180/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I1fea8f19433d908583de71d8d2401bbb8c0c7900 Gerrit-Change-Number: 15180 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: sccp_sap_up: set rc early
lynxis lazus has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-iuh/+/15179 )
Change subject: iu_client: sccp_sap_up: set rc early
..
iu_client: sccp_sap_up: set rc early
Allows to skip assignment later.
Change-Id: Idd803774612719df144bef569fb734289aa31282
---
M src/iu_client.c
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
laforge: Looks good to me, approved
diff --git a/src/iu_client.c b/src/iu_client.c
index 92d25f5..b5f3557 100644
--- a/src/iu_client.c
+++ b/src/iu_client.c
@@ -764,7 +764,7 @@
struct osmo_sccp_user *scu = _scu;
struct osmo_scu_prim *prim = (struct osmo_scu_prim *) oph;
struct osmo_prim_hdr *resp = NULL;
- int rc;
+ int rc = -1;
struct ranap_ue_conn_ctx *ue;
struct new_ue_conn_ctx new_ctx = {};
@@ -773,7 +773,6 @@
switch (OSMO_PRIM_HDR(oph)) {
case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_CONFIRM):
/* confirmation of outbound connection */
- rc = -1;
break;
case OSMO_PRIM(OSMO_SCU_PRIM_N_CONNECT, PRIM_OP_INDICATION):
/* indication of new inbound connection request*/
@@ -814,7 +813,6 @@
rc = ranap_cn_rx_cl(cn_ranap_handle_cl, prim,
msgb_l2(oph->msg), msgb_l2len(oph->msg));
break;
default:
- rc = -1;
break;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15179
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Idd803774612719df144bef569fb734289aa31282
Gerrit-Change-Number: 15179
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-iuh[master]: iu_client: ensure UE is not NULL on CO primitives
lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15178 ) Change subject: iu_client: ensure UE is not NULL on CO primitives .. iu_client: ensure UE is not NULL on CO primitives When ue_conn_ctx_find() can not find a UE it returns NULL. Change-Id: I63222fda6778417b1c986cb05772fecc51c43bb5 --- M src/iu_client.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/iu_client.c b/src/iu_client.c index b5f3557..8da9a43 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -796,6 +796,9 @@ LOGPIU(LOGL_DEBUG, "N-DISCONNECT.ind(%u)\n", prim->u.disconnect.conn_id); ue = ue_conn_ctx_find(prim->u.disconnect.conn_id); + if (!ue) + break; + rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); break; case OSMO_PRIM(OSMO_SCU_PRIM_N_DATA, PRIM_OP_INDICATION): @@ -804,6 +807,9 @@ osmo_hexdump(msgb_l2(oph->msg), msgb_l2len(oph->msg))); /* resolve UE context */ ue = ue_conn_ctx_find(prim->u.data.conn_id); + if (!ue) + break; + rc = ranap_cn_rx_co(cn_ranap_handle_co, ue, msgb_l2(oph->msg), msgb_l2len(oph->msg)); break; case OSMO_PRIM(OSMO_SCU_PRIM_N_UNITDATA, PRIM_OP_INDICATION): -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15178 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I63222fda6778417b1c986cb05772fecc51c43bb5 Gerrit-Change-Number: 15178 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 8: (2 comments) https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@139 PS8, Line 139: osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0); > I don't really like the idea of calling tx_disconn inside free() function, > imho tx_disconn should be […] So far, the SGSN doesn't know so much about sccp connection (since 2g isn't connection oriented). The sccp connection has the same lifetime as this object, since only connected objects makes sense. Unconnected objects should only be present while the cleanup in sgsn happens. https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@816 PS8, Line 816: /* A Iu Release event might be used to free the UE in cn_ranap_handle_co. */ > This seems not related to the patch? yes, it's related. it's not needed here, because ue is not used further in this function. In ranap_cn_rx_co() a call towards ranap_iu_free_ue() can happen. I'll move this into the emit signal patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 16:32:35 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
Change subject: RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
..
RAN_Adapter: f_ran_adapter_cleanup() check if adapter is bound
Don't use unbound references to objects, this will
create a dynamic test failure.
Fixes: ce0d615e12be ("sgsn: Proper shutdown of RAN_Adapter components")
Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
---
M library/RAN_Adapter.ttcnpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/91/15391/1
diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index f84fd34..aed31ed 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -191,6 +191,10 @@
}
function f_ran_adapter_cleanup(inout RAN_Adapter ba) {
+ if (not isbound(ba)) {
+ return;
+ }
+
if (ba.vc_RAN != null) {
if (ba.transport == RANAP_TRANSPORT_IuCS) {
#ifdef RAN_EMULATION_RANAP
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15391
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9c974a850949829728c35cf5dbdd0858fdef
Gerrit-Change-Number: 15391
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in ...osmo-msc[master]: fix error on BSSMAP Cipher Mode Complete L3 msg IE
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15317 ) Change subject: fix error on BSSMAP Cipher Mode Complete L3 msg IE .. Patch Set 6: as indicated, I'm not arguing that right now you are smart enough to know it is safe. But what about the next 5... years down the road, after (god forbid) another refactoring, ...? Just do msgb_alloc() and prevent any related issues once and for all. Why micro-optimize this particular use case at the cost of having some different behavior than in any other code path in any other osmocom program? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd8dad18d6dda24d075dd8da72c3d6db1302090d Gerrit-Change-Number: 15317 Gerrit-PatchSet: 6 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:13:20 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: src/gprs/Makefile.am: Move build of shared .c files to an internal lib
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15360 ) Change subject: src/gprs/Makefile.am: Move build of shared .c files to an internal lib .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib7665c530c086a5f3135c395bb8bf19ed4a882b6 Gerrit-Change-Number: 15360 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 03 Sep 2019 16:10:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Split out GPRS SM layer into its own file
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15386 ) Change subject: Split out GPRS SM layer into its own file .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie61d22e7868af6de73cdf9c731f07130b282599d Gerrit-Change-Number: 15386 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:09:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gmm: Move code handling GMM PTMSI Realloc Complete to its own function
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15382 ) Change subject: gmm: Move code handling GMM PTMSI Realloc Complete to its own function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15382 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3b21a976c6683bea5419a33f0ccb8b56483d6e21 Gerrit-Change-Number: 15382 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:08:42 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: enum gprs_gmm_state: Fix spec reference
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15383 ) Change subject: enum gprs_gmm_state: Fix spec reference .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15383 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I62121e46e5091e5b559397aa01f107ddc23e2c18 Gerrit-Change-Number: 15383 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:08:49 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gmm: Move code handling GMM Routing Area Update Complete to its own f...
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15381 ) Change subject: gmm: Move code handling GMM Routing Area Update Complete to its own function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8e28ac03edf82374e804701ebe635e1171a2b36a Gerrit-Change-Number: 15381 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:08:32 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Move out sgsn to its own subdir
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15363 ) Change subject: Move out sgsn to its own subdir .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16fccc0eadf588599b9e5578d0f4dbaf9df81737 Gerrit-Change-Number: 15363 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:07:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: gmm: Move code handling GMM Attach Complete to its own function
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15380 ) Change subject: gmm: Move code handling GMM Attach Complete to its own function .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15380 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2d8d947ab1eb4100f404b885461f7a30583c9ac6 Gerrit-Change-Number: 15380 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 16:08:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Delete previously activated pdp ctx in *_interact()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 ) Change subject: ggsn: Delete previously activated pdp ctx in *_interact() .. Patch Set 1: Code-Review+2 +2 myself since this fix is pretty obvious and this way this night tests will already be fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a Gerrit-Change-Number: 15390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 15:39:47 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Delete previously activated pdp ctx in *_interact()
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 ) Change subject: ggsn: Delete previously activated pdp ctx in *_interact() .. ggsn: Delete previously activated pdp ctx in *_interact() This change fixes some GGSN_Tests failing lately since osmo-ggsn correctly sends DeleteCtxReq for dangling pdp ctx upon increased Recovery counter received, and tests are not expecting that (because they don't expectect dangling pdp ctx from previous tests). Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 4a53fa1..44dba4a 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -958,6 +958,7 @@ f_wait_gtpu_fail(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Test PDP context activation for dynamic IPv4 EUA without DNS request */ @@ -1089,6 +1090,7 @@ f_wait_icmp4_echo_request(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1345,6 +1347,7 @@ f_wait_gtpu_fail(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only APN */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a Gerrit-Change-Number: 15390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/15387 ) Change subject: ipa: ipa_server_link_close() add checks of link state .. Patch Set 4: Code-Review-1 Some day I'll discover how do you manage to submit several new versions of a patch without taking into consideration any of my comments... -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 15:37:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 8: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@139 PS8, Line 139: osmo_sccp_tx_disconn(g_scu, ue_ctx->conn_id, NULL, 0); I don't really like the idea of calling tx_disconn inside free() function, imho tx_disconn should be called by the user if possible before calling free() https://gerrit.osmocom.org/#/c/15161/8/src/iu_client.c@816 PS8, Line 816: /* A Iu Release event might be used to free the UE in cn_ranap_handle_co. */ This seems not related to the patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 15:33:32 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15161 ) Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 15:31:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15182 ) Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 15:29:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 to look at the new patch set (#4). Change subject: ipa: ipa_server_link_close() add checks of link state .. ipa: ipa_server_link_close() add checks of link state When closing a link which failed on open, ipa_server_link_close() would crash it when calling osmo_fd_unregister. Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 --- M src/input/ipa.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/15387/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
lynxis lazus has removed a vote on this change. Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. Removed Code-Review-2 by lynxis lazus -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote
Change in ...osmo-iuh[master]: iu_client: introduce ranap_iu_free_ue() to free the UE connections
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 to look at the new patch set (#8). Change subject: iu_client: introduce ranap_iu_free_ue() to free the UE connections .. iu_client: introduce ranap_iu_free_ue() to free the UE connections When freeing the UE connection object, disconnect the SCTP connection. Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b --- M include/osmocom/ranap/iu_client.h M src/iu_client.c 2 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/61/15161/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6812edb4da487507ccf9f483de801c1c65c4b72b Gerrit-Change-Number: 15161 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect in...
Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 to look at the new patch set (#8). Change subject: iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication .. iu_client: emit RANAP_IU_EVENT_LINK_INVALIDATED on SCCP disconnect indication Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 --- M src/iu_client.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/15182/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15182 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I168b5c67336c4d1cb9fcebb9c26a7cf2fc46e420 Gerrit-Change-Number: 15182 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-iuh[master]: iu_client: introduce a connection state
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/15181 ) Change subject: iu_client: introduce a connection state .. Patch Set 5: Code-Review-2 (2 comments) I've to reconsider this https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c File src/iu_client.c: https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@119 PS3, Line 119: ctx->conn_state = RANAP_CONN_STATE_CONNECTED; > Should be DISCONNECTED. no. should be connected. https://gerrit.osmocom.org/#/c/15181/3/src/iu_client.c@823 PS3, Line 823: ue->conn_state = RANAP_CONN_STATE_CONNECTED; > Should be DISCONNECTED. right. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/15181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I77e01724be05ac488a4685ba367b7a71985b54e3 Gerrit-Change-Number: 15181 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 14:39:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 743s] ar: `u' modifier ignored since `D' is the default (see `U') [ 743s] libtool: link: ranlib .libs/libtransceiver_common.a [ 743s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 743s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 744s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 744s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 744s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 744s] collect2: error: ld returned 1 exit status [ 744s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 744s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 744s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 744s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 744s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 744s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 744s] make[1]: *** [Makefile:444: all] Error 2 [ 744s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 744s] dh_auto_build: make -j1 returned exit code 2 [ 744s] make: *** [debian/rules:6: build] Error 255 [ 744s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 744s] [ 744s] cloud121 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Tue Sep 3 14:19:04 UTC 2019. [ 744s] [ 744s] ### VM INTERACTION START ### [ 747s] [ 693.171367] sysrq: SysRq : Power Off [ 747s] [ 693.178217] reboot: Power down [ 749s] ### VM INTERACTION END ### [ 749s] [ 749s] cloud121 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Tue Sep 3 14:19:09 UTC 2019. [ 749s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 529s] ar: `u' modifier ignored since `D' is the default (see `U') [ 529s] libtool: link: ranlib .libs/libtransceiver_common.a [ 529s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 529s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 530s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 530s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 530s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 530s] collect2: error: ld returned 1 exit status [ 530s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 530s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 530s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 530s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 530s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 530s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 530s] make[1]: *** [Makefile:444: all] Error 2 [ 530s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 530s] dh_auto_build: make -j1 returned exit code 2 [ 530s] make: *** [debian/rules:6: build] Error 255 [ 530s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 530s] [ 530s] lamb03 failed "build osmo-trx_1.1.1.dsc" at Tue Sep 3 14:12:16 UTC 2019. [ 530s] [ 530s] ### VM INTERACTION START ### [ 533s] [ 512.660497] sysrq: SysRq : Power Off [ 533s] [ 512.684832] reboot: Power down [ 533s] ### VM INTERACTION END ### [ 533s] [ 533s] lamb03 failed "build osmo-trx_1.1.1.dsc" at Tue Sep 3 14:12:20 UTC 2019. [ 533s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 500s] ar: `u' modifier ignored since `D' is the default (see `U') [ 500s] libtool: link: ranlib .libs/libtransceiver_common.a [ 500s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 500s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 500s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 500s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 500s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 500s] collect2: error: ld returned 1 exit status [ 500s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 500s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 500s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 500s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 501s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 501s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 501s] make[1]: *** [Makefile:444: all] Error 2 [ 501s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 501s] dh_auto_build: make -j1 returned exit code 2 [ 501s] make: *** [debian/rules:6: build] Error 255 [ 501s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 501s] [ 501s] lamb24 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Tue Sep 3 14:12:11 UTC 2019. [ 501s] [ 501s] ### VM INTERACTION START ### [ 504s] [ 481.774797] sysrq: SysRq : Power Off [ 504s] [ 481.802948] reboot: Power down [ 504s] ### VM INTERACTION END ### [ 504s] [ 504s] lamb24 failed "build osmo-trx_1.1.1.10.77f3.dsc" at Tue Sep 3 14:12:14 UTC 2019. [ 504s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 446s] ar: `u' modifier ignored since `D' is the default (see `U') [ 446s] libtool: link: ranlib .libs/libtransceiver_common.a [ 446s] libtool: link: ( cd ".libs" && rm -f "libtransceiver_common.la" && ln -s "../libtransceiver_common.la" "libtransceiver_common.la" ) [ 446s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -luhd [ 447s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-uhd osmo_trx_uhd-osmo-trx.o ./device/uhd/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/x86_64-linux-gnu/libosmoctrl.so /usr/lib/x86_64-linux-gnu/libosmogsm.so -ltalloc /usr/lib/x86_64-linux-gnu/libosmovty.so /usr/lib/x86_64-linux-gnu/libosmocore.so -luhd [ 447s] /usr/bin/ld: ./device/uhd/.libs/libdevice.a(UHDDevice.o): undefined reference to symbol '_ZN5boost6system16generic_categoryEv' [ 447s] /usr/bin/ld: /usr/lib/x86_64-linux-gnu/libboost_system.so.1.67.0: error adding symbols: DSO missing from command line [ 447s] collect2: error: ld returned 1 exit status [ 447s] make[4]: *** [Makefile:681: osmo-trx-uhd] Error 1 [ 447s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 447s] make[3]: *** [Makefile:820: all-recursive] Error 1 [ 447s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 447s] make[2]: *** [Makefile:513: all-recursive] Error 1 [ 447s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 447s] make[1]: *** [Makefile:444: all] Error 2 [ 447s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 447s] dh_auto_build: make -j1 returned exit code 2 [ 447s] make: *** [debian/rules:6: build] Error 255 [ 447s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 447s] [ 447s] lamb04 failed "build osmo-trx_1.1.1.dsc" at Tue Sep 3 13:59:19 UTC 2019. [ 447s] [ 447s] ### VM INTERACTION START ### [ 450s] [ 429.301148] sysrq: SysRq : Power Off [ 450s] [ 429.305314] reboot: Power down [ 450s] ### VM INTERACTION END ### [ 450s] [ 450s] lamb04 failed "build osmo-trx_1.1.1.dsc" at Tue Sep 3 13:59:23 UTC 2019. [ 450s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/)
Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors
neels has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/15342 )
Change subject: ran_dec logging: log message sizes on errors
..
ran_dec logging: log message sizes on errors
Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
---
M src/libmsc/ran_msg_a.c
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libmsc/ran_msg_a.c b/src/libmsc/ran_msg_a.c
index fd8afdc..43e27f6 100644
--- a/src/libmsc/ran_msg_a.c
+++ b/src/libmsc/ran_msg_a.c
@@ -761,13 +761,17 @@
}
if (msgb_l3len(bssmap) < h->length) {
- LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated,
discarding message\n");
+ LOG_RAN_A_DEC(ran_dec, LOGL_ERROR, "BSSMAP data truncated,
discarding message:"
+ " msgb_l3len(bssmap) == %u <
bssmap_header->length == %u\n",
+ msgb_l3len(bssmap), h->length);
return -1;
}
if (msgb_l3len(bssmap) > h->length) {
- LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes
after the BSSMAP data, truncating\n",
-msgb_l3len(bssmap) - h->length);
+ LOG_RAN_A_DEC(ran_dec, LOGL_NOTICE, "There are %u extra bytes
after the BSSMAP data, truncating:"
+ " msgb_l3len(bssmap) == %u >
bssmap_header->length == %u\n",
+ msgb_l3len(bssmap) - h->length,
+ msgb_l3len(bssmap), h->length);
msgb_l3trim(bssmap, h->length);
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15342
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb
Gerrit-Change-Number: 15342
Gerrit-PatchSet: 6
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state
neels has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/15389 )
Change subject: msc_a fsm: ignore state chg to same state
..
msc_a fsm: ignore state chg to same state
We sometimes see errors like
libmsc/msc_a.c:361 msc_a(...){MSC_A_ST_RELEASING}: transition to state
MSC_A_ST_RELEASING not permitted!
i.e. changing state to the state msc_a is already in.
Ignore re-entering the same state for most state changes. However, there is one
state change in msc_a where re-entering the MSC_A_ST_VALIDATE_L3 is necessary
to start the timeout.
Hence add msc_a_state_chg_always() and use that for re-entering
MSC_A_ST_VALIDATE_L3. Change msc_a_state_chg() to skip no-op state changes.
This should silence all no-op state change error messages for msc_a.
Related: OS#4169
Change-Id: I0c74c10b5fa7bbdd6ae3674926cc0393edf15a35
---
M src/libmsc/msc_a.c
M tests/msc_vlr/msc_vlr_test_gsm_authen.err
M tests/msc_vlr/msc_vlr_test_hlr_reject.err
M tests/msc_vlr/msc_vlr_test_hlr_timeout.err
M tests/msc_vlr/msc_vlr_test_ms_timeout.err
5 files changed, 8 insertions(+), 13 deletions(-)
Approvals:
neels: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c
index a082cb8..b414574 100644
--- a/src/libmsc/msc_a.c
+++ b/src/libmsc/msc_a.c
@@ -63,9 +63,15 @@
/* Transition to a state, using the T timer defined in msc_a_fsm_timeouts.
* The actual timeout value is in turn obtained from network->T_defs.
* Assumes local variable fi exists. */
-#define msc_a_state_chg(msc_a, state) \
+#define msc_a_state_chg_always(msc_a, state) \
osmo_tdef_fsm_inst_state_chg((msc_a)->c.fi, state, msc_a_fsm_timeouts,
(msc_a)->c.ran->tdefs, 5)
+/* Same as msc_a_state_chg_always() but ignore if the msc_a already is in the
target state. */
+#define msc_a_state_chg(msc_a, STATE) do { \
+ if ((msc_a)->c.fi->state != STATE) \
+ msc_a_state_chg_always(msc_a, STATE); \
+ } while(0)
+
struct gsm_network *msc_a_net(const struct msc_a *msc_a)
{
return msub_net(msc_a->c.msub);
@@ -1036,7 +1042,7 @@
};
osmo_use_count_make_static_entries(_a->use_count,
msc_a->use_count_buf, ARRAY_SIZE(msc_a->use_count_buf));
/* Start timeout for first state */
- msc_a_state_chg(msc_a, MSC_A_ST_VALIDATE_L3);
+ msc_a_state_chg_always(msc_a, MSC_A_ST_VALIDATE_L3);
return msc_a;
}
diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err
b/tests/msc_vlr/msc_vlr_test_gsm_authen.err
index c9be4ef..4905881 100644
--- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err
+++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err
@@ -1926,7 +1926,6 @@
DMSC msc_a(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){MSC_A_ST_RELEASING}:
RAN encode: CLEAR_COMMAND on GERAN-A
DMSC dummy_msc_i(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){0}: Received
Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST
DREF VLR subscr IMSI-90170004620:MSISDN-46071 -
msc_a_fsm_releasing_onenter: now used by 2 (active-conn,vlr_gsup_rx)
-DMSC msc_a(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){MSC_A_ST_RELEASING}:
transition to state MSC_A_ST_RELEASING not permitted!
DREF VLR subscr IMSI-90170004620:MSISDN-46071 - vlr_gsup_rx: now used by 1
(active-conn)
<-- GSUP rx OSMO_GSUP_MSGT_CHECK_IMEI_RESULT: vlr_gsupc_read_cb() returns 0
msc_a_is_accepted() == false
@@ -2192,7 +2191,6 @@
DMSC msc_a(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){MSC_A_ST_RELEASING}:
RAN encode: CLEAR_COMMAND on GERAN-A
DMSC dummy_msc_i(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){0}: Received
Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST
DREF VLR subscr IMSI-90170004620:MSISDN-46071 -
msc_a_fsm_releasing_onenter: now used by 2 (active-conn,vlr_gsup_rx)
-DMSC msc_a(IMSI-90170004620:MSISDN-46071:GERAN-A:LU){MSC_A_ST_RELEASING}:
transition to state MSC_A_ST_RELEASING not permitted!
DREF VLR subscr IMSI-90170004620:MSISDN-46071 - vlr_gsup_rx: now used by 1
(active-conn)
<-- GSUP rx OSMO_GSUP_MSGT_CHECK_IMEI_ERROR: vlr_gsupc_read_cb() returns 0
msc_a_is_accepted() == false
diff --git a/tests/msc_vlr/msc_vlr_test_hlr_reject.err
b/tests/msc_vlr/msc_vlr_test_hlr_reject.err
index 9d0737a..e4ea226 100644
--- a/tests/msc_vlr/msc_vlr_test_hlr_reject.err
+++ b/tests/msc_vlr/msc_vlr_test_hlr_reject.err
@@ -65,7 +65,6 @@
DMSC msc_a(IMSI-90170004620:GERAN-A:LU){MSC_A_ST_RELEASING}: RAN encode:
CLEAR_COMMAND on GERAN-A
DMSC dummy_msc_i(IMSI-90170004620:GERAN-A:LU){0}: Received Event
MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST
DREF VLR subscr IMSI-90170004620 - msc_a_fsm_releasing_onenter: now used
by 2 (active-conn,vlr_gsup_rx)
-DMSC msc_a(IMSI-90170004620:GERAN-A:LU){MSC_A_ST_RELEASING}: transition to
state
Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"
neels has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/15388 )
Change subject: vlr: don't log about "gratuitous ID RESPONSE"
..
vlr: don't log about "gratuitous ID RESPONSE"
If an ID Response comes in during a non-LU L3 Complete (Paging or CM Service
Request), no event needs to be dispatched. So far vlr_subscr_rx_id_resp()
logged a NOTICE "gratuitous ID RESPONSE?!?" if no lu_fsm is present.
An ID Response can come in particularly as payload with a BSSMAP Cipher Mode
Complete message, even though osmo-msc didn't explicitly ask for it.
It is not an error to get a Cipher Mode Complete containing an ID Response
during Paging or CM Service Request, so remove the confusing log message.
Related: OS#4168 (only loosely related)
Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac
---
M src/libvlr/vlr.c
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
neels: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index de61ba5..ea160b1 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -1182,8 +1182,6 @@
break;
}
osmo_fsm_inst_dispatch(vsub->lu_fsm, event, mi_string);
- } else {
- LOGVSUBP(LOGL_NOTICE, vsub, "gratuitous ID RESPONSE?!?\n");
}
return 0;
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15388
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac
Gerrit-Change-Number: 15388
Gerrit-PatchSet: 2
Gerrit-Owner: neels
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0c74c10b5fa7bbdd6ae3674926cc0393edf15a35 Gerrit-Change-Number: 15389 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 13:58:46 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 ) Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac Gerrit-Change-Number: 15388 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 13:58:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM
Hello lynxis lazus, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 to look at the new patch set (#2). Change subject: Implement GMM State using osmocom FSM .. Implement GMM State using osmocom FSM State machine inspired in the one from TS 24.008 4.1.3.3.1. Some state transitions are inroduced in the code but are still commented out since we lack some functionalitites or improvements in the code to handle different scenarios. Most of the logic is still outside of the FSM, but at least now the states are handled in a sane way triggered by events. Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 --- M include/osmocom/sgsn/Makefile.am A include/osmocom/sgsn/gprs_gmm_fsm.h M include/osmocom/sgsn/gprs_sgsn.h M src/sgsn/Makefile.am M src/sgsn/gprs_gmm.c A src/sgsn/gprs_gmm_fsm.c M src/sgsn/gprs_sgsn.c M src/sgsn/sgsn_libgtp.c M src/sgsn/sgsn_vty.c M tests/sgsn/Makefile.am M tests/sgsn/sgsn_test.c 11 files changed, 261 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/85/15385/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 Gerrit-Change-Number: 15385 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset
Change in ...osmo-sgsn[master]: Implement GMM State using osmocom FSM
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 ) Change subject: Implement GMM State using osmocom FSM .. Patch Set 1: (2 comments) Same comments apply to both 'mm_state_gb_fsm' and 'mm_state_iu_fsm'. https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h File include/osmocom/sgsn/gprs_gmm_state_fsm.h: https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_gmm_state_fsm.h@6 PS1, Line 6: gmm_state_fsm_states > I'm simply following convention of naming _states and _events the fields of > an osmocom FSM. This is fine, I have nothing against '_states' and '_events' postfixes. > It happens to be be by casuality that the machine definition is named "GMM > state" Right now we have 'gmm_state' field in the 'sgsn_mm_ctx' structure. The purpose of this field is to store the current state, so it's logical to call it that way. You're introducing the FSM, so it doesn't make sense to follow the old naming. https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15385/1/include/osmocom/sgsn/gprs_sgsn.h@122 PS1, Line 122: gmm_state_fsm In the other comment I mentioned this field. Let's call it 'gmm_fsm'. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15385 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idecb43c10d66224d4f9ba9320825040ce6cf9a07 Gerrit-Change-Number: 15385 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 03 Sep 2019 11:49:25 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
keith has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/15120 )
Change subject: Implement a global switch on the network to disable call
waiting.
..
Implement a global switch on the network to disable call waiting.
Add a network -> callwaiting VTY command as boolean.
When this is enabled (default) there is no change to
operation previous to this commit.
When this switch is disabled with "no call-waiting" in vty
then when a call arrives, we will check if we have an active
call transaction for this subscriber, no matter if it is
establishing, established, or alerting, in any of these cases we
will return USER BUSY to the calling party.
Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae
---
M include/osmocom/msc/gsm_data.h
M src/libmsc/gsm_04_08_cc.c
M src/libmsc/msc_vty.c
M src/osmo-msc/msc_main.c
M tests/test_nodes.vty
5 files changed, 53 insertions(+), 3 deletions(-)
Approvals:
neels: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
keith: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h
index a90b732..11b6e82 100644
--- a/include/osmocom/msc/gsm_data.h
+++ b/include/osmocom/msc/gsm_data.h
@@ -258,6 +258,9 @@
/* Whether we want to use Osmux against BSCs. Controlled via VTY */
enum osmux_usage use_osmux;
+
+ /* Whether to use call waiting on the network */
+ bool call_waiting;
};
struct osmo_esme;
diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c
index e83caa2..ed74e88 100644
--- a/src/libmsc/gsm_04_08_cc.c
+++ b/src/libmsc/gsm_04_08_cc.c
@@ -1909,6 +1909,25 @@
GSM48_CAUSE_LOC_PRN_S_LU,
GSM48_CC_CAUSE_DEST_OOO);
}
+
+ /* Find valid conn */
+ msc_a = msc_a_for_vsub(vsub, true);
+
+ /* If subscriber is BUSY and we do not DO call in call aka
"call-waiting" */
+ if (!net->call_waiting && msc_a) {
+ struct gsm_trans *existing_cc_trans =
trans_find_by_type(msc_a, TRANS_CC);
+ if (existing_cc_trans && existing_cc_trans->cc.state !=
GSM_CSTATE_NULL) {
+ LOG_TRANS_CAT(existing_cc_trans, DCC,
LOGL_NOTICE,
+ "rx '%s' for subscriber %s with
trans state (%s)"
+ " rejecting with USER_BUSY\n",
+ get_mncc_name(msg->msg_type),
data->called.number,
+
gsm48_cc_state_name(existing_cc_trans->cc.state));
+ return mncc_release_ind(net, NULL,
data->callref,
+
GSM48_CAUSE_LOC_PRN_S_LU,
+
GSM48_CC_CAUSE_USER_BUSY);
+ }
+ }
+
/* Create transaction */
trans = trans_alloc(net, vsub, TRANS_CC,
TRANS_ID_UNASSIGNED, data->callref);
@@ -1922,9 +1941,6 @@
return -ENOMEM;
}
- /* Find valid conn */
- msc_a = msc_a_for_vsub(vsub, true);
-
/* If subscriber has no conn */
if (!msc_a) {
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 4674e2e..09aef91 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -330,6 +330,29 @@
return CMD_SUCCESS;
}
+DEFUN(cfg_net_call_wait, cfg_net_call_wait_cmd,
+ "call-waiting",
+ "Enable Call Waiting on the Network\n")
+{
+ struct gsm_network *net = vty->index;
+
+ net->call_waiting = true;
+
+ return CMD_SUCCESS;
+}
+
+DEFUN(cfg_net_no_call_wait, cfg_net_no_call_wait_cmd,
+ "no call-waiting",
+ NO_STR
+ "Disable Call Waiting on the Network\n")
+{
+ struct gsm_network *net = vty->index;
+
+ net->call_waiting = false;
+
+ return CMD_SUCCESS;
+}
+
static int config_write_net(struct vty *vty)
{
int i;
@@ -376,6 +399,9 @@
gsmnet->emergency.route_to_msisdn, VTY_NEWLINE);
}
+ if (!gsmnet->call_waiting)
+ vty_out(vty, " no call-waiting%s", VTY_NEWLINE);
+
return CMD_SUCCESS;
}
@@ -1946,6 +1972,8 @@
install_element(GSMNET_NODE, _net_no_timezone_cmd);
install_element(GSMNET_NODE, _net_per_loc_upd_cmd);
install_element(GSMNET_NODE, _net_no_per_loc_upd_cmd);
+ install_element(GSMNET_NODE, _net_call_wait_cmd);
+ install_element(GSMNET_NODE, _net_no_call_wait_cmd);
install_element(CONFIG_NODE, _msc_cmd);
Change in ...osmo-msc[master]: Implement a global switch on the network to disable call waiting.
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15120 ) Change subject: Implement a global switch on the network to disable call waiting. .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3eb6f23f7103e3002874fb5d3a30c9de952202ae Gerrit-Change-Number: 15120 Gerrit-PatchSet: 12 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 03 Sep 2019 11:47:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0c74c10b5fa7bbdd6ae3674926cc0393edf15a35 Gerrit-Change-Number: 15389 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 11:36:36 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 ) Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac Gerrit-Change-Number: 15388 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 11:29:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-ttcn3-hacks[master]: ggsn: Delete previously activated pdp ctx in *_interact()
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 Change subject: ggsn: Delete previously activated pdp ctx in *_interact() .. ggsn: Delete previously activated pdp ctx in *_interact() This change fixes some GGSN_Tests failing lately since osmo-ggsn correctly sends DeleteCtxReq for dangling pdp ctx upon increased Recovery counter received, and tests are not expecting that (because they don't expectect dangling pdp ctx from previous tests). Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/15390/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 4a53fa1..44dba4a 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -958,6 +958,7 @@ f_wait_gtpu_fail(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Test PDP context activation for dynamic IPv4 EUA without DNS request */ @@ -1089,6 +1090,7 @@ f_wait_icmp4_echo_request(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Validate if different clients (pdp ctx) can reach one another through GGSN. */ @@ -1345,6 +1347,7 @@ f_wait_gtpu_fail(ctxB); f_pdp_ctx_del(ctxA, '1'B); + f_pdp_ctx_del(ctxB, '1'B); } /* Test IPv4v6 context activation for dynamic IPv4v6 EUA on a v4-only APN */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I232298e2bfd8bfc99d82cbf5803d11db7eb1786a Gerrit-Change-Number: 15390 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/15387 ) Change subject: ipa: ipa_server_link_close() add checks of link state .. Patch Set 3: See my comment from previous version of the patch... -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 10:20:36 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 to look at the new patch set (#3). Change subject: ipa: ipa_server_link_close() add checks of link state .. ipa: ipa_server_link_close() add checks of link state When closing a link which failed on open, ipa_server_link_close() would crash it when calling osmo_fd_unregister. Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 --- M src/input/ipa.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/15387/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 to look at the new patch set (#2). Change subject: ipa: ipa_server_link_close() add checks of link state .. ipa: ipa_server_link_close() add checks of link state When closing a link which failed on open, ipa_server_link_close() would crash it when calling osmo_fd_unregister. Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 --- M src/input/ipa.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/87/15387/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...pysim[master]: pySim-prog: Use CSV format with headers
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/15313 ) Change subject: pySim-prog: Use CSV format with headers .. Patch Set 2: Code-Review+1 I fixed the problem. Now it passes the tests. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 09:52:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...pysim[master]: pySim-prog: Use CSV format with headers
dexter has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/pysim/+/15313 ) Change subject: pySim-prog: Use CSV format with headers .. pySim-prog: Use CSV format with headers This way we can have optional fields like adm1 in the file Also require iccid as identifier for the SIM card Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 --- M pySim-prog.py M pySim/cards.py 2 files changed, 22 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/13/15313/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/15313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0d317ea51d0cf582b82157eec6cdec074001a236 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-CC: pespin Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: msc_a fsm: ignore state chg to same state
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15389 ) Change subject: msc_a fsm: ignore state chg to same state .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15389 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0c74c10b5fa7bbdd6ae3674926cc0393edf15a35 Gerrit-Change-Number: 15389 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 09:26:17 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: vlr: don't log about "gratuitous ID RESPONSE"
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15388 ) Change subject: vlr: don't log about "gratuitous ID RESPONSE" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15388 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8a5b8735eb41cd0976c7ab32cdd55440d3ef70ac Gerrit-Change-Number: 15388 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 09:02:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-abis[master]: ipa: ipa_server_link_close() add checks of link state
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/15387 ) Change subject: ipa: ipa_server_link_close() add checks of link state .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15387/1/src/input/ipa.c File src/input/ipa.c: https://gerrit.osmocom.org/#/c/15387/1/src/input/ipa.c@336 PS1, Line 336: if (osmo_fd_is_registered(>ofd)) There was recently a discussion about similar patch, Better make sure ofd.fd is initialized to -1 and simply use (link->ofd.fd < 0) condition for both lines. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/15387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I672d4de25464c3829b08aff26b1a6d4ad92e7684 Gerrit-Change-Number: 15387 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 09:00:16 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-msc[master]: ran_dec logging: log message sizes on errors
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15342 ) Change subject: ran_dec logging: log message sizes on errors .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id08e4ee5a4dbf552dbb107d8f0519110664f6acb Gerrit-Change-Number: 15342 Gerrit-PatchSet: 5 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 03 Sep 2019 07:36:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
