Re: [Gimp-developer] unsharp mask
On Wed, 2010-12-08 at 23:15 +0200, Alexia Death wrote: > I'm not suggesting changing it's name, I'm proposing suffixing the > name of the algorithm with its purpose because the algorithm name > itself is outright misleading. Putting it in the menu in a menu item > named Sharpen would serve the same purpose, but I dont think we have > any other sharpening algorithms in default distribution to justify > that. Well, you are suggesting to change its name. Suffixing it is a name change and it has the potential to confuse users that are actually looking for "Unsharp Mask" and expect to find a standard filter under its usual name. About the menu, that's a good point. IMO it would be useful to have a "Sharpen" group in the "Filters->Enhance" menu, separated from the other filters. Here all sharpen filters can register and having "Unsharp Mask" in a group with "Sharpen" should be a good hint on what it actually does. Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
[Gimp-developer] Unsharp Mask and Sharpening
Hi, What are the best GIMP tools for sharpening? Is there a time when someone would use Sharpen instead of Unsharp Mask? To me GIMP's Unsharp Mask has a better range and control. Will Wavelet Sharpen be included in GIMP 2.8? I find the Luminance setting gives even better results than Unsharp Mask. I hope this is the correct mailing list for these questions Regards Jan ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On 12/08/10 21:57, Sven Neumann wrote: > On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: >> When we are on the subject already, I have a suggestion. Lets save the >> countless noobs time and change the menu label of unsharp mask to >> Unsharp Mask Sharpen? > > Seriously, Unsharp Mask is the correct term and it is widely known and > mentioned in pretty much any book/tutorial that covers image > manipulation and sharpening algorithms. It doesn't really help to > disguise the filter by giving it a different name. GIMP is not really > meant to be the application that a noob should use for their casual > image manipulation needs. There are other application that fill this > need and we should leave it to them to present the user with just a > single sharpening algorithm and calling it "Sharpen" (even though it > would most probably be "Unsharp Mask"). > > > Sven > > > Looking at the present way this is presented: Sharpen ... Unsharp mask Then, because everyone who wants to sharpen an image is likely to look at the option called "sharpen" this has a hint saying it's not as powerful as unsharp mask. The unsharp mask hint explains that this is the most commonly used way to sharpen an image. Thus it is recognised that this is confusing and counter intuitive to the point where both comments are saying you don't want to use sharpen , try unsharp. While unsharp mask may be the "correct term" it only makes sense in a photographic lab of a generation ago, it is now jargon. However interesting that may be to know the origins, the term is now a hindrance to usage and a clearer presentation would be better IMHO. While the vision of gimp is to be "top-end" this should not require all users to have 10 years professional experience or a degree in image processing. It should be top-end in function without being esoteric. I would suggest renaming sharpen to "simple" or "basic sharpen" and unsharp to "sharpen". That would instantly guide people to the probably required tool. Then use the hints to provide for those seeking more detail to know which they require rather than , as now, using this space to say the names are confusing and you probably don't want this one, use the other one. /gg ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On 12/08/2010 01:15 PM, Alexia Death wrote: > On Wed, Dec 8, 2010 at 10:57 PM, Sven Neumann wrote: >> On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: >>> When we are on the subject already, I have a suggestion. Lets save the >>> countless noobs time and change the menu label of unsharp mask to >>> Unsharp Mask Sharpen? >> Seriously, Unsharp Mask is the correct term and it is widely known and >> mentioned in pretty much any book/tutorial that covers image >> manipulation and sharpening algorithms. > Well, I personally had been using gimp for several years and at least > one image processing related university class behind me, before I ran > into sharpening tutorial that mentioned it as one of the options. > > If photo processing isn't your main track, you probably dont know what > its for. And its a serious usability issue, if there are features that > would be very useful, but are impossible to discover. Being > pro-oriented is fine, but there are several kinds of pros and stomping > on in gimp education of its users like that is really not helpful > IMHO. > > I'm not suggesting changing it's name, I'm proposing suffixing the > name of the algorithm with its purpose because the algorithm name > itself is outright misleading. Putting it in the menu in a menu item > named Sharpen would serve the same purpose, but I dont think we have > any other sharpening algorithms in default distribution to justify > that. How about, "Sharpen (Unsharp Mask)" Patrick ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On 12/08/2010 12:46 PM, Michael Natterer wrote: > On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: >> When we are on the subject already, I have a suggestion. Lets save the >> countless noobs time and change the menu label of unsharp mask to >> Unsharp Mask Sharpen? > Which would make the noobs think what exactly? That GIMP developers > suffer from some semi-inverse tautologigal redundancy disorder? > > Unsharp Mask Sharpen, ts ts ts :) That is funny. The noobs of course, don't know about the unsharp mask algorithm and don't realize that it will sharpen. The think it will unsharpen. Patrick ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On Wed, Dec 8, 2010 at 10:57 PM, Sven Neumann wrote: > On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: >> When we are on the subject already, I have a suggestion. Lets save the >> countless noobs time and change the menu label of unsharp mask to >> Unsharp Mask Sharpen? > > Seriously, Unsharp Mask is the correct term and it is widely known and > mentioned in pretty much any book/tutorial that covers image > manipulation and sharpening algorithms. Well, I personally had been using gimp for several years and at least one image processing related university class behind me, before I ran into sharpening tutorial that mentioned it as one of the options. If photo processing isn't your main track, you probably dont know what its for. And its a serious usability issue, if there are features that would be very useful, but are impossible to discover. Being pro-oriented is fine, but there are several kinds of pros and stomping on in gimp education of its users like that is really not helpful IMHO. I'm not suggesting changing it's name, I'm proposing suffixing the name of the algorithm with its purpose because the algorithm name itself is outright misleading. Putting it in the menu in a menu item named Sharpen would serve the same purpose, but I dont think we have any other sharpening algorithms in default distribution to justify that. -- --Alexia p.s Sorry for the double mail again, Sven... ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: > When we are on the subject already, I have a suggestion. Lets save the > countless noobs time and change the menu label of unsharp mask to > Unsharp Mask Sharpen? Seriously, Unsharp Mask is the correct term and it is widely known and mentioned in pretty much any book/tutorial that covers image manipulation and sharpening algorithms. It doesn't really help to disguise the filter by giving it a different name. GIMP is not really meant to be the application that a noob should use for their casual image manipulation needs. There are other application that fill this need and we should leave it to them to present the user with just a single sharpening algorithm and calling it "Sharpen" (even though it would most probably be "Unsharp Mask"). Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On 12/08/10 19:35, Alexia Death wrote: > When we are on the subject already, I have a suggestion. Lets save the > countless noobs time and change the menu label of unsharp mask to > Unsharp Mask Sharpen? > > --Alexia Good point but is that any clearer than 'unblur mask blur' ? Until this stupid, cryptic, confusing name gets dumped everyone who has not already met it will be confused. Let's call it something else that makes sense and maybe just put unsharp in the hint in case anyone knows it from elsewhere. /gg ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On Wed, 2010-12-08 at 20:35 +0200, Alexia Death wrote: > When we are on the subject already, I have a suggestion. Lets save the > countless noobs time and change the menu label of unsharp mask to > Unsharp Mask Sharpen? Which would make the noobs think what exactly? That GIMP developers suffer from some semi-inverse tautologigal redundancy disorder? Unsharp Mask Sharpen, ts ts ts :) ciao, --mitch ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On Wed, 2010-12-08 at 14:40 -0500, Rob Antonishen wrote: > > > > We prefer patches created from git commits using 'git format-patch'. If > > you had submitted such a patch, I would have pushed your commit by now. > > Can you resend your diff with a commit log please? > > > > > > Sven > > Sorry. I've never worked with git before. > > Would the attached be correct? Doesn't totally follow the rules for the git commit log message (taken from the git commit manual page): Though not required, it’s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. Tools that turn commits into email, for example, use the first line on the Subject: line and the rest of the commit in the body. But yes, it does the trick and I'll push it right away. Thanks, Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
>
> We prefer patches created from git commits using 'git format-patch'. If
> you had submitted such a patch, I would have pushed your commit by now.
> Can you resend your diff with a commit log please?
>
>
> Sven
Sorry. I've never worked with git before.
Would the attached be correct?
-Rob A>
From b2292460636ceba85849c3a3796fa2f1488e7da6 Mon Sep 17 00:00:00 2001
From: Rob Antonishen
Date: Wed, 8 Dec 2010 14:37:24 -0500
Subject: [PATCH] Increased maximum radius to 500 in unsharp-mask plugin
---
plug-ins/common/unsharp-mask.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plug-ins/common/unsharp-mask.c b/plug-ins/common/unsharp-mask.c
index de23822..1755f18 100644
--- a/plug-ins/common/unsharp-mask.c
+++ b/plug-ins/common/unsharp-mask.c
@@ -864,7 +864,7 @@ unsharp_mask_dialog (GimpDrawable *drawable)
adj = gimp_scale_entry_new (GTK_TABLE (table), 0, 0,
_("_Radius:"), SCALE_WIDTH, ENTRY_WIDTH,
- unsharp_params.radius, 0.1, 120.0, 0.1, 1.0, 1,
+ unsharp_params.radius, 0.1, 500.0, 0.1, 1.0, 1,
TRUE, 0, 0,
NULL, NULL);
--
1.7.1
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
When we are on the subject already, I have a suggestion. Lets save the countless noobs time and change the menu label of unsharp mask to Unsharp Mask Sharpen? --Alexia ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
On Wed, 2010-12-08 at 13:22 -0500, Rob Antonishen wrote: > Looks simple enough - it is only a GUI restriction (I was able to > apply larger radii using the script-fu console) > > Attached is a diff We prefer patches created from git commits using 'git format-patch'. If you had submitted such a patch, I would have pushed your commit by now. Can you resend your diff with a commit log please? Sven ___ Gimp-developer mailing list Gimp-developer@lists.XCF.Berkeley.EDU https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
Looks simple enough - it is only a GUI restriction (I was able to
apply larger radii using the script-fu console)
Attached is a diff
-Rob A>
On Wed, Dec 8, 2010 at 11:53 AM, wrote:
> A bit off-topic, but in one of the upcoming releases would it be
> possible to increase the maximum radius allowable in the Unsharp Mask
> dialog to "500" or so. With increased image sizes being much more
> prevalent than in the past, the original maximum ("120") can be
> somewhat limiting.
>
>
> ___
> Gimp-developer mailing list
> Gimp-developer@lists.XCF.Berkeley.EDU
> https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
>
diff
Description: Binary data
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
Re: [Gimp-developer] unsharp mask
A bit off-topic, but in one of the upcoming releases would it be
possible to increase the maximum radius allowable in the Unsharp Mask
dialog to "500" or so. With increased image sizes being much more
prevalent than in the past, the original maximum ("120") can be
somewhat limiting.
___
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer
