Re: can I send something like upload finished answere from HTTP servlet to my application ?

2011-05-02 Thread Manvel Saroyan
Thank You Alan Chaney.
Now my project works ok.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: can I send something like upload finished answere from HTTP servlet to my application ?

2011-05-02 Thread Manvel Saroyan
Thank you Alan Chaney now my project works ok:)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Cursor disappearing from TextBox

2011-05-02 Thread varakumar pjd
Hello,

 Cursor is being disappeared from my TextBox and I am unable
to enter anything. Just have a look at this code once.

TextBox textBox = new TextBox();
SimplePanel panel = new SimplePanel();
panel.addStyleName(downarrow);
HorizontalPanel hPanel = new HorizontalPanel();
hPanel.add(textBox);
hPanel.add(panel);

FocusWidget widget = new FocusWidget(hPanel.getElement());

RootPanel.get().add(widget);


Now in the result I am getting a widget like a ListBox.
But when I want to enter anything in that TextBox cursor is being
disappeared in 1sec from that and I am unable to enter anything. Can
anybody suggest me for this problem.


Thanks,
Vara Kumar

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Cursor disappearing from TextBox

2011-05-02 Thread varakumar pjd
Hello,

 Cursor is being disappeared from my TextBox and I am unable
to enter anything. Just have a look at this code once.

TextBox textBox = new TextBox();
SimplePanel panel = new SimplePanel();
panel.addStyleName(downarrow);
HorizontalPanel hPanel = new HorizontalPanel();
hPanel.add(textBox);
hPanel.add(panel);

FocusWidget widget = new FocusWidget(hPanel.getElement());

RootPanel.get().add(widget);


Now in the result I am getting a widget like a ListBox.
But when I want to enter anything in that TextBox cursor is being
disappeared in 1sec from that and I am unable to enter anything. Can
anybody suggest me for this problem.


Thanks,
Vara Kumar

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Using Google Closure Library within GWT JSNI .....

2011-05-02 Thread nino ekambi
I was  just wondering what s the best way to go ?

GWT oder Closure oder botch ?
 maybe some one can explain to me the strengh  of closure compare to gwt ?

Thank

2011/5/2 Broc Seib broc.s...@gmail.com

 I just went down this road (with success). I've been using GWT, but I
 really wanted to use a Closure menu button widget. So I figured out how to
 mix closure widgets into my GWT app, gluing them together with JSNI as you
 expected. I've made a blog posting sharing my experience mixing Closure
 with 
 GWThttp://blog.broc.seib.net/2011/05/mixing-google-closure-with-gwt.html
 .

 There is some minor impedance mismatch between Closure and GWT. First,
 closure has its own home-brew event system, so you gotta setup/catch your
 events on the closure side before you send things back via JSNI to GWT
 world. Second, the big deal with Closure is that once you identify the
 closure widgets you need on a page, you can run it through the closure
 compiler and eliminate all unnecessary javascript code, and compile it all
 into a single, compact js file. Because of this it would make no sense for
 someone to create a GWT wrapper library containing all the individual
 closure widgets. Instead, you gotta look at each GWT page load and design
 for the closure widgets you'll need.

 I also see no reason why there would be any performance issues.

 -broc

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 

GWT API for  non Java based platforms
http://code.google.com/p/gwt4air/
http://www.gwt4air.appspot.com/

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Aw: After using GIN,all events registered by @UiHandler don't work.

2011-05-02 Thread Jens
I never had a problem with GIN and @UiHandler. You can add a -gen custom 
path to your run configuration to see what code GWT generates. Seems to be 
very unlikely that @UiHandler does not work but everything else does.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: With GWT, when exactly do you need DTOs for your entities ?

2011-05-02 Thread dmen
I do use the same approach, though with Spring MVC Controllers +
XStream instead of GWT RPC.

https://github.com/scumm/mojo/tree/master/mojo-dao/src/main/java/mojo/dao/util

On May 1, 10:27 pm, Celinio cel...@gmail.com wrote:
 Thanks for pointing it out.
 Well, apparently the author created a class, HibernateFilter.java, that acts
 as a filter during the GWT serialization of 
 objects.http://tocollege-net.googlecode.com/svn/ProGWT/trunk/src/main/java/co...

 It converts Date objects, PersistentSet collections etc.
 Not sure what it's worth actually.
 Has anyone used such approach ?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Overriding RemoteServiceServlet.checkPermutationStrongName()

2011-05-02 Thread Ice13ill
Hello, i get this exception java.lang.SecurityException: Blocked
request without GWT permutation header in my app, but only at some
user requests.
If i override the method checkPermutationStrongName() in the remote
servlet (which checks a request header) by leaving it empty, will that
cause security issues ? Or is there another way of avoiding this
exception ?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: With GWT, when exactly do you need DTOs for your entities ?

2011-05-02 Thread dmen
There is a catch however!

You cannot safely use CascadeType.MERGE with ToMany associations. If
you do, JPA will automatically delete the nullified collections when
you sent those entities back to the server.

On May 2, 1:45 pm, dmen dmenou...@gmail.com wrote:
 I do use the same approach, though with Spring MVC Controllers +
 XStream instead of GWT RPC.

 https://github.com/scumm/mojo/tree/master/mojo-dao/src/main/java/mojo...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



DataPicker Validation

2011-05-02 Thread Manvel Saroyan
Hi... please tell me is there a way to make a Datapicker value
validation ?
When I enter wrong value datePicker changes it's style making
background red... so if DatePicker can recognise did I enter valid
value I think there will be also method to check that validation for
example on button click  I wan't to know is the value is valid or
not...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



how to reposition the popup when window gets resized

2011-05-02 Thread newbee
Hi All,

I am using popups in my application and I am positioning them at
absolute left and right of some other widget. Now the problem is that
when i resize the window then the relative widget left and right are
changing but the popup is still staying at the old position

Is there anyway I can reposition my popup when I resize the window.

Example:
PushButton someButton= new PushButton(addIcon);
someButton.setWidth(addIcon.getWidth() + px);
someButton.setHeight(addIcon.getHeight() + px);

fileListPopupPanel = new PopupPanel();
fileListPopupPanel.setStyleName(BrowserPanel-PopupPanel);
fileListPopupPanel.setAutoHideEnabled(false);

fileListPopupPanel.setPopupPosition(someButton.getAbsoluteLeft(),
(someButton
.getAbsoluteTop() + 
(someButton.getOffsetHeight(;

I appreciate your help.

Thanks,
satish

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: how to reposition the popup when window gets resized

2011-05-02 Thread jhulford
Use a Window ResizeHandle and reposition your dialog when the window
is resized.

On May 2, 9:16 am, newbee gandhamsat...@gmail.com wrote:
 Hi All,

 I am using popups in my application and I am positioning them at
 absolute left and right of some other widget. Now the problem is that
 when i resize the window then the relative widget left and right are
 changing but the popup is still staying at the old position

 Is there anyway I can reposition my popup when I resize the window.

 Example:
 PushButton someButton= new PushButton(addIcon);
 someButton.setWidth(addIcon.getWidth() + px);
 someButton.setHeight(addIcon.getHeight() + px);

 fileListPopupPanel = new PopupPanel();
 fileListPopupPanel.setStyleName(BrowserPanel-PopupPanel);
 fileListPopupPanel.setAutoHideEnabled(false);

 fileListPopupPanel.setPopupPosition(someButton.getAbsoluteLeft(),
 (someButton
                                 .getAbsoluteTop() + 
 (someButton.getOffsetHeight(;

 I appreciate your help.

 Thanks,
 satish

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



GWT - Capture values of dynamically created components

2011-05-02 Thread Bhavin
Hi,

I have a GWT page with 2 text boxes, 1 hyperlink and 1 button
initially (on page load).
When I click on the hyperlink, I add another text box (dynamically
without refreshing the page).

Now when I click the button, I need to capture the values that lie in
all the three text boxes. How can I do it?

I am desparately looking for some help on this area because I am
working on a critical project and badly need help on this.

--
Thanks!
Bhavin

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: GWT - Capture values of dynamically created components

2011-05-02 Thread Alisson Prestes
You can

   - use a simple ArrayList to store the values and
   - other ArrayList to store the widgets
   - create a function to update the values in the values ArrayList, that
   receives a integer that represents the position you're altering
   - create a click handler for each hyperlink with a class attribute called
   index. Each hyperlink will have a single index and this is the way it will
   tell your application which of the groups has been altered

I think this is simple to implement and will solve your problem.

Alisson Prestes
www.google.com/profiles/javalisson



On Mon, May 2, 2011 at 10:43 AM, Bhavin bhavinbpar...@gmail.com wrote:

 Hi,

 I have a GWT page with 2 text boxes, 1 hyperlink and 1 button
 initially (on page load).
 When I click on the hyperlink, I add another text box (dynamically
 without refreshing the page).

 Now when I click the button, I need to capture the values that lie in
 all the three text boxes. How can I do it?

 I am desparately looking for some help on this area because I am
 working on a critical project and badly need help on this.

 --
 Thanks!
 Bhavin

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



req.getContentLength() returns -1, what is wrong ???

2011-05-02 Thread Manvel Saroyan
Hi.
I'm using current validation code on my HTTPServlet to check if the
user uploads big files:
public void doPost(HttpServletRequest req, HttpServletResponse res)
throws ServletException, IOException {
long maxSize = 1024*1024 * 1; //Limit 50 MB
int contentLength = req.getContentLength();
if (contentLength  0 || contentLength  maxSize) {
res.sendError(509, CHAP@: +contentLength+ BYTE-a);
}

else {
 It's ok
   }
In the development mode req.getContentLength(); Returns me the
correct
size of the data I'm uploading, but when I deploy my application to
App Engine And run my application req.getContentLength(); returns me
-1. Please tell me what is wrong and please suggest me how can I
solve
that problem...

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to update CellTable's Header Cell based on action in data table

2011-05-02 Thread Jason
Darn it!  I think I was just staring at my code for too long last
Friday.  Thanks Thomas!  I was successfully able to update my header
cell's value in the onSelectionChange method of my SelectionHandler
and call redrawHeaders() which successfully re-renders the header
cell.  I'm not sure how I missed this workflow the first go around.

On Apr 29, 6:23 pm, Thomas Broyer t.bro...@gmail.com wrote:
 You might be looking for the 
 CellTable#redrawHeaders()http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/googl...()method.
  In your SelectionHandler, you would update the internal value of
 your Header (whatever is returned by its getValue method) and then
 redrawHeaders() to update the display.
 (just an idea, never ever tried)

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: CellTree with CellTable nodes

2011-05-02 Thread lamre
 CellCartella cell = new AbstractCellCartella(click)
 {
 @Override
 public void render(Context context, 
Cartella value,
SafeHtmlBuilder sb)
 {
sb.appendEscaped(value.getDescCartella());
 }
 //gestiamo gli eventi
 @Override
 public void onBrowserEvent(Context 
context, Element parent,

Cartella value,NativeEvent event, ValueUpdaterCartella
valueUpdater)
 {
 if (value == null) {   return; 
  }
 super.onBrowserEvent(context, 
parent, value, event,
valueUpdater);
 if 
(click.equals(event.getType()))
 {

ControllerPqm.getInstance().loadCartella(value.getIdCartella());
//   Window.alert(Click sulla 
cartella +
value.getDescCartella());
 }
 }
  };

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: CellTree with CellTable nodes

2011-05-02 Thread lamre
CellCartella cell = new AbstractCellCartella(click)
 {
 @Override
 public void render(Context context, 
Cartella value,
SafeHtmlBuilder sb)
 {
 
sb.appendEscaped(value.getDescCartella());
 }
 @Override
 public void onBrowserEvent(Context 
context, Element parent,

Cartella value,NativeEvent event, ValueUpdaterCartella
valueUpdater)
 {
 if 
(click.equals(event.getType()))
 {
   
Window.alert(Click sulla cartella +
value.getDescCartella());
 }
 }
};

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



CellTable colspan or rowspan...

2011-05-02 Thread scarlatine
Hi!
I need to merge cells with same data in a CellTable. I have seen this thread 
https://groups.google.com/d/topic/google-web-toolkit/K0YBv819i70/discussion, 
but where can I put 
cellTable.getRowElement(row).getCells().getItem(column).setRowSpan(rowSpan); 
to use it when the table receives its data (I want to use paging)?
Another question: is that a way to add an arbitrary row in the middle of the 
data rows like the date in the included file?
Thanks...
 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.

attachment: Sample.PNG

Unable to get result object from Service layer

2011-05-02 Thread Debolina Dan
Hi All,



I am trying to get the result object from service layer through
handler, i am getting this error



org.springframework.transaction.UnexpectedRollbackException:
Transaction rolledback because it has been marked as rollback-only



Service layer code is :

public VerifyDataResult verifyData(VerifyData data) {

VerifyDataResult result = new VerifyDataResult ();



try {

ClientCase newClientCase = data.getClientCase();

Case newCase = new Case();

newCase.setDecinum(newClientCase.getDecinum());

newCase.setCaseNumber(newClientCase.getCaseNumber() !=
null ? newClientCase.getCaseNumber() : 0);

ccdbManager.checkDecinum(newCase);



} catch (DecinumException decinumException) {

result.setDuplicate(true);

log.debug(Duplicate Decinum exist  +
decinumException.getMessage());

log.debug(Result value  + result);

   // throw new DecinumException(Duplicate Decinum exist );

} catch(Exception e){

log.debug(Duplicate Decinum exception in PMS  +
e.getMessage());

}

return result;

}



Handler Code:



public VerifyDataResult execute(VerifyData action, ExecutionContext
context) throws ActionException {



VerifyDataResult result = new VerifyDataResult ();

try {

result = payloadModelService.verifyData(action);

log.debug(after setting of Duplicate Decinum
value ...+result.isDuplicate());

} catch (DecinumException e) {

log.debug(Exception at execute
+e.getMessage());

e.printStackTrace();

throw new ActionException(e.getMessage());

}catch(Exception e){

log.debug(verify decinum values =
+result.isDuplicate());

log.debug(Duplicate Exception  +e.getMessage());

e.printStackTrace();

}



log.debug(Before returning result   +result);

return result;

}



Ever time the result is getting set to False even if the result is
being set to true in our service layer. Can you please suggest.


Thanks in advance.
Deb.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Get the underlying object in a chart using onSelect event

2011-05-02 Thread Gopi Krishnan Nambiar
Hi,

Is there any way to get hold of the underlying object, whose row has
been selected in an orgChart ? I am only able to get the row, using
the selection event as of now. The intent is to populate the an
employee's details based on which employee is clicked on in the
orgChart.
Thanks in advance.

-Gopi

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Offline map functionallity GWT

2011-05-02 Thread qperez
Hi, is there any way to obtain offline map functionallity for a GWT
application?
We are using GWT 2.1 with gwtmaps module from google apis, but the map
goes away as soon as our computer goes offline. we need to implement
some kind of offline functionallity.

Thanks in advance,
Ana

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Application need to be recompiled on a Tomcat server ? It's a GWT Maven Project ?

2011-05-02 Thread Alexis10
Hi,

I had this common error of compilation of Maven GWT project:
#  GWT module 'www.mysociety.Application' may need to be
(re)compiled  #
I tried several things I can found on the web, during 3 days.

People says always to add ?gwt.codesvr=127.0.0.1:9997 after the url
without understanding that the goal is to run a GWT Application not
under developpement mode server. Furthermore... this technic is not a
solution.

I post here a part of solution I tried just this morning and working
perfectly.

So... if the project is a Maven GWT one, and you want to deploy it on
Tomcat... try to:

-- delete the folder groupId.artifactId.moduleName in the folder
src/main/webapp
For me it was www.mysociety.Application folder to delete.
-- After the deployement of the project, clean the cache of the web
browser.
-- Try !

I hope that my solution will help someone.

Cordialy,

Alexis10

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



HasDataEditor + CellTable

2011-05-02 Thread erank
Hi all,
I'm looking for a good example howto write an editor for a CellTable.

I understand that I need to use the HasDataEditor of ListEditor but I
can't find anything about it..

Thanks.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Data-binding, Konckout.js

2011-05-02 Thread Artem Nikulchenko
I've recently seen Knockout.js presentation at MIX 11 and it looks
amazing. It removes all boilerplate code around data-binding and looks
really amazing!!! We do have a lot of development in both GWT and
Silverlight, and Silverlight data-binding is probably the only
advantage left (and we really miss it when switch to GWT and write
data oriented applications). And it looks like Knockout.js could give
same experience, if it would be integrated into GWT.

Is there are any plans to integrate Knockout.js into GWT? Or maybe
make same binding experience in GWT by it's own?

Best regards,
Artem

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Downloading older GWT plugin versions

2011-05-02 Thread tharkun
Hi,

I am trying to set up a co-worker with my GWT based project, which I
started on GWT 2.2.0. Obviously, if he tries to install the Google
Plugin via update-site, he's going to get version 2.2.1 and you can't
simply install older versions from the update-site.

Unfortunately however, you also can't seem to get older versions of
the update-site as a zip, only latest. Am I missing something? All I
can find online are other people having the same problem, but no
solutions or definite answers.

Am I missing something? I really just need version 2.2.0 of the
plugin, as I can't spend the time to upgrade everything to 2.2.1 right
now (yes I know it is just a minor version jump, but I have been
bitten by those before, even with GWT).

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: how to reposition the popup when window gets resized

2011-05-02 Thread mike b
If you find an elegant solution, please post it.  I have the same thing on my 
to do list.  Thx 

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Application need to be recompiled on a Tomcat server ? It's a GWT Maven Project ?

2011-05-02 Thread Thomas Broyer
Best solution is to *not* launch DevMode using your src/main/webapp as the 
war folder. See http://code.google.com/eclipse/docs/faq.html#gwt_with_maven

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: how to reposition the popup when window gets resized

2011-05-02 Thread Ben Imp
I believe the center() method on the dialog will re-center a dialog even if 
its already visible.  Stick that into a resize handler and you should be 
good to go.

-Ben

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Downloading older GWT plugin versions

2011-05-02 Thread Chris Conroy
The plugin ships with an SDK, but that doesn't mean you must use that SDK
with the plugin:

Right click on your project - Google - Web Toolkit Settings - Configure
SDKs.

On Mon, May 2, 2011 at 10:45 AM, tharkun thar...@gmx.de wrote:

 Hi,

 I am trying to set up a co-worker with my GWT based project, which I
 started on GWT 2.2.0. Obviously, if he tries to install the Google
 Plugin via update-site, he's going to get version 2.2.1 and you can't
 simply install older versions from the update-site.

 Unfortunately however, you also can't seem to get older versions of
 the update-site as a zip, only latest. Am I missing something? All I
 can find online are other people having the same problem, but no
 solutions or definite answers.

 Am I missing something? I really just need version 2.2.0 of the
 plugin, as I can't spend the time to upgrade everything to 2.2.1 right
 now (yes I know it is just a minor version jump, but I have been
 bitten by those before, even with GWT).

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Probleme when compiling gwt project

2011-05-02 Thread David Chandler
Can you supply sample code so we can reproduce this and research it?

On Sun, May 1, 2011 at 4:11 AM, nino ekambi jazzmatad...@googlemail.comwrote:

 Hello people,

 i m getting this error when compiling my GWT Project :

 [ERROR] Unexpected
 java.lang.ArrayIndexOutOfBoundsException: -1
 at
 org.eclipse.jdt.internal.compiler.codegen.StackMapFrame.addStackItem(StackMapFrame.java:105)
  at
 org.eclipse.jdt.internal.compiler.ClassFile.traverse(ClassFile.java:7386)
 at
 org.eclipse.jdt.internal.compiler.ClassFile.completeCodeAttribute(ClassFile.java:1613)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:244)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:564)
  at
 org.eclipse.jdt.internal.compiler.ast.QualifiedAllocationExpression.generateCode(QualifiedAllocationExpression.java:169)
 at
 org.eclipse.jdt.internal.compiler.ast.Statement.generateArguments(Statement.java:102)
  at
 org.eclipse.jdt.internal.compiler.ast.MessageSend.generateCode(MessageSend.java:153)
 at
 org.eclipse.jdt.internal.compiler.ast.Expression.generateCode(Expression.java:601)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:232)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:564)
  at
 org.eclipse.jdt.internal.compiler.ast.QualifiedAllocationExpression.generateCode(QualifiedAllocationExpression.java:169)
 at
 org.eclipse.jdt.internal.compiler.ast.Statement.generateArguments(Statement.java:102)
  at
 org.eclipse.jdt.internal.compiler.ast.MessageSend.generateCode(MessageSend.java:153)
 at
 org.eclipse.jdt.internal.compiler.ast.Expression.generateCode(Expression.java:601)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:232)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:581)
  at
 org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.generateCode(CompilationUnitDeclaration.java:356)
 at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:755)
  at
 com.google.gwt.dev.javac.JdtCompiler$CompilerImpl.process(JdtCompiler.java:182)
 at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:444)
  at com.google.gwt.dev.javac.JdtCompiler.doCompile(JdtCompiler.java:617)
 at
 com.google.gwt.dev.javac.CompilationStateBuilder$CompileMoreLater.compile(CompilationStateBuilder.java:193)
  at
 com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:390)
 at
 com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:275)
  at
 com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:325)
 at com.google.gwt.dev.Precompile.precompile(Precompile.java:512)
  at com.google.gwt.dev.Precompile.precompile(Precompile.java:495)
 at com.google.gwt.dev.Precompile.precompile(Precompile.java:407)
  at com.google.gwt.dev.Compiler.run(Compiler.java:215)
 at com.google.gwt.dev.Compiler.run(Compiler.java:187)
  at com.google.gwt.dev.Compiler$1.run(Compiler.java:159)
 at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:87)
  at
 com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRunner.java:81)
 at com.google.gwt.dev.Compiler.main(Compiler.java:166)


 Can somebody help me with this please ?

 cheers,

 Alain

 --

 GWT API for  non Java based platforms
 http://code.google.com/p/gwt4air/
 http://www.gwt4air.appspot.com/


  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
David Chandler
Developer Programs Engineer, Google Web Toolkit
w: http://code.google.com/
b: http://googlewebtoolkit.blogspot.com/
t: @googledevtools

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send 

How to extend GWT Module to Dynamic Web Module with Maven?

2011-05-02 Thread sipungora
Hi,

My problem:

on the page:
http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/39e0ff6325e4d504/55bfd342d77ec910?pli=1

one explains how gwt-module can be extended to Dynamic Web Module in
order to be deploybar into eclipse tomcat. I've configured my pom so,
that item 3 will be done by maven.


3. insert the following natures into your .project file (inside the
natures node):
 
natureorg.eclipse.wst.common.modulecore.ModuleCoreNature/nature
 
natureorg.eclipse.wst.common.project.facet.core.nature/nature
natureorg.eclipse.wst.jsdt.core.jsNature/nature

But how can I configure pom for 7 and 8 items?


6. right-click the project and select Properties - Project Facets
7. Check  'Java' and 'Dynamic Web Project'
8. Click 'further configuration available' and change the Content
Directory to 'war', to align with GWT's output


This is my configuration:


plugin
groupIdorg.apache.maven.plugins/
groupId
artifactIdmaven-eclipse-plugin/
artifactId
version2.8/version
configuration
additionalBuildcommands
 
buildcommandorg.eclipse.jdt.core.javabuilder
/buildcommand
 
buildcommandcom.google.gdt.eclipse.core.webAppProjectValidator
/buildcommand
 
buildcommandcom.google.gwt.eclipse.core.gwtProjectValidator
/buildcommand
/additionalBuildcommands
additionalProjectnatures
 
projectnatureorg.eclipse.jdt.core.javanature
/projectnature
 
projectnaturecom.google.gwt.eclipse.core.gwtNature
/projectnature
 
projectnatureorg.eclipse.wst.common.modulecore.ModuleCoreNature
/projectnature
 
projectnatureorg.eclipse.wst.common.project.facet.core.nature
/projectnature
 
projectnatureorg.eclipse.wst.jsdt.core.jsNature
/projectnature
/additionalProjectnatures

classpathContainers
 
classpathContainercom.google.gwt.eclipse.core.GWT_CONTAINER
/classpathContainer
 
classpathContainerorg.eclipse.jdt.launching.JRE_CONTAINER
/classpathContainer
/classpathContainers
additionalProjectFacets
jst.java6.0/
jst.java
jst.web2.4/jst.web
/badditionalProjectFacets

/configuration
/plugin

But additionalProjectFacets have no effect.
If I do items 7 and 8 manually as it was described, the file
org.eclipse.wst.common.project.facet.core.xml will be created. Its
content is

?xml version=1.0 encoding=UTF-8?
faceted-project
  installed facet=jst.java version=6.0/
  installed facet=jst.web version=2.4/
/faceted-project

But unfortunately this file will not be created by maven (I build with
mvn eclipse:eclipse).

This was item 7.

About item 8 I have no ideas yet (I mean the build with maven).

Thanks in advance.
Best Regards.
-sipungora

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: removing focus border from CellTable cells

2011-05-02 Thread Jeff.Lowery
If you can add a class name to the table, you can try this:

.table-class-name td {
   border-style: none;
}

Which will remove all table cell borders on selection


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to extend GWT Module to Dynamic Web Module with Maven?

2011-05-02 Thread David Chandler
Hi sipungora,

This info is pretty outdated. With Google Plugin for Eclipse 2.x, you can
simply Import | Existing maven project, point it to your POM, and the
project will be configured correctly.

Provided you have the correct POM, of course. Here are several you can look
at:

http://code.google.com/p/google-web-toolkit/source/browse/trunk/samples/expenses/pom.xml(GWT+GAE
Maven project maintained by the GWT team)
http://code.google.com/p/listwidget/source/browse/trunk/pom.xml (simpler POM
for one of my own GWT+GAE projects not using Spring)

/dmc

There are several example POMs you can look at

On Mon, May 2, 2011 at 2:11 PM, sipungora kostya...@yahoo.de wrote:

 Hi,

 My problem:

 on the page:

 http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/39e0ff6325e4d504/55bfd342d77ec910?pli=1

 one explains how gwt-module can be extended to Dynamic Web Module in
 order to be deploybar into eclipse tomcat. I've configured my pom so,
 that item 3 will be done by maven.


 
 3. insert the following natures into your .project file (inside the
 natures node):

 natureorg.eclipse.wst.common.modulecore.ModuleCoreNature/nature

 natureorg.eclipse.wst.common.project.facet.core.nature/nature
natureorg.eclipse.wst.jsdt.core.jsNature/nature

 
 But how can I configure pom for 7 and 8 items?


 
 6. right-click the project and select Properties - Project Facets
 7. Check  'Java' and 'Dynamic Web Project'
 8. Click 'further configuration available' and change the Content
 Directory to 'war', to align with GWT's output

 

 This is my configuration:


plugin
groupIdorg.apache.maven.plugins/
 groupId
artifactIdmaven-eclipse-plugin/
 artifactId
version2.8/version
configuration
additionalBuildcommands

 buildcommandorg.eclipse.jdt.core.javabuilder
/buildcommand

 buildcommandcom.google.gdt.eclipse.core.webAppProjectValidator
/buildcommand

 buildcommandcom.google.gwt.eclipse.core.gwtProjectValidator
/buildcommand
/additionalBuildcommands
additionalProjectnatures

 projectnatureorg.eclipse.jdt.core.javanature
/projectnature

 projectnaturecom.google.gwt.eclipse.core.gwtNature
/projectnature

 projectnatureorg.eclipse.wst.common.modulecore.ModuleCoreNature
/projectnature

 projectnatureorg.eclipse.wst.common.project.facet.core.nature
/projectnature

 projectnatureorg.eclipse.wst.jsdt.core.jsNature
/projectnature
/additionalProjectnatures

classpathContainers

 classpathContainercom.google.gwt.eclipse.core.GWT_CONTAINER
/classpathContainer

 classpathContainerorg.eclipse.jdt.launching.JRE_CONTAINER
/classpathContainer
/classpathContainers
additionalProjectFacets
jst.java6.0/
 jst.java
jst.web2.4/jst.web
/badditionalProjectFacets

/configuration
/plugin

 But additionalProjectFacets have no effect.
 If I do items 7 and 8 manually as it was described, the file
 org.eclipse.wst.common.project.facet.core.xml will be created. Its
 content is

 ?xml version=1.0 encoding=UTF-8?
 faceted-project
  installed facet=jst.java version=6.0/
  installed facet=jst.web version=2.4/
 /faceted-project

 But unfortunately this file will not be created by maven (I build with
 mvn eclipse:eclipse).

 This was item 7.

 About item 8 I have no ideas yet (I mean the build with maven).

 Thanks in advance.
 Best Regards.
 -sipungora

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 

Re: Offline map functionallity GWT

2011-05-02 Thread Eric Ayers
The underlying javascript api requires an Internet connection.  If you are
providing your own map tiles you might be able to use openmaps or a gwt
project called Saschamaps in combination with gears or html5 persistence.
On May 2, 2011 11:51 AM, qperez qpe...@gmail.com wrote:
 Hi, is there any way to obtain offline map functionallity for a GWT
 application?
 We are using GWT 2.1 with gwtmaps module from google apis, but the map
 goes away as soon as our computer goes offline. we need to implement
 some kind of offline functionallity.

 Thanks in advance,
 Ana

 --
 You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.


-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Probleme when compiling gwt project

2011-05-02 Thread nino ekambi
Hi David,
It looks like i had a broken workspace. Switching to another one solved the
problem.

Thank you.

Alain

2011/5/2 David Chandler drfibona...@google.com

 Can you supply sample code so we can reproduce this and research it?

 On Sun, May 1, 2011 at 4:11 AM, nino ekambi 
 jazzmatad...@googlemail.comwrote:

 Hello people,

 i m getting this error when compiling my GWT Project :

 [ERROR] Unexpected
 java.lang.ArrayIndexOutOfBoundsException: -1
 at
 org.eclipse.jdt.internal.compiler.codegen.StackMapFrame.addStackItem(StackMapFrame.java:105)
  at
 org.eclipse.jdt.internal.compiler.ClassFile.traverse(ClassFile.java:7386)
 at
 org.eclipse.jdt.internal.compiler.ClassFile.completeCodeAttribute(ClassFile.java:1613)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:244)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:564)
  at
 org.eclipse.jdt.internal.compiler.ast.QualifiedAllocationExpression.generateCode(QualifiedAllocationExpression.java:169)
 at
 org.eclipse.jdt.internal.compiler.ast.Statement.generateArguments(Statement.java:102)
  at
 org.eclipse.jdt.internal.compiler.ast.MessageSend.generateCode(MessageSend.java:153)
 at
 org.eclipse.jdt.internal.compiler.ast.Expression.generateCode(Expression.java:601)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:232)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:564)
  at
 org.eclipse.jdt.internal.compiler.ast.QualifiedAllocationExpression.generateCode(QualifiedAllocationExpression.java:169)
 at
 org.eclipse.jdt.internal.compiler.ast.Statement.generateArguments(Statement.java:102)
  at
 org.eclipse.jdt.internal.compiler.ast.MessageSend.generateCode(MessageSend.java:153)
 at
 org.eclipse.jdt.internal.compiler.ast.Expression.generateCode(Expression.java:601)
  at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:232)
 at
 org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.generateCode(AbstractMethodDeclaration.java:179)
  at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:530)
 at
 org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.generateCode(TypeDeclaration.java:581)
  at
 org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.generateCode(CompilationUnitDeclaration.java:356)
 at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:755)
  at
 com.google.gwt.dev.javac.JdtCompiler$CompilerImpl.process(JdtCompiler.java:182)
 at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:444)
  at com.google.gwt.dev.javac.JdtCompiler.doCompile(JdtCompiler.java:617)
 at
 com.google.gwt.dev.javac.CompilationStateBuilder$CompileMoreLater.compile(CompilationStateBuilder.java:193)
  at
 com.google.gwt.dev.javac.CompilationStateBuilder.doBuildFrom(CompilationStateBuilder.java:390)
 at
 com.google.gwt.dev.javac.CompilationStateBuilder.buildFrom(CompilationStateBuilder.java:275)
  at
 com.google.gwt.dev.cfg.ModuleDef.getCompilationState(ModuleDef.java:325)
 at com.google.gwt.dev.Precompile.precompile(Precompile.java:512)
  at com.google.gwt.dev.Precompile.precompile(Precompile.java:495)
 at com.google.gwt.dev.Precompile.precompile(Precompile.java:407)
  at com.google.gwt.dev.Compiler.run(Compiler.java:215)
 at com.google.gwt.dev.Compiler.run(Compiler.java:187)
  at com.google.gwt.dev.Compiler$1.run(Compiler.java:159)
 at com.google.gwt.dev.CompileTaskRunner.doRun(CompileTaskRunner.java:87)
  at
 com.google.gwt.dev.CompileTaskRunner.runWithAppropriateLogger(CompileTaskRunner.java:81)
 at com.google.gwt.dev.Compiler.main(Compiler.java:166)


 Can somebody help me with this please ?

 cheers,

 Alain

 --

 GWT API for  non Java based platforms
 http://code.google.com/p/gwt4air/
 http://www.gwt4air.appspot.com/


  --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




 --
 David Chandler
 Developer Programs Engineer, Google Web Toolkit
 w: http://code.google.com/
 b: http://googlewebtoolkit.blogspot.com/
 t: @googledevtools

 --
 You received this message because you are 

dynamic GWT page creation based on Java Bean

2011-05-02 Thread Ajay
Hi,

I have one use case and want to know whether we can achieve it through
GWT or not.
I have a XML which has set of elements along with their property.This
configuration gets persisted in DB and later point of time based on
user request we load the configuration and convert it into some kind
of bean.

Now, My question is that can we generate dynamic html pages depending
upon bean meta information ?

like for example
1) XML element will property like , uitype,readonly,maxlength,
validation and so on ..
2) Will generate GWT component by reading this property from java bean

If not clear please revert back to me ..

Thanks for your time
Waiting for your positive reply

Thanks,
Ajay

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: How to select a row on click of any cell in that row - Celltable

2011-05-02 Thread Alexandre Ardhuin
Define a SingleSelectionModel and add it to CellTable :

final SingleSelectionModelT ssm = new SingleSelectionModelT();
cellTable.setSelectionModel(ssm);
ssm.addSelectionChangeHandler(new Handler() {
@Override
public void onSelectionChange(final SelectionChangeEvent event)
{
final T selectedObject = ssm.getSelectedObject();
// do what you want
}
});

Alexandre

2011/4/28 kalpana anbalagan kalpana.anbala...@gmail.com

 Hello,

 I am using GWT 2.2 CellTable. I want to select a row if i click on
 any cell in that row similar to what is achieved when selecting
 checkbox in the selectionmodel. As per my requirement, we are not
 using Checkboxcell to select a row in celltable.

 note: all the cells in the celltable are constructed using
 TextColumn.

 Can anyone help me on this.

 Thanks in Advance,
 Kalpana

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.



-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: dynamic GWT page creation based on Java Bean

2011-05-02 Thread David Chandler
Hi Ajay,

GWT doesn't generate dynamic HTML pages like server-side frameworks. The GWT
compiler produces highly optimized JavaScript that runs in the browser.
Also, the GWT compiler doesn't support reflection, so you can't parse an
arbitrary Java type at runtime. You could, however, use GWT's RequestBuilder
and XMLParser to retrieve XML metadata from the server and alter the UI
accordingly.

HTH,
/dmc

On Mon, May 2, 2011 at 3:47 PM, Ajay creativeaja...@gmail.com wrote:

 Hi,

 I have one use case and want to know whether we can achieve it through
 GWT or not.
 I have a XML which has set of elements along with their property.This
 configuration gets persisted in DB and later point of time based on
 user request we load the configuration and convert it into some kind
 of bean.

 Now, My question is that can we generate dynamic html pages depending
 upon bean meta information ?

 like for example
 1) XML element will property like , uitype,readonly,maxlength,
 validation and so on ..
 2) Will generate GWT component by reading this property from java bean

 If not clear please revert back to me ..

 Thanks for your time
 Waiting for your positive reply

 Thanks,
 Ajay

 --
 You received this message because you are subscribed to the Google Groups
 Google Web Toolkit group.
 To post to this group, send email to google-web-toolkit@googlegroups.com.
 To unsubscribe from this group, send email to
 google-web-toolkit+unsubscr...@googlegroups.com.
 For more options, visit this group at
 http://groups.google.com/group/google-web-toolkit?hl=en.




-- 
David Chandler
Developer Programs Engineer, Google Web Toolkit
w: http://code.google.com/
b: http://googlewebtoolkit.blogspot.com/
t: @googledevtools

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Problems with Godaddy hosting and server-side deserialization

2011-05-02 Thread Joe D.
Alan,
Do you have suggestions for hosting providers that you are happy with. I'm 
so sick of NoDaddy and trying to fit a square peg (eg GWT) into a round hole 
(eg CrapDaddy). 
*Webhostingjava.net *looks interesting.

There's of course the appengine route, but wouldn't I have to covert my 
existing relational data models to it's object model? Not quite ready for 
that yet.

I've also considered moving away from GWT-RPC to JSON, as the former seems 
to be the problem (if you will). Besides, GWT-RPC is not available for 
Android which is a severe limitation.

Without further babble: decisions, decisions. 

Any wisdom from this awesome GWTer community is truly appreciated!
Joe

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Problems with Godaddy hosting and server-side deserialization

2011-05-02 Thread Alan Chaney

Joe

On 5/2/2011 3:26 PM, Joe D. wrote:

Alan,
Do you have suggestions for hosting providers that you are happy with. I'm
so sick of NoDaddy and trying to fit a square peg (eg GWT) into a round hole
(eg CrapDaddy).
*Webhostingjava.net *looks interesting.
I've used what was thePlanet but has now evolved into Softlayer for several years on several 
projects quite successfully. There's also AWS and RackMount. I have no experience of 
Webhostingjava.net so I can't comment.



I've also considered moving away from GWT-RPC to JSON, as the former seems
to be the problem (if you will). Besides, GWT-RPC is not available for
Android which is a severe limitation.


Yes, that's a possibility. Good point about Android

Alan

--
You received this message because you are subscribed to the Google Groups Google 
Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



SmartGWT, UIBinder and GWT Designer

2011-05-02 Thread richip
Has anyone successfully used the above products / technologies to
create a UIBinder GUI object that's editable in GWT Designer and makes
use SmartGWT? Can you send me some tips?

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: Offline map functionallity GWT

2011-05-02 Thread chris
GWT 
2.3http://code.google.com/webtoolkit/doc/latest/ReleaseNotes.html#LocalStorage
 seems 
to have a Local Storage API, maybe that can be used to do what you need.

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



how do u capture click events in cellbrowser

2011-05-02 Thread alexl
hi,

I want to make cellbrowser consisting of albums and photos, and when
you click on a photo (ImageCell) the id is returned, how do you
capture those events

thanks

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Re: how to reposition the popup when window gets resized

2011-05-02 Thread newbee
Thanks guys. I will try this ResizeHandle solution and will post it if
that works well.

On May 2, 9:24 pm, Ben Imp benlee...@gmail.com wrote:
 I believe the center() method on the dialog will re-center a dialog even if
 its already visible.  Stick that into a resize handler and you should be
 good to go.

 -Ben

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



Map not displayed in broaser after adding map api.jar also...

2011-05-02 Thread Ram
I have included GWT Maps api.jar file in my GWT Project build
path.Then i try sample program given by GWTI did all same as
instructed by that samplebut the map is not displayed in my
browser when i run my project...


What is the Problem here...Also i noticed, when i try try to compile
GWT projectI got some exception in Maps jar fileWhat is the
problem here...please help me..

-- 
You received this message because you are subscribed to the Google Groups 
Google Web Toolkit group.
To post to this group, send email to google-web-toolkit@googlegroups.com.
To unsubscribe from this group, send email to 
google-web-toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/google-web-toolkit?hl=en.



[gwt-contrib] Re: Using the Editor framework to edit tasks in the MobileWebApp sample. The DateButton widget is li... (issue1425808)

2011-05-02 Thread Rodrigo Chandia
Thanks for reporting the issue! Filed at:

http://code.google.com/p/google-web-toolkit/issues/detail?id=6300

On Fri, Apr 29, 2011 at 3:15 PM, misra.a...@gmail.com wrote:

 There is a small issue with cancel button, when you add task. It doesn't
 work.

 On 2011/04/27 17:38:57, jlabanca wrote:

 committed as r10087




 http://gwt-code-reviews.appspot.com/1425808/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

2011-05-02 Thread t . broyer

I addressed the feedback (including Brian's one, adding a paragraph to
SafeUri javadoc) and formatted the files.


http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java
File user/src/com/google/gwt/resources/client/ImageResource.java
(right):

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/client/ImageResource.java#newcode127
user/src/com/google/gwt/resources/client/ImageResource.java:127: String
getURL();
On 2011/04/27 18:01:32, jat wrote:

Should this be deprecated?


Done.

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
File user/src/com/google/gwt/resources/rg/DataResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/DataResourceGenerator.java#newcode68
user/src/com/google/gwt/resources/rg/DataResourceGenerator.java:68:
sw.println(new  + DataResourcePrototype.class.getName() + ();
On 2011/04/27 18:01:32, jat wrote:

Should this be getCanonicalName()?  In this case they are the same,

but in

general getName() is not going to return a name you can use in the

source.


If you change, change them all in this change.


ALL resource generators, and a whole bunch of other classes use
getName() instead getCanonicalName() (there's even a
getName().replace('$','.') in GwtCreateResourceGenerator!) so I'm gonna
leave them as is.

Moreover, those classes are public API so they're not going to turn into
nested classes, unexpectedly breaking the generator, so I think it's OK
to use getName() in this case (getCanonicalName would be better, but
getName is OK).

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
File user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java#newcode481
user/src/com/google/gwt/resources/rg/ImageResourceGenerator.java:481:
new String[]{bundle.getNormalContentsFieldName(),
bundle.getRtlContentsFieldName()};
On 2011/04/27 18:01:32, jat wrote:

space between ] and {


Done.

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
File
user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
(right):

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java#newcode302
user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java:302:
// TODO(xtof): refactor HtmlContext with isStart/isEnd/isEntire
accessors an simplified type.
On 2011/04/27 17:18:58, xtof wrote:

an[d] simplified?


Done.

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/user/client/ui/Image.java
File user/src/com/google/gwt/user/client/ui/Image.java (right):

http://gwt-code-reviews.appspot.com/1380806/diff/29005/user/src/com/google/gwt/user/client/ui/Image.java#newcode301
user/src/com/google/gwt/user/client/ui/Image.java:301: public abstract
void setVisibleRect(Image image, int left, int top, int width, int
height);
On 2011/04/27 18:01:32, jat wrote:

On 2011/04/27 17:18:58, xtof wrote:
 Maybe undo this line wrap?



Since we changed to 100 chars, my understanding is each file when

edited should

be reformatted, though ideally as a separate change to avoid

obfuscating the

real change.  In this case, I don't care much either way.


Done.

http://gwt-code-reviews.appspot.com/1380806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adds a ui:safehtml tag to UiBinder (issue1422812)

2011-05-02 Thread sbrubaker

http://gwt-code-reviews.appspot.com/1422812/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Add a convenience base class for value type locators (issue1428809)

2011-05-02 Thread rice

Reviewers: rjrjr, robertvawter,

Description:
Add a convenience base class for value type locators


Please review this at http://gwt-code-reviews.appspot.com/1428809/

Affected files:
  A user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java


Index:  
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java

===
--- user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java	 
(revision 0)
+++ user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java	 
(revision 0)

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+
+package com.google.web.bindery.requestfactory.shared;
+
+/**
+ * A {@link Locator} for use with value types (as opposed to entities),  
which
+ * are not persisted. Abstract methods from the {@link Locator} class that  
are

+ * not relevant for value types are implemented to return {@code null}.
+ *
+ * @param T the type of domain object the Locator will operate on
+ */
+public abstract class ValueLocatorT extends LocatorT, Void {
+
+  /**
+   * Returns {@code null}.
+   */
+  @Override
+  public final Void getId(T domainObject) {
+return null;
+  }
+
+  /**
+   * Returns {@code null}.
+   */
+  @Override
+  public final ClassVoid getIdType() {
+return null;
+  }
+
+  /**
+   * Returns {@code null}.
+   */
+  @Override
+  public final Object getVersion(T domainObject) {
+return null;
+  }
+}


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Remove duplicate build target (issue1423812)

2011-05-02 Thread rice

Reviewers: rjrjr,

Description:
Remove duplicate build target


Please review this at http://gwt-code-reviews.appspot.com/1423812/

Affected files:
  M build.xml


Index: build.xml
===
--- build.xml   (revision 10116)
+++ build.xml   (working copy)
@@ -40,7 +40,6 @@
 call-subproject subproject=requestfactory subtarget=build /
 call-subproject subproject=servlet subtarget=build /
 call-subproject subproject=jni subtarget=build /
-call-subproject subproject=requestfactory subtarget=build /
   /target

   target name=dist depends=build, doc description=[action] Make all  
the distributions



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread zundel

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread zundel

I decided to back out the original patch and go with using the output of
resource.getPath() as the key for the cache.  This should differentiate
between source and super-source but not include any special prefixes for
.jar files or generated files.


http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread zundel

I should also mention that this makes a follow-on patch to check
contentId in case jar file timestamps update a little bit easier when
updating the cached unit.

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add a convenience base class for value type locators (issue1428809)

2011-05-02 Thread t . broyer

My 2c.


http://gwt-code-reviews.appspot.com/1428809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
File
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java
(right):

http://gwt-code-reviews.appspot.com/1428809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java#newcode26
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java:26:
public abstract class ValueLocatorT extends LocatorT, Void {
Shouldn't find() also be implemented?

Also, getDomainType is never used, so it could be a good idea to
implement it here too.
(I believe it should be deprecated and made non-abstract at the Locator
level, don't know if it should be done in this CL though)

In other words, only create() is useful for a value object and should be
kept abstract.

http://gwt-code-reviews.appspot.com/1428809/diff/1/user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java#newcode33
user/src/com/google/web/bindery/requestfactory/shared/ValueLocator.java:33:
return null;
How about throw new UnsupportedOperationException() ?

http://gwt-code-reviews.appspot.com/1428809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Remove duplicate build target (issue1423812)

2011-05-02 Thread rjrjr

LGTM

http://gwt-code-reviews.appspot.com/1423812/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread tobyr

LGTM

Nice change. I like this better.


http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java#newcode147
dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java:147: try {
On 2011/04/30 16:08:28, jbrosenberg wrote:

Actually, this won't open the file, it will only parse the URL string,

and

return the name part, which is the substring after the '!'.   It's

probably not

necessary to construct a JarEntry intermediate value.  You can just do
connection.getEntryName().


You're right. It's not really obvious that's what's happening though
(and I've implemented my own URLConnection and URLStreamHandler).

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread tobyr

LGTM

Nice change. I like this better.


http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java#newcode147
dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java:147: try {
On 2011/04/30 16:08:28, jbrosenberg wrote:

Actually, this won't open the file, it will only parse the URL string,

and

return the name part, which is the substring after the '!'.   It's

probably not

necessary to construct a JarEntry intermediate value.  You can just do
connection.getEntryName().


You're right. It's not really obvious that's what's happening though
(and I've implemented my own URLConnection and URLStreamHandler).

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread tobyr

LGTM

Nice change. I like this better.


http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java#newcode147
dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java:147: try {
On 2011/04/30 16:08:28, jbrosenberg wrote:

Actually, this won't open the file, it will only parse the URL string,

and

return the name part, which is the substring after the '!'.   It's

probably not

necessary to construct a JarEntry intermediate value.  You can just do
connection.getEntryName().


You're right. It's not really obvious that's what's happening though
(and I've implemented my own URLConnection and URLStreamHandler).

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adds HTML5 App Cache support to MobileWebApp sample. (issue1422815)

2011-05-02 Thread pdr

Rietveld is giving me a bunch of errors trying to read files such as
web.xml. I reviewed the one file I could access and that is relevant to
this change, but do you mind re-uploading the patch?


http://gwt-code-reviews.appspot.com/1422815/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
File
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
(right):

http://gwt-code-reviews.appspot.com/1422815/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode57
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:57:
private static final String[] STATIC_FILES = {
Is there no way to grab these automatically so that this static files
stuff doesn't have to be here? At a minimum there should be a way to
parameterize this.

http://gwt-code-reviews.appspot.com/1422815/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode58
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:58:
/MobileWebApp.html,
I believe you don't need to list MobileWebApp.html in the cache manifest
since it will automatically be cached. The css file will need to be
listed though.

http://gwt-code-reviews.appspot.com/1422815/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java#newcode59
samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java:59:
/MobileWebApp.css,
These resources (in /audio/) can be included by adding a public
path=path to get exported/ line to your gwt.xml so you don't have to
list them here.

http://gwt-code-reviews.appspot.com/1422815/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10117 committed - Adding the SourceElement for use with Audio and Video, and adding conv...

2011-05-02 Thread codesite-noreply

Revision: 10117
Author:   jlaba...@google.com
Date: Mon May  2 06:45:06 2011
Log:  Adding the SourceElement for use with Audio and Video, and adding  
convenience methods in those widgets to use the element.  Multiple  
SourceElements can be specified for an AudioElement/VideoElement widget,  
and the browser will choose and download one of the sources that it can  
play.  This is convenient and easier than doing a runtime check in user  
code to figure out the best source file.


Review at http://gwt-code-reviews.appspot.com/1423810

Review by: p...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10117

Added:
 /trunk/user/src/com/google/gwt/dom/client/SourceElement.java
Modified:
  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/ui/SoundEffects.java

 /trunk/user/src/com/google/gwt/dom/client/AudioElement.java
 /trunk/user/src/com/google/gwt/dom/client/Document.java
 /trunk/user/src/com/google/gwt/dom/client/VideoElement.java
 /trunk/user/src/com/google/gwt/media/client/MediaBase.java
 /trunk/user/test/com/google/gwt/media/client/MediaTest.java

===
--- /dev/null
+++ /trunk/user/src/com/google/gwt/dom/client/SourceElement.java	Mon May  2  
06:45:06 2011

@@ -0,0 +1,100 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.gwt.dom.client;
+
+/**
+ * The SOURCE element specifies one of potentially multiple source file in  
a

+ * media element.
+ *
+ * @see a  
href=http://www.w3.org/TR/html5/video.html#the-source-element;W3C

+ *  HTML Specification/a
+ */
+@TagName(SourceElement.TAG)
+public class SourceElement extends Element {
+
+  static final String TAG = source;
+
+  /**
+   * Assert that the given {@link Element} is compatible with this class  
and

+   * automatically typecast it.
+   */
+  public static SourceElement as(Element elem) {
+assert elem.getTagName().equalsIgnoreCase(TAG);
+return (SourceElement) elem;
+  }
+
+  protected SourceElement() {
+  }
+
+  /**
+   * Returns the source URL for the media, or {@code null} if none is set.
+   *
+   * @return a String URL or {@code null}
+   *
+   * @see #setSrc(String)
+   */
+  public final native String getSrc() /*-{
+return this.src;
+  }-*/;
+
+  /**
+   * Returns the type of media represented by the src, or {@code null} if  
none

+   * is set.
+   *
+   * @return a String type, or {@code null}
+   *
+   * @see #setType(String)
+   */
+  public final native String getType() /*-{
+return this.type;
+  }-*/;
+
+  /**
+   * Sets the source URL for the media.
+   *
+   * @param url a String URL
+   *
+   * @see #getSrc()
+   */
+  public final native void setSrc(String url) /*-{
+this.src = url;
+  }-*/;
+
+  /**
+   * Sets the type of media represented by the src. The browser will look  
at the

+   * type when deciding which source files to request from the server.
+   *
+   * p
+   * The type is the format or encoding of the media represented by the  
source
+   * element. For example, the type of an {@link AudioElement} could be  
one of

+   * {@value AudioElement#TYPE_OGG}, {@link AudioElement#TYPE_MP3}, or
+   * {@link AudioElement#TYPE_WAV}.
+   * /p
+   *
+   * p
+   * You can also add the codec information to the type, giving the  
browser even

+   * more information about whether or not it can play the file (Example: 
+   * codeaudio/ogg; codec=vorbis/code);
+   * /p
+   *
+   * @param type the media type
+   *
+   * @see #getType()
+   */
+  public final native void setType(String type) /*-{
+this.type = type;
+  }-*/;
+}
===
---  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/ui/SoundEffects.java	 
Wed Apr 27 05:15:56 2011
+++  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/ui/SoundEffects.java	 
Mon May  2 06:45:06 2011

@@ -16,49 +16,13 @@
 package com.google.gwt.sample.mobilewebapp.client.ui;

 import com.google.gwt.dom.client.AudioElement;
-import com.google.gwt.dom.client.Document;
 import com.google.gwt.media.client.Audio;

-import java.util.ArrayList;
-import java.util.List;
-
 /**
  * A bundle of sound effects that can be used in the application.
  */
 public class SoundEffects {

-  /**
-   * The source path and type of an audio source file.
-   */
-  private static class AudioSource {
-private final String source;
-private final 

[gwt-contrib] Re: Adding the SourceElement for use with Audio and Video, and adding convenience methods in those w... (issue1423810)

2011-05-02 Thread jlabanca

committed as r10117

http://gwt-code-reviews.appspot.com/1423810/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Promoting LazyDomElement to be used externally. LazyDomElement can be (issue1427809)

2011-05-02 Thread rjrjr

Needs integration test, but let's leave that for a follow up. I want to
land http://gwt-code-reviews.appspot.com/1421811/ first.


http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
File user/src/com/google/gwt/uibinder/client/LazyDomElement.java
(right):

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#newcode33
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:33: *
lt;div ui:field=myDiv class={anyClass}/gt;
The class bit is noise, can you snip it?

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#newcode45
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:45: */
/**
  * Creates an instance to fetch the element with the given id.
  */

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#newcode54
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:54:
/**
  * Returns the dom element
  * @return the dom element
  * @throws RuntimeException is the element cannot be found
  */

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#newcode59
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:59: throw
new RuntimeException(Element is not attached.);
Cannot find element with id \ + domId + \. Perhaps it is not
attached to the document body?

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterOfLazyDomElement.java
File
user/src/com/google/gwt/uibinder/rebind/FieldWriterOfLazyDomElement.java
(right):

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterOfLazyDomElement.java#newcode46
user/src/com/google/gwt/uibinder/rebind/FieldWriterOfLazyDomElement.java:46:
if (!templateFieldType.isAssignableTo(parameterType)) {
Needs a unit test. See FieldWriterOfGeneratedCssResourceTest for
example.

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode380
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:380: // But
if the owner field is an instance of LazyDomElement then the code
/* for long comments

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode463
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:463: // We
can switch types if useLazyWidgetBuilders is enabled and the
/*

http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode710
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:710: return
lazyDomElementClass.isAssignableFrom(ownerField.getType().getRawType());
Can getRawType can return null? Is isAssignableFrom null safe?

http://gwt-code-reviews.appspot.com/1427809/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Discards the jar file name in the resource location. It isn't necessary, and (issue1428805)

2011-05-02 Thread tobyr

LGTM

Nice change. I like this better.

(This failed last time. This might be a duplicate).

http://gwt-code-reviews.appspot.com/1428805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Implementation of a RecordingEventBus, which is useful for writing (issue1429801)

2011-05-02 Thread rjrjr

LGTM

Thanks!

http://gwt-code-reviews.appspot.com/1429801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr

Some nits. Needs Rafa's LGTM


http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode61
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:61:
private MortalLogger logger;
please make the logger final while you're here

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode62
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:62:
private FieldWriterType fieldType;
Shouldn't fieldType be final?

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/FieldWriter.java (right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java#newcode145
user/src/com/google/gwt/uibinder/rebind/FieldWriter.java:145: void
setFieldType(FieldWriterType type);
Seems wrong for this to be a mutable value.

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java
File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java#newcode22
user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java:22: public
enum FieldWriterType {
Does it need to be public?

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fix Attachable for those poor fellows who don't have the bliss of SafeHtml enabled (yet). (issue1426808)

2011-05-02 Thread Ray Ryan
LGTM

On Fri, Apr 29, 2011 at 2:06 PM, rdcas...@google.com wrote:

 Reviewers: rjrjr,

 Description:
 Fix Attachable for those poor fellows who don't have the bliss of
 SafeHtml enabled (yet).


 Please review this at http://gwt-code-reviews.appspot.com/1426808/

 Affected files:
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java


 Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
 ===
 --- user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (revision
 10113)
 +++ user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java (working
 copy)
 @@ -792,7 +792,7 @@
*/
   public String tokenForSafeHtmlExpression(String expression) {
 if (!useSafeHtmlTemplates) {
 -  return tokenForStringExpression(expression);
 +  return tokenForStringExpression(expression + .asString());
 }

 String token = tokenator.nextToken(expression);




-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10118 committed - Implementation of a RecordingEventBus, which is useful for writing...

2011-05-02 Thread codesite-noreply

Revision: 10118
Author:   bd...@google.com
Date: Mon May  2 08:00:17 2011
Log:  Implementation of a RecordingEventBus, which is useful for writing
tests that verify whether certain events have been fired.

Review at http://gwt-code-reviews.appspot.com/1429801

Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10118

Added:
  
/trunk/user/src/com/google/web/bindery/event/shared/testing/RecordingEventBus.java


===
--- /dev/null
+++  
/trunk/user/src/com/google/web/bindery/event/shared/testing/RecordingEventBus.java	 
Mon May  2 08:00:17 2011

@@ -0,0 +1,77 @@
+/*
+ * Copyright 2011 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may  
not
+ * use this file except in compliance with the License. You may obtain a  
copy of

+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,  
WITHOUT

+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations  
under

+ * the License.
+ */
+package com.google.web.bindery.event.shared.testing;
+
+import com.google.web.bindery.event.shared.Event;
+import com.google.web.bindery.event.shared.Event.Type;
+import com.google.web.bindery.event.shared.EventBus;
+import com.google.web.bindery.event.shared.HandlerRegistration;
+import com.google.web.bindery.event.shared.SimpleEventBus;
+
+import java.util.HashSet;
+import java.util.Set;
+
+/**
+ * Wraps an {@link EventBus} implementation to keep track of fired events.
+ */
+public class RecordingEventBus extends EventBus {
+  private final SetEvent? firedEvents = new HashSetEvent?();
+  private final EventBus wrapped;
+
+  public RecordingEventBus() {
+this(new SimpleEventBus());
+  }
+
+  public RecordingEventBus(EventBus wrapped) {
+this.wrapped = wrapped;
+  }
+
+  @Override
+  public H HandlerRegistration addHandler(TypeH type, H handler) {
+return wrapped.addHandler(type, handler);
+  }
+
+  @Override
+  public H HandlerRegistration addHandlerToSource(TypeH type, Object  
source, H handler) {

+return wrapped.addHandlerToSource(type, source, handler);
+  }
+
+  /**
+   * Clears the remembered list of fired events.
+   */
+  public void clearFiredEvents() {
+firedEvents.clear();
+  }
+
+  @Override
+  public void fireEvent(Event? event) {
+wrapped.fireEvent(event);
+firedEvents.add(event);
+  }
+
+  @Override
+  public void fireEventFromSource(Event? event, Object source) {
+firedEvents.add(event);
+wrapped.fireEventFromSource(event, source);
+  }
+
+  /**
+   * Returns {@code true} if the specified event was fired.
+   */
+  public boolean wasEventFired(Event? event) {
+return firedEvents.contains(event);
+  }
+}

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10119 committed - Fix Attachable for those poor fellows who don't have the bliss of Safe...

2011-05-02 Thread codesite-noreply

Revision: 10119
Author:   gwt.mirror...@gmail.com
Date: Mon May  2 11:17:34 2011
Log:  Fix Attachable for those poor fellows who don't have the bliss of  
SafeHtml enabled (yet).


Review at http://gwt-code-reviews.appspot.com/1426808

Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10119

Modified:
 /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java

===
--- /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	Thu  
Apr 28 13:42:59 2011
+++ /trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java	Mon  
May  2 08:12:13 2011

@@ -792,7 +792,7 @@
*/
   public String tokenForSafeHtmlExpression(String expression) {
 if (!useSafeHtmlTemplates) {
-  return tokenForStringExpression(expression);
+  return tokenForStringExpression(expression + .asString());
 }

 String token = tokenator.nextToken(expression);

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] SafeHtmlRenderer code gen for UiBinder. (issue1427810)

2011-05-02 Thread rchandia

Reviewers: rjrjr,

Description:
SafeHtmlRenderer code gen for UiBinder.
Picking-up patch from rietveld issue 1426803


Please review this at http://gwt-code-reviews.appspot.com/1427810/

Affected files:
  M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
  M user/src/com/google/gwt/uibinder/elementparsers/CustomButtonParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/DomElementParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/HTMLPanelParser.java
  M user/src/com/google/gwt/uibinder/elementparsers/HasHTMLParser.java
  M  
user/src/com/google/gwt/uibinder/elementparsers/StackLayoutPanelParser.java
  M  
user/src/com/google/gwt/uibinder/elementparsers/TabLayoutPanelParser.java

  M user/src/com/google/gwt/uibinder/elementparsers/TabPanelParser.java
  M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
  M user/src/com/google/gwt/uibinder/rebind/FieldManager.java
  M user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
  M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: SafeHtmlRenderer code gen for UiBinder (issue1426803)

2011-05-02 Thread rchandia

Review will continue at http://gwt-code-reviews.appspot.com/1427810

On 2011/04/26 23:07:59, rjrjr wrote:

Turns out the useLazyWidget stuff isn't passing all of the UiBinder

tests

yet. Ignoring that path for now seems reasonable. Sorry for the flip

flop.


On Mon, Apr 25, 2011 at 3:19 PM,

https://mail.google.com/mail/?view=cmfs=1tf=1to=rj...@google.com
wrote:


 Oh, the base class exists already:

 com.google.gwt.text.shared.AbstractSafeHtmlRendererT


 http://gwt-code-reviews.appspot.com/1426803/





http://gwt-code-reviews.appspot.com/1426803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Phase 1 of GWT Dashboard. This includes an interface in gwt-dev for posting to a dashboard (defa... (issue1427807)

2011-05-02 Thread jhumphries

http://gwt-code-reviews.appspot.com/1427807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adding additional testing for GWT RPC. Some custom serialized objects (issue1424801)

2011-05-02 Thread unnurg

LGTM

On 2011/04/28 15:12:50, Stephen Chenney wrote:

I have removed the out-of-date comment and ran a smoke test with a

fresh pull of

GWT. Everything is checking out.



http://gwt-code-reviews.appspot.com/1424801/diff/1/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java

File user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java

(right):


http://gwt-code-reviews.appspot.com/1424801/diff/1/user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java#newcode126

user/test/com/google/gwt/user/client/rpc/CoreJavaTest.java:126: * This

test is

disabled because it times out, apparently due to an infinite
On 2011/04/28 00:18:48, unnurg wrote:
 Where is the code to disable this?



I forgot to update the comment after you helped me fix it. About to be

done.



http://gwt-code-reviews.appspot.com/1424801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Adding a tutorial video to the MobileWebApp sample as an example of using HTML5 video. Also fixi... (issue1425815)

2011-05-02 Thread jlabanca

Reviewers: rchandia,

Description:
Adding a tutorial video to the MobileWebApp sample as an example of
using HTML5 video. Also fixing issue 6300 (pressing cancel button
doesn't work when adding a new task).

Demo at http://jlabanca-testing.appspot.com/.  Click the Need Help?
link in the upper right corner to view the video.

Issue: 6300


Please review this at http://gwt-code-reviews.appspot.com/1425815/

Affected files:
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.ui.xml

  M samples/mobilewebapp/war/WEB-INF/web.xml


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Phase 1 of GWT Dashboard. This includes an interface in gwt-dev for posting to a dashboard (defa... (issue1427807)

2011-05-02 Thread jhumphries

I also added some conditions to BrowserChannelServerTest to integration
test the way this class works with DevModeSession.

And I had to add a utility class in the dev.shell package for use by
unit tests when working with DevModeSession class (since its constructor
and setSessionForCurrentThread() method are now package-private).


http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
File dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
(right):

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java#newcode171
dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java:171: *
@return the current session instance with which
codeSpeedTracerLogger/code
On 2011/04/29 23:25:14, tobyr wrote:

Better for this to be the top level javadoc with no @return than

vice-versa

Done.

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java
File
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java
(right):

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java#newcode62
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java:62:
e.printStackTrace();
Done. I did it slightly differently -- I added the causedBy exception
so that the printed stack trace shows the stack trace of this
constructed exception *and* the original exception and stack trace that
was caught here.

On 2011/04/29 23:25:14, tobyr wrote:

Probably better to do something like:
new Throwable(Unexpected failure while trying to load dashboard

class:  +

className + . The dashboard is disabled. Stack trace
follows:).printStackTrace();


http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java#newcode74
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java:74:
static void setNotifier(DashboardNotifier notifier) {
On 2011/04/29 23:25:14, tobyr wrote:

Ternary operator is simpler:
theNotifier = notifier == null ? defaultNotifier : notifier;


Done.

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java#newcode82
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifierFactory.java:82:
// no usable constructor -- use static method
On 2011/04/29 23:25:14, tobyr wrote:

This comment isn't useful. Just remove it or replace with a full

javadoc comment

that uses {@link getNotifier}.


Done.

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java
File
dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java
(right):

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java#newcode17
dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java:17:
package com.google.gwt.dev.util.log.dashboard;
On 2011/04/29 23:25:14, tobyr wrote:

I think we should move this into com.google.gwt.dev.shell. Then the

constructor

and ThreadLocal setter could be non-public.


Done.

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java#newcode20
dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java:20:
* Represents a session between dev.mode and a browser plugin.
On 2011/04/29 23:25:14, tobyr wrote:

s/dev.mode/devmode


Done.

http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java#newcode28
dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java:28:
* Gets the default session for the current thread.
I chose the name getSessionForCurrentThread since I think it is more
intuitive. The name getSessionForThread, at least to me, implies that it
will take a Thread as a parameter.

On 2011/04/29 23:25:14, tobyr wrote:

Add more explanation about what a default session is. (Not sure I

even like

that terminology. Maybe just getSessionForThread? Explain that it's

possible for

a thread to not be associated with a DevModeSession, in which case the

method

returns null.


http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java#newcode36
dev/core/src/com/google/gwt/dev/util/log/dashboard/DevModeSession.java:36:
* @param session
Done. Eclipse auto-generated it, and I just forgot to cull it before
sending for review.

On 2011/04/29 23:25:14, tobyr wrote:

Either leave out @params or document them.


http://gwt-code-reviews.appspot.com/1427807/diff/4001/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File

[gwt-contrib] Re: Adding a tutorial video to the MobileWebApp sample as an example of using HTML5 video. Also fixi... (issue1425815)

2011-05-02 Thread rchandia

LGTM. Awesome!
On 2011/05/02 18:56:59, jlabanca wrote:



http://gwt-code-reviews.appspot.com/1425815/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Makes some private info from AttachableHTMLPanel accessible to subclasses. (issue1423813)

2011-05-02 Thread rdcastro

Reviewers: rjrjr,

Description:
Makes some private info from AttachableHTMLPanel accessible to
subclasses.


Please review this at http://gwt-code-reviews.appspot.com/1423813/

Affected files:
  M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java


Index: user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
===
--- user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java	 
(revision 10116)
+++ user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java	 
(working copy)

@@ -62,7 +62,7 @@
   public Command wrapInitializationCallback = null;
   public Command detachedInitializationCallback = null;

-  private SafeHtml html = null;
+  protected SafeHtml html = null;
   private String styleName = null;

   /**
@@ -140,7 +140,7 @@

   @Override
   public com.google.gwt.user.client.Element getElement() {
-if (html != null) {
+if (!isFullyInitialized()) {
   // In case we haven't finished initialization yet, finish it now.
   buildAndInitDivContainer();
   html = null;
@@ -182,16 +182,16 @@
   @Override
   public void render(String id, SafeHtmlBuilder builder) {
 if (styleName != null) {
-  builder.append(TEMPLATE.renderWithIdAndClass(id, styleName, html));
+  builder.append(TEMPLATE.renderWithIdAndClass(id, styleName,  
getInnerHtml()));

   styleName = null;
 } else {
-  builder.append(TEMPLATE.renderWithId(id, html));
+  builder.append(TEMPLATE.renderWithId(id, getInnerHtml()));
 }
   }

   @Override
   public void setStyleName(String styleName) {
-if (html != null) {
+if (!isFullyInitialized()) {
   // If we haven't built the actual HTML element yet, we save the style
   // to apply later on.
   this.styleName = styleName;
@@ -202,7 +202,7 @@

   @Override
   public void wrapElement(Element element) {
-if (html == null) {
+if (!isFullyInitialized()) {
   // NOTE(rdcastro): This code is only run when Attachable is in  
active use.

   element.getParentNode().replaceChild(getElement(), element);
 } else {
@@ -217,6 +217,21 @@
   }

   /**
+   * Returns the HTML to be set as the innerHTML of the container.
+   */
+  protected SafeHtml getInnerHtml() {
+return html;
+  }
+
+  /**
+   * Whether the initilization of the panel is finished (i.e., the  
corresponding

+   * DOM element has been built).
+   */
+  protected boolean isFullyInitialized() {
+return html == null;
+  }
+
+  /**
* Method that finishes the initialization of HTMLPanel instances built  
from
* HTML. This will create a div to wrap the given HTML and call any  
callbacks

* that may have been added to the panel.
@@ -224,7 +239,7 @@
   private void buildAndInitDivContainer() {
 // Build the div that'll container the panel's HTML.
 Element element = Document.get().createDivElement();
-element.setInnerHTML(html.asString());
+element.setInnerHTML(getInnerHtml().asString());
 setElement(element);

 // If there's any wrap callback to call, we have to attach the div  
before



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Makes some private info from AttachableHTMLPanel accessible to subclasses. (issue1423813)

2011-05-02 Thread rjrjr

LGTM

http://gwt-code-reviews.appspot.com/1423813/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Add runtime-locale support for Localizable subtypes. (issue1425816)

2011-05-02 Thread jat

Reviewers: unnurg,

Description:
Add runtime-locale support for Localizable subtypes.

This is a prerequisitive for later work moving things from being
generated at compile-time to being mostly pre-generated during the CLDR
import step.  What can't be pre-generated is the runtime locales
support, so this provides the ability to support runtime locales for
pre-generated code.

Review by: unn...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1425816/

Affected files:
  M  
user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java

  M user/src/com/google/gwt/i18n/rebind/LocaleInfoGenerator.java
  M user/src/com/google/gwt/i18n/rebind/LocalizableGenerator.java
  M user/src/com/google/gwt/i18n/tools/I18NSync.java
  M user/test/com/google/gwt/i18n/I18NSuite.java
  A user/test/com/google/gwt/i18n/rebind/LocalizableGeneratorTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Add runtime-locale support for Localizable subtypes. (issue1425816)

2011-05-02 Thread jat


http://gwt-code-reviews.appspot.com/1425816/diff/1/user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java
File
user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java
(right):

http://gwt-code-reviews.appspot.com/1425816/diff/1/user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java#newcode60
user/src/com/google/gwt/i18n/client/impl/cldr/LocalizedNamesImplBase.java:60:
return super.loadLikelyRegionCodes();
So what was happening before I added this is that a delegating call
would fail with a visibility error, like this:

public class LocalizedNamesImpl_es_419_runtimeSelection extends
LocalizedNamesImpl {

  private LocalizedNamesImpl instance;

  protected String[] loadLikelyRegionCodes() {
ensureInstance();
return instance.loadLikelyRegionCodes();
  }
}

And it would fail with on the instance.loadLikelyRegionCodes call (in
both javac and Eclipse), even though other calls to protected methods
wouldn't.  I'm not sure why, but adding this fixed it.

http://gwt-code-reviews.appspot.com/1425816/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Fixing MediaTest#testAddSource to only compare the end of the src to the src that was set. Some... (issue1427811)

2011-05-02 Thread jlabanca

Reviewers: sbrubaker,

Description:
Fixing MediaTest#testAddSource to only compare the end of the src to the
src that was set.  Some browsers automatically prepend the host path to
the src file name.


Please review this at http://gwt-code-reviews.appspot.com/1427811/

Affected files:
  M user/test/com/google/gwt/media/client/MediaTest.java


Index: user/test/com/google/gwt/media/client/MediaTest.java
===
--- user/test/com/google/gwt/media/client/MediaTest.java(revision 10120)
+++ user/test/com/google/gwt/media/client/MediaTest.java(working copy)
@@ -97,15 +97,15 @@

 // Add some source elements.
 SourceElement source0 = media.addSource(file.ogg, audio/ogg);
-assertEquals(file.ogg, source0.getSrc());
+assertTrue(source0.getSrc().endsWith(file.ogg));
 assertEquals(audio/ogg, source0.getType());
 SourceElement source1 = media.addSource(file.ogv, video/ogg);
-assertEquals(file.ogv, source1.getSrc());
+assertTrue(source1.getSrc().endsWith(file.ogv));
 assertEquals(video/ogg, source1.getType());

 // Add a source without a type.
 SourceElement source2 = media.addSource(file.mp3);
-assertEquals(file.mp3, source2.getSrc());
+assertTrue(source2.getSrc().endsWith(file.mp3));

 // Check that the sources are a children of the media.
 assertEquals(media.getElement(), source0.getParentElement());


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fixing MediaTest#testAddSource to only compare the end of the src to the src that was set. Some... (issue1427811)

2011-05-02 Thread sbrubaker

LGTM

http://gwt-code-reviews.appspot.com/1427811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10121 committed - Fixing MediaTest#testAddSource to only compare the end of the src to t...

2011-05-02 Thread codesite-noreply

Revision: 10121
Author:   jlaba...@google.com
Date: Mon May  2 09:30:06 2011
Log:  Fixing MediaTest#testAddSource to only compare the end of the src  
to the src that was set.  Some browsers automatically prepend the host path  
to the src file name.


Review at http://gwt-code-reviews.appspot.com/1427811

http://code.google.com/p/google-web-toolkit/source/detail?r=10121

Modified:
 /trunk/user/test/com/google/gwt/media/client/MediaTest.java

===
--- /trunk/user/test/com/google/gwt/media/client/MediaTest.java	Mon May  2  
06:45:06 2011
+++ /trunk/user/test/com/google/gwt/media/client/MediaTest.java	Mon May  2  
09:30:06 2011

@@ -97,15 +97,15 @@

 // Add some source elements.
 SourceElement source0 = media.addSource(file.ogg, audio/ogg);
-assertEquals(file.ogg, source0.getSrc());
+assertTrue(source0.getSrc().endsWith(file.ogg));
 assertEquals(audio/ogg, source0.getType());
 SourceElement source1 = media.addSource(file.ogv, video/ogg);
-assertEquals(file.ogv, source1.getSrc());
+assertTrue(source1.getSrc().endsWith(file.ogv));
 assertEquals(video/ogg, source1.getType());

 // Add a source without a type.
 SourceElement source2 = media.addSource(file.mp3);
-assertEquals(file.mp3, source2.getSrc());
+assertTrue(source2.getSrc().endsWith(file.mp3));

 // Check that the sources are a children of the media.
 assertEquals(media.getElement(), source0.getParentElement());

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Fixing MediaTest#testAddSource to only compare the end of the src to the src that was set. Some... (issue1427811)

2011-05-02 Thread jlabanca

committed as r10121

http://gwt-code-reviews.appspot.com/1427811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10122 committed - Adding a tutorial video to the MobileWebApp sample as an example of us...

2011-05-02 Thread codesite-noreply

Revision: 10122
Author:   jlaba...@google.com
Date: Mon May  2 09:33:23 2011
Log:  Adding a tutorial video to the MobileWebApp sample as an example  
of using HTML5 video. Also fixing issue 6300 (pressing cancel button  
doesn't work when adding a new task).


Demo at http://jlabanca-testing.appspot.com/.  Click the Need Help? link  
in the upper right corner to view the video.


Issue: 6300

Review at http://gwt-code-reviews.appspot.com/1425815

Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10122

Added:
 /trunk/samples/mobilewebapp/war/video
 /trunk/samples/mobilewebapp/war/video/tutorial.mp4
 /trunk/samples/mobilewebapp/war/video/tutorial.ogv
Modified:
  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.ui.xml

 /trunk/samples/mobilewebapp/war/WEB-INF/web.xml

===
--- /dev/null   
+++ /trunk/samples/mobilewebapp/war/video/tutorial.mp4	Mon May  2 09:33:23  
2011

Binary file, no diff available.
===
--- /dev/null   
+++ /trunk/samples/mobilewebapp/war/video/tutorial.ogv	Mon May  2 09:33:23  
2011

Binary file, no diff available.
===
---  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java	 
Wed Apr 27 05:15:56 2011
+++  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java	 
Mon May  2 09:33:23 2011

@@ -49,6 +49,12 @@
*/
   private boolean isDead = false;

+  /**
+   * Indicates whether the activity is editing an existing task or  
creating a

+   * new task.
+   */
+  private boolean isEditing;
+
   /**
* The current task being edited.
*/
@@ -76,10 +82,10 @@
   }

   public void deleteTask() {
-if (task == null) {
-  doCancelTask();
-} else {
+if (isEditing) {
   doDeleteTask();
+} else {
+  doCancelTask();
 }
   }

@@ -148,12 +154,14 @@

 if (taskId == null) {
   // Create a new task.
+  isEditing = false;
   view.setEditing(false);
   TaskRequest request =  
clientFactory.getRequestFactory().taskRequest();

   task = request.create(TaskProxy.class);
   view.getEditorDriver().edit(task, request);
 } else {
   // Lock the display until the task is loaded.
+  isEditing = true;
   view.setEditing(true);
   view.setLocked(true);

===
---  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java	 
Wed Apr 27 05:15:56 2011
+++  
/trunk/samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java	 
Mon May  2 09:33:23 2011

@@ -18,8 +18,12 @@
 import com.google.gwt.canvas.dom.client.CssColor;
 import com.google.gwt.cell.client.AbstractCell;
 import com.google.gwt.core.client.GWT;
+import com.google.gwt.dom.client.MediaElement;
+import com.google.gwt.dom.client.VideoElement;
 import com.google.gwt.dom.client.Style.Unit;
+import com.google.gwt.event.dom.client.ClickEvent;
 import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.media.client.Video;
 import com.google.gwt.place.shared.Place;
 import com.google.gwt.place.shared.PlaceChangeEvent;
 import com.google.gwt.safehtml.shared.SafeHtmlBuilder;
@@ -37,11 +41,16 @@
 import  
com.google.gwt.user.cellview.client.HasKeyboardSelectionPolicy.KeyboardSelectionPolicy;

 import com.google.gwt.user.client.Window;
 import com.google.gwt.user.client.ui.Anchor;
+import com.google.gwt.user.client.ui.Button;
 import com.google.gwt.user.client.ui.DeckLayoutPanel;
+import com.google.gwt.user.client.ui.DialogBox;
 import com.google.gwt.user.client.ui.DockLayoutPanel;
+import com.google.gwt.user.client.ui.FlowPanel;
 import com.google.gwt.user.client.ui.HasOneWidget;
 import com.google.gwt.user.client.ui.IsWidget;
 import com.google.gwt.user.client.ui.Label;
+import com.google.gwt.user.client.ui.PopupPanel;
+import com.google.gwt.user.client.ui.VerticalPanel;
 import com.google.gwt.user.client.ui.Widget;
 import com.google.gwt.view.client.SelectionChangeEvent;
 import com.google.gwt.view.client.SingleSelectionModel;
@@ -124,10 +133,15 @@
*/
   private static final String CHART_URL_ATTRIBUTE = chart;

+  /**
+   * The external URL of the video tutorial for browsers that do not  
support

+   * video.
+   */
+  private static final String EXTERNAL_TUTORIAL_URL  
= http://www.youtube.com/watch?v=oHg5SJYRHA0;;

+
   private static MobileWebAppShellDesktopUiBinder uiBinder = GWT
   .create(MobileWebAppShellDesktopUiBinder.class);

-  // TODO(jlabanca): Record and show a help video tutorial.
 

[gwt-contrib] Re: Adding a tutorial video to the MobileWebApp sample as an example of using HTML5 video. Also fixi... (issue1425815)

2011-05-02 Thread jlabanca

committed as r10122

http://gwt-code-reviews.appspot.com/1425815/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes


http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode61
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:61:
private MortalLogger logger;
On 2011/05/02 17:19:59, rjrjr wrote:

please make the logger final while you're here


Done.

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode62
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:62:
private FieldWriterType fieldType;
On 2011/05/02 17:19:59, rjrjr wrote:

Shouldn't fieldType be final?


Nop, see setFieldType().

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/FieldWriter.java (right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriter.java#newcode145
user/src/com/google/gwt/uibinder/rebind/FieldWriter.java:145: void
setFieldType(FieldWriterType type);
On 2011/05/02 17:19:59, rjrjr wrote:

Seems wrong for this to be a mutable value.


True, done.

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java
File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java#newcode22
user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java:22: public
enum FieldWriterType {
On 2011/05/02 17:19:59, rjrjr wrote:

Does it need to be public?


Nop, done.

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr


http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode62
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:62:
private FieldWriterType fieldType;
That's my point. setFieldType seems wrong. The field type should be
passed in as a constructor arg.

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread hermes


http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
File user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java
(right):

http://gwt-code-reviews.appspot.com/1428807/diff/1/user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java#newcode62
user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java:62:
private FieldWriterType fieldType;
On 2011/05/02 19:45:26, rjrjr wrote:

That's my point. setFieldType seems wrong. The field type should be

passed in as

a constructor arg.


Ohh sorry, this was already done. Just forgot to remove the comment. See
the new patch.

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10123 committed - Guide eclipse users to jdk 1.6, not 1.5

2011-05-02 Thread codesite-noreply

Revision: 10123
Author:   rj...@google.com
Date: Mon May  2 09:43:22 2011
Log:  Guide eclipse users to jdk 1.6, not 1.5

http://code.google.com/p/google-web-toolkit/source/detail?r=10123

Modified:
 /trunk/eclipse/README.txt

===
--- /trunk/eclipse/README.txt   Fri Nov 12 04:18:43 2010
+++ /trunk/eclipse/README.txt   Mon May  2 09:43:22 2011
@@ -20,7 +20,7 @@
 Window-Preferences-Java-Build Path-Classpath Variables
 Create a variable named GWT_TOOLS pointing to your tools folder.
 Create a variable named JDK_HOME pointing to the root of your JDK install
-  (for example, C:\Program Files\jdk1.5.0_05 or /usr/lib/j2sdk1.5-sun)
+  (for example, C:\Program Files\jdk1.6 or /usr/lib/j2sdk1.6-sun)

  Spelling -

@@ -71,7 +71,7 @@

  Compiler settings 
 Window-Preferences-Java-Compiler
-Set the compiler compliance level to 1.5.
+Set the compiler compliance level to 1.6.

 --- Compiler errors  warnings 
 Window-Preferences-Java-Compiler-Errors/Warnings

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr

Looks good as soon as I see FieldWriterOfExsitingTypeTest.java. It's
okay to hold off on the integration test, but there shouldn't be
anything in the way of writing a unit test a la
FieldWriterOfGeneratedCssResourceTest.

Sorry, I could have sworn I asked for that in the first review. Must
have gotten distracted.

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Including the TaskProxy (when available) in TaskEditPlace so we do not do an extra round trip to... (issue1428810)

2011-05-02 Thread jlabanca

Reviewers: rchandia,

Description:
Including the TaskProxy (when available) in TaskEditPlace so we do not
do an extra round trip to the server to lookup the task.

Also fixing a bug where the Task List menu item isn't selected when
the task list is visible because TaskListPlace is no longer a singleton.
 We now do an instanceof check instead of an == check to compare the
TaskListPlace in the menu item to the TaskListPlace from the place
change event.


Please review this at http://gwt-code-reviews.appspot.com/1428810/

Affected files:
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskEditActivity.java
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/activity/TaskListActivity.java
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
  M  
samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/place/TaskEditPlace.java



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10124 committed - Edited wiki page TroubleshootingOOPHM through web user interface.

2011-05-02 Thread codesite-noreply

Revision: 10124
Author:   to...@google.com
Date: Mon May  2 13:03:37 2011
Log:  Edited wiki page TroubleshootingOOPHM through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=10124

Modified:
 /wiki/TroubleshootingOOPHM.wiki

===
--- /wiki/TroubleshootingOOPHM.wiki Fri Apr 15 15:09:20 2011
+++ /wiki/TroubleshootingOOPHM.wiki Mon May  2 13:03:37 2011
@@ -3,6 +3,7 @@

 ==(Chrome only) Do you see a Gray GWT Toolbox in your omnibar?==

+http://google-web-toolkit.googlecode.com/files/chrome-devmode-omnibar-grey-5-2-11.png
 The Chrome GWT plugin can't ask for permission like the Safari or Firefox  
GWT plugins. However, the GWT toolbox will appear in the omnibar whenever  
you try to use Development Mode. A gray toolbox icon indicates you have a  
permissions issue. You can click on the gray toolbox to jump to the  
configuration page and add your host to the whitelist. If your permissions  
are all in order, the toolbox icon will turn red.


 ==Are you trying cross-machine debugging?==

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] [google-web-toolkit] r10125 committed - Edited wiki page TroubleshootingOOPHM through web user interface.

2011-05-02 Thread codesite-noreply

Revision: 10125
Author:   to...@google.com
Date: Mon May  2 13:04:25 2011
Log:  Edited wiki page TroubleshootingOOPHM through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=10125

Modified:
 /wiki/TroubleshootingOOPHM.wiki

===
--- /wiki/TroubleshootingOOPHM.wiki Mon May  2 13:03:37 2011
+++ /wiki/TroubleshootingOOPHM.wiki Mon May  2 13:04:25 2011
@@ -4,6 +4,7 @@
 ==(Chrome only) Do you see a Gray GWT Toolbox in your omnibar?==

  
http://google-web-toolkit.googlecode.com/files/chrome-devmode-omnibar-grey-5-2-11.png

+
 The Chrome GWT plugin can't ask for permission like the Safari or Firefox  
GWT plugins. However, the GWT toolbox will appear in the omnibar whenever  
you try to use Development Mode. A gray toolbox icon indicates you have a  
permissions issue. You can click on the gray toolbox to jump to the  
configuration page and add your host to the whitelist. If your permissions  
are all in order, the toolbox icon will turn red.


 ==Are you trying cross-machine debugging?==

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adds ability to include SafeHtml objects in dom based UI's if the lazy (issue1421811)

2011-05-02 Thread rjrjr

http://gwt-code-reviews.appspot.com/1421811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Introducing FieldTypeWriter, an enum that identifies field writers and (issue1428807)

2011-05-02 Thread rjrjr

LGTM

Hermes will follow up with tests posthaste

http://gwt-code-reviews.appspot.com/1428807/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adds ability to include SafeHtml objects in dom based UI's if the lazy (issue1421811)

2011-05-02 Thread rjrjr

Updated with support for type parameters like W extends IsWidget 
IsPlaid in @UiChild methods. Unnur, can you take another look?

http://gwt-code-reviews.appspot.com/1421811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: Adds ability to include SafeHtml objects in dom based UI's if the lazy (issue1421811)

2011-05-02 Thread rjrjr

Hey there Rodrigo. Unnur is on point for this review, but you might find
it interesting.

http://gwt-code-reviews.appspot.com/1421811/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Improve runtime locales support, so runtime locales that are under a (issue1421812)

2011-05-02 Thread jat

Reviewers: unnurg,

Description:
Improve runtime locales support, so runtime locales that are under a
more specific compile-time locale do not appear under a more general
one.  An example would be compile locales of [es, es-419] and runtime
locales of [es-es, es-co, es-ar] -- the runtime locales for es should
not include es-co and es-ar since they are also under es-419.

Review by: unn...@google.com

Please review this at http://gwt-code-reviews.appspot.com/1421812/

Affected files:
  M user/src/com/google/gwt/i18n/rebind/LocaleUtils.java
  M user/src/com/google/gwt/i18n/server/GwtLocaleImpl.java
  A user/test/com/google/gwt/i18n/rebind/LocaleUtilsTest.java


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


  1   2   >