Re: Creating clickable links within text
On Tuesday, May 21, 2013 9:51:10 PM UTC+2, Joel wrote: I have a cell that contains some text. I would like to create links within the text that are clickable. For, example abc and xyz should be links. I figured on using InlineLabel to create the links within the text. However, since the whole thing is a cell I can't click on the individual label/links. 1) Is there a way to turn off click grabbing at the CellList level, so my inner links will work? I also need to know which one was clicked? How? Make a custom Cell: http://www.gwtproject.org/doc/latest/DevGuideUiCustomCells.html and http://google-web-toolkit.googlecode.com/svn/javadoc/latest/com/google/gwt/cell/client/AbstractCell.html Your links will be spans with specific class names, and in onBrowserEvent you'll check whether the event target is on of those spans and take action accordingly. Using UiRenderer will make it easier if you can use it: http://www.gwtproject.org/doc/latest/DevGuideUiBinder.html#Rendering_HTML_for_Cells 2) Is InlineLabel really the appropriate widget to use (I just want to take an action on the page, not leave the page)? No, just like any widget. You use Cells, so you can't use widgets (within them). -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: JPA issue: A parent cannot be established or changed once an object has been persisted.
Dear Alfredo and Juan,
obviously there is an hidden problem with my code i simply do not see.
Could you please have a short look at these 3 classes (full code) and tell
me what am I doing wrong here:
https://dl.dropboxusercontent.com/u/2983671/JPA_Problem/JPA_Problem.zip
Please note: Everything works fine as log as I do not try to make any
changes to the Tradesman entity (its parameters).
When is set new password or any other parameter, i get an error message of
type:
Detected attempt to establish Company(no-id-yet) as the parent of
Tradesman(358) but the entity identified by Tradesman(358) has already been
persisted without a parent. A parent cannot be established or changed once
an object has been persisted.
I am using: JPA with DataNucleus on Google Datastore. (Standard setting
that come with GWT 2.5)
Thank you in advance for your help!!
Best regards:
Nermin
Am Dienstag, 21. Mai 2013 18:29:54 UTC+2 schrieb Alfredo Quiroga-Villamil:
Or use a cascade persist, merge to force creation or merge respectively
Sent from my iPhone
On May 21, 2013, at 7:02 AM, Juan Pablo Gardella
gardella...@gmail.comjavascript:
wrote:
You should persist company before persist Tradesman or attach to an
existent company. This relation should be explicit. Create
company.addTrademan(Trademan t) method:
company.addTrademan(Trademan t){
users.add(t);
t.setCompany(this);
}
Call this in a transactional method.
Juan
2013/5/21 Nermin use...@gmx.de javascript:
Dear Juan,
I tried *@ManyToOne(optional=false)*, unfortunately no changes.
In my current setting, the @PrePersist is called only once. (I see it on
system out) That means: no multiple attempts to persist Tradesman entity.
However, it looks to me that whenever I change parameters on the
Tradesman entity JPA creates/persists for some reason the Tradesman in the
DB, independently from the Company entity.
I use Standard GWT settings: GWT 2.5, DataNucleus on Appengine Datastore.
The scenario I am describing here is a standard scenario you will face
when using GWT with JPA. I am surprised that my code is not working.
@PrePersist works fine as long as the Entity is not in a owned relation
with other entities.
Does anyone has an idea what could be wrong here?
Thank you!!
Nermin
@Thomas: Thank you for the advise. I will
Am Dienstag, 21. Mai 2013 12:01:43 UTC+2 schrieb Juan Pablo Gardella:
Update your entity as:
@Entity
public class Tradesman extends User{
@ManyToOne(optional=false)
private Company company;
*@PrePersist*
public void hashPassword(){
setPassword(BCrypt.hashpw(**enti**ty.getPassword(),
BCrypt.gensalt());
}
And then check where are you persisting Tradesman without company.
2013/5/21 Thomas Broyer t.br...@gmail.com
On Tuesday, May 21, 2013 11:18:42 AM UTC+2, Nermin wrote:
Dear GWT developers,
I have a probably simple problem with my application which I am
obviously not able to solve.
Two Classes: Company, Tradesman
@Entity
public class Company {
@OneToMany(cascade = CascadeType.ALL, mappedBy = company)
private ListTradesman users = new ArrayListTradesman();
}
@Entity
public class Tradesman extends User{
@ManyToOne
private Company company;
*@PrePersist*
public void hashPassword(){
setPassword(BCrypt.hashpw(**enti**ty.getPassword(),
BCrypt.gensalt());
}
*JSR 303 validation on GWT is activated.*
Here is the *error message:
*Detected attempt to establish Company(no-id-yet) as the parent of
Tradesman(356) but the entity identified by Tradesman(356) has already
been
persisted without a parent. A parent cannot be established or changed
once
an object has been persisted.
My problem is obviously that when I change some parameters within the
Tradesman entity within the *@PrePersist* method, a new child entity
is created.
In case I do not touch any parameter, in the @PrePersist, everything
works fine.
What am I doing wrong here?
You're not reaching the appropriate group ;-)
I suppose you're using AppEngine (form what I know of JPA, I can't see
a reason for that kind of message, unless you're using JPA on AppEngine),
in which case you can ask for support on StackOverflow: https://**
developers.google.com/**appengine/communityhttps://developers.google.com/appengine/community
--
You received this message because you are subscribed to the Google
Groups Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send
an email to google-web-toolkit+**unsubscr...@googlegroups.com.
To post to this group, send email to google-we...@**googlegroups.com.
Visit this group at http://groups.google.com/**
group/google-web-toolkit?hl=enhttp://groups.google.com/group/google-web-toolkit?hl=en
**.
For more options, visit
https://groups.google.com/**groups/opt_outhttps://groups.google.com/groups/opt_out
.
--
You
Re: gwt-maven-archetypes with multiple client modules
how to launch the DevMode from within eclipse on a setup with seperate client server project like your maven-archetype modular-webapp, without using maven? I'm trying to find this already for a few weeks, but I did not find a solution yet. Problem with the maven gwt:run launch is, that the client-side code isn't debug-able that way -- only server-side with the tomcat7-run can be debugged that way.. I've tried to create an eclipse run configuration analog to my single-project setups, but nothing worked so far... Am Freitag, 7. Dezember 2012 10:01:00 UTC+1 schrieb Thomas Broyer: On Friday, December 7, 2012 9:45:19 AM UTC+1, kim young ill wrote: Hi there, i start using this for gwt-modular webapp, quite great, Thanks but now i put a second gwt-module in the client package, how to configure the pom file so that both are avail. in -Ddev ? You'll have to replace the module with modules in the gwt-maven-plugin configuration, and add the modules as module child elements. You'd probably want to introduce another property in addition to gwt.module. Note that I made this dev profile only to make it easier to start up, but I highly recommend you to launch the DevMode from your IDE. gwt:run is far from ideal in this multi-module setup. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: gwt-maven-archetypes with multiple client modules
On Wednesday, May 22, 2013 12:09:44 PM UTC+2, Thomas Käfer wrote: how to launch the DevMode from within eclipse on a setup with seperate client server project like your maven-archetype modular-webapp, without using maven? I'm trying to find this already for a few weeks, but I did not find a solution yet. Problem with the maven gwt:run launch is, that the client-side code isn't debug-able that way -- only server-side with the tomcat7-run can be debugged that way.. Yes it is; far from ideal, but it's possible: use gwt:debug instead of gwt:run, and then attach a debugger to the process; see http://mojo.codehaus.org/gwt-maven-plugin/debug-mojo.html I've tried to create an eclipse run configuration analog to my single-project setups, but nothing worked so far... It should be as easy as Debug As… → Web Application (running on an external server) and using http://localhost:8080/ as the External server root and unchecking Select an HTML page; assuming you run Tomcat with mvn tomcat7:run (or any other setup such that it serves both myapp-client/target/myapp-client-1.0.0-SNAPSHOT and myapp-server/target/myapp-server-1.0.0-SNAPSHOT in the webapp; otherwise just go edit the launch configuration and change the -war to point to the myapp-server/target/myapp-server-1.0.0-SNAPSHOT) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: drag and drop group
Haven't used GWT Drag and Drop yet but can't you just skip the code in your drag or drop handler if your group condition isn't true? -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: gwt-maven-archetypes with multiple client modules
Thanks for your reply, and thanks for the info! Have a working debug-able environment now! With this Debug As… → Web Application (running on an external server) on the client project, I get the error Could not find any host-pages in project name-client My setup is generated by your maven archetype modular-webapp and nearly no changes, only played around with debug configurations and maven a little bit. But based on your other info I've managed to create a Web Application debug configuration manually, and it works! Huge thanks again! (also for creating these archetypes) Am Mittwoch, 22. Mai 2013 12:44:04 UTC+2 schrieb Thomas Broyer: On Wednesday, May 22, 2013 12:09:44 PM UTC+2, Thomas Käfer wrote: how to launch the DevMode from within eclipse on a setup with seperate client server project like your maven-archetype modular-webapp, without using maven? I'm trying to find this already for a few weeks, but I did not find a solution yet. Problem with the maven gwt:run launch is, that the client-side code isn't debug-able that way -- only server-side with the tomcat7-run can be debugged that way.. Yes it is; far from ideal, but it's possible: use gwt:debug instead of gwt:run, and then attach a debugger to the process; see http://mojo.codehaus.org/gwt-maven-plugin/debug-mojo.html I've tried to create an eclipse run configuration analog to my single-project setups, but nothing worked so far... It should be as easy as Debug As… → Web Application (running on an external server) and using http://localhost:8080/ as the External server root and unchecking Select an HTML page; assuming you run Tomcat with mvn tomcat7:run (or any other setup such that it serves both myapp-client/target/myapp-client-1.0.0-SNAPSHOT and myapp-server/target/myapp-server-1.0.0-SNAPSHOT in the webapp; otherwise just go edit the launch configuration and change the -war to point to the myapp-server/target/myapp-server-1.0.0-SNAPSHOT) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: gwt-maven-archetypes with multiple client modules
On Wednesday, May 22, 2013 1:08:38 PM UTC+2, Thomas Käfer wrote: Thanks for your reply, and thanks for the info! Have a working debug-able environment now! With this Debug As… → Web Application (running on an external server) on the client project, I get the error Could not find any host-pages in project name-client My setup is generated by your maven archetype modular-webapp and nearly no changes, only played around with debug configurations and maven a little bit. This is strange 'cause I tested it as I was replying, with a freshly created modular-webapp project. I had an error about test-client/target/test-client-1.0.0-SNAPSHOT not existing, but that was because I hadn't previously mvn package (or even run mvn tomcat7:run). I deleted the launch config and started again (Debug As…) and it just worked. But based on your other info I've managed to create a Web Application debug configuration manually, and it works! That's generally what I do, as I like to have control. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: JPA issue: A parent cannot be established or changed once an object has been persisted.
Show how you are persisting the entities.
2013/5/22 Nermin user...@gmx.de
Dear Alfredo and Juan,
obviously there is an hidden problem with my code i simply do not see.
Could you please have a short look at these 3 classes (full code) and tell
me what am I doing wrong here:
https://dl.dropboxusercontent.com/u/2983671/JPA_Problem/JPA_Problem.zip
Please note: Everything works fine as log as I do not try to make any
changes to the Tradesman entity (its parameters).
When is set new password or any other parameter, i get an error message of
type:
Detected attempt to establish Company(no-id-yet) as the parent of
Tradesman(358) but the entity identified by Tradesman(358) has already been
persisted without a parent. A parent cannot be established or changed once
an object has been persisted.
I am using: JPA with DataNucleus on Google Datastore. (Standard setting
that come with GWT 2.5)
Thank you in advance for your help!!
Best regards:
Nermin
Am Dienstag, 21. Mai 2013 18:29:54 UTC+2 schrieb Alfredo Quiroga-Villamil:
Or use a cascade persist, merge to force creation or merge respectively
Sent from my iPhone
On May 21, 2013, at 7:02 AM, Juan Pablo Gardella gardella...@gmail.com
wrote:
You should persist company before persist Tradesman or attach to an
existent company. This relation should be explicit. Create
company.addTrademan(Trademan t) method:
company.addTrademan(Trademan t){
users.add(t);
t.setCompany(this);
}
Call this in a transactional method.
Juan
2013/5/21 Nermin use...@gmx.de
Dear Juan,
I tried *@ManyToOne(optional=false)*, unfortunately no changes.
In my current setting, the @PrePersist is called only once. (I see it on
system out) That means: no multiple attempts to persist Tradesman entity.
However, it looks to me that whenever I change parameters on the
Tradesman entity JPA creates/persists for some reason the Tradesman in the
DB, independently from the Company entity.
I use Standard GWT settings: GWT 2.5, DataNucleus on Appengine Datastore.
The scenario I am describing here is a standard scenario you will face
when using GWT with JPA. I am surprised that my code is not working.
@PrePersist works fine as long as the Entity is not in a owned relation
with other entities.
Does anyone has an idea what could be wrong here?
Thank you!!
Nermin
@Thomas: Thank you for the advise. I will
Am Dienstag, 21. Mai 2013 12:01:43 UTC+2 schrieb Juan Pablo Gardella:
Update your entity as:
@Entity
public class Tradesman extends User{
@ManyToOne(optional=false)
private Company company;
*@PrePersist*
public void hashPassword(){
setPassword(BCrypt.hashpw(**entity.getPassword(),
BCrypt.gensalt());
}
And then check where are you persisting Tradesman without company.
2013/5/21 Thomas Broyer t.br...@gmail.com
On Tuesday, May 21, 2013 11:18:42 AM UTC+2, Nermin wrote:
Dear GWT developers,
I have a probably simple problem with my application which I am
obviously not able to solve.
Two Classes: Company, Tradesman
@Entity
public class Company {
@OneToMany(cascade = CascadeType.ALL, mappedBy = company)
private ListTradesman users = new ArrayListTradesman();
}
@Entity
public class Tradesman extends User{
@ManyToOne
private Company company;
*@PrePersist*
public void hashPassword(){
setPassword(BCrypt.hashpw(**entity.getPassword(),
BCrypt.gensalt());
}
*JSR 303 validation on GWT is activated.*
Here is the *error message:
*Detected attempt to establish Company(no-id-yet) as the parent of
Tradesman(356) but the entity identified by Tradesman(356) has already
been
persisted without a parent. A parent cannot be established or changed
once
an object has been persisted.
My problem is obviously that when I change some parameters within the
Tradesman entity within the *@PrePersist* method, a new child entity
is created.
In case I do not touch any parameter, in the @PrePersist, everything
works fine.
What am I doing wrong here?
You're not reaching the appropriate group ;-)
I suppose you're using AppEngine (form what I know of JPA, I can't see
a reason for that kind of message, unless you're using JPA on AppEngine),
in which case you can ask for support on StackOverflow: https://**
develop**ers.google.com/**appengine/**communityhttps://developers.google.com/appengine/community
--
You received this message because you are subscribed to the Google
Groups Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send
an email to google-web-toolkit+**unsubscribe**@googlegroups.com.
To post to this group, send email to google-we...@**googlegroups.com.
Visit this group at http://groups.google.com/**group**
/google-web-toolkit?hl=enhttp://groups.google.com/group/google-web-toolkit?hl=en
**.
For more options, visit
Build tree table with GWT CellTableBuilder
Is it possible to build a tree table like thishttp://www.sencha.com/examples/#ExamplePlace:basictreegridwith the new CellTableBuilder of vanilla GWT? https://lh5.googleusercontent.com/-oHWT1_E1_LY/UZzQ8WUvYlI/AAM/I8q4wxhkTt4/s1600/oqDJW.png The GWT Showcase examplehttp://gwt.googleusercontent.com/samples/Showcase/Showcase.html#!CwCustomDataGrid only allows to expand the top level rows. My use case requires expansion of multiple row levels. How can I achieve this with pure GWT? Regards Ben -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Build tree table with GWT CellTableBuilder
Hi, I managed this. I followed the example given on the latest GWT showcase for the custom data grid http://gwt.googleusercontent.com/samples/Showcase/Showcase.html#!CwCellTable Key is new TableRowBuilder. You can inject rows into the table. Use a Click event on a cell to trigger the injection. I used an asynchronous callback to get the data and found it easier to redraw the entire table. In the example the objects already contain the data. He iterates through a list building a new row for each item. James -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
primer for mobile development
The company I work for just got a secure mobile app that has browser integration for the specific platform (iOS,android). We have an existing GWT app (several actually) that could have some convenient mobile features. Can someone provide direction on resources (articles, books, blogs, forum posts) that I should read in order to get started on the right track. So, I've been using GWT for 2.5 years now and am very familiar with that. I've read about phonegap and the associated GWT projects around it. https://code.google.com/p/gwt-phonegap/ http://www.m-gwt.com/ What else?? My biggest question is: How to setup a browser environment to test chrome and safari (iOS) ? I will most likely never have the ability to actually have a Mac or iPad and will have to test on my personal iPhone. (argh) Thanks in advance! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Creating clickable links within text
Thanks for the response. I made some progress, like you say the trick is mostly in processing the DOM in the onBrowserEvent. I also had the issue of the pointer/selection trying to be handled by the CellList, this requires un-styling it appropriately and turning off selection mode: cellList.setSelectionModel(new NoSelectionModelReviewEntry(), DefaultSelectionEventManager.ReviewEntrycreateWhitelistManager()); Propagating the click events will be a little interesting as well as conditionally constructing these links in the cell renderer, but the end state is in sight. Thanks!, J -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: drag and drop group
conceptually, of course that is what you want to do. I tried disallow the drop from inside the onDragEnter and onDragOver events, but don't see any api to set the drag icon to disabled mode. I played with event.getDataTransfer().setDragImage(...), but it has no effect. On Wednesday, May 22, 2013 3:45:39 AM UTC-7, Jens wrote: Haven't used GWT Drag and Drop yet but can't you just skip the code in your drag or drop handler if your group condition isn't true? -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
One of the big problems with deployed GWT apps has always been the impossibility of tracing JavaScript exceptions back to the Java source code. What we need is a true equivalent of Java stack traces. There was an effort made by the GWT team a couple years ago to solve this problem ( https://code.google.com/p/google-web-toolkit/wiki/WebModeExceptions ), and it was a good start, but unfortunately they gave up without producing an adequate solution. If you've ever tried to use the compiler.emulatedStack.recordLineNumbers setting, you know that it is badly broken: the line numbers and file names reported in the stack traces are incorrect most of the time, while the the resulting compiled JavaScript is 70-90% larger than the original. The way this feature is currently implemented, the compiler puts instrumentations in the wrong places most of the time, doesn't do enough to optimize for code size, and does not provide enough information via symbol maps for StackTraceDeobfuscator. On Chrome, theoretically we could use compiler.useSourceMaps instead, but that feature is badly broken too. I have spent the last 2 months working on this problem full time, and I almost have the perfect solution ready. But I'm an indie developer, and I can't really afford to go unpaid much longer, because I've already put business aside for two months to work on this (originally I thought it would take a week, but I kept finding more and more bugs and tricky problems to solve, which is why I'm guessing the original developers gave up on seeing this project through to fruition). If I started a crowdfunding campaign to help me fund this work to completion, would you or your employer be willing to contribute? The original Google Atlanta team did an amazing job developing GWT for 10+ years, but those guys are all gone, and Google has not had a dedicated team working on GWT since last summer, so I think it will be up to the user community to fund its future development from now on. My goal is perfect JavaScript stack traces with exact Java line numbers, with only a 50-60% output size increase and similar performance metrics. For browsers that support sourcemaps (only Chrome for now), there will be no output size increase at all, because I intend to fix all the bugs associated with the compiler.useSourceMaps feature as well. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Offline debugging my gwt app
Hello GWT-team guys ! Nobody has an idea at least if is it a bug or a feature? Thanks a lot for your help Yves -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
I dont think you will get paid for it, because: 1.) Its somewhat not in the spirit of open source software 2.) Your patch must go through review and there is no guarantee that it will be committed 3.) GWT will remove IE6/7 support soon and probably in 2014 also IE8 support. Also Opera moves to WebKit. That means that there is probably no need for StackTrace emulation anymore in the near future as modern browsers provide the relevant information. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
Thanks for your comment. Let me respond to your points: 1) I've seen this point discussed before, and the standard counter-argument is that the spirit of OSS is free as in freedom, not beer. Lots of developers get paid to work on OSS projects. 2) This is actually one of the reasons I'm thinking about raising funds. I am already on the verge of using my patch inside my own GWT-based app, but if I get some funding I'd be able to justify taking the extra time to make sure the patch will pass the review process. 3) I must point out that your third argument is not in the spirit of GWT, which aims to support as many browsers as possible. As of today, you will not get good stack traces with GWT on any modern browser, including WebKit. By relevant information, I assume you mean sourcemaps support. Well, Chrome is the only browser that currently supports sourcemaps but GWT's existing support for generating stack traces with that information is very buggy, and this is one of the things I'm working on improving. I'm also not optimistic that sourcemaps will achieve universal support any time soon, if ever. On Wed, May 22, 2013 at 4:38 PM, Jens jens.nehlme...@gmail.com wrote: I dont think you will get paid for it, because: 1.) Its somewhat not in the spirit of open source software 2.) Your patch must go through review and there is no guarantee that it will be committed 3.) GWT will remove IE6/7 support soon and probably in 2014 also IE8 support. Also Opera moves to WebKit. That means that there is probably no need for StackTrace emulation anymore in the near future as modern browsers provide the relevant information. -- J. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/hP8cQ7AdDUc/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Exception reporting is broken in GWT: would you support a kickstarter project to fix it?
Correction: when I said that a browser needs to support sourcemaps to generate accurate stack traces, that wasn't entirely accurate. What a browser needs to support is the stack property of exception objects, which provides a JavaScript stack trace with both line and column numbers. It's the GWT compiler that uses a sourcemap to derive original Java line numbers and filenames from the browser-provided line and column numbers. This functionality is currently broken in GWT, however, and Chrome is currently the only browser that provides column numbers. And even if more browsers add column info in the future, it's almost certain that their stack trace formats will all be different, so we'll have to patch GWT every time a new browser adds the support. My proposed project will leave us in good shape to be able to do that easily. On Wed, May 22, 2013 at 5:53 PM, Alex Epshteyn alexander.epsht...@gmail.com wrote: Thanks for your comment. Let me respond to your points: 1) I've seen this point discussed before, and the standard counter-argument is that the spirit of OSS is free as in freedom, not beer. Lots of developers get paid to work on OSS projects. 2) This is actually one of the reasons I'm thinking about raising funds. I am already on the verge of using my patch inside my own GWT-based app, but if I get some funding I'd be able to justify taking the extra time to make sure the patch will pass the review process. 3) I must point out that your third argument is not in the spirit of GWT, which aims to support as many browsers as possible. As of today, you will not get good stack traces with GWT on any modern browser, including WebKit. By relevant information, I assume you mean sourcemaps support. Well, Chrome is the only browser that currently supports sourcemaps but GWT's existing support for generating stack traces with that information is very buggy, and this is one of the things I'm working on improving. I'm also not optimistic that sourcemaps will achieve universal support any time soon, if ever. On Wed, May 22, 2013 at 4:38 PM, Jens jens.nehlme...@gmail.com wrote: I dont think you will get paid for it, because: 1.) Its somewhat not in the spirit of open source software 2.) Your patch must go through review and there is no guarantee that it will be committed 3.) GWT will remove IE6/7 support soon and probably in 2014 also IE8 support. Also Opera moves to WebKit. That means that there is probably no need for StackTrace emulation anymore in the near future as modern browsers provide the relevant information. -- J. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/hP8cQ7AdDUc/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: primer for mobile development
I'm on the same train, I would like to get some guidance on mobile GWT. At least how to start on that. I'm doing my app in MVP pattern, so it would be great if it fits that. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: primer for mobile development
I use m-gwt http://www.m-gwt.com/ . You may want to run a device emulator to test on. Since it is a browser based environment, you can start with the desktop then test on devices. On Wed, May 22, 2013 at 6:56 PM, Mohammad Al-Quraian m4des...@gmail.comwrote: I'm on the same train, I would like to get some guidance on mobile GWT. At least how to start on that. I'm doing my app in MVP pattern, so it would be great if it fits that. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: primer for mobile development
Well there s also Touch4j and Titanium4j if you wanna use GWT on mobile. Touch4j wraps Sencha Touch Titanium4j wraps Appcelerator Titanium. Disclaimer: I m one of the person behind both projects 2013/5/23 Ed ej19...@gmail.com I use m-gwt http://www.m-gwt.com/ . You may want to run a device emulator to test on. Since it is a browser based environment, you can start with the desktop then test on devices. On Wed, May 22, 2013 at 6:56 PM, Mohammad Al-Quraian m4des...@gmail.comwrote: I'm on the same train, I would like to get some guidance on mobile GWT. At least how to start on that. I'm doing my app in MVP pattern, so it would be great if it fits that. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT project with maven
Hi , I am looking for the GWT project with the maven setup. Can you please provide me the link for the sample project ? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Can't deploy my project anymore
Has anyone pinpointed the cause of this? I have tried to fix this with fresh installations of Eclipse Juno and Indigo with the GWT SDK and Designer plugins, have deleted the gwt-cache dirs, am using jre6, and yet the problem persists, very weird. What else bothers me about this is that I can't figure out what I did that made this start happening; from my perspective this functionality was working just fine and then started failing one day when I did not make any substantial (from my perspective) changes to my environment. Maybe next I should try to print out all my code on paper, buy a new computer, install and setup everything, and type in the code again. Thanks! On Monday, March 18, 2013 4:38:02 PM UTC-4, JoyaleXandre wrote: Hi everybody, Since friday I can't deploy my project anymore. Went I start the war generation with the deploy button I instantly get an error *message saying*: Designer error occured. Select Details for more information. See the Error Log for more information. Reason: Parse error or internal Designer error, *The stack trace is this: * Plug-in Provider: Google Plug-in Name: Plug-in ID: org.eclipse java.lang.NoClassDefFoundError: org/eclipse/jdt/launching/IJavaLaunchConfigurationConstants at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.getGWTProjectClasspath(DeployModuleAction.java:364) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.createBuildScript(DeployModuleAction.java:150) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.access$1(DeployModuleAction.java:131) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:103) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Full stack trace (to see full context): java.lang.reflect.InvocationTargetException at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:114) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121) Caused by: java.lang.NoClassDefFoundError: org/eclipse/jdt/launching/IJavaLaunchConfigurationConstants at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.getGWTProjectClasspath(DeployModuleAction.java:364) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.createBuildScript(DeployModuleAction.java:150) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction.access$1(DeployModuleAction.java:131) at com.google.gdt.eclipse.designer.actions.deploy.DeployModuleAction$1.run(DeployModuleAction.java:103) ... 1 more I completely uninstalled the Google Plugin and reinstalled it. I still get this error. My last chance is probably to reinstall Eclipse from scratch, but I would like to avoid reinstalling and configuring all my dev envirronnement. Can somebody help me please. Am I the only one who got this problem since I tried to update the Google Plugin? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
show selected items after filter
the 2 items selected before the filtering are not shown (as selected) in
the ListGrid. So the user gets confused because he doesn't know that they
are saved externally, so I would like to check them again for him. So that
his view is consistent to what he already checked.
I found the forum a way, I write addDataArrivedHandler but how could I do
this? has anyone ever done this and could help me?
Follow my code
private static ListGrid criaGradeAuxiliares() {
final ListGrid gridAuxiliares = new ListGrid();
gridAuxiliares.setDataSource(DataSource.get(Constantes.DS_USUARIO));
//gridAuxiliares.setAutoFetchData(true);
gridAuxiliares.setFetchOperation(usuariosFiscalizacao);
ListGridField colunaNome =
FabricaComponentes.criaListGridField(new ConfigListGridField().setNome(nome));
ListGridField colunaPerfil =
FabricaComponentes.criaListGridField(new
ConfigListGridField().setNome(perfil));
ListGridField colunaUF =
FabricaComponentes.criaListGridField(new
ConfigListGridField().setNome(siglaEstado));
ListGridField colunaEmpresa =
FabricaComponentes.criaListGridField(new
ConfigListGridField().setNome(empresaFiscalizadora));
gridAuxiliares.setWidth100();
gridAuxiliares.setHeight(300);
gridAuxiliares.setFields(colunaNome, colunaPerfil, colunaUF,
colunaEmpresa);
gridAuxiliares.setSelectionType(SelectionStyle.SIMPLE);
gridAuxiliares.setSelectionAppearance(SelectionAppearance.CHECKBOX);
gridAuxiliares.setShowFilterEditor(true);
gridAuxiliares.setFilterOnKeypress(true);
gridAuxiliares.setFetchDelay(ConstantesVisao.CAMPO_TAM_50);
gridAuxiliares.setAutoFetchData(true);
return gridAuxiliares;
}
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT project with maven
There are a few examples on the web. Start here http://mojo.codehaus.org/gwt-maven-plugin/ On May 22, 2013, at 7:32 PM, Srinivasa Rao srinivasa.bodd...@gmail.com wrote: Hi , I am looking for the GWT project with the maven setup. Can you please provide me the link for the sample project ? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: primer for mobile development
Ed , thx for the reply. Can you point me to a device emulator? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: primer for mobile development
Nino , thx for the links. I will look into those. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Can't deploy my project anymore
I ran into the same problem and could not figure out which configuration setting got hosed. Fortunately for me, I had a backup on another computer and just reverted back to that project and GWT 2.5. That is one of the drawbacks of GWT--there is too much magic going on behind the scenes spread out in many directories and files. I will never try upgrading to a new version of GWT without backing up everything first. Sorry this probably won't help you--I feel your pain. Best, Jeff On May 22, 2013 7:20 PM, Jack Gage rjg...@gmail.com wrote: Has anyone pinpointed the cause of this? I have tried to fix this with fresh installations of Eclipse Juno and Indigo with the GWT SDK and Designer plugins, have deleted the gwt-cache dirs, am using jre6, and yet the problem persists, very weird. What else bothers me about this is that I can't figure out what I did that made this start happening; from my perspective this functionality was working just fine and then started failing one day when I did not make any substantial (from my perspective) changes to my environment. Maybe next I should try to print out all my code on paper, buy a new computer, install and setup everything, and type in the code again. Thanks! On Monday, March 18, 2013 4:38:02 PM UTC-4, JoyaleXandre wrote: Hi everybody, Since friday I can't deploy my project anymore. Went I start the war generation with the deploy button I instantly get an error *message saying*: Designer error occured. Select Details for more information. See the Error Log for more information. Reason: Parse error or internal Designer error, *The stack trace is this: * Plug-in Provider: Google Plug-in Name: Plug-in ID: org.eclipse java.lang.**NoClassDefFoundError: org/eclipse/jdt/launching/** IJavaLaunchConfigurationConsta**nts at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**getGWTProjectClasspath(** DeployModuleAction.java:364) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**createBuildScript(**DeployModuleAction.java:150) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.access$1(**DeployModuleAction.java:131) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:103) at org.eclipse.jface.operation.**ModalContext$** ModalContextThread.run(**ModalContext.java:121) Full stack trace (to see full context): java.lang.reflect.**InvocationTargetException at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:114) at org.eclipse.jface.operation.**ModalContext$** ModalContextThread.run(**ModalContext.java:121) Caused by: java.lang.**NoClassDefFoundError: org/eclipse/jdt/launching/** IJavaLaunchConfigurationConsta**nts at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**getGWTProjectClasspath(** DeployModuleAction.java:364) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.**createBuildScript(**DeployModuleAction.java:150) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction.access$1(**DeployModuleAction.java:131) at com.google.gdt.eclipse.**designer.actions.deploy.** DeployModuleAction$1.run(**DeployModuleAction.java:103) ... 1 more I completely uninstalled the Google Plugin and reinstalled it. I still get this error. My last chance is probably to reinstall Eclipse from scratch, but I would like to avoid reinstalling and configuring all my dev envirronnement. Can somebody help me please. Am I the only one who got this problem since I tried to update the Google Plugin? -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/e3DoVrI6V70/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT project with maven
Take a look here for source code for the basic HelloWorld example: https://github.com/steinsag/gwt-maven-example I used that as an example to follow while building my application. On Thursday, May 23, 2013 7:32:35 AM UTC+8, Srinivasa Rao wrote: Hi , I am looking for the GWT project with the maven setup. Can you please provide me the link for the sample project ? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 2: Brian: The main reason I put up this patch is that currently IE9 is leaking memory quite badly for each RPC call you make. The root cause is that eval() on IE9 is designed to keep everything evaled in memory until the browsers session dies. See https://code.google.com/p/google-web-toolkit/issues/detail?id=57366 for more details and discussion. Thanks by the way for the great google doc, hadn't seen it before Thomas posted it here. Maybe put it up on the new gwt site in some form? Thomas, Colin: Many times it takes an equal amount of effort to create some imaginative hack for IE6/7 than to actually create a new feature and support all the other browsers. Would gladly see IE6/7 support dropped as soon as possible. IE8 is still a headache in some cases but not as much as those two. Will look into the .concat workaround next, and see if can figure something out. -- To view, visit https://gwt-review.googlesource.com/2900 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6062180397f5fabed1dd5f08140c2bd43a19fa9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Colin Alworth niloc...@gmail.com Gerrit-Reviewer: John Ahlroos j...@vaadin.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Thomas Broyer has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 3:
(1 comment)
Note that SuggestBox's event forwarding was deprecated in favor of exposing
the internal TextBox, so you should do
suggestBox.getTextBox().addFocusHandler(handler) instead of
suggestBox.addFocusHandler(handler). It breaks encapsulation but I believe
there are cases where it's impractical and causes more harm than good.
PanelComposite is a good example too: panels shouldn't be composites as it
breaks the add(child) vs. getParent() symmetry, and fixing it would require
too much work.
In the end, I tend to think that composites shouldn't expose low-level
events from their wrapped widgets, and shouldn't be containers.
For events, either you only use high-level events such as SelectionEvent
for SuggestBox, ValueChangeEvent for ValueListBox or ValuePicker, or
OpenEvent and CloseEvent for DisclosurePanel.
For panels, you'd rather extend Panel, or not make a Composite and instead
simply implement IsWidget and HasWidgets.ForIsWidget.
Note that we have precedents of composites that are panel and violate the
principle of least surprise for getParent(): DisclosurePanel, TabBar and
TabPanel are such widgets. Our existing widgets that delegate events
however are either broken or have deprecated/removed the delegation.
Conclusion: it's a real mess, do whatever you think is best, but I'd rather
go with only genericized Composite and ResizeComposite, possibly
introducing the 'delegate' concept, and without FocusComposite and
PanelComposite.
File user/src/com/google/gwt/user/client/ui/FocusComposite.java
Line 127: return getDelegate().addDoubleClickHandler(handler);
That'd mean making overrideSource public, which I don't think is something
we want to do.
An alternative would be to add some generic helper in
com.google.gwt.event.shared that would internally do the overrideSource and
GwtEvent#dispatch, and then use:
private GwtEventForwardingHelper helper = new
GwtEventForwardingHelper(this);
public HandlerRegistration addDoubleClickHandler(final DoubleClickHandler
handler) {
return getDelegate().addDoubleClickHandler(new DoubleClickHandler() {
@Override
public void onDoubleClick(DoubleClickEvent event) {
helper.dispatch(event, handler);
}
});
}
Actually, it wouldn't even need to be in com.google.gwt.event and reusable:
we could make a local/inner class extending EventBus so it could call
setSourceOfEvent and dispatchEvent:
// extends SimpleEventBus, all we want is accessing 'protected static'
methods from EventBus
private static class GwtEventForwardingHelper extends SimpleEventBus {
public static H void dispatch(Composite? source, GwtEventH event,
H handler) {
Object oldSource = event.getSource();
setSourceOfEvent(event, source);
try {
dispatchEvent(event, handler);
} finally {
setSourceOfEvent(event, oldSource);
}
}
}
// helper method for Composite subclasses
protected H void dispatchEvent(GwtEventH event, H handler) {
GwtEventForwardingHelper.dispatch(this, event, handler);
}
public HandlerRegistration addDoubleClickHandler(final DoubleClickHandler
handler) {
return getDelegate().addDoubleClickHandler(new DoubleClickHandler() {
@Override
public void onDoubleClick(DoubleClickEvent event) {
dispatchEvent(event, handler);
}
});
}
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2500 to look at the new patch set (#5). Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree. Now expects them in GWT_TOOLS. Bug: issue 8031 Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 --- M build.xml D tools/api-checker/reference/README D tools/api-checker/reference/createApiCheckerReferenceJars.sh D tools/api-checker/reference/gwt-dev-modified.jar D tools/api-checker/reference/gwt-user-modified.jar 5 files changed, 3 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Integration Testing Idea
Ok so having put everything together I think I have a plan. I'm thinking that the best approach would be to have a script that runs a cleanDB class before it runs each test (I can just java the test class to run it right?). It's not an ideal solution since this means I will only be able to have 1 test a class but it does allow the DB to be cleaned between tests and the tests to be run order independent. This is what I've been looking for. I'm considering using reflection to manually run all tests in a class and call the clean function in between each. Any thoughts? Thanks On Tuesday, May 21, 2013 11:02:19 AM UTC-4, Jens wrote: That actually sounds promising. This may be a dumb question but can anyone think of a way to slave the WebDriver and JUNIT together? Take a look at: http://nadimsaker.blogspot.de/2011/10/how-to-run-selenium-webdriver-code-with.html Before setting up WebDriver in the setUp() method you should be able add code to install a database fixture for testing. -- J. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Hello Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1350 to look at the new patch set (#2). Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 --- M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java M user/test/com/google/gwt/uibinder/rebind/HandlerEvaluatorTest.java 2 files changed, 4 insertions(+), 3 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Thomas Broyer has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 2: Code-Review+1 Hmm, so, UiBinder only supports event handlers that extend EventHandler, and the error message in this case points to GwtEvent (so we can say UiBinder is tailored for GwtEvent and not the more generic Event), but this change wants to make it legal for an addXxxHandler(SomeGwtEvent) method to return a bindery HandlerRegistration (i.e. mixing c.g.g.event and c.g.web.bindery.event types in the same method). That sounds weird. I wonder if it wouldn't be better to either: * put an error message when we detect c.g.web.bindery.event.shared.HandlerRegistration saying did you mean com.google.gwt.event.shared.HandlerRegistration * or fully support c.g.web.bindery.event: mandate assignable to c.g.w.b.event.shared.Event, don't look for EventHandler (only is interface), and thus accept any HandlerRegistration. -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 5: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 4: Since we already have ResizeComposite, I'm not sure that's a good example of how this change is an improvement? It seems like we should have another example. For custom panels, how well does extending Panel work? Suppose you want a fancy panel that's based on a UIBinder template and can be used in a UIBinder template, with a hole where the children should go and some extra widgets that are encapsulated and aren't exposed as children in the panel API. How hard is that to do? What's the best way to make that easy? -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 4: In the end, I tend to think that composites shouldn't expose low-level events from their wrapped widgets, and shouldn't be containers. For events, either you only use high-level events such as SelectionEvent for SuggestBox, ValueChangeEvent for ValueListBox or ValuePicker, or OpenEvent and CloseEvent for DisclosurePanel. This is mostly true, composite will usually only need to expose logical events but I don't think it is always practical. Why an interface / functionality for ValueListBox should be any different than ListBox? If somebody needs focus events for ListBox and then it means they also need it for ValueListBox, this is true for any composite that does single encapsulation. For panels, you'd rather extend Panel, or not make a Composite and instead simply implement IsWidget and HasWidgets.ForIsWidget. Note that we have precedents of composites that are panel and violate the principle of least surprise for getParent(): DisclosurePanel, TabBar and TabPanel are such widgets. Our existing widgets that delegate events however are either broken or have deprecated/removed the delegation. Yes exactly. We are already broken in many places and there is a huge mess. As our own code is broken that means everybody else's code is also broken. We cannot get rid of the mass by ignoring it - and not taking an action is exactly that. There are parts that are fixable (event source) and also there are other parts that is not much practical to fix with current design (getParent symmetry). Parent symmetry also probably broken for any other widget system that uses composition for reuse. But use case is unavoidable as can be seen from our very own SDK (and based on my previos experience with Swing). If we don't provide the right tools then people are causing even more mess like extending a panel instead of composite and only forward one or two methods and missing the rest (like removals or other 'add' methods). What I'm trying to do here is to provide a way for both our own code and user code to do this in less messy way and I think even in it current state it is already an improvement. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Remove early optimization from Precompile.
Manuel Carrasco Moñino has posted comments on this change. Change subject: Remove early optimization from Precompile. .. Patch Set 2: Code-Review+1 I have tested the patch with a couple of large projects and the time difference is not appreciable: 2:35.148s - 2:29.584s 1:56.687s - 1:54.328s Maybe because I'm compiling 2 permutations for these projects. Time is the entire maven process (package) without tests. The patch does not break anything. -- To view, visit https://gwt-review.googlesource.com/2280 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26bad5f14735a9283021b53edadc5bde1a659c45 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2582 to look at the new patch set (#5). Change subject: Introduces generic Composite widgets. .. Introduces generic Composite widgets. Composite can now be 'safely' extended to add delegation to methods for more specific types. Improves error messaging for incorrect use. Fixes issue 4665, issue 6997. Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Review-Link: https://gwt-review.googlesource.com/#/c/2582/ --- M user/src/com/google/gwt/user/client/ui/Composite.java M user/src/com/google/gwt/user/client/ui/ResizeComposite.java 2 files changed, 83 insertions(+), 32 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds FocusComposite and PanelComposite.
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/2940
Change subject: Adds FocusComposite and PanelComposite.
..
Adds FocusComposite and PanelComposite.
Change-Id: I372f9c4942c11b799eeb57870163dd999ad095cb
---
A user/src/com/google/gwt/user/client/ui/FocusComposite.java
A user/src/com/google/gwt/user/client/ui/PanelComposite.java
2 files changed, 301 insertions(+), 0 deletions(-)
diff --git a/user/src/com/google/gwt/user/client/ui/FocusComposite.java
b/user/src/com/google/gwt/user/client/ui/FocusComposite.java
new file mode 100644
index 000..0173bb0
--- /dev/null
+++ b/user/src/com/google/gwt/user/client/ui/FocusComposite.java
@@ -0,0 +1,229 @@
+/*
+ * Copyright 2013 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.user.client.ui;
+
+import com.google.gwt.event.dom.client.BlurHandler;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.dom.client.DoubleClickHandler;
+import com.google.gwt.event.dom.client.DragEndHandler;
+import com.google.gwt.event.dom.client.DragEnterHandler;
+import com.google.gwt.event.dom.client.DragHandler;
+import com.google.gwt.event.dom.client.DragLeaveHandler;
+import com.google.gwt.event.dom.client.DragOverHandler;
+import com.google.gwt.event.dom.client.DragStartHandler;
+import com.google.gwt.event.dom.client.DropHandler;
+import com.google.gwt.event.dom.client.FocusHandler;
+import com.google.gwt.event.dom.client.GestureChangeHandler;
+import com.google.gwt.event.dom.client.GestureEndHandler;
+import com.google.gwt.event.dom.client.GestureStartHandler;
+import com.google.gwt.event.dom.client.HasAllDragAndDropHandlers;
+import com.google.gwt.event.dom.client.HasAllFocusHandlers;
+import com.google.gwt.event.dom.client.HasAllGestureHandlers;
+import com.google.gwt.event.dom.client.HasAllKeyHandlers;
+import com.google.gwt.event.dom.client.HasAllMouseHandlers;
+import com.google.gwt.event.dom.client.HasAllTouchHandlers;
+import com.google.gwt.event.dom.client.HasClickHandlers;
+import com.google.gwt.event.dom.client.HasDoubleClickHandlers;
+import com.google.gwt.event.dom.client.KeyDownHandler;
+import com.google.gwt.event.dom.client.KeyPressHandler;
+import com.google.gwt.event.dom.client.KeyUpHandler;
+import com.google.gwt.event.dom.client.MouseDownHandler;
+import com.google.gwt.event.dom.client.MouseMoveHandler;
+import com.google.gwt.event.dom.client.MouseOutHandler;
+import com.google.gwt.event.dom.client.MouseOverHandler;
+import com.google.gwt.event.dom.client.MouseUpHandler;
+import com.google.gwt.event.dom.client.MouseWheelHandler;
+import com.google.gwt.event.dom.client.TouchCancelHandler;
+import com.google.gwt.event.dom.client.TouchEndHandler;
+import com.google.gwt.event.dom.client.TouchMoveHandler;
+import com.google.gwt.event.dom.client.TouchStartHandler;
+import com.google.gwt.event.shared.HandlerRegistration;
+
+/**
+ * A {@link Composite} that wraps a {@link Focusable} widget.
+ *
+ * @param T type of the widget wrapped
+ */
+public class FocusCompositeT extends FocusWidget extends CompositeT
+implements Focusable, HasEnabled, HasAllFocusHandlers,
HasAllKeyHandlers, HasClickHandlers,
+HasDoubleClickHandlers, HasAllMouseHandlers,
HasAllDragAndDropHandlers, HasAllGestureHandlers,
+HasAllTouchHandlers {
+
+ @Override
+ public int getTabIndex() {
+return getDelegate().getTabIndex();
+ }
+
+ @Override
+ public void setAccessKey(char key) {
+getDelegate().setAccessKey(key);
+ }
+
+ @Override
+ public void setFocus(boolean focused) {
+getDelegate().setFocus(focused);
+ }
+
+ @Override
+ public void setTabIndex(int index) {
+getDelegate().setTabIndex(index);
+ }
+
+ @Override
+ public HandlerRegistration addFocusHandler(FocusHandler handler) {
+return getDelegate().addFocusHandler(handler);
+ }
+
+ @Override
+ public HandlerRegistration addBlurHandler(BlurHandler handler) {
+return getDelegate().addBlurHandler(handler);
+ }
+
+ @Override
+ public void setEnabled(boolean enabled) {
+getDelegate().setEnabled(enabled);
+ }
+
+ @Override
+ public boolean isEnabled() {
+return getDelegate().isEnabled();
+ }
+
+ @Override
+ public HandlerRegistration addKeyDownHandler(KeyDownHandler handler) {
+return getDelegate().addKeyDownHandler(handler);
+ }
+
+ @Override
+ public
[gwt-contrib] Change in gwt[master]: Adds FocusComposite and PanelComposite.
Goktug Gokdogan has posted comments on this change. Change subject: Adds FocusComposite and PanelComposite. .. Patch Set 1: Bringing the discussion to its own patch. Will looking into alternatives for event source correction. -- To view, visit https://gwt-review.googlesource.com/2940 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I372f9c4942c11b799eeb57870163dd999ad095cb Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Jens Nehlmeier has posted comments on this change.
Change subject: Introduces generic Composite widgets.
..
Patch Set 4:
@Brian: You can use UiBinder to define a custom Panel easily, the only
downside is that you can not use GWT widgets in the UiBinder as the
UiBinder root element must be a DOM Element, so you can call setElement().
Rough example:
div
h1SlidingPanel Headline/h1
!-- FORBIDDEN by UiBinder g:Button ui:field=nextSlidenext/g:Button
--
div ui:field=childContainer/div
div
SlidingPanel extends ComplexPanel {
@UiField DivElement childContainer;
public SlidingPanel() {
setElement(uiBinder.createAndBindUi(this));
}
@Override
pubic void add(Widget w) {
add(w, childContainer.Elementcast()); //protected method of
ComplexPanel
}
}
So if you want to add some interaction controls like buttons you must do it
using the low level Element API. Thats why you probably always choose
Composite in combination with UiBinder because then you can choose
HTMLPanel as UiBinder root which allows you to add DOM elements as well as
widgets.
The delegate concept of this patch pretty much replicates the protected
ComplexPanel.add(Widget w, Element childContainer) method. But the delegate
concept in this patch can break Widget.getParent() because it operates on
widget level while ComplexPanel.add(Widget w, Element childContainer) does
not as it uses a DOM element as target container.
--
To view, visit https://gwt-review.googlesource.com/2582
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: re: We cannot get rid of the mass by ignoring it - and not taking an action is exactly that. Well, not taking action does have the advantage that nobody needs to migrate any code. But I agree with fixing things; I just want to make sure that any change we make works well and isn't a partially-working thing that people need to learn. We should understand it well enough that we can easily explain to other people why they should use it and it won't be it seemed like a good idea at the time but I don't fully understand it. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: (1 comment) File user/src/com/google/gwt/user/client/ui/ResizeComposite.java Line 25: public abstract class ResizeCompositeT extends Widget RequiresResize Looking at this example, the main advantages I see are that (a) you don't need to define a constructor in this class to enforce its constraints, and (b) we're restricting the type on the one-argument version of initWidget(), so subclassing is a bit less error-prone. But this will be an internal detail of the class that gets constructed. But what if the subclass wants a delegate and RequiresResize at the same time? Then we're enforcing a constraint on the delegate, not the widget. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Julien Dramaix has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 2: @Thomas I agree with your option #2 but we should create an issue for that and fix it in another change. The goal of the issue 7079 is to support new HandlerRegistration class What do you think ? -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...
Goktug Gokdogan has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 2: Code-Review+1 It is weird but I don't think it is a big deal as it is technically correct to return the super type of HandlerRegistration from your addXXXHandler method. -- To view, visit https://gwt-review.googlesource.com/1350 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f23b094f55e40d2b2223e9f018c98c4e41a850 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Daniel Kurka danku...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Julien Dramaix julien.dram...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 3: (1 comment) File user/src/com/google/gwt/user/client/ui/FocusComposite.java Line 127: return getDelegate().addDoubleClickHandler(handler); Hmm, I thought they were in the same package. Your suggestion is not keeping track of previous addHandler calls. So it will be causing dublicate events for each addXXX calls. Also we don't need GwtEventForwardingHelper as calling fireEvent will do the trick. Am I missing anything? (Whatever we do, it would be great to encapsulate it as helper for composite to make it straightforward for other subclasses.) -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: Goktug and I talked about this. I'll try to summarize: - How did this get so complicated? UIBinder requires a zero-argument constructor and also requires you to pass this to its methods. So we cannot use constructors for initialization, and that's why we have initWidget() in the first place. - Why not have a separate class that supports delegates? Because that would force PanelComposite and FocusComposite to make a decision on which class to inherit from. We want to defer that decision to the subclass when it calls either the one or two-argument version of initWidget(). - Why not have CompositeW,D? Because in the simple case we only want one type variable for the wrapped widget. It looks a little weird and it's a bit hard to explain, but examples make sense. - Can we make delegation transparent for parent-child relationships, similar to web components? Probably not because lots of things would break. (Maybe we should update the documentation on HasWidgets to say that it adds its argument as a descendant.) - Can we make delegation of event handlers transparent? Probably not a good idea, because it adds complexity and relatively few event handlers check the source. (Maybe update the addFocusHandler/addBlurHandler javadoc to say that the source may be a descendant?) -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Brian Slesinsky has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes most issues with the SoyC reports. Applied an unsubmit...
Brian Slesinsky has posted comments on this change. Change subject: Fixes most issues with the SoyC reports. Applied an unsubmitted patch (http://gwt-code-reviews.appspot.com/1726803/) by Alan and added a few fixes. This is a somewhat ugly fix. A full refactor wll be done when the new Fragment Merging strategy is impl .. Patch Set 3: Code-Review+2 I don't fully understand this code but it seems reasonable. -- To view, visit https://gwt-review.googlesource.com/1610 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I950ebd7b367671446e3d919a00be24d4cbf3fa88 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Jens Nehlmeier has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: So if the delegate feature sounds nice but has the potential to create confusion, why should it be added to GWT? Making getWidget()/initWidget() typed would also solve the issues that this CL references. A developer that wants that delegation feature can still have it by extending an ordinary typed composite and introduce the code that Goktug has introduced to support a delegate. After this discussion I dont really see the point of adding a delegation feature to Composite. I am willing to give a +1 if anyone can convince me that its worth it to have the delegate concept in GWT proper, so it can be used by everyone, although we now know it can cause confusions. Otherwise I will probably vote -1. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Introduces generic Composite widgets.
Goktug Gokdogan has posted comments on this change. Change subject: Introduces generic Composite widgets. .. Patch Set 5: We are really going in circles. The delegate is part of Composite because of the same reason why somebody cannot safely introduce generics by extending this class. There is really nothing complicated about the basic use case and I don't think it will cause confusion. People don't need to know the delegate concept until they need to know about it. -- To view, visit https://gwt-review.googlesource.com/2582 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e5c07e978d442db7d8402c57605cec1b3ea09e Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds FocusComposite and PanelComposite.
Goktug Gokdogan has posted comments on this change.
Change subject: Adds FocusComposite and PanelComposite.
..
Patch Set 1:
I thought little bit more on this.
As we must always call specific addXYZHandler methods expecting specific
handler classes, I think it is impossible to avoid boilerplate without
codegen.
The minimal boilerplate that I found is my previous proposal of updating
the source of the event (we can put a helper in composite for source
override). Anybody who wants to be good citizen can choose to do that.
If we do code generation, we can simplify it a lot and everybody can use it:
interface FocusForwardingHandlers extends HasXHandlers, HasYHandlers,
ForwardingHandler;
FocusForwardingHandlers helper;
protected void initWidget(Widget widget, T delegate) {
super.initWidget(widget, delegate);
helper = GWT.create(FocusForwardingHandlers.class);
helper.init(this, delegate);
};
public HandlerRegistration addFocusHandler(FocusHandler handler) {
return helper.addHandler(handler);
}
but writing the codegen is also a lot of work. I'm not sure if it will
worth for just fixing the source of event.
--
To view, visit https://gwt-review.googlesource.com/2940
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I372f9c4942c11b799eeb57870163dd999ad095cb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
