[jira] [Commented] (TAJO-2166) Disallow csv file format in DDL Languages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380752#comment-15380752
 ] 

ASF GitHub Bot commented on TAJO-2166:
--

Github user dongjinleekr commented on the issue:

https://github.com/apache/tajo/pull/1037
  
I applied all your comments! :)


> Disallow csv file format in DDL Languages
> -
>
> Key: TAJO-2166
> URL: https://issues.apache.org/jira/browse/TAJO-2166
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
>
> csv file type is disallowed from ver 0.11.0. We have to remove it from DDL 
> also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo issue #1037: TAJO-2166: Disallow csv file format in DDL Languages

[dongjinleekr]

Github user dongjinleekr commented on the issue:

https://github.com/apache/tajo/pull/1037
  
I applied all your comments! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380666#comment-15380666
 ] 

Hudson commented on TAJO-2176:
--

SUCCESS: Integrated in Tajo-master-build #1181 (See 
[https://builds.apache.org/job/Tajo-master-build/1181/])
TAJO-2176: Refining function documents. (jypark: rev 
354ff85d2b5d065fd899940a792f0fcb6e99695c)
* tajo-docs/src/main/sphinx/functions/data_type_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst
* tajo-docs/src/main/sphinx/configuration/worker_configuration.rst
* tajo-docs/src/main/sphinx/sql_language/data_model.rst
* tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/agg_func.rst
* tajo-docs/src/main/sphinx/functions/json_func.rst
* tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/window_func.rst
* CHANGES


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
> Fix For: 0.12.0
>
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TAJO-2176) Refining function documents

[Jongyoung Park (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jongyoung Park resolved TAJO-2176.
--
   Resolution: Fixed
Fix Version/s: 0.12.0

> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
> Fix For: 0.12.0
>
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380655#comment-15380655
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user eminency closed the pull request at:

https://github.com/apache/tajo/pull/1038


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[eminency]

Github user eminency closed the pull request at:

https://github.com/apache/tajo/pull/1038


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380654#comment-15380654
 ] 

Hudson commented on TAJO-2176:
--

FAILURE: Integrated in Tajo-master-CODEGEN-build #750 (See 
[https://builds.apache.org/job/Tajo-master-CODEGEN-build/750/])
TAJO-2176: Refining function documents. (jypark: rev 
354ff85d2b5d065fd899940a792f0fcb6e99695c)
* tajo-docs/src/main/sphinx/sql_language/data_model.rst
* tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/window_func.rst
* tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/data_type_func_and_operators.rst
* tajo-docs/src/main/sphinx/configuration/worker_configuration.rst
* tajo-docs/src/main/sphinx/functions/json_func.rst
* tajo-docs/src/main/sphinx/functions/network_func_and_operators.rst
* CHANGES
* tajo-docs/src/main/sphinx/functions/datetime_func_and_operators.rst
* tajo-docs/src/main/sphinx/functions/agg_func.rst


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: Tajo-master-CODEGEN-build #750

[Apache Jenkins Server]

See 

Changes:

[jypark] TAJO-2176: Refining function documents.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H7 (Mapreduce Falcon Hadoop Pig Zookeeper Tez Hdfs 
yahoo-not-h2) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url http://git-wip-us.apache.org/repos/asf/tajo.git 
 > # timeout=10
Fetching upstream changes from http://git-wip-us.apache.org/repos/asf/tajo.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > http://git-wip-us.apache.org/repos/asf/tajo.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision 354ff85d2b5d065fd899940a792f0fcb6e99695c (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 354ff85d2b5d065fd899940a792f0fcb6e99695c
 > git rev-list ea777aabee64552b08178204709b033c54a4e4a5 # timeout=10
[Tajo-master-CODEGEN-build] $ /bin/bash -x /tmp/hudson3786871573781794941.sh
+ export JAVA_HOME=/home/jenkins/tools/java/latest
+ JAVA_HOME=/home/jenkins/tools/java/latest
+ export MAVEN_HOME=/home/jenkins/tools/maven/latest
+ MAVEN_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
+ 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
+ which java
/home/jenkins/tools/java/latest/bin/java
+ protoc --version
libprotoc 2.5.0
+ mvn --version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 
2014-02-14T17:37:52+00:00)
Maven home: /home/jenkins/tools/maven/latest
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /home/jenkins/tools/java/jdk1.6.0_45-64/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "3.13.0-36-lowlatency", arch: "amd64", family: "unix"
+ cd 
+ /home/jenkins/tools/maven/latest/bin/mvn clean install -DCODEGEN=true
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] Tajo Main
[INFO] Tajo Project POM
[INFO] Tajo Maven Plugins
[INFO] Tajo Common
[INFO] Tajo Algebra
[INFO] Tajo Catalog Common
[INFO] Tajo Plan
[INFO] Tajo Rpc Common
[INFO] Tajo Protocol Buffer Rpc
[INFO] Tajo Catalog Client
[INFO] Tajo Catalog Server
[INFO] Tajo Storage Common
[INFO] Tajo HDFS Storage
[INFO] Tajo PullServer
[INFO] Tajo Client
[INFO] Tajo SQL Parser
[INFO] Tajo CLI tools
[INFO] ASM (thirdparty)
[INFO] Tajo RESTful Container
[INFO] Tajo Metrics
[INFO] Tajo Core
[INFO] Tajo RPC
[INFO] Tajo Catalog Drivers Hive
[INFO] Tajo Catalog Drivers
[INFO] Tajo Catalog
[INFO] Tajo Client Example
[INFO] Tajo HBase Storage
[INFO] Tajo Cluster Tests
[INFO] Tajo JDBC Driver
[INFO] Tajo JDBC storage common
[INFO] Tajo PostgreSQL JDBC storage
[INFO] Tajo S3 storage
[INFO] Tajo Storage
[INFO] Tajo Yarn
[INFO] Tajo Core Tests
[INFO] Tajo Tablespace Example
[INFO] Tajo Distribution
[INFO] 
[INFO] Using the builder 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
 with a thread count of 1
[INFO] 
[INFO] 
[INFO] Building Tajo Main 0.12.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4:enforce (clean) @ tajo-main ---
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed 
with message:
Detected JDK Version: 1.6.0-45 is not in the allowed range 1.8.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Tajo Main . FAILURE [  0.622 s]
[INFO] Tajo Project POM .. SKIPPED
[INFO] Tajo Maven Plugins  SKIPPED
[INFO] Tajo Common ... SKIPPED
[INFO] Tajo Algebra .. SKIPPED
[INFO] Tajo Catalog Common ... SKIPPED
[INFO] Tajo Plan . SKIPPED
[INFO] Tajo Rpc Common ... SKIPPED
[INFO] Tajo Protocol Buffer Rpc .. SKIPPED
[INFO] Tajo Catalog Client ... SKIPPED
[INFO] 

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380635#comment-15380635
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user eminency commented on the issue:

https://github.com/apache/tajo/pull/1038
  
Thanks, I'll ship it and close the PR.


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo issue #1038: TAJO-2176: Refining function documents

[eminency]

Github user eminency commented on the issue:

https://github.com/apache/tajo/pull/1038
  
Thanks, I'll ship it and close the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380634#comment-15380634
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on the issue:

https://github.com/apache/tajo/pull/1038
  
+1. Thank you for the quick update! 


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo issue #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on the issue:

https://github.com/apache/tajo/pull/1038
  
+1. Thank you for the quick update! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380606#comment-15380606
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user eminency commented on the issue:

https://github.com/apache/tajo/pull/1038
  
@jihoonson Thanks for good catches! I fixed them, please check.


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo issue #1038: TAJO-2176: Refining function documents

[eminency]

Github user eminency commented on the issue:

https://github.com/apache/tajo/pull/1038
  
@jihoonson Thanks for good catches! I fixed them, please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380554#comment-15380554
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061870
  
--- Diff: tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst 
---
@@ -347,82 +347,82 @@ String Functions and Operators
 > TAJO
 
 
-.. function:: lower(string text)
+.. function:: lower(string TEXT)
 
   Makes an input text to be lower case.
 
   :param string: input string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lower('TAJO');
 > tajo
 
-.. function:: lpad(source text, number int4, pad text)
+.. function:: lpad(source TEXT, number INT4, pad TEXT)
 
   Fill up the string to length by prepending the characters fill (a space 
by default). If the string is already longer than length then it is truncated 
(on the right).
 
   :param source: source string
   :param number: padding length
   :param pad: padding string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lpad('hi', 5, 'xy');
 > xyxhi
 
-.. function:: rpad(source text, number int4, pad text)
+.. function:: rpad(source TEXT, number INT4, pad TEXT)
--- End diff --

pad can be omitted.


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380553#comment-15380553
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061868
  
--- Diff: tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst 
---
@@ -347,82 +347,82 @@ String Functions and Operators
 > TAJO
 
 
-.. function:: lower(string text)
+.. function:: lower(string TEXT)
 
   Makes an input text to be lower case.
 
   :param string: input string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lower('TAJO');
 > tajo
 
-.. function:: lpad(source text, number int4, pad text)
+.. function:: lpad(source TEXT, number INT4, pad TEXT)
--- End diff --

pad can be omitted.


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061868
  
--- Diff: tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst 
---
@@ -347,82 +347,82 @@ String Functions and Operators
 > TAJO
 
 
-.. function:: lower(string text)
+.. function:: lower(string TEXT)
 
   Makes an input text to be lower case.
 
   :param string: input string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lower('TAJO');
 > tajo
 
-.. function:: lpad(source text, number int4, pad text)
+.. function:: lpad(source TEXT, number INT4, pad TEXT)
--- End diff --

pad can be omitted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061870
  
--- Diff: tajo-docs/src/main/sphinx/functions/string_func_and_operators.rst 
---
@@ -347,82 +347,82 @@ String Functions and Operators
 > TAJO
 
 
-.. function:: lower(string text)
+.. function:: lower(string TEXT)
 
   Makes an input text to be lower case.
 
   :param string: input string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lower('TAJO');
 > tajo
 
-.. function:: lpad(source text, number int4, pad text)
+.. function:: lpad(source TEXT, number INT4, pad TEXT)
 
   Fill up the string to length by prepending the characters fill (a space 
by default). If the string is already longer than length then it is truncated 
(on the right).
 
   :param source: source string
   :param number: padding length
   :param pad: padding string
-  :rtype: text
+  :rtype: TEXT
   :example:
 
   .. code-block:: sql
 
 select lpad('hi', 5, 'xy');
 > xyxhi
 
-.. function:: rpad(source text, number int4, pad text)
+.. function:: rpad(source TEXT, number INT4, pad TEXT)
--- End diff --

pad can be omitted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380551#comment-15380551
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061852
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -179,115 +179,120 @@ Math Functions and Operators
 
   Returns constant value of pi
 
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pi();
 > 3.141592653589793
 
-.. function:: pow (x float, y float)
+.. function:: pow (x FLOAT*, y FLOAT*)
 
   Returns value of x raised to the power of y
 
   :param x: base number
   :param y: exponent
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pow(2.0, 10.0);
 > 1024.0
 
-.. function:: radians (number float)
+.. function:: radians (number FLOAT*)
 
   Converts degrees to radians
 
   :param number: degree value
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select radians(45.0);
 > 0.7853981633974483
 
-.. function:: random(number int4)
+.. function:: random(number INT4)
 
   Returns a pseudorandom number.
 
   :param number: range restriction
-  :rtype: int4
+  :rtype: INT4
   :example:
 
   .. code-block:: sql
 
 select random(10);
 > 4
 
-.. function:: round (number int|float)
+.. function:: round (number INT*|FLOAT*)
 
   Rounds to nearest integer
 
   :param number: target number
-  :rtype: int8
+  :rtype: INT8
   :example:
 
   .. code-block:: sql
 
 select round(5.1); 
 > 5
 
-.. function:: sign (number int|float)
+.. function:: sign (number INT*|FLOAT*)
 
   Returns sign of argument as -1, 0, 1
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sign(-8.4); 
 > -1.0
 
-.. function:: sin (number float)
+.. function:: SIN (number FLOAT*)
 
   Returns the sine of number value
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sin(1.0); 
 > 0.8414709848078965
 
-.. function:: sqrt (number float8)
+.. function:: sqrt (number FLOAT8)
--- End diff --

need to be FLOAT*


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061852
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -179,115 +179,120 @@ Math Functions and Operators
 
   Returns constant value of pi
 
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pi();
 > 3.141592653589793
 
-.. function:: pow (x float, y float)
+.. function:: pow (x FLOAT*, y FLOAT*)
 
   Returns value of x raised to the power of y
 
   :param x: base number
   :param y: exponent
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pow(2.0, 10.0);
 > 1024.0
 
-.. function:: radians (number float)
+.. function:: radians (number FLOAT*)
 
   Converts degrees to radians
 
   :param number: degree value
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select radians(45.0);
 > 0.7853981633974483
 
-.. function:: random(number int4)
+.. function:: random(number INT4)
 
   Returns a pseudorandom number.
 
   :param number: range restriction
-  :rtype: int4
+  :rtype: INT4
   :example:
 
   .. code-block:: sql
 
 select random(10);
 > 4
 
-.. function:: round (number int|float)
+.. function:: round (number INT*|FLOAT*)
 
   Rounds to nearest integer
 
   :param number: target number
-  :rtype: int8
+  :rtype: INT8
   :example:
 
   .. code-block:: sql
 
 select round(5.1); 
 > 5
 
-.. function:: sign (number int|float)
+.. function:: sign (number INT*|FLOAT*)
 
   Returns sign of argument as -1, 0, 1
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sign(-8.4); 
 > -1.0
 
-.. function:: sin (number float)
+.. function:: SIN (number FLOAT*)
 
   Returns the sine of number value
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sin(1.0); 
 > 0.8414709848078965
 
-.. function:: sqrt (number float8)
+.. function:: sqrt (number FLOAT8)
--- End diff --

need to be FLOAT*


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380550#comment-15380550
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061850
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -179,115 +179,120 @@ Math Functions and Operators
 
   Returns constant value of pi
 
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pi();
 > 3.141592653589793
 
-.. function:: pow (x float, y float)
+.. function:: pow (x FLOAT*, y FLOAT*)
 
   Returns value of x raised to the power of y
 
   :param x: base number
   :param y: exponent
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pow(2.0, 10.0);
 > 1024.0
 
-.. function:: radians (number float)
+.. function:: radians (number FLOAT*)
 
   Converts degrees to radians
 
   :param number: degree value
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select radians(45.0);
 > 0.7853981633974483
 
-.. function:: random(number int4)
+.. function:: random(number INT4)
 
   Returns a pseudorandom number.
 
   :param number: range restriction
-  :rtype: int4
+  :rtype: INT4
   :example:
 
   .. code-block:: sql
 
 select random(10);
 > 4
 
-.. function:: round (number int|float)
+.. function:: round (number INT*|FLOAT*)
 
   Rounds to nearest integer
 
   :param number: target number
-  :rtype: int8
+  :rtype: INT8
   :example:
 
   .. code-block:: sql
 
 select round(5.1); 
 > 5
 
-.. function:: sign (number int|float)
+.. function:: sign (number INT*|FLOAT*)
 
   Returns sign of argument as -1, 0, 1
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sign(-8.4); 
 > -1.0
 
-.. function:: sin (number float)
+.. function:: SIN (number FLOAT*)
--- End diff --

The function name seems to be lowercase.


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061850
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -179,115 +179,120 @@ Math Functions and Operators
 
   Returns constant value of pi
 
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pi();
 > 3.141592653589793
 
-.. function:: pow (x float, y float)
+.. function:: pow (x FLOAT*, y FLOAT*)
 
   Returns value of x raised to the power of y
 
   :param x: base number
   :param y: exponent
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select pow(2.0, 10.0);
 > 1024.0
 
-.. function:: radians (number float)
+.. function:: radians (number FLOAT*)
 
   Converts degrees to radians
 
   :param number: degree value
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select radians(45.0);
 > 0.7853981633974483
 
-.. function:: random(number int4)
+.. function:: random(number INT4)
 
   Returns a pseudorandom number.
 
   :param number: range restriction
-  :rtype: int4
+  :rtype: INT4
   :example:
 
   .. code-block:: sql
 
 select random(10);
 > 4
 
-.. function:: round (number int|float)
+.. function:: round (number INT*|FLOAT*)
 
   Rounds to nearest integer
 
   :param number: target number
-  :rtype: int8
+  :rtype: INT8
   :example:
 
   .. code-block:: sql
 
 select round(5.1); 
 > 5
 
-.. function:: sign (number int|float)
+.. function:: sign (number INT*|FLOAT*)
 
   Returns sign of argument as -1, 0, 1
 
   :param number: target number
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select sign(-8.4); 
 > -1.0
 
-.. function:: sin (number float)
+.. function:: SIN (number FLOAT*)
--- End diff --

The function name seems to be lowercase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380548#comment-15380548
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061840
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -15,78 +15,78 @@ Math Functions and Operators
 select abs(-9); 
 > 9
 
-.. function:: acos (number float)
+.. function:: acos (number FLOAT*)
 
   Returns the arc cosine of number value
 
   :param number: input number as radian
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select acos(0.3); 
 > 1.2661036727794992 
 
-.. function:: asin (number float)
+.. function:: asin (number FLOAT*)
 
   Returns the arc sine of number value
 
   :param number: input number as radian
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select acos(0.8); 
 > 0.9272952180016123
 
-.. function:: atan (number float8)
+.. function:: atan (number FLOAT8)
--- End diff --

need to be FLOAT*


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061840
  
--- Diff: tajo-docs/src/main/sphinx/functions/math_func_and_operators.rst 
---
@@ -15,78 +15,78 @@ Math Functions and Operators
 select abs(-9); 
 > 9
 
-.. function:: acos (number float)
+.. function:: acos (number FLOAT*)
 
   Returns the arc cosine of number value
 
   :param number: input number as radian
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select acos(0.3); 
 > 1.2661036727794992 
 
-.. function:: asin (number float)
+.. function:: asin (number FLOAT*)
 
   Returns the arc sine of number value
 
   :param number: input number as radian
-  :rtype: float8
+  :rtype: FLOAT8
   :example:
 
   .. code-block:: sql
 
 select acos(0.8); 
 > 0.9272952180016123
 
-.. function:: atan (number float8)
+.. function:: atan (number FLOAT8)
--- End diff --

need to be FLOAT*


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2176) Refining function documents

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380545#comment-15380545
 ] 

ASF GitHub Bot commented on TAJO-2176:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061808
  
--- Diff: tajo-docs/src/main/sphinx/functions/agg_func.rst ---
@@ -1,91 +1,97 @@
-
+*
 Aggregation Functions
-
+*
+
 
 .. function:: avg (expression)
 
   Returns the average of all input values.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: corr (expression1, expression2)
 
   Returns the coefficient of correlation between a set of number pairs.
 
   :param expression1:
   :param expression2:
-  :type expression1: int | float
-  :type expression2: int | float
-  :rtype: float8
+  :type expression1: INT* | FLOAT*
+  :type expression2: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: count()
 
   Returns the number of input rows.
 
-  :rtype: int8
+  :rtype: INT8
 
 .. function:: last_value(expression)
 
   Returns the last value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: max(expression)
 
   Returns the maximum value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: min(expression)
 
   Returns the minimum value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: stddev_pop(expression)
 
   Returns the population standard deviation of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: stddev_samp(expression)
 
   Returns the sample standard deviation of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: sum(expression)
 
   Returns the sum of a set of numbers.
 
   :param expression:
-  :type expression: int | float
+  :type expression: INT* | FLOAT*
   :rtype: same as parameter data type
 
 .. function:: var_pop(expression)
 
   Returns the variance of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: var_samp(expression)
 
   Returns the unbiased sample variance of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
\ No newline at end of file
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
+
+
+.. note:: ``INT*`` means various size of integer types can be accepted. 
And ``FLOAT*`` means both of ``FLOAT4`` and ``FLOAT8`` are OK.
+  For your information, in Tajo SQL, ``INT`` is alias for ``INT4`` and 
``FLOAT`` is one for ``FLOAT4``.
--- End diff --

```Tajo SQL``` looks that Tajo has own SQL syntax to me. How about just 
```in Tajo```?


> Refining function documents
> ---
>
> Key: TAJO-2176
> URL: https://issues.apache.org/jira/browse/TAJO-2176
> Project: Tajo
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 0.11.3
>Reporter: Jongyoung Park
>Assignee: Jongyoung Park
>
> This is about task for refining function document.
> In detail, followings are included:
> 1. Type names in function signature should be capitalized to increase 
> readability.
> 2. The type names should be unified. Currently, some aliases are used at 
> once, for example, INT8 and LONG.
> 3. Some parts need correction or clarifying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1038: TAJO-2176: Refining function documents

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1038#discussion_r71061808
  
--- Diff: tajo-docs/src/main/sphinx/functions/agg_func.rst ---
@@ -1,91 +1,97 @@
-
+*
 Aggregation Functions
-
+*
+
 
 .. function:: avg (expression)
 
   Returns the average of all input values.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: corr (expression1, expression2)
 
   Returns the coefficient of correlation between a set of number pairs.
 
   :param expression1:
   :param expression2:
-  :type expression1: int | float
-  :type expression2: int | float
-  :rtype: float8
+  :type expression1: INT* | FLOAT*
+  :type expression2: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: count()
 
   Returns the number of input rows.
 
-  :rtype: int8
+  :rtype: INT8
 
 .. function:: last_value(expression)
 
   Returns the last value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: max(expression)
 
   Returns the maximum value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: min(expression)
 
   Returns the minimum value of expression.
 
   :param expression:
-  :type expression: int | float | date | time | timestamp | text
+  :type expression: INT* | FLOAT* | DATE | TIME | TIMESTAMP | TEXT
   :rtype: same as parameter data type
 
 .. function:: stddev_pop(expression)
 
   Returns the population standard deviation of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: stddev_samp(expression)
 
   Returns the sample standard deviation of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: sum(expression)
 
   Returns the sum of a set of numbers.
 
   :param expression:
-  :type expression: int | float
+  :type expression: INT* | FLOAT*
   :rtype: same as parameter data type
 
 .. function:: var_pop(expression)
 
   Returns the variance of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
 
 .. function:: var_samp(expression)
 
   Returns the unbiased sample variance of a set of numbers.
 
   :param expression:
-  :type expression: int | float
-  :rtype: float8
\ No newline at end of file
+  :type expression: INT* | FLOAT*
+  :rtype: FLOAT8
+
+
+.. note:: ``INT*`` means various size of integer types can be accepted. 
And ``FLOAT*`` means both of ``FLOAT4`` and ``FLOAT8`` are OK.
+  For your information, in Tajo SQL, ``INT`` is alias for ``INT4`` and 
``FLOAT`` is one for ``FLOAT4``.
--- End diff --

```Tajo SQL``` looks that Tajo has own SQL syntax to me. How about just 
```in Tajo```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2175) Fix some glitches in source code

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380544#comment-15380544
 ] 

Hudson commented on TAJO-2175:
--

FAILURE: Integrated in Tajo-master-CODEGEN-build #749 (See 
[https://builds.apache.org/job/Tajo-master-CODEGEN-build/749/])
TAJO-2175: Fix some glitches in source code. (jihoonson: rev 
ea777aabee64552b08178204709b033c54a4e4a5)
* 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
* tajo-plan/src/main/java/org/apache/tajo/plan/logical/AlterTableNode.java
* CHANGES
* tajo-core/src/main/java/org/apache/tajo/master/exec/DDLExecutor.java


> Fix some glitches in source code
> 
>
> Key: TAJO-2175
> URL: https://issues.apache.org/jira/browse/TAJO-2175
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
> Fix For: 0.12.0
>
>
> - AlterTableNode#clone has been commented out. It would be better to be 
> removed.
> - Remove unnecessary parameters from CatalogUtil#renameColumn, renameTable, 
> addNewColumn and setProperty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAJO-2175) Fix some glitches in source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380542#comment-15380542
 ] 

ASF GitHub Bot commented on TAJO-2175:
--

Github user asfgit closed the pull request at:

https://github.com/apache/tajo/pull/1039


> Fix some glitches in source code
> 
>
> Key: TAJO-2175
> URL: https://issues.apache.org/jira/browse/TAJO-2175
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
> Fix For: 0.12.0
>
>
> - AlterTableNode#clone has been commented out. It would be better to be 
> removed.
> - Remove unnecessary parameters from CatalogUtil#renameColumn, renameTable, 
> addNewColumn and setProperty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: Tajo-master-CODEGEN-build #749

[Apache Jenkins Server]

See 

Changes:

[jihoonson] TAJO-2175: Fix some glitches in source code.

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H7 (Mapreduce Falcon Hadoop Pig Zookeeper Tez Hdfs 
yahoo-not-h2) in workspace 

 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url http://git-wip-us.apache.org/repos/asf/tajo.git 
 > # timeout=10
Fetching upstream changes from http://git-wip-us.apache.org/repos/asf/tajo.git
 > git --version # timeout=10
 > git -c core.askpass=true fetch --tags --progress 
 > http://git-wip-us.apache.org/repos/asf/tajo.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/master^{commit} # timeout=10
Checking out Revision ea777aabee64552b08178204709b033c54a4e4a5 (origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f ea777aabee64552b08178204709b033c54a4e4a5
 > git rev-list fab36f97eff330ec2f655536bb00d2ca2cc557e9 # timeout=10
[Tajo-master-CODEGEN-build] $ /bin/bash -x /tmp/hudson9162460955302404442.sh
+ export JAVA_HOME=/home/jenkins/tools/java/latest
+ JAVA_HOME=/home/jenkins/tools/java/latest
+ export MAVEN_HOME=/home/jenkins/tools/maven/latest
+ MAVEN_HOME=/home/jenkins/tools/maven/latest
+ export 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
+ 
PATH=/home/jenkins/tools/java/latest/bin:/home/jenkins/tools/maven/latest/bin:/home/jenkins/tools/java/latest1.6/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
+ which java
/home/jenkins/tools/java/latest/bin/java
+ protoc --version
libprotoc 2.5.0
+ mvn --version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 
2014-02-14T17:37:52+00:00)
Maven home: /home/jenkins/tools/maven/latest
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /home/jenkins/tools/java/jdk1.6.0_45-64/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "3.13.0-36-lowlatency", arch: "amd64", family: "unix"
+ cd 
+ /home/jenkins/tools/maven/latest/bin/mvn clean install -DCODEGEN=true
[INFO] Scanning for projects...
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] Tajo Main
[INFO] Tajo Project POM
[INFO] Tajo Maven Plugins
[INFO] Tajo Common
[INFO] Tajo Algebra
[INFO] Tajo Catalog Common
[INFO] Tajo Plan
[INFO] Tajo Rpc Common
[INFO] Tajo Protocol Buffer Rpc
[INFO] Tajo Catalog Client
[INFO] Tajo Catalog Server
[INFO] Tajo Storage Common
[INFO] Tajo HDFS Storage
[INFO] Tajo PullServer
[INFO] Tajo Client
[INFO] Tajo SQL Parser
[INFO] Tajo CLI tools
[INFO] ASM (thirdparty)
[INFO] Tajo RESTful Container
[INFO] Tajo Metrics
[INFO] Tajo Core
[INFO] Tajo RPC
[INFO] Tajo Catalog Drivers Hive
[INFO] Tajo Catalog Drivers
[INFO] Tajo Catalog
[INFO] Tajo Client Example
[INFO] Tajo HBase Storage
[INFO] Tajo Cluster Tests
[INFO] Tajo JDBC Driver
[INFO] Tajo JDBC storage common
[INFO] Tajo PostgreSQL JDBC storage
[INFO] Tajo S3 storage
[INFO] Tajo Storage
[INFO] Tajo Yarn
[INFO] Tajo Core Tests
[INFO] Tajo Tablespace Example
[INFO] Tajo Distribution
[INFO] 
[INFO] Using the builder 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder
 with a thread count of 1
[INFO] 
[INFO] 
[INFO] Building Tajo Main 0.12.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4:enforce (clean) @ tajo-main ---
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed 
with message:
Detected JDK Version: 1.6.0-45 is not in the allowed range 1.8.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Tajo Main . FAILURE [  0.624 s]
[INFO] Tajo Project POM .. SKIPPED
[INFO] Tajo Maven Plugins  SKIPPED
[INFO] Tajo Common ... SKIPPED
[INFO] Tajo Algebra .. SKIPPED
[INFO] Tajo Catalog Common ... SKIPPED
[INFO] Tajo Plan . SKIPPED
[INFO] Tajo Rpc Common ... SKIPPED
[INFO] Tajo Protocol Buffer Rpc .. SKIPPED
[INFO] Tajo Catalog Client ... SKIPPED

[GitHub] tajo pull request #1039: TAJO-2175: Fix some glitches in source code

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tajo/pull/1039


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2175) Fix some glitches in source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380535#comment-15380535
 ] 

ASF GitHub Bot commented on TAJO-2175:
--

Github user jihoonson commented on the issue:

https://github.com/apache/tajo/pull/1039
  
+1. This change is straightforward improvement. I'll commit shortly.
Thanks.


> Fix some glitches in source code
> 
>
> Key: TAJO-2175
> URL: https://issues.apache.org/jira/browse/TAJO-2175
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
>
> - AlterTableNode#clone has been commented out. It would be better to be 
> removed.
> - Remove unnecessary parameters from CatalogUtil#renameColumn, renameTable, 
> addNewColumn and setProperty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TAJO-2166) Disallow csv file format in DDL Languages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380532#comment-15380532
 ] 

ASF GitHub Bot commented on TAJO-2166:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1037#discussion_r71061686
  
--- Diff: 
tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java ---
@@ -1325,6 +1325,9 @@ public Expr 
visitCreate_table_statement(Create_table_statementContext ctx) {
 
   if (checkIfExist(ctx.USING())) {
 String fileType = ctx.storage_type.getText();
+if (fileType.equals("csv")) {
+  throw new TajoRuntimeException(new SQLSyntaxError("Creating csv 
storage type table is disallowed from 0.12."));
--- End diff --

It would be better to let users know that they use ```text``` instead of 
```csv```. In addition, I think it would be better if a specific version name 
is not included in the error message for maintenance issue.


> Disallow csv file format in DDL Languages
> -
>
> Key: TAJO-2166
> URL: https://issues.apache.org/jira/browse/TAJO-2166
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
>
> csv file type is disallowed from ver 0.11.0. We have to remove it from DDL 
> also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1037: TAJO-2166: Disallow csv file format in DDL Language...

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1037#discussion_r71061686
  
--- Diff: 
tajo-core/src/main/java/org/apache/tajo/parser/sql/SQLAnalyzer.java ---
@@ -1325,6 +1325,9 @@ public Expr 
visitCreate_table_statement(Create_table_statementContext ctx) {
 
   if (checkIfExist(ctx.USING())) {
 String fileType = ctx.storage_type.getText();
+if (fileType.equals("csv")) {
+  throw new TajoRuntimeException(new SQLSyntaxError("Creating csv 
storage type table is disallowed from 0.12."));
--- End diff --

It would be better to let users know that they use ```text``` instead of 
```csv```. In addition, I think it would be better if a specific version name 
is not included in the error message for maintenance issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TAJO-2166) Disallow csv file format in DDL Languages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TAJO-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380529#comment-15380529
 ] 

ASF GitHub Bot commented on TAJO-2166:
--

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1037#discussion_r71061666
  
--- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java 
---
@@ -97,6 +98,17 @@ public final void testCreateTable2() throws Exception {
 assertDatabaseNotExists("d2");
   }
 
+  @Test
+  public final void testCreateTableWithCsv() throws Exception {
+try {
+  executeString("CREATE TABLE D1.table1 (age int) using csv;").close();
+  fail("It should not reach here.");
+} catch (Throwable e) {
+  assertEquals(e.getClass(), SQLSyntaxError.class);
--- End diff --

How about using JUnit's Expected Exception? You can simply check the 
expected exception like in 
https://github.com/apache/tajo/blob/master/tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogExceptions.java#L65,
 
or do more things like described here 
https://github.com/junit-team/junit4/wiki/Exception-testing.


> Disallow csv file format in DDL Languages
> -
>
> Key: TAJO-2166
> URL: https://issues.apache.org/jira/browse/TAJO-2166
> Project: Tajo
>  Issue Type: Improvement
>Reporter: Lee Dongjin
>Assignee: Lee Dongjin
>Priority: Minor
>
> csv file type is disallowed from ver 0.11.0. We have to remove it from DDL 
> also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] tajo pull request #1037: TAJO-2166: Disallow csv file format in DDL Language...

[jihoonson]

Github user jihoonson commented on a diff in the pull request:

https://github.com/apache/tajo/pull/1037#discussion_r71061666
  
--- Diff: 
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java 
---
@@ -97,6 +98,17 @@ public final void testCreateTable2() throws Exception {
 assertDatabaseNotExists("d2");
   }
 
+  @Test
+  public final void testCreateTableWithCsv() throws Exception {
+try {
+  executeString("CREATE TABLE D1.table1 (age int) using csv;").close();
+  fail("It should not reach here.");
+} catch (Throwable e) {
+  assertEquals(e.getClass(), SQLSyntaxError.class);
--- End diff --

How about using JUnit's Expected Exception? You can simply check the 
expected exception like in 
https://github.com/apache/tajo/blob/master/tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalogExceptions.java#L65,
 
or do more things like described here 
https://github.com/junit-team/junit4/wiki/Exception-testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---