Jenkins build is back to normal : debian_8-master » gcc,debian_8,release #1156

[jenkins]

See 

Build failed in Jenkins: debian_8-master » gcc,debian_8,release #1155

[jenkins]

See 


--
[...truncated 19540 lines...]
*** TEST 62 *** STARTING ***
*** TEST 62 *** PASSED ***
*** TEST 63 *** STARTING ***
*** TEST 63 *** PASSED ***
*** TEST 64 *** STARTING ***
*** TEST 64 *** PASSED ***
*** TEST 65 *** STARTING ***
*** TEST 65 *** PASSED ***
*** TEST 66 *** STARTING ***
*** TEST 66 *** PASSED ***
*** TEST 67 *** STARTING ***
*** TEST 67 *** PASSED ***
*** TEST 68 *** STARTING ***
*** TEST 68 *** PASSED ***
*** TEST 69 *** STARTING ***
*** TEST 69 *** PASSED ***
*** TEST 70 *** STARTING ***
*** TEST 70 *** PASSED ***
*** TEST 71 *** STARTING ***
*** TEST 71 *** PASSED ***
*** TEST 72 *** STARTING ***
*** TEST 72 *** PASSED ***
*** TEST 73 *** STARTING ***
*** TEST 73 *** PASSED ***
*** TEST 74 *** STARTING ***
*** TEST 74 *** PASSED ***
*** TEST 75 *** STARTING ***
*** TEST 75 *** PASSED ***
*** TEST 76 *** STARTING ***
*** TEST 76 *** PASSED ***
*** TEST 77 *** STARTING ***
*** TEST 77 *** PASSED ***
*** TEST 78 *** STARTING ***
*** TEST 78 *** PASSED ***
*** TEST 79 *** STARTING ***
*** TEST 79 *** PASSED ***
*** TEST 80 *** STARTING ***
*** TEST 80 *** PASSED ***
*** TEST 81 *** STARTING ***
*** TEST 81 *** PASSED ***
*** TEST 82 *** STARTING ***
*** TEST 82 *** PASSED ***
*** TEST 83 *** STARTING ***
*** TEST 83 *** PASSED ***
*** TEST 84 *** STARTING ***
*** TEST 84 *** PASSED ***
*** TEST 85 *** STARTING ***
*** TEST 85 *** PASSED ***
*** TEST 86 *** STARTING ***
*** TEST 86 *** PASSED ***
*** TEST 87 *** STARTING ***
*** TEST 87 *** PASSED ***
*** TEST 88 *** STARTING ***
*** TEST 88 *** PASSED ***
*** TEST 89 *** STARTING ***
*** TEST 89 *** PASSED ***
*** TEST 90 *** STARTING ***
*** TEST 90 *** PASSED ***
*** TEST 91 *** STARTING ***
*** TEST 91 *** PASSED ***
*** TEST 92 *** STARTING ***
*** TEST 92 *** PASSED ***
*** TEST 93 *** STARTING ***
*** TEST 93 *** PASSED ***
*** TEST 94 *** STARTING ***
*** TEST 94 *** PASSED ***
*** TEST 95 *** STARTING ***
*** TEST 95 *** PASSED ***
*** TEST 96 *** STARTING ***
*** TEST 96 *** PASSED ***
*** TEST 97 *** STARTING ***
*** TEST 97 *** PASSED ***
*** TEST 98 *** STARTING ***
*** TEST 98 *** PASSED ***
*** TEST 99 *** STARTING ***
*** TEST 99 *** PASSED ***
*** TEST 100 *** STARTING ***
*** TEST 100 *** PASSED ***
*** TEST 101 *** STARTING ***
*** TEST 101 *** PASSED ***
*** TEST 102 *** STARTING ***
*** TEST 102 *** PASSED ***
*** TEST 103 *** STARTING ***
*** TEST 103 *** PASSED ***
*** TEST 104 *** STARTING ***
*** TEST 104 *** PASSED ***
*** TEST 105 *** STARTING ***
*** TEST 105 *** PASSED ***
*** TEST 106 *** STARTING ***
*** TEST 106 *** PASSED ***
*** TEST 107 *** STARTING ***
*** TEST 107 *** PASSED ***
*** TEST 108 *** STARTING ***
*** TEST 108 *** PASSED ***
*** TEST 109 *** STARTING ***
*** TEST 109 *** PASSED ***
*** TEST 110 *** STARTING ***
*** TEST 110 *** PASSED ***
*** TEST 111 *** STARTING ***
*** TEST 111 *** PASSED ***
*** TEST 112 *** STARTING ***
*** TEST 112 *** PASSED ***
*** TEST 113 *** STARTING ***
*** TEST 113 *** PASSED ***
*** TEST 114 *** STARTING ***
*** TEST 114 *** PASSED ***
*** TEST 115 *** STARTING ***
*** TEST 115 *** PASSED ***
*** TEST 116 *** STARTING ***
*** TEST 116 *** PASSED ***
*** TEST 117 *** STARTING ***
*** TEST 117 *** PASSED ***
*** TEST 118 *** STARTING ***
*** TEST 118 *** PASSED ***
*** TEST 119 *** STARTING ***
*** TEST 119 *** PASSED ***
*** TEST 120 REGRESSION_RESULT PARENTSELECTION:  
PASSED
REGRESSION_TEST DONE: FAILED
*** STARTING ***
*** TEST 120 *** PASSED ***
*** TEST 121 *** STARTING ***
*** TEST 121 *** PASSED ***
*** TEST 122 *** STARTING ***
*** TEST 122 *** PASSED ***
*** TEST 123 *** STARTING ***
*** TEST 123 *** PASSED ***
*** TEST 124 *** STARTING ***
*** TEST 124 *** PASSED ***
*** TEST 125 *** STARTING ***
*** TEST 125 *** PASSED ***
*** TEST 126 *** STARTING ***
*** TEST 126 *** PASSED ***
*** TEST 127 *** STARTING ***
*** TEST 127 *** PASSED ***
*** TEST 128 *** STARTING ***
*** TEST 128 *** PASSED ***
*** TEST 129 *** STARTING ***
*** TEST 129 *** PASSED ***
*** TEST 130 *** STARTING ***
*** TEST 130 *** PASSED ***
*** TEST 131 *** STARTING ***
*** TEST 131 *** PASSED ***
*** TEST 132 *** STARTING ***
*** TEST 132 *** PASSED ***
*** TEST 133 *** STARTING ***
*** TEST 133 *** PASSED ***
*** TEST 134 *** STARTING ***
*** TEST 134 *** PASSED ***
*** TEST 135 *** STARTING ***
*** TEST 135 *** PASSED ***
*** TEST 136 *** STARTING ***
*** TEST 136 *** PASSED ***
*** TEST 137 *** STARTING ***
*** TEST 137 *** PASSED ***
*** TEST 138 *** STARTING ***
*** TEST 138 *** PASSED ***
*** TEST 139 *** STARTING ***
*** TEST 139 *** PASSED ***
*** TEST 140 *** STARTING ***
*** TEST 140 *** PASSED ***
*** TEST 141 *** STARTING ***
*** TEST 141 *** PASSED ***
*** TEST 142 *** STARTING ***
*** TEST 142 *** PASSED ***
*** TEST 143 *** STARTING ***
*** TEST 143 *** PASSED ***
*** TEST 144 *** STARTING ***
*** 

Build failed in Jenkins: clang-analyzer #2709

[jenkins]

See 

--
[...truncated 5402 lines...]
reading sources... [ 69%] developer-guide/api/functions/TSVIOMutexGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONTodoGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReaderGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReenable.en
reading sources... [ 71%] developer-guide/api/functions/TSVIOVConnGet.en
reading sources... [ 71%] developer-guide/api/functions/TSfclose.en
reading sources... [ 71%] developer-guide/api/functions/TSfflush.en
reading sources... [ 71%] developer-guide/api/functions/TSfgets.en
reading sources... [ 71%] developer-guide/api/functions/TSfopen.en
reading sources... [ 72%] developer-guide/api/functions/TSfread.en
reading sources... [ 72%] developer-guide/api/functions/TSfwrite.en
reading sources... [ 72%] developer-guide/api/functions/TSmalloc.en
reading sources... [ 72%] developer-guide/api/functions/index.en
reading sources... [ 73%] developer-guide/api/index.en
reading sources... [ 73%] developer-guide/api/types/TSCacheDataType.en
reading sources... [ 73%] developer-guide/api/types/TSCacheError.en
reading sources... [ 73%] developer-guide/api/types/TSCacheLookupResult.en
reading sources... [ 73%] developer-guide/api/types/TSCacheScanResult.en
reading sources... [ 74%] developer-guide/api/types/TSEvent.en
reading sources... [ 74%] developer-guide/api/types/TSFetchWakeUpOptions.en
reading sources... [ 74%] developer-guide/api/types/TSHttpHookID.en
reading sources... [ 74%] developer-guide/api/types/TSHttpStatus.en
reading sources... [ 75%] developer-guide/api/types/TSHttpType.en
reading sources... [ 75%] developer-guide/api/types/TSIOBuffersSizeIndex.en
reading sources... [ 75%] developer-guide/api/types/TSLifecycleHookID.en
reading sources... [ 75%] developer-guide/api/types/TSLookingUpType.en
reading sources... [ 75%] developer-guide/api/types/TSMilestonesType.en
reading sources... [ 76%] developer-guide/api/types/TSOverridableConfigKey.en
reading sources... [ 76%] developer-guide/api/types/TSParseResult.en
reading sources... [ 76%] developer-guide/api/types/TSRecordAccessType.en
reading sources... [ 76%] developer-guide/api/types/TSRecordCheckType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordDataType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordModeType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordPersistType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordUpdateType.en
reading sources... [ 78%] developer-guide/api/types/TSReturnCode.en
reading sources... [ 78%] developer-guide/api/types/TSSDKVersion.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingMatchType.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingPoolType.en
reading sources... [ 78%] developer-guide/api/types/TSServerState.en
reading sources... [ 79%] developer-guide/api/types/TSStatPeristence.en
reading sources... [ 79%] developer-guide/api/types/TSStatSync.en
reading sources... [ 79%] developer-guide/api/types/TSThreadPool.en
reading sources... [ 79%] developer-guide/api/types/TSUuid.en
reading sources... [ 80%] developer-guide/api/types/TSVConnCloseFlags.en
reading sources... [ 80%] developer-guide/api/types/index.en
reading sources... [ 80%] developer-guide/architecture/api-functions.en
reading sources... [ 80%] developer-guide/architecture/architecture.en
reading sources... [ 80%] developer-guide/architecture/consistency.en
reading sources... [ 81%] developer-guide/architecture/data-structures.en
reading sources... [ 81%] developer-guide/architecture/index.en
reading sources... [ 81%] developer-guide/architecture/ram-cache.en
reading sources... [ 81%] developer-guide/architecture/tiered-storage.en
reading sources... [ 82%] developer-guide/config-vars.en
reading sources... [ 82%] developer-guide/continuous-integration/index.en
reading sources... [ 82%] developer-guide/contributing/index.en
reading sources... [ 82%] developer-guide/debugging/core-dump-analysis.en
reading sources... [ 82%] developer-guide/debugging/debug-builds.en
reading sources... [ 83%] developer-guide/debugging/debug-tags.en
reading sources... [ 83%] developer-guide/debugging/index.en
reading sources... [ 83%] developer-guide/debugging/memory-leaks.en
reading sources... [ 83%] developer-guide/debugging/profiling.en
reading sources... [ 84%] developer-guide/debugging/using-tsassert.en
reading sources... [ 84%] developer-guide/documentation/adding-domains.en
reading 

Build failed in Jenkins: clang-analyzer #2708

[jenkins]

See 

Changes:

[Bryan Call] TS-4909: Throttling based on resident memory

[Bryan Call] TS-4909: Throttling based on resident memory backdoor was renaned 
to

--
[...truncated 5402 lines...]
reading sources... [ 69%] developer-guide/api/functions/TSVIOMutexGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONTodoGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReaderGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReenable.en
reading sources... [ 71%] developer-guide/api/functions/TSVIOVConnGet.en
reading sources... [ 71%] developer-guide/api/functions/TSfclose.en
reading sources... [ 71%] developer-guide/api/functions/TSfflush.en
reading sources... [ 71%] developer-guide/api/functions/TSfgets.en
reading sources... [ 71%] developer-guide/api/functions/TSfopen.en
reading sources... [ 72%] developer-guide/api/functions/TSfread.en
reading sources... [ 72%] developer-guide/api/functions/TSfwrite.en
reading sources... [ 72%] developer-guide/api/functions/TSmalloc.en
reading sources... [ 72%] developer-guide/api/functions/index.en
reading sources... [ 73%] developer-guide/api/index.en
reading sources... [ 73%] developer-guide/api/types/TSCacheDataType.en
reading sources... [ 73%] developer-guide/api/types/TSCacheError.en
reading sources... [ 73%] developer-guide/api/types/TSCacheLookupResult.en
reading sources... [ 73%] developer-guide/api/types/TSCacheScanResult.en
reading sources... [ 74%] developer-guide/api/types/TSEvent.en
reading sources... [ 74%] developer-guide/api/types/TSFetchWakeUpOptions.en
reading sources... [ 74%] developer-guide/api/types/TSHttpHookID.en
reading sources... [ 74%] developer-guide/api/types/TSHttpStatus.en
reading sources... [ 75%] developer-guide/api/types/TSHttpType.en
reading sources... [ 75%] developer-guide/api/types/TSIOBuffersSizeIndex.en
reading sources... [ 75%] developer-guide/api/types/TSLifecycleHookID.en
reading sources... [ 75%] developer-guide/api/types/TSLookingUpType.en
reading sources... [ 75%] developer-guide/api/types/TSMilestonesType.en
reading sources... [ 76%] developer-guide/api/types/TSOverridableConfigKey.en
reading sources... [ 76%] developer-guide/api/types/TSParseResult.en
reading sources... [ 76%] developer-guide/api/types/TSRecordAccessType.en
reading sources... [ 76%] developer-guide/api/types/TSRecordCheckType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordDataType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordModeType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordPersistType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordUpdateType.en
reading sources... [ 78%] developer-guide/api/types/TSReturnCode.en
reading sources... [ 78%] developer-guide/api/types/TSSDKVersion.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingMatchType.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingPoolType.en
reading sources... [ 78%] developer-guide/api/types/TSServerState.en
reading sources... [ 79%] developer-guide/api/types/TSStatPeristence.en
reading sources... [ 79%] developer-guide/api/types/TSStatSync.en
reading sources... [ 79%] developer-guide/api/types/TSThreadPool.en
reading sources... [ 79%] developer-guide/api/types/TSUuid.en
reading sources... [ 80%] developer-guide/api/types/TSVConnCloseFlags.en
reading sources... [ 80%] developer-guide/api/types/index.en
reading sources... [ 80%] developer-guide/architecture/api-functions.en
reading sources... [ 80%] developer-guide/architecture/architecture.en
reading sources... [ 80%] developer-guide/architecture/consistency.en
reading sources... [ 81%] developer-guide/architecture/data-structures.en
reading sources... [ 81%] developer-guide/architecture/index.en
reading sources... [ 81%] developer-guide/architecture/ram-cache.en
reading sources... [ 81%] developer-guide/architecture/tiered-storage.en
reading sources... [ 82%] developer-guide/config-vars.en
reading sources... [ 82%] developer-guide/continuous-integration/index.en
reading sources... [ 82%] developer-guide/contributing/index.en
reading sources... [ 82%] developer-guide/debugging/core-dump-analysis.en
reading sources... [ 82%] developer-guide/debugging/debug-builds.en
reading sources... [ 83%] developer-guide/debugging/debug-tags.en
reading sources... [ 83%] developer-guide/debugging/index.en
reading sources... [ 83%] developer-guide/debugging/memory-leaks.en
reading sources... [ 83%] developer-guide/debugging/profiling.en

Jenkins build is back to normal : out_of_tree-master #2076

[jenkins]

See 

Jenkins build is back to normal : in_tree-master #2306

[jenkins]

See 

Build failed in Jenkins: out_of_tree-master #2075

[jenkins]

See 

Changes:

[Bryan Call] TS-4909: Throttling based on resident memory

--
[...truncated 577 lines...]
config.status: creating lib/tsconfig/Makefile
config.status: creating lib/wccp/Makefile
config.status: creating mgmt/Makefile
config.status: creating mgmt/api/Makefile
config.status: creating mgmt/api/include/Makefile
config.status: creating mgmt/cluster/Makefile
config.status: creating mgmt/utils/Makefile
config.status: creating plugins/Makefile
config.status: creating plugins/authproxy/Makefile
config.status: creating plugins/background_fetch/Makefile
config.status: creating plugins/conf_remap/Makefile
config.status: creating plugins/esi/Makefile
config.status: creating plugins/generator/Makefile
config.status: creating plugins/gzip/Makefile
config.status: creating plugins/header_rewrite/Makefile
config.status: creating plugins/healthchecks/Makefile
config.status: creating plugins/libloader/Makefile
config.status: creating plugins/regex_remap/Makefile
config.status: creating plugins/regex_revalidate/Makefile
config.status: creating plugins/s3_auth/Makefile
config.status: creating plugins/stats_over_http/Makefile
config.status: creating plugins/tcpinfo/Makefile
config.status: creating plugins/xdebug/Makefile
config.status: creating plugins/experimental/Makefile
config.status: creating plugins/experimental/acme/Makefile
config.status: creating plugins/experimental/balancer/Makefile
config.status: creating plugins/experimental/buffer_upload/Makefile
config.status: creating plugins/experimental/cache_key_genid/Makefile
config.status: creating plugins/experimental/cache_promote/Makefile
config.status: creating plugins/experimental/cache_range_requests/Makefile
config.status: creating plugins/experimental/cachekey/Makefile
config.status: creating plugins/experimental/collapsed_connection/Makefile
config.status: creating plugins/experimental/collapsed_forwarding/Makefile
config.status: creating plugins/experimental/custom_redirect/Makefile
config.status: creating plugins/experimental/epic/Makefile
config.status: creating plugins/experimental/escalate/Makefile
config.status: creating plugins/experimental/geoip_acl/Makefile
config.status: creating plugins/experimental/header_freq/Makefile
config.status: creating plugins/experimental/header_normalize/Makefile
config.status: creating plugins/experimental/hipes/Makefile
config.status: creating plugins/experimental/hook-trace/Makefile
config.status: creating plugins/experimental/inliner/Makefile
config.status: creating plugins/experimental/memcache/Makefile
config.status: creating plugins/experimental/memcached_remap/Makefile
config.status: creating plugins/experimental/metalink/Makefile
config.status: creating plugins/experimental/mp4/Makefile
config.status: creating plugins/experimental/multiplexer/Makefile
config.status: creating plugins/experimental/mysql_remap/Makefile
config.status: creating plugins/experimental/remap_purge/Makefile
config.status: creating plugins/experimental/remap_stats/Makefile
config.status: creating plugins/experimental/ssl_cert_loader/Makefile
config.status: creating plugins/experimental/sslheaders/Makefile
config.status: creating plugins/experimental/stale_while_revalidate/Makefile
config.status: creating plugins/experimental/stream_editor/Makefile
config.status: creating plugins/experimental/ts_lua/Makefile
config.status: creating plugins/experimental/url_sig/Makefile
config.status: creating plugins/experimental/webp_transform/Makefile
config.status: creating proxy/Makefile
config.status: creating proxy/api/ts/Makefile
config.status: creating proxy/config/Makefile
config.status: creating proxy/config/body_factory/Makefile
config.status: creating proxy/config/body_factory/default/Makefile
config.status: creating proxy/config/records.config.default
config.status: creating proxy/config/storage.config.default
config.status: creating proxy/congest/Makefile
config.status: creating proxy/hdrs/Makefile
config.status: creating proxy/http/Makefile
config.status: creating proxy/http/remap/Makefile
config.status: creating proxy/http2/Makefile
config.status: creating proxy/logging/Makefile
config.status: creating proxy/shared/Makefile
config.status: creating rc/Makefile
config.status: creating rc/trafficserver
config.status: creating rc/trafficserver.conf
config.status: creating rc/trafficserver.service
config.status: creating rc/trafficserver.xml
config.status: creating tools/Makefile
config.status: creating tools/trafficserver.pc
config.status: creating tools/tsxs
config.status: creating lib/ink_autoconf.h
config.status: executing depfiles commands
config.status: executing libtool commands
configure: Build option summary:
CC: ccache cc
CXX:ccache c++
CPP:cc -E
CFLAGS: -std=gnu99 -g -pipe -Wall -Wextra 
-Wno-ignored-qualifiers -Wno-unused-parameter -O3 

[GitHub] trafficserver pull request #1063: TS-4909: Throttling based on resident memo...

[bryancall]

Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1063


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4909) Throttling based on resident memory usage

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4909?focusedWorklogId=30722=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30722
 ]

ASF GitHub Bot logged work on TS-4909:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 23:42
Start Date: 15/Oct/16 23:42
Worklog Time Spent: 10m 
  Work Description: Github user bryancall closed the pull request at:

https://github.com/apache/trafficserver/pull/1063


Issue Time Tracking
---

Worklog Id: (was: 30722)
Time Spent: 2h 20m  (was: 2h 10m)

> Throttling based on resident memory usage
> -
>
> Key: TS-4909
> URL: https://issues.apache.org/jira/browse/TS-4909
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Core
>Reporter: Bryan Call
> Fix For: 7.1.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Add a feature to stop accepting connections if the resident memory is over a 
> certain limit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4934) Assert in Http2Stream::do_io_close() when active timeout

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4934:
---
Fix Version/s: (was: 7.1.0)
   7.0.0

> Assert in Http2Stream::do_io_close() when active timeout
> 
>
> Key: TS-4934
> URL: https://issues.apache.org/jira/browse/TS-4934
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {noformat}
> Program received signal SIGABRT, Aborted.
> 0x726e75f7 in raise () from /lib64/libc.so.6
> (gdb) bt
> #0  0x726e75f7 in raise () from /lib64/libc.so.6
> #1  0x726e8ce8 in abort () from /lib64/libc.so.6
> #2  0x74bf7c4b in ink_abort (message_format=0x74c25700 "%s:%d: 
> failed assertion `%s`") at ink_error.cc:79
> #3  0x74bf2bd7 in _ink_assert (expression=0xb43920 "get_state() == 
> HTTP2_STREAM_STATE_CLOSED", file=0xb436a0 "Http2Stream.cc", line=333)
> at ink_assert.cc:37
> #4  0x0075ef92 in Http2Stream::do_io_close (this=0x7fffe6492b40) at 
> Http2Stream.cc:333
> #5  0x00679b1d in HttpVCTable::cleanup_entry (this=0x7fffe69c8990, 
> e=0x7fffe69c8990) at HttpSM.cc:216
> #6  0x00679bde in HttpVCTable::cleanup_all (this=0x7fffe69c8990) at 
> HttpSM.cc:227
> #7  0x006b561f in HttpSM::kill_this (this=0x7fffe69c71e0) at 
> HttpSM.cc:6756
> #8  0x0068f792 in HttpSM::main_handler (this=0x7fffe69c71e0, 
> event=106, data=0x7fffe6492e88) at HttpSM.cc:2671
> #9  0x00535f6c in Continuation::handleEvent (this=0x7fffe69c71e0, 
> event=106, data=0x7fffe6492e88) at ../iocore/eventsystem/I_Continuation.h:153
> #10 0x0075d136 in Http2Stream::main_event_handler 
> (this=0x7fffe6492b40, event=106, edata=0x608e00014ce0) at Http2Stream.cc:68
> #11 0x00535f6c in Continuation::handleEvent (this=0x7fffe6492b40, 
> event=2, data=0x608e00014ce0) at ../iocore/eventsystem/I_Continuation.h:153
> #12 0x00a69c41 in EThread::process_event (this=0x70c65800, 
> e=0x608e00014ce0, calling_code=2) at UnixEThread.cc:143
> #13 0x00a6a491 in EThread::execute (this=0x70c65800) at 
> UnixEThread.cc:225
> #14 0x00a6858c in spawn_thread_internal (a=0x6008000156d0) at 
> Thread.cc:84
> #15 0x74e64ac8 in ?? () from /lib64/libasan.so.0
> #16 0x7349ddc5 in start_thread () from /lib64/libpthread.so.0
> #17 0x727a828d in clone () from /lib64/libc.so.6
> (gdb) p get_state()
> $1 = HTTP2_STREAM_STATE_HALF_CLOSED_REMOTE
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4949) Disable fuzzy revalidation logic

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4949:
---
Fix Version/s: (was: 7.1.0)
   7.0.0

> Disable fuzzy revalidation logic
> 
>
> Key: TS-4949
> URL: https://issues.apache.org/jira/browse/TS-4949
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In TS-4235, we marked the fuzzy logic as deprecated, but we left it on by 
> default. For 7.0.0, I'd like to disable the configuration defaults entirely, 
> and later for 8.0.0 we remove the remaining code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4949) Disable fuzzy revalidation logic

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4949:
---
Backport to Version:   (was: 7.0.0)

> Disable fuzzy revalidation logic
> 
>
> Key: TS-4949
> URL: https://issues.apache.org/jira/browse/TS-4949
> Project: Traffic Server
>  Issue Type: Improvement
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> In TS-4235, we marked the fuzzy logic as deprecated, but we left it on by 
> default. For 7.0.0, I'd like to disable the configuration defaults entirely, 
> and later for 8.0.0 we remove the remaining code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4934) Assert in Http2Stream::do_io_close() when active timeout

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4934:
---
Backport to Version: 6.2.1  (was: 6.2.1, 7.0.0)

> Assert in Http2Stream::do_io_close() when active timeout
> 
>
> Key: TS-4934
> URL: https://issues.apache.org/jira/browse/TS-4934
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP/2
>Reporter: Masaori Koshiba
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> {noformat}
> Program received signal SIGABRT, Aborted.
> 0x726e75f7 in raise () from /lib64/libc.so.6
> (gdb) bt
> #0  0x726e75f7 in raise () from /lib64/libc.so.6
> #1  0x726e8ce8 in abort () from /lib64/libc.so.6
> #2  0x74bf7c4b in ink_abort (message_format=0x74c25700 "%s:%d: 
> failed assertion `%s`") at ink_error.cc:79
> #3  0x74bf2bd7 in _ink_assert (expression=0xb43920 "get_state() == 
> HTTP2_STREAM_STATE_CLOSED", file=0xb436a0 "Http2Stream.cc", line=333)
> at ink_assert.cc:37
> #4  0x0075ef92 in Http2Stream::do_io_close (this=0x7fffe6492b40) at 
> Http2Stream.cc:333
> #5  0x00679b1d in HttpVCTable::cleanup_entry (this=0x7fffe69c8990, 
> e=0x7fffe69c8990) at HttpSM.cc:216
> #6  0x00679bde in HttpVCTable::cleanup_all (this=0x7fffe69c8990) at 
> HttpSM.cc:227
> #7  0x006b561f in HttpSM::kill_this (this=0x7fffe69c71e0) at 
> HttpSM.cc:6756
> #8  0x0068f792 in HttpSM::main_handler (this=0x7fffe69c71e0, 
> event=106, data=0x7fffe6492e88) at HttpSM.cc:2671
> #9  0x00535f6c in Continuation::handleEvent (this=0x7fffe69c71e0, 
> event=106, data=0x7fffe6492e88) at ../iocore/eventsystem/I_Continuation.h:153
> #10 0x0075d136 in Http2Stream::main_event_handler 
> (this=0x7fffe6492b40, event=106, edata=0x608e00014ce0) at Http2Stream.cc:68
> #11 0x00535f6c in Continuation::handleEvent (this=0x7fffe6492b40, 
> event=2, data=0x608e00014ce0) at ../iocore/eventsystem/I_Continuation.h:153
> #12 0x00a69c41 in EThread::process_event (this=0x70c65800, 
> e=0x608e00014ce0, calling_code=2) at UnixEThread.cc:143
> #13 0x00a6a491 in EThread::execute (this=0x70c65800) at 
> UnixEThread.cc:225
> #14 0x00a6858c in spawn_thread_internal (a=0x6008000156d0) at 
> Thread.cc:84
> #15 0x74e64ac8 in ?? () from /lib64/libasan.so.0
> #16 0x7349ddc5 in start_thread () from /lib64/libpthread.so.0
> #17 0x727a828d in clone () from /lib64/libc.so.6
> (gdb) p get_state()
> $1 = HTTP2_STREAM_STATE_HALF_CLOSED_REMOTE
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4626) LogFile::close_file should not delete m_log handle

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4626:
---
Fix Version/s: (was: 7.1.0)
   7.0.0

> LogFile::close_file should not delete m_log handle
> --
>
> Key: TS-4626
> URL: https://issues.apache.org/jira/browse/TS-4626
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Michael Chai
>Assignee: Daniel Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> When log file was deleted on the disk, LogFile::check_fd will close file 
> handle and reopen again.delete m_log at this point will cause 
> LogFile::open_file return "LOG_FILE_COULD_NOT_OPEN_FILE" .  otherwise, will 
> cause trafficserver crash at LogFile::preproc_and_try_delete
> 300 if (!m_log->m_start_time) {
> (gdb) bt
> #0  0x0068245f in LogFile::preproc_and_try_delete (this=0x1132eb0, 
> lb=0x7fffdc000da0) at LogFile.cc:300
> #1  0x0068caa6 in LogBufferManager::preproc_buffers (this=0x1132970, 
> sink=0x1132eb0) at LogObject.cc:77
> #2  0x00691a53 in LogObject::preproc_buffers (this=0x1132ae0, idx=0) 
> at LogObject.h:146
> #3  0x006901c3 in LogObjectManager::preproc_buffers (this=0x1127228, 
> idx=0) at LogObject.cc:1126
> #4  0x0066b668 in Log::preproc_thread_main (args=0x1131edc) at 
> Log.cc:1168
> #5  0x0066ce9d in LoggingPreprocContinuation::mainEvent 
> (this=0x1131ea0) at Log.cc:279
> #6  0x0050d662 in Continuation::handleEvent (this=0x1131ea0, event=1, 
> data=0x11529a0) at ../iocore/eventsystem/I_Continuation.h:153
> #7  0x007a1e9f in EThread::execute (this=0x707a1010) at 
> UnixEThread.cc:298
> #8  0x007a0d0c in spawn_thread_internal (a=0x1131ef0) at Thread.cc:84
> #9  0x764740a4 in start_thread (arg=0x707a0700) at 
> pthread_create.c:309
> #10 0x7541c04d in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
> (gdb) p m_log
> $1 = (BaseLogFile *) 0x0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4626) LogFile::close_file should not delete m_log handle

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4626:
---
Backport to Version: 6.2.1  (was: 6.2.1, 7.0.0)

> LogFile::close_file should not delete m_log handle
> --
>
> Key: TS-4626
> URL: https://issues.apache.org/jira/browse/TS-4626
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Michael Chai
>Assignee: Daniel Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> When log file was deleted on the disk, LogFile::check_fd will close file 
> handle and reopen again.delete m_log at this point will cause 
> LogFile::open_file return "LOG_FILE_COULD_NOT_OPEN_FILE" .  otherwise, will 
> cause trafficserver crash at LogFile::preproc_and_try_delete
> 300 if (!m_log->m_start_time) {
> (gdb) bt
> #0  0x0068245f in LogFile::preproc_and_try_delete (this=0x1132eb0, 
> lb=0x7fffdc000da0) at LogFile.cc:300
> #1  0x0068caa6 in LogBufferManager::preproc_buffers (this=0x1132970, 
> sink=0x1132eb0) at LogObject.cc:77
> #2  0x00691a53 in LogObject::preproc_buffers (this=0x1132ae0, idx=0) 
> at LogObject.h:146
> #3  0x006901c3 in LogObjectManager::preproc_buffers (this=0x1127228, 
> idx=0) at LogObject.cc:1126
> #4  0x0066b668 in Log::preproc_thread_main (args=0x1131edc) at 
> Log.cc:1168
> #5  0x0066ce9d in LoggingPreprocContinuation::mainEvent 
> (this=0x1131ea0) at Log.cc:279
> #6  0x0050d662 in Continuation::handleEvent (this=0x1131ea0, event=1, 
> data=0x11529a0) at ../iocore/eventsystem/I_Continuation.h:153
> #7  0x007a1e9f in EThread::execute (this=0x707a1010) at 
> UnixEThread.cc:298
> #8  0x007a0d0c in spawn_thread_internal (a=0x1131ef0) at Thread.cc:84
> #9  0x764740a4 in start_thread (arg=0x707a0700) at 
> pthread_create.c:309
> #10 0x7541c04d in clone () at 
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
> (gdb) p m_log
> $1 = (BaseLogFile *) 0x0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4885) Incorrect checking of fds_throttle and fds_limit

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4885:
---
Backport to Version:   (was: 7.0.0)

> Incorrect checking of fds_throttle and fds_limit
> 
>
> Key: TS-4885
> URL: https://issues.apache.org/jira/browse/TS-4885
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code}
>  902 static void
>  903 check_fd_limit()
>  904 {
>  905   int fds_throttle = -1;
>  906   REC_ReadConfigInteger(fds_throttle, 
> "proxy.config.net.connections_throttle");
>  907   if (fds_throttle > fds_limit + THROTTLE_FD_HEADROOM) {  // 
> ---> Incorrect
>  908 int new_fds_throttle = fds_limit - THROTTLE_FD_HEADROOM;
>  909 if (new_fds_throttle < 1) {
>  910   ink_abort("too few file descriptors (%d) available", fds_limit);
>  911 }
>  912 char msg[256];
>  913 snprintf(msg, sizeof(msg), "connection throttle too high, "
>  914"%d (throttle) + %d (internal use) > %d 
> (file descriptor limit), "
>  915"using throttle of %d",
>  916  fds_throttle, THROTTLE_FD_HEADROOM, fds_limit, 
> new_fds_throttle);
>  917 SignalWarning(MGMT_SIGNAL_SYSTEM_ERROR, msg);
>  918   }
>  919 }
> {code}
> {code}
> 1001 static void
> 1002 adjust_sys_settings(void)
> 1003 {
> ...
> 1024   REC_ReadConfigInteger(fds_throttle, 
> "proxy.config.net.connections_throttle");
> 1025 
> 1026   if (getrlimit(RLIMIT_NOFILE, ) == 0) {
> 1027 if (fds_throttle > (int)(lim.rlim_cur + THROTTLE_FD_HEADROOM)) {  // 
> --> Incorrect
> 1028   lim.rlim_cur = (lim.rlim_max = (rlim_t)fds_throttle);
> 1029   if (setrlimit(RLIMIT_NOFILE, ) == 0 && 
> getrlimit(RLIMIT_NOFILE, ) == 0) {
> 1030 fds_limit = (int)lim.rlim_cur;
> 1031 syslog(LOG_NOTICE, "NOTE: RLIMIT_NOFILE(%d):cur(%d),max(%d)", 
> RLIMIT_NOFILE, (int)lim.rlim_cur, (int)lim.rlim_max);
> 1032   }
> 1033 }
> 1034   }
> ...
> 1043 }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-4885) Incorrect checking of fds_throttle and fds_limit

[Bryan Call (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Call updated TS-4885:
---
Fix Version/s: (was: 7.1.0)
   7.0.0

> Incorrect checking of fds_throttle and fds_limit
> 
>
> Key: TS-4885
> URL: https://issues.apache.org/jira/browse/TS-4885
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {code}
>  902 static void
>  903 check_fd_limit()
>  904 {
>  905   int fds_throttle = -1;
>  906   REC_ReadConfigInteger(fds_throttle, 
> "proxy.config.net.connections_throttle");
>  907   if (fds_throttle > fds_limit + THROTTLE_FD_HEADROOM) {  // 
> ---> Incorrect
>  908 int new_fds_throttle = fds_limit - THROTTLE_FD_HEADROOM;
>  909 if (new_fds_throttle < 1) {
>  910   ink_abort("too few file descriptors (%d) available", fds_limit);
>  911 }
>  912 char msg[256];
>  913 snprintf(msg, sizeof(msg), "connection throttle too high, "
>  914"%d (throttle) + %d (internal use) > %d 
> (file descriptor limit), "
>  915"using throttle of %d",
>  916  fds_throttle, THROTTLE_FD_HEADROOM, fds_limit, 
> new_fds_throttle);
>  917 SignalWarning(MGMT_SIGNAL_SYSTEM_ERROR, msg);
>  918   }
>  919 }
> {code}
> {code}
> 1001 static void
> 1002 adjust_sys_settings(void)
> 1003 {
> ...
> 1024   REC_ReadConfigInteger(fds_throttle, 
> "proxy.config.net.connections_throttle");
> 1025 
> 1026   if (getrlimit(RLIMIT_NOFILE, ) == 0) {
> 1027 if (fds_throttle > (int)(lim.rlim_cur + THROTTLE_FD_HEADROOM)) {  // 
> --> Incorrect
> 1028   lim.rlim_cur = (lim.rlim_max = (rlim_t)fds_throttle);
> 1029   if (setrlimit(RLIMIT_NOFILE, ) == 0 && 
> getrlimit(RLIMIT_NOFILE, ) == 0) {
> 1030 fds_limit = (int)lim.rlim_cur;
> 1031 syslog(LOG_NOTICE, "NOTE: RLIMIT_NOFILE(%d):cur(%d),max(%d)", 
> RLIMIT_NOFILE, (int)lim.rlim_cur, (int)lim.rlim_max);
> 1032   }
> 1033 }
> 1034   }
> ...
> 1043 }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1112
  
Is there a Jira ticket for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30721=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30721
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 21:46
Start Date: 15/Oct/16 21:46
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1114
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1030/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30721)
Time Spent: 3h 50m  (was: 3h 40m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1114: TS-4971: Remove useless casts from plugins.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1114
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1030/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30720=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30720
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 21:38
Start Date: 15/Oct/16 21:38
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1114
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/922/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30720)
Time Spent: 3h 40m  (was: 3.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1114: TS-4971: Remove useless casts from plugins.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1114
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/922/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30719=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30719
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 21:35
Start Date: 15/Oct/16 21:35
Worklog Time Spent: 10m 
  Work Description: GitHub user SolidWallOfCode opened a pull request:

https://github.com/apache/trafficserver/pull/1114

TS-4971: Remove useless casts from plugins.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1114


commit 9214ef1a1db320a6b3d2e067fb89e06d3bddf113
Author: Alan M. Carroll 
Date:   2016-10-14T22:56:53Z

TS-4971: Remove useless casts from plugins.




Issue Time Tracking
---

Worklog Id: (was: 30719)
Time Spent: 3.5h  (was: 3h 20m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1114: TS-4971: Remove useless casts from plugins...

[SolidWallOfCode]

GitHub user SolidWallOfCode opened a pull request:

https://github.com/apache/trafficserver/pull/1114

TS-4971: Remove useless casts from plugins.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1114


commit 9214ef1a1db320a6b3d2e067fb89e06d3bddf113
Author: Alan M. Carroll 
Date:   2016-10-14T22:56:53Z

TS-4971: Remove useless casts from plugins.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[Alan M. Carroll (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll resolved TS-4971.
-
Resolution: Fixed

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: clang-analyzer #2707

[jenkins]

See 

Changes:

[amc] TS-4971: Change TSPluginRegistration to be const.

--
[...truncated 5404 lines...]
reading sources... [ 69%] developer-guide/api/functions/TSVIOMutexGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesGet.en
reading sources... [ 69%] developer-guide/api/functions/TSVIONBytesSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONDoneSet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIONTodoGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReaderGet.en
reading sources... [ 70%] developer-guide/api/functions/TSVIOReenable.en
reading sources... [ 71%] developer-guide/api/functions/TSVIOVConnGet.en
reading sources... [ 71%] developer-guide/api/functions/TSfclose.en
reading sources... [ 71%] developer-guide/api/functions/TSfflush.en
reading sources... [ 71%] developer-guide/api/functions/TSfgets.en
reading sources... [ 71%] developer-guide/api/functions/TSfopen.en
reading sources... [ 72%] developer-guide/api/functions/TSfread.en
reading sources... [ 72%] developer-guide/api/functions/TSfwrite.en
reading sources... [ 72%] developer-guide/api/functions/TSmalloc.en
reading sources... [ 72%] developer-guide/api/functions/index.en
reading sources... [ 73%] developer-guide/api/index.en
reading sources... [ 73%] developer-guide/api/types/TSCacheDataType.en
reading sources... [ 73%] developer-guide/api/types/TSCacheError.en
reading sources... [ 73%] developer-guide/api/types/TSCacheLookupResult.en
reading sources... [ 73%] developer-guide/api/types/TSCacheScanResult.en
reading sources... [ 74%] developer-guide/api/types/TSEvent.en
reading sources... [ 74%] developer-guide/api/types/TSFetchWakeUpOptions.en
reading sources... [ 74%] developer-guide/api/types/TSHttpHookID.en
reading sources... [ 74%] developer-guide/api/types/TSHttpStatus.en
reading sources... [ 75%] developer-guide/api/types/TSHttpType.en
reading sources... [ 75%] developer-guide/api/types/TSIOBuffersSizeIndex.en
reading sources... [ 75%] developer-guide/api/types/TSLifecycleHookID.en
reading sources... [ 75%] developer-guide/api/types/TSLookingUpType.en
reading sources... [ 75%] developer-guide/api/types/TSMilestonesType.en
reading sources... [ 76%] developer-guide/api/types/TSOverridableConfigKey.en
reading sources... [ 76%] developer-guide/api/types/TSParseResult.en
reading sources... [ 76%] developer-guide/api/types/TSRecordAccessType.en
reading sources... [ 76%] developer-guide/api/types/TSRecordCheckType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordDataType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordModeType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordPersistType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordType.en
reading sources... [ 77%] developer-guide/api/types/TSRecordUpdateType.en
reading sources... [ 78%] developer-guide/api/types/TSReturnCode.en
reading sources... [ 78%] developer-guide/api/types/TSSDKVersion.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingMatchType.en
reading sources... [ 78%] 
developer-guide/api/types/TSServerSessionSharingPoolType.en
reading sources... [ 78%] developer-guide/api/types/TSServerState.en
reading sources... [ 79%] developer-guide/api/types/TSStatPeristence.en
reading sources... [ 79%] developer-guide/api/types/TSStatSync.en
reading sources... [ 79%] developer-guide/api/types/TSThreadPool.en
reading sources... [ 79%] developer-guide/api/types/TSUuid.en
reading sources... [ 80%] developer-guide/api/types/TSVConnCloseFlags.en
reading sources... [ 80%] developer-guide/api/types/index.en
reading sources... [ 80%] developer-guide/architecture/api-functions.en
reading sources... [ 80%] developer-guide/architecture/architecture.en
reading sources... [ 80%] developer-guide/architecture/consistency.en
reading sources... [ 81%] developer-guide/architecture/data-structures.en
reading sources... [ 81%] developer-guide/architecture/index.en
reading sources... [ 81%] developer-guide/architecture/ram-cache.en
reading sources... [ 81%] developer-guide/architecture/tiered-storage.en
reading sources... [ 82%] developer-guide/config-vars.en
reading sources... [ 82%] developer-guide/continuous-integration/index.en
reading sources... [ 82%] developer-guide/contributing/index.en
reading sources... [ 82%] developer-guide/debugging/core-dump-analysis.en
reading sources... [ 82%] developer-guide/debugging/debug-builds.en
reading sources... [ 83%] developer-guide/debugging/debug-tags.en
reading sources... [ 83%] developer-guide/debugging/index.en
reading sources... [ 83%] developer-guide/debugging/memory-leaks.en
reading sources... [ 83%] developer-guide/debugging/profiling.en
reading sources... [ 84%] developer-guide/debugging/using-tsassert.en
reading 

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30718=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30718
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 21:04
Start Date: 15/Oct/16 21:04
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/921/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30718)
Time Spent: 3h 20m  (was: 3h 10m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1110: TS-4971: Change TSPluginRegistration to be const.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/921/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30717
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 21:00
Start Date: 15/Oct/16 21:00
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1029/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 30717)
Time Spent: 3h 10m  (was: 3h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1110: TS-4971: Change TSPluginRegistration to be const.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1029/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TS-4976) Clean up casting in the plugins.

[Alan M. Carroll (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578740#comment-15578740
 ] 

Alan M. Carroll commented on TS-4976:
-

In my view, the point of cleaning up these casts is to provide better example 
code. For that reason, I would prefer to clean up all the casting in the 
plugins. It's actually less work to do that than to pick and choose which casts 
to fix.

> Clean up casting in the plugins.
> 
>
> Key: TS-4976
> URL: https://issues.apache.org/jira/browse/TS-4976
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
>
> With TS-4971 committed, we should clean up the {{const_cast}} formerly 
> required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-4976) Clean up casting in the plugins.

[Alan M. Carroll (JIRA)]

Alan M. Carroll created TS-4976:
---

 Summary: Clean up casting in the plugins.
 Key: TS-4976
 URL: https://issues.apache.org/jira/browse/TS-4976
 Project: Traffic Server
  Issue Type: Improvement
  Components: Plugins
Reporter: Alan M. Carroll


With TS-4971 committed, we should clean up the {{const_cast}} formerly required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30716=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30716
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 20:52
Start Date: 15/Oct/16 20:52
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode closed the pull request at:

https://github.com/apache/trafficserver/pull/1110


Issue Time Tracking
---

Worklog Id: (was: 30716)
Time Spent: 3h  (was: 2h 50m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1110: TS-4971: Change TSPluginRegistration to be...

[SolidWallOfCode]

Github user SolidWallOfCode closed the pull request at:

https://github.com/apache/trafficserver/pull/1110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1112
  
It's a big change, but we should probably do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30715=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30715
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 19:40
Start Date: 15/Oct/16 19:40
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
I think we should fix up the casts, or not. I think it's worse to say we'll 
fix some of the pointless casts but not others. If the goal is to show correct 
code, they should all be fixed. I also think if we're fixing this all C style 
casts should be removed. Those are strongly deprecated for C++ code. The point 
of the distinct casts is to make it clear what is being done.

I'm fine with splitting this into a PR for each commit. That's why I left 
them separated.


Issue Time Tracking
---

Worklog Id: (was: 30715)
Time Spent: 2h 50m  (was: 2h 40m)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1110: TS-4971: Change TSPluginRegistration to be const.

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1110
  
I think we should fix up the casts, or not. I think it's worse to say we'll 
fix some of the pointless casts but not others. If the goal is to show correct 
code, they should all be fixed. I also think if we're fixing this all C style 
casts should be removed. Those are strongly deprecated for C++ code. The point 
of the distinct casts is to make it clear what is being done.

I'm fine with splitting this into a PR for each commit. That's why I left 
them separated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1112
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1028/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1112: RFC: Prefer nullptr to NULL.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1112
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/920/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30714=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30714
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534541
  
--- Diff: plugins/esi/esi.cc ---
@@ -1599,12 +1599,9 @@ esiPluginInit(int argc, const char *argv[], struct 
OptionInfo *pOptionInfo)
   if (argc > 1) {
 int c;
 static const struct option longopts[] = {
-  {const_cast("packed-node-support"), no_argument, NULL, 'n'},
-  {const_cast("private-response"), no_argument, NULL, 'p'},
-  {const_cast("disable-gzip-output"), no_argument, NULL, 'z'},
-  {const_cast("first-byte-flush"), no_argument, NULL, 'b'},
-  {const_cast("handler-filename"), required_argument, NULL, 
'f'},
-  {NULL, 0, NULL, 0},
+  {"packed-node-support", no_argument, NULL, 'n'},
{"private-response", no_argument, NULL, 'p'},
+  {"disable-gzip-output", no_argument, NULL, 'z'},
{"first-byte-flush", no_argument, NULL, 'b'},
+  {"handler-filename", required_argument, NULL, 'f'}, {NULL, 0, NULL, 
0},
--- End diff --

Solaris


Issue Time Tracking
---

Worklog Id: (was: 30714)
Time Spent: 2h 40m  (was: 2.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30712=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30712
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534567
  
--- Diff: plugins/esi/fetcher/HttpDataFetcherImpl.cc ---
@@ -80,7 +80,7 @@ HttpDataFetcherImpl::addFetchRequest(const string , 
FetchedDataProcessor *ca
   if (length < (int)sizeof(buff)) {
 http_req = buff;
   } else {
-http_req = (char *)malloc(length + 1);
+http_req = static_cast(malloc(length + 1));
--- End diff --

I'm not convinced by ``static_cast`` on ``malloc()``. It does nothing but 
look uglier. It would be better not to include so many different changes in 
this PR.


Issue Time Tracking
---

Worklog Id: (was: 30712)
Time Spent: 2h 40m  (was: 2.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30713=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30713
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534526
  
--- Diff: plugins/authproxy/authproxy.cc ---
@@ -682,10 +682,10 @@ AuthParseOptions(int argc, const char **argv)
   // on some platforms (e.g. Solaris / Illumos). On sane platforms (e.g. 
linux), it'll get
   // automatically casted back to the const char*, as the struct is 
defined in .
   static const struct option longopt[] = {
-{const_cast("auth-host"), required_argument, 0, 'h'},
-{const_cast("auth-port"), required_argument, 0, 'p'},
-{const_cast("auth-transform"), required_argument, 0, 't'},
-{const_cast("force-cacheability"), no_argument, 0, 'c'},
+{"auth-host", required_argument, 0, 'h'},
+{"auth-port", required_argument, 0, 'p'},
+{"auth-transform", required_argument, 0, 't'},
+{"force-cacheability", no_argument, 0, 'c'},
--- End diff --

This change will break Solaris.


Issue Time Tracking
---

Worklog Id: (was: 30713)
Time Spent: 2h 40m  (was: 2.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-4971) Change TSPluginRegistration and TSPluginRegister to take const data

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-4971?focusedWorklogId=30711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30711
 ]

ASF GitHub Bot logged work on TS-4971:
--

Author: ASF GitHub Bot
Created on: 15/Oct/16 15:56
Start Date: 15/Oct/16 15:56
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534537
  
--- Diff: plugins/background_fetch/background_fetch.cc ---
@@ -551,13 +551,12 @@ void
 TSPluginInit(int argc, const char *argv[])
 {
   TSPluginRegistrationInfo info;
-  static const struct option longopt[] = {{const_cast("log"), 
required_argument, NULL, 'l'},
-  {const_cast("config"), 
required_argument, NULL, 'c'},
-  {NULL, no_argument, NULL, '\0'}};
+  static const struct option longopt[] = {
+{"log", required_argument, NULL, 'l'}, {"config", required_argument, 
NULL, 'c'}, {NULL, no_argument, NULL, '\0'}};
--- End diff --

Solaris again :(


Issue Time Tracking
---

Worklog Id: (was: 30711)
Time Spent: 2h 40m  (was: 2.5h)

> Change TSPluginRegistration and TSPluginRegister to take const data
> ---
>
> Key: TS-4971
> URL: https://issues.apache.org/jira/browse/TS-4971
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Plugins
>Reporter: Alan M. Carroll
> Fix For: 7.1.0
>
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> These should be constant. The fact they are not causes problems and bad 
> programming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1110: TS-4971: Change TSPluginRegistration to be...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534537
  
--- Diff: plugins/background_fetch/background_fetch.cc ---
@@ -551,13 +551,12 @@ void
 TSPluginInit(int argc, const char *argv[])
 {
   TSPluginRegistrationInfo info;
-  static const struct option longopt[] = {{const_cast("log"), 
required_argument, NULL, 'l'},
-  {const_cast("config"), 
required_argument, NULL, 'c'},
-  {NULL, no_argument, NULL, '\0'}};
+  static const struct option longopt[] = {
+{"log", required_argument, NULL, 'l'}, {"config", required_argument, 
NULL, 'c'}, {NULL, no_argument, NULL, '\0'}};
--- End diff --

Solaris again :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1110: TS-4971: Change TSPluginRegistration to be...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534541
  
--- Diff: plugins/esi/esi.cc ---
@@ -1599,12 +1599,9 @@ esiPluginInit(int argc, const char *argv[], struct 
OptionInfo *pOptionInfo)
   if (argc > 1) {
 int c;
 static const struct option longopts[] = {
-  {const_cast("packed-node-support"), no_argument, NULL, 'n'},
-  {const_cast("private-response"), no_argument, NULL, 'p'},
-  {const_cast("disable-gzip-output"), no_argument, NULL, 'z'},
-  {const_cast("first-byte-flush"), no_argument, NULL, 'b'},
-  {const_cast("handler-filename"), required_argument, NULL, 
'f'},
-  {NULL, 0, NULL, 0},
+  {"packed-node-support", no_argument, NULL, 'n'},
{"private-response", no_argument, NULL, 'p'},
+  {"disable-gzip-output", no_argument, NULL, 'z'},
{"first-byte-flush", no_argument, NULL, 'b'},
+  {"handler-filename", required_argument, NULL, 'f'}, {NULL, 0, NULL, 
0},
--- End diff --

Solaris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1110: TS-4971: Change TSPluginRegistration to be...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534567
  
--- Diff: plugins/esi/fetcher/HttpDataFetcherImpl.cc ---
@@ -80,7 +80,7 @@ HttpDataFetcherImpl::addFetchRequest(const string , 
FetchedDataProcessor *ca
   if (length < (int)sizeof(buff)) {
 http_req = buff;
   } else {
-http_req = (char *)malloc(length + 1);
+http_req = static_cast(malloc(length + 1));
--- End diff --

I'm not convinced by ``static_cast`` on ``malloc()``. It does nothing but 
look uglier. It would be better not to include so many different changes in 
this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1110: TS-4971: Change TSPluginRegistration to be...

[jpeach]

Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1110#discussion_r83534526
  
--- Diff: plugins/authproxy/authproxy.cc ---
@@ -682,10 +682,10 @@ AuthParseOptions(int argc, const char **argv)
   // on some platforms (e.g. Solaris / Illumos). On sane platforms (e.g. 
linux), it'll get
   // automatically casted back to the const char*, as the struct is 
defined in .
   static const struct option longopt[] = {
-{const_cast("auth-host"), required_argument, 0, 'h'},
-{const_cast("auth-port"), required_argument, 0, 'p'},
-{const_cast("auth-transform"), required_argument, 0, 't'},
-{const_cast("force-cacheability"), no_argument, 0, 'c'},
+{"auth-host", required_argument, 0, 'h'},
+{"auth-port", required_argument, 0, 'p'},
+{"auth-transform", required_argument, 0, 't'},
+{"force-cacheability", no_argument, 0, 'c'},
--- End diff --

This change will break Solaris.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---