Re: [DISCUSS] Time for Jenkins to require Java 8 to run

[nicolas de loof]

Have just read Java 9 is postponed to 2017/07/27, give us some extra time
to look into this

2016-10-19 7:47 GMT+02:00 nicolas de loof :

> @Oleg I totally agree we need to investigate java 9 support  - for your
> information, jenkins doesn't boot on java9+jigsaw, see
> https://github.com/x-stream/xstream/issues/74
>
>
>
> 2016-10-18 23:42 GMT+02:00 Oleg Nenashev :
>
>> Weak -1 regarding JDK8, but the opinion is not that strong.
>> I'm pretty sure that now it will be a pretty big problem for low-end
>> platfroms like Embedded Systems with hand-made OpenJDK builds.
>>
>> We should rather consider investing into Java 9 Early Access IMHO. People
>> will likely start submitting issues soon, and we may have serious issues
>> with upgrade of our old lib forks
>>
>> BR, Oleg
>>
>> суббота, 15 октября 2016 г., 19:57:49 UTC+2 пользователь Kanstantsin
>> Shautsou написал:
>>>
>>> ROR
>>>
>>> 2016-10-15 21:21 GMT+04:00 Arnaud Héritier :
>>>
 FYI PR#66 I would like to apply Olivier's comment before applying it
 and PR#66 daniel's comment.


 Le samedi 15 octobre 2016, Arnaud Héritier  a
 écrit :

> I was supposed to work on it yesterday but I had a problem at home and
> I had to stop to work early. There are 2 PRs I would like to finalize
> before the release. I hope to do it tomorrow evening or at the later on
> Monday. I don't know if Olivier had some others todo ?
>
> Le samedi 15 octobre 2016, Kanstantsin Shautsou <
> kanstantsin@gmail.com> a écrit :
>
>> I have no stacktrace and test case as we replaced guice to released
>> version in our custom build. Will do of course when get again, but PR in
>> core is blocked only by maven-plugin release.
>>
>> --
>> You received this message because you are subscribed to the Google
>> Groups "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it,
>> send an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/d71732a5-c11
>> 8-446d-a1d1-01438ce3e3bd%40googlegroups.com
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
> --
> -
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>
>

 --
 -
 Arnaud Héritier
 http://aheritier.net
 Mail/GTalk: aheritier AT gmail DOT com
 Twitter/Skype : aheritier

 --
 You received this message because you are subscribed to a topic in the
 Google Groups "Jenkins Developers" group.
 To unsubscribe from this topic, visit https://groups.google.com/d/to
 pic/jenkinsci-dev/fo5nKLhZK5U/unsubscribe.
 To unsubscribe from this group and all its topics, send an email to
 jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit https://groups.google.com/d/ms
 gid/jenkinsci-dev/CAFNCU-8XUYxeQ-fardYEBoEy1zPOxWn%2B2HYhPbH
 4XMYqqxjQ3w%40mail.gmail.com
 
 .

 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/10beaf2b-6b64-4b7b-8c35-9ef100014bda%40googlegroups.com
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJzmSdi%2BPZuHF7Jdu5ZQRHSNNGzSLChkzPosvVjzpo45-zQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [DISCUSS] Time for Jenkins to require Java 8 to run

[nicolas de loof]

@Oleg I totally agree we need to investigate java 9 support  - for your
information, jenkins doesn't boot on java9+jigsaw, see
https://github.com/x-stream/xstream/issues/74



2016-10-18 23:42 GMT+02:00 Oleg Nenashev :

> Weak -1 regarding JDK8, but the opinion is not that strong.
> I'm pretty sure that now it will be a pretty big problem for low-end
> platfroms like Embedded Systems with hand-made OpenJDK builds.
>
> We should rather consider investing into Java 9 Early Access IMHO. People
> will likely start submitting issues soon, and we may have serious issues
> with upgrade of our old lib forks
>
> BR, Oleg
>
> суббота, 15 октября 2016 г., 19:57:49 UTC+2 пользователь Kanstantsin
> Shautsou написал:
>>
>> ROR
>>
>> 2016-10-15 21:21 GMT+04:00 Arnaud Héritier :
>>
>>> FYI PR#66 I would like to apply Olivier's comment before applying it and
>>> PR#66 daniel's comment.
>>>
>>>
>>> Le samedi 15 octobre 2016, Arnaud Héritier  a écrit :
>>>
 I was supposed to work on it yesterday but I had a problem at home and
 I had to stop to work early. There are 2 PRs I would like to finalize
 before the release. I hope to do it tomorrow evening or at the later on
 Monday. I don't know if Olivier had some others todo ?

 Le samedi 15 octobre 2016, Kanstantsin Shautsou <
 kanstantsin@gmail.com> a écrit :

> I have no stacktrace and test case as we replaced guice to released
> version in our custom build. Will do of course when get again, but PR in
> core is blocked only by maven-plugin release.
>
> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/d71732a5-c11
> 8-446d-a1d1-01438ce3e3bd%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>


 --
 -
 Arnaud Héritier
 http://aheritier.net
 Mail/GTalk: aheritier AT gmail DOT com
 Twitter/Skype : aheritier


>>>
>>> --
>>> -
>>> Arnaud Héritier
>>> http://aheritier.net
>>> Mail/GTalk: aheritier AT gmail DOT com
>>> Twitter/Skype : aheritier
>>>
>>> --
>>> You received this message because you are subscribed to a topic in the
>>> Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit https://groups.google.com/d/to
>>> pic/jenkinsci-dev/fo5nKLhZK5U/unsubscribe.
>>> To unsubscribe from this group and all its topics, send an email to
>>> jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit https://groups.google.com/d/ms
>>> gid/jenkinsci-dev/CAFNCU-8XUYxeQ-fardYEBoEy1zPOxWn%2B2HYhPbH
>>> 4XMYqqxjQ3w%40mail.gmail.com
>>> 
>>> .
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/10beaf2b-6b64-4b7b-8c35-9ef100014bda%
> 40googlegroups.com
> 
> .
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANMVJz%3DuLYo4tgfG42QeHS4foYZSyobb5NgwVSj_2guuSJ2zzQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Surya Gaddipati]

>. Adding a one-off method which is not in general 
safe to call would just make a compatible transition harder. 

ok yea this  sounds  like a reasonable concern. 
I would be glad to help with lock-free queue implementation  which would be 
ideal for  1 computer <=> 1 build  type of situation. 

On Monday, October 17, 2016 at 9:53:23 AM UTC-5, Surya Gaddipati wrote:
>
> Hi all, 
>
> I am working on  plugin 
>  that 
> creates a single use computer/node whose lifecycle is tied to a single 
> build .  I am currently adding the node like this 
>
> Jenkins.getInstance().addNode(node); 
>
>
> However that method requires multiple Queue locks while doing so. 
>
>
> I believe in my particular case there is no need for queue locking since 
> only a single build can ever be scheduled on the computer via 
> LabelAssignmentAction. 
>
> I wanted to check ,
>
> 1. if that assumption is correct
>
> 2. If the team is open to accepting a patch to jenkins.instance for  a new 
> method which adds a node without the Queue lock. 
>
>
> Thank you.
>
>
> --Surya
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/e11a97dc-a149-43ca-af52-f8799f1233ba%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [DISCUSS] Time for Jenkins to require Java 8 to run

[Oleg Nenashev]

Weak -1 regarding JDK8, but the opinion is not that strong.
I'm pretty sure that now it will be a pretty big problem for low-end 
platfroms like Embedded Systems with hand-made OpenJDK builds. 

We should rather consider investing into Java 9 Early Access IMHO. People 
will likely start submitting issues soon, and we may have serious issues 
with upgrade of our old lib forks

BR, Oleg

суббота, 15 октября 2016 г., 19:57:49 UTC+2 пользователь Kanstantsin 
Shautsou написал:
>
> ROR
>
> 2016-10-15 21:21 GMT+04:00 Arnaud Héritier  >:
>
>> FYI PR#66 I would like to apply Olivier's comment before applying it and 
>> PR#66 daniel's comment. 
>>
>>
>> Le samedi 15 octobre 2016, Arnaud Héritier > > a écrit :
>>
>>> I was supposed to work on it yesterday but I had a problem at home and I 
>>> had to stop to work early. There are 2 PRs I would like to finalize before 
>>> the release. I hope to do it tomorrow evening or at the later on Monday. I 
>>> don't know if Olivier had some others todo ?
>>>
>>> Le samedi 15 octobre 2016, Kanstantsin Shautsou <
>>> kanstantsin@gmail.com> a écrit :
>>>
 I have no stacktrace and test case as we replaced guice to released 
 version in our custom build. Will do of course when get again, but PR in 
 core is blocked only by maven-plugin release.

 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkinsci-dev+unsubscr...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/d71732a5-c118-446d-a1d1-01438ce3e3bd%40googlegroups.com
  
 
 .
 For more options, visit https://groups.google.com/d/optout.

>>>
>>>
>>> -- 
>>> -
>>> Arnaud Héritier
>>> http://aheritier.net
>>> Mail/GTalk: aheritier AT gmail DOT com
>>> Twitter/Skype : aheritier
>>>
>>>
>>
>> -- 
>> -
>> Arnaud Héritier
>> http://aheritier.net
>> Mail/GTalk: aheritier AT gmail DOT com
>> Twitter/Skype : aheritier
>>
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "Jenkins Developers" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/jenkinsci-dev/fo5nKLhZK5U/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> jenkinsci-de...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/CAFNCU-8XUYxeQ-fardYEBoEy1zPOxWn%2B2HYhPbH4XMYqqxjQ3w%40mail.gmail.com
>>  
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/10beaf2b-6b64-4b7b-8c35-9ef100014bda%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Updating to remoting 3 in the core

[Oleg Nenashev]

We are ready to merge https://github.com/jenkinsci/jenkins/pull/2492.
Is somebody has any concerns, please shout ASAP

четверг, 13 октября 2016 г., 10:52:55 UTC+2 пользователь Arnaud Héritier 
написал:
>
> +1
>
> On Thu, Oct 13, 2016 at 8:25 AM, Oleg Nenashev  > wrote:
>
>> Hello,
>>
>> For your information, we are going to release a new major version of 
>> remoting (remoting 3). This version provides a new JNLP4 protocol, which 
>> adds support of Java NIO and improves stability being compared to the JNLP3 
>> protocol. 
>>
>> Due to the change implementation, it requires some *formally* 
>> incompatible changes in the remoting lib and the core. The change required 
>> deletion of the JnlpServerHandshake class and rework of its 
>> implementation (PR to the core 
>> ). De-facto we 
>> were unable to find any usages of such API. 
>>
>> Another important change is the explicit Java 7 requirement. We do not 
>> support Java 6 on slaves/agents starting from the 1.610 release (
>> Announcement ), but 
>> de-facto remoting users were still able to use this Java version and latest 
>> remoting versions in particular edge cases.
>>
>> Today at the Jenkins governance meeting 
>> 
>>  
>> we decided that these formally incompatible changes are not blockers for 
>> including it into Jenkins 2.x.
>>
>> As a remoting maintainer, I would like to include JNLP4 into Jenkins core 
>> as soon as possible since remoting 3 has some known stability issues. 
>> Inclusion into Weeklys allows to get better soak testing before the change 
>> actually gets into the next LTS baselines. Newest Jenkins core versions 
>> include UI for managing the new protocol, hence users will be able to 
>> opt-in and opt-out. Jenkins agents with remoting 2.x will be able to 
>> connect to Jenkins master with remoting 3.x, hence the update should be 
>> smooth.
>>
>> Please respond if you have any concerns regarding the approach.
>>
>> Best regards,
>> Oleg Nenashev
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/a8f1c019-63c0-4cfd-b443-33a3fe476b96%40googlegroups.com
>>  
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> -- 
> -
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/56956b28-a727-4d60-b5da-565a911da598%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Jesse Glick]

On Tue, Oct 18, 2016 at 12:10 PM, Surya Gaddipati
 wrote:
> neither concerrentmodificationexception nor scheduling
> on zombie node are applicable here .

If you are bypassing a lock, a CME seems like a risk.

> a patch to core that adds nodes to jenkins
> without unnecessary queue locking.

Sounds like the wrong approach to me. For the short term Stephen’s advice was

> For now, use the queue lock methods, when we remove the need for a lock they 
> will become no-ops that the JVM will inline away for plugins compiled against 
> current cores

The real fix would be to bypass `Queue` altogether for these cases and
inline all the launching and remoting into the lifecycle of the build
itself. The main issue is that there are some places in Jenkins core
where it is assumed that a valid `Node`/`Computer` is also in the
global lists, which is not something you want here. You can create a
`FilePath` and `Launcher` not tied to a `Node` or `Computer`, but that
is also poorly supported in various places. So I think a larger
redesign is necessary. Adding a one-off method which is not in general
safe to call would just make a compatible transition harder.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr21MKnN3sBY6j%3DkrvSWOfCt6Mrk23Y6TW-tK-65hUqf8g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Surya Gaddipati]

>thus encapsulated the API calls you are struggling with.

Oh yea I remember seeing that somewhere too. I remember seeing a commit on 
jenkins core for this too. 


But thats not the issue I am talking about here. 

Let me summarize this discussion,  

Jenkins.getInstance().addNode(node);


This code locks the queue. Locking the queue for adding single-use node is 
not necessary.  I am still not clear what Stephen is inferring with 
''issues start cropping up' , neither concerrentmodificationexception nor 
scheduling on zombie node are applicable here .

I am asking if you'd accept a patch to core that adds nodes to 
jenkins without unnecessary queue locking. 


-- Surya





On Tuesday, October 18, 2016 at 10:20:06 AM UTC-5, Jesse Glick wrote:
>
> On Mon, Oct 17, 2016 at 5:47 PM, Surya Gaddipati 
>  wrote: 
> > yes like that, there are a couple of differences 
>
> IIRC there was a more abstract plugin which purported to provide an 
> API to allocate a node for the duration of one build only, and which 
> thus encapsulated the API calls you are struggling with. I do not 
> recall offhand where it is. @Nicolas? 
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/76a7fd8f-25d8-4a60-8a86-2936ce59c4db%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Replacment for getBuilders()

[Jesse Glick]

On Tue, Oct 18, 2016 at 9:20 AM,   wrote:
> Has anyone found nice workaround which doesn't involve ugly parameter
> passing?

What exactly needs to be worked around? Each step should be
self-contained. If it needs to be told where to look for files, tell
it.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr2b8NRbFFobhePX3NQJyyYop5C%3Dau1JFd0AWzAn7%2BWZtQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Jesse Glick]

On Mon, Oct 17, 2016 at 5:47 PM, Surya Gaddipati
 wrote:
> yes like that, there are a couple of differences

IIRC there was a more abstract plugin which purported to provide an
API to allocate a node for the duration of one build only, and which
thus encapsulated the API calls you are struggling with. I do not
recall offhand where it is. @Nicolas?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3g_XUX496%3DLyTBY3VMe3r28ndrDV3chqUC%2BNzAYmKJQw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Release Plugin-Errors

[Jesse Glick]

On Fri, Aug 19, 2016 at 5:02 AM, Robert Sandell  wrote:
> Could it be because you have no javadoc?
>
> [ERROR] javadoc: error - No public or protected classes found to document.

No, this error would mean there are no sources at all, or they are all
paclage-private. Either way, that seems an impossible situation since
a plugin with no `public` classes cannot do anything.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr0n6ZsOH5M9PY7dbVofAd1s08UmJfh%2BxJa52mo9MxuUug%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: fetching nodes from chefserver

[Daniel Beck]

> On 18.10.2016, at 16:46, Lavanya pujari  wrote:
> 
> I am working on integrating jenkins with chef.

Not a question for the Jenkins developers list.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6DAC5215-661E-4A6E-A2D3-C66DF6EC8583%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

fetching nodes from chefserver

[Lavanya pujari]

I am working on integrating jenkins with chef. So Inorder to communicate I 
need to fetch the nodes from chef server where I am able to establish 
connection between these two. How can I fetch the nodes?

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/875b21cf-6ff0-49f5-9d86-3a3428f7552d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Quoting ArgumentListBuilder addQuoted(""). Fails to run on unix.

[Joseph P]

Issue created https://issues.jenkins-ci.org/browse/JENKINS-39066

Den mandag den 17. oktober 2016 kl. 20.38.56 UTC+2 skrev Joseph P:
>
> Hi
>
> I have a login command which accepts no password by "" or ''
> Command execute fine on Windows.
>
> This is how the ProcStarter gets going.
> ProcStarter starter = launcher.launch().cmds(command);
>
> The command is: /Applications/AccuRev/bin/accurev login josp ""
> Or: "C:\Program Files\AccuRev\bin\accurev.exe" login josp ""
>
> I have tried different escaping but nothing has worked.
> 7, 5, 3, 2 back slashes. backticks... single quoting. etc.
> Also tried StringEscapeUtils, even .cmdAsSingleString
>
> Any ideas would be appreciated why Java/Unix is eating my quotes.
>
> Files in question: 
>
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/cmd/Login.java
>
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/AccurevLauncher.java
>
> Best regards, Joseph.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/95f70208-81fc-47a7-aa35-1f1a8bc17924%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Replacment for getBuilders()

[fkpkot]

Hi,
In our plugin we use the getBuilders method in order to learn which 
builders were active during the build and get their working files and etc.
As far as i understand - moving to pipeline has disabled it due to design 
logic (one cannot simply know what went on during the build :) ) and  so 
I'm looking for better solution.

Has anyone found nice workaround which doesn't involve ugly parameter 
passing?

I've been thinking on simply searching for specific result files each run 
but I'm not sure its the best one.


Thanks ahead.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/660556d0-a9cc-452f-98c0-f48368bfe709%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Quoting ArgumentListBuilder addQuoted(""). Fails to run on unix.

[Joseph P]

I'd be happy to report a issue. Was thinking someone here had experience 
with escaping it properly before creating an issue.

Den tirsdag den 18. oktober 2016 kl. 13.16.00 UTC+2 skrev Daniel Beck:
>
> This is not where you report bugs. 
>
> https://wiki.jenkins-ci.org/display/JENKINS/How+to+report+an+issue 
>
> > On 17.10.2016, at 20:38, Joseph P  
> wrote: 
> > 
> > Hi 
> > 
> > I have a login command which accepts no password by "" or '' 
> > Command execute fine on Windows. 
> > 
> > This is how the ProcStarter gets going. 
> > ProcStarter starter = launcher.launch().cmds(command); 
> > 
> > The command is: /Applications/AccuRev/bin/accurev login josp "" 
> > Or: "C:\Program Files\AccuRev\bin\accurev.exe" login josp "" 
> > 
> > I have tried different escaping but nothing has worked. 
> > 7, 5, 3, 2 back slashes. backticks... single quoting. etc. 
> > Also tried StringEscapeUtils, even .cmdAsSingleString 
> > 
> > Any ideas would be appreciated why Java/Unix is eating my quotes. 
> > 
> > Files in question: 
> > 
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/cmd/Login.java
>  
> > 
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/AccurevLauncher.java
>  
> > 
> > Best regards, Joseph. 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to jenkinsci-de...@googlegroups.com . 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/a67b09dc-30b7-443b-8a12-1a0d2b81cba0%40googlegroups.com.
>  
>
> > For more options, visit https://groups.google.com/d/optout. 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/d8a2a9e7-c055-4b25-a269-986c699d5388%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Stephen Connolly]

On 18 October 2016 at 14:00, Oliver Gondža  wrote:

> On 2016-10-18 14:52, Surya Gaddipati wrote:
>
> In theory, add should be safe and only remove requiring the lock...

>>>
>> Would you be open to  accepting the following patch to jenkins core
>>
>> |
>> Jenkins.getInstance().addNodeWithoutQueueLock(node)
>>
>
> This will further expose the nasty implementation detail we failed to
> hide: scheduling will choke once nodes are manipulated.
>
> Silly question, can not make the Queue/scheduling immune to Nodes changes
> - and get rid of this abomination? The idea that different parts of
> codebase needs to be aware of this and we even rely on plugins to play nice
> to protect scheduling consistency is frighting me.
>

As I said, I have identified a paper which should enable an approach that
would give us a lock free Queue/LoadBalancer... but I have not had the time
to put effort into it.

Part of the issue here is also the queue listeners. Last time we tried to
unpick the queue locking behaviour we ended up causing regressions in the
queue listeners.

I'll raise it internally with our PM to see if they'll be ok allocating
some time for me to experiment with queue de-locking...

-Stephen


> --
> oliver
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/ms
> gid/jenkinsci-dev/4f7b6a22-047e-3911-a0bc-74638a788d5d%40gmail.com.
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMzTeqJXC28eP2BNoih14wE1NDYok-1%2B6mi7vWz%2BSPu%3DAA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Oliver Gondža]

On 2016-10-18 14:52, Surya Gaddipati wrote:


In theory, add should be safe and only remove requiring the lock...


Would you be open to  accepting the following patch to jenkins core

|
Jenkins.getInstance().addNodeWithoutQueueLock(node)


This will further expose the nasty implementation detail we failed to 
hide: scheduling will choke once nodes are manipulated.


Silly question, can not make the Queue/scheduling immune to Nodes 
changes - and get rid of this abomination? The idea that different parts 
of codebase needs to be aware of this and we even rely on plugins to 
play nice to protect scheduling consistency is frighting me.


--
oliver

--
You received this message because you are subscribed to the Google Groups "Jenkins 
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/4f7b6a22-047e-3911-a0bc-74638a788d5d%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Adding a node with Queue.withLock in Jenkins

[Surya Gaddipati]

Hi Stephen, 

I really appreciate your quick responses,

>> It's when you then end up down at 
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1525-L1526
 that 
the issues start cropping up.

I am not quite sure what you mean 'issues start cropping up' , what would 
happen?. I've walked through the code but I still don't see where 
'concurrent mod exception' could be happening, perhaps you mean something 
else? For my plugin there is no chance that build would be assigned to a 
phantom node, if you mean that.

>> In theory, add should be safe and only remove requiring the lock... 

Would you be open to  accepting the following patch to jenkins core

Jenkins.getInstance().addNodeWithoutQueueLock( node) 


Thanks again. 

Surya





-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/fe06e639-e501-4a97-ad58-74e701747733%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Violations Report for Atomiq - Code Similarity Finder and SOurce Monitor

[venkatakrishnan nagarajan]

How about displaying the HTML report files under Violation report? If yes 
> then how to configure.

But am able to display the HTML files under Post Build Actions-> Archive 
the artifacts.

Thanks

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/18769566-7c6b-42be-93e2-a89555185a8e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Release Plugin-Errors

[Daniel Beck]

> On 18.10.2016, at 11:46, lakshm...@qualesce.com wrote:
> 
> Can you please tell what is the process to follow for releasing the plugin 
> after over plugin has forked in github?
> 

https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins#HostingPlugins-Releasingtojenkinsci.org

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/D1FEBA49-74CE-4493-806C-00DB67ED9007%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Violations Report for Atomiq - Code Similarity Finder and SOurce Monitor

[Daniel Beck]

> On 18.10.2016, at 09:48, venkatakrishnan nagarajan 
>  wrote:
> 
> Hi, As am unware of java stuff, I explored python to create new plugin. I 
> havent got any hint nowhere. 

That's because it's not possible.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ADE91F11-0E9F-4EE4-82C0-2A384C781F85%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Quoting ArgumentListBuilder addQuoted(""). Fails to run on unix.

[Daniel Beck]

This is not where you report bugs.

https://wiki.jenkins-ci.org/display/JENKINS/How+to+report+an+issue

> On 17.10.2016, at 20:38, Joseph P  wrote:
> 
> Hi
> 
> I have a login command which accepts no password by "" or ''
> Command execute fine on Windows.
> 
> This is how the ProcStarter gets going.
> ProcStarter starter = launcher.launch().cmds(command);
> 
> The command is: /Applications/AccuRev/bin/accurev login josp ""
> Or: "C:\Program Files\AccuRev\bin\accurev.exe" login josp ""
> 
> I have tried different escaping but nothing has worked.
> 7, 5, 3, 2 back slashes. backticks... single quoting. etc.
> Also tried StringEscapeUtils, even .cmdAsSingleString
> 
> Any ideas would be appreciated why Java/Unix is eating my quotes.
> 
> Files in question: 
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/cmd/Login.java
> https://github.com/jenkinsci/accurev-plugin/blob/FixEmptyPassword/src/main/java/hudson/plugins/accurev/AccurevLauncher.java
> 
> Best regards, Joseph.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/a67b09dc-30b7-443b-8a12-1a0d2b81cba0%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/384B3112-77C5-487D-B08B-3C0AA01DC11E%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Plugin to add a custom build step.

[Daniel Beck]

> On 17.10.2016, at 20:07, Kul Bhushan Srivastava  wrote:
> 
> Please suggest.

I don't know what else is wrong. Compare what you did with the mvn hpi plugin 
archetype, it basically does exactly what you're doing, and it works.

mvn -U org.jenkins-ci.tools:maven-hpi-plugin:create

FWIW it seems insane to upload plugins you don't even know are working to 
Jenkins. Just debug them locally. You won't have to restart Tomcat then to 
apply changes.

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/21C79BD2-3319-44A1-B536-DBA9719A332F%40beckweb.net.
For more options, visit https://groups.google.com/d/optout.

Re: Release Plugin-Errors

[lakshmi . p]

Hi,

Can you please tell what is the process to follow for releasing the plugin 
after over plugin has forked in github?

On Monday, October 17, 2016 at 4:55:32 PM UTC+5:30, Daniel Beck wrote:
>
>
> > On 17.10.2016, at 11:52, laks...@qualesce.com  wrote: 
> > 
> > Can you brief me in which way javadoc is used in this plugin release. 
>
> Versions of the 2.x plugins parent POM include Javadoc generation that 
> creates a Javadoc archive as build artifact. 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/3beb9c2b-6d05-454b-af43-fa7496d4148f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Violations Report for Atomiq - Code Similarity Finder and SOurce Monitor

[venkatakrishnan nagarajan]

Hi, As am unware of java stuff, I explored python to create new plugin. I 
havent got any hint nowhere. 
Is there any possibility to display my own files like HTML/BMP/XML in 
violation report plugin?

Thanks

On Tuesday, October 4, 2016 at 4:48:09 PM UTC, Daniel Beck wrote:
>
>
> > On 04.10.2016, at 15:03, venkatakrishnan nagarajan  > wrote: 
> > 
> > For developing new plug-in, do we need editor to write java 
> code(eclipse) to start  or python? Kindly suggest the steps 
>
> There is plenty of documentation on how to get started with Jenkins plugin 
> development available in our wiki and elsewhere. Just google it. 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/7dbf27e7-ad52-4e19-9afd-0a83f5d2b059%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: maven-plugin release ready to be done

[Arnaud Héritier]

On Tue, Oct 18, 2016 at 4:01 AM, Olivier Lamy  wrote:

> Hey there,
> All done! (just a matter of upgrading the tycho version in it test as you
> may use a symlink on your machine)
>

See my comment :
https://github.com/jenkinsci/maven-plugin/commit/732877f50d1da6d733b83093afd0cd97516ce58b
We can probably just drop it ...



> New release of the so famous and so great maven integration plugin done!!
>
>
Yeah 

Thanks a lot !


>
> On 17 October 2016 at 19:20, Arnaud Héritier  wrote:
>
>> thanks a lot Olivier.
>>
>>
>> On Mon, Oct 17, 2016 at 10:18 AM, Olivier Lamy 
>> wrote:
>>
>>> Hi,
>>> A bit busy tonight.
>>> But I can have a look tomorrow 18th Oct morning (my morning :-) ).
>>>
>>>
>>>
>>>
>>> On 17 October 2016 at 10:09, Arnaud Héritier 
>>> wrote:
>>>
 Hi Olivier,

   I merged all PRs I wanted to see landing in maven-plugin 2.14
   This release is blocking a jenkins core PR to upgrade guice
 https://github.com/jenkinsci/jenkins/pull/2568
   I wanted to do it myself but I have always 2 tests failures on with
 old Tycho. It seems to come from my environment and how maven is configured

  expected: but was:
   Run 5: Maven30xBuildTest>HudsonTestCa
 se.runBare:287->HudsonTestCase.runTest:453->AbstractMaven3xB
 uildTest.testTychoTestResults:215->HudsonTestCase.buildAndAs
 sertSuccess:871->HudsonTestCase.assertBuildStatusSuccess:867
 ->HudsonTestCase.assertBuildStatusSuccess:861->HudsonTestCase.assertBuildStatus:836
 unexpected build status; build log was:

  expected: but was:
   Run 5: Maven31xBuildTest>HudsonTestCa
 se.runBare:287->HudsonTestCase.runTest:453->AbstractMaven3xB
 uildTest.testTychoTestResults:215->HudsonTestCase.buildAndAs
 sertSuccess:871->HudsonTestCase.assertBuildStatusSuccess:867
 ->HudsonTestCase.assertBuildStatusSuccess:861->HudsonTestCase.assertBuildStatus:836
 unexpected build status;

 This is coming from https://bugs.eclipse.org/
 bugs/show_bug.cgi?id=340852 (but I'm not sure to use any symbolic link)

 CI is ok https://jenkins.ci.cloudbees.com/job/plugins/job/maven-plugin/
 Wiki is up-to-date : https://wiki.jenkins-ci.org/
 display/JENKINS/Maven+Project+Plugin

 Olivier can you release it please ?

 Cheers
 --
 -
 Arnaud Héritier
 http://aheritier.net
 Mail/GTalk: aheritier AT gmail DOT com
 Twitter/Skype : aheritier

 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-dev+unsubscr...@googlegroups.com.
 To view this discussion on the web visit https://groups.google.com/d/ms
 gid/jenkinsci-dev/CAFNCU-_aEUcheninZRgHOdr4gpFsT76zEdYnxak1K
 XTLR7GJ7A%40mail.gmail.com
 
 .
 For more options, visit https://groups.google.com/d/optout.

 --
 Olivier Lamy
 http://twitter.com/olamy | http://linkedin.com/in/olamy

>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit https://groups.google.com/d/ms
>>> gid/jenkinsci-dev/CAPoyBqRJ9Go6cg0%2BfR_m_O2hnVZtKTprKx_D7xc
>>> 1euHL-icVGA%40mail.gmail.com
>>> 
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> -
>> Arnaud Héritier
>> http://aheritier.net
>> Mail/GTalk: aheritier AT gmail DOT com
>> Twitter/Skype : aheritier
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/CAFNCU-_%3D7YJZZDBZ-BmDpoLjUh4LW7nXgDvbTG0
>> FYdGSxOrMkg%40mail.gmail.com
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and 

Re: Adding a node with Queue.withLock in Jenkins

[Pavel Janousek]

On the other hand, is it really necessary to call all associated Listeners 
(like in [1].update() - L222, L236, L242) when the Queue is still locked (is it 
guaranteed and documented for a ProvisioningListener contract)? It can be a 
quite time spent operation/call...

[1] 
https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/slaves/NodeProvisioner.java

--
Pavel Janousek
Senior Jenkins QA Engineer


- Original Message -
> From: "Stephen Connolly" 
> To: jenkinsci-dev@googlegroups.com
> Sent: Monday, October 17, 2016 11:51:10 PM
> Subject: Re: Adding a node with Queue.withLock in Jenkins
> 
> On 17 October 2016 at 22:42, Surya Gaddipati 
> wrote:
> 
> > Hi Stephen,
> >
> > Thank you for your quick response. I don't want to belabor this more than
> > it needs to be .
> >
> > >If you change the list of nodes during that time, the queue thread will
> > get a concurrent modification exception (best case) and die
> >
> > I am guessing you are referring to this line
> > 
> >
> >
> > for (Computer c : Jenkins.getInstance().getComputers())
> >
> > This is not same collection that addnode modifies, its a copy . So it
> > seems unlikely that would cause a concurrent modification exception.
> >
> >
> It's when you then end up down at
> https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/Queue.java#L1525-L1526
> that the issues start cropping up.
> 
> In theory, add should be safe and only remove requiring the lock... in
> practice we found that a lot of the cloud plugins blow up if we remove the
> add lock. If you want to remove the add lock for your Jenkins and have
> complete control over the plugins installed, you may get lucky
> 
> 
> >
> > > it will assign work to a node that no longer exists, except for a
> > phantom object reference that it held onto... or worse
> >
> > This won't happen in this specific case I am describing here since a
> > computer is tied to *one* particular build , it cannot be assigned to a
> > phantom node.
> >
> >
> > My main motivation is to remove queue locking as much as possible as  our
> > Jenkins instance has major scalability issues, almost *all* of it stemming
> > from overzealous queue locking.
> >
> >
> > > It is a long term goal to remove the queue lock
> >
> > I would love for queue.lock to go away  but do you think it realistic to
> > expect that to go away anytime soon given how deeply embedded it is into
> > the core structure of the code. eg: Here it looks like we are acquiring a
> > queue lock
> > within
> > a queue lock
> > 
> > ?
> >
> >
> >
> >
> >
> > On Monday, October 17, 2016 at 1:54:11 PM UTC-5, Stephen Connolly wrote:
> >
> >>
> >>
> >> On Monday 17 October 2016, Surya Gaddipati  wrote:
> >>
> >>> Thanks Stephen for your quick response.
> >>>
> >>> >  as otherwise the scheduling will blow up in your face.
> >>>
> >>> Curious, What do you mean by this ?
> >>>
> >>
> >> When the queue starts scheduling it has to iterate the list of nodes to
> >> build up the candidate nodes for the load balancing algorithm.
> >>
> >> If you change the list of nodes during that time, the queue thread will
> >> get a concurrent modification exception (best case) and die... or it will
> >> assign work to a node that no longer exists, except for a phantom object
> >> reference that it held onto... or worse
> >>
> >> It is a long term goal to remove the queue lock as it impacts scalability
> >> when you have 1000's of executors that can match a job... but even then
> >> the
> >> impact is not so large that removing the lock would be a priority.
> >>
> >> For now, use the queue lock methods, when we remove the need for a lock
> >> they will become no-ops that the JVM will inline away for plugins compiled
> >> against current cores
> >>
> >>
> >>> thanks again.
> >>>
> >>> On Monday, October 17, 2016 at 9:53:23 AM UTC-5, Surya Gaddipati wrote:
> 
>  Hi all,
> 
>  I am working on  plugin
>   that
>  creates a single use computer/node whose lifecycle is tied to a single
>  build .  I am currently adding the node like this
> 
>  Jenkins.getInstance().addNode(node);
> 
> 
>  However that method requires multiple Queue locks while doing so.
> 
> 
>  I believe in my particular case there is no need for queue locking
>  since only a single build can ever be scheduled on the computer via
>  LabelAssignmentAction.
> 
>  I wanted to check ,
> 
>  1. if that assumption is correct
> 
>  2. If the team is open to