Re: Splitting kde-workspace and kde-runtime proposal
Hello! On Tue, Jan 21, 2014 at 3:35 PM, Antonis Tsiapaliokas kok...@gmail.com wrote: I think that splitting each individual component to its own repo might be a bit confusing. Because if we don't have two groups (plasma-desktop and plasma- workspace), then we will not be able to provide something as a standard solution. So each person will consider Plasma Desktop as something entirely different. Yes having group is essential, otherwise it will create confusion.. repo like kde:kf5umbrella will be also needed. Thanks! -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- Review request for KDE Frameworks. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/ --- (Updated Jan. 21, 2014, 11:12 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: knotifications Description --- Fix non-X11 implementation of KPassivePopup placement Diffs - src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d tests/kpassivepopuptest.h bc0dedc71b4bef8dbc5c89b79c82fb920929cced Diff: https://git.reviewboard.kde.org/r/115147/diff/ Testing --- Builds when I comment out find_package(X11) in the CMakeLists.txt file. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup
On Jan. 21, 2014, 6:42 a.m., Martin Gräßlin wrote:
src/kpassivepopup.cpp, lines 466-467
https://git.reviewboard.kde.org/r/115157/diff/1/?file=234862#file234862line466
small suggestion:
if (QWidget *widget = QWidget::find(d-window)) {
...
}
I have a strong dislike of assignments in if conditions...
- Alex
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115157/#review47854
---
On Jan. 20, 2014, 5:58 p.m., Alex Merry wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115157/
---
(Updated Jan. 20, 2014, 5:58 p.m.)
Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka.
Repository: knotifications
Description
---
This is an alternative approach to https://git.reviewboard.kde.org/r/115147/
where we avoid doing the cross platform support ourselves, and instead depend
on KWindowSystem.
Downsides: it looks like the implementations for KWindowInfo::geometry() and
KWindowInfo::frameGeometry are the wrong way round on windows, and they are
not implemented at all on Mac. However, the code we had here was never
tested either, so...
Make better use of KWindowSystem in KPassivePopup
This avoids having code that is compiled on non-X11 platforms but not on
X11 (the old non-X11 code did not compile).
Diffs
-
CMakeLists.txt 022cbcb7a12aa5ad9843019ffd73f1b3e117fb9b
src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d
tests/CMakeLists.txt c7481362008e3cae10d0afcfbcaea5fe953ce62d
tests/kpassivepopuptest.cpp f457aed7e57904bcc00462a947bc5eaae7208792
Diff: https://git.reviewboard.kde.org/r/115157/diff/
Testing
---
Compiles and tests work when X11 is found. Compiles and tests do as well as
expected (ie: popups are placed next to the window instead of the taskbar
entry) when X11 is not found (specifically by commenting out
find_package(X11)).
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: ktexteditor_master_qt5 #86
See http://build.kde.org/job/ktexteditor_master_qt5/86/ -- [...truncated 340 lines...] Removing autotests/input/indent/pascal/longtest3/actual Removing autotests/input/indent/pascal/longtest4/actual Removing autotests/input/indent/pascal/openpar1/actual Removing autotests/input/indent/pascal/openpar2/actual Removing autotests/input/indent/pascal/prep1/actual Removing autotests/input/indent/pascal/trig1/actual Removing autotests/input/indent/python/dedentBreak/actual Removing autotests/input/indent/python/dedentComment/actual Removing autotests/input/indent/python/dedentContinue/actual Removing autotests/input/indent/python/dedentPass/actual Removing autotests/input/indent/python/dedentRaise/actual Removing autotests/input/indent/python/dedentReturn/actual Removing autotests/input/indent/python/dedentReturn2/actual Removing autotests/input/indent/python/dedentReturn3/actual Removing autotests/input/indent/python/dict1/actual Removing autotests/input/indent/python/dict2/actual Removing autotests/input/indent/python/function_args/actual Removing autotests/input/indent/python/indentColon/actual Removing autotests/input/indent/python/indentComment/actual Removing autotests/input/indent/python/keepIndent1/actual Removing autotests/input/indent/python/keepIndent2/actual Removing autotests/input/indent/python/keepIndent3/actual Removing autotests/input/indent/python/keepIndent4/actual Removing autotests/input/indent/python/list1/actual Removing autotests/input/indent/python/list2/actual Removing autotests/input/indent/python/tuple1/actual Removing autotests/input/indent/python/tuple2/actual Removing autotests/input/indent/python/wrapped_line/actual Removing autotests/input/indent/ruby/array-comment1/actual Removing autotests/input/indent/ruby/array-comment2/actual Removing autotests/input/indent/ruby/array-comment3/actual Removing autotests/input/indent/ruby/array-comment4/actual Removing autotests/input/indent/ruby/array-comment5/actual Removing autotests/input/indent/ruby/array1/actual Removing autotests/input/indent/ruby/array10/actual Removing autotests/input/indent/ruby/array11/actual Removing autotests/input/indent/ruby/array12/actual Removing autotests/input/indent/ruby/array16/actual Removing autotests/input/indent/ruby/array17/actual Removing autotests/input/indent/ruby/array18/actual Removing autotests/input/indent/ruby/array19/actual Removing autotests/input/indent/ruby/array2/actual Removing autotests/input/indent/ruby/array20/actual Removing autotests/input/indent/ruby/array21/actual Removing autotests/input/indent/ruby/array22/actual Removing autotests/input/indent/ruby/array3/actual Removing autotests/input/indent/ruby/array4/actual Removing autotests/input/indent/ruby/array5/actual Removing autotests/input/indent/ruby/array6/actual Removing autotests/input/indent/ruby/array7/actual Removing autotests/input/indent/ruby/array8/actual Removing autotests/input/indent/ruby/array9/actual Removing autotests/input/indent/ruby/basic1/actual Removing autotests/input/indent/ruby/basic2/actual Removing autotests/input/indent/ruby/basic3/actual Removing autotests/input/indent/ruby/basic4/actual Removing autotests/input/indent/ruby/block-comment1/actual Removing autotests/input/indent/ruby/block-comment2/actual Removing autotests/input/indent/ruby/block-comment3/actual Removing autotests/input/indent/ruby/block-comment4/actual Removing autotests/input/indent/ruby/block-comment5/actual Removing autotests/input/indent/ruby/block-comment6/actual Removing autotests/input/indent/ruby/block-comment7/actual Removing autotests/input/indent/ruby/block-comment8/actual Removing autotests/input/indent/ruby/block01/actual Removing autotests/input/indent/ruby/block02/actual Removing autotests/input/indent/ruby/comment1/actual Removing autotests/input/indent/ruby/comment2/actual Removing autotests/input/indent/ruby/comment3/actual Removing autotests/input/indent/ruby/comment4/actual Removing autotests/input/indent/ruby/comment5/actual Removing autotests/input/indent/ruby/comment6/actual Removing autotests/input/indent/ruby/do1/actual Removing autotests/input/indent/ruby/do2/actual Removing autotests/input/indent/ruby/do3/actual Removing autotests/input/indent/ruby/do4/actual Removing autotests/input/indent/ruby/do5/actual Removing autotests/input/indent/ruby/do6/actual Removing autotests/input/indent/ruby/do7/actual Removing autotests/input/indent/ruby/empty-file1/actual Removing autotests/input/indent/ruby/hash1/actual Removing autotests/input/indent/ruby/hash10/actual Removing autotests/input/indent/ruby/hash11/actual Removing autotests/input/indent/ruby/hash12/actual Removing autotests/input/indent/ruby/hash16/actual Removing autotests/input/indent/ruby/hash17/actual Removing autotests/input/indent/ruby/hash18/actual Removing autotests/input/indent/ruby/hash19/actual Removing autotests/input/indent/ruby/hash2/actual Removing autotests/input/indent/ruby/hash20/actual Removing
Jenkins build is back to normal : ktexteditor_master_qt5 #87
See http://build.kde.org/job/ktexteditor_master_qt5/87/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47860 --- Ship it! Ship It! - Martin Gräßlin On Jan. 20, 2014, 6:58 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- (Updated Jan. 20, 2014, 6:58 p.m.) Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka. Repository: knotifications Description --- This is an alternative approach to https://git.reviewboard.kde.org/r/115147/ where we avoid doing the cross platform support ourselves, and instead depend on KWindowSystem. Downsides: it looks like the implementations for KWindowInfo::geometry() and KWindowInfo::frameGeometry are the wrong way round on windows, and they are not implemented at all on Mac. However, the code we had here was never tested either, so... Make better use of KWindowSystem in KPassivePopup This avoids having code that is compiled on non-X11 platforms but not on X11 (the old non-X11 code did not compile). Diffs - CMakeLists.txt 022cbcb7a12aa5ad9843019ffd73f1b3e117fb9b src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d tests/CMakeLists.txt c7481362008e3cae10d0afcfbcaea5fe953ce62d tests/kpassivepopuptest.cpp f457aed7e57904bcc00462a947bc5eaae7208792 Diff: https://git.reviewboard.kde.org/r/115157/diff/ Testing --- Compiles and tests work when X11 is found. Compiles and tests do as well as expected (ie: popups are placed next to the window instead of the taskbar entry) when X11 is not found (specifically by commenting out find_package(X11)). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Splitting kde-workspace and kde-runtime proposal
On Tuesday, January 21, 2014 11:03:57 Bhushan Shah wrote: On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas afies...@kde.org wrote: In the plasma sprint we have done a session to plan what we are going to do with kde-workspace/kde-runtime repositories, here is the proposal we came with. We are going to create 2 new repos called plasma-desktop and plasma-workspace, we decided to use plasma as a prefix so in the future we can have more workspaces and desktops without being in the awkward situation of having one wrongly labeled as KDE while others are not (thinking on for example having Razorqt/lxde as part of KDE in the future). Current kde-workspace and kde- runtime will be kept for history reasons. I want to suggest something different, 1) Create two different groups named plasma-workspace and plasma-desktop like frameworks How is this granularity useful? To me, it sounds like way too much, too hard to move code around within the same domain, for example. We don't want to flood people with hundreds of repositories. The generic workspace vs. specific formfactor split is well in line with how we see people deploying Plasma, you install the framework, the generic workspace, and then a package for a specific formfactor. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47861 --- This review has been submitted with commit 096faf3d2bf7786bbc54450f884050021cf582b6 by Alex Merry to branch master. - Commit Hook On Jan. 20, 2014, 5:58 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- (Updated Jan. 20, 2014, 5:58 p.m.) Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka. Repository: knotifications Description --- This is an alternative approach to https://git.reviewboard.kde.org/r/115147/ where we avoid doing the cross platform support ourselves, and instead depend on KWindowSystem. Downsides: it looks like the implementations for KWindowInfo::geometry() and KWindowInfo::frameGeometry are the wrong way round on windows, and they are not implemented at all on Mac. However, the code we had here was never tested either, so... Make better use of KWindowSystem in KPassivePopup This avoids having code that is compiled on non-X11 platforms but not on X11 (the old non-X11 code did not compile). Diffs - CMakeLists.txt 022cbcb7a12aa5ad9843019ffd73f1b3e117fb9b src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d tests/CMakeLists.txt c7481362008e3cae10d0afcfbcaea5fe953ce62d tests/kpassivepopuptest.cpp f457aed7e57904bcc00462a947bc5eaae7208792 Diff: https://git.reviewboard.kde.org/r/115157/diff/ Testing --- Compiles and tests work when X11 is found. Compiles and tests do as well as expected (ie: popups are placed next to the window instead of the taskbar entry) when X11 is not found (specifically by commenting out find_package(X11)). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- (Updated Jan. 21, 2014, 12:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Martin Gräßlin and Michael Palimaka. Repository: knotifications Description --- This is an alternative approach to https://git.reviewboard.kde.org/r/115147/ where we avoid doing the cross platform support ourselves, and instead depend on KWindowSystem. Downsides: it looks like the implementations for KWindowInfo::geometry() and KWindowInfo::frameGeometry are the wrong way round on windows, and they are not implemented at all on Mac. However, the code we had here was never tested either, so... Make better use of KWindowSystem in KPassivePopup This avoids having code that is compiled on non-X11 platforms but not on X11 (the old non-X11 code did not compile). Diffs - CMakeLists.txt 022cbcb7a12aa5ad9843019ffd73f1b3e117fb9b src/kpassivepopup.cpp b41cb8dc8b3372346bd12c0413bf6bfa9a6fd00d tests/CMakeLists.txt c7481362008e3cae10d0afcfbcaea5fe953ce62d tests/kpassivepopuptest.cpp f457aed7e57904bcc00462a947bc5eaae7208792 Diff: https://git.reviewboard.kde.org/r/115157/diff/ Testing --- Compiles and tests work when X11 is found. Compiles and tests do as well as expected (ie: popups are placed next to the window instead of the taskbar entry) when X11 is not found (specifically by commenting out find_package(X11)). Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 5:39 p.m., Thomas Lübking wrote: and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? KF/5 would be broken then, would it not? What about having a common data package downstream? No it wouldn't be broken, it would continue to compile using the .xml files it has locally. - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47587 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 9:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 5:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 5:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ Martin Gräßlin wrote: How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? Martin Gräßlin wrote: Oh and I think review request https://git.reviewboard.kde.org/r/115079/ illustrates the problem. As the file doesn't get installed any more, we need to copy it everywhere where it's going to be used. This looks like a very sub-optimal solution. The xml file would be included in the kde-workspace source directly ( https://git.reviewboard.kde.org/r/115079/ ) - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 17, 2014, 4:07 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 17, 2014, 4:07 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - KF5GlobalAccelConfig.cmake.in 5f069d3 src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115137: Provide information about the active screen in KWindowSystem
On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: given the ratio by this property is set (often) and read (rarely), i wonder whether we could establish a semi-async functionality, where the client sends a message to have the property updated, then syncs, reads and returns the updated property? reg. screen ./. output terminology: we've active screen everywhere and we can probably not expose the screen/output problem to end users. Also Qt talks of screen in this regard. I'd suggest to keep activeScreen and specify the meaning in the comment. Martin Gräßlin wrote: i wonder whether we could establish a semi-async functionality, where the client sends a message to have the property updated, then syncs, reads and returns the updated property? That would be different to how all the other methods in KWindowSystem works. What could be considered is not having a signal to not wake up the clients or only emit the signal if connect-notify is called. Also Qt talks of screen in this regard. This was the reason why I went with screen in the first place. The class is called QScreen and not QOutput. Calling it output didn't occur to me at all. I don't mind how it is called and from a technical perspective (especially considering XRandR) I agree with Fredrik. But from a user point of view I think screen is the better name due to the QScreen anology. What could be done is using output in the NET class to be closer to the X11 world, but keep the name screen in the abstraction. I don't know whether output makes sense on Windows or Mac (in case they ever implement it). That would be different to how all the other methods in KWindowSystem works. My major concern would be the mouse driven active screen. Right now, when the active screen is required, kwin just checks the current mouse position. When we need to keep the info updated (signal or not), that means that kwin has to poll the mouse all the time (even if we would smoothen the update by a timer so the active screen isn't updated a 1000 times when moving the cursor around a screen edge). And while knowing the active screen is certainly nice, our main concern right now is the occasional raiseOrLower taskbar case. A 2-pass query would nicely circumvent this as the data only needs to be updated when really and likely rarely required. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review47824 --- On Jan. 20, 2014, 1:14 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- (Updated Jan. 20, 2014, 1:14 p.m.) Review request for KDE Frameworks, kdewin and kwin. Repository: kwindowsystem Description --- The rational for these changes is based on the discussion in http://article.gmane.org/gmane.comp.kde.devel.plasma/27579/ Plasma needs to know which is the active screen and so far only KWin knows it, so we need to make everybody aware of it. --- Add convenient wrapper for active screen to KWindowSystem A method is added to get the identifier of the active screen as a QString and a signal whenever the active screen changes. This method is only provided for X11, on Windows and Mac a null QString is returned as the identifier. Add an active screen property to NETRootInfo The active screen is intended to be set by KWin to the active screen it's using. This can be used by a Client to manually position e.g. override redirect windows on the active screen. It's intended as a help for multi-screen setups where a Client can only do guesses on where to position e.g. a notification window. It's a KDE specific extension as property _KDE_NET_ACTIVE_SCREEN and announced in the supported properties. Diffs - autotests/netrootinfotestwm.cpp 120fbee92d0b22862d8ce746b3b30891ecd9f056 src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 src/kwindowsystem_mac.cpp 8bd2ac763fa26ba49e7733fc3ba93e755383928c src/kwindowsystem_win.cpp 96148b2d808396a3046204e55fd19d767db017c5 src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 src/netwm_def.h 8b1ccb8bd731aefb9559c8f2b450337b0312ed4d src/netwm_p.h 41792b330f7405034f4d51fb31a4de5dd674b6d0 Diff: https://git.reviewboard.kde.org/r/115137/diff/ Testing --- * wm part of NETWM is unit tested * KWindowSystem is only compile tested (unit testing is difficult as we need a window manager which supports this property which is at the moment of
Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115165: Use a proper temporary file for the doxygen config
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Use a proper temporary file for the doxygen config Diffs - src/kapidox/__init__.py 554bd2412dfa8c279a78c969de765d36b51236ba Diff: https://git.reviewboard.kde.org/r/115165/diff/ Testing --- Ran kgenapidox on threadweaver with both python2 and python3. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47874 --- Ship it! Ship It! - Alex Merry On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 1:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Changes --- new tactic, rename the interface file (but keep the interface name the same) Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs (updated) - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: this would break my workflow given that I install kde4 and kf5 to different prefixes. I think this needs a different approach, but please don't ask me for it. I'm lacking ideas how we could solve this upstream. Hrvoje Senjan wrote: What about just renaming xml files? Interfaces would be left compatible, and the files would not conflict. Only it would look a bit ugly, and possibly confusing... (To my knowledge, there is no rule/spec that xml must match interface name, but that could be false ;-) Martin Tobias Holmedahl Sandsmark wrote: I think the idea is to move the xml file to kde-workspace somehow? Jonathan Riddell wrote: @Gräßlin How would it break the workflow? You can install kdelibs4 and kf5 anywhere you like and it'll still compile fine. But it won't overlap files if they are installed to the same place with these changes. @sandsmark yes the files would be moved into kde-workspace, see patch in https://git.reviewboard.kde.org/r/115079/ Martin Gräßlin wrote: How is a setup going to find the xml file to generate an interface from if it doesn't get installed? A true KF5 setup shouldn't pick anything from kdelibs4. By not installing it, things depending on it will be broken. Or am I missing something? Martin Gräßlin wrote: Oh and I think review request https://git.reviewboard.kde.org/r/115079/ illustrates the problem. As the file doesn't get installed any more, we need to copy it everywhere where it's going to be used. This looks like a very sub-optimal solution. Jonathan Riddell wrote: The xml file would be included in the kde-workspace source directly ( https://git.reviewboard.kde.org/r/115079/ ) New patch follows Hrvoje Senjan's suggestion to rename the interface file but keep the interface name the same - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47614 --- On Jan. 21, 2014, 2:49 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- Note that I fixed the build failure with kdesrc-build differently - I added a ignore-modules kapidox in kdesrc-build's include files. And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here). - David Faure On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 1:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47879 --- I like this approach better (though I don't know whether that's causing problems on the DBus side). Maybe we could keep the files as they are and just rename at install? - Martin Gräßlin On Jan. 21, 2014, 3:49 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:49 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/org.kde.kglobalaccel.Component.xml ec21201 src/org.kde.KGlobalAccel.xml 8746551 src/kf5_org.kde.kglobalaccel.Component.xml PRE-CREATION src/kf5_org.kde.KGlobalAccel.xml PRE-CREATION src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 2:55 p.m., Martin Gräßlin wrote: I like this approach better (though I don't know whether that's causing problems on the DBus side). Maybe we could keep the files as they are and just rename at install? new patch attached - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47879 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- something went wrong with the latest patch. CMake looks fine but it includes the renamed files. - Martin Gräßlin On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Changes --- rename file only at install time Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs (updated) - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47887 --- Ship it! Ship It! - Martin Gräßlin On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 4:16 p.m., Martin Gräßlin wrote: something went wrong with the latest patch. CMake looks fine but it includes the renamed files. Jonathan Riddell wrote: Maybe I'm going mad but I don't see any renamed files in it. Here's the same patch in a pastebin http://paste.ubuntu.com/6792111/ I blame review board. It showed me the new CMakeLists.txt but still the renamed files... Now it works. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- On Jan. 21, 2014, 4:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 3:16 p.m., Martin Gräßlin wrote: something went wrong with the latest patch. CMake looks fine but it includes the renamed files. Maybe I'm going mad but I don't see any renamed files in it. Here's the same patch in a pastebin http://paste.ubuntu.com/6792111/ - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2014-w4
Hello everyone, This is the minutes of the Week 3 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, arichardson, dfaure, mgraesslin, Riddell, tosky and myself. Announcement: * Come on people, we're still short on maintainers! * Aiming at a frameworks sprint somewhen in spring; * Don't forget that Alpha 1 is due for release next week; * afiestas signed up for maintaining kded; * he also wrote a proposal to split runtime and workspace: http://community.kde.org/Plasma/Tokamak7/split_proposal * agateau fixed ki18n so that tests would work without install; * he also worked on integrating kf5dot in kapidox; * he also created a todo list for the doc of the frameworks and the tooling; * alexmerry got the apidox script working; * he is about to remove all the Mainpage.dox files as the script won't need them (preserving useful content of course); * he's also working with ben to get the necessary deps on ebn to run the script; * he's also working on reducing the KDE stuff in ECM; * arichardson got almost all of KF5 building on windows, patches to follow; * he got to the point where okteta is running on windows: http://postimg.org/image/51gwpoxpf ; * dfaure is focusing on generating .pri files for qmake users; * he needs a review on https://git.reviewboard.kde.org/r/115099/ ; * he also started to fix kcrash use of command line options; * mgraesslin took over maintainership of kwindowsystem and kglobalaccel; * he's working on KWindowInfo unit tests; * he also plans to transform the classes to give them runtime platform detection for wayland; * he'll need help from windows and mac people if they don't want their implementations to break; * Riddell is working on coinstallability, especially around dbus interfaces; * he's also close of having tier 2 fully packaged, some parts of tier 3 being done already; * tosky found out that the validity of the qtoptions and kdeoptions man pages is in need of review; * he's also working with the doc team toward a switch to docbook 4.2; * ervin got a few more maintainers, still some positions open; * he also contacted afiestas for a sprint in Barcelona. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2014-w4
On Tuesday 21 of January 2014 16:42:42 Kevin Ottens wrote: * tosky found out that the validity of the qtoptions and kdeoptions man pages is in need of review; * he's also working with the doc team toward a switch to docbook 4.2; Quick patch: to docbook 4.5 (our documentation is based on 4.2 now). Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
On Jan. 21, 2014, 3:23 p.m., Martin Gräßlin wrote: Ship It! Many thanks to Jonathan for working on this, and Martin for giving a green light! ;-) - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47887 --- On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
On Jan. 21, 2014, 2:57 p.m., David Faure wrote: Note that I fixed the build failure with kdesrc-build differently - I added a ignore-modules kapidox in kdesrc-build's include files. And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here). You can't really avoid that with Python packages; you can install them with --user and make sure your PATH is set correctly, or you can install them with a prefix and make sure your PYTHONPATH is set correctly (or there are a couple of other ways of telling python about custom site package dirs). Well, or you can install them in a standard location, such as for distro packages. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 1:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
On Jan. 21, 2014, 3:57 p.m., David Faure wrote: Note that I fixed the build failure with kdesrc-build differently - I added a ignore-modules kapidox in kdesrc-build's include files. And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here). Alex Merry wrote: You can't really avoid that with Python packages; you can install them with --user and make sure your PATH is set correctly, or you can install them with a prefix and make sure your PYTHONPATH is set correctly (or there are a couple of other ways of telling python about custom site package dirs). Well, or you can install them in a standard location, such as for distro packages. Note that the breakage is at runtime, not install time. But since kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? That's one less piece to maintain. - Aurélien --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- On Jan. 21, 2014, 2:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47894 --- This review has been submitted with commit fc7deb7e9d7a641495729380746821dae140fb6b by Jonathan Riddell to branch master. - Commit Hook On Jan. 21, 2014, 3:10 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115078: don't install dbus interface files in kglobalaccel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 4:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Martin Gräßlin. Repository: kglobalaccel Description --- don't install dbus interface files in kglobalaccel, these overlap with the equivalent files in kdelibs4 which causes problems for some distributions Diffs - src/CMakeLists.txt d48e92e Diff: https://git.reviewboard.kde.org/r/115078/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115134: Append 5 to kjscmd it's manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47897 --- looks good, ksjcmd is just a developer binary so nothing else needs a rename to use it a couple more changes in the man page and it's good The most common way to run kjscmd is simply as The most common way to run kjscmd is simply as - Jonathan Riddell On Jan. 19, 2014, 10:57 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 19, 2014, 10:57 p.m.) Review request for KDE Frameworks. Repository: kjsembed Description --- Patch to make kjsembed not collide with kdelibs(4) when installed to same prefix. Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary has been renamed. Diffs - docs/kjscmd/CMakeLists.txt eda31bf docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION src/kjscmd/CMakeLists.txt a659f0f Diff: https://git.reviewboard.kde.org/r/115134/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115134: Append 5 to kjscmd it's manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47899 --- Ship it! Ship It! - Jonathan Riddell On Jan. 21, 2014, 4:43 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 21, 2014, 4:43 p.m.) Review request for KDE Frameworks. Repository: kjsembed Description --- Patch to make kjsembed not collide with kdelibs(4) when installed to same prefix. Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary has been renamed. Diffs - docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 docs/kjscmd/CMakeLists.txt eda31bf src/kjscmd/CMakeLists.txt a659f0f Diff: https://git.reviewboard.kde.org/r/115134/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
On Jan. 21, 2014, 2:57 p.m., David Faure wrote: Note that I fixed the build failure with kdesrc-build differently - I added a ignore-modules kapidox in kdesrc-build's include files. And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here). Alex Merry wrote: You can't really avoid that with Python packages; you can install them with --user and make sure your PATH is set correctly, or you can install them with a prefix and make sure your PYTHONPATH is set correctly (or there are a couple of other ways of telling python about custom site package dirs). Well, or you can install them in a standard location, such as for distro packages. Aurélien Gâteau wrote: Note that the breakage is at runtime, not install time. But since kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? That's one less piece to maintain. Sure; I have no opinion on it either way, TBH. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 1:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/#review47902 --- https://git.reviewboard.kde.org/r/115188/ kde-workspace update to match - Jonathan Riddell On Jan. 21, 2014, 5:02 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- (Updated Jan. 21, 2014, 5:02 p.m.) Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115185: Integrate kf5dot
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/ --- Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This big patch includes all of the kf5dot repository inside kapidox. Python code is in src/kapidox/kf5dot, scripts are in src/. I replayed all the commits from the kf5dot repository within the kapidox repository using `git am` to avoid loosing history. As such, I plan to do the merge using --no-ff. Diffs - src/kapidox/kf5dot/frameworkdb.py PRE-CREATION src/kf5dot-generate PRE-CREATION src/kf5dot-generate-all PRE-CREATION src/kf5dot-prepare PRE-CREATION README.md 660e9c3 src/kapidox/kf5dot/framework.py PRE-CREATION setup.py 025afdb src/kapidox/kf5dot/.gitignore PRE-CREATION src/kapidox/kf5dot/block.py PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115185/diff/ Testing --- Generated all diagrams. Works as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115186: rename dbus interface file for kjobviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115186/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description --- This dbus interface file also gets installed in kdelibs4 which overlaps it in kf5, some distros can not handle this. So rename the file on install. The dbus interface remains the same. This is the same technique used for kglobalaccel. Diffs - src/CMakeLists.txt 7527a0a Diff: https://git.reviewboard.kde.org/r/115186/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115134: Append 5 to kjscmd it's manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 21, 2014, 5:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kjsembed Description --- Patch to make kjsembed not collide with kdelibs(4) when installed to same prefix. Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary has been renamed. Diffs - docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 docs/kjscmd/CMakeLists.txt eda31bf src/kjscmd/CMakeLists.txt a659f0f Diff: https://git.reviewboard.kde.org/r/115134/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115185: Integrate kf5dot
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/#review47903 --- - files should have licenses and encoding marks - kf5dot is not very descriptive as a name. I would call the module dependencies or depdiags or something like that, and the scripts something similar but with a k or kf5 prefix - it would be nice if kgenframeworksapidox could do all the magic itself, when suitable option(s) are passed (although that can be something to implement later) src/kapidox/kf5dot/.gitignore https://git.reviewboard.kde.org/r/115185/#comment33912 Unnecessary; kapidox has a top-level .gitignore that already does this Another option for merging histories is http://thread.gmane.org/gmane.comp.version-control.git/5126/ (with some modifications; in particular, git-*-cache is now git-*-index). But that depends on how much you care about preserving commit shasums. In general, though, I approve :-) - Alex Merry On Jan. 21, 2014, 4:58 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115185/ --- (Updated Jan. 21, 2014, 4:58 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kapidox Description --- This big patch includes all of the kf5dot repository inside kapidox. Python code is in src/kapidox/kf5dot, scripts are in src/. I replayed all the commits from the kf5dot repository within the kapidox repository using `git am` to avoid loosing history. As such, I plan to do the merge using --no-ff. Diffs - src/kapidox/kf5dot/frameworkdb.py PRE-CREATION src/kf5dot-generate PRE-CREATION src/kf5dot-generate-all PRE-CREATION src/kf5dot-prepare PRE-CREATION README.md 660e9c3 src/kapidox/kf5dot/framework.py PRE-CREATION setup.py 025afdb src/kapidox/kf5dot/.gitignore PRE-CREATION src/kapidox/kf5dot/block.py PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115185/diff/ Testing --- Generated all diagrams. Works as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115134: Append 5 to kjscmd it's manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/#review47905 --- This review has been submitted with commit a310819d576e267e54bd5c965eeda78afb87ed9b by Hrvoje Senjan to branch master. - Commit Hook On Jan. 21, 2014, 4:43 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115134/ --- (Updated Jan. 21, 2014, 4:43 p.m.) Review request for KDE Frameworks. Repository: kjsembed Description --- Patch to make kjsembed not collide with kdelibs(4) when installed to same prefix. Additionally, adjusted manpage to reference kjs5 instead of kjs, as that binary has been renamed. Diffs - docs/kjscmd/man-kjscmd5.1.docbook PRE-CREATION docs/kjscmd/man-kjscmd.1.docbook 5a7fd02 docs/kjscmd/CMakeLists.txt eda31bf src/kjscmd/CMakeLists.txt a659f0f Diff: https://git.reviewboard.kde.org/r/115134/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114908: Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/#review47909 --- This review has been submitted with commit 8b055d7f229d6596cf15d045b85ec937f8e2abe8 by Alex Merry to branch master. - Commit Hook On Jan. 19, 2014, 1:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114908/ --- (Updated Jan. 19, 2014, 1:21 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Use add_definitions directly, instead of via _KDE4_PLATFORM_DEFINITIONS Setting the variable just leads to set() calls overwriting each other accidentally (as appeared to have happened in the WIN32 block). Diffs - kde-modules/KDECompilerSettings.cmake 6adbc069bf314ae1a462ffbc5abe25264dac0ac2 Diff: https://git.reviewboard.kde.org/r/114908/diff/ Testing --- KCoreAddons still compiles, and make VERBOSE=1 shows that it is setting -D_BSD_SOURCE -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500, as expected. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115189: rename dbus interface files for kstatusnotifier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115189/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotifications Description --- Rename dbus interface files on install, but keep the same dbus interface. This prevents files clashing with kdelibs4 equivalents but maintains the specified interface. Diffs - src/CMakeLists.txt 5d731eb Diff: https://git.reviewboard.kde.org/r/115189/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_
On Jan. 17, 2014, 6:51 p.m., Alex Merry wrote: KF5DocToolsMacros.cmake, lines 166-172 https://git.reviewboard.kde.org/r/115077/diff/1/?file=234284#file234284line166 These should *not* be renamed, as they are compatibility macros. However, they should probably be moved to kde4support. Aleix Pol Gonzalez wrote: I wouldn't rename it indeed. Moving it to KDE4Support can be good indeed, although it kind of defeats the purpose, as you'll need to actually depend on KDE4Support to get the warning. David Narváez wrote: Luigi, your call. Alex Merry wrote: Well, most projects will start off depending on KDE4Support anyway, and if you don't use it I think you should just get an error about the macro not being found. Luigi Toscano wrote: My thoughts: - is the dependency on KDE4Support the first thing a ported application should do? If yes, then the macros can be kept and moved; but please read on; - KDE4_CREATE_HTML_HANDBOOK can be completely removed. It has been deprecated on Wed Aug 15 03:55:48 2007 +, 82f7b6ba0f8be7d314ac780b9a873e98b6be39b2, and it is not used (apart from the definition in kdelibs and kf5/kdoctools). - KDE4_CREATE_HANDBOOK should not be renamed, and it can be moved to KDE4Support (I see that it was already renamed as KDOCTOOLS_CREATE_HANDBOOK in the frameworks-based code) - I see KDE4_SERIALIZE_TOOL has been renamed as well; but it is defined in KDE4Support: http://lxr.kde.org/source/frameworks/kde4support/cmake/modules/FindKDE4Internal.cmake#455 I'm not sure how to deal with this: probably it would be better to define it here and rename it as KDOCTOOLS_blabla. Does it make sense? Alex Merry wrote: In general, yes, the first thing a ported application will do is replace the lines to search for kdelibs4 with lines to find KDE4Support (and other frameworks). I agree that KDE4_CREATE_HTML_HANDBOOK should be removed (along with any other macro that didn't actually do anything in kdelibs4). If KDE4_CREATE_HANDBOOK was a useful macro in kdelibs4, it should move to kde4support (and either be defined as it is here, or forward to KDOCTOOLS_CREATE_HANDBOOK). I have no idea how the KDE4_SERIALIZE_TOOL thing is supposed to work, so I can't comment on that. Luigi Toscano wrote: KDE4_SERIALIZE_TOOL is used only here (kdoctools); I suggest to rename it as KDOCTOOLS_SERIALIZE_TOOL and add its definition (see http://lxr.kde.org/source/kde/kdelibs/cmake/modules/FindKDE4Internal.cmake#721). KDE4_CREATE_HANDBOOK is used everytime there is documentation in kdelibs4-based applications, so yes, we need to keep it somehow for migration purposes :) I'll split this RR into several others covering those changes. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --- On Jan. 18, 2014, 1:16 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/ --- (Updated Jan. 18, 2014, 1:16 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- Part of the overall task of removing mentions of KDE4 from the code. Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115077/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115190: Add unit test for KWindowInfo on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/ --- Review request for KDE Frameworks and Ben Cooksley. Repository: kwindowsystem Description --- Add unit test for KWindowInfo on X11 Unit test for most methods provided by KWindowInfo. The general pattern is to create a window, show it, test the property, change it and verify that the change worked. This is a little bit tricky as the test needs to interact with large parts of the window manager. In case a property is updated by the window manager we need to send the client message, wait till the window manager has reacted on it and updated the property and then wait for the property update. This is mostly done by waiting for the signal KWindowSystem::windowChanged. Unfortunately that reports globally and not just for the window we are interested in. So we have to filter out till we got the correct one. If there is at the same time further interaction with the windowing system tests can fail, but a re-run normally fixes it. The unit test is so far written against KWin. It's possible that it needs adjustments for succeeding on build.kde.org. Given that KWindowInfo::actionSupported is not tested as that is clearly to specific to the used window manager. --- @Ben: is it possible that you try the patch on build.kde.org while it's under review, so that I can fix any possible failures. Diffs - autotests/CMakeLists.txt 58803aec9c807f68ff2bac227d0d9cf0305fa1f6 autotests/kwindowinfox11test.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115190/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114897: Make KDE_ENABLE_EXCEPTIONS a list
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114897/
---
(Updated Jan. 21, 2014, 6:14 p.m.)
Status
--
This change has been discarded.
Review request for Build System, Extra Cmake Modules, KDE Frameworks, and
Stephen Kelly.
Repository: extra-cmake-modules
Description
---
Make KDE_ENABLE_EXCEPTIONS a list
When KDE_ENABLE_EXCEPTIONS contains two arguments, they are currently a
single string containing those space-separated arguments. It can thus
be used as
set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} ${KDE_ENABLE_EXCEPTIONS})
However, the proper way to set compile flags these days is to use
add_compile_options, as in
add_compile_options(${KDE_ENABLE_EXCEPTIONS})
which requires KDE_ENABLE_EXCEPTIONS to be a list.
Note that this change means that setting CMAKE_CXX_FLAGS like above NO
LONGER WORKS (as you will get the argument
-fexceptions;-UQT_NO_EXCEPTIONS added for GCC and Clang).
Diffs
-
kde-modules/KDECompilerSettings.cmake
cd93e519dea4917a6c09df02bb32254f468c2861
Diff: https://git.reviewboard.kde.org/r/114897/diff/
Testing
---
ThreadWeaver compiles under GCC on Linux if (and only if) I change the
src/CMakeLists.txt file to use add_compile_options instead of setting
CMAKE_CXX_FLAGS.
Thanks,
Alex Merry
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 21, 2014, 6:35 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/#review47918 --- This review has been submitted with commit 84c78978a52cc490896013e7881f0a25e4aa5828 by Jonathan Riddell to branch master. - Commit Hook On Jan. 17, 2014, 4:48 p.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065/ --- (Updated Jan. 17, 2014, 4:48 p.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, and Scarlett Clark. Repository: kdoctools Description --- Rename man pages and checkXML tool to prevent clashes with kdelibs4 credit should go to scarlett Diffs - CMakeLists.txt 74c7af5 checkXML.in.cmake d7a57c7 checkXML5.in.cmake PRE-CREATION docs/CMakeLists.txt 7e9612f docs/checkXML/CMakeLists.txt 7f8226c docs/checkXML/man-checkXML.1.docbook 2bfb3f3 docs/checkXML5/CMakeLists.txt PRE-CREATION docs/checkXML5/man-checkXML5.1.docbook PRE-CREATION docs/kde5options/CMakeLists.txt PRE-CREATION docs/kde5options/man-kde5options.7.docbook PRE-CREATION docs/kdeoptions/CMakeLists.txt a91f451 docs/kdeoptions/man-kdeoptions.7.docbook 7e62f41 docs/qt5options/CMakeLists.txt PRE-CREATION docs/qt5options/man-qt5options.7.docbook PRE-CREATION docs/qtoptions/CMakeLists.txt f1dbb6c docs/qtoptions/man-qtoptions.7.docbook a00677a Diff: https://git.reviewboard.kde.org/r/115065/diff/ Testing --- Thanks, Jonathan Riddell ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kf5options and qt5options manpages
kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. But which options are still true? From qt5options: --display displayname Use the X-server display displayname. --session sessionId Restore the application for the given sessionId. --cmap Causes the application to install a private color map on an 8-bit display. --ncols count Limits the number of colors allocated in the color cube on an 8-bit display, if the application is using the QApplication::ManyColor color specification. --nograb Tells Qt(TM) to never grab the mouse or the keyboard. --dograb Running under a debugger can cause an implicit --nograb, use --dograb to override. --sync Switches to synchronous mode for debugging. --fn,--font fontname Defines the application font. --bg,--background color Sets the default background color and an application palette (light and dark shades are calculated). --fg,--foreground color Sets the default foreground color --btn,--button color Sets the default button color. --name name Sets the application name. --title title Sets the application title (caption). --visual TrueColor Forces the application to use a TrueColor visual on an 8-bit display. --inputstyle inputstyle Sets XIM (X Input Method) input style. Possible values are onthespot, overthespot, offthespot and root. --im XIM server Set XIM server. --noxim Disable XIM --reverse mirrors the whole layout of widgets --stylesheet file.qss applies the Qt stylesheet to the application widgets From kf5options: --caption caption Use caption as name in the titlebar. --icon icon Use icon as the application icon. --config filename Use the alternative configuration filename --nocrashhandler Disable the crash handler, to get core dumps. --waitforwm Waits for a WM_NET compatible windowmanager. --style style Sets the application GUI style. --geometry geometry Sets the client geometry of the main widget. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
Comments from dfaure on https://git.reviewboard.kde.org/r/115065/ --caption caption Use caption as name in the titlebar. Still works with Qt5, but remove one dash. Testcase: kate -caption KATE_KF5 --config filename Use the alternative configuration filename this is gone [one can use XDG_CONFIG_HOME instead, I suppose] ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py
On Jan. 21, 2014, 2:57 p.m., David Faure wrote: Note that I fixed the build failure with kdesrc-build differently - I added a ignore-modules kapidox in kdesrc-build's include files. And I don't like that this will break when using a custom prefix and PYTHONPATH is not set (which is the case here). Alex Merry wrote: You can't really avoid that with Python packages; you can install them with --user and make sure your PATH is set correctly, or you can install them with a prefix and make sure your PYTHONPATH is set correctly (or there are a couple of other ways of telling python about custom site package dirs). Well, or you can install them in a standard location, such as for distro packages. Aurélien Gâteau wrote: Note that the breakage is at runtime, not install time. But since kdesrc-build now ignores kapidox, maybe it's simpler to discard this patch? That's one less piece to maintain. Alex Merry wrote: Sure; I have no opinion on it either way, TBH. Ah right, it won't break make install. Then I withdraw my objection, go ahead. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- On Jan. 21, 2014, 1:49 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- (Updated Jan. 21, 2014, 1:49 p.m.) Review request for Build System, KDE Frameworks and Alex Merry. Repository: kapidox Description --- To fix build failures with kdesrc-build, add a CMakeLists.txt which wraps python setup.py. Diffs - README.md 660e9c3 CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115166/diff/ Testing --- Built and installed with the classic CMake commands. The kapidox tools work fine as long as the installation prefix is either the system one, or defined in $PYTHONPATH. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KCrash
On Sunday 19 January 2014 20:56:23 David Faure wrote: On Sunday 19 January 2014 20:44:48 Kevin Ottens wrote: What about KCRASH_NO_CRASH_HANDLER ? It's long but it makes it at least descriptive. Except that it's not technically correct, a crash handler (= a function called upon crashing) is still called, to handle autorestart functionality (when enabled by the app) and to print out some information (app foo is crashing). Or if the app installs a custom crash handler, it will be called. The only thing that this disables is drkonqi -- the command-line option has always been misnamed, although not as much as the env var :) KCRASH_DISABLE_DRKONQI is probably the only strictly-correct name. Anyhow, naming is the easy part on to actually implementing it... Done: commit 6f0059cd976bbd2968eb8d903e797fdcfb23d3af Author: David Faure fa...@kde.org Date: Tue Jan 21 22:52:00 2014 +0100 Replace --nocrashhandler with KCRASH_AUTO_RESTARTED=1 in the kcrash code. This is how we internally detect that we are being restarted after a crash and therefore we must 1) disable drkonqi 2) delay the crashhandler, to avoid infinite respawning in case the app crashes on startup For users, KDE_DEBUG=1 remains the way to disable drkonqi. No cmdline arg anymore. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115197: Allow compiling KTextEditor on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115201: Use qplatformdefs.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- Review request for KDE Frameworks. Repository: kbookmarks Description --- Use qplatformdefs.h Add a dummy qHash function so that MSVC doesn't fail Diffs - src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 Diff: https://git.reviewboard.kde.org/r/115201/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
On 21/01/14 18:38, Jonathan Riddell wrote: --nocrashhandler Disable the crash handler, to get core dumps. Gone; use KDE_DEBUG=1 instead (see David Faure's email). ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kf5options and qt5options manpages
On 21/01/14 18:38, Jonathan Riddell wrote: kdeoptions and qtoptions manpages listed the common options to applications using kdelibs4 and qt4. These have just become kf5options and qt5options. There is also --license and --author (via KAboutData). ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115198: Fix KDE4Support compilation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115198/ --- Review request for KDE Frameworks and David Faure. Repository: kde4support Description --- KCrash::setApplicationName and KCrash::setApplicationPath disappeared from the KCrash module 179de6d16fb9be580dbb7b15e0a56fcb990c7516, so I guess that a good fix is just stop using it. I'm unsure what's the best way though. Diffs - src/kdeui/kapplication.cpp 5a7f4c8 Diff: https://git.reviewboard.kde.org/r/115198/diff/ Testing --- Builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115197: Allow compiling KTextEditor on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47934 --- ++ for platformsdefs, still no idea why we need winsock, thought, need to look at that. - Christoph Cullmann On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? - Luigi Toscano On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115200: fix windows build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/ --- Review request for KDE Frameworks. Repository: kauth Description --- Fix windows build Add a stub implementation of syslog that simply writes to stderr. Use QThread::usleep() instead of the Unix-only usleep() Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1 Diffs - autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 src/backends/dbus/DBusHelperProxy.cpp 03f63f2edd91865cf3e636fb28df0015e7759210 src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 Diff: https://git.reviewboard.kde.org/r/115200/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115197: Allow compiling KTextEditor on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47938 --- This review has been submitted with commit db925facd7a728753b2a84ec51161b2234a6bf48 by Christoph Cullmann to branch master. - Commit Hook On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115197: Allow compiling KTextEditor on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 10:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 11:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? two separate commits, however kdoctools is broken on windows so I made it optional to allow building - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 11:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 11:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115197: Allow compiling KTextEditor on Windows
On Jan. 21, 2014, 10:24 p.m., Christoph Cullmann wrote: ++ for platformsdefs, still no idea why we need winsock, thought, need to look at that. Alexander Richardson wrote: gethostname is called, I am not familiar enough with the code to say whether that is necessary I see, will fix that, thanks for the hint. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47934 --- On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115197: Allow compiling KTextEditor on Windows
On Jan. 21, 2014, 11:24 p.m., Christoph Cullmann wrote: ++ for platformsdefs, still no idea why we need winsock, thought, need to look at that. gethostname is called, I am not familiar enough with the code to say whether that is necessary - Alexander --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/#review47934 --- On Jan. 21, 2014, 11:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197/ --- (Updated Jan. 21, 2014, 11:21 p.m.) Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description --- Allow compiling KTextEditor on Windows Diffs - src/CMakeLists.txt 761ec5ce08035ce801997e207e4f3871dfa8bd21 src/syntax/katesyntaxdocument.cpp b92e07e367ecbef938f2fa184b5f92633aa4ce92 src/utils/templateinterface.cpp 74e965efd0cc98b69f839cd20b7af4bf219d797b Diff: https://git.reviewboard.kde.org/r/115197/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115201: Use qplatformdefs.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47940 --- Ship it! Looks good, still compiles fine here (Linux, gcc). src/kbookmark.h https://git.reviewboard.kde.org/r/115201/#comment33947 I wondered if this was going to make a comeback... - Alex Merry On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- (Updated Jan. 21, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- Use qplatformdefs.h Add a dummy qHash function so that MSVC doesn't fail Diffs - src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 Diff: https://git.reviewboard.kde.org/r/115201/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building Wouldn't it be better to fix KDocTools on windows instead? :) What is broken? Is it the issue with compiling libxml/libxslt? - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47942 --- Welp, since no-one seems to care, I'm gonna commit it. - Alex Merry On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/ --- (Updated Jan. 12, 2014, 12:58 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Do not explicity find or use Qt5WebKit(Widgets) The kdewebkit designer plugin does not directly use anything from Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is found as a dependency of KF5WebKit. So we do not need to find it ourselves, or explicitly link against it. Diffs - CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b Diff: https://git.reviewboard.kde.org/r/114980/diff/ Testing --- Still configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115203: Allow compiling with MSVC
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115203/ --- Review request for KDE Frameworks. Repository: kcrash Description --- Allow compiling with MSVC Diffs - src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 Diff: https://git.reviewboard.kde.org/r/115203/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/ --- (Updated Jan. 21, 2014, 10:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Do not explicity find or use Qt5WebKit(Widgets) The kdewebkit designer plugin does not directly use anything from Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is found as a dependency of KF5WebKit. So we do not need to find it ourselves, or explicitly link against it. Diffs - CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b Diff: https://git.reviewboard.kde.org/r/114980/diff/ Testing --- Still configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115190: Add unit test for KWindowInfo on X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115190/#review47945 --- I'm afraid the test fails Martin. Guess KWin and Openbox behave differently in some areas. 5/9 Test #5: kwindowsystem-kwindowinfox11test ..***Failed9.96 sec * Start testing of KWindowInfoX11Test * Config: Using QtTest library 5.2.2, Qt 5.2.2 PASS : KWindowInfoX11Test::initTestCase() FAIL! : KWindowInfoX11Test::testState(max) Compared values are not the same Actual (info.state()): 0 Expected (static_castunsigned long(firstRun ? NET::DemandsAttention : 0)): 2048 Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(129)] PASS : KWindowInfoX11Test::testState(maxHoriz) FAIL! : KWindowInfoX11Test::testState(shaded) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] FAIL! : KWindowInfoX11Test::testState(skipTaskbar) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] FAIL! : KWindowInfoX11Test::testState(skipPager) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] FAIL! : KWindowInfoX11Test::testState(keep above) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] FAIL! : KWindowInfoX11Test::testState(keep below) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] FAIL! : KWindowInfoX11Test::testState(fullscreen) 'waitForWindow(spy, window-winId(), NET::WMState)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(159)] PASS : KWindowInfoX11Test::testMinimized() PASS : KWindowInfoX11Test::testMappingState() PASS : KWindowInfoX11Test::testWindowType(desktop) PASS : KWindowInfoX11Test::testWindowType(dock) PASS : KWindowInfoX11Test::testWindowType(toolbar) PASS : KWindowInfoX11Test::testWindowType(menu) PASS : KWindowInfoX11Test::testWindowType(dialog) PASS : KWindowInfoX11Test::testWindowType(override) PASS : KWindowInfoX11Test::testWindowType(override as normal) PASS : KWindowInfoX11Test::testWindowType(topmenu) PASS : KWindowInfoX11Test::testWindowType(topmenu as dock) PASS : KWindowInfoX11Test::testWindowType(utility) PASS : KWindowInfoX11Test::testWindowType(utility as dialog) PASS : KWindowInfoX11Test::testWindowType(splash) PASS : KWindowInfoX11Test::testWindowType(splash as dock) PASS : KWindowInfoX11Test::testWindowType(dropdownmenu) PASS : KWindowInfoX11Test::testWindowType(popupmenu) PASS : KWindowInfoX11Test::testWindowType(popupmenu as menu) PASS : KWindowInfoX11Test::testWindowType(tooltip) PASS : KWindowInfoX11Test::testWindowType(notification) PASS : KWindowInfoX11Test::testWindowType(ComboBox) PASS : KWindowInfoX11Test::testWindowType(DNDIcon) PASS : KWindowInfoX11Test::testWindowType(desktop-unknown) PASS : KWindowInfoX11Test::testWindowType(dock-unknown) PASS : KWindowInfoX11Test::testWindowType(toolbar-unknown) PASS : KWindowInfoX11Test::testWindowType(menu-unknown) PASS : KWindowInfoX11Test::testWindowType(dialog-unknown) PASS : KWindowInfoX11Test::testWindowType(override-unknown) PASS : KWindowInfoX11Test::testWindowType(topmenu-unknown) PASS : KWindowInfoX11Test::testWindowType(utility-unknown) PASS : KWindowInfoX11Test::testWindowType(splash-unknown) PASS : KWindowInfoX11Test::testWindowType(dropdownmenu-unknown) PASS : KWindowInfoX11Test::testWindowType(popupmenu-unknown) PASS : KWindowInfoX11Test::testWindowType(tooltip-unknown) PASS : KWindowInfoX11Test::testWindowType(notification-unknown) PASS : KWindowInfoX11Test::testWindowType(ComboBox-unknown) PASS : KWindowInfoX11Test::testWindowType(DNDIcon-unknown) FAIL! : KWindowInfoX11Test::testDesktop() 'waitForWindow(spy, window-winId(), NET::WMDesktop)' returned FALSE. () Loc: [/srv/jenkins/workspace/kwindowsystem_master_qt5/autotests/kwindowinfox11test.cpp(304)] PASS : KWindowInfoX11Test::testWindowClass() PASS : KWindowInfoX11Test::testWindowRole() PASS : KWindowInfoX11Test::testClientMachine() FAIL! : KWindowInfoX11Test::testName() Compared values are not the same Actual (info3.visibleName()) : kwindowinfox11test Expected (QStringLiteral(foobar)): foobar Loc:
Re: Review Request 114980: Do not explicity find or use Qt5WebKit(Widgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/#review47943 --- This review has been submitted with commit 749336963bbcddea2e547020202e049937536275 by Alex Merry to branch master. - Commit Hook On Jan. 12, 2014, 12:58 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114980/ --- (Updated Jan. 12, 2014, 12:58 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Do not explicity find or use Qt5WebKit(Widgets) The kdewebkit designer plugin does not directly use anything from Qt5WebKitWidgets, only KWebView from KF5WebKit. Qt5WebKitWidgets is found as a dependency of KF5WebKit. So we do not need to find it ourselves, or explicitly link against it. Diffs - CMakeLists.txt d13d071f935306df2d052b58a6a03ea92bba36f3 src/CMakeLists.txt 55ac819d4c2cbaac483cec9617402e18fbe22d2b Diff: https://git.reviewboard.kde.org/r/114980/diff/ Testing --- Still configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47947 --- CMakeLists.txt https://git.reviewboard.kde.org/r/115202/#comment33948 What's the problem with finding documentation on windows? - Aleix Pol Gonzalez On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115132: Append 5 to preparetips script manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/#review47951 --- Ship it! Seems sensible to me. - Alex Merry On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/ --- (Updated Jan. 19, 2014, 10:34 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same prefix. I can cleanup whitespaces if needed (they where present in original script). Also, depending on the outcome of r115065, can change kdeoptions man reference. Diffs - docs/preparetips/CMakeLists.txt 4685089 docs/preparetips/man-preparetips.1.docbook baf4b6b docs/preparetips/man-preparetips5.1.docbook PRE-CREATION src/CMakeLists.txt baf5295 src/ktipdialog.cpp 1b74f55 src/preparetips a89d9f1 src/preparetips5 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115132/diff/ Testing --- Builds :) Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
On Jan. 21, 2014, 10:29 p.m., Luigi Toscano wrote: Jut to be sure, are the two changes (optional KDocTools and the not-iterator hack) unrelated? Alexander Richardson wrote: two separate commits, however kdoctools is broken on windows so I made it optional to allow building Luigi Toscano wrote: Wouldn't it be better to fix KDocTools on windows instead? :) What is broken? Is it the issue with compiling libxml/libxslt? Alexander Richardson wrote: The problem is that it can't find kdex.dtd. I guess I could fix that by copying it the right location, but thats more of a hack. Luigi Toscano wrote: Uhm, on Linux systems you have to set XDG_DATA_DIRS: The value of kde-dir/share must be included in the environment variable XDG_DATA_DIRS or otherwise the build will fail. where kde-dir = your KDE Frameworks 5 installation directory (from http://community.kde.org/Frameworks/Building). I don't know if and how it works on Windows. Alexander Richardson wrote: It is not possible. I will have to modify KDEInstallDirs to get a proper fix. Instead of prefix/share/* we have to install to C:/ProgramData/* or some per-user dir (will have to investigate there, although I don't feel like spending much time on this issue since I rarely use Windows) Can you please at least report this on the TODO list of kde-windows packagers? As I said, I'm not sure this is the right long-term solution, I guess it will happen also for every other frameworks/modules on Windows. - Luigi --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/#review47936 --- On Jan. 21, 2014, 10:26 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 21, 2014, 10:26 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Make KDocTools an optional dependency Fix compilation on MSVC Not sure whether this is a bug in MSVC or their STL or even Qt (unlikely) Diffs - CMakeLists.txt b5b42fb207d68e44bc0fe58763a39574d81c3e9d src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review47953 --- Seems sensible to me, but I would add Valentin Rusu to the review. - Alex Merry On Jan. 21, 2014, 10:38 a.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 21, 2014, 10:38 a.m.) Review request for KDE Frameworks. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115200: fix windows build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/#review47955 --- Ship it! Still compiles fine for me (Linux, gcc). - Alex Merry On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks. Repository: kauth Description --- Fix windows build Add a stub implementation of syslog that simply writes to stderr. Use QThread::usleep() instead of the Unix-only usleep() Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1 Diffs - autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 src/backends/dbus/DBusHelperProxy.cpp 03f63f2edd91865cf3e636fb28df0015e7759210 src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 Diff: https://git.reviewboard.kde.org/r/115200/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47957 --- cmake/FindSharedMimeInfo.cmake https://git.reviewboard.kde.org/r/115199/#comment33953 On Unix, `update-mime-database -v` outputs to stderr. You should set ERROR_VARIABLE to the same values as OUTPUT_VARIABLE (this will merge the streams); that way it should work on both Windows and Unix. - Alex Merry On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:29 a.m.) Review request for KDE Frameworks. Changes --- fixed the reported issue Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs (updated) - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:30 a.m.) Review request for KDE Frameworks. Changes --- right diff Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs (updated) - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47959 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 21, 2014, 11:30 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115200: fix windows build
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/#review47960 --- This review has been submitted with commit 8ea89457676104911eaa16331c6082fa1b563fc9 by Alex Richardson to branch master. - Commit Hook On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115200/ --- (Updated Jan. 21, 2014, 10:21 p.m.) Review request for KDE Frameworks. Repository: kauth Description --- Fix windows build Add a stub implementation of syslog that simply writes to stderr. Use QThread::usleep() instead of the Unix-only usleep() Allow compiling the tests on windows by adding -DKAUTH_STATIC_DEFINE=1 Diffs - autotests/CMakeLists.txt 746d61798d768eeeff7fe889fec768a4887053db autotests/TestHelper.cpp b0005bd80af3d7232387458c4e4ffad5c5374f52 src/backends/dbus/DBusHelperProxy.cpp 03f63f2edd91865cf3e636fb28df0015e7759210 src/kauthhelpersupport.cpp 2cd1f68880673780a9a2c18cd5b120b2baea54e9 Diff: https://git.reviewboard.kde.org/r/115200/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115132: Append 5 to preparetips script manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/ --- (Updated Jan. 21, 2014, 11:36 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same prefix. I can cleanup whitespaces if needed (they where present in original script). Also, depending on the outcome of r115065, can change kdeoptions man reference. Diffs - docs/preparetips/CMakeLists.txt 4685089 docs/preparetips/man-preparetips.1.docbook baf4b6b docs/preparetips/man-preparetips5.1.docbook PRE-CREATION src/CMakeLists.txt baf5295 src/ktipdialog.cpp 1b74f55 src/preparetips a89d9f1 src/preparetips5 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115132/diff/ Testing --- Builds :) Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115132: Append 5 to preparetips script manpage
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/#review47961 --- This review has been submitted with commit 1ea6262185916ae453db15d325bdad0e27b1e0b3 by Hrvoje Senjan to branch master. - Commit Hook On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115132/ --- (Updated Jan. 19, 2014, 10:34 p.m.) Review request for KDE Frameworks. Repository: kconfigwidgets Description --- Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same prefix. I can cleanup whitespaces if needed (they where present in original script). Also, depending on the outcome of r115065, can change kdeoptions man reference. Diffs - docs/preparetips/CMakeLists.txt 4685089 docs/preparetips/man-preparetips.1.docbook baf4b6b docs/preparetips/man-preparetips5.1.docbook PRE-CREATION src/CMakeLists.txt baf5295 src/ktipdialog.cpp 1b74f55 src/preparetips a89d9f1 src/preparetips5 PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115132/diff/ Testing --- Builds :) Thanks, Hrvoje Senjan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115207: Improve integration QCommandLineParser - KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication. Diffs - src/lib/kaboutdata.h c9e src/lib/kaboutdata.cpp f24006b Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review47962 --- Think that will make porting easier and avoids boiler plate code - Christoph Cullmann On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Jan. 21, 2014, 11:36 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication. Diffs - src/lib/kaboutdata.h c9e src/lib/kaboutdata.cpp f24006b Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47963 --- Ship it! Works for me now. - Alex Merry On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 21, 2014, 11:30 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review47964 --- Looks like a good idea to me. - Alex Merry On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Jan. 21, 2014, 11:36 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Let the KAboutData set information to QApplication. This way we don't have to duplicate information by passing it to the KAboutData _and_ the QApplication. Diffs - src/lib/kaboutdata.h c9e src/lib/kaboutdata.cpp f24006b Diff: https://git.reviewboard.kde.org/r/115207/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115202: Allow building KConfigWidgets on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115202/ --- (Updated Jan. 22, 2014, 1:06 a.m.) Review request for KDE Frameworks. Changes --- don't make kdoctools optional Repository: kconfigwidgets Description (updated) --- Fix compilation on MSVC Diffs (updated) - src/kcolorschememanager.cpp 2e44f88d4b613a263047899b102da53541139171 Diff: https://git.reviewboard.kde.org/r/115202/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/#review47966 --- This review has been submitted with commit 0971e8cc8daffc1101ace9a37f8e777499b9843b by Alex Richardson to branch master. - Commit Hook On Jan. 21, 2014, 11:30 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 21, 2014, 11:30 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115199: Fix detection of shared-mime-info on Windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115199/ --- (Updated Jan. 22, 2014, 12:12 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcoreaddons Description --- Fix detection of shared-mime-info on Windows For some reason exec_program would fail, it works with execute_process Diffs - cmake/FindSharedMimeInfo.cmake 4427c733b3c4e6fb969ee03e4405fb2a12a26232 Diff: https://git.reviewboard.kde.org/r/115199/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115201: Use qplatformdefs.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47968 --- This review has been submitted with commit 27aa98c3897af2876357b8ad19ea7abc2cdb7d99 by Alex Richardson to branch master. - Commit Hook On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- (Updated Jan. 21, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- Use qplatformdefs.h Add a dummy qHash function so that MSVC doesn't fail Diffs - src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 Diff: https://git.reviewboard.kde.org/r/115201/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115201: Use qplatformdefs.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/#review47967 --- This review has been submitted with commit 7076a02f50b48904a0cac67348074d23b35a754f by Alex Richardson to branch master. - Commit Hook On Jan. 21, 2014, 10:22 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- (Updated Jan. 21, 2014, 10:22 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- Use qplatformdefs.h Add a dummy qHash function so that MSVC doesn't fail Diffs - src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 Diff: https://git.reviewboard.kde.org/r/115201/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115201: Use qplatformdefs.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115201/ --- (Updated Jan. 22, 2014, 12:15 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kbookmarks Description --- Use qplatformdefs.h Add a dummy qHash function so that MSVC doesn't fail Diffs - src/kbookmark.h 0ce3a74b922da0ceaa214f7556d946ea1e62215a src/kbookmarkimporter.cpp 9ce564f88f0a4d4bafe4a54a899ae90632d31f65 src/kbookmarkimporter_ie.cpp 457d22fc388def15104b9ef86958a44980a61935 src/kbookmarkimporter_opera.cpp d44548d8bf8039a12ceeb387985352f605cf27a1 Diff: https://git.reviewboard.kde.org/r/115201/diff/ Testing --- Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs
On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: Thanks for working on apidox! Sorry for the large number of comments... Wow! You were ultra-fast, just 31 minutes for all this! :-) I will see one by one tomorrow (just wanted to comment about something I clearly don't agree). On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote: src/kcompletion.h, line 103 https://git.reviewboard.kde.org/r/115206/diff/1/?file=235092#file235092line103 You remove the hyphen from auto-completion ealier, but not here. Yes, I drop the hyphen from auto-completion when it works as a noun. But here (and in many other places) is working as a compound adjective. Some sources about compound adjectives and hyphens: http://writersrelief.com/blog/2008/03/hyphen-rules-dont-let-misused-hyphens-muddle-your-adjectives-or-your-writing/ http://www.grammarbook.com/punctuation/hyphens.asp Nevertheless, I may be wrong. If so, please tell me. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/#review47958 --- On Jan. 21, 2014, 11:12 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115206/ --- (Updated Jan. 21, 2014, 11:12 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Correct spelling, grammar and style of kcompletion.h docs Diffs - src/kcompletion.h 46b63a4 Diff: https://git.reviewboard.kde.org/r/115206/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
