[Libreoffice-bugs] [Bug 155855] Pasting (previous) images from Windows clipboard impossible into LO
https://bugs.documentfoundation.org/show_bug.cgi?id=155855 Vladimir Sokolinskiy changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Vladimir Sokolinskiy --- Repro. Version: 7.4.2.3 (x64) / LibreOffice Community Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf CPU threads: 6; OS: Windows 10.0 Build 19044; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155776] Slow scrolling, utilizing a CPU core to max
https://bugs.documentfoundation.org/show_bug.cgi?id=155776 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108075 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108075 [Bug 108075] [META] Scrolling and Page up/down issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108075] [META] Scrolling and Page up/down issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108075 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155776 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155776 [Bug 155776] Slow scrolling, utilizing a CPU core to max -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102998 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155854 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155854 [Bug 155854] Mail Merge hangs after connecting to the mailserver -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155854] Mail Merge hangs after connecting to the mailserver
https://bugs.documentfoundation.org/show_bug.cgi?id=155854 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||102998 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102998 [Bug 102998] [META] Mail merge bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||155856 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155856 [Bug 155856] Port C++ SDK examples make files to cmake / qmake -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155856] Port C++ SDK examples make files to cmake / qmake
https://bugs.documentfoundation.org/show_bug.cgi?id=155856 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118558] doesn't change format of page to 2 columns for Endnote page style
https://bugs.documentfoundation.org/show_bug.cgi?id=118558 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> --- still repro in Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069c7dc4e9706b40ca12d83d83f90f41cec948f8 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154756] Vertical text direction results in rotation, not vertical text direction
https://bugs.documentfoundation.org/show_bug.cgi?id=154756 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | --- Comment #15 from Heiko Tietze --- Presented the topic in the ESC. Current behavior is presumably correct, yet enhancing it with a 90° rotation state of the characters possible. Would be an enhancement in this case. I wonder if this should work out of the box when combining the page style with rotated characters (doesn't work correctly though). Besides the enhancement it would be nice to change the preview but IMO low priority- affected users do understand the effect of changing the text direction. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 151207] [SAMPLE] Areas where multithreading would be needed to improve slow performance of common tasks in huge (million rows) spreadsheets
https://bugs.documentfoundation.org/show_bug.cgi?id=151207 --- Comment #5 from Xiaoc <3118049...@qq.com> --- I think so.When processing hundreds of pages of Word, libreOffice is also slower to open than the competition, and we all want LibreOffice to be better -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/xmldump.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 8e307b8affbeb26555b25cf07a8a270a0447f6db
Author: Miklos Vajna
AuthorDate: Thu Jun 15 09:34:54 2023 +0200
Commit: Miklos Vajna
CommitDate: Thu Jun 15 16:04:03 2023 +0200
sw layout xml dump: show page frame of anchored objects
It's useful to see if this is updated already or not when the object
moves between pages.
Change-Id: Iccad297585c04d77a95eb6cd31b65919470a97e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153102
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/source/core/text/xmldump.cxx b/sw/source/core/text/xmldump.cxx
index 5c85d5c601fb..cadf89fb3531 100644
--- a/sw/source/core/text/xmldump.cxx
+++ b/sw/source/core/text/xmldump.cxx
@@ -371,6 +371,10 @@ void SwAnchoredObject::dumpAsXml( xmlTextWriterPtr writer
) const
(void)xmlTextWriterStartElement( writer, BAD_CAST( getElementName() ) );
(void)xmlTextWriterWriteFormatAttribute( writer, BAD_CAST( "ptr" ), "%p",
this );
(void)xmlTextWriterWriteAttribute(writer, BAD_CAST("anchor-frame"),
BAD_CAST(OString::number(mpAnchorFrame->GetFrameId()).getStr()));
+if (mpPageFrame)
+{
+(void)xmlTextWriterWriteAttribute(writer, BAD_CAST("page-frame"),
BAD_CAST(OString::number(mpPageFrame->GetFrameId()).getStr()));
+}
SwTextFrame* pAnchorCharFrame =
const_cast(this)->FindAnchorCharFrame();
if (pAnchorCharFrame)
{
[Libreoffice-bugs] [Bug 155034] Cannot open or create file in Impress / Draw on Ubuntu 18.04 or 20.04 after Update libxmlsec to 1.3.0
https://bugs.documentfoundation.org/show_bug.cgi?id=155034 --- Comment #34 from Timur --- Thanks for that, Miklos. Master bibi repo is 9 days old, I will see this when updated. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155856] Port C++ SDK examples make files to cmake / qmake
https://bugs.documentfoundation.org/show_bug.cgi?id=155856 Hossein changed: What|Removed |Added Keywords||difficultyMedium, easyHack, ||skillCpp, skillScript -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155856] New: Port C++ SDK examples make files to cmake / qmake
https://bugs.documentfoundation.org/show_bug.cgi?id=155856 Bug ID: 155856 Summary: Port C++ SDK examples make files to cmake / qmake Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hoss...@libreoffice.org There are various C++ SDK examples available via LibreOffice SDK. some of them are listed here: C++ examples https://api.libreoffice.org/examples/examples.html#Cpp_examples Others can be found inside odk/examples/cpp/, and also odk/examples/DevelopersGuide/. These examples are supposed to be built using GNU Make, which has several problems, and need many dependencies. On the other hand, building the examples using modern build tools like cmake and qmake is much easier. This task here is to port C++ SDK examples makefile to cmake and or qmake. Below you can find some examples on how to port the make files to cmake/qmake. Blog post: Using cmake to build LibreOffice C++ SDK examples https://dev.blog.documentfoundation.org/2022/04/19/using-cmake-to-build-libreoffice-cpp-sdk-examples/ Video: LibreOffice SDK Examples Overhaul - LibreOffice Conference 2021 https://www.youtube.com/watch?v=zWLFv5AR3uY Example: LOConvertor https://github.com/hosseinn/loconvertor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 Stéphane Guillou (stragu) changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #17 from Stéphane Guillou (stragu) --- Thanks! :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155855] New: Pasting (previous) images from Windows clipboard impossible into LO
https://bugs.documentfoundation.org/show_bug.cgi?id=155855 Bug ID: 155855 Summary: Pasting (previous) images from Windows clipboard impossible into LO Product: LibreOffice Version: 7.4.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gbcharlot-questionning12...@yahoo.com Description: Hello, I have had this issue since years. I did not find the correct answer in the LO forums to this issue. And also the issue as described below might be more detailed than the previous ones or apparently (but not) similar ones. On LO on Windows it is absolutely impossible to copy-paste an image from the clipboard into any LO document, WHEN the image is not the very last (recent) thing that has been copied… I can copy-paste ANY text from the windows clipboard even if it was very old and at the end of the clipboard queue. But this is not working for any screenshot that is not the very last (recent) thing listed on the clipboard. The very last screenshot is still copy-past’able’ into LO documents. But as soon as I copy let’s says a word and when I go to the Windows clipboard with pressing the Windows Icone + V, if I select the visible screenshot that is on position 2 or 3 etc… but not in position #1, then pasting the Screenshot into any LO document would never work. It works with ANY other software but not at all with LO. And this issue has been the same for at least 3-4 years. And believe me I have hoped at each new release of LO that this issue would be solved but the issue is STILL there. When I click to copy an image and then copy text and then try to paste the copied (not screenshooted) image from the clipboard the issue is the same. Also, when using the Print Screen key, the issue is the also the same: basically the issue is about all images whatever the way they were copied and added in the clipboard, when listed 2nd or more in the windows clipboard queue. Note: I tried obviously on other PCs and the issue is there too… This issue relates to all main LO components: Impress, Writer, Calc Steps to Reproduce: 1.Take a screenshot or copy an image into the Windows clipboard 2. Copy some text (not an image) into the clipboard 3. Try to paste the image which is second in the queue of the windows clipboard into any LO component ==> it will not work Actual Results: Impossible to paste any image from the windows clipboard into any LO component, when the given image is not the very last thing that has been copied into the clipboard Expected Results: Being able to paste an image copied into the windows clipboard into LO components even if this image was the last before the last that has been copied into the windows clipboard Reproducible: Always User Profile Reset: No Additional Info: Thank you and good luck for resolving this bug. Great gratitude towards the overall community of developers and people who work and have been working so long to develop Libre Office! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source xmloff/qa xmloff/source
sw/source/uibase/uno/unotxdoc.cxx |7 +-
xmloff/qa/unit/data/listRestartAfterBreak.fodt | 25 ++
xmloff/qa/unit/text.cxx| 61 +
xmloff/source/text/txtparae.cxx| 33 ++---
4 files changed, 104 insertions(+), 22 deletions(-)
New commits:
commit 7db19db341608ba2059543a3c8d61cd458470602
Author: Mike Kaganski
AuthorDate: Thu Jun 15 10:34:41 2023 +0300
Commit: Mike Kaganski
CommitDate: Thu Jun 15 15:47:01 2023 +0200
ODF export: simplify restart handling to skip list id where possible
This continues to minimize cases where random ids are written, helping
to make the output more deterministic; it builds upon commits
8f48f91009caa86d896f247059874242ed18bf39 (ODT export: omit unreferenced
, 2022-03-10), and
82bbf63582bdf28e7918e58ebf6657a9144bc9f3 (tdf#155823: Improve the check
if the list id is not required, 2023-06-14).
The previous code used to write 'text:continue-list' when the list is
restarted. It is unnecessary when there is no other condition requiring
such a reference (like style change, or interleaving lists); so relax
the conditions allowing to put simple 'text:continue-numbering="true"'.
This also allows to simplify a bit the code around 'ShouldSkipListId'.
Change-Id: Idf8be455953d08fd578266bda22f3a55d7b9ee23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153104
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index 51c777ee47da..e68d468e3fff 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1974,8 +1974,8 @@ Any SwXTextDocument::getPropertyValue(const OUString&
rPropertyName)
// A hack to avoid writing random list ids to ODF when they are not
referred later
// see XMLTextParagraphExport::DocumentListNodes ctor
-// Sequence of nodes, each of them represented by four-element
sequence:
-// [ index, styleIntPtr, list_id, isRestart ]
+// Sequence of nodes, each of them represented by three-element
sequence:
+// [ index, styleIntPtr, list_id ]
std::vector> nodes;
const SwDoc& rDoc = *m_pDocShell->GetDoc();
@@ -1989,9 +1989,8 @@ Any SwXTextDocument::getPropertyValue(const OUString&
rPropertyName)
{
css::uno::Any index(pTextNode->GetIndex().get());
css::uno::Any list_id(pTextNode->GetListId());
-css::uno::Any isRestart(pTextNode->IsListRestart());
-nodes.push_back({ index, styleIntPtr, list_id, isRestart });
+nodes.push_back({ index, styleIntPtr, list_id });
}
}
return css::uno::Any(comphelper::containerToSequence(nodes));
diff --git a/xmloff/qa/unit/data/listRestartAfterBreak.fodt
b/xmloff/qa/unit/data/listRestartAfterBreak.fodt
new file mode 100644
index ..7ae5c84d7060
--- /dev/null
+++ b/xmloff/qa/unit/data/listRestartAfterBreak.fodt
@@ -0,0 +1,25 @@
+
+
+
+
+
+
+
+ Item1
+
+
+
+
+
+ Item2
+
+
+
+
+
+ Item3 (restarted)
+
+
+
+
+
\ No newline at end of file
diff --git a/xmloff/qa/unit/text.cxx b/xmloff/qa/unit/text.cxx
index bff3f8b14821..abd4a0e07dea 100644
--- a/xmloff/qa/unit/text.cxx
+++ b/xmloff/qa/unit/text.cxx
@@ -347,6 +347,67 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testListIdState)
CPPUNIT_ASSERT(!id.isEmpty());
}
+CPPUNIT_TEST_FIXTURE(XmloffStyleTest, testListIdOnRestart)
+{
+// Test that a restart of a continued list, by itself, does not introduce
a unneeded xml:id
+// and text:continue-list, but uses text:continue-numbering, and is
imported correctly.
+
+// Given a document with a list with a restart after break:
+loadFromURL(u"listRestartAfterBreak.fodt");
+
+auto xTextDocument(mxComponent.queryThrow());
+auto
xParaEnumAccess(xTextDocument->getText().queryThrow());
+auto xParaEnum(xParaEnumAccess->createEnumeration());
+
+auto xPara(xParaEnum->nextElement().queryThrow());
+auto aActual(xPara->getPropertyValue("ListLabelString").get());
+CPPUNIT_ASSERT_EQUAL(OUString("1."), aActual);
+OUString list_id = xPara->getPropertyValue("ListId").get();
+xParaEnum->nextElement(); // Skip empty intermediate paragraph
+xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY_THROW);
+aActual = xPara->getPropertyValue("ListLabelString").get();
+CPPUNIT_ASSERT_EQUAL(OUString("2."), aActual);
+CPPUNIT_ASSERT_EQUAL(list_id,
xPara->getPropertyValue("ListId").get());
+xParaEnum->nextElement(); // Skip empty intermediate paragraph
+xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY);
+aActual = xPara->getPropertyValue("ListLabelString").get();
+// Check that restart was applied correctly, with simple
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 --- Comment #6 from Mike Kaganski --- Created attachment 187927 --> https://bugs.documentfoundation.org/attachment.cgi?id=187927=edit Minimized sample (In reply to randylow77 from comment #3) > Created attachment 187916 [details] > new file Repro. This is a minimized sample. (In reply to randylow77 from comment #5) > Created attachment 187926 [details] > I am adding another file with Cyrillic characters that does not open > correctly in LO Writer, but is displayed correctly in MS Word and Only > Office. This opens fine using Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL threaded Looks like a separate issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155848] CSV import improperly import floats as text prefixed by a hidden apostrophe
https://bugs.documentfoundation.org/show_bug.cgi?id=155848 --- Comment #2 from Eike Rathke --- And for converting text to numeric (or date(+time)) after import see https://wiki.documentfoundation.org/Faq/Calc/How_to_convert_number_text_to_numeric_data (In reply to Martin Mokrejs from comment #0) > Yes, the thousands separator ',' got interpreted regardles of my locale as a > decimal dot so 12,600 (twelve thousand 6 hundred) turned into 12,6. But that > is another story. > Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US That pretty much suggest that the CSV import locale probably was also cs-CZ which has ',' comma decimal separator. Pay attention to the dialog and its settings. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 randylo...@gmail.com changed: What|Removed |Added Attachment #187926|Another incorrectly |I am adding another file description|displayed file with |with Cyrillic characters |Cyrillic characters.|that does not open ||correctly in LO Writer, but ||is displayed correctly in ||MS Word and Only Office. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155838] PDF Convertion Removing Dropdown and Checkbox Input
https://bugs.documentfoundation.org/show_bug.cgi?id=155838 Steph changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from Steph --- Updating Status -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155854] New: Mail Merge hangs after connecting to the mailserver
https://bugs.documentfoundation.org/show_bug.cgi?id=155854 Bug ID: 155854 Summary: Mail Merge hangs after connecting to the mailserver Product: LibreOffice Version: 7.3.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: bernarddecock.ma...@yahoo.be Description: Mail Merge hangs when it starts sending e-mails. I set the dbg variable in mailmerge.py True. The logging reveals that a connection is made with the SMTP-server and the connection is acknowledged. The logging ends with reply: b’235 2.0.0 OK Authenticated\r\n’ reply: retcode (235); Msg: b’2.0.0 OK Authenticated’ PyMailSMTPService isConnected XSL Vendor: ‘libxslt’ After a while a notification pops up that LO is unresponsive. It looks that something goes wrong while parsing the info into data to be emailed. I have this behavior on 3 computers with Linux Mint 21.1 Cinnamon. I installed Ubuntu 23.04 in a virtual machine and Mail Merge started working fine in the VM. Is this a known bug in Version: 7.3.7.2 / LibreOffice Community Build ID: 30(Build:2)? Steps to Reproduce: 1. Open the Mail Merge Wizard 2. Configure 3. Request to send the emails Actual Results: LO Hangs Expected Results: LO is unresponsive and shuts down after selecting to terminate the app. It tells afterward that the documents have to be recovered, although they haven't been changed. Reproducible: Always User Profile Reset: No Additional Info: It should the proper email -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #14 from Mike Kaganski --- (In reply to zuebgirl from comment #13) > But also, just because something is popular does not mean it's right or the > best. Again: the LO project has *no* goal of *deciding* which programming language is "right" or "best"; the popularity tells the only one metric that matters for this project: the number of people who potentially can benefit from the support; it shows that dropping this support would make much harm (and there are other metrics telling about harm from dropping such support); and trying to force your idea on the project is trying to shift the project's goals, that are fixed and defined in the TDF legal statutes. I'm off of this useless discussion. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 randylo...@gmail.com changed: What|Removed |Added Attachment #187926|Another incorrectly |Another incorrectly description|displayed Cyrillic file.|displayed file with ||Cyrillic characters. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155835] Incorrect display of Cyrillic characters in the text in LO Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=155835 randylo...@gmail.com changed: What|Removed |Added Attachment #187911|0 |1 is obsolete|| --- Comment #5 from randylo...@gmail.com --- Created attachment 187926 --> https://bugs.documentfoundation.org/attachment.cgi?id=187926=edit Another incorrectly displayed Cyrillic file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #13 from zuebg...@sharklasers.com --- (In reply to Mike Kaganski from comment #12) > (In reply to zuebgirl from comment #11) > > There is no benefit of JS over any other language, except when someone knows > one better than another. Python is the *world's #1* programming language - > see today's TIOBE index [1]; the idea that the project has a goal to force > people to learn some other programming language *just because zuebgirl has > an idea it has an abstract benefit* is another daydreaming. > > [1] https://www.tiobe.com/tiobe-index/ But also, just because something is popular does not mean it's right or the best. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #12 from Mike Kaganski --- (In reply to zuebgirl from comment #11) There is no benefit of JS over any other language, except when someone knows one better than another. Python is the *world's #1* programming language - see today's TIOBE index [1]; the idea that the project has a goal to force people to learn some other programming language *just because zuebgirl has an idea it has an abstract benefit* is another daydreaming. [1] https://www.tiobe.com/tiobe-index/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155838] PDF Convertion Removing Dropdown and Checkbox Input
https://bugs.documentfoundation.org/show_bug.cgi?id=155838 --- Comment #3 from Steph --- Unfortunately our tool that uses LibreOffice does not have the ability to open the UI for Libreoffice, and relies on the command line. I am bit confused by your suggestion because it does not seem to relate to what I am running in to for this defect. I am running into this issue in the command line, not the UI. Is there a flag I should be adding for this "Create PDF Form" option you are suggesting? Some other useful information -this didnt seem to be a problem in an older version (7.0.4) -I would also suggest using the document I have provided, because this seems to be a problem with older dropdowns and checkbox(I believe from Word 2016) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122970] Direct cursor leaves screen trail with mouse pointer movement and no text
https://bugs.documentfoundation.org/show_bug.cgi?id=122970 Heiko Tietze changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||riz...@libreoffice.org --- Comment #19 from Heiko Tietze --- Rizal, can you create a nice cursor image for this? See also https://gerrit.libreoffice.org/c/core/+/153099 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 122970] Direct cursor leaves screen trail with mouse pointer movement and no text
https://bugs.documentfoundation.org/show_bug.cgi?id=122970 Heiko Tietze changed: What|Removed |Added Keywords||needsUXEval CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||riz...@libreoffice.org --- Comment #19 from Heiko Tietze --- Rizal, can you create a nice cursor image for this? See also https://gerrit.libreoffice.org/c/core/+/153099 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #11 from zuebg...@sharklasers.com --- (In reply to Mike Kaganski from comment #10) > One small addendum: the idea of zuebgirl could stem from the perception that > support of different languages is costly for the project. No it is not; the > architecture of the pluggable scripting machinery only requires a reasonably > compact binding layer, allowing to use the internal published UNO API. The > UNO API, used *universally*, is both the weak and the strong side of OOo/LO; > and the cost of supporting the binding layers is acceptable. The xkcd > reference and everything else is an elitist attitude, allowing OP to think > they can disregard everyone else's needs who use the suite; and is like > saying that every person on the planet must abandon their native language in > favor of language X - just because it's similar to xkcd 927. Yes, but the added cost is seen, for example, in the ports that are attempted to JS/TS now. Fewer people are interested in them now when they can already use them from Python, regardless of what benefits there might be. The result is then two stagnated ecosystems. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)
https://bugs.documentfoundation.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 154168, which changed state. Bug 154168 Summary: FILESAVE: Export selection to .PNG without transparency fails https://bugs.documentfoundation.org/show_bug.cgi?id=154168 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 Paris Oplopoios changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 --- Comment #16 from Paris Oplopoios --- Backported to 7.5 too, marking as fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 Commit Notification changed: What|Removed |Added Whiteboard|target:24.2.0 |target:24.2.0 |target:7.6.0.0.beta2|target:7.6.0.0.beta2 ||target:7.5.5 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - include/vcl vcl/source
include/vcl/bitmapex.hxx |1 +
vcl/source/bitmap/BitmapEx.cxx |5 +
vcl/source/filter/png/PngImageWriter.cxx |8 ++--
3 files changed, 12 insertions(+), 2 deletions(-)
New commits:
commit 21fa75ced1f82b5dd87874a789a13153c09cd283
Author: Paris Oplopoios
AuthorDate: Sat Jun 10 21:33:39 2023 +0300
Commit: Paris Oplopoios
CommitDate: Thu Jun 15 15:01:54 2023 +0200
tdf#154168 Export no transparency PNGs correctly
When bTranslucent was false the function would simply return, causing a
0 byte png. Now we just remove the alpha channel.
Change-Id: Ie2578185ac12fb38b6f1b674758e564721e3973f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152840
Tested-by: Jenkins
Reviewed-by: Paris Oplopoios
(cherry picked from commit 7588c1f33cdaab58a6b84f4f4e75922c5d4a8a7f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152886
Reviewed-by: Xisco Fauli
(cherry picked from commit e691869486cd4ee4ee1dfb8f7a41440f7f6500fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153081
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index f847c9f6dcb2..9dcedc7ffb81 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -56,6 +56,7 @@ public:
boolIsEmpty() const;
voidSetEmpty();
voidClear();
+voidClearAlpha();
voidDraw( OutputDevice* pOutDev,
const Point& rDestPt ) const;
diff --git a/vcl/source/bitmap/BitmapEx.cxx b/vcl/source/bitmap/BitmapEx.cxx
index 6ff2280cdb06..c19ed0f02c3a 100644
--- a/vcl/source/bitmap/BitmapEx.cxx
+++ b/vcl/source/bitmap/BitmapEx.cxx
@@ -190,6 +190,11 @@ void BitmapEx::Clear()
SetEmpty();
}
+void BitmapEx::ClearAlpha()
+{
+maAlphaMask.SetEmpty();
+}
+
bool BitmapEx::IsAlpha() const
{
return !maAlphaMask.IsEmpty();
diff --git a/vcl/source/filter/png/PngImageWriter.cxx
b/vcl/source/filter/png/PngImageWriter.cxx
index f550d9951e64..29d79740009e 100644
--- a/vcl/source/filter/png/PngImageWriter.cxx
+++ b/vcl/source/filter/png/PngImageWriter.cxx
@@ -50,8 +50,6 @@ static bool pngWrite(SvStream& rStream, const BitmapEx&
rBitmapEx, int nCompress
bool bInterlaced, bool bTranslucent,
const std::vector& aAdditionalChunks)
{
-if (rBitmapEx.IsAlpha() && !bTranslucent)
-return false;
if (rBitmapEx.IsEmpty())
return false;
@@ -78,6 +76,12 @@ static bool pngWrite(SvStream& rStream, const BitmapEx&
rBitmapEx, int nCompress
aBitmapEx = rBitmapEx;
}
+if (!bTranslucent)
+{
+// Clear alpha channel
+aBitmapEx.ClearAlpha();
+}
+
Bitmap aBitmap;
AlphaMask aAlphaMask;
Bitmap::ScopedReadAccess pAccess;
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #10 from Mike Kaganski --- One small addendum: the idea of zuebgirl could stem from the perception that support of different languages is costly for the project. No it is not; the architecture of the pluggable scripting machinery only requires a reasonably compact binding layer, allowing to use the internal published UNO API. The UNO API, used *universally*, is both the weak and the strong side of OOo/LO; and the cost of supporting the binding layers is acceptable. The xkcd reference and everything else is an elitist attitude, allowing OP to think they can disregard everyone else's needs who use the suite; and is like saying that every person on the planet must abandon their native language in favor of language X - just because it's similar to xkcd 927. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #9 from Mike Kaganski --- Buovjaga can provide an up-to-date reference to the "let us use a better JS library" idea, which itself is fine, but not easy. But the idea that BASIC or Python support could be deprecated (let alone, dropped) is a no-go. Breaking infinite user documents, extensions, home-made or paid-for macros and other automation tools; breaking internal functionality that depends on e.g. Python (e.g., NumberText and its spell-number used in numbering)... As said, if you want to experiment with dropping them, you are free to fork it. Note that it doesn't men that you are advised to fork just to enhance JS support - these are orthogonal. INVALID. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155776] Slow scrolling, utilizing a CPU core to max
https://bugs.documentfoundation.org/show_bug.cgi?id=155776 --- Comment #2 from Telesto --- Created attachment 187925 --> https://bugs.documentfoundation.org/attachment.cgi?id=187925=edit Sample -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/libjpeg-turbo
external/libjpeg-turbo/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 694c9da5076006275a10373e42a1c6ee4e0dbbeb Author: Julien Nabet AuthorDate: Tue Jun 13 21:07:26 2023 +0200 Commit: Tomaž Vajngerl CommitDate: Thu Jun 15 14:25:27 2023 +0200 libjpeg-turbo is used for import but also export jpeg filter Change-Id: I257db8f1c59ff16d70751fe875594faa8e07e902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153002 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl diff --git a/external/libjpeg-turbo/README b/external/libjpeg-turbo/README index 66ab7ad9660d..7f0065b5f6d5 100644 --- a/external/libjpeg-turbo/README +++ b/external/libjpeg-turbo/README @@ -1,6 +1,6 @@ External library for reading/writing jpegs -This is only used by the jpeg import filter that is provided +This is used by the jpeg import and export filters that are provided for use by VCL see [[vcl/source/filter/jpeg]] From [https://www.libjpeg-turbo.org/].
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #8 from zuebg...@sharklasers.com --- (In reply to Julien Nabet from comment #7) > (In reply to zuebgirl from comment #6) > > (In reply to Julien Nabet from comment #5) > > > I don't know the state of Javascript support in LO but whatever it is, no > > > need to deprecate Python cause it's still widely spread or Basic since it > > > allows compatibility with VB from MsOffice. About Beanshell, I don't know > > > if > > > it's really used or not, I wouldn't be against its deprecation. > > > > > > About Javascript, I'm just a spectator of the race of the frameworks, > > > reactJS, nodeJS, Angular, ... and wonder if this domain is mature enough > > > or > > > if we should wait more. > > > > These are valid concerns, but my arguments against them are: > > > > -There is some momentum to replace or support Python with JS/TS. For > > example, because JS/TS is syntactically nicer language (curly brackets > > etc.). > > I don't see any information about "momentum to replace or support Python" so > could you add some refs? > "syntactically nicer language" thanks to curly brackets, isn't it a bit > subjective? Just a matter of taste for me. Personnally, I'm not against > curly brackets, lots of languages use it (including C++ used for LO) but I > appreciate the elegant way to make block just by indenting in Python. Consider for example: https://github.com/javascriptdata/scikit.js Then consider any of the opinion articles that you can find by searching for "typescript for data science" or similar. Finally, consider that the web browser is dominated by JS/TS. In the case of deploying to the web browser, people have used e.g. Flask for Python and a REST API. This is certainly less elegant than having the pipeline in a single language technology. The curly brackets etc. may make it easier to create advanced tools for the language. https://cjshaver.com/bl0172 > > -Having two fairly similar languages requires ~ double the support, but does > > it give double benefit? > > For those who use Python, it's not a matter to double benefit or not, it's a > matter to be able to program LO or not in Python so 0 or 1. https://xkcd.com/927/ > > -It's not necessary to maintain compatibility with MS Office, and taking > > this goal limits the prospects of LO. It's then a choice between whether > > support for MS Office is a better goal than designing an independent office > > software. > Since LO wants to support docx, xlsx, etc. in addition to odt, ods, ... I > suppose it's necessary. If it's not the case, it would mean to dump OOXML > support completely since quite some people, above all in companies, use > macros, so not sure LO people would be ok but I may be wrong. This could also motivate separate projects. For those that use only open formats, there's no need for MS Office compatibility. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141555] New document has caret in awkward position and paper view is not centered
https://bugs.documentfoundation.org/show_bug.cgi?id=141555 Wolfgang Fahl changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118795] 3D-visualization of complex extruded CustomShapes is bad
https://bugs.documentfoundation.org/show_bug.cgi?id=118795 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #4 from Xisco Faulí --- Still reproducible in Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 244f9cf66bc36f229ccb5712bc8d80166b92266d CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: es-ES (es_ES.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/pdfexport/data/tdf155161.odt |binary
vcl/qa/cppunit/pdfexport/pdfexport.cxx | 40
2 files changed, 40 insertions(+)
New commits:
commit 198a1afe4d4c3c57a0cf6dc69c2494a2b9119751
Author: Khaled Hosny
AuthorDate: Wed Jun 14 16:39:18 2023 +0300
Commit: خالد حسني
CommitDate: Thu Jun 15 13:51:17 2023 +0200
tdf#155161: Add test
The test document embeds Cantarell font because we don’t bundle any
fonts with CFF2 table (or CFF table for that matter).
Change-Id: Icdbab58ea3999baa75bc85fad60172218d9f6058
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153054
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/qa/cppunit/pdfexport/data/tdf155161.odt
b/vcl/qa/cppunit/pdfexport/data/tdf155161.odt
new file mode 100644
index ..1d22bb7c4d01
Binary files /dev/null and b/vcl/qa/cppunit/pdfexport/data/tdf155161.odt differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 0739cd25cd8a..e19f989ce9b9 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -4779,6 +4779,46 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf152246)
}
}
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf155161)
+{
+// TODO: We seem to get a fallback font on Windows
+#ifndef _WIN32
+vcl::filter::PDFDocument aDocument;
+load(u"tdf155161.odt", aDocument);
+
+// Check that all fonts in the document are Type 3 fonts
+int nFonts = 0;
+for (const auto& aElement : aDocument.GetElements())
+{
+auto pObject =
dynamic_cast(aElement.get());
+if (!pObject)
+continue;
+auto pType =
dynamic_cast(pObject->Lookup("Type"));
+if (pType && pType->GetValue() == "Font")
+{
+auto pSubtype =
dynamic_cast(pObject->Lookup("Subtype"));
+CPPUNIT_ASSERT(pSubtype);
+CPPUNIT_ASSERT_EQUAL(OString("Type3"), pSubtype->GetValue());
+
+auto pName =
dynamic_cast(pObject->Lookup("Name"));
+CPPUNIT_ASSERT(pName);
+CPPUNIT_ASSERT_EQUAL(OString("Cantarell-Regular"),
pName->GetValue());
+
+nFonts++;
+}
+}
+
+#ifdef MACOSX
+// There must be two fonts
+CPPUNIT_ASSERT_EQUAL(2, nFonts);
+#else
+// But it seems that embedded variable fonts don’t register all supported
+// styles on Linux, so the bold and regular text use the same regular font.
+CPPUNIT_ASSERT(nFonts);
+#endif
+#endif
+}
+
} // end anonymous namespace
CPPUNIT_PLUGIN_IMPLEMENT();
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #7 from Julien Nabet --- (In reply to zuebgirl from comment #6) > (In reply to Julien Nabet from comment #5) > > I don't know the state of Javascript support in LO but whatever it is, no > > need to deprecate Python cause it's still widely spread or Basic since it > > allows compatibility with VB from MsOffice. About Beanshell, I don't know if > > it's really used or not, I wouldn't be against its deprecation. > > > > About Javascript, I'm just a spectator of the race of the frameworks, > > reactJS, nodeJS, Angular, ... and wonder if this domain is mature enough or > > if we should wait more. > > These are valid concerns, but my arguments against them are: > > -There is some momentum to replace or support Python with JS/TS. For > example, because JS/TS is syntactically nicer language (curly brackets etc.). I don't see any information about "momentum to replace or support Python" so could you add some refs? "syntactically nicer language" thanks to curly brackets, isn't it a bit subjective? Just a matter of taste for me. Personnally, I'm not against curly brackets, lots of languages use it (including C++ used for LO) but I appreciate the elegant way to make block just by indenting in Python. > -Having two fairly similar languages requires ~ double the support, but does > it give double benefit? For those who use Python, it's not a matter to double benefit or not, it's a matter to be able to program LO or not in Python so 0 or 1. > -It's not necessary to maintain compatibility with MS Office, and taking > this goal limits the prospects of LO. It's then a choice between whether > support for MS Office is a better goal than designing an independent office > software. Since LO wants to support docx, xlsx, etc. in addition to odt, ods, ... I suppose it's necessary. If it's not the case, it would mean to dump OOXML support completely since quite some people, above all in companies, use macros, so not sure LO people would be ok but I may be wrong. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155849] LanguageTool extension not working, error message about grammar checking not enabled appears but it is
https://bugs.documentfoundation.org/show_bug.cgi?id=155849 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Mike Kaganski --- (In reply to markus_urban from comment #2) So it looks like a co-incidence, with the JRE giving the LanguageTool extension error messages, and bug 155647 breaking all proofreading function *silently* (no checking will be performed, no errors marked, but no popups). Let me mark it as a duplicate of the latter then. *** This bug has been marked as a duplicate of bug 155647 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113338] [META] Embedded fonts bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113338 خالد حسني changed: What|Removed |Added Depends on||155853 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155853 [Bug 155853] Embedded variable fonts show only the default instance -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155853] Embedded variable fonts show only the default instance
https://bugs.documentfoundation.org/show_bug.cgi?id=155853 خالد حسني changed: What|Removed |Added Blocks||113338 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113338 [Bug 113338] [META] Embedded fonts bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155853] New: Embedded variable fonts show only the default instance
https://bugs.documentfoundation.org/show_bug.cgi?id=155853 Bug ID: 155853 Summary: Embedded variable fonts show only the default instance Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kha...@libreoffice.org Created attachment 187924 --> https://bugs.documentfoundation.org/attachment.cgi?id=187924=edit Test document When opening a document with an embedded variable font on Linux, only the default instance of the embedded font is available. When the font is installed all defined instances are available. Opening the attached document on a system that does not have Cantarell installed (or while setting the env var SAL_NON_APPLICATION_FONT_USE=deny) should show Regular, Thin, Light, Bold, and Extra Bold font styles, but currently only Regular is available the Bold is synthetic. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155849] LanguageTool extension not working, error message about grammar checking not enabled appears but it is
https://bugs.documentfoundation.org/show_bug.cgi?id=155849 --- Comment #2 from markus_ur...@gmx.at --- The error message pops up when I try to access anything from the Extras / LanguageTool menu. Update: As I've seen now, it might be an issue with the JRE I did not have before and have to investigate. It did work just now for a short time. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155852] New: MCGR FILESAVE PPTX export of stepped gradient has wrong colors
https://bugs.documentfoundation.org/show_bug.cgi?id=155852 Bug ID: 155852 Summary: MCGR FILESAVE PPTX export of stepped gradient has wrong colors Product: LibreOffice Version: 7.6.0.0 beta1+ Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Keywords: implementationError Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de CC: armin.le.gr...@me.com Created attachment 187923 --> https://bugs.documentfoundation.org/attachment.cgi?id=187923=edit examples with draw:gradient-step-count=4 Open attached fodp document and export it to pptx. Open saved pptx document and compare it with original fodp document. Errors: Some colors are different from original colors. Some sections have gradients but should be single-colored. I think the problem is, that the step colors are calculated different in rendering in LO than in export to OOXML. Compare the rendering calculation in https://opengrok.libreoffice.org/xref/core/vcl/source/outdev/gradient.cxx?r=dccd82b5#341 with export calculation in https://opengrok.libreoffice.org/xref/core/basegfx/source/tools/bgradient.cxx?r=cdc015ff=doApplySteps#760 Significant difference is on the one hand const double fAlpha = static_cast(i) / fStepsMinus1; and on the other hand const double fSingleStep(1.0 / static_cast(nStepCount)); -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - oox/Library_oox.mk oox/source writerfilter/Library_writerfilter.mk writerfilter/source xmloff/Library_xo.mk xmloff/source
Rebased ref, commits from common ancestor:
commit 31699dc711942bde9d1fb9b64aa9c87217967f81
Author: Tomaž Vajngerl
AuthorDate: Wed Jun 14 11:48:51 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Thu Jun 15 20:12:15 2023 +0900
oox, writerfilter, xmloff: use frozen unordered_map for static data
Change-Id: I4a53fa57f52900104d249c84cde36c9d3b9e1300
diff --git a/oox/Library_oox.mk b/oox/Library_oox.mk
index b878089027b1..3bf2d607918c 100644
--- a/oox/Library_oox.mk
+++ b/oox/Library_oox.mk
@@ -65,6 +65,7 @@ $(eval $(call gb_Library_use_libraries,oox,\
$(eval $(call gb_Library_use_externals,oox,\
boost_headers \
+ frozen \
))
ifeq ($(TLS),OPENSSL)
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index ad0b5ca7835e..6660c6bd2660 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -19,7 +19,9 @@
#include
#include
-#include
+#include
+#include
+#include
#include
#include
#include
@@ -214,39 +216,40 @@ void lclOffValue( sal_Int32& ornValue, sal_Int32 nOff,
sal_Int32 nMax = MAX_PERC
ornValue = getLimitedValue< sal_Int32, sal_Int32 >( ornValue + nOff, 0,
nMax );
}
+static constexpr frozen::unordered_map aSchemeColorNameToIndex
+{
+{ u"dk1", model::ThemeColorType::Dark1 },
+{ u"lt1", model::ThemeColorType::Light1 },
+{ u"dk2", model::ThemeColorType::Dark2 },
+{ u"lt2", model::ThemeColorType::Light2 },
+{ u"accent1", model::ThemeColorType::Accent1 },
+{ u"accent2", model::ThemeColorType::Accent2 },
+{ u"accent3", model::ThemeColorType::Accent3 },
+{ u"accent4", model::ThemeColorType::Accent4 },
+{ u"accent5", model::ThemeColorType::Accent5 },
+{ u"accent6", model::ThemeColorType::Accent6 },
+{ u"hlink", model::ThemeColorType::Hyperlink },
+{ u"folHlink", model::ThemeColorType::FollowedHyperlink },
+{ u"tx1", model::ThemeColorType::Dark1 },
+{ u"bg1", model::ThemeColorType::Light1 },
+{ u"tx2", model::ThemeColorType::Dark2 },
+{ u"bg2", model::ThemeColorType::Light2 },
+{ u"dark1", model::ThemeColorType::Dark1},
+{ u"light1", model::ThemeColorType::Light1},
+{ u"dark2", model::ThemeColorType::Dark2 },
+{ u"light2", model::ThemeColorType::Light2 },
+{ u"text1", model::ThemeColorType::Dark1 },
+{ u"background1", model::ThemeColorType::Light1 },
+{ u"text2", model::ThemeColorType::Dark2 },
+{ u"background2", model::ThemeColorType::Light2 },
+{ u"hyperlink", model::ThemeColorType::Hyperlink },
+{ u"followedHyperlink", model::ThemeColorType::FollowedHyperlink }
+};
+
} // namespace
model::ThemeColorType schemeNameToThemeColorType(OUString const& rSchemeName)
{
-static std::unordered_map const
aSchemeColorNameToIndex{
-{ u"dk1", model::ThemeColorType::Dark1 },
-{ u"lt1", model::ThemeColorType::Light1 },
-{ u"dk2", model::ThemeColorType::Dark2 },
-{ u"lt2", model::ThemeColorType::Light2 },
-{ u"accent1", model::ThemeColorType::Accent1 },
-{ u"accent2", model::ThemeColorType::Accent2 },
-{ u"accent3", model::ThemeColorType::Accent3 },
-{ u"accent4", model::ThemeColorType::Accent4 },
-{ u"accent5", model::ThemeColorType::Accent5 },
-{ u"accent6", model::ThemeColorType::Accent6 },
-{ u"hlink", model::ThemeColorType::Hyperlink },
-{ u"folHlink", model::ThemeColorType::FollowedHyperlink },
-{ u"tx1", model::ThemeColorType::Dark1 },
-{ u"bg1", model::ThemeColorType::Light1 },
-{ u"tx2", model::ThemeColorType::Dark2 },
-{ u"bg2", model::ThemeColorType::Light2 },
-{ u"dark1", model::ThemeColorType::Dark1},
-{ u"light1", model::ThemeColorType::Light1},
-{ u"dark2", model::ThemeColorType::Dark2 },
-{ u"light2", model::ThemeColorType::Light2 },
-{ u"text1", model::ThemeColorType::Dark1 },
-{ u"background1", model::ThemeColorType::Light1 },
-{ u"text2", model::ThemeColorType::Dark2 },
-{ u"background2", model::ThemeColorType::Light2 },
-{ u"hyperlink", model::ThemeColorType::Hyperlink },
-{ u"followedHyperlink", model::ThemeColorType::FollowedHyperlink}
-};
-
auto aIterator = aSchemeColorNameToIndex.find(rSchemeName);
if (aIterator == aSchemeColorNameToIndex.end())
return model::ThemeColorType::Unknown;
diff --git a/oox/source/drawingml/colorchoicecontext.cxx
b/oox/source/drawingml/colorchoicecontext.cxx
index b0977c5e003c..04b9f996d8d5 100644
--- a/oox/source/drawingml/colorchoicecontext.cxx
+++ b/oox/source/drawingml/colorchoicecontext.cxx
@@ -24,13 +24,16 @@
#include
#include
#include
+#include
+#include
+#include
namespace oox::drawingml {
namespace
{
-const std::unordered_map
constSystemColorMap =
+static constexpr frozen::unordered_map
constSystemColorMap
{
{ XML_scrollBar, model::SystemColorType::ScrollBar },
{ XML_background,
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/pdfwriter_impl.cxx | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
New commits:
commit 845fbfcce9091e541bab657163b026aad8648261
Author: Khaled Hosny
AuthorDate: Thu Jun 15 06:27:38 2023 +0300
Commit: خالد حسني
CommitDate: Thu Jun 15 13:12:39 2023 +0200
Don’t add empty Fonts dictionary to Type 3 font resources
If the Type 3 font does not use any other fonts, skip writing Fonts to
its Resources dictionary.
Change-Id: I1d0489debeb9f0e24022316551eb234b279381c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153100
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 48ed2ffe3be5..0c5fc8401a43 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2756,22 +2756,26 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
}
// write font dict
-auto nFontDict = createObject();
-aLine.setLength(0);
-aLine.append(OString::number(nFontDict) + " 0 obj\n<<");
-for (auto nFontID : aUsedFonts)
+auto nFontDict = -1;
+if (!aUsedFonts.empty())
{
-aLine.append("/F"
-+ OString::number(nFontID)
-+ " "
-+ OString::number(rFontIDToObject[nFontID])
-+ " 0 R");
+nFontDict = createObject();
+aLine.setLength(0);
+aLine.append(OString::number(nFontDict) + " 0 obj\n<<");
+for (auto nFontID : aUsedFonts)
+{
+aLine.append("/F"
++ OString::number(nFontID)
++ " "
++ OString::number(rFontIDToObject[nFontID])
++ " 0 R");
+}
+aLine.append(">>\nendobj\n\n");
+if (!updateObject(nFontDict))
+return false;
+if (!writeBuffer(aLine))
+return false;
}
-aLine.append(">>\nendobj\n\n");
-if (!updateObject(nFontDict))
-return false;
-if (!writeBuffer(aLine))
-return false;
// write ExtGState objects
if (!aUsedAlpha.empty())
@@ -2807,7 +2811,8 @@ bool PDFWriterImpl::emitType3Font(const
vcl::font::PhysicalFontFace* pFace,
// write resources dict
aLine.setLength(0);
aLine.append(OString::number(nResources) + " 0 obj\n");
-aResourceDict.append(aLine, nFontDict);
+if (!aUsedFonts.empty())
+aResourceDict.append(aLine, nFontDict);
aLine.append("endobj\n\n");
if (!updateObject(nResources))
return false;
[Libreoffice-bugs] [Bug 155851] New: Phrase checking: in multi-word dictionary items each word is still marked as error
https://bugs.documentfoundation.org/show_bug.cgi?id=155851 Bug ID: 155851 Summary: Phrase checking: in multi-word dictionary items each word is still marked as error Product: LibreOffice Version: 7.6.0.0 beta1+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rgb.m...@gmail.com CC: so...@libreoffice.org This is a follow up of Bug 154499. In 7.6, suppose you add the Latin phrase "ad hoc" to your user dictionary. When you go to a document that uses that dictionary and type "ad hoc," the term "hoc" is marked as an error even if the combination is now correct. Expectations (& results): Type "ad hoc" and the phrase is recognized as correct (doesn't work). Type only "hoc" → the spellchecker recognize hoc as an error (work) and suggest "ad hoc" (doesn't work). Type "a hoc" → the spellchecker recognize both words as a *single* error and suggest "ad hoc" (doesn't work). Type "ahoc" or "adhoc" → the spellchecker recognize them as an error and suggest "ad hoc" (work... *but* when you continue editing the paragraph the word "hoc" is marked as an error). Note about the last point: There is an inconsistent behavior with the spellchecker. As soon as the substitution is inserted, the word "hoc" is NOT marked as an error, but if you later edit the paragraph close to that word, it get marked. Also, sometimes a word that's marked gets unmarked... I'm not able to figure out what's going on or what triggers the behavior. Note 2: adding the word "hoc" to the dictionary is not a solution, because the word alone is an error, it must go with "ad" before it. Tested with: Version: 7.6.0.0.beta1 (X86_64) / LibreOffice Community Build ID: be55b15d98c5f059483845a183fcb5ea8023d27c CPU threads: 8; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb) Locale: es-ES (es_ES.UTF-8); UI: es-ES Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: i18npool/inc i18npool/source
i18npool/inc/localedata.hxx |4 +-
i18npool/source/localedata/LocaleNode.cxx | 59 +-
i18npool/source/localedata/localedata.cxx | 41 +---
3 files changed, 55 insertions(+), 49 deletions(-)
New commits:
commit 88304309b57abe1e50395c5f71862fabcd1c752e
Author: Noel Grandin
AuthorDate: Wed Jun 14 13:22:24 2023 +0200
Commit: Noel Grandin
CommitDate: Thu Jun 15 13:05:29 2023 +0200
speed up startup time
by avoid conversion of static locale data from sal_Unicode to OUString
data - we can declare the data as OUStringConstExpr arrays and then
no conversion is necessary.
Change-Id: Iae879408d6761098d0e73526a65863d8f3cdb9ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153059
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/i18npool/inc/localedata.hxx b/i18npool/inc/localedata.hxx
index 063637ca67f9..f4cd15a30254 100644
--- a/i18npool/inc/localedata.hxx
+++ b/i18npool/inc/localedata.hxx
@@ -149,8 +149,8 @@ private:
/// @throws css::uno::RuntimeException
oslGenericFunction getFunctionSymbol( const css::lang::Locale& rLocale,
const char* pFunction );
-sal_Unicode ** getIndexArray(const css::lang::Locale& rLocale, sal_Int16&
indexCount);
-sal_Unicode ** getIndexArrayForAlgorithm(const css::lang::Locale& rLocale,
std::u16string_view rAlgorithm);
+OUString const * getIndexArray(const css::lang::Locale& rLocale,
sal_Int16& indexCount);
+OUString const * getIndexArrayForAlgorithm(const css::lang::Locale&
rLocale, std::u16string_view rAlgorithm);
/// @throws css::uno::RuntimeException
css::uno::Sequence< css::i18n::CalendarItem2 > &
getCalendarItemByName(const OUString& name,
diff --git a/i18npool/source/localedata/LocaleNode.cxx
b/i18npool/source/localedata/LocaleNode.cxx
index b70cae2c713f..49024a6bc97f 100644
--- a/i18npool/source/localedata/LocaleNode.cxx
+++ b/i18npool/source/localedata/LocaleNode.cxx
@@ -1430,9 +1430,9 @@ void LCIndexNode::generateCode (const OFileWriter )
const
OUString useLocale = getAttr().getValueByName("ref");
if (!useLocale.isEmpty()) {
useLocale = useLocale.replace( '-', '_');
-of.writeRefFunction("getIndexAlgorithm_", useLocale);
-of.writeRefFunction("getUnicodeScripts_", useLocale);
-of.writeRefFunction("getFollowPageWords_", useLocale);
+of.writeOUStringRefFunction("getIndexAlgorithm_", useLocale);
+of.writeOUStringRefFunction("getUnicodeScripts_", useLocale);
+of.writeOUStringRefFunction("getFollowPageWords_", useLocale);
return;
}
sal_Int16 nbOfIndexs = 0;
@@ -1444,28 +1444,28 @@ void LCIndexNode::generateCode (const OFileWriter )
const
{
OUString str;
str = currNode->getAttr().getValueByName("unoid");
-of.writeParameter("IndexID", str, nbOfIndexs);
+of.writeOUStringLiteralParameter("IndexID", str, nbOfIndexs);
str = currNode->getAttr().getValueByName("module");
-of.writeParameter("IndexModule", str, nbOfIndexs);
+of.writeOUStringLiteralParameter("IndexModule", str, nbOfIndexs);
str = currNode->getValue();
-of.writeParameter("IndexKey", str, nbOfIndexs);
+of.writeOUStringLiteralParameter("IndexKey", str, nbOfIndexs);
str = currNode -> getAttr().getValueByName("default");
-of.writeDefaultParameter("Index", str, nbOfIndexs);
+of.writeOUStringLiteralDefaultParameter("Index", str, nbOfIndexs);
str = currNode -> getAttr().getValueByName("phonetic");
-of.writeDefaultParameter("Phonetic", str, nbOfIndexs);
+of.writeOUStringLiteralDefaultParameter("Phonetic", str,
nbOfIndexs);
of.writeAsciiString("\n");
nbOfIndexs++;
}
if( currNode->getName() == "UnicodeScript" )
{
-of.writeParameter("unicodeScript", currNode->getValue(),
nbOfUnicodeScripts );
+of.writeOUStringLiteralParameter("unicodeScript",
currNode->getValue(), nbOfUnicodeScripts );
nbOfUnicodeScripts++;
}
if( currNode->getName() == "FollowPageWord" )
{
-of.writeParameter("followPageWord", currNode->getValue(),
nbOfPageWords);
+of.writeOUStringLiteralParameter("followPageWord",
currNode->getValue(), nbOfPageWords);
nbOfPageWords++;
}
}
@@ -1473,7 +1473,7 @@ void LCIndexNode::generateCode (const OFileWriter )
const
of.writeInt(nbOfIndexs);
of.writeAsciiString(";\n\n");
-of.writeAsciiString("\nstatic const sal_Unicode* IndexArray[] = {\n");
+of.writeAsciiString("\nstatic constexpr rtl::OUStringConstExpr
IndexArray[] = {\n");
for(sal_Int16 i = 0; i < nbOfIndexs; i++) {
of.writeAsciiString("\tIndexID");
of.writeInt(i);
@@ -1501,30 +1501,41 @@ void
[Libreoffice-bugs] [Bug 155850] pasting multiple of the same emoji makes them overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=155850 --- Comment #2 from rasa.putn...@gmail.com --- restarting in normal mode, fixes it mostly, still deletes with two backspaces, but doesn't overlap aanymore, sorry if the bug report is waste of time -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155850] pasting multiple of the same emoji makes them overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=155850 rasa.putn...@gmail.com changed: What|Removed |Added Alias||vaarna -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155850] pasting multiple of the same emoji makes them overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=155850 --- Comment #1 from rasa.putn...@gmail.com --- Created attachment 187922 --> https://bugs.documentfoundation.org/attachment.cgi?id=187922=edit image of the glitch -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155850] New: pasting multiple of the same emoji makes them overlap
https://bugs.documentfoundation.org/show_bug.cgi?id=155850 Bug ID: 155850 Summary: pasting multiple of the same emoji makes them overlap Product: LibreOffice Version: 7.5.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rasa.putn...@gmail.com Description: was pasting multiple "eye in the speech bubble" colour emoji got rendered on top of text and each other. also if i select the eye in the speech bubble emoji sometimes it pastes an eye emoji. i presume i just picked some kind of hybrid two emoji in one and Writer is having trouble, i relate. also if pasted too many in a row they overlap (themselves and text), and take two backspace presses to delete (after the first one it changes to the eye emoji) Steps to Reproduce: 1.paste emoji (eye in speech bubble) a few times 2.write in the same line 3. Actual Results: emojis are overlapping text and themselves Expected Results: row of eye in the speech bubble emojis Reproducible: Sometimes User Profile Reset: No Additional Info: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-US Calc: threaded okay damn, in safe mode it doesn't paste colored emoji at all just the black and white, those work fine, i have no idea how in few hours of using LibreOffice i scrambled the settings so much. thank you, for your work and cheers -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155786] [Feature proposal] Migrate all scripting to QuickJS/JavaScript
https://bugs.documentfoundation.org/show_bug.cgi?id=155786 --- Comment #6 from zuebg...@sharklasers.com --- (In reply to Julien Nabet from comment #5) > I don't know the state of Javascript support in LO but whatever it is, no > need to deprecate Python cause it's still widely spread or Basic since it > allows compatibility with VB from MsOffice. About Beanshell, I don't know if > it's really used or not, I wouldn't be against its deprecation. > > About Javascript, I'm just a spectator of the race of the frameworks, > reactJS, nodeJS, Angular, ... and wonder if this domain is mature enough or > if we should wait more. These are valid concerns, but my arguments against them are: -There is some momentum to replace or support Python with JS/TS. For example, because JS/TS is syntactically nicer language (curly brackets etc.). -Having two fairly similar languages requires ~ double the support, but does it give double benefit? -It's not necessary to maintain compatibility with MS Office, and taking this goal limits the prospects of LO. It's then a choice between whether support for MS Office is a better goal than designing an independent office software. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svgio/qa svgio/source
svgio/qa/cppunit/SvgImportTest.cxx | 13 ++
svgio/qa/cppunit/data/tdf155833.svg | 31
svgio/source/svgreader/svgimagenode.cxx | 60 +---
3 files changed, 70 insertions(+), 34 deletions(-)
New commits:
commit 472d7ce57bdf1473538dda23c9328d44cdf816c8
Author: Xisco Fauli
AuthorDate: Thu Jun 15 10:10:38 2023 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 15 12:39:16 2023 +0200
tdf#155833: apply transform to image even if target is equal to viewbox
Change-Id: Ie820528384d096c6a332e2abd0095f68c7f64a0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153103
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx
b/svgio/qa/cppunit/SvgImportTest.cxx
index bdfbfcccb911..7184c5fa500b 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -423,6 +423,19 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf45771)
assertXPath(pDocument, "/primitive2D/transform/textsimpleportion[1]",
"familyname", "Times New Roman");
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf155833)
+{
+Primitive2DSequence aSequence =
parseSvg(u"/svgio/qa/cppunit/data/tdf155833.svg");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument = dumper.dumpAndParse(aSequence);
+
+CPPUNIT_ASSERT (pDocument);
+
+assertXPath(pDocument,
"/primitive2D/transform/mask/transform/transform/transform/transform/transform/bitmap",
1);
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf97941)
{
//Check tspan fontsize when using relative units
diff --git a/svgio/qa/cppunit/data/tdf155833.svg
b/svgio/qa/cppunit/data/tdf155833.svg
new file mode 100644
index ..8cc908424af0
--- /dev/null
+++ b/svgio/qa/cppunit/data/tdf155833.svg
@@ -0,0 +1,31 @@
+
+
+
+http://www.w3.org/1999/xlink;
+ xmlns="http://www.w3.org/2000/svg;
+ xmlns:svg="http://www.w3.org/2000/svg;>
+
+
+
+
+
+
+
+
diff --git a/svgio/source/svgreader/svgimagenode.cxx
b/svgio/source/svgreader/svgimagenode.cxx
index ed7b81cef61a..19c8c9404541 100644
--- a/svgio/source/svgreader/svgimagenode.cxx
+++ b/svgio/source/svgreader/svgimagenode.cxx
@@ -310,45 +310,37 @@ namespace svgio::svgreader
if(aNewTarget.empty())
return;
-if(aTarget.equal(aViewBox))
-{
-// just add to rTarget
-rTarget.append(aNewTarget);
-}
-else
-{
-// create mapping
-const SvgAspectRatio& rRatio = maSvgAspectRatio;
+// create mapping
+const SvgAspectRatio& rRatio = maSvgAspectRatio;
-// even when ratio is not set, use the defaults
-// let mapping be created from SvgAspectRatio
-const basegfx::B2DHomMatrix
aEmbeddingTransform(rRatio.createMapping(aTarget, aViewBox));
+// even when ratio is not set, use the defaults
+// let mapping be created from SvgAspectRatio
+const basegfx::B2DHomMatrix
aEmbeddingTransform(rRatio.createMapping(aTarget, aViewBox));
-if(!aEmbeddingTransform.isIdentity())
-{
-const drawinglayer::primitive2d::Primitive2DReference xRef(
-new drawinglayer::primitive2d::TransformPrimitive2D(
-aEmbeddingTransform,
-std::move(aNewTarget)));
-
-aNewTarget =
drawinglayer::primitive2d::Primitive2DContainer { xRef };
-}
+if(!aEmbeddingTransform.isIdentity())
+{
+const drawinglayer::primitive2d::Primitive2DReference xRef(
+new drawinglayer::primitive2d::TransformPrimitive2D(
+aEmbeddingTransform,
+std::move(aNewTarget)));
-if(!rRatio.isMeetOrSlice())
-{
-// need to embed in MaskPrimitive2D to ensure clipping
-const drawinglayer::primitive2d::Primitive2DReference
xMask(
-new drawinglayer::primitive2d::MaskPrimitive2D(
-basegfx::B2DPolyPolygon(
-
basegfx::utils::createPolygonFromRect(aTarget)),
-std::move(aNewTarget)));
-
-aNewTarget =
drawinglayer::primitive2d::Primitive2DContainer { xMask };
-}
+aNewTarget = drawinglayer::primitive2d::Primitive2DContainer {
xRef };
+}
-// embed and add to rTarget, take local extra-transform into
account
-pStyle->add_postProcess(rTarget, std::move(aNewTarget),
getTransform());
+if(!rRatio.isMeetOrSlice())
+{
+// need to embed in
[Libreoffice-bugs] [Bug 155849] LanguageTool extension not working, error message about grammar checking not enabled appears but it is
https://bugs.documentfoundation.org/show_bug.cgi?id=155849 --- Comment #1 from Mike Kaganski --- (In reply to markus_urban from comment #0) > An error message about grammar checking not enabled in > the settings appears on every attempt, even when it enabled. This puzzles me - can you elaborate, which "attempt" is meant that gives this problem? I.e., which specific actions (key presses, menu items, ...) result in this. Otherwise, it looks like a dupe of bug 155647, which is fixed for 7.5.5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140034] SPELL CHECKING DIALOG: It's not possible to change the size of the dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=140034 --- Comment #3 from R. Green --- Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-GB Calc: threaded The problem still stands. The text in the spell-check box is too small and not resizeable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155849] New: LanguageTool extension not working, error message about grammar checking not enabled appears but it is
https://bugs.documentfoundation.org/show_bug.cgi?id=155849 Bug ID: 155849 Summary: LanguageTool extension not working, error message about grammar checking not enabled appears but it is Product: LibreOffice Version: 7.5.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: markus_ur...@gmx.at Description: After updating to LibreOffice 7.5.4.2. LanguageTool was disabled and could not be enabled again. An error message about grammar checking not enabled in the settings appears on every attempt, even when it enabled. This seems to affect both the locally installed and the online version. It used to work quite fine in the previous version. Steps to Reproduce: 1. Trying to access the LanguageTool setting in the Extras menu 2. Error message appears 3. Repeated selecting / unselecting / enabling / disabling / restaring does not fix it Actual Results: still does not work Expected Results: might take some time at startup by experience, but it does not work at all Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-AT (de_AT); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=143002 László Németh changed: What|Removed |Added Depends on||155846 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155846 [Bug 155846] Change tracking error while moving a column. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155846] Change tracking error while moving a column.
https://bugs.documentfoundation.org/show_bug.cgi?id=155846 László Németh changed: What|Removed |Added Ever confirmed|0 |1 Blocks||143002 Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Status|UNCONFIRMED |ASSIGNED CC||nem...@numbertext.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143002 [Bug 143002] [META] Tracked Changes of tables -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155847] Change manager error
https://bugs.documentfoundation.org/show_bug.cgi?id=155847 László Németh changed: What|Removed |Added Ever confirmed|0 |1 Blocks||143002 CC||nem...@numbertext.org Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |nem...@numbertext.org |desktop.org | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143002 [Bug 143002] [META] Tracked Changes of tables -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables
https://bugs.documentfoundation.org/show_bug.cgi?id=143002 László Németh changed: What|Removed |Added Depends on||155847 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=155847 [Bug 155847] Change manager error -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: download.lst
download.lst |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3f6bb9565d4edce563dbd938c655ae853926d362 Author: Taichi Haradaguchi <20001...@ymail.ne.jp> AuthorDate: Thu Jun 15 07:09:06 2023 +0900 Commit: Michael Stahl CommitDate: Thu Jun 15 11:44:23 2023 +0200 nss: upgrade to release 3.90 Change-Id: Ic446f33abd5355886b8c8c181a088c07ea4605c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153096 Tested-by: Jenkins Reviewed-by: Michael Stahl diff --git a/download.lst b/download.lst index ac149a0d3873..80edf6a84a49 100644 --- a/download.lst +++ b/download.lst @@ -392,8 +392,8 @@ MYTHES_TARBALL := mythes-1.2.5.tar.xz # three static lines # so that git cherry-pick # will not run into conflicts -NSS_SHA256SUM := fcfa26d2738ec5b0cf72ab4be784eac832a75132cda2e295799c04d62a93607a -NSS_TARBALL := nss-3.88.1-with-nspr-4.35.tar.gz +NSS_SHA256SUM := f78ab1d911cae8bbc94758fb3bd0f731df4087423a4ff5db271ba65381f6b739 +NSS_TARBALL := nss-3.90-with-nspr-4.35.tar.gz # three static lines # so that git cherry-pick # will not run into conflicts
[Libreoffice-bugs] [Bug 155848] CSV import improperly import floats as text prefixed by a hidden apostrophe
https://bugs.documentfoundation.org/show_bug.cgi?id=155848 --- Comment #1 from Mike Kaganski --- If 0.65 appeared in a CSV, and got imported as text, and shows '0.65 in the edit line, all this means: 1. That the locale defined in the import dialog uses comma as decimal separator; 2. And that the locale set in your spreadsheet cells uses dot as decimal separator. In essence, it is a user error of not setting the CSV import settings properly in the dialog, and not a bug. Of course, it's just an educated guess, in the absence of a sample CSV. You should either set the locale in the import dialog to e.g. en-US (if all the data in the CSV uses those conventions), or you may select "USA" per-column there in the dialog, if the data happens to be mixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115236] Don't strip out "." from hyperlink file://./subdirectory/file.xyz when exporting to SVG
https://bugs.documentfoundation.org/show_bug.cgi?id=115236 Stephan Bergmann changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Stephan Bergmann --- (In reply to UbunLibOffImp from comment #0) > c] Impress should never strip out "." character when used as the first > character in a relative link in a *.odp that is exported to type *.svg > (example [c] = Insert > Link type > DOCUMENT > DOCUMENT PATH: > "file://./subdirectory/file.xyz") > (result [c] = when the *.svg is opened in above listed web browser, > hyperlink becomes "file:///subdirectory/file.svg" and is dead since it is > not resolved correctly) ( is not a relative URL. It is an absolute file URL whose authority component is a host denoting the registered name "."; whatever that is supposed to mean semantically.) I cannot reproduce this claim of LO stripping out ".": The resulting svg file contains the exact text "file://./subdirectory/file.xyz" eight times. It does not contain "subdirectory" in any other place (i.e., it does not also contain the text "file:///subdirectory/file.xyz" or something similar), which could indicate that LO does garble the specified URL when exporting to svg. (When I open that svg file in Firefox, following the link makes it indeed try to open , dropping the "." host. But that appears to be an issue of Firefox. In its inspector window, one still sees > xlink:href="file://./subdirectory/file.xyz">file://./subdirectory/file.x as the source of the link.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155848] New: CSV import improperly import floats as text prefixed by a hidden apostrophe
https://bugs.documentfoundation.org/show_bug.cgi?id=155848 Bug ID: 155848 Summary: CSV import improperly import floats as text prefixed by a hidden apostrophe Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mmokr...@fold.natur.cuni.cz Hi, the CSV import is terribly broken and Libreoffice Calc too on its own. The fields containing float numbers get imported as '0.65 instead of just 0.65. Because the leading apostrophe is NOT show in the table but ONLY on the EDITIng line it took me ages to realize it. Instead I was just blindly to set the Format -> Cells -> Numbers to some othe Category that current "Number". It did not help because the leading apostrophe is in place. It should have been REMOVED by this action. Once somebody told me about the Data -> Text to columns I could FIX the table importred via the broken import procedure but only column by colum (one cannot select multiple columns or cells spanning more than one column). One can do: Data -> Text to columsn -> Set the Other delimiter to the ' tick and click OK Set the cell content to Number via Format -> Cells -> Numbers . Then, you can use =SUM() or =AVG() functions over those cells to continue what used to work in the past. SUM() and AVG() function could be smart enough to act on text fields and try to interpret the contents as numbers. I do not see a point why during CSV import the contents should NOT be tried to be set to Number whenever possible. Or the import procedure should ASK user or provide a table for data format review upon import, emphasizing cells which are currently defined as TEXT but could have been Number. Either way, if sombody goes to Format -> Cells -> Numbers it should remove those offending ticks or at least give an error message. It is a pity whole column because typically on first line we have column descriptions which are TEXT, right? Ability to perform Data -> Text to columns trickery over multiple cells spanning more than one comlumn would be very helpful. Yes, the thousands separator ',' got interpreted regardles of my locale as a decimal dot so 12,600 (twelve thousand 6 hundred) turned into 12,6. But that is another story. Thank youf for any efforts to fix these. Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 50(Build:2) CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Gentoo official package Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155529] MariaDB/MySQL direct connection: Trying to insert NULL in NOT NULL fields will automatically changed in empty text or 0
https://bugs.documentfoundation.org/show_bug.cgi?id=155529 Alex Thurgood changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 Stéphane Guillou (stragu) changed: What|Removed |Added Component|Draw|filters and storage --- Comment #14 from Stéphane Guillou (stragu) --- Paris, I just verified the fix with exporting a Calc selection without transparency, in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: ec60d354359067f8c5c686ef2239ee705916de43 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thank you! I think you can mark as resolved - fixed. It would be great to get it backported to 7.5 too, as we already have 3 duplicate reports and it affects all components, not just Draw. I tried cherrypicking on gerrit (first time I try it) but I get a merge conflict. Can you please have a look? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155529] MariaDB/MySQL direct connection: Trying to insert NULL in NOT NULL fields will automatically changed in empty text or 0
https://bugs.documentfoundation.org/show_bug.cgi?id=155529 Alex Thurgood changed: What|Removed |Added Keywords||bibisectRequest --- Comment #3 from Alex Thurgood --- I don't recall this behaviour in older versions of LO, but can not test them on macOS. This would appear to be a regression. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131100] : Link to external .ods file returns incorrect data
https://bugs.documentfoundation.org/show_bug.cgi?id=131100 --- Comment #15 from Sophie Sipasseuth --- Like Julien => warning for macro and it asks me to enable or disable - I chose "disable" => a warning in top of grid appears telling: "Automatic update of external links has been disabled" + button "Allow updating" After that, No repro, all links are working, with this version of Libre Office: Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: f97a7b965be154824e108802b386e3132b0a237a CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155529] MariaDB/MySQL direct connection: Trying to insert NULL in NOT NULL fields will automatically changed in empty text or 0
https://bugs.documentfoundation.org/show_bug.cgi?id=155529 Alex Thurgood changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Alex Thurgood --- I can reproduce this in a direct connection against a MySQL server instance with Version: 7.5.1.2 (AARCH64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Raster; VCL: osx Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155529] MariaDB/MySQL direct connection: Trying to insert NULL in NOT NULL fields will automatically changed in empty text or 0
https://bugs.documentfoundation.org/show_bug.cgi?id=155529 Alex Thurgood changed: What|Removed |Added Summary|MariaDB direct connection: |MariaDB/MySQL direct |Trying to insert NULL in|connection: Trying to |NOT NULL fields will|insert NULL in NOT NULL |automatically changed in|fields will automatically |empty text or 0 |changed in empty text or 0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154168] FILESAVE: Export selection to .PNG without transparency fails
https://bugs.documentfoundation.org/show_bug.cgi?id=154168 Stéphane Guillou (stragu) changed: What|Removed |Added CC||wilson.pedros...@gmail.com --- Comment #13 from Stéphane Guillou (stragu) --- *** Bug 155844 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155844] Calc - file PNG zero size when export a sheet selection
https://bugs.documentfoundation.org/show_bug.cgi?id=155844 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||stephane.guillou@libreoffic ||e.org --- Comment #1 from Stéphane Guillou (stragu) --- I assume this happens when you have the option "save transparency" turned off, in which case this is a duplicate of bug 154168. Paris has already submitted a fix, and we will hopefully get it into 7.5.5 (it's already in versions 7.6 and 24.2). Thanks for the report! *** This bug has been marked as a duplicate of bug 154168 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155842] The font "Avrile" has 18 styles, I installed all successfully, but I can only see and use one.
https://bugs.documentfoundation.org/show_bug.cgi?id=155842 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |NOTABUG CC||stephane.guillou@libreoffic ||e.org --- Comment #4 from Stéphane Guillou (stragu) --- Thank you both! Closing as "not a bug". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155842] The font "Avrile" has 18 styles, I installed all successfully, but I can only see and use one.
https://bugs.documentfoundation.org/show_bug.cgi?id=155842 --- Comment #3 from Sonam --- (In reply to خالد حسني from comment #2) > You should be able to see all styles from the font tab: > https://help.libreoffice.org/latest/en-US/text/shared/01/05020100.html > > If they are not shown there, please provide more information on how to > obtain the font. Thank you so much. I guess, I just did not know how to use the program properly. I expected some drop down function for the different styles, like I saw in Word before. Many thanks. I can now work with it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122968] Stuttering/ judder while scrolling using page down (pages per second rate has worsened)
https://bugs.documentfoundation.org/show_bug.cgi?id=122968 --- Comment #7 from Sophie Sipasseuth --- My computer needs 2 or 3 seconds to pass from the first page to the last page when I use the scrollbar manually (with or without the CPU opening). If I use the arrow down of the scrollbar, after 10 seconds, the page display is the end of the second page and the beginning of the third page (with or without the CPU opening). If I use the arrow down key of my keyboard, in 10 seconds, the page display is page 11 (without the CPU opening). If I use the arrow down key of my keyboard, with the CPU opening, my computer stops running temporarily. Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: f97a7b965be154824e108802b386e3132b0a237a CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154929] [META] Accessibility Check sidebar deck, Automatic Accessibility Checking
https://bugs.documentfoundation.org/show_bug.cgi?id=154929 Bug 154929 depends on bug 155728, which changed state. Bug 155728 Summary: A11y sidebar: Update issue list after fixing an issue https://bugs.documentfoundation.org/show_bug.cgi?id=155728 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155833] svg import inverses rows of checkerboard colored image
https://bugs.documentfoundation.org/show_bug.cgi?id=155833 Xisco Faulí changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |xiscofa...@libreoffice.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: framework/source
framework/source/uielement/recentfilesmenucontroller.cxx | 47 ++-
1 file changed, 34 insertions(+), 13 deletions(-)
New commits:
commit 651d60f79c28c9a8e456817990c21a404c69d700
Author: Andreas Heinisch
AuthorDate: Tue Jun 6 23:33:12 2023 +0200
Commit: Andreas Heinisch
CommitDate: Thu Jun 15 09:54:55 2023 +0200
tdf#155699 - MRU: show pinned documents at the beginning of the list
Change-Id: Id08678708ee74a4a278baa1e67930044f25e5d5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152690
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch
diff --git a/framework/source/uielement/recentfilesmenucontroller.cxx
b/framework/source/uielement/recentfilesmenucontroller.cxx
index 194f66d1476f..e630dda1cba3 100644
--- a/framework/source/uielement/recentfilesmenucontroller.cxx
+++ b/framework/source/uielement/recentfilesmenucontroller.cxx
@@ -165,35 +165,50 @@ void RecentFilesMenuController::fillPopupMenu( Reference<
css::awt::XPopupMenu >
= officecfg::Office::Common::History::ShowCurrentModuleOnly::get();
size_t nItemPosModule = 0;
+size_t nItemPosPinned = 0;
if (( nPickListMenuItems > 0 ) && !m_bDisabled )
{
size_t nItemPos = 0;
+
+// tdf#155699 - create a lambda to insert a recent document item at a
specified position
+auto insertHistoryItemAtPos =
+[&](const SvtHistoryOptions::HistoryItem& rPickListEntry, const
size_t aInsertPosition)
+{
+m_aRecentFilesItems.insert(m_aRecentFilesItems.begin() +
aInsertPosition,
+ { rPickListEntry.sURL,
rPickListEntry.isReadOnly });
+nItemPos++;
+};
+
if (m_aModuleName != "com.sun.star.frame.StartModule")
{
::comphelper::MimeConfigurationHelper aConfigHelper(
comphelper::getProcessComponentContext());
+
// Show the first MAX_MENU_ITEMS_PER_MODULE items of the current
module
// on top of the recent document list.
for (int i = 0; i < nPickListMenuItems; i++)
{
const SvtHistoryOptions::HistoryItem& rPickListEntry =
aHistoryList[i];
-const std::pair
aPickListEntry(rPickListEntry.sURL,
-
rPickListEntry.isReadOnly);
-if ((nItemPosModule < MAX_MENU_ITEMS_PER_MODULE ||
bShowCurrentModuleOnly)
-&&
aConfigHelper.GetDocServiceNameFromFilter(rPickListEntry.sFilter)
- == m_aModuleName)
+
+// tdf#155699 - insert pinned document at the beginning of the
list
+if (rPickListEntry.isPinned)
{
-m_aRecentFilesItems.insert(m_aRecentFilesItems.begin() +
nItemPosModule,
- aPickListEntry);
-nItemPos++;
+insertHistoryItemAtPos(rPickListEntry, nItemPosPinned);
+nItemPosPinned++;
nItemPosModule++;
}
-else if (!bShowCurrentModuleOnly)
+// tdf#56696 - insert documents of the current module
+else if ((bShowCurrentModuleOnly
+ || (nItemPosModule - nItemPosPinned) <
MAX_MENU_ITEMS_PER_MODULE)
+ &&
aConfigHelper.GetDocServiceNameFromFilter(rPickListEntry.sFilter)
+== m_aModuleName)
{
-m_aRecentFilesItems.insert(m_aRecentFilesItems.begin() +
nItemPos,
- aPickListEntry);
-nItemPos++;
+insertHistoryItemAtPos(rPickListEntry, nItemPosModule);
+nItemPosModule++;
}
+// Insert all other documents at the end of the list if the
expert option is not set
+else if (!bShowCurrentModuleOnly)
+insertHistoryItemAtPos(rPickListEntry, nItemPos);
}
}
else
@@ -201,7 +216,9 @@ void RecentFilesMenuController::fillPopupMenu( Reference<
css::awt::XPopupMenu >
for (int i = 0; i < nPickListMenuItems; i++)
{
const SvtHistoryOptions::HistoryItem& rPickListEntry =
aHistoryList[i];
-m_aRecentFilesItems.emplace_back(rPickListEntry.sURL,
rPickListEntry.isReadOnly);
+// tdf#155699 - insert pinned document at the beginning of the
list
+insertHistoryItemAtPos(rPickListEntry,
+ rPickListEntry.isPinned ?
nItemPosModule++ : nItemPos);
}
}
}
@@ -263,6 +280,10 @@ void RecentFilesMenuController::fillPopupMenu( Reference<
css::awt::XPopupMenu >
rPopupMenu->setTipHelpText(sal_uInt16(i + 1), aTipHelpText);
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sc/source
sc/source/filter/oox/extlstcontext.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 4a3eba59bef50ae1535482ef7021b50b68e4f016
Author: Henry Castro
AuthorDate: Fri Mar 17 11:03:36 2023 -0400
Commit: Xisco Fauli
CommitDate: Thu Jun 15 09:36:14 2023 +0200
sc: filter: oox: add missing formula if it is a text ...
conditional format:
NOT(ISERROR(SEARCH("Done",C1)))
Signed-off-by: Henry Castro
Change-Id: I4da117a1a122b3895788645dcd5de3e36cdcad0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149067
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153008
Tested-by: Jenkins
(cherry picked from commit 7c2cfc26381dd31ab43e357eea7a3f5e63d3d6f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153075
Reviewed-by: Xisco Fauli
diff --git a/sc/source/filter/oox/extlstcontext.cxx
b/sc/source/filter/oox/extlstcontext.cxx
index 2646f0969958..5328accac5c8 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -274,6 +274,12 @@ void ExtConditionalFormattingContext::onEndElement()
break;
case XLS14_TOKEN( cfRule ):
{
+if (IsSpecificTextCondMode(maModel.eOperator) && nFormulaCount ==
1)
+{
+maModel.aFormula = aChars;
+maModel.eOperator = ScConditionMode::Direct;
+}
+
getStyles().getExtDxfs().forEachMem( ::finalizeImport );
maModel.aStyle = getStyles().createExtDxfStyle(rStyleIdx);
rStyleIdx++;
[Libreoffice-bugs] [Bug 155847] Change manager error
https://bugs.documentfoundation.org/show_bug.cgi?id=155847 NISZ LibreOffice Team changed: What|Removed |Added Summary|Change handler error|Change manager error -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155847] Change handler error
https://bugs.documentfoundation.org/show_bug.cgi?id=155847 --- Comment #1 from NISZ LibreOffice Team --- Created attachment 187921 --> https://bugs.documentfoundation.org/attachment.cgi?id=187921=edit Screenshot of the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155847] New: Change handler error
https://bugs.documentfoundation.org/show_bug.cgi?id=155847 Bug ID: 155847 Summary: Change handler error Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu Description: The change manager does not handle it well when there is both an inserted and deleted case. It does not show 2 changes, but many. Steps to Reproduce: 1: Insert a table. 2: Turn on change handler. 3: Insert a new column and then delete another column. 4: Look at the change handler. Actual Results: It shows more changes than it should. Expected Results: It shows as much change as has happened. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069c7dc4e9706b40ca12d83d83f90f41cec948f8 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/text/data/para-upper-margin-fly-intersect.docx |binary
sw/qa/core/text/text.cxx | 30 ++
sw/qa/extras/layout/layout3.cxx | 20 -
sw/source/core/text/itrform2.cxx |6 ++
4 files changed, 45 insertions(+), 11 deletions(-)
New commits:
commit 737d90b7b7cb03bb6128b74a32906b0391868830
Author: Miklos Vajna
AuthorDate: Thu Jun 15 08:24:23 2023 +0200
Commit: Miklos Vajna
CommitDate: Thu Jun 15 09:28:56 2023 +0200
sw floattable: fix handling of upper margin of anchor for fly intersect
The bugdoc has 2 paragraphs and a shape between them. Word has a small
amount of space between the shape and the 2nd paragraph, Writer has a
large amount of space between the shape and the 2nd paragraph.
It seems what happens is that Writer puts both the text node's own
upper spacing and the previous text node's lower spacing into the upper
spacing of the text frame, so the check added in commit
d07fc485d46f431405a3f6a002f951a08c559677 (tdf#116486 Consider upper
margin in paragraph positioning with flys, 2018-04-10) is not entirely
correct, as it deal with both upper and lower margins, but its intention
was just the upper margins.
Fix the problem by (indirectly) using
GetUpperSpaceAmountConsideredForPrevFrame(), which allows doing the
intersection for the original text node upper spacing but not for the
text node lower spacing. This keeps the original bugdoc working, but
fixes the unexpected vertical space for the new bugdoc.
This is part of the effort so that the original bnc#816603 bugdoc's DOCX
version moves an overlapping floating table from page 4 back to page 3,
like Word does. testTdf122878 is modified to just make sure no overlap
happens, manual testing of the bugdoc shows that our layout still
matches Word.
Change-Id: I4622fb77dc8a52493766e50688ec92065eac65bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153101
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/core/text/data/para-upper-margin-fly-intersect.docx
b/sw/qa/core/text/data/para-upper-margin-fly-intersect.docx
new file mode 100644
index ..e8e767fb3897
Binary files /dev/null and
b/sw/qa/core/text/data/para-upper-margin-fly-intersect.docx differ
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index 6d71cadcf9ea..dff758985c37 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -1371,6 +1371,36 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testTdf139863)
assertXPath(pXmlDoc, "//body/txt[2]/SwParaPortion/SwLineLayout/child::*",
1);
}
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testParaUpperMarginFlyIntersect)
+{
+// Given a document with 2 paragraphs, the paragraphs have both upper and
lower spacing of 567
+// twips:
+createSwDoc("para-upper-margin-fly-intersect.docx");
+
+// When laying out that document:
+calcLayout();
+
+// Then make sure that we shift down the text in the second paragraph only
based on the 2nd para
+// upper margin, not based on the 1st para lower margin:
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+int nFlyCount
+= getXPathContent(pXmlDoc,
+
"count(//SwParaPortion/SwLineLayout/child::*[@type='PortionType::Fly'])")
+ .toInt32();
+int nHeight = 0;
+for (int i = 1; i <= nFlyCount; ++i)
+{
+OString xPath =
"(//SwParaPortion/SwLineLayout/child::*[@type='PortionType::Fly'])["
++ OString::number(i) + "]";
+nHeight += getXPath(pXmlDoc, xPath, "height").toInt32();
+}
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 521 (~500)
+// - Actual : 857 (~1000)
+// I.e. both upper and lower margin was taken into account.
+CPPUNIT_ASSERT_EQUAL(521, nHeight);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/qa/extras/layout/layout3.cxx b/sw/qa/extras/layout/layout3.cxx
index 9d4d53be5d39..784a295fa2e8 100644
--- a/sw/qa/extras/layout/layout3.cxx
+++ b/sw/qa/extras/layout/layout3.cxx
@@ -193,21 +193,21 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter3, testTdf122878)
{
createSwDoc("tdf122878.docx");
xmlDocUniquePtr pXmlDoc = parseLayoutDump();
-// FIXME: the XPath should be adjusted when the proper floating table
would be imported
const sal_Int32 nTblTop
= getXPath(pXmlDoc,
"/root/page[1]/footer/txt/anchored/fly/tab/infos/bounds", "top")
.toInt32();
-const sal_Int32 nFirstPageParaCount
-= getXPathContent(pXmlDoc, "count(/root/page[1]/body/txt)").toInt32();
-CPPUNIT_ASSERT_EQUAL(sal_Int32(30), nFirstPageParaCount);
-for (sal_Int32 i = 1; i <= nFirstPageParaCount; ++i)
+SwDoc* pDoc = getSwDoc();
+SwRootFrame* pLayout =
[Libreoffice-bugs] [Bug 155846] New: Change tracking error while moving a column.
https://bugs.documentfoundation.org/show_bug.cgi?id=155846 Bug ID: 155846 Summary: Change tracking error while moving a column. Product: LibreOffice Version: 24.2.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoff...@nisz.hu Description: When a column in a table is selected by clicking the mouse over the column, then clicking the selected column again and dragging it to the first cell of another column while holding down the left mouse button, the change tracking is not marked correctly. Steps to Reproduce: 1: Create a table. 2: Turn on change tracking. 3: Click over a column to select it. 4: Click inside the selected column and move it to the first cell of another column. Actual Results: Does not mark the change correctly. Expected Results: Correctly marks the change. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 069c7dc4e9706b40ca12d83d83f90f41cec948f8 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/source
sw/source/core/access/AccessibilityCheck.cxx| 22
sw/source/core/inc/AccessibilityCheck.hxx |2 -
sw/source/core/txtnode/OnlineAccessibilityCheck.cxx |2 -
3 files changed, 11 insertions(+), 15 deletions(-)
New commits:
commit 4c71b0ac5fcb3ebe1e88721c49be8a6e0b9dcdf9
Author: Balazs Varga
AuthorDate: Tue Jun 13 11:25:36 2023 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Jun 15 09:26:30 2023 +0200
tdf#155728 - A11y sidebar: fix Update issue list after fixing an issue
in case of SdrObjects.
Change-Id: I45608d423c0da0f1a983dcfad43562c3d7c9ee67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152953
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 4bfdc5b1aeee65bfbc985452a90cc43868682f0a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153077
diff --git a/sw/source/core/access/AccessibilityCheck.cxx
b/sw/source/core/access/AccessibilityCheck.cxx
index 05d2634db863..802ad2c8dea3 100644
--- a/sw/source/core/access/AccessibilityCheck.cxx
+++ b/sw/source/core/access/AccessibilityCheck.cxx
@@ -1337,7 +1337,7 @@ public:
} // end anonymous namespace
// Check Shapes, TextBox
-void AccessibilityCheck::checkObject(SdrObject* pObject)
+void AccessibilityCheck::checkObject(SwNode* pCurrent, SdrObject* pObject)
{
if (!pObject)
return;
@@ -1381,6 +1381,8 @@ void AccessibilityCheck::checkObject(SdrObject* pObject)
pIssue->setObjectID(pObject->GetName());
pIssue->setDoc(*m_pDoc);
+if (pCurrent)
+pIssue->setNode(pCurrent);
}
}
}
@@ -1469,19 +1471,13 @@ void AccessibilityCheck::check()
if (pNodeCheck)
pNodeCheck->check(pNode);
}
-}
-}
-IDocumentDrawModelAccess& rDrawModelAccess =
m_pDoc->getIDocumentDrawModelAccess();
-auto* pModel = rDrawModelAccess.GetDrawModel();
-for (sal_uInt16 nPage = 0; nPage < pModel->GetPageCount(); ++nPage)
-{
-SdrPage* pPage = pModel->GetPage(nPage);
-for (size_t nObject = 0; nObject < pPage->GetObjCount(); ++nObject)
-{
-SdrObject* pObject = pPage->GetObj(nObject);
-if (pObject)
-checkObject(pObject);
+for (SwFrameFormat* const& pFrameFormat : pNode->GetAnchoredFlys())
+{
+SdrObject* pObject = pFrameFormat->FindSdrObject();
+if (pObject)
+checkObject(pNode, pObject);
+}
}
}
}
diff --git a/sw/source/core/inc/AccessibilityCheck.hxx
b/sw/source/core/inc/AccessibilityCheck.hxx
index c7613e8829a4..caaff1944842 100644
--- a/sw/source/core/inc/AccessibilityCheck.hxx
+++ b/sw/source/core/inc/AccessibilityCheck.hxx
@@ -49,7 +49,7 @@ public:
}
void check() override;
-void checkObject(SdrObject* pObject);
+void checkObject(SwNode* pNode, SdrObject* pObject);
void checkNode(SwNode* pNode);
void checkDocumentProperties();
};
diff --git a/sw/source/core/txtnode/OnlineAccessibilityCheck.cxx
b/sw/source/core/txtnode/OnlineAccessibilityCheck.cxx
index 20d0ac39c10e..629497c50bac 100644
--- a/sw/source/core/txtnode/OnlineAccessibilityCheck.cxx
+++ b/sw/source/core/txtnode/OnlineAccessibilityCheck.cxx
@@ -134,7 +134,7 @@ void
OnlineAccessibilityCheck::runAccessibilityCheck(SwNode* pNode)
{
SdrObject* pObject = pFrameFormat->FindSdrObject();
if (pObject)
-m_aAccessibilityCheck.checkObject(pObject);
+m_aAccessibilityCheck.checkObject(pNode, pObject);
}
auto aCollection = m_aAccessibilityCheck.getIssueCollection();
[Libreoffice-bugs] [Bug 155839] When propmpted about missing hyphenation data - I should be offered a download link
https://bugs.documentfoundation.org/show_bug.cgi?id=155839 Mike Kaganski changed: What|Removed |Added CC||cl...@documentfoundation.or ||g, r...@debian.org --- Comment #5 from Mike Kaganski --- cloph, rene: do you know if it's possible to tweak our packaging process such as to allow the main package to know which language packages (and their parts - like, if they contain hyphenation) are built together? Of maybe we can allow to set up a URL to learn it? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 155839] When propmpted about missing hyphenation data - I should be offered a download link
https://bugs.documentfoundation.org/show_bug.cgi?id=155839 Mike Kaganski changed: What|Removed |Added CC||cl...@documentfoundation.or ||g, r...@debian.org --- Comment #5 from Mike Kaganski --- cloph, rene: do you know if it's possible to tweak our packaging process such as to allow the main package to know which language packages (and their parts - like, if they contain hyphenation) are built together? Of maybe we can allow to set up a URL to learn it? -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/webdav-curl/CurlUri.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 977878814a3573627026e31edb8a51c8f30c8a0c
Author: Stephan Bergmann
AuthorDate: Wed Jun 14 16:05:54 2023 +0200
Commit: Stephan Bergmann
CommitDate: Thu Jun 15 09:01:18 2023 +0200
ooo#41037 Reject URLs containing unencoded NUL characters
Change-Id: I45bbd342734f190ce918b610441ca911a47830b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153062
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/ucb/source/ucp/webdav-curl/CurlUri.cxx
b/ucb/source/ucp/webdav-curl/CurlUri.cxx
index c5440423a2db..3ee218d5aca3 100644
--- a/ucb/source/ucp/webdav-curl/CurlUri.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlUri.cxx
@@ -115,6 +115,10 @@ CurlUri::CurlUri(::std::u16string_view const rURI)
}
// use curl to parse the URI, to get a consistent interpretation
+if (rURI.find(u'\0') != std::u16string_view::npos)
+{
+throw DAVException(DAVException::DAV_INVALID_ARG);
+}
OString const utf8URI(OUStringToOString(rURI, RTL_TEXTENCODING_UTF8));
auto uc = curl_url_set(m_pUrl.get(), CURLUPART_URL, utf8URI.getStr(), 0);
if (uc != CURLUE_OK)
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf155690.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx| 47 ++
writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 ++
3 files changed, 53 insertions(+)
New commits:
commit 7f9f6fdd6f74d0b9c824a8a0c0384addb5c2ffe6
Author: Michael Stahl
AuthorDate: Wed Jun 14 15:35:24 2023 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 15 08:59:19 2023 +0200
tdf#155690 writerfilter: fix import of bookmark in table...
... at start of section.
(regression from commit 2e8aad6d45c53d554ccaf26de998ede708cfc289)
Change-Id: I1e0e720758b607b69645b29c46f4092264289f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153053
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 142aa77265361492e74707b08c5bcd366e7205ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153072
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/ooxmlexport/data/tdf155690.docx
b/sw/qa/extras/ooxmlexport/data/tdf155690.docx
new file mode 100644
index ..1839862688ee
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf155690.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index f42b5e7f9a28..a5176b5d32e6 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -58,6 +58,53 @@ DECLARE_OOXMLEXPORT_TEST(testTdf126994_lostPageBreak,
"tdf126994_lostPageBreak.d
CPPUNIT_ASSERT_EQUAL_MESSAGE( "Number of Pages", 3, getPages() );
}
+DECLARE_OOXMLEXPORT_TEST(testTdf155690, "tdf155690.docx")
+{
+uno::Reference xBookmarksSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference xBookmarks =
xBookmarksSupplier->getBookmarks();
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+// the problem was that the start was after the H
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_2"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_3"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("ello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_4"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_3"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("ello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_4"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf121374_sectionHF)
{
loadAndReload("tdf121374_sectionHF.odt");
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 6616407836de..7fb017154135 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -8102,6 +8102,9 @@ void DomainMapper_Impl::StartOrEndBookmark( const
OUString& rId )
else
{
xCursor = xText->createTextCursorByRange(
aBookmarkIter->second.m_xTextRange );
+}
+if (!aBookmarkIter->second.m_bIsStartOfText)
+{
xCursor->goRight( 1, false );
}
@@ -8243,6 +8246,9 @@ void
DomainMapper_Impl::startOrEndPermissionRange(sal_Int32 permissinId)
else
{
xCursor =
xText->createTextCursorByRange(aPermIter->second.m_xTextRange);
+}
+if (!aPermIter->second.m_bIsStartOfText)
+{
xCursor->goRight(1, false);
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf155690.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport13.cxx| 47 ++
writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 ++
3 files changed, 53 insertions(+)
New commits:
commit b5a50e5bd31303da8c102122b2e0adf3674eee9d
Author: Michael Stahl
AuthorDate: Wed Jun 14 15:35:24 2023 +0200
Commit: Xisco Fauli
CommitDate: Thu Jun 15 08:59:15 2023 +0200
tdf#155690 writerfilter: fix import of bookmark in table...
... at start of section.
(regression from commit 2e8aad6d45c53d554ccaf26de998ede708cfc289)
Change-Id: I1e0e720758b607b69645b29c46f4092264289f9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153053
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 142aa77265361492e74707b08c5bcd366e7205ad)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153071
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/ooxmlexport/data/tdf155690.docx
b/sw/qa/extras/ooxmlexport/data/tdf155690.docx
new file mode 100644
index ..1839862688ee
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf155690.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
index f6c1b84fcec9..80243ba64a2d 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
@@ -58,6 +58,53 @@ DECLARE_OOXMLEXPORT_TEST(testTdf126994_lostPageBreak,
"tdf126994_lostPageBreak.d
CPPUNIT_ASSERT_EQUAL_MESSAGE( "Number of Pages", 3, getPages() );
}
+DECLARE_OOXMLEXPORT_TEST(testTdf155690, "tdf155690.docx")
+{
+uno::Reference xBookmarksSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference xBookmarks =
xBookmarksSupplier->getBookmarks();
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+// the problem was that the start was after the H
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_2"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_3"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("ello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row1_4"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_1"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_3"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("ello world"),
xMark->getAnchor()->getString());
+}
+{
+uno::Reference
xMark(xBookmarks->getByName("row2_4"), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xMark.is());
+CPPUNIT_ASSERT_EQUAL(OUString("Hello world"),
xMark->getAnchor()->getString());
+}
+}
+
CPPUNIT_TEST_FIXTURE(Test, testTdf121374_sectionHF)
{
loadAndReload("tdf121374_sectionHF.odt");
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 41ca8bf8d45e..f75fbf529c96 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -8344,6 +8344,9 @@ void DomainMapper_Impl::StartOrEndBookmark( const
OUString& rId )
else
{
xCursor = xText->createTextCursorByRange(
aBookmarkIter->second.m_xTextRange );
+}
+if (!aBookmarkIter->second.m_bIsStartOfText)
+{
xCursor->goRight( 1, false );
}
@@ -8485,6 +8488,9 @@ void
DomainMapper_Impl::startOrEndPermissionRange(sal_Int32 permissinId)
else
{
xCursor =
xText->createTextCursorByRange(aPermIter->second.m_xTextRange);
+}
+if (!aPermIter->second.m_bIsStartOfText)
+{
xCursor->goRight(1, false);
}
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sd/source
sd/source/ui/dlg/sdtreelb.cxx | 22 ++
1 file changed, 2 insertions(+), 20 deletions(-)
New commits:
commit 2ce4de98f4d0226e8f7e43f8cd1b5f4b4901c230
Author: Jim Raykowski
AuthorDate: Sat Jun 10 17:16:29 2023 -0800
Commit: Xisco Fauli
CommitDate: Thu Jun 15 08:56:16 2023 +0200
SdNavigator: Improve unique name detection
Commit ace75043781b5fe36546ec75574a14617f4feb30 added the ability to
rename page and object names from the Navigator. An approach that
searches entry names in the tree was used to check for unique naming.
This does not guarantee uniquess as the name may already be used
for an object in another view, for example, Notes view. This
patch guarantees name uniqueness by checking the document model to
see if an object with the name already exists.
Change-Id: Iad419420d6010b94380c55b7dc71a8d4abbec784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152843
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
(cherry picked from commit ec60d354359067f8c5c686ef2239ee705916de43)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153018
Reviewed-by: Xisco Fauli
diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx
index 45b078df0cb0..56e93bd7dfe0 100644
--- a/sd/source/ui/dlg/sdtreelb.cxx
+++ b/sd/source/ui/dlg/sdtreelb.cxx
@@ -783,27 +783,9 @@ IMPL_LINK(SdPageObjsTLV, EditedEntryHdl, const
IterString&, rIterString, bool)
return true;
// If the new name is empty or not unique, start editing again.
-bool bUniqueName = true;
-std::unique_ptr xEntry(m_xTreeView->make_iterator());
-if (!rIterString.second.isEmpty())
-{
-if (m_xTreeView->get_iter_first(*xEntry))
-{
-do
-{
-// skip self!
-if (m_xTreeView->iter_compare(*xEntry, rIterString.first) != 0
&&
-m_xTreeView->get_text(*xEntry) == rIterString.second)
-{
-bUniqueName = false;
-break;
-}
-} while(m_xTreeView->iter_next(*xEntry));
-}
-}
-if (rIterString.second.isEmpty() || !bUniqueName)
+if (rIterString.second.isEmpty() || m_pDoc->GetObj(rIterString.second))
{
-m_xTreeView->copy_iterator(rIterString.first, *xEntry);
+std::unique_ptr
xEntry(m_xTreeView->make_iterator());
Application::PostUserEvent(LINK(this, SdPageObjsTLV, EditEntryAgain),
xEntry.release());
return false;
}
