Re: [patch] Finding the generated latex file

2015-11-10 Thread Guillaume Munch

Le 10/11/2015 01:08, Scott Kostyshak a écrit :

On Mon, Nov 09, 2015 at 08:04:29AM +, Guillaume Munch wrote:

Le 06/11/2015 10:35, Jean-Marc Lasgouttes a écrit :

Le 06/11/2015 04:16, Scott Kostyshak a écrit :

I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?


Although I personally like this (as I noted above), I think we should
get opinions from a couple of other LyX developers. From a quick search,
we have been giving a dialog for more than 10 years so there might be a
good reason for it.


I think that a stderr message is good enough. I do not remember a
discussion about having this dialog. If you want to know, find when it
was introduced, and look at lyx-devel archives from this time.

JMarc




I suggest that people who requested this patch decide whether they want to
do this extra check, or ask me to commit already. :)


I think this idea has simmered for long enough. Thanks for your
patience, Guillaume. And thanks for the patch.

Please commit.



Done.

Guillaume




Re: [patch] Finding the generated latex file

2015-11-09 Thread Scott Kostyshak
On Mon, Nov 09, 2015 at 08:04:29AM +, Guillaume Munch wrote:
> Le 06/11/2015 10:35, Jean-Marc Lasgouttes a écrit :
> >Le 06/11/2015 04:16, Scott Kostyshak a écrit :
> >>>I also agree that it's better to replace the alert with a message on
> >>>stderr. I noticed that there are already similar messages on the
> >>>terminal when files cannot be removed.
> >>>
> >>>Attached is a patch. Shall I commit it?
> >>
> >>Although I personally like this (as I noted above), I think we should
> >>get opinions from a couple of other LyX developers. From a quick search,
> >>we have been giving a dialog for more than 10 years so there might be a
> >>good reason for it.
> >
> >I think that a stderr message is good enough. I do not remember a
> >discussion about having this dialog. If you want to know, find when it
> >was introduced, and look at lyx-devel archives from this time.
> >
> >JMarc
> >
> >
> 
> I suggest that people who requested this patch decide whether they want to
> do this extra check, or ask me to commit already. :)

I think this idea has simmered for long enough. Thanks for your
patience, Guillaume. And thanks for the patch.

Please commit.

Scott


Re: [patch] Finding the generated latex file

2015-11-09 Thread Guillaume Munch

Le 06/11/2015 10:35, Jean-Marc Lasgouttes a écrit :

Le 06/11/2015 04:16, Scott Kostyshak a écrit :

I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?


Although I personally like this (as I noted above), I think we should
get opinions from a couple of other LyX developers. From a quick search,
we have been giving a dialog for more than 10 years so there might be a
good reason for it.


I think that a stderr message is good enough. I do not remember a
discussion about having this dialog. If you want to know, find when it
was introduced, and look at lyx-devel archives from this time.

JMarc




I suggest that people who requested this patch decide whether they want 
to do this extra check, or ask me to commit already. :)



Guillaume



Re: [patch] Finding the generated latex file

2015-11-06 Thread Jean-Marc Lasgouttes

Le 06/11/2015 04:16, Scott Kostyshak a écrit :

I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?


Although I personally like this (as I noted above), I think we should
get opinions from a couple of other LyX developers. From a quick search,
we have been giving a dialog for more than 10 years so there might be a
good reason for it.


I think that a stderr message is good enough. I do not remember a 
discussion about having this dialog. If you want to know, find when it 
was introduced, and look at lyx-devel archives from this time.


JMarc



Re: [patch] Finding the generated latex file

2015-11-05 Thread Andrew Parsloe



On 6/11/2015 3:32 p.m., Guillaume Munch wrote:

Le 04/11/2015 17:16, PhilipPirrip a écrit :


I personally find this very annoying. As a user. It doesn't happen on
Linux, so I'm still good, but on Windows:
I tested the patch on Windows, no messages were shown if LyX was closed,
Windows Explorer window would just close upon the deletion of the temp
folder. But, if I had Acrobat Reader open with the document still loaded
in, two error messages would pop out giving me totally irrelevant
information... I press ok, and than what? LyX is going to close anyway,
should I look for the temp folder and delete it myself?



I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?



On 11/03/2015 07:00 PM, Andrew Parsloe wrote:


I have found the message helpful, particularly when developing a
module or a latex package to work with LyX. In the latter case, the
failure to remove the temp directory may indicate that a latex
process is still running. (Failure of a preview snippet for
instance.) From experience I know that this can lead to multiple
occurrences of the latex executable running at once, and LyX
becoming more and more sluggish.


Do you have other examples of good informations you get from this
message? For running processes, I agree that it can be sometimes useful
although I find using a system monitor more useful. But it's
double-edged: I have already seen this message pop up because instant
preview was still running, for instance.
It's not a big issue with me. I keep the system monitor on now too in 
the situations mentioned.


Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus



Re: [patch] Finding the generated latex file

2015-11-05 Thread Guillaume Munch

Le 06/11/2015 03:16, Scott Kostyshak a écrit :

On Fri, Nov 06, 2015 at 02:32:13AM +, Guillaume Munch wrote:

Le 04/11/2015 17:16, PhilipPirrip a écrit :


I personally find this very annoying. As a user. It doesn't happen on
Linux, so I'm still good, but on Windows:
I tested the patch on Windows, no messages were shown if LyX was closed,
Windows Explorer window would just close upon the deletion of the temp
folder. But, if I had Acrobat Reader open with the document still loaded
in, two error messages would pop out giving me totally irrelevant
information... I press ok, and than what? LyX is going to close anyway,
should I look for the temp folder and delete it myself?



I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?


Although I personally like this (as I noted above), I think we should
get opinions from a couple of other LyX developers. From a quick search,
we have been giving a dialog for more than 10 years so there might be a
good reason for it.



Yes, the intention was to discuss it. The fix is trivial, it did not 
cost me any time doing it, so I'm okay if another solution is retained. 
So, any informed objection?





Re: [patch] Finding the generated latex file

2015-11-05 Thread Scott Kostyshak
On Fri, Nov 06, 2015 at 02:32:13AM +, Guillaume Munch wrote:
> Le 04/11/2015 17:16, PhilipPirrip a écrit :
> >
> >I personally find this very annoying. As a user. It doesn't happen on
> >Linux, so I'm still good, but on Windows:
> >I tested the patch on Windows, no messages were shown if LyX was closed,
> >Windows Explorer window would just close upon the deletion of the temp
> >folder. But, if I had Acrobat Reader open with the document still loaded
> >in, two error messages would pop out giving me totally irrelevant
> >information... I press ok, and than what? LyX is going to close anyway,
> >should I look for the temp folder and delete it myself?
> >
> 
> I also agree that it's better to replace the alert with a message on
> stderr. I noticed that there are already similar messages on the
> terminal when files cannot be removed.
> 
> Attached is a patch. Shall I commit it?

Although I personally like this (as I noted above), I think we should
get opinions from a couple of other LyX developers. From a quick search,
we have been giving a dialog for more than 10 years so there might be a
good reason for it.

Scott


Re: [patch] Finding the generated latex file

2015-11-05 Thread Guillaume Munch

Le 04/11/2015 17:16, PhilipPirrip a écrit :


I personally find this very annoying. As a user. It doesn't happen on
Linux, so I'm still good, but on Windows:
I tested the patch on Windows, no messages were shown if LyX was closed,
Windows Explorer window would just close upon the deletion of the temp
folder. But, if I had Acrobat Reader open with the document still loaded
in, two error messages would pop out giving me totally irrelevant
information... I press ok, and than what? LyX is going to close anyway,
should I look for the temp folder and delete it myself?



I also agree that it's better to replace the alert with a message on
stderr. I noticed that there are already similar messages on the
terminal when files cannot be removed.

Attached is a patch. Shall I commit it?



On 11/03/2015 07:00 PM, Andrew Parsloe wrote:


I have found the message helpful, particularly when developing a
module or a latex package to work with LyX. In the latter case, the
failure to remove the temp directory may indicate that a latex
process is still running. (Failure of a preview snippet for
instance.) From experience I know that this can lead to multiple
occurrences of the latex executable running at once, and LyX
becoming more and more sluggish.


Do you have other examples of good informations you get from this
message? For running processes, I agree that it can be sometimes useful
although I find using a system monitor more useful. But it's
double-edged: I have already seen this message pop up because instant
preview was still running, for instance.
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 847b029..8bdbd66 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -526,9 +526,8 @@ Buffer::~Buffer()
 		d->position_to_children.clear();
 
 		if (!d->temppath.destroyDirectory()) {
-			Alert::warning(_("Could not remove temporary directory"),
-bformat(_("Could not remove the temporary directory %1$s"),
-from_utf8(d->temppath.absFileName(;
+			LYXERR0(bformat(_("Could not remove the temporary directory %1$s"),
+			from_utf8(d->temppath.absFileName(;
 		}
 		removePreviews();
 	}
diff --git a/src/LyX.cpp b/src/LyX.cpp
index a1fdac9..fe4ba78 100644
--- a/src/LyX.cpp
+++ b/src/LyX.cpp
@@ -404,10 +404,8 @@ void LyX::prepareExit()
 			LYXERR(Debug::INFO, "Deleting tmp dir "
 << package().temp_dir().absFileName());
 			if (!package().temp_dir().destroyDirectory()) {
-docstring const msg =
-	bformat(_("Unable to remove the temporary directory %1$s"),
-	from_utf8(package().temp_dir().absFileName()));
-Alert::warning(_("Unable to remove temporary directory"), msg);
+LYXERR0(bformat(_("Unable to remove the temporary directory %1$s"),
+from_utf8(package().temp_dir().absFileName(;
 			}
 		}
 	}


Re: [patch] Finding the generated latex file

2015-11-04 Thread PhilipPirrip

On 11/03/2015 07:00 PM, Andrew Parsloe wrote:


I have found the message helpful, particularly when developing a module
or a latex package to work with LyX. In the latter case, the failure to
remove the temp directory may indicate that a latex process is still
running. (Failure of a preview snippet for instance.) From experience I
know that this can lead to multiple occurrences of the latex executable
running at once, and LyX becoming more and more sluggish.



I personally find this very annoying. As a user. It doesn't happen on 
Linux, so I'm still good, but on Windows:
I tested the patch on Windows, no messages were shown if LyX was closed, 
Windows Explorer window would just close upon the deletion of the temp 
folder. But, if I had Acrobat Reader open with the document still loaded 
in, two error messages would pop out giving me totally irrelevant 
information... I press ok, and than what? LyX is going to close anyway, 
should I look for the temp folder and delete it myself?


I don't think this is the right way of debugging things. There's 
View>Message pane, why not just print the error message there. Worse 
things happen than the temp folder not being deleted and no windows pop 
out like this.





Re: [patch] Finding the generated latex file

2015-11-03 Thread PhilipPirrip

On 11/03/2015 10:45 AM, Guillaume Munch wrote:

Bad news, it didn't work on Windows. Qt 4.8, VS2010, WinXP/VirtualBox
On Linux, it worked with two AND three slashes: both Qt 4.8 and Qt 5.5;
Gnome 3.18, Fedora 23.


Thanks for the report and the extra step in testing. Please try again
with latest master.


I report that everything works in both WindowsXP and Fedora Linux.
The file browser window showing the temporary folder disappears when LyX 
is closed on Windows, Nautilus in Linux moves to the parent directory.






It opens the directory containing the chosen log — there's really no
trap about it. So I think that "Open Containing Directory" is the
clearest about what is achieved.


OK. What I was saying is that it shows more than just a log file, but no 
problem, what's most important is that it now works.







Re: [patch] Finding the generated latex file

2015-11-03 Thread Andrew Parsloe



On 4/11/2015 11:07 a.m., Scott Kostyshak wrote:

On Tue, Nov 03, 2015 at 06:03:36PM +0100, Stephan Witt wrote:

Am 03.11.2015 um 17:39 schrieb Guillaume Munch :


So the error message is valid. The solution would be to make it clearer. Maybe one could show a 
better message depending on the failure. If it's "resource busy" then we could add to the 
message something like "The directory might be currently in use in a different program".

Unfortunately it's a boolean state only: see FileName.cpp line 639 - 
rmdir(QFileInfo const & fi) called from FileName::destroyDirectory().

A few points:

- I agree with Stephan that the likelihood of users running into this
   message is greater.

- For me the message is shown twice.

- I actually wonder if we should not show the message to the user. Who
   cares that we cannot remove the temporary directory? What if we just
   output the message on STDERR?

Scott

I have found the message helpful, particularly when developing a module 
or a latex package to work with LyX. In the latter case, the failure to 
remove the temp directory may indicate that a latex process is still 
running. (Failure of a preview snippet for instance.) From experience I 
know that this can lead to multiple occurrences of the latex executable 
running at once, and LyX becoming more and more sluggish.


Andrew

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus



Re: [patch] Finding the generated latex file

2015-11-03 Thread Scott Kostyshak
On Tue, Nov 03, 2015 at 06:03:36PM +0100, Stephan Witt wrote:
> Am 03.11.2015 um 17:39 schrieb Guillaume Munch :
> 
> > So the error message is valid. The solution would be to make it clearer. 
> > Maybe one could show a better message depending on the failure. If it's 
> > "resource busy" then we could add to the message something like "The 
> > directory might be currently in use in a different program".
> 
> Unfortunately it's a boolean state only: see FileName.cpp line 639 - 
> rmdir(QFileInfo const & fi) called from FileName::destroyDirectory().

A few points:

- I agree with Stephan that the likelihood of users running into this
  message is greater.

- For me the message is shown twice.

- I actually wonder if we should not show the message to the user. Who
  cares that we cannot remove the temporary directory? What if we just
  output the message on STDERR?

Scott


Re: [patch] Finding the generated latex file

2015-11-03 Thread Scott Kostyshak
On Tue, Nov 03, 2015 at 03:45:03PM +, Guillaume Munch wrote:
> Le 03/11/2015 08:27, PhilipPirrip a écrit :
> >On 11/02/2015 10:58 PM, Guillaume Munch wrote:
> >>Pushed at f441590c. Windows/OSX users, please report if it does not work.
> >
> >Hey Guillaume,
> >Bad news, it didn't work on Windows. Qt 4.8, VS2010, WinXP/VirtualBox
> >This was the error message:
> >lyx\src\frontends\qt4\GuiLog.cpp (207): Unable to open QUrl even though
> >dir exists!
> >
> >
> >I then added another slash to your code
> >QUrl qdir(toqstr(from_utf8("file:///" + dir.absFileName())),
> >   QUrl::StrictMode);
> >(by the example here http://doc.qt.io/qt-4.8/qdesktopservices.html#details)
> >and it WORKED!
> >
> >
> >
> >
> >On Linux, it worked with two AND three slashes: both Qt 4.8 and Qt 5.5;
> >Gnome 3.18, Fedora 23.
> 
> 
> Thanks for the report and the extra step in testing. Please try again
> with latest master.
> 
> 
> >
> >If I may:  to me, "Open Containing Directory"  doesn't mean much. What
> >does the directory contain - the log shown above, the lyx document? How
> >about "Open Compilation Directory" (or Temporary / or Folder)?
> 
> It opens the directory containing the chosen log — there's really no
> trap about it. So I think that "Open Containing Directory" is the
> clearest about what is achieved.
> 
> LyX is (almost) consistent in using Directory instead of Folder.
> 
> 
> >
> >What I find would be handy to have, since you've already been messing
> >around this code, is a button that would clear the temporary dir.  LyX
> >sometimes gets stuck with some old log and aux files, especially after
> >an error in compilation, and the only way to get rid of the error
> >messages is to make a dummy change or reopen the document.
> >
> 
> I think that there are already bug reports about this and I am not sure
> that an additional button is the best solution. But, for very specific
> usages, thanks the the new button, you can now open the directory, do
> Ctrl+A and then delete…

I also think there are bug reports about it. I think it is a reasonable
request, but I think that it is separate from this topic, although I
agree that you could use Guillaume's button to achieve what you want.

Also, even though I do support your feature request, it would be great
if you could make bug reports with reproducible examples so that we
could fix the bugs at the source.

Scott


Re: [patch] Finding the generated latex file

2015-11-03 Thread Stephan Witt
Am 03.11.2015 um 17:39 schrieb Guillaume Munch :

> Le 03/11/2015 16:16, Stephan Witt a écrit :
>> Am 03.11.2015 um 16:36 schrieb Guillaume Munch :
>>> 
>>> Do you mean that the patch now causes this error message? Under which
>>> circumstances precisely? Is it that if the directory is open in the
>>> finder, then LyX cannot remove the directory? (Under Linux, Nautilus's
>>> behaviour is to move to the parent directory if the current directory is
>>> deleted.)
>> 
>> Yes, the error is displayed by LyX because it cannot remove the temporary
>> directory while it is shown in the Finder (the Nautilus of OSX).
>> 
>> I'd guess this is the common scenario for the average user:
>> check the LaTeX log, use the button, switch back to LyX and finally exit LyX 
>> -
>> which raises the mentioned error message and leaves the empty temporary
>> directory in file system.
>> 
>> It's not the patch causing the error message - it's easier to get it with the
>> patch.
>> 
> 
> So the error message is valid. The solution would be to make it clearer. 
> Maybe one could show a better message depending on the failure. If it's 
> "resource busy" then we could add to the message something like "The 
> directory might be currently in use in a different program".

Unfortunately it's a boolean state only: see FileName.cpp line 639 - 
rmdir(QFileInfo const & fi) called from FileName::destroyDirectory().

Stephan



Re: [patch] Finding the generated latex file

2015-11-03 Thread Guillaume Munch

Le 03/11/2015 16:39, Guillaume Munch a écrit :

Le 03/11/2015 16:16, Stephan Witt a écrit :

Am 03.11.2015 um 16:36 schrieb Guillaume Munch :


Do you mean that the patch now causes this error message? Under which
circumstances precisely? Is it that if the directory is open in the
finder, then LyX cannot remove the directory? (Under Linux, Nautilus's
behaviour is to move to the parent directory if the current directory is
deleted.)


Yes, the error is displayed by LyX because it cannot remove the temporary
directory while it is shown in the Finder (the Nautilus of OSX).

I'd guess this is the common scenario for the average user:
check the LaTeX log, use the button, switch back to LyX and finally
exit LyX -
which raises the mentioned error message and leaves the empty temporary
directory in file system.

It's not the patch causing the error message - it's easier to get it
with the
patch.



So the error message is valid. The solution would be to make it clearer.
Maybe one could show a better message depending on the failure. If it's
"resource busy" then we could add to the message something like "The
directory might be currently in use in a different program".




BTW while testing whether the button worked with spaces in the path, I 
noticed that LyX fails to delete the temporary folder with the message 
"/tmp/temp dir with spaces does not look like a LyX temporary directory" 
when there are spaces in the path.




Re: [patch] Finding the generated latex file

2015-11-03 Thread Guillaume Munch

Le 03/11/2015 16:16, Stephan Witt a écrit :

Am 03.11.2015 um 16:36 schrieb Guillaume Munch :


Do you mean that the patch now causes this error message? Under which
circumstances precisely? Is it that if the directory is open in the
finder, then LyX cannot remove the directory? (Under Linux, Nautilus's
behaviour is to move to the parent directory if the current directory is
deleted.)


Yes, the error is displayed by LyX because it cannot remove the temporary
directory while it is shown in the Finder (the Nautilus of OSX).

I'd guess this is the common scenario for the average user:
check the LaTeX log, use the button, switch back to LyX and finally exit LyX -
which raises the mentioned error message and leaves the empty temporary
directory in file system.

It's not the patch causing the error message - it's easier to get it with the
patch.



So the error message is valid. The solution would be to make it clearer. 
Maybe one could show a better message depending on the failure. If it's 
"resource busy" then we could add to the message something like "The 
directory might be currently in use in a different program".



Guillaume



Re: [patch] Finding the generated latex file

2015-11-03 Thread Stephan Witt
Am 03.11.2015 um 16:36 schrieb Guillaume Munch :

> Le 03/11/2015 08:59, Stephan Witt a écrit :
>> Am 03.11.2015 um 04:58 schrieb Guillaume Munch > >:
>> 
>>> Le 02/11/2015 18:38, Guillaume Munch a écrit :
 Le 28/10/2015 16:39, Ilan a écrit :
> Thanks David and Stephan.
> 
> My problem is that I'm working on a multi-file project so under the tmp
> directory there are several directories and the location of the Latex
> file
> depends on the file I compiled (and of course the tmp directory has a
> different
> name each time under windows).
> 
> What I used to do until few months ago is opening the Latex log, and
> there I
> saw the full path to the compiled file, so I could copy it to a Latex
> editor.
> After some updates to Lyx & Latex, I see in the log only the file name
> without
> the path.
> 
> I can (and this is what I do) to find the current tmp directory and then
> searching for all the Latex files to find the right one by its name.
> I hoped there is an option to return to the previous state of easily
> finding
> the directory with a click.
> 
> 
 
>>> 
>>> 
>>> Pushed at f441590c. Windows/OSX users, please report if it does not work.
>> 
>> It works for me on OSX. Although I'd expect user questions regarding the
>> attached error message on exit of LyX:
>> "Cannot remove temporary directory…" or similar…
>> 
> 
> 
> Do you mean that the patch now causes this error message? Under which
> circumstances precisely? Is it that if the directory is open in the
> finder, then LyX cannot remove the directory? (Under Linux, Nautilus's
> behaviour is to move to the parent directory if the current directory is
> deleted.)

Yes, the error is displayed by LyX because it cannot remove the temporary
directory while it is shown in the Finder (the Nautilus of OSX).

I'd guess this is the common scenario for the average user:
check the LaTeX log, use the button, switch back to LyX and finally exit LyX -
which raises the mentioned error message and leaves the empty temporary
directory in file system.

It's not the patch causing the error message - it's easier to get it with the
patch.

Stephan

Re: [patch] Finding the generated latex file

2015-11-03 Thread Guillaume Munch

Le 03/11/2015 08:59, Stephan Witt a écrit :

Am 03.11.2015 um 04:58 schrieb Guillaume Munch mailto:g...@lyx.org>>:


Le 02/11/2015 18:38, Guillaume Munch a écrit :

Le 28/10/2015 16:39, Ilan a écrit :

Thanks David and Stephan.

My problem is that I'm working on a multi-file project so under the tmp
directory there are several directories and the location of the Latex
file
depends on the file I compiled (and of course the tmp directory has a
different
name each time under windows).

What I used to do until few months ago is opening the Latex log, and
there I
saw the full path to the compiled file, so I could copy it to a Latex
editor.
After some updates to Lyx & Latex, I see in the log only the file name
without
the path.

I can (and this is what I do) to find the current tmp directory and then
searching for all the Latex files to find the right one by its name.
I hoped there is an option to return to the previous state of easily
finding
the directory with a click.




(from )


Dear List,

(continuing on lyx-devel)


Here's a proof-of-concept patch to add an “Open directory…” button to
the log dialog. I did it very quickly which is why I only call it
“proof-of-concept”. If we want to commit this then at least somebody
with better QtDesigner skills should add the button to the interface in
a more proper way.

I, too, used to spend too much time finding the proper lyxtmpdir (for
various reasons ranging from debugging the latex output using
divide-and-conquer when LyX's debugging facility was unsufficient, to
debugging instant preview). And I think it's not too bad to expose the
LyX internals in this way.

What do you think?




Pushed at f441590c. Windows/OSX users, please report if it does not work.


It works for me on OSX. Although I'd expect user questions regarding the
attached error message on exit of LyX:
"Cannot remove temporary directory…" or similar…




Do you mean that the patch now causes this error message? Under which
circumstances precisely? Is it that if the directory is open in the
finder, then LyX cannot remove the directory? (Under Linux, Nautilus's
behaviour is to move to the parent directory if the current directory is
deleted.)





Re: [patch] Finding the generated latex file

2015-11-03 Thread Guillaume Munch

Le 03/11/2015 08:27, PhilipPirrip a écrit :

On 11/02/2015 10:58 PM, Guillaume Munch wrote:

Pushed at f441590c. Windows/OSX users, please report if it does not work.


Hey Guillaume,
Bad news, it didn't work on Windows. Qt 4.8, VS2010, WinXP/VirtualBox
This was the error message:
lyx\src\frontends\qt4\GuiLog.cpp (207): Unable to open QUrl even though
dir exists!


I then added another slash to your code
QUrl qdir(toqstr(from_utf8("file:///" + dir.absFileName())),
   QUrl::StrictMode);
(by the example here http://doc.qt.io/qt-4.8/qdesktopservices.html#details)
and it WORKED!




On Linux, it worked with two AND three slashes: both Qt 4.8 and Qt 5.5;
Gnome 3.18, Fedora 23.



Thanks for the report and the extra step in testing. Please try again
with latest master.




If I may:  to me, "Open Containing Directory"  doesn't mean much. What
does the directory contain - the log shown above, the lyx document? How
about "Open Compilation Directory" (or Temporary / or Folder)?


It opens the directory containing the chosen log — there's really no
trap about it. So I think that "Open Containing Directory" is the
clearest about what is achieved.

LyX is (almost) consistent in using Directory instead of Folder.




What I find would be handy to have, since you've already been messing
around this code, is a button that would clear the temporary dir.  LyX
sometimes gets stuck with some old log and aux files, especially after
an error in compilation, and the only way to get rid of the error
messages is to make a dummy change or reopen the document.



I think that there are already bug reports about this and I am not sure
that an additional button is the best solution. But, for very specific
usages, thanks the the new button, you can now open the directory, do
Ctrl+A and then delete…




Re: [patch] Finding the generated latex file

2015-11-03 Thread Stephan Witt
Am 03.11.2015 um 04:58 schrieb Guillaume Munch :

> Le 02/11/2015 18:38, Guillaume Munch a écrit :
>> Le 28/10/2015 16:39, Ilan a écrit :
>>> Thanks David and Stephan.
>>> 
>>> My problem is that I'm working on a multi-file project so under the tmp
>>> directory there are several directories and the location of the Latex
>>> file
>>> depends on the file I compiled (and of course the tmp directory has a
>>> different
>>> name each time under windows).
>>> 
>>> What I used to do until few months ago is opening the Latex log, and
>>> there I
>>> saw the full path to the compiled file, so I could copy it to a Latex
>>> editor.
>>> After some updates to Lyx & Latex, I see in the log only the file name
>>> without
>>> the path.
>>> 
>>> I can (and this is what I do) to find the current tmp directory and then
>>> searching for all the Latex files to find the right one by its name.
>>> I hoped there is an option to return to the previous state of easily
>>> finding
>>> the directory with a click.
>>> 
>>> 
>> 
>> (from )
>> 
>> 
>> Dear List,
>> 
>> (continuing on lyx-devel)
>> 
>> 
>> Here's a proof-of-concept patch to add an “Open directory…” button to
>> the log dialog. I did it very quickly which is why I only call it
>> “proof-of-concept”. If we want to commit this then at least somebody
>> with better QtDesigner skills should add the button to the interface in
>> a more proper way.
>> 
>> I, too, used to spend too much time finding the proper lyxtmpdir (for
>> various reasons ranging from debugging the latex output using
>> divide-and-conquer when LyX's debugging facility was unsufficient, to
>> debugging instant preview). And I think it's not too bad to expose the
>> LyX internals in this way.
>> 
>> What do you think?
>> 
> 
> 
> Pushed at f441590c. Windows/OSX users, please report if it does not work.

It works for me on OSX. Although I'd expect user questions regarding the
attached error message on exit of LyX: 
"Cannot remove temporary directory…" or similar…

Stephan




Re: [patch] Finding the generated latex file

2015-11-03 Thread PhilipPirrip

On 11/02/2015 10:58 PM, Guillaume Munch wrote:

Pushed at f441590c. Windows/OSX users, please report if it does not work.


Hey Guillaume,
Bad news, it didn't work on Windows. Qt 4.8, VS2010, WinXP/VirtualBox
This was the error message:
lyx\src\frontends\qt4\GuiLog.cpp (207): Unable to open QUrl even though 
dir exists!



I then added another slash to your code
QUrl qdir(toqstr(from_utf8("file:///" + dir.absFileName())),
  QUrl::StrictMode);
(by the example here http://doc.qt.io/qt-4.8/qdesktopservices.html#details)
and it WORKED!




On Linux, it worked with two AND three slashes: both Qt 4.8 and Qt 5.5; 
Gnome 3.18, Fedora 23.





If I may:  to me, "Open Containing Directory"  doesn't mean much. What 
does the directory contain - the log shown above, the lyx document? How 
about "Open Compilation Directory" (or Temporary / or Folder)?


What I find would be handy to have, since you've already been messing 
around this code, is a button that would clear the temporary dir.  LyX 
sometimes gets stuck with some old log and aux files, especially after 
an error in compilation, and the only way to get rid of the error 
messages is to make a dummy change or reopen the document.








Re: [patch] Finding the generated latex file

2015-11-02 Thread Guillaume Munch

Le 02/11/2015 18:38, Guillaume Munch a écrit :

Le 28/10/2015 16:39, Ilan a écrit :

Thanks David and Stephan.

My problem is that I'm working on a multi-file project so under the tmp
directory there are several directories and the location of the Latex
file
depends on the file I compiled (and of course the tmp directory has a
different
name each time under windows).

What I used to do until few months ago is opening the Latex log, and
there I
saw the full path to the compiled file, so I could copy it to a Latex
editor.
After some updates to Lyx & Latex, I see in the log only the file name
without
the path.

I can (and this is what I do) to find the current tmp directory and then
searching for all the Latex files to find the right one by its name.
I hoped there is an option to return to the previous state of easily
finding
the directory with a click.




(from )


Dear List,

(continuing on lyx-devel)


Here's a proof-of-concept patch to add an “Open directory…” button to
the log dialog. I did it very quickly which is why I only call it
“proof-of-concept”. If we want to commit this then at least somebody
with better QtDesigner skills should add the button to the interface in
a more proper way.

I, too, used to spend too much time finding the proper lyxtmpdir (for
various reasons ranging from debugging the latex output using
divide-and-conquer when LyX's debugging facility was unsufficient, to
debugging instant preview). And I think it's not too bad to expose the
LyX internals in this way.

What do you think?




Pushed at f441590c. Windows/OSX users, please report if it does not work.



Re: [patch] Finding the generated latex file

2015-11-02 Thread Scott Kostyshak
On Tue, Nov 03, 2015 at 01:05:58AM +, Guillaume Munch wrote:

> >Looking at what other programs do in similar (but slightly different)
> >situations:
> >
> >evince and firefox both have:
> >Open Containing Folder
> >
> >fslint has:
> >Open Folder
> >
> >filelight has:
> >Open File Manager Here
> >
> >chromium has:
> >Show in folder
> >
> >As for my personal preference, I might like "Open temporary dir" or
> >"Open temp dir" because it might be nice to emphasize that the directory
> >is temporary (e.g. it might be deleted soon!). Also that is how we refer
> >to it technically so if there are any user questions about "the
> >temporary" directory we will understand exactly which directory is being
> >referred to, as opposed to "I opened the directory, but...". I suppose
> >there is room for confusion though, since technically the temporary
> >directory is actually the parent folder of the lyx_tmpbuf0 directory. In
> >summary, I don't have a strong preference.
> 
> Ok. My preference is for "Open Containing Directory" which I find more
> intuitive. It is still more specific than "the directory" so it has some of
> the advantages that you mention. Also, the path already makes it clear that
> it is not part of the user's personal files.

Makes sense. Your preference is also the closest to the most common one
of the programs I found (evince and firefox).

Scott


Re: [patch] Finding the generated latex file

2015-11-02 Thread Guillaume Munch

Le 03/11/2015 00:41, Scott Kostyshak a écrit :

On Tue, Nov 03, 2015 at 12:11:08AM +, Guillaume Munch wrote:


The "Open directory..." could also get rid of the "Show Output Anyway"
button for the same reasoning as (1) above. I like the "Show Output
Anyway" button how it is, but I'm not sure if that's because I just got
used to it. If others prefer one less button though, I would be OK with
that.


To be clear, this is a different dialog right? So are you suggesting to add
this “Open directory” button to the other dialog as well?


Yes, in this case we could have the "Open directory" button in the place
of "Show Output Anyway" and would not need it in the LaTeX Log dialog.
But I just realized that if the compilation is successful, we can only
get to the LaTeX Log dialog so my idea is not good because we might want
to access the temporary directory even on a successful compilation.



I'd keep the “Show
Output Anyway” button, for the reason you mentioned: there can be many
files. What do others think?


Any ideas for a clearer button label than “Open directory...”?


I do not like all first letters capitalized, but it seems that is the
current style so we should stick with that.


I make a quick search and you're right, title capitalization on buttons 
is a thing and is even recommended in some HIGs. (Title capitalization 
does not exist in French so I never noticed that in my apps.)



Also I don't think we should
have "...". That is for if another dialog *in LyX* is expected to follow
a click of that button. If I am mistaken on that we should rename "Show
Output Anyway" to have "..." also.


No, I think you are right.



Looking at what other programs do in similar (but slightly different)
situations:

evince and firefox both have:
Open Containing Folder

fslint has:
Open Folder

filelight has:
Open File Manager Here

chromium has:
Show in folder

As for my personal preference, I might like "Open temporary dir" or
"Open temp dir" because it might be nice to emphasize that the directory
is temporary (e.g. it might be deleted soon!). Also that is how we refer
to it technically so if there are any user questions about "the
temporary" directory we will understand exactly which directory is being
referred to, as opposed to "I opened the directory, but...". I suppose
there is room for confusion though, since technically the temporary
directory is actually the parent folder of the lyx_tmpbuf0 directory. In
summary, I don't have a strong preference.


Ok. My preference is for "Open Containing Directory" which I find more 
intuitive. It is still more specific than "the directory" so it has some 
of the advantages that you mention. Also, the path already makes it 
clear that it is not part of the user's personal files.




Re: [patch] Finding the generated latex file

2015-11-02 Thread Scott Kostyshak
On Tue, Nov 03, 2015 at 12:11:08AM +, Guillaume Munch wrote:

> >The "Open directory..." could also get rid of the "Show Output Anyway"
> >button for the same reasoning as (1) above. I like the "Show Output
> >Anyway" button how it is, but I'm not sure if that's because I just got
> >used to it. If others prefer one less button though, I would be OK with
> >that.
> 
> To be clear, this is a different dialog right? So are you suggesting to add
> this “Open directory” button to the other dialog as well?

Yes, in this case we could have the "Open directory" button in the place
of "Show Output Anyway" and would not need it in the LaTeX Log dialog.
But I just realized that if the compilation is successful, we can only
get to the LaTeX Log dialog so my idea is not good because we might want
to access the temporary directory even on a successful compilation.


> I'd keep the “Show
> Output Anyway” button, for the reason you mentioned: there can be many
> files. What do others think?
> 
> 
> Any ideas for a clearer button label than “Open directory...”?

I do not like all first letters capitalized, but it seems that is the
current style so we should stick with that. Also I don't think we should
have "...". That is for if another dialog *in LyX* is expected to follow
a click of that button. If I am mistaken on that we should rename "Show
Output Anyway" to have "..." also.

Looking at what other programs do in similar (but slightly different)
situations:

evince and firefox both have:
Open Containing Folder

fslint has:
Open Folder

filelight has:
Open File Manager Here

chromium has:
Show in folder

As for my personal preference, I might like "Open temporary dir" or
"Open temp dir" because it might be nice to emphasize that the directory
is temporary (e.g. it might be deleted soon!). Also that is how we refer
to it technically so if there are any user questions about "the
temporary" directory we will understand exactly which directory is being
referred to, as opposed to "I opened the directory, but...". I suppose
there is room for confusion though, since technically the temporary
directory is actually the parent folder of the lyx_tmpbuf0 directory. In
summary, I don't have a strong preference.

Scott


Re: [patch] Finding the generated latex file

2015-11-02 Thread Guillaume Munch

Le 02/11/2015 23:50, Scott Kostyshak a écrit :

On Mon, Nov 02, 2015 at 09:49:24PM +, Guillaume Munch wrote:

Le 02/11/2015 21:10, Andrew Parsloe a écrit :

Your proposed button would also solve #9211 "Make the lyxpreview.log
files accessible within LyX".




I agree, part of this idea comes from all the times I had to debug lyx
previews (but not only).


For the interface, I also propose to substitute the extant “Copy to
clipboard” button with this “Open directory...” button to avoid making
the interface heavier.


I think this is a good idea.


Indeed, “Copy to clipboard” is twice redundant:
1. With “open directory” one can open the original log file in an editor.


I was a little worried that some users would get overwhelmed when they
open the directory and there are possibly many files, but...


2. One can already do Ctrl+A in the dialog, or right mouse button ▷
Select all, then copy.


this assuages my concern.

The "Open directory..." could also get rid of the "Show Output Anyway"
button for the same reasoning as (1) above. I like the "Show Output
Anyway" button how it is, but I'm not sure if that's because I just got
used to it. If others prefer one less button though, I would be OK with
that.


To be clear, this is a different dialog right? So are you suggesting to 
add this “Open directory” button to the other dialog as well? I'd keep 
the “Show Output Anyway” button, for the reason you mentioned: there can 
be many files. What do others think?



Any ideas for a clearer button label than “Open directory...”?



Re: [patch] Finding the generated latex file

2015-11-02 Thread Scott Kostyshak
On Mon, Nov 02, 2015 at 09:49:24PM +, Guillaume Munch wrote:
> Le 02/11/2015 21:10, Andrew Parsloe a écrit :
> >Your proposed button would also solve #9211 "Make the lyxpreview.log
> >files accessible within LyX".
> >
> 
> 
> I agree, part of this idea comes from all the times I had to debug lyx
> previews (but not only).
> 
> 
> For the interface, I also propose to substitute the extant “Copy to
> clipboard” button with this “Open directory...” button to avoid making
> the interface heavier.

I think this is a good idea.

> Indeed, “Copy to clipboard” is twice redundant:
> 1. With “open directory” one can open the original log file in an editor.

I was a little worried that some users would get overwhelmed when they
open the directory and there are possibly many files, but...

> 2. One can already do Ctrl+A in the dialog, or right mouse button ▷
> Select all, then copy.

this assuages my concern.

The "Open directory..." could also get rid of the "Show Output Anyway"
button for the same reasoning as (1) above. I like the "Show Output
Anyway" button how it is, but I'm not sure if that's because I just got
used to it. If others prefer one less button though, I would be OK with
that.

Scott


Re: [patch] Finding the generated latex file

2015-11-02 Thread Guillaume Munch

Le 02/11/2015 21:10, Andrew Parsloe a écrit :

Your proposed button would also solve #9211 "Make the lyxpreview.log
files accessible within LyX".




I agree, part of this idea comes from all the times I had to debug lyx
previews (but not only).


For the interface, I also propose to substitute the extant “Copy to
clipboard” button with this “Open directory...” button to avoid making
the interface heavier. Indeed, “Copy to clipboard” is twice redundant:
1. With “open directory” one can open the original log file in an editor.
2. One can already do Ctrl+A in the dialog, or right mouse button ▷
Select all, then copy.

Any user of the "Copy to clipboard" button would object?


I propose to commit the attached which solves the UI issues of the
previous patch.



Guillaume
>From ea6b85adc95be9625a203f35009edfe5ee0deee5 Mon Sep 17 00:00:00 2001
From: Guillaume Munch 
Date: Mon, 2 Nov 2015 18:19:40 +
Subject: [PATCH] Add "Open directory..." button to the log dialog.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It takes the place of the “Copy to Clipboard” button which was redundant.
---
 src/frontends/qt4/GuiLog.cpp  | 19 +++
 src/frontends/qt4/GuiLog.h|  2 ++
 src/frontends/qt4/ui/LogUi.ui |  5 +++--
 3 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/frontends/qt4/GuiLog.cpp b/src/frontends/qt4/GuiLog.cpp
index 14e7aaf..427e989 100644
--- a/src/frontends/qt4/GuiLog.cpp
+++ b/src/frontends/qt4/GuiLog.cpp
@@ -24,8 +24,10 @@
 #include "support/FileName.h"
 #include "support/gettext.h"
 
+#include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -189,6 +191,23 @@ void GuiLog::on_nextWarningPB_clicked()
 }
 
 
+void GuiLog::on_openDirPB_clicked()
+{
+	support::FileName dir = logfile_.onlyPath();
+	if (!dir.exists())
+		return;
+	QUrl qdir(toqstr(from_utf8("file://" + dir.absFileName())),
+			  QUrl::StrictMode);
+	// Give hints in case of bugs
+	if (!qdir.isValid()) {
+		LYXERR0("QUrl is invalid!");
+		return;
+	}
+	if (!QDesktopServices::openUrl(qdir))
+		LYXERR0("Unable to open QUrl even though dir exists!");
+}
+
+
 void GuiLog::goTo(QRegExp const & exp) const
 {
 	QTextCursor const newc =
diff --git a/src/frontends/qt4/GuiLog.h b/src/frontends/qt4/GuiLog.h
index 2a9ebb6..8159836 100644
--- a/src/frontends/qt4/GuiLog.h
+++ b/src/frontends/qt4/GuiLog.h
@@ -41,6 +41,8 @@ private Q_SLOTS:
 	void on_nextErrorPB_clicked();
 	/// jump to next warning
 	void on_nextWarningPB_clicked();
+	/// open containing directory
+	void on_openDirPB_clicked();
 	/// Log type changed
 	void typeChanged(int);
 
diff --git a/src/frontends/qt4/ui/LogUi.ui b/src/frontends/qt4/ui/LogUi.ui
index ddf6ebc..ebbc9dd 100644
--- a/src/frontends/qt4/ui/LogUi.ui
+++ b/src/frontends/qt4/ui/LogUi.ui
@@ -1,3 +1,4 @@
+
 
  LogUi
  
@@ -105,9 +106,9 @@
 


-
+
  
-  Copy to Clip&board
+  &Open directory...
  
 

-- 
2.1.4



Re: [patch] Finding the generated latex file

2015-11-02 Thread Andrew Parsloe



On 3/11/2015 7:38 a.m., Guillaume Munch wrote:

Le 28/10/2015 16:39, Ilan a écrit :

Thanks David and Stephan.

My problem is that I'm working on a multi-file project so under the tmp
directory there are several directories and the location of the Latex 
file
depends on the file I compiled (and of course the tmp directory has a 
different

name each time under windows).

What I used to do until few months ago is opening the Latex log, and 
there I
saw the full path to the compiled file, so I could copy it to a Latex 
editor.
After some updates to Lyx & Latex, I see in the log only the file 
name without

the path.

I can (and this is what I do) to find the current tmp directory and then
searching for all the Latex files to find the right one by its name.
I hoped there is an option to return to the previous state of easily 
finding

the directory with a click.




(from )


Dear List,

(continuing on lyx-devel)


Here's a proof-of-concept patch to add an “Open directory…” button to 
the log dialog. I did it very quickly which is why I only call it 
“proof-of-concept”. If we want to commit this then at least somebody 
with better QtDesigner skills should add the button to the interface 
in a more proper way.


I, too, used to spend too much time finding the proper lyxtmpdir (for 
various reasons ranging from debugging the latex output using 
divide-and-conquer when LyX's debugging facility was unsufficient, to 
debugging instant preview).
Your proposed button would also solve #9211 "Make the lyxpreview.log 
files accessible within LyX".


Andrew


And I think it's not too bad to expose the LyX internals in this way.

What do you think?


Guillaume



---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus



[patch] Finding the generated latex file

2015-11-02 Thread Guillaume Munch

Le 28/10/2015 16:39, Ilan a écrit :

Thanks David and Stephan.

My problem is that I'm working on a multi-file project so under the tmp
directory there are several directories and the location of the Latex file
depends on the file I compiled (and of course the tmp directory has a different
name each time under windows).

What I used to do until few months ago is opening the Latex log, and there I
saw the full path to the compiled file, so I could copy it to a Latex editor.
After some updates to Lyx & Latex, I see in the log only the file name without
the path.

I can (and this is what I do) to find the current tmp directory and then
searching for all the Latex files to find the right one by its name.
I hoped there is an option to return to the previous state of easily finding
the directory with a click.




(from )


Dear List,

(continuing on lyx-devel)


Here's a proof-of-concept patch to add an “Open directory…” button to 
the log dialog. I did it very quickly which is why I only call it 
“proof-of-concept”. If we want to commit this then at least somebody 
with better QtDesigner skills should add the button to the interface in 
a more proper way.


I, too, used to spend too much time finding the proper lyxtmpdir (for 
various reasons ranging from debugging the latex output using 
divide-and-conquer when LyX's debugging facility was unsufficient, to 
debugging instant preview). And I think it's not too bad to expose the 
LyX internals in this way.


What do you think?


Guillaume
>From 7f97044ddbe67ccd83c6460878045aabf134c443 Mon Sep 17 00:00:00 2001
From: Guillaume Munch 
Date: Mon, 2 Nov 2015 18:19:40 +
Subject: [PATCH] Add "Open directory..." button to the log dialog.

Proof of concept.
---
 src/frontends/qt4/GuiLog.cpp  |  17 +
 src/frontends/qt4/GuiLog.h|   2 +
 src/frontends/qt4/ui/LogUi.ui | 150 ++
 3 files changed, 98 insertions(+), 71 deletions(-)

diff --git a/src/frontends/qt4/GuiLog.cpp b/src/frontends/qt4/GuiLog.cpp
index 14e7aaf..1db6f99 100644
--- a/src/frontends/qt4/GuiLog.cpp
+++ b/src/frontends/qt4/GuiLog.cpp
@@ -24,8 +24,10 @@
 #include "support/FileName.h"
 #include "support/gettext.h"
 
+#include 
 #include 
 #include 
+#include 
 #include 
 
 #include 
@@ -189,6 +191,21 @@ void GuiLog::on_nextWarningPB_clicked()
 }
 
 
+void GuiLog::on_openDirPB_clicked()
+{
+	support::FileName dir = logfile_.onlyPath();
+	QUrl qdir(toqstr(from_utf8("file://" + dir.absFileName())),
+			  QUrl::StrictMode);
+	if (dir.exists()) {
+		// Give hints in case of bugs
+		if (!qdir.isValid())
+			LYXERR0("QUrl is invalid!");
+		if (!QDesktopServices::openUrl(qdir))
+			LYXERR0("Unable to open QUrl although dir exists.");
+	}
+}
+
+
 void GuiLog::goTo(QRegExp const & exp) const
 {
 	QTextCursor const newc =
diff --git a/src/frontends/qt4/GuiLog.h b/src/frontends/qt4/GuiLog.h
index 2a9ebb6..8159836 100644
--- a/src/frontends/qt4/GuiLog.h
+++ b/src/frontends/qt4/GuiLog.h
@@ -41,6 +41,8 @@ private Q_SLOTS:
 	void on_nextErrorPB_clicked();
 	/// jump to next warning
 	void on_nextWarningPB_clicked();
+	/// open containing directory
+	void on_openDirPB_clicked();
 	/// Log type changed
 	void typeChanged(int);
 
diff --git a/src/frontends/qt4/ui/LogUi.ui b/src/frontends/qt4/ui/LogUi.ui
index ddf6ebc..6a4f49b 100644
--- a/src/frontends/qt4/ui/LogUi.ui
+++ b/src/frontends/qt4/ui/LogUi.ui
@@ -1,60 +1,68 @@
-
+
+
  LogUi
- 
-  
+ 
+  

 0
 0
-421
+454
 474

   
-  
+  

   
-  
+  
true
   
-  
-   
+  
+   
 9

-   
+   
 6

-   
-
- 
+   
+
+ 
+  Copy to Clip&board
+ 
+
+   
+   
+
+ 
   &Find:
  
- 
+ 
   findLE
  
 

-   
-
- 
+   
+
+ 
   Hit Enter to search, or click Go!
  
 

-   
-
- 
+   
+
+ 
   Log &Type:
  
- 
+ 
   logTypeCO
  
 

-   
+   
 
- 
+ 
   Qt::Horizontal
  
- 
+ 
   
161
20
@@ -62,41 +70,41 @@
  
 

-   
-
+   
+

-   
-
+   
+

-   
-
- 
+   
+
+ 
   Update the display
  
- 
+ 
   &Update
  
- 
+ 
   true
  
 

-   
-
- 
+   
+
+ 
   &Close
  
 

-   
+   
 
- 
+ 
   Qt::Horizontal
  
- 
+ 
   QSizePolicy::Expanding
  
- 
+ 
   
111
26
@@ -104,53 +112,53 @@
  
 

-   
-
- 
-  Copy to Clip&board
- 
-
-   
-   
-
- 
-  Qt::Horizontal
- 
- 
-  
-   201
-   20
-  
- 
-
-   
-   
-
- 
+   
+
+ 
   &Go!
  
 

-   
-
- 
+   
+
+ 
   Jump to the next warning message.
  
- 
+ 
   Next &Warning
  
 

-   
-
- 
+   
+