[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209



--- Comment #9 from Fedora Update System  ---
ddgr-1.2-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-1ed409d72c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646



--- Comment #11 from Fedora Update System  ---
patool-1.12-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a91b279e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525698] Review Request: jid - Json Incremental Digger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525698

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
jid-0.7.2-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-61e8dd7f23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
linux-driver-management-1.0.3-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377631



--- Comment #20 from mgans...@alice.de  ---
Thanks for the review !
the version is now gnome-shell-extension-netspeed-28-0.2.20180208gite3cea60
hope that's ok now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605

Nick Bebout  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||n...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|n...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #2 from Eli Young  ---
GitHub is used as the source instead of PyPI because the tarfile uploaded to
PyPI has been stripped of tests and, more critically, the license.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605



--- Comment #1 from Eli Young  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=24984110

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544605] New: Review Request: python-digitalocean - Easy access to Digital Ocean APIs to deploy droplets , images and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544605

Bug ID: 1544605
   Summary: Review Request: python-digitalocean - Easy access to
Digital Ocean APIs to deploy droplets, images and more
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: elysc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://elyscape.fedorapeople.org//python-digitalocean.spec
SRPM URL:
http://elyscape.fedorapeople.org//python-digitalocean-1.13.2-1.fc28.src.rpm

Description:
Easy access to Digital Ocean APIs to deploy droplets, images and
more.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377631] Review Request: gnome-shell-extension-netspeed - A gnome-shell extension to show speed of the internet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377631

Andrew Toskin  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #19 from Andrew Toskin  ---
I'd meant the version should be *just* 28, because that's what the "version"
property in the json file says, not 3.28.

But I won't make you wait for yet another review because that.

Sorry, this has taken so long, but there's only so much you can do when the
upstream developer gets busy with other things in their life. At least it's
done now, though :)

APPROVED!

The next steps include requesting the creation of the repository for you
package in tje Fedora SCM, and requesting all branches for all versions of
Fedora and/or EPEL you plan on building for. (master will be created
automatically, but you'll need to manually request f27 and f26, and epel7 if
you wish to support that release too.)

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers%2FJoin#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492475] Review Request: aftertheflood-sparks-fonts - a font to display charts within text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492475

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Elliott Sales de Andrade  ---
Looks good. APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #12 from Ilya Gradina  ---
(In reply to Jaroslav Prokop from comment #11)
> The Guard::RSpec::RSpecProcess failures are happening because bundler is
> needed for them and the upstream does not seem to mention that or require it
> at all in the file. I recommend notifying upstream about this. For the time
> being I would probably just comment out the specific test cases.

ok, thx.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268703] Review Request: rubygem-powerpack - A few useful extensions to core Ruby classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268703



--- Comment #8 from Ilya Gradina  ---
(In reply to Vít Ondruch from comment #7)
> Ping ... What is the status here, please? The package was approved already
> ...

excuse me, it is fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562

Nick Bebout  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|n...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268742] Review Request: rubygem-bacon-colored_output - Colored output for Bacon test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268742



--- Comment #17 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rubygem-bacon-colored_output. You may commit
to the branch "f28" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562

Eli Young  changed:

   What|Removed |Added

 CC||n...@fedoraproject.org



--- Comment #2 from Eli Young  ---
*** Bug 1492896 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1492896] Review Request: python-certbot-dns-route53 - certbot plugin for Route53 DNS validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1492896

Eli Young  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2018-02-12 16:30:12



--- Comment #3 from Eli Young  ---
Superseded by #1544562.

*** This bug has been marked as a duplicate of bug 1544562 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562



--- Comment #1 from Eli Young  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=24972645

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544562] New: Review Request: python-certbot-dns-route53 - Route53 DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544562

Bug ID: 1544562
   Summary: Review Request: python-certbot-dns-route53 - Route53
DNS Authenticator plugin for Certbot
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: elysc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://elyscape.fedorapeople.org//python-certbot-dns-route53.spec
SRPM URL:
http://elyscape.fedorapeople.org//python-certbot-dns-route53-0.21.1-1.fc28.src.rpm

Description:
The certbot-dns-rfc2136 plugin automates the process of
completing an ACME dns-01 challenge by creating, and subsequently
removing, TXT records using AWS Route53.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268742] Review Request: rubygem-bacon-colored_output - Colored output for Bacon test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268742



--- Comment #16 from Ilya Gradina  ---
(In reply to Roman Joost from comment #14)
> Alright went full cycle. Hope this helps?

Thanks, everything is works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268742] Review Request: rubygem-bacon-colored_output - Colored output for Bacon test framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268742



--- Comment #15 from Ilya Gradina  ---
(In reply to Roman Joost from comment #14)
> Alright went full cycle. Hope this helps?

Thanks Roman,
I corrected the spec:
new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-bacon-colored_output.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-bacon-colored_output-1.1.1-3.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555

Nick Bebout  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||n...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|n...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528781] Review Request: mpfr - multiple-precision floating-point computations [needs sponsor]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528781

James Paul Turner  changed:

   What|Removed |Added

  Flags|needinfo-   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #2 from Eli Young  ---
Note that tests are disabled because most of them require internet access.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1528781] Review Request: mpfr - multiple-precision floating-point computations [needs sponsor]

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1528781

James Paul Turner  changed:

   What|Removed |Added

  Flags|needinfo?(jamesturner246@gm |needinfo-
   |ail.com)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555



--- Comment #1 from Eli Young  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=24972427

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544555] New: Review Request: python-certbot-dns-google - Google Cloud DNS Authenticator plugin for Certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544555

Bug ID: 1544555
   Summary: Review Request: python-certbot-dns-google - Google
Cloud DNS Authenticator plugin for Certbot
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: elysc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://elyscape.fedorapeople.org//python-certbot-dns-google.spec
SRPM URL:
http://elyscape.fedorapeople.org//python-certbot-dns-google-0.21.1-1.fc28.src.rpm

Description:
The certbot-dns-rfc2136 plugin automates the process of
completing an ACME dns-01 challenge by creating, and subsequently
removing, TXT records using Google Cloud DNS.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #11 from Jaroslav Prokop  ---
The Guard::RSpec::RSpecProcess failures are happening because bundler is needed
for them and the upstream does not seem to mention that or require it at all in
the file. I recommend notifying upstream about this. For the time being I would
probably just comment out the specific test cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #10 from Ilya Gradina  ---
(In reply to Vít Ondruch from comment #9)
> Oh, you are applying the latest packaging techniques (unpacking the gem via
> %setup), very nice :)
> 
> However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite
> fails entirely, you won't notice. I would rather see the tests disabled one
> by one or some explanation at minimum.
> 
> Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
> now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility
> with latest RSpec? Isn't there patch available upstream already?

Hi Vit, thanks for the remarks.
I had two kinds of errors: Guard::RSpec::RSpecProcess, Guard::RSpecFormatter.
Option "rspec --tag ~..." did not work for me, so I used "--exclude-pattern".

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec-4.7.3-3.fc28.src.rpm

also there is open issue with Guard::RSpecFormatter:
https://github.com/guard/guard-rspec/issues/405

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833



--- Comment #6 from David Benoit  ---
It seems FE-DEADREVIEW was auto-blocked when the old bug was marked as a
duplicate of this.  I have removed the block since we are still actively
working on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

David Benoit  changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541566] Review Request: whipper - Python CD-DA ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541566



--- Comment #8 from Matthew  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-27-x86_64/00714229-whipper/whipper.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mruszczyk/whipper/fedora-27-x86_64/00714229-whipper/whipper-0.6.0-4.fc27.src.rpm

Description: CD-DA ripper focused on accuracy over speed.

Fedora Account System Username: mruszczyk

(In reply to William Moreno from comment #6)
> > >  - Is it really necessary to split the python part into a separate library
> > > package? It doesn't seem to be used as a library, only as a binary.
> > 
> > I did this after asking a few questions in the #fedora-devel irc. They
> > seemed to indicate that it was abnormal to not split python packages this
> > way to make future python 3 support easier to setup. Is that incorrect?
> > 
> 
> It is not common in Fedora packaging to split a python package in a %{name}
> package and a python2-%{name} subpackage, the only reason to do dat is if
> the python2-%{name} is a module importable and usefull without the
> executable files in %{name}, but this are few bites of direference for the
> user point of view.


Thank you very much for the feedback. I have restructured the spec file to only
generate a single binary package.

(In reply to William Moreno from comment #7)
> Package Review
> ==
> 
> You are requering gobjects, is whipper a command line tool or provides a
> grafical user interface? If so work with upstream to include a desktop file
> and appdata.xml file.
> 
> [!]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/lib/python2.7/site-packages/whipper,
>  /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7.egg-info
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/lib/python2.7/site-
>  packages/whipper, /usr/lib/python2.7/site-packages/whipper-0.6.0-py2.7
>  .egg-info
> 
> Update %files to:
> %{python2_sitelib}/whipper-%{version}-py2.7.egg-info
> %{python2_sitelib}/whipper
> 
> This way you own the directory and not only the lifes on it.

The application is a command line tool and does not provide a graphical user
interface. The gobject requirement is still in the tree for now but work is
being done to eliminate it. I have adjusted the files section to properly take
ownership of the directories.

Please let me know if there is anything else I need to change at this time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1541554] Review Request: podman - Manage Pods, Containers and Container Images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1541554



--- Comment #8 from Fedora Update System  ---
podman-0.2-1.git3d0100b.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-803745b92f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #29 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/sirikali

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #28 from Raphael Groner  ---
https://pagure.io/releng/fedora-scm-requests/issue/4485
https://pagure.io/releng/fedora-scm-requests/issue/4486

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #35 from digimer  ---
I think I have integrated the comments, save for the last one in comment #34
for "buildrequire". I'm not sure what you are referring to, specifically. If I
can get clarification on that, or missed anything, please let me know and I'll
roll a new RPM asap.


New .spec and srpm:
https://www.alteeve.com/an-repo/files/packages/kronosnet.spec.1.0-5
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-5.fc27.src.rpm

f26:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24971062

f27:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24971069

rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24971077

epel7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=24971089


Here is the diff in .spec from 1.0-4;


--- kronosnet.spec.1.0-42018-01-31 23:32:53.661198886 -0500
+++ kronosnet.spec.1.0-52018-02-12 14:20:52.122179273 -0500
@@ -70,10 +70,11 @@
 Name: kronosnet
 Summary: Multipoint-to-Multipoint VPN daemon
 Version: 1.0
-Release: 3%{?dist}
+Release: 5%{?dist}
 License: GPLv2+ and LGPLv2+
 URL: http://www.kronosnet.org
 Source0: http://www.kronosnet.org/releases/kronosnet-%{version}.tar.gz
+Patch0: gcc8-fixes.patch

 # Build dependencies
 BuildRequires: gcc
@@ -83,16 +84,16 @@
 BuildRequires: lksctp-tools-devel
 %endif
 %if %{defined buildcryptonss}
-BuildRequires: /usr/include/nss3/nss.h /usr/include/nspr4/nspr.h
+BuildRequires: nss-devel nspr-devel
 %endif
 %if %{defined buildcryptoopenssl}
-BuildRequires: /usr/include/openssl/conf.h
+BuildRequires: openssl-devel
 %endif
 %if %{defined buildcompresszlib}
 BuildRequires: zlib-devel
 %endif
 %if %{defined buildcompresslz4}
-BuildRequires: /usr/include/lz4hc.h
+BuildRequires: lz4-devel
 %endif
 %if %{defined buildcompresslzo2}
 BuildRequires: lzo-devel
@@ -101,7 +102,7 @@
 BuildRequires: xz-devel
 %endif
 %if %{defined buildcompressbzip2}
-BuildRequires: /usr/include/bzlib.h
+BuildRequires: bzip2-devel
 %endif
 %if %{defined buildkronosnetd}
 BuildRequires: pam-devel
@@ -198,9 +199,6 @@
 # remove docs
 rm -rf %{buildroot}/usr/share/doc/kronosnet

-%clean
-rm -rf %{buildroot}
-
 # main empty package
 %description
 kronosnet source
@@ -210,16 +208,6 @@
 %package -n kronosnetd
 Summary: Multipoint-to-Multipoint VPN daemon
 License: GPLv2+ and LGPLv2+
-%if %{defined _unitdir}
-## Needed for systemd unit - Removed, see:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/LLG4T53FW2BGVZLGLKNYTKPD5SQNBZ2Y/
-#Requires(post):   systemd-sysv
-#Requires(post):   systemd-units
-#Requires(preun):  systemd-units
-#Requires(postun): systemd-units
-%else
-Requires(post): chkconfig
-Requires(preun): chkconfig, initscripts
-%endif
 Requires(post): shadow-utils
 Requires(preun): shadow-utils
 Requires: pam, /etc/pam.d/passwd
@@ -236,16 +224,8 @@
  or service disruption.

 %post -n kronosnetd
-%if %{defined _unitdir}
- %if 0%{?systemd_post:1}
-  %systemd_post kronosnetd.service
- %else
-  /bin/systemctl daemon-reload >/dev/null 2>&1 || :
- %endif
-%else
-/sbin/chkconfig --add kronosnetd
-%endif
-/usr/sbin/groupadd --force --system kronosnetadm
+%systemd_post kronosnetd.service
+getent group kronosnetadm >/dev/null || groupadd --force kronosnetadm

 %preun -n kronosnetd
 %if %{defined _unitdir}
@@ -265,7 +245,6 @@
 %endif

 %files -n kronosnetd
-%defattr(-,root,root,-)
 %license COPYING.* COPYRIGHT 
 %dir %{_sysconfdir}/kronosnet
 %dir %{_sysconfdir}/kronosnet/*
@@ -363,7 +342,7 @@

 %if %{defined buildcryptonss}
 %package -n libknet1-crypto-nss-plugin
-Summary: libknet1 nss support
+Summary: Libknet1 nss support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -377,7 +356,7 @@

 %if %{defined buildcryptoopenssl}
 %package -n libknet1-crypto-openssl-plugin
-Summary: libknet1 openssl support
+Summary: Libknet1 openssl support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -391,7 +370,7 @@

 %if %{defined buildcompresszlib}
 %package -n libknet1-compress-zlib-plugin
-Summary: libknet1 zlib support
+Summary: Libknet1 zlib support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -404,7 +383,7 @@
 %endif
 %if %{defined buildcompresslz4}
 %package -n libknet1-compress-lz4-plugin
-Summary: libknet1 lz4 and lz4hc support
+Summary: Libknet1 lz4 and lz4hc support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -419,7 +398,7 @@

 %if %{defined buildcompresslzo2}
 %package -n libknet1-compress-lzo2-plugin
-Summary: libknet1 lzo2 support
+Summary: Libknet1 lzo2 support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -433,7 +412,7 @@

 %if %{defined buildcompresslzma}
 %package -n libknet1-compress-lzma-plugin
-Summary: libknet1 lzma support
+Summary: Libknet1 lzma support
 License: GPLv2+ and LGPLv2+
 Requires: libknet1 = %{version}-%{release}

@@ -447,7 +426,7 @@

 %if 

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #27 from Raphael Groner  ---
Thanks for the review!

What's wrong with the comments above the patches? I forgot how upstream gets
notified and let know about both commits. Maybe upstream wrote me by e-mail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #38 from Fedora Update System  ---
molsketch-0.5.1-7.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c755bcbeff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525694] Review Request: golang-github-bitly-go-simplejson - Go package to interact with arbitrary JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525694

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
golang-github-bitly-go-simplejson-0.5.0-2.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-84a1820855

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539209] Review Request: ddgr - DuckDuckGo from the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539209

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
ddgr-1.2-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-bcd841f6d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525698] Review Request: jid - Json Incremental Digger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525698
Bug 1525698 depends on bug 1525694, which changed state.

Bug 1525694 Summary: Review Request: golang-github-bitly-go-simplejson - Go 
package to interact with arbitrary JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1525694

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525696] Review Request: golang-github-nwidger-jsoncolor - Colorized JSON output for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525696

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
golang-github-nwidger-jsoncolor-0-0.2.20170215git75a6de4.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-18c9ba5ad3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525698] Review Request: jid - Json Incremental Digger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525698
Bug 1525698 depends on bug 1525696, which changed state.

Bug 1525696 Summary: Review Request: golang-github-nwidger-jsoncolor - 
Colorized JSON output for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1525696

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542646] Review Request: patool - Portable command line archive file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542646

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
patool-1.12-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-aabb305a90

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544239



--- Comment #2 from dper...@gmail.com ---
Thank you for the feedback. I've implemented the requested changes ('Group:'
has been removed, the COPYING file is specified as a %license instead of %doc,
and and Appdata file has been added). Please see:

Spec URL: https://au2pb.org/srpms/unison248.spec
SRPM URL: https://au2pb.org/srpms/unison248-2.48.15v4-2.fc27.src.rpm

https://koji.fedoraproject.org/koji/taskinfo?taskID=24970440

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468



--- Comment #2 from Steve Grubb  ---
Thanks for the review. New SRPM and spec file reposted.

(In reply to Robert-André Mauchin from comment #1)
> Hello,
> 
>  - Not used in Fedora anymore:
> 
> Group:
> 
> BuildRoot:
> 
> rm -rf $RPM_BUILD_ROOT
> 
> %defattr(-,root,root,-)

Removed


>  - Use the correct systemd macros:
> 
> %{?systemd_requires}
> BuildRequires: systemd

Removed -devel


>  - the license file must be included with %license, not %doc:
> 
> %files
> %doc README
> %license COPYING

Fixed

>  - These %attr(644,root,root) %attr(755,root,root) are not needed because
> they are already the default value.

I like explicit permissions in case the make file has an accident. There are a
number of executable man pages on Fedora. :-)


>  - COPYING contains GNU General Public License v3.0 but your license header
> contains GPLv2+. Please use GPLv3 or GPLv3+.

Doh! Fixed.


>  - Please follow
> https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation
> to add user and group.
>Add Requires(pre): shadow-utils

Fixed.

> %pre
> getent group GROUPNAME >/dev/null || groupadd -r GROUPNAME
> getent passwd USERNAME >/dev/null || \
> useradd -r -g GROUPNAME -d HOMEDIR -s /sbin/nologin \
> -c "Useful comment about the purpose of this account" USERNAME
> exit 0

I think the existing code should do the trick. The default behavior is to
create both user and group unless overridden. So, checking the user should
suffice for simple cases.

>  - In %files, for man pages, don't directly link to the gz extension but use
> a glob:
> 
> %{_mandir}/man8/fapolicyd.8.*
> %{_mandir}/man5/fapolicyd.rules.5.*
> 
> See https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages for
> rationale.

Fixed. I widened the glob as there will certainly be future man pages added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Neal Gompa  ---
Looks good to me now.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/qevercloud. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219

Damian Wrobel  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||dwro...@ertelnet.rybnik.pl
 Resolution|--- |DUPLICATE
Last Closed||2018-02-12 11:55:58



--- Comment #16 from Damian Wrobel  ---


*** This bug has been marked as a duplicate of bug 1540833 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|DUPLICATE   |---
   Keywords||Reopened



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)
 CC||bthoma...@gmail.com



--- Comment #5 from Damian Wrobel  ---
*** Bug 1301219 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: qevercloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Robert-André Mauchin  changed:

   What|Removed |Added

Summary|Review Request: QEverCloud  |Review Request: qevercloud
   |- Unofficial Evernote Cloud |- Unofficial Evernote Cloud
   |API for Qt5 |API for Qt5



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1542650] Review Request: QEverCloud - Unofficial Evernote Cloud API for Qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1542650

Ben Rosser  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Ben Rosser  ---
Great, package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1119197] Review Request: gnushogi - Shogi (Japanese Chess) AI engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1119197

Ben Rosser  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |fedora-review+



--- Comment #25 from Ben Rosser  ---
Great, package is approved!

I have also gone ahead and sponsored you into packagers. If you have any future
questions about packaging feel free to send me an email, or ask me on IRC (my
username in Fedora IRC channels is TC01).

You can now follow the remaining steps in this wiki article to get gnushogi
imported and built:

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #34 from Jan Friesse  ---
@digimer:
Few more comments to kronosned section.

It's now safe to expect systemd_post to exists so it's better to follow
https://fedoraproject.org/wiki/Packaging:Systemd#Packaging, so for knet it
means:
- Add buildrequire
- Remove 0%{?systemd_post:1}, 0%{?systemd_preun:1}, else sections.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - Multipoint-to-Multipoint network abstraction layer for High Availability applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Jan Friesse  changed:

   What|Removed |Added

 CC||jfrie...@redhat.com



--- Comment #33 from Jan Friesse  ---
@digimer:
I've quickly checked the
https://www.alteeve.com/an-repo/files/packages/kronosnet-1.0-4.fc26.src.rpm and
found following issues:

-  warning: bogus date in %changelog: Tue Jan 31 2018 Madison Kelly
 - 1.0-4  <-- Should be Wed

- capitalize the summary (so for example convert "libknet1 crypto plugins meta
package" ->> "Libknet crypto", libknet1 openssl support -> "Libknet openssl
support", ...)

- Please try to follow
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires . We need
explicit requires for plugins-all, but they should be properly versioned and
some small comment why we need it would be nice to have.

- Please remove old cruft:

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-) in %files

- I know kronosnetd is not going to be distributed right now, but fixing
groupadd as
https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation may
be good idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #37 from Alexander Ploumistos  ---
I just did.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468



--- Comment #1 from Robert-André Mauchin  ---
Hello,

 - Not used in Fedora anymore:

Group:

BuildRoot:

rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root,-)

 - Use the correct systemd macros:

%{?systemd_requires}
BuildRequires: systemd

 - the license file must be included with %license, not %doc:

%files
%doc README
%license COPYING

 - These %attr(644,root,root) %attr(755,root,root) are not needed because they
are already the default value.

 - COPYING contains GNU General Public License v3.0 but your license header
contains GPLv2+. Please use GPLv3 or GPLv3+.

 - Please follow
https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation to
add user and group.
   Add Requires(pre): shadow-utils

%pre
getent group GROUPNAME >/dev/null || groupadd -r GROUPNAME
getent passwd USERNAME >/dev/null || \
useradd -r -g GROUPNAME -d HOMEDIR -s /sbin/nologin \
-c "Useful comment about the purpose of this account" USERNAME
exit 0

 - In %files, for man pages, don't directly link to the gz extension but use a
glob:

%{_mandir}/man8/fapolicyd.8.*
%{_mandir}/man5/fapolicyd.rules.5.*

See https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages for rationale.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544239



--- Comment #1 from Robert-André Mauchin  ---
A couple of preliminary remarks:

 - Group: is not needed anymore in Fedora

 - The license file (COPYING) must not be included with %doc, but with
%license:

%files
%doc src/NEWS src/README unison-manual.html
%license src/COPYING

 - Please consider adding an Appdata file for the gtk subpackage. See
https://fedoraproject.org/wiki/Packaging:AppData

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434



--- Comment #12 from Scott Talbert  ---
(In reply to Miro Hrončok from comment #11)
> (In reply to Scott Talbert from comment #9)
> > (In reply to Miro Hrončok from comment #4)
> > > There are wxWidgets in ext/wxWidgets, are those used or not? If not, can 
> > > the
> > > folder be deleted, just to make it clear?
> > 
> > The wxWidgets source isn't used EXCEPT for the interface headers
> > (ext/wxWidgets/interface/...) and the doxygen stuff.  So, we can't delete
> > ext/wxWidgets completely, but we could delete some subset of it.  What do
> > you think about that?
> 
> Can we somehow use the wxGTK3-devel header files instead? If not, just maybe
> add a note to the spec?

The wxGTK3-devel headers do not include the interface headers.  At one point,
however, I had created a wxGTK3-xmldocs package which had the information
needed for the wxPython4 build.  However, the interface headers were/are full
of bugs, so I was frequently having to patch them in wxGTK3 package. 
Eventually, I abandoned that approach to use the bundled copies of the headers
which have received lots of bug fixes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468

Daniel Kopeček  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dkope...@redhat.com
   Assignee|nob...@fedoraproject.org|mtama...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544468] New: Review Request: fapolicyd - Application Whitelisting Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544468

Bug ID: 1544468
   Summary: Review Request: fapolicyd - Application Whitelisting
Daemon
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sgr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: people.redhat.com/sgrubb/fapolicyd/fapolicyd.spec

SRPM URL: people.redhat.com/sgrubb/fapolicyd/fapolicyd-0.8.5-1.src.rpm

Description: 
Fapolicyd (File Access Policy Daemon) implements application whitelisting
to decide file access rights. Applications that are known via a reputation
source are allowed access while unknown applications are not. The daemon
makes use of the kernel's fanotify interface to determine file access rights.

Fedora Account System Username: sgrubb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540335] Review Request: primesieve - Fast C/ C++ prime number generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540335



--- Comment #6 from Michael Schwendt  ---
> 1)

That is a recent change indeed.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_Libraries


> 3)

If the package naming bugs you that much, you could go a step further and build
the following packages:

  primesieve : for the executable
  libprimesieve : for the shared runtime lib
  libprimesieve-devel : for the shared buildtime lib
  libprimesieve-static : for the static lib

That would be even closer to Debian, where they use a versioned libprimesieve8
package. Of course, if no other program links with libprimesieve [yet], you may
also drop the primesieve package and include it in the libprimesieve package.
Adding "Provides: primesieve" would extend the namespace with regard to user
searches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544239] Review Request: unison248 - There is a new incompatible version of unison240

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544239

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384

Vitaly Zaitsev  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #5 from Vitaly Zaitsev  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #4 from Vitaly Zaitsev  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: tcl-thread-debugsource : /usr/src/debug/tcl-
  thread-2.8.2-1.fc28.x86_64/generic/psGdbm.h tcl-thread-debugsource :
  /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/tclThread.h tcl-
  thread-debugsource : /usr/src/debug/tcl-
  thread-2.8.2-1.fc28.x86_64/generic/tclThreadInt.h tcl-thread-debugsource
  : /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/tclXkeylist.h
  tcl-thread-debugsource : /usr/src/debug/tcl-
  thread-2.8.2-1.fc28.x86_64/generic/threadSpCmd.h tcl-thread-debugsource :
  /usr/src/debug/tcl-thread-2.8.2-1.fc28.x86_64/generic/threadSvCmd.h tcl-
  thread-debugsource : /usr/src/debug/tcl-
  thread-2.8.2-1.fc28.x86_64/generic/threadSvKeylistCmd.h tcl-thread-
  debugsource : /usr/src/debug/tcl-
  thread-2.8.2-1.fc28.x86_64/generic/threadSvListCmd.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/tcl-thread
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "NTP", "Unknown or generated". 71 files
 have unknown license. Detailed output of licensecheck in
 /home/vitaly/1544384-tcl-thread/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/.build-id(kde-
 platform-plugin, nethogs, libhbalinux, cups-client, rsyslog, rpm-
 plugin-selinux, libimagequant, giflib, libreoffice-graphicfilter,
 xsel, trousers, dirac-libs, libdb-utils, xorg-x11-font-utils, OpenEXR-
 libs, libcom_err, libseccomp, ksysguardd, icoutils, p11-kit, libabw,
 mpgtx, gtkspell, libid3tag, libmodman, xdotool, dolphin-plugins,
 parted, kf5-kcontacts, libdvdread, zstd, kgreeter-plugins, bluez-libs,
 libbs2b, kf5-kjobwidgets, libwebp, libxslt, system-config-printer-
 udev, perl-Encode, elfutils, python2-cryptography, kf5-kdeclarative,
 libevdev, libgpg-error, lvm2-libs, kf5-sonnet-core, perl-Digest-SHA,
 reaver, perl-Params-Classify, kf5-solid, sddm, libzstd, liblognorm,
 wxBase, symlinks, libcdr, cdparanoia-libs, e2fsprogs-libs, pulseaudio-
 libs, usermode-gtk, lcms2, deltarpm, libxcb, libyubikey,
 python3-pycurl, openconnect, xcb-util-keysyms, kf5-threadweaver,
 libgphoto2, iw, tinyxml, xcb-util, libwmf-lite, mc, http-parser,
 qt5-qtspeech, pulseaudio-utils, perl-Sub-Identify, dolphin, kf5
 -kdelibs4support-libs, libeot, ImageMagick-c++, systemd-bootchart,
 uniconvertor, kf5-kpackage, kf5-kfilemetadata, perl-Ref-Util-XS, perl-
 Time-Piece, dbusmenu-qt, qca-qt5, ncurses-libs, libidn2, ldns, perl-
 Sys-Syslog, fcoe-utils, qhexedit2-qt5-libs, xorg-x11-xkb-utils,
 NetworkManager-openvpn, libxkbfile, hplip-libs, libwvstreams, kf5
 -kglobalaccel-libs, xmlrpc-c-client, sane-backends-drivers-cameras,
 python3-hawkey, libwpd, enchant2, libdc1394, perl-Time-HiRes, libwps,
 gssdp, cln, kactivitymanagerd, gimagereader-qt, libacl, xorg-x11-drv-
 ati, kf5-solid-libs, libSM, policycoreutils, mcelog, samba-common-
 tools, libgdiplus, libmusicbrainz5, pptp, sane-backends-drivers-
 scanners, libXxf86misc, foomatic, python3-reportlab, minizip,
 libpath_utils, rpm-build, libglvnd-gles, rpm-plugin-systemd-inhibit,
 rpm-sign, freeglut, gstreamer1, libnatspec, libtomcrypt, dbus-libs,
 libreoffice-gtk3, libreoffice-gtk2, optipng, librtmp, cairo-gobject,
 libkkc, sgpio, gutenprint, openal-soft, usermode, libfbclient2, qpdf-
 libs, linux-atm-libs, pyparted, libedit, openssh, atk, python3-cairo,
 SDL_net, accountsservice, isl, hfsplus-tools, krename, ImageMagick,
 perl-IPC-SysV, gssproxy, mesa-libGLU, libblockdev-btrfs,
 libatomic_ops, 

[Bug 1543813] Review Request: pwkickstart - generate kickstart passwords

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1543813



--- Comment #2 from Lukas Zapletal  ---
Thanks Neal,

good one. I actually bumped upstream to 1.0.2 so there is now both python3 and
2 compatibility. Shebang now uses python3 by default.

https://github.com/lzap/pwkickstart/commit/c19c8a5b77b8c884461a7d17d38391471fb9fb63

Rebased the SPEC on the new version and added python3 as the dependency.

https://github.com/lzap/spec_reviews/commit/298b101e7574ae7c956095be9cff3e6af3f785f6

SPEC URL:
https://raw.githubusercontent.com/lzap/spec_reviews/master/pwkickstart.spec
SRPM URL:
https://lzap.fedorapeople.org/fedora-packaging/pwkickstart/1.0.2/pwkickstart-1.0.2-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1540833] Review Request: racket - programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1540833

Damian Wrobel  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||dwro...@ertelnet.rybnik.pl
 Resolution|--- |DUPLICATE
Last Closed||2018-02-12 08:25:34



--- Comment #4 from Damian Wrobel  ---


*** This bug has been marked as a duplicate of bug 1301219 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1301219] Review Request: racket - Racket is a full-spectrum programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301219



--- Comment #15 from Damian Wrobel  ---
*** Bug 1540833 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #3 from Vasiliy Glazov  ---
Spec URL:
https://src.fedoraproject.org/fork/vascom/rpms/tcl-thread/raw/master/f/tcl-thread.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/6624/24966624/tcl-thread-2.8.2-1.fc28.src.rpm

Debuginfo package enabled.
Requires of tcl(abi) = 8.6 is necessary because not processing automatically.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202

Damian Wrobel  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #26 from Damian Wrobel  ---
Raphael,

Please consider adding upstream link to patches as per [6].

Package approved.

[6]
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384



--- Comment #2 from Vitaly Zaitsev  ---
> %global debug_package %{nil}

Remove this row. Your package contains binaries, so they need to be stripped
into debuginfo package.

> Requires:   tcl(abi) = 8.6

You don't need to specify ABI version. Rpmbuild will do it automatically.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384

Vitaly Zaitsev  changed:

   What|Removed |Added

 CC||vit...@easycoding.org
   Assignee|nob...@fedoraproject.org|vit...@easycoding.org



--- Comment #1 from Vitaly Zaitsev  ---
I will review this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1310434] Review Request: python-wxpython4 - new implementation of wxPython (Phoenix)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310434



--- Comment #11 from Miro Hrončok  ---
(In reply to Scott Talbert from comment #9)
> (In reply to Miro Hrončok from comment #4)
> > There are wxWidgets in ext/wxWidgets, are those used or not? If not, can the
> > folder be deleted, just to make it clear?
> 
> The wxWidgets source isn't used EXCEPT for the interface headers
> (ext/wxWidgets/interface/...) and the doxygen stuff.  So, we can't delete
> ext/wxWidgets completely, but we could delete some subset of it.  What do
> you think about that?

Can we somehow use the wxGTK3-devel header files instead? If not, just maybe
add a note to the spec?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #36 from Antonio Trande  ---
Why not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544384] New: Review Request: tcl-thread - Tcl Thread extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544384

Bug ID: 1544384
   Summary: Review Request: tcl-thread - Tcl Thread extension
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: vasc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://src.fedoraproject.org/fork/vascom/rpms/tcl-thread/raw/master/f/tcl-thread.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/4407/24964407/tcl-thread-2.8.2-1.fc28.src.rpm

Description:
Thread extension for the Tcl toolkit.  You can use this extension to gain
script level access to Tcl threading capabilities.

Homepage http://tcl.sourceforge.net/

This package already was in repo but retired. I am want unretire and update it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #35 from Alexander Ploumistos  ---
Antonio, do you think that I should add Molsketch (and/or SciDAVis) to the
comps XML file under "Engineering and Scientific"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #9 from Vít Ondruch  ---
Oh, you are applying the latest packaging techniques (unpacking the gem via
%setup), very nice :)

However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite fails
entirely, you won't notice. I would rather see the tests disabled one by one or
some explanation at minimum.

Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility with
latest RSpec? Isn't there patch available upstream already?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1544081] Review Request: grc - Generic Colorizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1544081



--- Comment #4 from Robin Lee  ---
(In reply to Robert-André Mauchin from comment #3)
>  - You didn't change 1.11.1 by %{version} in Source0. It would be easier for
> future updates.
Sorry, I missed this point. I will fix it during importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org