Re: [PATCHES] Admin functions contrib
Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. Andreas is asking. Please commit ASAP. Is I stated several times, I'll do the win32 as soon as I get a chance to. It's not a logger file issue, it's a *win32 stderr* problem. If you believe that a feature must support all systems, tablespace must be removed as well. Regards, Andreas ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] Admin functions contrib
Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. How is logging typically handled on Windows? -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Admin functions contrib
Peter Eisentraut wrote: Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. How is logging typically handled on Windows? It is done using the eventlog service (which is supported as replacement for syslog now) or in case of MSSQL as file logging. MSSQL in more detail: In eventlog only the most important MSSQL messages will appear (start/stop, PANIC), while the rest is done in logfiles (retrievable over client tools, rotatable using sp_cycle_errorlog) and may grow much larger than eventlog (which will receive messages from all apps/services). This handling is so throughout M$ apps, like webserver etc: fatals to eventlog, the rest to files. Regards, Andreas ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Admin functions contrib
It's better than no patch I think. /D -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Sat 7/31/2004 5:33 AM To: Dave Page Cc: Tom Lane; Andreas Pflug; PostgreSQL Patches Subject: Re: [PATCHES] Admin functions contrib Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. Andreas is asking. --- Dave Page wrote: -Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 29 July 2004 18:41 To: Andreas Pflug Cc: Bruce Momjian; PostgreSQL Patches; Dave Page Subject: Re: [PATCHES] Admin functions contrib Andreas Pflug [EMAIL PROTECTED] writes: Bruce Momjian wrote: So, I suggest we get the logging code into the backend, and you can code anything you want pgadmin to do in plperlu, and Win32 supports plperlu too. The big advantage is that you can improve the plperlu functions with every release of pgadmin. I do not agree on this. Administrative tools should require as few additional backend packages as possible. This argument doesn't really hold water when the alternative is a contrib package. It's considerably more likely that the installation will have plperl than that it will have some random contrib package. Also, what happens if you find that the contrib package doesn't do everything you need? You'll be stuck for another PG release cycle, whereas rejiggering a plperl function that pgadmin is defining for itself is no problem. pgAdmin I used to create helper functions and views on the server, and not only were they a *real* pain in the neck to manage, but they were also the most often complained about 'feature' of pgAdmin, to the extent that when pgAdmin II was written, rule number #1 was 'it must offer 100% functionality on a clean, standard database with no server side objects'. In pga1 it even got to the stage that I wrote a cleanup wizard to allow ppl to remove the stuff that was created. We also had problems with people who had limited access to their servers (because they were ISP hosted etc). I've not even persuaded hub.org to install pl/pgsql for the postgresql.org sites for example - I can't imagine the response I'd get if I asked for pl/perlu!! This is primarily why we want to get the functionality into the backend. Secondary to that, it will also allow phpPgAdmin and other tools to offer the same functionality. It could be argued of course, that a contrib module violates our standard database rule (which it does), but it does at least allow us to get some standard code into the distribution, in a way that /might/ be compatible with the feature freeze, with a view to full integration in the next cycle. As Bruce has seen, this is some pretty nice functionality that Andreas has added to pga3, and is one of the few areas that we lag behind SQL Server etc. in on the management front. Regards, Dave. ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Admin functions contrib
Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows. Personally, of course, I won't care if it never works on Windows. But I suspect there are some out there who do care ;-). It might be better to wait till we're sure there's a reasonable implementation path for Windows. regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Admin functions contrib
Tom Lane wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. I'm slightly worried that we might be painting ourselves into a corner, ie implementing functionality that will never work on Windows. Personally, of course, I won't care if it never works on Windows. But I suspect there are some out there who do care ;-). It might be better to wait till we're sure there's a reasonable implementation path for Windows. Actually, I believe the implementation I did first (having all processes append to the logfile themselves) would have worked for win32 too. As long as you don't impose linux-centric limitations on win32 implementations, there certainly *are* solutions to the problem. A very reasonable way would be to have the win32_signal_waiter thread not only wait for the child terminating, but also checking the pipe. This is certainly *the* recommended win32 way. Regards, Andreas ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] win32 timezone map
Per discussion off-list with Tom, here is a patch to redo the way the system timezone is detected on win32. Er ... no patch attached? Heh. Oops. //Magnus tz_map.patch Description: tz_map.patch ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
[PATCHES] bootstrap does not init paths
Seems bootstrapmain() never called find_my_exec(), and therefor never manged to fill in the path to the timezone directory. With the new timezone code that actully picks up a decent timezone on my system, that causes initdb to fail because it can't find any acceptable timezone at all. This patch adds the required call to bootstrapmain(), and initdb works again for me. Code itself directly copied from postgresmain(). //Magnus bootstrap_init.patch Description: bootstrap_init.patch ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
[PATCHES] correct docbook version
Hi, I saw some inconsistence in the docbook version. Here is a patch that just correct it. -- Euler Taveira de Oliveira euler (at) ufgnet.ufg.br Desenvolvedor Web e Administrador de Sistemas UFGNet - Universidade Federal de Goiás docbook.diff Description: Binary data ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [PATCHES] correct docbook version
Euler Taveira de Oliveira wrote: I saw some inconsistence in the docbook version. Here is a patch that just correct it. These files are obsolete. I've removed them. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send unregister YourEmailAddressHere to [EMAIL PROTECTED])
Re: [PATCHES] bootstrap does not init paths
Magnus Hagander [EMAIL PROTECTED] writes: This patch adds the required call to bootstrapmain(), and initdb works again for me. Code itself directly copied from postgresmain(). Applied, except I moved it up a little bit. In the PostgresMain case this is done before InitializeGUCOptions(), and it seems best to keep the ordering consistent. regards, tom lane ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html
[PATCHES] Another transation fix
Here is another try at fixing the translation message. Instead of
removing the backslashes in the message, I escaped them. Per discussion
with Joe Conway.
--
Bruce Momjian| http://candle.pha.pa.us
[EMAIL PROTECTED] | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup.| Newtown Square, Pennsylvania 19073
Index: zh_TW.po
===
RCS file: /cvsroot/pgsql-server/src/bin/initdb/po/zh_TW.po,v
retrieving revision 1.1
retrieving revision 1.3
diff -c -c -r1.1 -r1.3
*** zh_TW.po30 Jul 2004 05:28:36 - 1.1
--- zh_TW.po31 Jul 2004 20:00:26 - 1.3
***
*** 197,203
#: initdb.c:1864
msgid ok\n
! msgstr ¦¨¥\\n
#: initdb.c:1894
#, c-format
--- 197,203
#: initdb.c:1864
msgid ok\n
! msgstr ¦¨¥\\\n
#: initdb.c:1894
#, c-format
***
*** 257,263
#: initdb.c:1973
msgid --no-locale equivalent to --locale=C\n
! msgstr --no-locale ¥\¯à¦P --locale=C\n
#: initdb.c:1974
msgid -U, --username=NAME database superuser name\n
--- 257,263
#: initdb.c:1973
msgid --no-locale equivalent to --locale=C\n
! msgstr --no-locale ¥\\¯à¦P --locale=C\n
#: initdb.c:1974
msgid -U, --username=NAME database superuser name\n
***
*** 468,474
\n
msgstr
\n
! °õ¦æ¦¨¥\¡A²{¦b§A¥i¥H¥Î¤U¦C©R¥O±Ò°Ê¸ê®Æ®w¦øªA¾¹:\n
\n
%s%s%s/postmaster -D %s%s%s\n
©Î\n
--- 468,474
\n
msgstr
\n
! °õ¦æ¦¨¥\\¡A²{¦b§A¥i¥H¥Î¤U¦C©R¥O±Ò°Ê¸ê®Æ®w¦øªA¾¹:\n
\n
%s%s%s/postmaster -D %s%s%s\n
©Î\n
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly
Re: [PATCHES] Another transation fix
Bruce Momjian wrote: Here is another try at fixing the translation message. Instead of removing the backslashes in the message, I escaped them. Per discussion with Joe Conway. Now I'm getting three errors instead of one: msgfmt -o po/zh_TW.mo po/zh_TW.po po/zh_TW.po:199: `msgid' and `msgstr' entries do not both end with '\n' po/zh_TW.po:260:40: invalid control sequence po/zh_TW.po:471:11: invalid control sequence msgfmt: found 3 fatal errors Not sure if it is relevant, but here are my locale related environment variables: LANG=C LANGUAGE=C LC_ALL=C This is on a Fedora core 2 machine. Anyone have any ideas how to properly fix this? Thanks, Joe ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
[PATCHES] win32 version info - try 2
Here's another attempt at adding version info to win32 stuff. Lots of changes since last try :-) * Build rules in Makefile.global builds the .o or .rc file required. Each makefile defines PGFILEDESC with a file description that gets imported. * Full version number is pulled from pg_config.h. The numeric-only version number is just in win32ver.rc - I notice the release instructions have manual editing of the other rc file already, so it's not that much more work. It can easily be changed by adding to configure, but I'm not sure it's worth the job now that there is just one place that would use it. * Versioninfo not set on all DLLs, just the ones that would normally be linked against client programs. I'd still like to see it on more, but it's not *that* important. It could easily be added using the same rules if we wanted to. It still uses the 7.5.x.y version number notation, since for now it only affects pgevent.dll which is win32 only anyway and doesn't have a version number of its own. * Just two files to add - both go in src/port. (Moved the icon there per discussion on IM with Bruce) * A makefile can set PGAPPICON=iconname to specify an icon to be linked in. (I don't know how icons work on other platforms, this could perhaps be extended to others?) //Magnus win32ver_2.patch Description: win32ver_2.patch attachment: pgsql.ico win32ver.rc Description: win32ver.rc ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
Re: [PATCHES] win32 version info - try 2
Magnus Hagander wrote: * Just two files to add - both go in src/port. (Moved the icon there per discussion on IM with Bruce) Can you post the rationale? It seem an odd place for it. But it still holds that we a) should not put binary files in our CVS b) cannot put binary files without source in our CVS We can import the original format (or some variant) and create the icon at build time. This would also be better for other distributors. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
Re: [PATCHES] win32 version info - try 2
* Just two files to add - both go in src/port. (Moved the icon there per discussion on IM with Bruce) Can you post the rationale? It seem an odd place for it. We might want to link it into other binaries in the future, therefor it should not go under psql/. It's platform specific, therefor it should go in port/. But it still holds that we a) should not put binary files in our CVS Why exactly is this? I asked before, and the only response I ever got (off-list) was that we actually could... b) cannot put binary files without source in our CVS See (a). We can import the original format (or some variant) and create the icon at build time. This would also be better for other distributors. The source is in .ai format, and there is manual work to convert it into a good quality .ico, from what I read on the authors page. AFAIK, .ai is also binary, and it's hard to put a person in a Makefile. Is it the concept of non-sourcecode, or is it the fact that it's actually binary that is the issue? E.g. will it help if we for example uuencoded it and then just uudecode:ed it in a build rule? //Magnus ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Another transation fix
Joe Conway wrote: FWIW, I can compile with the attached patch. That looks awfully close to what we started from... :-/ -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] win32 version info - try 2
Magnus Hagander wrote: It's platform specific, therefor it should go in port/. The criterion for port/ is not whether something is platform-specific. It's whether it's a module that helps porting source code. Which this is not. Maybe we should add a new directory that contains icons and other random auxiliary files such as .desktop files for Linux desktops. Is it the concept of non-sourcecode, or is it the fact that it's actually binary that is the issue? E.g. will it help if we for example uuencoded it and then just uudecode:ed it in a build rule? The problem isn't so much binary files vs. CVS, although that is an annoyance to take into account. The issue is that we need to have the source code for all files that we distribute, where source code is the preferred form for modification. This is a legal issue, a philosophical issue, and a practical issue. If you say the icon is created by hand, then that's OK, although up to now I've created all icons programmatically from, say, a PNG or SVG source. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] win32 version info - try 2
It's platform specific, therefor it should go in port/. The criterion for port/ is not whether something is platform-specific. It's whether it's a module that helps porting source code. Which this is not. Maybe we should add a new directory that contains icons and other random auxiliary files such as .desktop files for Linux desktops. Sure, that works for me. It's a simple path change in Makefile.global.in. So whatever works for you guys. Is it the concept of non-sourcecode, or is it the fact that it's actually binary that is the issue? E.g. will it help if we for example uuencoded it and then just uudecode:ed it in a build rule? The problem isn't so much binary files vs. CVS, although that is an annoyance to take into account. The issue is that we need to have the source code for all files that we distribute, where source code is the preferred form for modification. This is a legal issue, a philosophical issue, and a practical issue. If you say the icon is created by hand, then that's OK, although up to now I've created all icons programmatically from, say, a PNG or SVG source. Well, what I did was, as I wrote in my original mail, download it from http://pgsql.gavinroy.com/art/. AFAIK the original source of it is a .ai file, though. I'll have to ask Gavin about how the file was actually created, it if twas done manually or through an automatable process. Gavin - hopefully you can say something on how it's done? Thanks. //Magnus ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Another transation fix
Joe Conway wrote:
Bruce Momjian wrote:
Here is another try at fixing the translation message. Instead of
removing the backslashes in the message, I escaped them. Per discussion
with Joe Conway.
Now I'm getting three errors instead of one:
msgfmt -o po/zh_TW.mo po/zh_TW.po
po/zh_TW.po:199: `msgid' and `msgstr' entries do not both end with '\n'
po/zh_TW.po:260:40: invalid control sequence
po/zh_TW.po:471:11: invalid control sequence
msgfmt: found 3 fatal errors
FWIW, I can compile with the attached patch.
Joe
? src/bin/initdb/po/de.mo
? src/bin/initdb/po/fr.mo
? src/bin/initdb/po/it.mo
? src/bin/initdb/po/pt_BR.mo
? src/bin/initdb/po/ru.mo
? src/bin/initdb/po/sv.mo
? src/bin/initdb/po/zh_TW.mo
Index: src/bin/initdb/po/zh_TW.po
===
RCS file: /cvsroot/pgsql-server/src/bin/initdb/po/zh_TW.po,v
retrieving revision 1.3
diff -c -r1.3 zh_TW.po
*** src/bin/initdb/po/zh_TW.po 31 Jul 2004 20:00:26 - 1.3
--- src/bin/initdb/po/zh_TW.po 31 Jul 2004 22:02:59 -
***
*** 197,203
#: initdb.c:1864
msgid ok\n
! msgstr ¦¨¥\\\n
#: initdb.c:1894
#, c-format
--- 197,203
#: initdb.c:1864
msgid ok\n
! msgstr ¦¨¥\\n
#: initdb.c:1894
#, c-format
***
*** 257,263
#: initdb.c:1973
msgid --no-locale equivalent to --locale=C\n
! msgstr --no-locale ¥\\¯à¦P --locale=C\n
#: initdb.c:1974
msgid -U, --username=NAME database superuser name\n
--- 257,263
#: initdb.c:1973
msgid --no-locale equivalent to --locale=C\n
! msgstr --no-locale ¥\¯à¦P --locale=C\n
#: initdb.c:1974
msgid -U, --username=NAME database superuser name\n
***
*** 468,474
\n
msgstr
\n
! °õ¦æ¦¨¥\\¡A²{¦b§A¥i¥H¥Î¤U¦C©R¥O±Ò°Ê¸ê®Æ®w¦øªA¾¹:\n
\n
%s%s%s/postmaster -D %s%s%s\n
©Î\n
--- 468,474
\n
msgstr
\n
! °õ¦æ¦¨¥\¡A²{¦b§A¥i¥H¥Î¤U¦C©R¥O±Ò°Ê¸ê®Æ®w¦øªA¾¹:\n
\n
%s%s%s/postmaster -D %s%s%s\n
©Î\n
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Admin functions contrib
This logging issue has drained a lot of time during feature freeze when we should be getting existing patches in and completed. I am willing to apply a perfect patch but I am not willing to spend anymore time on this than I have to. This is all something that shouldn't be happening during feature freeze. I realize this patch is important to Andreas but every patch is important to its author. We have done just fine without this functionality for years so I don't see the rush to get it in. You can say Win32 will make it more significant, but if it doesn't work on Win32 yet, the argument doesn't work. And I am not going to apply a patch with the promise that a more complete one is coming later. I am not saying I am going to reject the patch if it arrives but I am not but I am not going to be upset if it doesn't make it in until 7.6. --- Andreas Pflug wrote: Bruce Momjian wrote: Do people want the server file logging/rotating patch applied if it is Unix-only? Right now the patch is ifdef'ed so Win32 use of it is disabled. Andreas is asking. Please commit ASAP. Is I stated several times, I'll do the win32 as soon as I get a chance to. It's not a logger file issue, it's a *win32 stderr* problem. If you believe that a feature must support all systems, tablespace must be removed as well. Regards, Andreas ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED] -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings
Re: [PATCHES] [subxacts] Last try before beta
Alvaro Herrera [EMAIL PROTECTED] writes: Here is the last patch before beta for subtransactions. It fixes the following outstanding issues: - Add (some) user savepoint documentation The patch seems to intend to add three reference-page sgml files, but those files are missing? regards, tom lane ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
[PATCHES]Traditional Chinese pgscripts-zh_TW.po for 7.5
Can't find this one on mailing list so I resend this. All messages are translated. Thank you. pgscripts-zh_TW.po Description: Binary data ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] [subxacts] Last try before beta
Alvaro Herrera Munoz [EMAIL PROTECTED] writes: The patch seems to intend to add three reference-page sgml files, but those files are missing? No, the files are embedded in the patch ... I avoided using cvs diff to create the patch -- rather I diff'd two source trees, which includes the new files inline. Ah, got it. Thanx. I think the locking is still a few bricks shy of a load ... working on it now ... regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
