D10890: Don't skip certain recent documents in kicker and taskmanager

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  lgtm

REPOSITORY
  R119 Plasma Desktop

BRANCH
  prepare_for_krecentdocument_fix

REVISION DETAIL
  https://phabricator.kde.org/D10890

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

[Yuri Chornoivan]

yurchor added inline comments.

INLINE COMMENTS

> main.qml:132
> +   if(!connectCtx){
> +   var conError = i18n("I am not connected to the  internet, 
> Please check your network connection")
> +   convoLmodel.append({"itemType": "NonVisual", "InputQuery": 
> conError});

Is it necessary to use "" between "the" and "internet" in this message? Thanks 
in advance for your answer.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D11142

To: Aiix, #plasma
Cc: yurchor, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11148: Move applet packages' /code subdirs below /ui subdirs

[Aleix Pol Gonzalez]

apol added a comment.


  In D11148#221135 , @broulik wrote:
  
  > Well, the package definition says JS files must (should) be in "code", I 
don't see the advantage of moving this.
  
  
  There's no advantage to that rule though.
  
  Also AFAIR there's a warning that complains about that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11148

To: kossebau, #plasma, mart, broulik, hein
Cc: apol, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D10747: Implement zwp_linux_dmabuf_v1

[Fredrik Höglund]

fredrik updated this revision to Diff 28986.
fredrik added a comment.


  Import the context.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=27735=28986

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Roman Gilg]

romangg added a comment.


  Well we need to stop exporting the QT_QPA_PLATFORM value in startup script in 
any case, right? Or when we depend on Qt 5.11 and then set it to "wayland;x11" 
does it not break apps depending on Qt 5.y, y<11? So the question is just if we 
want to wait till we depend on 5.11 with this removal or do it now (and using 
the helper function proposed in this diff instead).
  
  Putting this helper function into some framework is unnecessary though, that 
I can see now.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11148: Move applet packages' /code subdirs below /ui subdirs

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D11148#221135 , @broulik wrote:
  
  > Well, the package definition says JS files must (should) be in "code", I 
don't see the advantage of moving this.
  
  
  That would the be another place to fix.
  
  Motivation for this and the other patches is this from today:
  
  [17:20]  notmart: hi. quick question: what is it with all the 
warnings "Warning: all files used by qml by the plasmoid should be in ui/." for 
*.js files which seem by standard located in the sibling "code/"  directory 
instead? there are quite some during plasmashell run
  [17:21]  is that a bogus warning which should be fixed for js 
files? or should js files be relocated in the future?
  [17:25]  frinring: yeah, js files should be relocated in the future
  [17:26]  notmart: what would be the new recommendation? ui/code/
  [17:27]  frinring: we used to have a very complicated rewrite for 
accessing files for doing things like that and force js from there
  [17:28]  then, profiling ended up eating a non trascurable time of 
bootup :)
  [17:28]  frinring: so yeah, either in ui/ directly or in ui/code 
which is cleaner, so it doesn't weight onto that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11148

To: kossebau, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11148: Move applet packages' /code subdirs below /ui subdirs

[Kai Uwe Broulik]

broulik added a comment.


  Well, the package definition says JS files must (should) be in "code", I 
don't see the advantage of moving this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11148

To: kossebau, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11148: Move applet packages' /code subdirs below /ui subdirs

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart, broulik, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  As there are quite a bit QML files in the respective /ui subdir, having the
  JS file in another separate subdir named /code as befire provides
  good overview

TEST PLAN
  Applets UI & Config still work as before

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mergeappletcodedirintouidir

REVISION DETAIL
  https://phabricator.kde.org/D11148

AFFECTED FILES
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kicker/package/contents/ui/code/tools.js
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/ui/KickoffItem.qml
  applets/kickoff/package/contents/ui/code/tools.js
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/code/layout.js
  applets/taskmanager/package/contents/ui/code/tools.js
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, #plasma, mart, broulik, hein
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[David Edmundson]

davidedmundson added a comment.


  > interest to other apps as well, which can't yet rely on Qt 5.11
  
  The 5.11 changes are about runtime Qt, not any new API. Apps will have to do 
nothing.
  The app itself can still rely on Qt5.0.
  
  -
  
  We discussed in the meeting, I still think it's a bad idea to waste time 
bodging an already properly solved problem - and in exchange for fixing some 
obscure bundled apps we break other stuff and make wayland app-dev harder.
  
  But I also said I wouldn't block this specific proposal as it is here.
  
  Code is fine +0

REPOSITORY
  R120 Plasma Workspace

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: davidedmundson, romangg, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11145: Merge applet packages' /code subdirs into /ui subdirs

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart, broulik.
Restricted Application added a project: Plasma.
kossebau requested review of this revision.

REVISION SUMMARY
  As there are only a few QML files in the respective /ui subdir, having the
  JS file in the same dir still provides good overview

TEST PLAN
  Applets UI & Config still work as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mergeappletcodedirintouidir

REVISION DETAIL
  https://phabricator.kde.org/D11145

AFFECTED FILES
  applets/batterymonitor/package/contents/code/logic.js
  applets/batterymonitor/package/contents/ui/logic.js
  applets/lock_logout/contents/code/data.js
  applets/lock_logout/contents/ui/data.js
  applets/notifications/package/contents/code/uiproperties.js
  applets/notifications/package/contents/ui/uiproperties.js

To: kossebau, #plasma, mart, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Martin Flöser]

graesslin added a comment.


  In D10816#221084 , @romangg wrote:
  
  > Hmm, what about application distributed as distro packages? Anyways,if you 
think this is a non-issue, feel free to push.
  
  
  Let's be realistic. Many applications we ship don't even have the desktop 
file name fixed for Wayland. I doubt we would see adjustments for this prior to 
distros shipping Qt 5.11.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: romangg, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Hmm, what about application distributed as distro packages? Anyways,if you 
think this is a non-issue, feel free to push.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  platform-detection

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma, romangg
Cc: romangg, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: plasma-desktop-5.12.3 bug report

[Nate Graham]

Hi David,
Bug reports are submitted using Bugzilla, not email. See:
- https://bugs.kde.org/
- https://community.kde.org/Get_Involved/Bug_Reporting

Nate


On 03/07/2018 02:02 AM, David Binderman wrote:

Hello there,


plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error) 
Memory leak: oldCorr



Source code is

   if ( ::ioctl(fd, JSIOCGCORR, oldCorr) == -1 )
   {
     ::close(fd);
     delete [] oldCorr;
     return JoyDevice::ERR_GET_CORR;
   }

   if (bt < 0) {
   return JoyDevice::ERR_GET_BUTTONS;
   }

One if statement tidies things up, the other doesn't. Suggest code rework.
It would also be more efficient if the sanity check for bt were moved
to just after where it is set up.

Regards

David Binderman

D11144: Merge applet packages' /code subdirs into /ui subdirs

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  As there are only a few QML files in the respective /ui subdir, having the
  JS file in the same dir still provides good overview

TEST PLAN
  Applets UI & Config still work as before

REPOSITORY
  R114 Plasma Addons

BRANCH
  mergecodesubdirinuidir

REVISION DETAIL
  https://phabricator.kde.org/D11144

AFFECTED FILES
  applets/colorpicker/package/contents/code/logic.js
  applets/colorpicker/package/contents/ui/configGeneral.qml
  applets/colorpicker/package/contents/ui/logic.js
  applets/colorpicker/package/contents/ui/main.qml
  applets/quicklaunch/package/contents/code/layout.js
  applets/quicklaunch/package/contents/ui/IconItem.qml
  applets/quicklaunch/package/contents/ui/Popup.qml
  applets/quicklaunch/package/contents/ui/layout.js
  applets/quicklaunch/package/contents/ui/main.qml

To: kossebau, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Plasma 5.12.3

[Luna Jernberg]

 Updating now :)

On Tue, Mar 6, 2018 at 3:39 PM, Jonathan Riddell  wrote:

> Plasma 5.12.3 bug fix release is available now for packagers
>
> https://www.kde.org/announcements/plasma-5.12.3.php
>

plasma-desktop-5.12.3 bug report

[David Binderman]

Hello there,


plasma-desktop-5.12.3/kcms/hardware/joystick/joydevice.cpp:188]: (error) Memory 
leak: oldCorr

Source code is

  if ( ::ioctl(fd, JSIOCGCORR, oldCorr) == -1 )
  {
::close(fd);
delete [] oldCorr;
return JoyDevice::ERR_GET_CORR;
  }

  if (bt < 0) {
  return JoyDevice::ERR_GET_BUTTONS;
  }

One if statement tidies things up, the other doesn't. Suggest code rework.
It would also be more efficient if the sanity check for bt were moved
to just after where it is set up.

Regards

David Binderman

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Martin Flöser]

graesslin added a comment.


  In D10816#220991 , @romangg wrote:
  
  > Shouldn't this function go directly in KWayland as some utily function 
`xdgSessionToQpaPlatform`? I believe it's generic enough for that and even 
though Qt 5.11 will have detection for QT_QPA_PLATFORM the function could be of 
interest to other apps as well, which can't yet rely on Qt 5.11. In particular 
of course KDE apps themselves.
  
  
  I think we don't need it in frameworks as application using our flatpack 
runtime get the behavior for free.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: romangg, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

[Aditya Mehra]

Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Aiix requested review of this revision.

REVISION SUMMARY
  Check if there is an internet connection available before displaying 
information cards
  
  - Ping example.com to check connection availability
  - Wait for active internet connection to connect to plasma geolocation 
datasource
  - Do not display information cards in not connected as they are dependent on 
GeoLocation data

REPOSITORY
  R846 Mycroft Plasma integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11142

AFFECTED FILES
  CMakeLists.txt
  plasmoid/contents/ui/main.qml
  plugin/CMakeLists.txt
  plugin/connectioncheck.cpp
  plugin/connectioncheck.h
  plugin/mycroftplasmoidplugin.cpp

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

[Aditya Mehra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:7a9795631062: Add ConnectionCheck for Dash Cards 
(authored by Aiix).

REPOSITORY
  R846 Mycroft Plasma integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11142?vs=28975=28976

REVISION DETAIL
  https://phabricator.kde.org/D11142

AFFECTED FILES
  CMakeLists.txt
  plasmoid/contents/ui/main.qml
  plugin/CMakeLists.txt
  plugin/connectioncheck.cpp
  plugin/connectioncheck.h
  plugin/mycroftplasmoidplugin.cpp

To: Aiix, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias marked 2 inline comments as done.
Kanedias added a comment.


  @romangg , I had to recreate it after rebase, cause I don't have force-push.

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 28973.
Kanedias added a comment.


  Review comments

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1230?vs=25979=28973

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

AFFECTED FILES
  main_wayland.cpp
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/drm_backend.cpp
  plugins/platforms/drm/drm_buffer_gbm.h
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg added a comment.


  Please import the context. This makes reviews more easy. Either via -U9 
flag to git diff or (for future diffs) by using arc directly on a feature 
branch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart
Cc: romangg, plasma-devel, #frameworks, schernikov, michaelh, ZrenBot, 
alexeymin, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D1230: GBM remote access support for KWin

[Roman Gilg]

romangg added a comment.


  Pls remove the whitespace and rebase your branch on current master (it merges 
without conflict).

INLINE COMMENTS

> drm_backend.cpp:793
>  }
> +

rm whitespace

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

[Roman Gilg]

romangg added a comment.


  Shouldn't this function go directly in KWayland as some utily function 
`xdgSessionToQpaPlatform`? I believe it's generic enough for that and even 
though Qt 5.11 will have detection for QT_QPA_PLATFORM the function could be of 
interest to other apps as well, which can't yet rely on Qt 5.11. In particular 
of course KDE apps themselves.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10816

To: graesslin, #plasma
Cc: romangg, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11009: Make passiveNotifications last longer, so users can actually read them

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11009

To: ngraham, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added a comment.


  Not so sure why phabricator didn't set you as the commit author... sorry 
about that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e2a29f8ea072: Migration request from IBusConfig to 
GSettings (authored by xuetianweng).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11061?vs=28920=28964

REVISION DETAIL
  https://phabricator.kde.org/D11061

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11009: Make passiveNotifications last longer, so users can actually read them

[Nathaniel Graham]

ngraham updated this revision to Diff 28965.
ngraham added a comment.


  Rebase on master

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11009?vs=28534=28965

BRANCH
  longer-lasting-passiveNotifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11009

AFFECTED FILES
  src/controls/templates/private/PassiveNotification.qml

To: ngraham, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11134: ToolbarApplicationHeader layout

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2e7ec021ad0e: ToolbarApplicationHeader layout (authored 
by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11134?vs=28960=28963#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11134?vs=28960=28963

REVISION DETAIL
  https://phabricator.kde.org/D11134

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml

To: mart, #kirigami, apol
Cc: apol, ngraham, plasma-devel, davidedmundson, mart, hein

D11134: ToolbarApplicationHeader layout

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> Units.qml:101
>  
> -readonly property QtObject __styleItem: QtQuickControlsPrivate.StyleItem 
> {elementType: "frame" }
> +//readonly property QtObject __styleItem: 
> QtQuickControlsPrivate.StyleItem {elementType: "frame" }
>  

Unrelated change.

REPOSITORY
  R169 Kirigami

BRANCH
  phab/toolbartweak

REVISION DETAIL
  https://phabricator.kde.org/D11134

To: mart, #kirigami, apol
Cc: apol, ngraham, plasma-devel, davidedmundson, mart, hein

D11134: ToolbarApplicationHeader layout

[Nathaniel Graham]

ngraham added a comment.


  +1, this is a huge visual improvement in my eyes.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11134

To: mart, #kirigami
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D8827: experimental support for auto mnemonics

[Aleix Pol Gonzalez]

apol added a comment.


  Big +1, missed it earlier.
  
  Won't upstream QQC2 come up with something in this regard?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D8827

To: mart, #plasma
Cc: apol, hein, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D11134: ToolbarApplicationHeader layout

[Marco Martin]

mart updated this revision to Diff 28960.
mart edited the summary of this revision.
mart added a comment.


  - paddings fixes

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11134?vs=28956=28960

BRANCH
  phab/toolbartweak

REVISION DETAIL
  https://phabricator.kde.org/D11134

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/AbstractListItem.qml
  src/controls/templates/ApplicationHeader.qml
  src/styles/org.kde.desktop/Units.qml

To: mart, #kirigami
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11134: some layouting tweaks

[Marco Martin]

mart created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  phab/toolbartweak

REVISION DETAIL
  https://phabricator.kde.org/D11134

AFFECTED FILES
  src/controls/ToolBarApplicationHeader.qml
  src/controls/private/PrivateActionToolButton.qml
  src/controls/templates/ApplicationHeader.qml
  src/styles/org.kde.desktop/Units.qml

To: mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D8827: experimental support for auto mnemonics

[Marco Martin]

mart updated this revision to Diff 28954.
mart added a comment.


  - kirigami 2.3 needed

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8827?vs=28926=28954

BRANCH
  arcpatch-D8827

REVISION DETAIL
  https://phabricator.kde.org/D8827

AFFECTED FILES
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/ToolButton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: mart, #plasma
Cc: hein, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11133: Fix minimise all applet on wayland with an active window

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  There's an async round trip after requesting isMinimized to kwin and
  then back to Plasma with the updated roles.
  
  There's a quirk on wayland that IsActive will update before we get
  isMinimized changed. The old code would see that a window is currently
  not minimised and deactivate the effect.
  
  This patch checks the roles to only check after IsMinimized changes.

TEST PLAN
  More clicking

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11133

AFFECTED FILES
  applets/minimizeall/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11059: Add convenience method to get a persistent model index from TasksModel

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:290ee95dacdf: Add convenience method to get a persistent 
model index from TasksModel (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11059?vs=28720=28947#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11059?vs=28720=28947

REVISION DETAIL
  https://phabricator.kde.org/D11059

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp
  libtaskmanager/tasksmodel.h

To: davidedmundson, #plasma, hein
Cc: broulik, Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:be06f0b74073: Allow users to change the format to BCD 
(decimal) in Binary Clock widget (authored by piotrkakol, committed by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10434?vs=27024=28945#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10434?vs=27024=28945

REVISION DETAIL
  https://phabricator.kde.org/D10434

AFFECTED FILES
  applets/binary-clock/package/contents/config/main.xml
  applets/binary-clock/package/contents/ui/BinaryClock.qml
  applets/binary-clock/package/contents/ui/DotColumn.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11131: [plasmashell] Set Qt::AA_UseHighDpiPixmaps

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:70f8f197c79a: [plasmashell] Set Qt::AA_UseHighDpiPixmaps 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11131?vs=28940=28944

REVISION DETAIL
  https://phabricator.kde.org/D11131

AFFECTED FILES
  shell/main.cpp

To: broulik, #plasma, davidedmundson, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11131: [plasmashell] Set Qt::AA_UseHighDpiPixmaps

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We currently do not support Qt scaling in plasmashell but in case we do, 
don't forget this.

TEST PLAN
  Ran plasmashell with `PLASMA_USE_QT_SCALING=true` and now get crisp context 
menu icons
  
  Shouldn't have any effect on IconItem etc

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11131

AFFECTED FILES
  shell/main.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10434: Allow users to change the format to BCD (decimal) in Binary Clock widget

[Piotr Kąkol]

piotrkakol added a comment.


  I was instructed to give my contact details that will be included in the 
commit message.
  Piotr Kąkol piotrka...@pm.me

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10434

To: piotrkakol, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  @graesslin , @davidedmundson , please approve this once again, this was 
updated numerous times after initial review

REPOSITORY
  R108 KWin

BRANCH
  gbm-vnc

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, 
plasma-devel, schernikov, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

[Oleg Chernovskiy]

Kanedias added a comment.


  @graesslin , @davidedmundson , please approve this once again, this was 
updated numerous times after initial review

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, 
plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11126: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists

[Friedrich W . H . Kossebau]

kossebau added a comment.


  I am slightly confused though as for me kded still seems to load the kded 
module anyway, as the current code in kded only checks the platform on 
preloading, but not later. Is that really on purpose?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11126

To: kossebau, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11126: [touchpad kded] Work around kded fail on X-KDE-OnlyShowOnQtPlatforms lists

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: mart.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  kded currently fails to handle list values set for X-KDE-OnlyShowOnQtPlatforms
  and will read the whole value as one string "xcb;" including the semicolon.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fixOnlyShowOnQtPlatforms

REVISION DETAIL
  https://phabricator.kde.org/D11126

AFFECTED FILES
  kcms/touchpad/src/kded/kded_touchpad.desktop

To: kossebau, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D8827: experimental support for auto mnemonics

[Marco Martin]

mart updated this revision to Diff 28926.
mart added a comment.


  - Merge branch 'master' into arcpatch-D8827
  - better shortcut management for MenuItem

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8827?vs=22409=28926

BRANCH
  arcpatch-D8827

REVISION DETAIL
  https://phabricator.kde.org/D8827

AFFECTED FILES
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/ToolButton.qml
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h

To: mart, #plasma
Cc: hein, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi added a comment.


  In D10297#220548 , @rkflx wrote:
  
  > In D10297#220547 , @gregormi 
wrote:
  >
  > > Some people from Plasma reviewed the original review request on 
reviewboard. Should we add some more reviewers before it can go in?
  >
  >
  > Only looked at it briefly, but I did not spot something about KSysGuard 
(the multi-page app), it was all about "System Monitor" (the single page 
dialog) so far. Anyway, I'm not the maintainer, I only added a comment about 
something I noticed.
  
  
  I think the reviewers are aware that the menu will also be part of KSysGuard, 
which is a good thing. I added Thomas from the original review request and 
Friedrich as one from the recent commit history as additional reviewers.
  
  So the final question to be decided is: "For KSysGuard: is it odd that the 
new tools menu only appears in the System Table tab?" I would follow Nate's 
assessment https://phabricator.kde.org/D10297#207235 here and say no and 
regarding all circumstances it is a good solution.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Takao Fujiwara]

fujiwara updated this revision to Diff 28920.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11061?vs=28881=28920

REVISION DETAIL
  https://phabricator.kde.org/D11061

AFFECTED FILES
  applets/kimpanel/backend/ibus/ibus15/panel.cpp

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[Henrik Fehlauer]

rkflx added a comment.


  In D7087#220623 , @gregormi wrote:
  
  > By the way, on Netrunner's Plasma the About System dialog looks like this: 
http://i1-news.softpedia-static.com/images/news2/netrunner-desktop-16-09-avalon-linux-os-is-out-with-kernel-4-7-kde-plasma-5-7-510007-3.jpg:
 it adds Graphics and Network information.
  
  
  Not only that, also "KDE Apps Version", just like I suggested. I guess it's 
open source, so try to find the patch or convince them to upstream it ;)
  
  > **And how **to go forward with this particular patch: If there are no 
objections I will proceed with Dominik's label suggestion as it is "simple, 
easy to understand and extend, and all the copy-to-clipboard code is in one 
place" and it looks good to solve the i18n issue.
  
  Sounds like a plan.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi added a comment.


  In D7087#207306 , @rkflx wrote:
  
  > In D7087#207286 , @dhaumann wrote:
  >
  > > In fact, I wonder whether there already is a script or similar helper 
tools that give you this kind of system information. I currently do not 
remember, though... Anyone else?
  >
  >
  > Do you mean `inxi -Fxxxz`? Surely that's material for a different patch, 
but might be a nice idea to integrate. It's more hardware related, though, less 
about software versions.
  >
  > I guess for a useful https://bugs.kde.org report the only thing missing is 
the KDE Applications version and some info about the graphics card + driver.
  
  
  Oh, that's a nice tool. Having that in the menu would help not to forget its 
existence.
  
  In D7087#220251 , @rkflx wrote:
  
  > In D7087#207286 , @dhaumann wrote:
  >
  > > In fact, I wonder whether there already is a script or similar helper 
tools that give you this kind of system information. I currently do not 
remember, though... Anyone else?
  >
  >
  > Try #2: Did you mean this?:
  >
  >   qdbus org.kde.KWin /KWin supportInformation
  
  
  This output contains much KWin specific information. But why not.
  
  By the way, on Netrunner's Plasma the About System dialog looks like this: 
http://i1-news.softpedia-static.com/images/news2/netrunner-desktop-16-09-avalon-linux-os-is-out-with-kernel-4-7-kde-plasma-5-7-510007-3.jpg:
 it adds Graphics and Network information.
  
  **And how **to go forward with this particular patch: If there are no 
objections I will proceed with Dominik's label suggestion as it is "simple, 
easy to understand and extend, and all the copy-to-clipboard code is in one 
place" and it looks good to solve the i18n issue.

INLINE COMMENTS

> dhaumann wrote in Module.cpp:256
> Nitpicking: Why do you declare the clipboard here, when you use it only 10 
> lines later? :-) Better would be:
> 
>   QGuiApplication::clipboard()->setText(text);
> 
> So just one line at the end.

Good question :). I'll fix that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Henrik Fehlauer]

rkflx added a comment.


  In D10297#220547 , @gregormi wrote:
  
  > Some people from Plasma reviewed the original review request on 
reviewboard. Should we add some more reviewers before it can go in?
  
  
  Only looked at it briefly, but I did not spot something about KSysGuard (the 
multi-page app), it was all about "System Monitor" (the single page dialog) so 
far. Anyway, I'm not the maintainer, I only added a comment about something I 
noticed.
  
  As for adding more reviewers: I guess someone from #plasma 
 has to approve it in the end, and 
maybe look at the code again because the original review is quite old by now. 
Perhaps it's best to tag individual reviewers (from your old review, or from 
recent Git history).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Fwd: Re: kwin display issue on librem5

[Marco Martin]

On martedì 6 marzo 2018 17:47:39 CET Martin Flöser wrote:
> > also note that kwayland is part of KDE frameworks, so hopefully at
> > least
> > kwayland patch will be included in Next month's KDE Frameworks 5.45
> > release.
> 
> Given that this seems to fix a severe bug, we could consider to backport
> it to 5.12 with a conditional building if frameworks 5.45 is found. It's
> something we haven't done so far, but given that we face the issue of
+1

-- 
Marco Martin

D10297: Add new "Tools" button above System Monitor's process list

[gregormi]

gregormi added a comment.


  In D10297#207127 , @rkflx wrote:
  
  > Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button 
is fine (annoyingly with a slightly larger height than the combobox, but that's 
life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on 
this tab page? I could imagine the menubar would be a better place.
  >
  > (Sorry this comes so late, I only reviewed in more detail because nobody 
from Plasma bothered so far. Ignore my comment if you want.)
  
  
  Some people from Plasma reviewed the original review request on reviewboard. 
Should we add some more reviewers before it can go in?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:04dc4c9d2217: [mediacontroller applet] Use media playback 
status icons (authored by romangg).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11056?vs=28906=28907

REVISION DETAIL
  https://phabricator.kde.org/D11056

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: romangg, #plasma, andreask, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg updated this revision to Diff 28906.
romangg added a comment.


  - Also change tooltip icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11056?vs=28902=28906

BRANCH
  mediaAppletStatusIcon

REVISION DETAIL
  https://phabricator.kde.org/D11056

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: romangg, #plasma, andreask, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Kai Uwe Broulik]

broulik added a comment.


  Can you please also update the tooltip

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStatusIcon

REVISION DETAIL
  https://phabricator.kde.org/D11056

To: romangg, #plasma, andreask, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11056: [mediacontroller applet] Use media playback status icons

[Roman Gilg]

romangg updated this revision to Diff 28902.
romangg added a comment.


  Rebase on master

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11056?vs=28713=28902

BRANCH
  mediaAppletStatusIcon

REVISION DETAIL
  https://phabricator.kde.org/D11056

AFFECTED FILES
  applets/mediacontroller/contents/ui/main.qml

To: romangg, #plasma, andreask
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

[Xuetian Weng]

xuetianweng added inline comments.

INLINE COMMENTS

> panel.cpp:922
> +impanel_update_engines(impanel, var_engines);
> +if (var_engines)
> +g_variant_unref(var_engines);

https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces

Always use braces

> panel.cpp:933
> +impanel_update_triggers(impanel, var_triggers);
> +if (var_triggers)
> +g_variant_unref(var_triggers);

Same as above

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11061

To: fujiwara, #plasma, hein, xuetianweng
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg updated this revision to Diff 28892.
romangg added a comment.


  - Minor changes proposed by Kai

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11063?vs=28889=28892

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma, andreask, broulik
Cc: ngraham, abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

Phabricator Notification Mails

[Ben Cooksley]

Hi all,

It has been brought to my attention that some find that they are
receiving too much mail or other notifications from Phabricator. For
those who are unaware there are numerous options available within
Phabricator to allow you to control how much it notifies you of
changes.

To customise the notices you receive, open your account settings
(available from the dropdown menu beside your avatar in the top
menubar, or at https://phabricator.kde.org/settings/) and select the
"Email Preferences" section.

You can choose to receive email, just receive an in-Phabricator
notification, or receive nothing at all for the various categories
provided there.

In the case of mailing lists, Sysadmin also has the option of
customising these for the list itself as well. Should people wish to
have this changed please bring it up on the list itself then file a
ticket once a consensus has been reached. Unfortunately Community
Admins do not have the ability to change these settings.

If you are receiving duplicate email for a project (because you are
also subscribed to it's mailing list) then Phabricator also allows you
to disable this by opening the Project, browsing to Members and
selecting the "Disable Mail" option.

If a large number of people find themselves needing to use the
"Disable Mail" option then we may need to reconsider how we are
currently setting up Herald rules (currently we subscribe the Project
and rely on the mailing list being a member of the Project to send
mail to the list - this also has the added benefit of looping the list
in on changes to tasks without needing an additional Herald rule).

Cheers,
Ben

D11063: [mediacontroller applet] Reorder elements

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Go go go :)

INLINE COMMENTS

> ExpandedRepresentation.qml:174
>  
> -ColumnLayout {
> -Layout.fillWidth: true
> -spacing: units.smallSpacing / 2
> -
> -PlasmaExtras.Heading {
> -id: song
> -Layout.fillWidth: true
> -level: 3
> -opacity: 0.6
> -
> -maximumLineCount: 3
> -wrapMode: Text.WrapAtWordBoundaryOrAnywhere
> -elide: Text.ElideRight
> -text: root.track ? root.track : i18n("No media playing")
> -textFormat: Text.PlainText
> -}
> +PlasmaCore.IconItem {
> +anchors {

`usesPlasmaTheme: false`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

To: romangg, #plasma, andreask, broulik
Cc: ngraham, abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d511a766779b: [mediacontroller applet] Reorder elements 
(authored by romangg).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11063?vs=28892=28895

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma, andreask, broulik
Cc: ngraham, abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 28893.
zzag added a comment.


  take scaling factor into account

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11069?vs=28874=28893

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11069

AFFECTED FILES
  cmake/FindFFTW.cmake
  kdecoration/CMakeLists.txt
  kdecoration/breezeboxshadowhelper.cpp
  kdecoration/breezeboxshadowhelper.h
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecoration.h
  kdecoration/breezesettingsdata.kcfg

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11109: [Notifications] Remove NoAccessNetworkAccessManagerFactory

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  With shared QML engine this would affect all applets and since we properly 
escape HTML in notifications now this is unneccessary.

TEST PLAN
  5.12 branch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11109

AFFECTED FILES
  applets/notifications/plugin/notificationshelperplugin.cpp
  applets/notifications/plugin/notificationshelperplugin.h

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11063: [mediacontroller applet] Reorder elements

[Roman Gilg]

romangg updated this revision to Diff 28889.
romangg added a comment.


  Rebased on master

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11063?vs=28816=28889

BRANCH
  mediaAppletStructure

REVISION DETAIL
  https://phabricator.kde.org/D11063

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: romangg, #plasma, andreask
Cc: ngraham, abetts, nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11065: [Active Window Control] Slightly fix vertical alignment of window name

[Radek Hušek]

Pitel updated this revision to Diff 28886.
Pitel added a comment.


  Moving appmenu instead of window title.

REPOSITORY
  R884 Active Window Control Applet for Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11065?vs=28738=28886

BRANCH
  realign

REVISION DETAIL
  https://phabricator.kde.org/D11065

AFFECTED FILES
  package/contents/ui/AppMenu.qml

To: Pitel, #plasma, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart