D12330: Consistently use KQuickControls.ColorButton in the config UI

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:135f0f9dd179: Consistently use KQuickControls.ColorButton 
in the config UI (authored by kossebau).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12330?vs=32516=32518

REVISION DETAIL
  https://phabricator.kde.org/D12330

AFFECTED FILES
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: kossebau, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12330: Consistently use KQuickControls.ColorButton in the config UI

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  usekquickcolorbutton

REVISION DETAIL
  https://phabricator.kde.org/D12330

AFFECTED FILES
  wallpapers/color/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  In D12311#249270 , @sharvey wrote:
  
  > F5812033: Screenshot_20180418_161500.png 

  >  The good news is that it still behaves properly with a scaled display.
  >
  > The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!
  
  
  Ouch, that's pretty bad. Perhaps we should move the button up higher in the 
window so you'll always be able to reach it no matter what weird state you find 
yourself in.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812033: Screenshot_20180418_161500.png 

  The good news is that it still behaves properly with a scaled display.
  
  The bad news is that, due to the `minimumSize` we configured for System 
Settings, I can't get back to the bottom of the Display KCM to reset my screen 
scale. Had to set `QT_SCALE_FACTOR=0.5` and launch `systemsettings5` directly. 
Never a dull moment!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a comment.


  I think it would be worth it! It's definitely not a crown jewel of polished 
UI design, that's for sure.
  
  To test scaling, try setting a systemwide scale factor in System Settings > 
Display and Monitor > Displays > Scale Display, then logging out and back in, 
then doing it again,

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Scott Harvey]

sharvey added a comment.


  F5812014: Screenshot_20180418_155156.png 

  The dialog seems immune to QT_SCALE_FACTOR=2.0 (because it's launched from a 
separate process?). I don't have a HiDPI display to test on.
  
  I tried different fonts up to 15pt and all is okay. I even tried the nasty 
Windows-style widgets and it's still okay.
  
  I agree the layout is kind of a mess. I can take a shot at reworking it if 
the reviewers think it's worth the effort.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Nathaniel Graham]

ngraham added a comment.


  From  localization perspective, this seems important given that some 
languages generally yield longer strings than others (we get a lot of Bugzilla 
tickets on this). Also, romance languages tend to put the differentiating part 
of the string on the end rather than the beginning.
  
  From a usability perspective, showing all the text (within reason) seems more 
important than rigidly sticking to a single preferred size. Function > form 
(within reason, again).
  
  So +1 from me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: ngraham, davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[David Edmundson]

davidedmundson added a comment.


  It's looking a trillion times better than the early screenshots.
  
  Some feedback from a quick test:
  
  - close icon in the "add" popup doesn't have a mouseover effect so it looks a 
bit weird
  - I have no languages installed and that makes the popup look really weird

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  + pushed a revert commit. Thanks!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein reopened this revision.
hein added a comment.


  Reopen for review.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  Arf, no, sorry. I forgot over a week's worth of vacation that I had this on 
the same branch as something else.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D12313: Consistently use text "Configure..." for applet configure buttons

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:47feb15029da: Consistently use text 
Configure... for applet configure buttons (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12313?vs=32482=32515

REVISION DETAIL
  https://phabricator.kde.org/D12313

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/mediaframe/package/contents/ui/main.qml

To: kossebau, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Albert Astals Cid]

aacid added a comment.


  In D12171#248840 , @hein wrote:
  
  > Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.
  
  
  Andy said +1 5 days ago.
  
  BTW have you tried it? It tries very hard not to change the menu width at 
all, so as David says most probably you won't even notice it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12318: Consistently use KQuickControls.ColorButton in the config UI

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f3ad84f91946: Consistently use KQuickControls.ColorButton 
in the config UI (authored by kossebau).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12318?vs=32505=32514

REVISION DETAIL
  https://phabricator.kde.org/D12318

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  wallpapers/potd/contents/ui/config.qml

To: kossebau, #plasma, #vdg, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[David Edmundson]

davidedmundson added a comment.


  > This revision was not accepted when it landed; it landed in state Changes 
Planned.Wed, Apr 18, 8:54 PM
  
  Was this intentionally merged?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Kai Uwe Broulik]

broulik added a comment.


  I think there's something severly wrong with the dialog's size hints if we 
need to add arbitrary numbers all over the place. Can you make sure this 
doesn't break with
  
  - different font
  - larger font
  - screen scaling
  - different widget style
  - ...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: broulik, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12313: Consistently use text "Configure..." for applet configure buttons

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Can we fix `configurationNeeded` in the desktop/panel containment, please? :P

REPOSITORY
  R114 Plasma Addons

BRANCH
  consistentConfigurebuttontext

REVISION DETAIL
  https://phabricator.kde.org/D12313

To: kossebau, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12314: expose the wallpaper config to the lockscreen

[Kai Uwe Broulik]

broulik added a comment.


  Hmm I think it would make for a nicer API to expose `wallpaperPluginName` and 
`wallpaperConfiguration` directly? I find doing `wallpaper.something` and 
`wallpaperIntegration.pluginName` a bit awkward, but fine with me.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D12314

To: mart, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12324: Sort top-level entries as well when sorting is enabled

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7d2674da2103: Sort top-level entries as well when sorting 
is enabled (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12324?vs=32503=32510

REVISION DETAIL
  https://phabricator.kde.org/D12324

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

To: hein, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Eike Hein]

This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5e6353d2824f: Port Language KCM to Qt Quick (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=31923=32509

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D12318: Consistently use KQuickControls.ColorButton in the config UI

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  So much red!

REPOSITORY
  R114 Plasma Addons

BRANCH
  useconsistentcolorbutton

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 32505.
kossebau added a comment.


  also update potd wallpaper with KQuickControls.ColorButton

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12318?vs=32502=32505

BRANCH
  useconsistentcolorbutton

REVISION DETAIL
  https://phabricator.kde.org/D12318

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml
  wallpapers/potd/contents/ui/config.qml

To: kossebau, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau added a comment.


  In D12318#249050 , @davidedmundson 
wrote:
  
  > There's ColorButton  
(https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside 
kquickcontrols
  >
  > Can't we use that?
  
  
  Ah, I had only grepped for ColorDialog and before also only seen that custom 
code in the image wallpaper config. From quick testing that one works as well, 
and is used in Fifteenpuzzle config UI.
  Though not anywhere else. Leaves me slightly puzzled why nothing else has 
used it before and instead did own creations?
  
  With KQuickControls.ColorButton:
  F5811924: Screenshot_20180418_205933.png 

  
  F5811928: Screenshot_20180418_205912.png 

  
  F5811925: Screenshot_20180418_210015.png 

  
  Would do similar patches for image wallpaper & similar as well if this one is 
okayed.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12324: Sort top-level entries as well when sorting is enabled

[Eike Hein]

hein created this revision.
hein added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
hein requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12324

AFFECTED FILES
  applets/kicker/plugin/appsmodel.cpp

To: hein, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 32502.
kossebau added a comment.


  use KQuickControls.ColorButton

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12318?vs=32491=32502

BRANCH
  useconsistentcolorbutton

REVISION DETAIL
  https://phabricator.kde.org/D12318

AFFECTED FILES
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml
  applets/systemloadviewer/package/contents/ui/ColorSettings.qml

To: kossebau, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text; reduce overall size of dialog

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.
ngraham accepted this revision.
ngraham added a comment.


  Much better! I'd still prefer less whitespace, but this is already an 
improvement. But now that I'm staring at this dialog over and over again, I'm 
wondering if we even need the non-bold caption text at all. It just repeats the 
bold text in a slightly more awkward and more wordy fashion. What do you think?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts, #frameworks
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12323: Read theme.conf of themes

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> davidedmundson wrote in themeconfig.cpp:169
> nice solution
> 
> "NoGlobals" - Cascade to system settings, but omit user's globals.
> 
> should work better. It will include the added sources, but no more

https://cgit.kde.org/kconfig.git/tree/src/core/kconfig.h#n97 says that it's the 
same value, isn't it?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12323

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12323: Read theme.conf of themes

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  1 minor change.

INLINE COMMENTS

> themeconfig.cpp:169
>  if (configFile.exists()) {
> -KSharedConfigPtr themeConfig = 
> KSharedConfig::openConfig(configFile.fileName() + ".user", 
> KConfig::SimpleConfig);
> +KSharedConfigPtr themeConfig = 
> KSharedConfig::openConfig(configFile.fileName() + ".user", 
> KConfig::CascadeConfig);
> +themeConfig->addConfigSources({configFile.fileName()});

nice solution

"NoGlobals" - Cascade to system settings, but omit user's globals.

should work better. It will include the added sources, but no more

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12323

To: fvogt, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11928: fade to blur when the login box appears

[Vlad Zagorodniy]

zzag added a comment.


  In D11928#240658 , @ngraham wrote:
  
  > F5791756: Spectacle.wS4100.png 
  
  
  It looks like there are "blur artifacts/contours"... How about adding 
Gaussian noise? It can help to break the "contours".

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/newlockscreen

REVISION DETAIL
  https://phabricator.kde.org/D11928

To: mart, #plasma, #vdg, ngraham
Cc: zzag, abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[David Edmundson]

davidedmundson added a comment.


  There's ColorButton  
(https://api.kde.org/frameworks/kdeclarative/html/classColorButton.html) inside 
kquickcontrols
  
  Can't we use that?

INLINE COMMENTS

> kossebau wrote in ColorPicker.qml:34
> Open question to developers:
> how expensive is it to have an instance of ColorDialog per button, instead of 
> sharing one over all buttons?
> 
> That's where the code for both ColorButtons here is yet to be aligned.

It's open source, you can see what Qt Dialogs does internally.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12323: Read theme.conf of themes

[Fabian Vogt]

fvogt added a comment.


  (Actually targeting the Plasma/5.12 branch)

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D12323

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12323: Read theme.conf of themes

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Otherwise kcm_sddm ignores values in there. Previously, a theme with a default
  background image reverts to a color background on save.

TEST PLAN
  Ran kcm_sddm and saved without changes. The background type is still image.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12323

AFFECTED FILES
  src/themeconfig.cpp

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey updated this revision to Diff 32498.
sharvey added a comment.


  - Correct initial Y placement for `errorMessageWidget`

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32496=32498

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  Here's the latest from the Pixel Conservation Society. I can't manage 
wholesale space-savings without breaking up the existing `gridLayout` and 
basically starting from scratch. It does resize a bit and does no harm.
  
  F5811876: Screenshot_20180418_130139.png 

  
  F5811879: Screenshot_20180418_130149.png 

  
  F5811882: Screenshot_20180418_130257.png 

  
  F5811884: Screenshot_20180418_130307.png 


REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey updated this revision to Diff 32496.
sharvey added a comment.


  - Reduce height of dialog by shrinking UI elements when not needed
  
  Password error alert and user-choice combo box are reduced to 1px high when 
not needed, then restored to their original geometry when activated.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12311?vs=32476=32496

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.ui

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  Here's what I can come up with. I can't accomplish major resizing without 
breaking up the existing UI layout grid(s) and starting from scratch. But I 
managed to save a few pixels where I could.
  
  F5811860: Screenshot_20180418_123909.png 
 F5811862: Screenshot_20180418_123920.png 
 F5811864: Screenshot_20180418_124324.png 


REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Nathaniel Graham]

ngraham added a comment.


  +1!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ColorPicker.qml:34
> +
> +QtDialogs.ColorDialog {
> +id: colorDialog

Open question to developers:
how expensive is it to have an instance of ColorDialog per button, instead of 
sharing one over all buttons?

That's where the code for both ColorButtons here is yet to be aligned.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Before:
  F5811833: Screenshot_20180418_191455.png 

  F5811834: Screenshot_20180418_191409.png 

  After:
  F5811837: Screenshot_20180418_191620.png 

  F5811838: Screenshot_20180418_191647.png 

  For comparison code which got copied from:
  F5811842: Screenshot_20180418_191719.png 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12318

To: kossebau, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12318: Use consistent color button components for color config UI elements

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  For a consistent UX use the same component code for config UI elements
  showing a currently selected color and allowing to trigger a color picker to
  select another color.
  
  Ideally in the future we can have a ready-to-use component in PlasmaExtras.

TEST PLAN
  All buttons adapt to color changes as well as trigger the color dialog if
  activated.

REPOSITORY
  R114 Plasma Addons

BRANCH
  useconsistentcolorbutton

REVISION DETAIL
  https://phabricator.kde.org/D12318

AFFECTED FILES
  applets/binary-clock/package/contents/ui/ColorButton.qml
  applets/binary-clock/package/contents/ui/configGeneral.qml
  applets/systemloadviewer/package/contents/ui/ColorPicker.qml

To: kossebau, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Nathaniel Graham]

ngraham added a comment.


  In D12311#248878 , @sharvey wrote:
  
  > It's got a Big Scary Red Box that appears for an error. It's already in the 
UI design, just not visible. So when it's set to visible, its space is already 
allocated.
  >
  > F5811776: Screenshot_20180418_110242.png 

  >
  > There's another hidden UI element above it, which is a combo box for 
selecting a different user. I've only got one user on my system, but i presume 
it activates when superuser privileges are requested, allowing you to enter the 
root password as a different user.
  
  
  Right. What I'm saying is: can we make the box compact by default, and become 
taller to accommodate the above-mentioned UI elements only when they're 
actually being displayed?
  
  BTW, creating another user and then removing it later is trivially easy in 
System Settings > Account Details > User Manager.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11928: fade to blur when the login box appears

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> WallpaperFader.qml:4
> +
> +Copyright (C) 2014 Aleix Pol Gonzalez 
> +

C?

> LockScreenUi.qml:76
> +property bool uiVisible: false
> +property bool blockUI: mainStack.depth > 1 || 
> mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive || 
> wallpaperIntegration.pluginName == "org.kde.color"
> +Text {

Is there any more generic solution possible?

> LockScreenUi.qml:77
> +property bool blockUI: mainStack.depth > 1 || 
> mainBlock.mainPasswordBox.text.length > 0 || inputPanel.keyboardActive || 
> wallpaperIntegration.pluginName == "org.kde.color"
> +Text {
> +text: wallpaperIntegration.pluginName

is this debug?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/newlockscreen

REVISION DETAIL
  https://phabricator.kde.org/D11928

To: mart, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12314: expose the wallpaper config to the lockscreen

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  the lockscreen can change behavior based on the wallpaer (D11928 
)

TEST PLAN
  wallpaper pluginmame is accessible to the greeter qml

REPOSITORY
  R133 KScreenLocker

BRANCH
  phab/exposeplugin

REVISION DETAIL
  https://phabricator.kde.org/D12314

AFFECTED FILES
  greeter/greeterapp.cpp

To: mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11928: fade to blue when the login box appears

[Marco Martin]

mart updated this revision to Diff 32483.
mart added a comment.


  - use the state machine for the effect
  - shorter animations
  - just blur and darken the background
  - whitespaces fixes
  - add precisions to make it work on GLES
  - bigger clock
  - move the wallpaperfader in a different component
  - more things moved out of the wallpaperfader component
  - same fader to sddm-theme
  - don't fade out with color wallpaper

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11928?vs=31410=32483

BRANCH
  mart/newlockscreen

REVISION DETAIL
  https://phabricator.kde.org/D11928

AFFECTED FILES
  lookandfeel/contents/components/Clock.qml
  lookandfeel/contents/components/SessionManagementScreen.qml
  lookandfeel/contents/components/WallpaperFader.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml

To: mart, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12313: Consistently use text "Configure..." for applet configure buttons

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Another applet which has such a button is the weather applet (master-only), 
which already uses this string.
  
  There is some inconsistency though still: one button shows an icon, while the 
other two do not. This is due to QQC2 button not supporting an icon next to a 
text on a Button control. Ignore for now, or simply remove icon everywhere?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12313

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12313: Consistently use text "Configure..." for applet configure buttons

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Applets which need initial configuration display some centered button
  to noth indicate the status as well as help the user to quickly get
  to the configuration page.
  
  Having consistent text on those buttons improves UX.

REPOSITORY
  R114 Plasma Addons

BRANCH
  consistentConfigurebuttontext

REVISION DETAIL
  https://phabricator.kde.org/D12313

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/mediaframe/package/contents/ui/main.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  In D12311#248852 , @ngraham wrote:
  
  > Better already! Do we even need to reserve that space? Many other such 
dialogs dynamically allocate it when necessary by increasing the height of the 
box. Is that not possible here?
  
  
  It's got a Big Scary Red Box that appears for an error. It's already in the 
UI design, just not visible. So when it's set to visible, its space is already 
allocated.
  
  F5811776: Screenshot_20180418_110242.png 

  
  There's another hidden UI element above it, which is a combo box for 
selecting a different user. I've only got one user on my system, but i presume 
it activates when superuser privileges are requested, allowing you to enter the 
root password as a different user.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:b43a463230d0: [mediaframe applet] Enable wrapping of fill 
mode description in config UI (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12307?vs=32466=32480#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12307?vs=32466=32480

REVISION DETAIL
  https://phabricator.kde.org/D12307

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: kossebau, #plasma, aspotashev
Cc: aspotashev, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

[Alexander Potashev]

aspotashev accepted this revision.
aspotashev added a comment.
This revision is now accepted and ready to land.


  Should be good if it doesn't crash.

REPOSITORY
  R114 Plasma Addons

BRANCH
  wrapfillmodedescription

REVISION DETAIL
  https://phabricator.kde.org/D12307

To: kossebau, #plasma, aspotashev
Cc: aspotashev, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Nathaniel Graham]

ngraham added a comment.


  Better already! Do we even need to reserve that space? Many other such 
dialogs dynamically allocate it when necessary by increasing the height of the 
box. Is that not possible here?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  F5811737: Screenshot_20180418_100622.png 

  How's this? It's a little tighter.
  
  Some of the white space is reserved for otherwise-invisible error messages 
(like an invalid password).
  
  If it gets more +1's, I'll update.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham, abetts
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Nathaniel Graham]

ngraham added a comment.


  +1 for much much less whitespace.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[David Edmundson]

davidedmundson added a comment.


  > Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.
  
  Worth noting that they only expand *if* they go above the current size which 
hasn't changed, so for me and most people after this patch it'll look exactly 
the same as it does now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: davidedmundson, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

[Eike Hein]

hein added a comment.


  Personally I sort of, well, hate this and it was a very conscious design 
decision to make the menu widths uniform, so I'd like some more VDG opinions to 
convince me otherwise first.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12171

To: aacid, #plasma, hein
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  I just realized I inadvertently shrank the spacing between the bold headline 
and the non-bold explanation text. There's a lot of white space in this dialog. 
Let me know if you want something adjusted...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  F5811717: Screenshot_20180416_124725.png 

  
  Before
  --
  
  F5811719: Screenshot_20180418_092904.png 

  After

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12102: Port Language KCM to Qt Quick

[Marco Martin]

mart added a comment.


  on kirigami master the swipelistitem should look more desktopy

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey added a comment.


  In D12311#248824 , @davidedmundson 
wrote:
  
  > Probably fine, but can you attach a screenshot
  
  
  You're too quick on the draw. Was still editing the summary!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey, davidedmundson, ngraham
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12091: HIG entry for On-demand pattern and swipe list item

[Marco Martin]

mart added a comment.


  this may be an example screenshot for kirigami
  F5811714: image.png 

REPOSITORY
  R985 KDE Human Interface Guidelines

REVISION DETAIL
  https://phabricator.kde.org/D12091

To: fabianr, colomar, mart, #kirigami
Cc: plasma-devel, ngraham, IlyaBizyaev, mvourlakos, romangg, hpereiradacosta, 
apol, davidedmundson, mart, hein, kamathraghavendra

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein added a comment.


  In D12102#244758 , @abetts wrote:
  
  > Would it be hard to include a checkbox to the left of each list item that 
shows a selection when tapped?
  
  
  Sorry, can you explain which of the two lists and what "shows a selection 
when tapped" means exactly? :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12102

To: hein, #kirigami, mart
Cc: safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, davidedmundson, mart, hein

D12311: Align lock icon with bold message text

[David Edmundson]

davidedmundson added a comment.


  Probably fine, but can you attach a screenshot

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12311

To: sharvey
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12311: Align lock icon with bold message text

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Adjusted spacers in UI file to properly align icon with message text

TEST PLAN
  - Compile polkit-kde-agent-1 with patch
- Trigger a root password request window (launch Synaptic, try to change 
SDDM in System Settings)
- Ensure that lock icon is aligned with bold headline text

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  align-lock-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12311

AFFECTED FILES
  AuthDialog.ui

To: sharvey
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10660: [Weather applet] Let Return invoke search

[Friedrich W . H . Kossebau]

kossebau added a comment.


  I would like to consider discarding this patch and the related introduction 
of the "acceptOnReturnPressed" property to Plasma config page concept only 
needed for this so far.
  
  I am currently drafting to rework the UI of the weather station page in the 
dialog, to add support for multiple stations (following request to match 
feature of the old yawp widget).
  
  And instead of having the current embedded weather station picker, whose 
interaction pattern has been reported to be confusing at least to some, go to 
follow the pattern as we know it from e.g. the file picker, where another 
separate subdialog is opened for just that purpose of selecting an item.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D10660

To: broulik, #plasma, kossebau
Cc: mart, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Target: Plasma/5.12 branch
  
  I wonder if that mode description text should be there at all, given it is 
inconsistent with other places in Plasma config UI, which do not have such a 
separate info text item for the selection of the fill mode/positioning (e.g. 
image wallpaper config). But given there is enough space in the config page, 
and someone added it for some reason, let's for now ensure the full text is 
readable.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12307

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12307: [mediaframe applet] Enable wrapping of fill mode description in config UI

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Especially with some translations the text will not fit on a single line.
  
  BUG: 393232

REPOSITORY
  R114 Plasma Addons

BRANCH
  wrapfillmodedescription

REVISION DETAIL
  https://phabricator.kde.org/D12307

AFFECTED FILES
  applets/mediaframe/package/contents/ui/ConfigGeneral.qml

To: kossebau, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

[Aleix Pol]

Yes, we were having the same issue for android. Just landed a fix.

Aleix

On Wed, Apr 18, 2018 at 1:16 PM, Ben Cooksley  wrote:

> Can someone please look into this and detail why we now have a new
> dependency here?
>
> A speedy resolution to this is required as Frameworks build failures can
> lead to rapid maintainability issues for the CI system.
>
> Cheers,
> Ben
>
> On Tue, Apr 17, 2018 at 11:55 PM, CI System  wrote:
>
>> *BUILD FAILURE*
>> Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%
>> 20WindowsMSVCQt5.10/60/
>> Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
>> Date of build: Tue, 17 Apr 2018 11:54:53 +
>> Build duration: 36 sec and counting
>> * CONSOLE OUTPUT *
>> [...truncated 49.71 KB...]
>> JOB_URL = 'https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%
>> 20WindowsMSVCQt5.10/'
>> LIB = 'C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\ATLMFC\lib\x64;C:\Program
>> Files (x86)\Microsoft Visual Studio\2017\Professional\VC\To
>> ols\MSVC\14.13.26128\lib\x64;C:\Program Files (x86)\Windows
>> Kits\10\lib\10.0.16299.0\ucrt\x64;C:\Program Files (x86)\Windows
>> Kits\10\lib\10.0.16299.0\um\x64;'
>> LIBPATH = 'C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\ATLMFC\lib\x64;C:\Program
>> Files (x86)\Microsoft Visual Studio\2017\Professional\VC\To
>> ols\MSVC\14.13.26128\lib\x64;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\lib\x86\store\references;C:\Program
>> Files (x86)\Windows Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files
>> (x86)\Windows Kits\10\References\10.0.16299.
>> 0;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;'
>> LOCALAPPDATA = 'C:\Users\Jenkins\AppData\Local'
>> NODE_LABELS = 'Windows Builder 1 WindowsMSVCQt5.10'
>> NODE_NAME = 'Windows Builder 1'
>> NUMBER_OF_PROCESSORS = '12'
>> OS = 'Windows_NT'
>> PATH = 'C:\Craft\CI\windows-msvc2017_64-cl-debug\bin;C:\Craft\CI\wi
>> ndows-msvc2017_64-cl-debug\lib;C:\Craft\CI\windows-msvc2017_
>> 64-cl-debug\dev-utils\bin;C:\Craft\CI\windows-msvc2017_64-
>> cl-debug\dev-utils\lib;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\bin\HostX64\x64;C:\Program
>> Files (x86)\Microsoft Visual Studio\2017\Professional\Commo
>> n7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program
>> Files (x86)\Microsoft Visual Studio\2017\Professional\Commo
>> n7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team
>> Explorer;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\MSBuild\15.0\bin\Roslyn;C:\Program Files
>> (x86)\Microsoft Visual Studio\2017\Professional\Team Tools\Performance
>> Tools\x64;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\Team Tools\Performance Tools;C:\Program Files
>> (x86)\Microsoft Visual 
>> Studio\Shared\Common\VSPerfCollectionTools\\x64;C:\Program
>> Files (x86)\Microsoft Visual 
>> Studio\Shared\Common\VSPerfCollectionTools\;C:\Program
>> Files (x86)\HTML Help Workshop;C:\Program Files (x86)\Windows
>> Kits\10\bin\10.0.16299.0\x64;C:\Program Files (x86)\Windows
>> Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\\MSBuild\15.0\bin;C:\Windows\Micros
>> oft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual
>> Studio\2017\Professional\Common7\IDE\;C:\Program Files (x86)\Microsoft
>> Visual Studio\2017\Professional\Common7\Tools\;C:\Program
>> Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramD
>> ata\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:
>> \WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program
>> Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'
>> PATHEXT = '.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.PY;.
>> PYW'
>> PLATFORM = 'x64'
>> PROCESSOR_ARCHITECTURE = 'AMD64'
>> PROCESSOR_IDENTIFIER = 'Intel64 Family 6 Model 61 Stepping 2,
>> GenuineIntel'
>> PROCESSOR_LEVEL = '6'
>> PROCESSOR_REVISION = '3d02'
>> PROGRAMDATA = 'C:\ProgramData'
>> PROGRAMFILES = 'C:\Program Files'
>> PROGRAMFILES(X86) = 'C:\Program Files (x86)'
>> PROGRAMW6432 = 'C:\Program Files'
>> PROMPT = '$P$G'
>> PSMODULEPATH = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'
>> PUBLIC = 'C:\Users\Public'
>> RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/Fra
>> meworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/60/display
>> /redirect?page=changes'
>> RUN_DISPLAY_URL = 'https://build.kde.org/job/Fra
>> meworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/60/display/redirect'
>> STAGE_NAME = 'Configuring Build'
>> SYSTEMDRIVE = 'C:'
>> SYSTEMROOT = 'C:\WINDOWS'
>> TEMP = 'C:\Users\Jenkins\AppData\Local\Temp'
>> TMP = 'C:\Users\Jenkins\AppData\Local\Temp'
>> UCRTVERSION = '10.0.16299.0'
>> UNIVERSALCRTSDKDIR = 'C:\Program Files (x86)\Windows 

D12305: Fix build on Android

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d9a956de53ed: Fix build on Android (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12305?vs=32460=32461

REVISION DETAIL
  https://phabricator.kde.org/D12305

AFFECTED FILES
  src/libkirigami/CMakeLists.txt
  src/libkirigami/tabletmodewatcher.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

[Ben Cooksley]

Can someone please look into this and detail why we now have a new
dependency here?

A speedy resolution to this is required as Frameworks build failures can
lead to rapid maintainability issues for the CI system.

Cheers,
Ben

On Tue, Apr 17, 2018 at 11:55 PM, CI System  wrote:

> *BUILD FAILURE*
> Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-
> qt5%20WindowsMSVCQt5.10/60/
> Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10
> Date of build: Tue, 17 Apr 2018 11:54:53 +
> Build duration: 36 sec and counting
> * CONSOLE OUTPUT *
> [...truncated 49.71 KB...]
> JOB_URL = 'https://build.kde.org/job/Frameworks%20kirigami%20kf5-
> qt5%20WindowsMSVCQt5.10/'
> LIB = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\
> Tools\MSVC\14.13.26128\ATLMFC\lib\x64;C:\Program Files (x86)\Microsoft
> Visual Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\lib\x64;C:\Program
> Files (x86)\Windows Kits\10\lib\10.0.16299.0\ucrt\x64;C:\Program Files
> (x86)\Windows Kits\10\lib\10.0.16299.0\um\x64;'
> LIBPATH = 'C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\ATLMFC\lib\x64;C:\Program
> Files (x86)\Microsoft Visual Studio\2017\Professional\VC\
> Tools\MSVC\14.13.26128\lib\x64;C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\lib\
> x86\store\references;C:\Program Files (x86)\Windows
> Kits\10\UnionMetadata\10.0.16299.0;C:\Program Files (x86)\Windows
> Kits\10\References\10.0.16299.0;C:\Windows\Microsoft.NET\
> Framework64\v4.0.30319;'
> LOCALAPPDATA = 'C:\Users\Jenkins\AppData\Local'
> NODE_LABELS = 'Windows Builder 1 WindowsMSVCQt5.10'
> NODE_NAME = 'Windows Builder 1'
> NUMBER_OF_PROCESSORS = '12'
> OS = 'Windows_NT'
> PATH = 'C:\Craft\CI\windows-msvc2017_64-cl-debug\bin;C:\Craft\CI\
> windows-msvc2017_64-cl-debug\lib;C:\Craft\CI\windows-
> msvc2017_64-cl-debug\dev-utils\bin;C:\Craft\CI\windows-
> msvc2017_64-cl-debug\dev-utils\lib;C:\Program Files (x86)\Microsoft
> Visual 
> Studio\2017\Professional\VC\Tools\MSVC\14.13.26128\bin\HostX64\x64;C:\Program
> Files (x86)\Microsoft Visual Studio\2017\Professional\
> Common7\IDE\VC\VCPackages;C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\Common7\IDE\CommonExtensions\
> Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team
> Explorer;C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\
> MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\Team Tools\Performance Tools\x64;C:\Program Files
> (x86)\Microsoft Visual Studio\2017\Professional\Team Tools\Performance
> Tools;C:\Program Files (x86)\Microsoft Visual Studio\Shared\Common\
> VSPerfCollectionTools\\x64;C:\Program Files (x86)\Microsoft Visual
> Studio\Shared\Common\VSPerfCollectionTools\;C:\Program Files (x86)\HTML
> Help Workshop;C:\Program Files (x86)\Windows 
> Kits\10\bin\10.0.16299.0\x64;C:\Program
> Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\\MSBuild\15.0\bin;C:\Windows\
> Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft
> Visual Studio\2017\Professional\Common7\IDE\;C:\Program Files
> (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\;C:\Program
> Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\
> ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;
> C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\
> System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\Users\
> Jenkins\AppData\Local\Microsoft\WindowsApps'
> PATHEXT = '.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.PY;.PYW'
> PLATFORM = 'x64'
> PROCESSOR_ARCHITECTURE = 'AMD64'
> PROCESSOR_IDENTIFIER = 'Intel64 Family 6 Model 61 Stepping 2, GenuineIntel'
> PROCESSOR_LEVEL = '6'
> PROCESSOR_REVISION = '3d02'
> PROGRAMDATA = 'C:\ProgramData'
> PROGRAMFILES = 'C:\Program Files'
> PROGRAMFILES(X86) = 'C:\Program Files (x86)'
> PROGRAMW6432 = 'C:\Program Files'
> PROMPT = '$P$G'
> PSMODULEPATH = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'
> PUBLIC = 'C:\Users\Public'
> RUN_CHANGES_DISPLAY_URL = 'https://build.kde.org/job/
> Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/60/
> display/redirect?page=changes'
> RUN_DISPLAY_URL = 'https://build.kde.org/job/Frameworks%20kirigami%20kf5-
> qt5%20WindowsMSVCQt5.10/60/display/redirect'
> STAGE_NAME = 'Configuring Build'
> SYSTEMDRIVE = 'C:'
> SYSTEMROOT = 'C:\WINDOWS'
> TEMP = 'C:\Users\Jenkins\AppData\Local\Temp'
> TMP = 'C:\Users\Jenkins\AppData\Local\Temp'
> UCRTVERSION = '10.0.16299.0'
> UNIVERSALCRTSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'
> USERDOMAIN = 'DESKTOP-66R8QOQ'
> USERNAME = 'Jenkins'
> USERPROFILE = 'C:\Users\Jenkins'
> VCIDEINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual
> Studio\2017\Professional\Common7\IDE\VC\'
> VCINSTALLDIR = 'C:\Program Files 

D12305: Fix build on Android

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Kirigami was half-depending on dbus and it wouldn't build

TEST PLAN
  Built it for Android

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12305

AFFECTED FILES
  src/libkirigami/CMakeLists.txt
  src/libkirigami/tabletmodewatcher.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein