[protobuf] Re: Issue 531 in protobuf: Cannot build protobuf using VS2013

2015-03-18 Thread protobuf


Comment #14 on issue 531 by st.ere...@gmail.com: Cannot build protobuf  
using VS2013

https://code.google.com/p/protobuf/issues/detail?id=531

Same problem as #12

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 694 in protobuf: module machine type 'x64' conflicts with target machine type 'X86'

2015-03-18 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 694 by va...@pushstrength.com: module machine type 'x64'  
conflicts with target machine type 'X86'

https://code.google.com/p/protobuf/issues/detail?id=694

What steps will reproduce the problem?
1. Create a project on x64 platform that exploits gtest
2. Compile
3. Error shows up

What is the expected output? What do you see instead?
module machine type 'x64' conflicts with target machine type 'X86'

What version of the product are you using? On what operating system?


Please provide any additional information below.

I have a project on Win32 platform. I followed all the steps on VS 2013 to  
move it to x64 platform as follows:


Build - Configuration Manager - Active Solution Platform - New - Copy  
from Win32

Build - Configuration Manager - Platform - x64 (for all the projects)
Project - Properties - Configuration Properties - VC++ Directories -  
Library Directories -  
$(VCInstallDir)\bin\x86_amd64;$(VCInstallDir)\bin.;$(WindowsSdkDir)lib\x64

Build - Build Solution
If I don't select x64 for my unit tests, the solution builds like a charm!  
The problem is when I select to have the unit tests in x64 format as well.  
The problem should be from the google protobuf side but I don't know how to  
resolve it.


Does anyone have any clue?
Thanks

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 692 in protobuf: Function headers for has_ accessors within oneof are put as private for enum/string/int32/bool

2015-03-12 Thread protobuf


Comment #2 on issue 692 by alfred...@gmail.com: Function headers for has_  
accessors within oneof are put as private for enum/string/int32/bool

https://code.google.com/p/protobuf/issues/detail?id=692

This bug should be about how containing_oneof wasn't check in  
src/google/protobuf/compiler/cpp/cpp_message.cc. My comments can be read in  
https://github.com/google/protobuf/commit/6ef984af4b0c63c1c33127a12dcfc8e6359f0c9e#commitcomment-10125327


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 689 in protobuf: Repeated fields do not serialize the 'size' into the file. Hence deserialize of repeated expects an unending sequence of repeated fields

2015-03-11 Thread protobuf


Comment #4 on issue 689 by narayan@gmail.com: Repeated fields do not  
serialize the 'size' into the file. Hence deserialize of repeated expects  
an unending sequence of repeated fields

https://code.google.com/p/protobuf/issues/detail?id=689

Looks likeit.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 689 in protobuf: Repeated fields do not serialize the 'size' into the file. Hence deserialize of repeated expects an unending sequence of repeated fields

2015-03-11 Thread protobuf


Comment #3 on issue 689 by dwah...@gmail.com: Repeated fields do not  
serialize the 'size' into the file. Hence deserialize of repeated expects  
an unending sequence of repeated fields

https://code.google.com/p/protobuf/issues/detail?id=689

It sounds like you're looking for the Message.writeDelimitedTo and  
Message.parseDelimitedFrom functions. Those are available in Java, but not  
in C++ (see issue 472).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 472 in protobuf: C++ Versions of ParseDelimitedFrom writeDelimitedTo

2015-03-11 Thread protobuf


Comment #2 on issue 472 by narayan@gmail.com: C++ Versions of  
ParseDelimitedFrom  writeDelimitedTo

https://code.google.com/p/protobuf/issues/detail?id=472

Well, WriteVarint32 may not be sufficient since size_t is actually 64 bit  
in modern computers, though in practice, it is least likely that we write  
Messages larger than (2^31 - 1) bytes.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 689 in protobuf: Repeated fields do not serialize the 'size' into the file. Hence deserialize of repeated expects an unending sequence of repeated fields

2015-03-10 Thread protobuf

Updates:
Status: WorkingAsIntended
Owner: xiaof...@google.com

Comment #1 on issue 689 by xiaof...@google.com: Repeated fields do not  
serialize the 'size' into the file. Hence deserialize of repeated expects  
an unending sequence of repeated fields

https://code.google.com/p/protobuf/issues/detail?id=689

This is by design. Protobuf fields are serialized as tag, value pairs.  
The parsing routine will check the tag to decide whether a value belongs to  
a repeated field and act accordingly. There could be a potentially infinite  
number of such tag, value pairs in an input stream, but in practice, the  
size of a message is usually already known before parsing. For example,  
when you send a protobuf message over the wire, you'll first send the size  
of the data before serialized bytes of the message.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 693 in protobuf: clan scan-build analysis of generated protobuf code produces warnings.

2015-03-10 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 693 by gahan.ro...@gmail.com: clan scan-build analysis of  
generated protobuf code produces warnings.

https://code.google.com/p/protobuf/issues/detail?id=693

What steps will reproduce the problem?
1. generate some c++ code with protobuf
2. use clang scan-build to analyse generated code.

What is the expected output? What do you see instead?
Expect to see no issues.
clang scan-build reports issues.

What version of the product are you using? On what operating system?
protobuf 2.4.1
RHEL6 linux.

Please provide any additional information below.

errors like the following are seen:


  AA71ParameterPayload_descriptor_ = file-message_type(0);
^
   warning: Called C++ object pointer is null


./aa71fw.pb.cc:1061:69: warning: Returning null reference
  if (default_instance_ == NULL) protobuf_AddDesc_aa71fw_2eproto();  return  
*default_instance_;
 
^

./aa71fw.pb.cc:1379:69: warning: Returning null reference
  if (default_instance_ == NULL) protobuf_AddDesc_aa71fw_2eproto();  return  
*default_instance_;
 
^


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 613 in protobuf: protoc: Add options to redirect input / output to files.

2015-03-10 Thread protobuf


Comment #1 on issue 613 by vap...@chromium.org: protoc: Add options to  
redirect input / output to files.

https://code.google.com/p/protobuf/issues/detail?id=613

https://github.com/google/protobuf/pull/235

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2015-03-09 Thread protobuf


Comment #17 on issue 447 by xiaof...@google.com: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

Feel free to create a github issue for this as we don't have a plan for  
automated migration of issues.


From our point of view, adding move constructors is not such a clear win.  
It has its costs. It will increase generated code size which will lead to a  
larger binary. For some Google binaries where protos contribute to half of  
the binary size, the size increase might be significant. More generated  
code also means longer compilation time. For the benefit of move  
constructors, we have already done some experiments which show no sign of  
performance improvements after adding move constructors. It's probably  
because our existing code is already highly optimized to avoid unnecessary  
copies. It's hard to find a piece of performance crucial code that can be  
improved with move constructors. To decide whether to add move  
constructors, the authority wants to see: data showing the impact of the  
generated code size change, and examples showing how the new API can  
improve the clarity of our existing code.  I guess there is not much a  
non-googler could help here.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 82 in protobuf: Add JSON serialization support

2015-03-07 Thread protobuf


Comment #15 on issue 82 by dengc...@gmail.com: Add JSON serialization  
support

https://code.google.com/p/protobuf/issues/detail?id=82

How about this: http://pastebin.com/0pZ5ESqu

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 691 in protobuf: Make procedure not able to finish on Ubuntu 14.10

2015-02-24 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 691 by kr...@163.com: Make procedure not able to finish on Ubuntu  
14.10

https://code.google.com/p/protobuf/issues/detail?id=691

What steps will reproduce the problem?
1.downlaod protobuf-2.5.0.tar.gz
2.use tar -xzf protobuf-2.5.0.tar.gz to extract all files
3.use ./configure to do the configuration
4.run command make

What is the expected output? What do you see instead?
The make process should have ended, but it run and run without stopping.

What version of the product are you using? On what operating system?
version: protobuf-2.5.0.tar.gz
operating system: Ubuntu 14.10 64bit

Please provide any additional information below.

I attached a log file as a output by using the command make  Error.txt
Such log come out repeatedly:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall  
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -O2 -g -DNDEBUG -MT  
cpp_message_field.lo -MD -MP -MF .deps/cpp_message_field.Tpo -c  
google/protobuf/compiler/cpp/cpp_message_field.cc -o cpp_message_field.o  

/dev/null 21

mv -f .deps/cpp_message_field.Tpo .deps/cpp_message_field.Plo
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I.  
-I..-pthread -Wall -Wwrite-strings -Woverloaded-virtual  
-Wno-sign-compare -O2 -g -DNDEBUG -MT cpp_primitive_field.lo -MD -MP  
-MF .deps/cpp_primitive_field.Tpo -c -o cpp_primitive_field.lo `test  
-f 'google/protobuf/compiler/cpp/cpp_primitive_field.cc' ||  
echo './'`google/protobuf/compiler/cpp/cpp_primitive_field.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -pthread -Wall  
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -O2 -g -DNDEBUG -MT  
cpp_primitive_field.lo -MD -MP -MF .deps/cpp_primitive_field.Tpo -c  
google/protobuf/compiler/cpp/cpp_primitive_field.cc  -fPIC -DPIC  
-o .libs/cpp_primitive_field.o

In file included from ./google/protobuf/compiler/cpp/cpp_field.h:41:0,
  
from ./google/protobuf/compiler/cpp/cpp_primitive_field.h:40,
 from  
google/protobuf/compiler/cpp/cpp_primitive_field.cc:35:
./google/protobuf/stubs/strutil.h: In function 'google::protobuf::int64  
google::protobuf::strto64(const char*, char**, int)':
./google/protobuf/stubs/strutil.h:319:25: warning:  
typedef 'sizeof_int64_is_not_sizeof_long_long' locally defined but not used  
[-Wunused-local-typedefs]

 sizeof_int64_is_not_sizeof_long_long);
 ^
./google/protobuf/stubs/common.h:382:11: note: in definition of  
macro 'GOOGLE_COMPILE_ASSERT'

   msg[bool(expr) ? 1 : -1]
   ^
I have no idea why the make procedure always repeats without stopping.
Please help me to find out the solution.
Thanks a lot!

Attachments:
Error.txt  80.1 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 691 in protobuf: Make procedure not able to finish on Ubuntu 14.10

2015-02-24 Thread protobuf


Comment #1 on issue 691 by kr...@163.com: Make procedure not able to finish  
on Ubuntu 14.10

https://code.google.com/p/protobuf/issues/detail?id=691

I am sorry that I've made a mistake.
After a long time waiting, make command finished successfully.
And all 'make check' passed.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2015-02-24 Thread protobuf


Comment #16 on issue 447 by benjamin...@gmail.com: No C++11 move  
constructors

https://code.google.com/p/protobuf/issues/detail?id=447

Now that protobuf is hosted on github: https://github.com/google/protobuf

Should we manually move this ticket to a github issue? Or is there a plan  
to do an automated migration of issues?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2015-02-23 Thread protobuf


Comment #15 on issue 447 by t...@ripple.com: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

This *is* unfortunate.

In particular, whomever the gatekeeper is for this isn't actually telling  
us why they aren't convinced - so how can we respond?  It seems like a  
clear win for anyone using C++11, and if we knew the exact objections, we  
could see if they were valid.  As it is, it's simple an argument by  
authority.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 119 in protobuf: TYPE_BOOL collides with MacOS macro

2015-02-21 Thread protobuf


Comment #11 on issue 119 by daen...@gmail.com: TYPE_BOOL collides with  
MacOS macro

https://code.google.com/p/protobuf/issues/detail?id=119

Is this bug just abandoned? It's still broken.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 690 in protobuf: protoc can produce cpp code that fails to compile due to naming clash on generated classes

2015-02-20 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 690 by btkenn...@gmail.com: protoc can produce cpp code that  
fails to compile due to naming clash on generated classes

https://code.google.com/p/protobuf/issues/detail?id=690

What steps will reproduce the problem?
1. download / build protobuf 2.6.1
2. cd to src dir, run protoc to generate cpp code for testcase.proto  
(./protoc --cpp_out=. testcase.proto)

3. compile with g++ (g++ -I. -c testcase.pb.cc)
4. see errors due to naming clash

What is the expected output? What do you see instead?
I'd expect protoc to fail with a sensible error rather than having GCC  
produce a large amount of relatively incomprehensible error messages.


What version of the product are you using? On what operating system?
Using protobuf-2.6.1 built on ubuntu 12.04 with gcc 4.6

Attachments:
testcase.proto  93 bytes

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 493 in protobuf: protobuf-java (2.5.0) GeneratedMessage#getUnknownFields() not implemented

2015-02-19 Thread protobuf


Comment #21 on issue 493 by verun.ka...@gmail.com: protobuf-java (2.5.0)  
GeneratedMessage#getUnknownFields() not implemented

https://code.google.com/p/protobuf/issues/detail?id=493

Sorry to re-surrect this, but we've run into this exact same issue when  
trying to move to the CDH5 distribution of Hadoop, which is using Protobuf  
2.5.0, while our code base is still using Protobuf 2.4.1.


I'd like to find out if the submitted patch is complete or if there are  
others places where patches need be applied...


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 689 in protobuf: Repeated fields do not serialize the 'size' into the file. Hence deserialize of repeated expects an unending sequence of repeated fields

2015-02-17 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 689 by narayan@gmail.com: Repeated fields do not serialize  
the 'size' into the file. Hence deserialize of repeated expects an unending  
sequence of repeated fields

https://code.google.com/p/protobuf/issues/detail?id=689

What steps will reproduce the problem?
1. Create a MyStudent.proto with below contents
   ---
  1 option optimize_for=SPEED;
  2
  3 package My;
  4
  5 message Course {
  6 required string courseName = 1;
  7 required int32 courseMarks = 2;
  8 };
  9
 10 message Student {
 11 required string rollNo  = 1;
 12 required string studentName = 2;
 13 repeated Course Courses = 3;
 14 };
 15
 16 enum RequestType {
 17 ReadStudentRequest_e   = 0;
 18 WriteStudentRequest_e  = 1;
 19 DeleteStudentRequest_e = 3;
 20 SetMarksRequest_e  = 4;
 21 GetMarksRequest_e  = 5;
 22 DeleteMarksRequest_e   = 6;
 23 };
 24
 25 enum ResponseType {
 26 RequestSuccessful_e = 0;
 27 RequestFailed_e = 1;
 28 };
 29
 30 message Request
 31 {
 32 required RequestType requestType = 1; // The request type
 33 optional Student student = 2; // For the use of  
WriteStudentRequest_e
 34 optional string rollNo   = 3; // For the use of  
ReadStudentRequest_e, DeleteStudentRequest_e,
 35   // 
SetMarksRequest_e, GetMarksRequest_e, DeleteMarksRequest_e
 36 optional string courseName   = 4; // For the use of  
GetMarksRequest_e, SetMarksRequest_e, DeleteMarksRequest_e
 37 optional int32 courseMarks   = 5; // For the use of  
SetMarksRequest_e

 38 };
 39
 40 message Response
 41 {
 42 required RequestType requestType   = 1; // The request type
 43 required ResponseType responseType = 2; // The response type
 44 optional string responseString = 3; // The response type
 45 optional Student student   = 4; // For the use of  
ReadStudentRequest_e
 46 optional string rollNo = 5; // For the use of  
WriteStudentRequest_e, DeleteStudentRequest_e,
 47 // 
SetMarksRequest_e, GetMarksRequest_e, DeleteMarksRequest_e
 48 optional string courseName = 6; // For the use of  
GetMarksRequest_e, SetMarksRequest_e, DeleteMarksRequest_e
 49 optional int32 courseMarks = 7; // For the use of  
GetMarksRequest_e

 50 };
   ---

2. Compile it:
   ---
   $ protoc --cpp_out=$PWD Student.proto
   ---

3. In the file MyStudent.pb.cc, what we see is:
   ---
...
 686 ::google::protobuf::uint8* Student::SerializeWithCachedSizesToArray(
 687 ::google::protobuf::uint8* target) const {
 688   // required string rollNo = 1;
 689   if (has_rollno()) {
 690 ::google::protobuf::internal::WireFormat::VerifyUTF8String(
 691   this-rollno().data(), this-rollno().length(),
 692   ::google::protobuf::internal::WireFormat::SERIALIZE);
 693 target =
 694   ::google::protobuf::internal::WireFormatLite::WriteStringToArray(
 695 1, this-rollno(), target);
 696   }
 697
 698   // required string studentName = 2;
 699   if (has_studentname()) {
 700 ::google::protobuf::internal::WireFormat::VerifyUTF8String(
 701   this-studentname().data(), this-studentname().length(),
 702   ::google::protobuf::internal::WireFormat::SERIALIZE);
 703 target =
 704   ::google::protobuf::internal::WireFormatLite::WriteStringToArray(
 705 2, this-studentname(), target);
 706   }
 707
 708   // repeated .My.Course Courses = 3;
 709   for (int i = 0; i  this-courses_size(); i++) {
 710 target = ::google::protobuf::internal::WireFormatLite::
 711   WriteMessageNoVirtualToArray(
 712 3, this-courses(i), target);
 713   }
 714
 715   if (!unknown_fields().empty()) {
 716 target  
= ::google::protobuf::internal::WireFormat::SerializeUnknownFieldsToArray(

 717 unknown_fields(), target);
 718   }
 719   return target;
 720 }
...
   ---

What is the expected output? What do you see instead?
---
Notice that in line 708 of the above code-snippet from MyStudent.pb.cc, we  
see that it writes only contents, but does not write the 'size' before  
writing the contents. This makes subsequent 'parse' unsafe since it will  
read infinite number of repeated elements (till end of file / array).

---

What version of the product are you using? On what operating system?
---
I am using the protobuf-devel version that comes with Fedora 21. Here

[protobuf] Re: Issue 119 in protobuf: TYPE_BOOL collides with MacOS macro

2015-02-12 Thread protobuf


Comment #10 on issue 119 by l0gicsub...@gmail.com: TYPE_BOOL collides with  
MacOS macro

https://code.google.com/p/protobuf/issues/detail?id=119

Will this issue be fixed somewhen? It's really disappointing.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 688 in protobuf: de

2015-02-06 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 688 by rich.h.d...@gmail.com: de
https://code.google.com/p/protobuf/issues/detail?id=688

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 687 in protobuf: ..

2015-02-04 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 687 by leandro@gmail.com: ..
https://code.google.com/p/protobuf/issues/detail?id=687

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 687 in protobuf: ..

2015-02-04 Thread protobuf

Updates:
Status: Invalid

Comment #1 on issue 687 by liuj...@google.com: ..
https://code.google.com/p/protobuf/issues/detail?id=687

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 526 in protobuf: Protocol compiler doesn't issue an meaningful error message when two custom options use the same extension field number.

2015-02-03 Thread protobuf


Comment #6 on issue 526 by j...@squareup.com: Protocol compiler doesn't  
issue an meaningful error message when two custom options use the same  
extension field number.

https://code.google.com/p/protobuf/issues/detail?id=526

Any update on this issue?  It seems to be still a problem (I just ran into  
it using 2.6.1).


Jason

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 686 in protobuf: Protoc does not provide a dependency manifest output file for build tools like make

2015-01-22 Thread protobuf


Comment #1 on issue 686 by haberl...@gmail.com: Protoc does not provide a  
dependency manifest output file for build tools like make

https://code.google.com/p/protobuf/issues/detail?id=686

this is what we're using - maybe can be built upon:

https://github.com/machinekit/machinekit/blob/master/src/machinetalk/proto/scripts/protoc-gen-depends




--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2015-01-22 Thread protobuf


Comment #14 on issue 447 by mend...@gmail.com: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

So a move constructor (eventually marked as noexcept) is not a peformance  
gain? Right!


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 686 in protobuf: Protoc does not provide a dependency manifest output file for build tools like make

2015-01-22 Thread protobuf

Updates:
Status: WontFix
Owner: xiaof...@google.com

Comment #2 on issue 686 by xiaof...@google.com: Protoc does not provide a  
dependency manifest output file for build tools like make

https://code.google.com/p/protobuf/issues/detail?id=686

Hi, could you help file this issue on github? We have moved to github not  
very long ago: https://github.com/google/protobuf


If you have a patch to add this feature to protoc, feel free to send us the  
patch in a pull request.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 686 in protobuf: Protoc does not provide a dependency manifest output file for build tools like make

2015-01-21 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 686 by richardg...@gmail.com: Protoc does not provide a  
dependency manifest output file for build tools like make

https://code.google.com/p/protobuf/issues/detail?id=686

Protobuf files can have import statements and include directories, so the  
full dependency tree is not known by the build system before executing  
protoc. This makes it hard for the build system to know when to schedule  
any given protoc command.
Make  other build systems can use a dependency file to trigger a rebuild  
when a dependency changes. GCC and other compilers expose this with the -MF  
flag, which outputs a file in the format


output_filename: input_file \
 input_file2 \
 input_file3
...

Protobuf knows the transitive set of input files, but doesn't expose this  
information in this format.


Patch to follow.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 685 in protobuf: java.lang.VerifyError: class RealtimeBidding$BidRequest overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

2015-01-11 Thread protobuf


Comment #4 on issue 685 by tryb...@gmail.com: java.lang.VerifyError: class  
RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

https://code.google.com/p/protobuf/issues/detail?id=685

Ticket can be closed.

Look for solution here  
https://github.com/trybeee/clojure-protobuf-example/pull/1


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 685 in protobuf: java.lang.VerifyError: class RealtimeBidding$BidRequest overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

2015-01-10 Thread protobuf


Comment #3 on issue 685 by tryb...@gmail.com: java.lang.VerifyError: class  
RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

https://code.google.com/p/protobuf/issues/detail?id=685

Created example project to show the errors i get
https://github.com/trybeee/clojure-protobuf-example

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 685 in protobuf: java.lang.VerifyError: class RealtimeBidding$BidRequest overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

2015-01-09 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 685 by tryb...@gmail.com: java.lang.VerifyError: class  
RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

https://code.google.com/p/protobuf/issues/detail?id=685

Hi Guys,

What steps will reproduce the problem?
1. Download and install 2.5.0 from here  
https://github.com/google/protobuf/releases

(./configure  make  make install)
$ protoc --version
libprotoc 2.5.0
2.Generate .java file: protoc --java_out=src/java/  
resources/proto/realtime-bidding.proto --proto_path=resources/proto
3. lein run (it's actually clojure project and i  see  
com.google.protobuf/protobuf-java 2.5.0 on classpath)


I'm getting following error:

Exception in thread main java.lang.VerifyError: class  
RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet
Caused by: java.lang.VerifyError: class RealtimeBidding$BidRequest  
overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet;

at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:760)
at  
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)

at java.net.URLClassLoader.defineClass(URLClassLoader.java:455)
at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
at java.net.URLClassLoader$1.run(URLClassLoader.java:367)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:360)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)


I also saw that ticket  
https://code.google.com/p/protobuf/issues/detail?id=484 but it didn't help.
RealtimeBidding.java is here  
https://gist.github.com/trybeee/6699dfd4dcc47b954432


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 685 in protobuf: java.lang.VerifyError: class RealtimeBidding$BidRequest overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

2015-01-09 Thread protobuf


Comment #1 on issue 685 by xiaof...@google.com: java.lang.VerifyError:  
class RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

https://code.google.com/p/protobuf/issues/detail?id=685

We don't have 2.5.0 on the github release page (the oldest there is 2.6.0).  
Could you check the version number again?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 685 in protobuf: java.lang.VerifyError: class RealtimeBidding$BidRequest overrides final method getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

2015-01-09 Thread protobuf


Comment #2 on issue 685 by tryb...@gmail.com: java.lang.VerifyError: class  
RealtimeBidding$BidRequest overrides final method  
getUnknownFields.()Lcom/google/protobuf/UnknownFieldSet

https://code.google.com/p/protobuf/issues/detail?id=685

I'm getting the same error with 2.6.0

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 684 in protobuf: integer overflow

2015-01-07 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 684 by edgar@gmail.com: integer overflow
https://code.google.com/p/protobuf/issues/detail?id=684

What steps will reproduce the problem?
svn diff stringprintf_unittest.cc
Index: stringprintf_unittest.cc
===
--- stringprintf_unittest.cc(revision 608)
+++ stringprintf_unittest.cc(working copy)
@@ -147,6 +147,16 @@
   delete[] buf;
 }

+TEST(StringPrintfTest, HugeBuf) {
+  // Check that the a corner case buffer is handled correctly.
+  int n = std::numeric_limitsint::max() ;
+  char* buf = (char *) malloc(n);
+  memset(buf, 0x41, n);
+  string value = StringPrintf(%s, buf);
+  EXPECT_EQ(value, );
+  free(buf);
+}
+
 }  // anonymous namespace
 }  // namespace protobuf
 }  // namespace google


What is the expected output? What do you see instead?
make check
Relevant part of src/test-suite.log:
[ RUN ] StringPrintfTest.HugeBuf
unknown file: Failure
C++ exception with description std::bad_alloc thrown in the test body.
[ FAILED ] StringPrintfTest.HugeBuf (8632 ms)

What version of the product are you using? On what operating system?
2.6.0 on Ubuntu 14.04

Please provide any additional information below.
I believe this bug can lead to DoS attacks.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 270 in protobuf: Precompiled protoc binary for OS X

2015-01-07 Thread protobuf


Comment #11 on issue 270 by osu...@gmail.com: Precompiled protoc binary for  
OS X

https://code.google.com/p/protobuf/issues/detail?id=270

You could also try this:
https://github.com/os72/protoc-jar
https://github.com/os72/protoc-jar-maven-plugin

Either directly via java -jar ..., or extract the packaged OSX protoc  
from the JAR



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 670 in protobuf: Not Able to compile protobuf for mips platform

2014-12-28 Thread protobuf


Comment #7 on issue 670 by osu...@gmail.com: Not Able to compile protobuf  
for mips platform

https://code.google.com/p/protobuf/issues/detail?id=670

Note that protobuf 2.4.1 seems to cross-compile fine to MIPS

2.5.0 and 2.6.1 both fail for me as well with the reported error

I used gcc 4.4 toolchain on debian, similar to instructions here:
https://moozing.wordpress.com/2011/04/05/cross-compile-in-debian/

And:
configure -host=mips --disable-shared CC=mips-linux-gnu-gcc  
CXX=mips-linux-gnu-g++



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 670 in protobuf: Not Able to compile protobuf for mips platform

2014-12-28 Thread protobuf


Comment #8 on issue 670 by osu...@gmail.com: Not Able to compile protobuf  
for mips platform

https://code.google.com/p/protobuf/issues/detail?id=670

After more digging it appears to build to MIPS32 (2.4.1, 2.5.0, 2.6.1):

./configure -host=mips32 CXX=mips-linux-gnu-g++ CXXFLAGS=-D__MIPSEL__  
-march=mips32 --disable-shared


After make:

file src/protoc
src/protoc: ELF 32-bit MSB executable, MIPS, MIPS32 version 1 (SYSV),  
dynamically linked (uses shared libs), for GNU/Linux 2.6.18,  
BuildID[sha1]=0x25cf7add05893f48e8c5bd2b256bd784d81045e4, with unknown  
capability 0x4100 = 0xf676e75, with unknown capability 0x1 =  
0x70401, not stripped



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 399 in protobuf: Add support for using batch files to wrap plugins on Windows

2014-12-18 Thread protobuf


Comment #3 on issue 399 by olli.s...@gmail.com: Add support for using batch  
files to wrap plugins on Windows

https://code.google.com/p/protobuf/issues/detail?id=399

This would also make the dart-protoc-plugin useable on windows...

https://github.com/dart-lang/dart-protoc-plugin

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 679 in protobuf: protobuf causes crash beacuse of mutex lock

2014-12-18 Thread protobuf


Comment #4 on issue 679 by jw...@dilect.us: protobuf causes crash beacuse  
of mutex lock

https://code.google.com/p/protobuf/issues/detail?id=679

I am also seeing this, also from VerifyUTF8StringFallback(). My code does  
not call google::protobuf::ShutdownProtobufLibrary().


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 683 in protobuf: Protocol buffers java

2014-12-18 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 683 by bisteni...@gmail.com: Protocol buffers java
https://code.google.com/p/protobuf/issues/detail?id=683

I have a .java class created by RestaurantBestLocationDTO.proto called  
RestaurantBestLocationDTOOuterClass so i make a api get call to my server
with content-type application/x-protobuf then i got a message but i can  
find the way to parse this message into a  
RestaurantBestLocationDTOOuterClass list


im doing something like this

ParserListRestaurantBestLocationDTOOuterClass parserData;
ListRestaurantBestLocationDTOOuterClass list =  
parserData.parseFrom(inputStream);


obviously it says that the error is nullpointer exception because  
parserData is null

but i cant get an Instance because is an Inferface

so can i do to get what i want?

i just need to parse the response and get the list

What is the expected output? What do you see instead?
I want to get a List of RestaurantBestLocationDTOOuterClass

What version of the product are you using? On what operating system?
protobuf 2.6.1

Please provide any additional information below.
...


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 682 in protobuf: Windows phone 8.1 problem

2014-12-11 Thread protobuf


Comment #2 on issue 682 by dobba...@gmail.com: Windows phone 8.1 problem
https://code.google.com/p/protobuf/issues/detail?id=682

Thank you! Here is link of issue in github:
https://github.com/google/protobuf/issues/132

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 682 in protobuf: Windows phone 8.1 problem

2014-12-10 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 682 by dobba...@gmail.com: Windows phone 8.1 problem
https://code.google.com/p/protobuf/issues/detail?id=682

I use protobuf in winrt app for Windows and windows phone.
I got this message when build for ARM: Host architecture was not detected  
as supported by protobuf

The device is Nokia Lumia 1020. My OS is Windows 8.1, Visual Studio 2013

When is build for x86(run on emulator) everything is fine.
What is the expected output? What do you see instead?

Thank's!


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 682 in protobuf: Windows phone 8.1 problem

2014-12-10 Thread protobuf

Updates:
Status: WontFix

Comment #1 on issue 682 by xiaof...@google.com: Windows phone 8.1 problem
https://code.google.com/p/protobuf/issues/detail?id=682

Hi dobballa, we moved to github not very long ago. Could you file this  
issue on our github site?

https://github.com/google/protobuf/issues

Also as we don't have such a testing environment as yours,  we'll need  
users' patch to fix this problem.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 556 in protobuf: Unable to cross-compile for i686-w64-mingw32 with Cygwin

2014-12-08 Thread protobuf

Updates:
Status: Fixed
Owner: xiaof...@google.com

Comment #4 on issue 556 by xiaof...@google.com: Unable to cross-compile for  
i686-w64-mingw32 with Cygwin

https://code.google.com/p/protobuf/issues/detail?id=556

For cross-compiling, you can specify an protoc binary using  
the --with-protoc flag. That is:

./configure --with-protoc=/path/to/cygwin/protoc --host=i686-w64-mingw32

BTW, why do you cross-compile for mingw32 with cygwin?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 556 in protobuf: Unable to cross-compile for i686-w64-mingw32 with Cygwin

2014-12-06 Thread protobuf


Comment #3 on issue 556 by bible.ma...@gmail.com: Unable to cross-compile  
for i686-w64-mingw32 with Cygwin

https://code.google.com/p/protobuf/issues/detail?id=556

Having the same issue. Did this get resolved?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 679 in protobuf: protobuf causes crash beacuse of mutex lock

2014-11-28 Thread protobuf


Comment #2 on issue 679 by islm.ya...@gmail.com: protobuf causes crash  
beacuse of mutex lock

https://code.google.com/p/protobuf/issues/detail?id=679

take care wher you call

google::protobuf::ShutdownProtobufLibrary()

also dont call it in worker process or worker thread!



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 679 in protobuf: protobuf causes crash beacuse of mutex lock

2014-11-28 Thread protobuf


Comment #3 on issue 679 by islm.ya...@gmail.com: protobuf causes crash  
beacuse of mutex lock

https://code.google.com/p/protobuf/issues/detail?id=679

take care where you call

google::protobuf::ShutdownProtobufLibrary()

also dont call it in worker process or worker thread!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 270 in protobuf: Precompiled protoc binary for OS X

2014-11-27 Thread protobuf


Comment #10 on issue 270 by forrest@gmail.com: Precompiled protoc  
binary for OS X

https://code.google.com/p/protobuf/issues/detail?id=270

Building protobuf 2.5.0 under Darwin (Mac OS X) was straight forward enough  
for me but getting it to build with the MATLAB extension was anything but  
easy. I didn't want to install Maven, yet another build system, we already  
have make, Ant, and Gradle, so I used Gradle to build it. The build  
downloads the source, configures it, and does the build. To get the MATLAB  
extension to build I had to patch some Makefiles which I probably didn't do  
a good job of but it is good enough. I've attached the Gradle build files  
and the Makefile patches I used. The reason I added this comment on this  
issue is because simplifying the Gradle build file, build.gradle, by  
removing the MATLAB support should be trivial. YMMV


Attachments:
protobuf-darwin-2.5.0.tgz  3.3 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 270 in protobuf: Precompiled protoc binary for OS X

2014-11-26 Thread protobuf


Comment #9 on issue 270 by erdem...@gmail.com: Precompiled protoc binary  
for OS X

https://code.google.com/p/protobuf/issues/detail?id=270

If you don't install Xcode and developer tools, you'll have to install the  
required dependencies on your own.


Just for future reference, your configure output should be on OS X Yosem.  
with version protobuf-2.6.0;



checking whether to enable maintainer-specific portions of Makefiles... yes
checking build system type... x86_64-apple-darwin14.0.0
checking host system type... x86_64-apple-darwin14.0.0
checking target system type... x86_64-apple-darwin14.0.0
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking C++ compiler flags.. use default: -O2  -g -DNDEBUG
checking whether __SUNPRO_CC is declared... no
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc...  
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld
checking if the linker  
(/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld)  
is GNU ld... no

checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm
checking the name lister (/usr/bin/nm) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 196608
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands +=... yes
checking how to convert x86_64-apple-darwin14.0.0 file names to  
x86_64-apple-darwin14.0.0 format... func_convert_file_noop
checking how to convert x86_64-apple-darwin14.0.0 file names to toolchain  
format... func_convert_file_noop
checking for  
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld  
option to reload object files... -r

checking for objdump... no
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @FILE support... no
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking for dsymutil... dsymutil
checking for nmedit... nmedit
checking for lipo... lipo
checking for otool... otool
checking for otool64... no
checking for -single_module linker flag... yes
checking for -exported_symbols_list linker flag... yes
checking for -force_load linker flag... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... yes
checking for gcc option to produce PIC... -fno-common -DPIC
checking if gcc PIC flag -fno-common -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker  
(/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld)  
supports shared libraries... yes

checking dynamic linker characteristics... darwin14.0.0 dyld
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build

[protobuf] Issue 681 in protobuf: ar

2014-11-25 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 681 by seymour@gmail.com: ar
https://code.google.com/p/protobuf/issues/detail?id=681

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 681 in protobuf: ar

2014-11-25 Thread protobuf

Updates:
Status: Invalid

Comment #1 on issue 681 by liuj...@google.com: ar
https://code.google.com/p/protobuf/issues/detail?id=681

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 270 in protobuf: Precompiled protoc binary for OS X

2014-11-25 Thread protobuf


Comment #8 on issue 270 by peter.on...@gmail.com: Precompiled protoc binary  
for OS X

https://code.google.com/p/protobuf/issues/detail?id=270

Well, if you trust third party binary here it is:  
http://blog.ondruska.com/2014/11/google-protocol-buffers-compiler-binary.html


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 512 in protobuf: Add support for atomic operations on powerpc architecture

2014-11-24 Thread protobuf


Comment #4 on issue 512 by rob.west...@gmail.com: Add support for atomic  
operations on powerpc architecture

https://code.google.com/p/protobuf/issues/detail?id=512

I pretty disappointed in the support for the PPC architecture.  WontFix?   
really.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 680 in protobuf: Python pickling depends on the path used during compilaton

2014-11-24 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 680 by dbertoui...@gmail.com: Python pickling depends on the path  
used during compilaton

https://code.google.com/p/protobuf/issues/detail?id=680

What steps will reproduce the problem?
1. Extract the test files
2. Run make in the root directory followed by python test.py. It should  
raise an exception.
3. Run make in the libs directory followed by python test.py. It should  
work fine.
4. Run make in the libs/pblib directory followed by python test.py. It  
should raise an exception.


What is the expected output? What do you see instead?

I would expect the test.py script to run without exception each time.

What version of the product are you using? On what operating system?

* protobuf 2.6.0
* py27-protobuf 2.6.0
* python 2.7.8
* FreeBSD 10.0

Please provide any additional information below.

The path used during compilation seems to be convertible to a valid import  
statement in the Python application using the protobuf. For example, if the  
protobuf is compiled with 'protoc --python_out=. obj.proto' then 'import  
obj_pb2' must be valid in the python application using it.



Attachments:
pb26-pickle-test.tar.gz  550 bytes

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 680 in protobuf: Python pickling depends on the path used during compilaton

2014-11-24 Thread protobuf


Comment #1 on issue 680 by xiaof...@google.com: Python pickling depends on  
the path used during compilaton

https://code.google.com/p/protobuf/issues/detail?id=680

Can you post the exception stack trace?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 680 in protobuf: Python pickling depends on the path used during compilaton

2014-11-24 Thread protobuf


Comment #2 on issue 680 by dbertoui...@gmail.com: Python pickling depends  
on the path used during compilaton

https://code.google.com/p/protobuf/issues/detail?id=680

In the first case (Step 2).

Traceback (most recent call last):
  File test.py, line 11, in module
cPickle.dumps(obj)
cPickle.PicklingError: Can't pickle class 'libs.pblib.obj_pb2.ObjectA':  
import of module libs.pblib.obj_pb2 failed


In the third case (Step 4)

Traceback (most recent call last):
  File test.py, line 11, in module
cPickle.dumps(obj)
cPickle.PicklingError: Can't pickle class 'obj_pb2.ObjectA': import of  
module obj_pb2 failed


I should also note that this seemed to be introduced in 2.6. No exceptions  
are raised when using 2.5.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 515 in protobuf: More intelligent enums

2014-11-18 Thread protobuf


Comment #9 on issue 515 by peterhan...@yahoo.com: More intelligent enums
https://code.google.com/p/protobuf/issues/detail?id=515

Wrapping enum with another message looks ugly to me, and only simple way  
for this so far would be adding prefix for it, like



enum CURRENCY {
   UNKNOWN = 0;
   NONE = 1;
   USD = 2;
  // etc...
}



Don't you mean that a workaround would be to add prefix like this:

enum CURRENCY {
  CURRENCY_UNKNOWN = 0;
  CURRENCY_NONE = 1;
  CURRENCY_USD = 2;
  // etc...
}

?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 464 in protobuf: Inefficient Java handling of repeated list of primitive types

2014-11-18 Thread protobuf


Comment #5 on issue 464 by ryan.fog...@gmail.com: Inefficient Java handling  
of repeated list of primitive types

https://code.google.com/p/protobuf/issues/detail?id=464

In case anyone is wondering. I just diffed GPB versions 1.6.0 and 1.6.1 and  
there is no significant changes that would trip up the patch file. I.e. the  
patch derived from TwoSigma's solution and posted Sep14 should work just  
fine for 2.6.1.




--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 512 in protobuf: Add support for atomic operations on powerpc architecture

2014-11-17 Thread protobuf


Comment #2 on issue 512 by austin.l...@gmail.com: Add support for atomic  
operations on powerpc architecture

https://code.google.com/p/protobuf/issues/detail?id=512

This still isn't fixed in the latest repo.  I ran across this bug report  
when debugging why my code wasn't working on powerpc.


OP: Can you send the pull request?  It would be awesome to get this fix  
checked in.  I can send it myself, but it seems a bit weird to send someone  
else' code...


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 512 in protobuf: Add support for atomic operations on powerpc architecture

2014-11-17 Thread protobuf


Comment #3 on issue 512 by oded.gab...@gmail.com: Add support for atomic  
operations on powerpc architecture

https://code.google.com/p/protobuf/issues/detail?id=512

Hi,
I'm no longer working on PowerPC processors, and I don't have the platform  
to test it.

So, please feel free to send my original patch.

Oded

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 679 in protobuf: protobuf causes crash beacuse of mutex lock

2014-11-12 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 679 by islm.ya...@gmail.com: protobuf causes crash beacuse of  
mutex lock

https://code.google.com/p/protobuf/issues/detail?id=679

What steps will reproduce the problem?
FreeBSD 10, it sometimes crashes on SerializeToOstream

ostringstream os(ios::out | ios::binary);
email.SerializeToOstream(os);

and creates a core of binary here is gdb output:

#0  0x004aa1a1 in google::protobuf::internal::Mutex::Lock ()
#1  0x004ab767 in google::protobuf::internal::MutexLock::MutexLock  
()

#2  0x004aa011 in google::protobuf::internal::LogMessage::Finish ()
#3  0x004aa0e9 in  
google::protobuf::internal::LogFinisher::operator= ()
#4  0x0054e623 in  
google::protobuf::internal::WireFormat::VerifyUTF8StringFallback ()
#5  0x0044b7a2 in  
google::protobuf::internal::WireFormat::VerifyUTF8String (
data=0x8071b5798 testtir asdas asda sda sdasdasd dadsad n  
asdasd\nBilgilerinize.\nSayg�lar�mla,\nSibel Kocaku� �ENG�N\nKalite  
ve �dari ��ler\nmailto:isim.soyi...@vizyonarge.com e:   
sibel.koca...@vizyonarge.com  |\nhttp:/..., size=836,  
op=google::protobuf::internal::WireFormat::SERIALIZE) at gthr-default.h:199
#6  0x00449007 in emails::Email::SerializeWithCachedSizesToArray  
(this=0x7ffed170, target=0x80702b0a2 word\  
xmlns:x=\urn:schemas-mic �$\a\b) at emailInput.pb.cc:43
#7  0x004ac1e7 in  
google::protobuf::MessageLite::SerializePartialToCodedStream ()
#8  0x004ac35d in  
google::protobuf::MessageLite::SerializeToCodedStream ()
#9  0x004ac39b in  
google::protobuf::MessageLite::SerializeToZeroCopyStream ()

#10 0x0053b2b0 in google::protobuf::Message::SerializeToOstream ()


What version of the product are you using? On what operating system?
protobuf 2.5.0

Please provide any additional information below.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 679 in protobuf: protobuf causes crash beacuse of mutex lock

2014-11-12 Thread protobuf


Comment #1 on issue 679 by islm.ya...@gmail.com: protobuf causes crash  
beacuse of mutex lock

https://code.google.com/p/protobuf/issues/detail?id=679

if i comment the line in common.cc on line 185

MutexLock lock(log_silencer_count_mutex);

everything looks well.



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 585 in protobuf: No support compile for Windows Phone 8

2014-11-12 Thread protobuf


Comment #5 on issue 585 by mengxi...@gmail.com: No support compile for  
Windows Phone 8

https://code.google.com/p/protobuf/issues/detail?id=585

many many errors...

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 678 in protobuf: HasExtension() called on a repeated field should cause a compile error (Protobuf 2.4.1)

2014-11-06 Thread protobuf

Updates:
	Summary: HasExtension() called on a repeated field should cause a compile  
error (Protobuf 2.4.1)

Owner: xiaof...@google.com

Comment #2 on issue 678 by xiaof...@google.com: HasExtension() called on a  
repeated field should cause a compile error (Protobuf 2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

HasExtension() is for optional fields and cannot be used upon a repeated  
field. Likewise ExtensionSize() can be used against a repeated field only.  
In your example, the line that currently is failing should really cause a  
compile error. we actually already has a DCHECK to prevent this kind of  
user error but seems it's not triggered:

https://github.com/google/protobuf/blob/master/src/google/protobuf/extension_set.cc#L194

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 678 in protobuf: HasExtension() called on a repeated field should cause a compile error (Protobuf 2.4.1)

2014-11-06 Thread protobuf


Comment #3 on issue 678 by kaspar.f...@dreizak.com: HasExtension() called  
on a repeated field should cause a compile error (Protobuf 2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

That makes sense – and is consistent with the other uses of has in the  
API. Thanks for the response.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 187 in protobuf: Command-line argument to override the optimize_for option

2014-11-05 Thread protobuf


Comment #14 on issue 187 by austin.l...@gmail.com: Command-line argument to  
override the optimize_for option

https://code.google.com/p/protobuf/issues/detail?id=187

I was able to use Keaton's plugin as a starting point and am using it now.   
I didn't know that the protobuf compiler was that extensible.  Way cool.


FYI, it is less lines of code to write the entire plugin in C++ and  
directly call the C++ generator from there, though it is a bit trickier to  
get it right.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 678 in protobuf: Clearing an extension message clears it but HasExtension still reports it's not cleared (Protobuf 2.4.1)

2014-11-05 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 678 by kaspar.f...@dreizak.com: Clearing an extension message  
clears it but HasExtension still reports it's not cleared (Protobuf 2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

What steps will reproduce the problem?
1. Compile the attached Protobuf and example program.
2. Run it: ./main

What is the expected output? What do you see instead?
The output should not print any violated statements.
It shows:
$ ./main
violated: A has no extension

What version of the product are you using? On what operating system?
Protobuf 2.4.1

Attachments:
protobufextbug.zip  7.4 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 678 in protobuf: Clearing an extension message clears it but HasExtension still reports it's not cleared (Protobuf 2.4.1)

2014-11-05 Thread protobuf


Comment #1 on issue 678 by kaspar.f...@dreizak.com: Clearing an extension  
message clears it but HasExtension still reports it's not cleared (Protobuf  
2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

For the sake of completeness, here are the files contained in the ZIP:

$ cat A.proto
message A {
optional string a = 1;
extensions 100 to 1000;
}

message AExt {
message E {
optional string e = 1;
}
extend A {
repeated E ext = 100;
}
}

$ cat main.cc
// $ protoc --version
// libprotoc 2.4.1
// $ c++ -L/opt/brew/lib -I/opt/brew/include/ main.cc A.pb.cc -lprotobuf -o  
main

// $ c++ --version
// Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)
// Target: x86_64-apple-darwin13.4.0
// Thread model: posix


#include A.pb.h
#include iostream
#include google/protobuf/text_format.h

void expectTrue(bool e, const std::string msg) {
if (!e) {
std::cout  violated:   msg  std::endl;
}
}

int main() {
std::cout  hello  std::endl;

// Clearing a message extension clears it but reports as still present
{
A a;
a.AddExtension(AExt::ext)-set_e(e);
expectTrue(a.HasExtension(AExt::ext), A has extension);
expectTrue(a.ExtensionSize(AExt::ext) == 1, A's extension has size 
1);
a.ClearExtension(AExt::ext);
expectTrue(a.ExtensionSize(AExt::ext) == 0, A's extension has size 
0);
expectTrue(!a.HasExtension(AExt::ext), A has no extension); 
// FAILS
}

return 0;
}

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 549 in protobuf: Cannot install to anywhere except /usr/local/lib

2014-10-31 Thread protobuf


Comment #2 on issue 549 by arglanir: Cannot install to anywhere except  
/usr/local/lib

https://code.google.com/p/protobuf/issues/detail?id=549

I have found the missing option at  
https://www.mail-archive.com/protobuf@googlegroups.com/msg02998.html.


So if someone needs it, you should use:

./configure --prefix=/home/sliverdragon37 --disable-shared

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 226 in protobuf: Python API doesn't support reading/writing delimited messages

2014-10-30 Thread protobuf


Comment #9 on issue 226 by vladimir...@gmail.com: Python API doesn't  
support reading/writing delimited messages

https://code.google.com/p/protobuf/issues/detail?id=226

Here's a workaround - assuming you want to do this because you are writing  
protobuf messages to sockets. The delimited write simply writes the message  
length as a varint32 before writing the message itself:


(apologies for unidiomatic code - bit of a python noob)

from google.protobuf.internal.decoder import _DecodeVarint32
from google.protobuf.internal.encoder import _EncodeVarint

def write_message_delimited(socket, msg):
hdr = []
_EncodeVarint(hdr.append, len(msg))
socket.sendall(.join(hdr))
socket.sendall(msg.SerializeToString())

def read_message_delimited(socket):
# int length is at most 4 bytes long
hdr_bytes = self.socket.recv(4)
(msg_length, hdr_length) = _DecodeVarint32(hdr_bytes, 0)

rsp_buffer = io.BytesIO()
if hdr_length  4:
  rsp_buffer.write(hdr_bytes[hdr_length:])

# read the remaining message bytes
msg_length = msg_length - (4 - hdr_length)
while msg_length  0:
rsp_bytes = self.socket.recv(min(8096, msg_length))
rsp_buffer.write(rsp_bytes)
msg_length = msg_length - len(rsp_bytes)

return MyMessage.ParseFromString(rsp_buffer.getvalue())

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 226 in protobuf: Python API doesn't support reading/writing delimited messages

2014-10-30 Thread protobuf


Comment #10 on issue 226 by vladimir...@gmail.com: Python API doesn't  
support reading/writing delimited messages

https://code.google.com/p/protobuf/issues/detail?id=226

Here's a workaround - assuming you want to do this because you are writing  
protobuf messages to sockets. The delimited write simply writes the message  
length as a varint32 before writing the message itself:


(apologies for unidiomatic code - bit of a python noob)

from google.protobuf.internal.decoder import _DecodeVarint32
from google.protobuf.internal.encoder import _EncodeVarint

def write_message_delimited(socket, msg):
hdr = []
_EncodeVarint(hdr.append, len(msg))
socket.sendall(.join(hdr))
socket.sendall(msg.SerializeToString())

def read_message_delimited(socket):
# int length is at most 4 bytes long
hdr_bytes = socket.recv(4)
(msg_length, hdr_length) = _DecodeVarint32(hdr_bytes, 0)

rsp_buffer = io.BytesIO()
if hdr_length  4:
  rsp_buffer.write(hdr_bytes[hdr_length:])

# read the remaining message bytes
msg_length = msg_length - (4 - hdr_length)
while msg_length  0:
rsp_bytes = socket.recv(min(8096, msg_length))
rsp_buffer.write(rsp_bytes)
msg_length = msg_length - len(rsp_bytes)

return MyMessage.ParseFromString(rsp_buffer.getvalue())

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 324 in protobuf: Feature: Add a new primitive type for a DateTime format

2014-10-30 Thread protobuf


Comment #8 on issue 324 by wouter.b...@gmail.com: Feature: Add a new  
primitive type for a DateTime format

https://code.google.com/p/protobuf/issues/detail?id=324

Temporenc (http://temporenc.org) is a comprehensive binary encoding format  
for dates and times that tries to solve the problem discussed in this  
issue. It is designed to be embedded into protobufs (or other embedding  
formats).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 226 in protobuf: Python API doesn't support reading/writing delimited messages

2014-10-29 Thread protobuf


Comment #8 on issue 226 by vladimir...@gmail.com: Python API doesn't  
support reading/writing delimited messages

https://code.google.com/p/protobuf/issues/detail?id=226

You have few use cases in your codebase? Lame reason. Disappointing.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 570 in protobuf: build 2.4.1 failed on mac os x 10.9

2014-10-27 Thread protobuf

Updates:
Status: Fixed

Comment #11 on issue 570 by xiaof...@google.com: build 2.4.1 failed on mac  
os x 10.9

https://code.google.com/p/protobuf/issues/detail?id=570

The latest code includes iostream which I believe has fixed this issue:
https://github.com/google/protobuf/blob/master/src/google/protobuf/message.cc

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 570 in protobuf: build 2.4.1 failed on mac os x 10.9

2014-10-26 Thread protobuf


Comment #9 on issue 570 by azxf...@gmail.com: build 2.4.1 failed on mac os  
x 10.9

https://code.google.com/p/protobuf/issues/detail?id=570

it the cofing.h file

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 266 in protobuf: Protoc generates unused variable in Java for protobuf with single repeated field

2014-10-24 Thread protobuf


Comment #7 on issue 266 by blakeman...@gmail.com: Protoc generates unused  
variable in Java for protobuf with single repeated field

https://code.google.com/p/protobuf/issues/detail?id=266

Still waiting on a fix for this...

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 676 in protobuf: protoc does not warn for Java keyword super

2014-10-21 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 676 by klocksve...@gmail.com: protoc does not warn for Java  
keyword super

https://code.google.com/p/protobuf/issues/detail?id=676

What steps will reproduce the problem?
1. Be mindless and forget that super is a keyword and try to use it as an  
enum identifier.

2. Create protofile:
enum SuperEnum {
  super = 1;
}

message SuperMessage {
  required SuperEnum super = 1;
}

3. compile with protoc
4. compile with javac
5. Get confused, because a moment ago before some copy and paste  
acrobatics, everything worked just fine and the cause is obfuscated by  
unrelated errors.



What is the expected output? What do you see instead?
protoc should warn or deny to use identifier super, instead it does not  
show any warning.


javac does not compile with error
SuperEnumMessage.java:13: error: identifier expected
  implements com.google.protobuf.ProtocolMessageEnum {
and tons of subsequent errors.

What version of the product are you using? On what operating system?
protoc 2.5.0, java hotspot 1.8.0_25, Linux 64-bit


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 675 in protobuf: memory leak

2014-10-20 Thread protobuf

Updates:
Status: Fixed
Owner: xiaof...@google.com
Labels: FixedIn-2.6.1

Comment #1 on issue 675 by xiaof...@google.com: memory leak
https://code.google.com/p/protobuf/issues/detail?id=675

Fixed in:
https://github.com/google/protobuf/commit/06e6690bf2055b4361db2a6bdd21facf3f2d86d6

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 675 in protobuf: memory leak

2014-10-19 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 675 by vxm...@gmail.com: memory leak
https://code.google.com/p/protobuf/issues/detail?id=675

A memory leak is detected by vld(visual leak detector).
I think the problem is caused by this function:
void InitEmptyString() {
  empty_string_ = new string;
}
empty_string_ will not be deleted later.

In previous version protobuf-2.5.0, empty string is a global std::string
const ::std::string kEmptyString;




protobuf version: protobuf-2.6.0
OS: windows 8.1
build env: visual studio 2013

Some output generated by vld:
d:\sdk\protobuf\protobuf-2.6.0\src\google\protobuf\generated_message_util.cc  
(55):  
ChatServerd.exe!google::protobuf::internal::InitEmptyString + 0x7  
bytes
d:\sdk\protobuf\protobuf-2.6.0\src\google\protobuf\stubs\common.h (876):  
ChatServerd.exe!google::protobuf::internal::FunctionClosure0::Run + 0xA  
bytes
d:\sdk\protobuf\protobuf-2.6.0\src\google\protobuf\stubs\once.cc (83):  
ChatServerd.exe!google::protobuf::GoogleOnceInitImpl + 0xF bytes
d:\sdk\protobuf\protobuf-2.6.0\src\google\protobuf\stubs\once.h (127):  
ChatServerd.exe!google::protobuf::GoogleOnceInit + 0xD bytes
d:\sdk\protobuf\protobuf-2.6.0\src\google\protobuf\generated_message_util.h  
(84): ChatServerd.exe!google::protobuf::internal::GetEmptyString + 0xF bytes


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 673 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 673 by weegreen...@gmail.com: protoc: can't control output  
directory

https://code.google.com/p/protobuf/issues/detail?id=673

I am working on integrating the protoc compiler to my build system, however  
I'm finding it difficult to control where the output files are saved.


What steps will reproduce the problem?

1. unzip project

2. change directories
$ cd protobuf_bug

3. execute expected use case:
$ protoc --cpp_out=src/audacity/messages/pb  
src/audacity/messages/pb/Type.proto


4. observe output files not placed in specified output directory:
$ find .
.
./src
./src/audacity
./src/audacity/messages
./src/audacity/messages/pb
./src/audacity/messages/pb/src
./src/audacity/messages/pb/src/audacity
./src/audacity/messages/pb/src/audacity/messages
./src/audacity/messages/pb/src/audacity/messages/pb
./src/audacity/messages/pb/src/audacity/messages/pb/Type.pb.h
./src/audacity/messages/pb/src/audacity/messages/pb/Type.pb.cc
./src/audacity/messages/pb/Type.proto

5. clean up the mess
$ rm -rf src/audacity/messages/pb/src

6. execute next expected use case:
$ protoc --cpp_out=. src/audacity/messages/pb/Type.proto

7. observe correct output:
$ find .
.
./src
./src/audacity
./src/audacity/messages
./src/audacity/messages/pb
./src/audacity/messages/pb/Type.pb.h
./src/audacity/messages/pb/Type.pb.cc
./src/audacity/messages/pb/Type.proto

What is the expected output? What do you see instead?

I expect the generated files to be placed in the directory specified,  
instead funny path manipulation is occurring.


What version of the product are you using? On what operating system?

$ protoc --version
libprotoc 2.5.0
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:   trusty

Please provide any additional information below.

Please add some option to explicitly place the generated files to  
specified location, similar to how gcc -o works, as protoc is advertised as  
a compiler.
The location where protoc places output files isn't explained in the  
documentation, if the default is to always place the output files next to  
the .proto file, then there should be a set of --cpp, --python, --java  
switches which does this, rather some --XXX_out=DIR switch.



Attachments:
protobuf_buf.zip  1.2 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Issue 674 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf

Status: New
Owner: liuj...@google.com
Labels: Type-Defect Priority-Medium

New issue 674 by weegreen...@gmail.com: protoc: can't control output  
directory

https://code.google.com/p/protobuf/issues/detail?id=674

May be related to #693.

What steps will reproduce the problem?

1. unzip project

2. change dir
$ cd protobuf_bug

3. execute expected use case:
$ protoc -Isrc --cpp_out=. src/audacity/messages/pb/Emitter.proto

4. observe output is unexpected:
$ find .
.
./audacity
./audacity/messages
./audacity/messages/pb
./audacity/messages/pb/Emitter.pb.h
./audacity/messages/pb/Emitter.pb.cc
./src
./src/audacity
./src/audacity/messages
./src/audacity/messages/pb
./src/audacity/messages/pb/Type.proto
./src/audacity/messages/pb/Emitter.proto

5. clean up mess:
$ rm -rf ./audacity

6. execute next expected use case:
$ protoc -Isrc --cpp_out=src src/audacity/messages/pb/Emitter.proto

7. observe expected output:
$ find .
.
./src
./src/audacity
./src/audacity/messages
./src/audacity/messages/pb
./src/audacity/messages/pb/Emitter.pb.h
./src/audacity/messages/pb/Emitter.pb.cc
./src/audacity/messages/pb/Type.proto
./src/audacity/messages/pb/Emitter.proto


What is the expected output? What do you see instead?

From my learning experience with documenting issue #693, I thought  
--cpp_out=. would always work, but once I started getting more complicated,  
when using -Isrc, everything gets hosed.  It seems like -IDIR and  
--cpp_out=DIR must always occur in pairs, this is very unexpected as gcc  
and visual studio compilers have no such behavior.  If multiple -I flags  
are specified, I have no idea how to manipulate --cpp_out.


What version of the product are you using? On what operating system?
See #693.

Please provide any additional information below.
See #693.



Attachments:
protobuf_bug.zip  1.6 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 673 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf

Updates:
Status: WorkingAsIntended
Owner: xiaof...@google.com

Comment #1 on issue 673 by xiaof...@google.com: protoc: can't control  
output directory

https://code.google.com/p/protobuf/issues/detail?id=673

This is just how protocol compiler is designed to work. For C++ and Python,  
it will generate a directory structure matching exactly the relative path  
of the input .proto file.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 673 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf


Comment #2 on issue 673 by weegreen...@gmail.com: protoc: can't control  
output directory

https://code.google.com/p/protobuf/issues/detail?id=673

Please document how it's designed to work.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 674 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf

Updates:
Status: WorkingAsIntended
Owner: xiaof...@google.com

Comment #1 on issue 674 by xiaof...@google.com: protoc: can't control  
output directory

https://code.google.com/p/protobuf/issues/detail?id=674

Here is how it works:

Support you invoke protoc as:
protoc -Ipath1 --cpp_out=path2 path1/path3/test.proto

protoc will generate:
path2/path3/test.pb.h
path2/path3/test.pb.cc

The canonical name of the .proto file will be path3/test.proto and that's  
the name used to refer to this file in protobuf runtime (e.g., you need to  
use this name in DescriptorPool::FindFileByName()).


We should document this better but this is working as intended.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 674 in protobuf: protoc: can't control output directory

2014-10-18 Thread protobuf


Comment #2 on issue 674 by weegreen...@gmail.com: protoc: can't control  
output directory

https://code.google.com/p/protobuf/issues/detail?id=674

Why not improve the documentation with this ticket?


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 476 in protobuf: Officially support Maven protoc plugin

2014-10-16 Thread protobuf

Updates:
Summary: Officially support Maven protoc plugin
Status: Accepted
Owner: xiaof...@google.com

Comment #10 on issue 476 by xiaof...@google.com: Officially support Maven  
protoc plugin

https://code.google.com/p/protobuf/issues/detail?id=476

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 489 in protobuf: 2.5.0 build failed on sparc-sun-solaris2.10

2014-10-16 Thread protobuf

Updates:
Status: Fixed
Owner: xiaof...@google.com

Comment #1 on issue 489 by xiaof...@google.com: 2.5.0 build failed on  
sparc-sun-solaris2.10

https://code.google.com/p/protobuf/issues/detail?id=489

Atomicops support for solaris is added in this commit:
https://github.com/google/protobuf/commit/a9155b8d3c568a82e4df9402f1461c7af6aa9eb0

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2014-10-15 Thread protobuf

Updates:
Status: WontFix
Owner: xiaof...@google.com

Comment #10 on issue 447 by xiaof...@google.com: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

FYI.

Google's Style Guide now permits rvalue references to be used in move  
constructors and this feature for protobuf has been proposed and discussed  
again (google internally). It's rejected again unfortunately. For Googlers  
who may want a reference, see CL 67127736. Basically he who has to power to  
decide whether to accept this change is not convinced that it can improve  
the API or can improve the performance.


Unless the issue is resolved internally, we wouldn't add move constructors  
to protobuf.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2014-10-15 Thread protobuf


Comment #11 on issue 447 by chen3feng: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

Very disappointed to hear this message.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2014-10-15 Thread protobuf


Comment #12 on issue 447 by cbsm...@gmail.com: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

Speaks volumes that after 22 months after submission and 5 months after a  
working plugin was contributed, there isn't even a direct answer.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 447 in protobuf: No C++11 move constructors

2014-10-15 Thread protobuf


Comment #13 on issue 447 by chen3feng: No C++11 move constructors
https://code.google.com/p/protobuf/issues/detail?id=447

let't make a fork on github?
2014-10-16 上午11:01于 proto...@googlecode.com写道:

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 226 in protobuf: Python API doesn't support reading/writing delimited messages

2014-10-14 Thread protobuf

Updates:
Owner: xiaof...@google.com

Comment #6 on issue 226 by xiaof...@google.com: Python API doesn't support  
reading/writing delimited messages

https://code.google.com/p/protobuf/issues/detail?id=226

I searched around our internal code base and it appears there are very few  
use cases of the Message.writeDelimitedTo() method in Java. Likely for two  
reasons: first, most users will just use a repeated message field if they  
want to send multiple messages over the wire; second, people who want to  
write multiple messages by themselves will tend to want their own  
customized format as well (i.e., not just a size prefix but also other  
meta-data information like the message type name). From my understanding,  
the writeDelimitedTo() method in Java's MessageLIte interface shouldn't be  
there in the first place. It just doesn't belong to protobuf core APIs and  
more of an utility method that very few users would need.


For this reason, I don't think we should add its counter-part in Python (or  
C++).



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 226 in protobuf: Python API doesn't support reading/writing delimited messages

2014-10-14 Thread protobuf


Comment #7 on issue 226 by brian.olson: Python API doesn't support  
reading/writing delimited messages

https://code.google.com/p/protobuf/issues/detail?id=226

The lack of an API for a framed stream of protobuf messages is a feature  
for lack of which projects have decided to go with Thrift or another system  
rather than protobuf.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 381 in protobuf: Do not use heap where stack can be used

2014-10-14 Thread protobuf

Updates:
Status: WontFix
Owner: xiaof...@google.com

Comment #4 on issue 381 by xiaof...@google.com: Do not use heap where stack  
can be used

https://code.google.com/p/protobuf/issues/detail?id=381

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 423 in protobuf: Cannot compile protobuf example code on AIX 6.1

2014-10-14 Thread protobuf

Updates:
Status: WontFix
Owner: xiaof...@google.com

Comment #3 on issue 423 by xiaof...@google.com: Cannot compile protobuf  
example code on AIX 6.1

https://code.google.com/p/protobuf/issues/detail?id=423

Marking this as Won't Fix as we don't have the environment to test/fix  
the problem. If you have a fix, feel free to send us a patch to our github  
site:

https://github.com/google/protobuf

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 499 in protobuf: using protobuf on ios

2014-10-14 Thread protobuf


Comment #3 on issue 499 by johnzhj...@gmail.com: using protobuf on ios
https://code.google.com/p/protobuf/issues/detail?id=499

in xcode build phases, add all you protoc generated .a library

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf


Comment #8 on issue 607 by gli...@chromium.org: Replace TSan API  
declarations in atomicops_internals_tsan.h with a header inclusion

https://code.google.com/p/protobuf/issues/detail?id=607

Niall, which Clang version are you using? Clang 3.5 must have this header  
(in fact we've just checked that), Clang 3.4 indeed does not.


Feng, do you think we need some check for Clang version around this header?
Perhaps something along the lines of:
(__clang_major__  3) || (__clang_major__ == 3  __clang_minor__  4)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf


Comment #9 on issue 607 by nialldouglas14: Replace TSan API declarations in  
atomicops_internals_tsan.h with a header inclusion

https://code.google.com/p/protobuf/issues/detail?id=607

I would assume at the time of report I would be running 3.4 as 3.5 wasn't  
out yet. Actually, until that change allowing multiple clang versions to  
coexist hits the main apt repos, I still can't install clang 3.5 :(


Niall

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf

Updates:
Owner: xiaof...@google.com

Comment #10 on issue 607 by xiaof...@google.com: Replace TSan API  
declarations in atomicops_internals_tsan.h with a header inclusion

https://code.google.com/p/protobuf/issues/detail?id=607

Yes, I think we need to make the header work on Clang 3.4 as well.  
Something like:

#if (__clang_major__  3) || (__clang_major__ == 3  __clang_minor__  4)
#include sanitizer/tsan_interface_atomic.h
#else
... atomicops declarations for 3.4 and older...
#endif

Could you help make this change? We moved to github and you can send us a  
pull request here: https://github.com/google/protobuf/pulls


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 607 in protobuf: Replace TSan API declarations in atomicops_internals_tsan.h with a header inclusion

2014-10-13 Thread protobuf


Comment #11 on issue 607 by nialldouglas14: Replace TSan API declarations  
in atomicops_internals_tsan.h with a header inclusion

https://code.google.com/p/protobuf/issues/detail?id=607

I can verify someone else's work after they have tested it themselves. I  
don't believe I am authorised by my current client to do the work myself.  
Niall


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


  1   2   3   4   5   6   7   8   9   10   >