How to review an entire application?
I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a new hire. This stuff had already been checked into our CVS repository. I suspect this is not standard practice, but is there some way to post a review request for an entire application or an entire directory (that is, where there are no changes against the repository for the current directory)? I see nothing obvious in post-review --help output which suggests this is possible. I'm using post-review 0.8 and ReviewBoard 0.9 ATM, but I have the power to upgrade it if necessary (it's just running on my desktop machine). Outside of me and a few other developers ReviewBoard is unknown at work, so I imagine this sort of here, the application is finished, please review it all request is going to pop up for some time to come. I'd really like to be able to accommodate such requests as a way to demonstrate RB's usefulness. Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ReviewBoard Error while posting review for GIT
Any update on this one?
I am again stuck here...
Kunjal
On Feb 11, 2:01 pm, Kunjal kunjal.par...@gmail.com wrote:
So, you are saying that Path variable in Admin GUI should be empty and
Mirror Path: should list the git repository?
Path: Empty string
Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I also configure cgit as you told but I do not know how to make my
local workspace available in cgit and also what path I put in Path
variable in Admin GUI for cgit.
Right now, posting review only works if there is below config:
Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This
is my local workspace and every developer would have its own ]
Mirror Path: git://mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I think I am getting there...
On Feb 10, 5:18 pm, Christian Hammond chip...@chipx86.com wrote:
Awesome :)
You can put the git:// URL in Mirror Path and Review Board will match
it properly. It just won't use it for accessing the repository.
Christian
On Wednesday, February 10, 2010, Kunjal kunjal.par...@gmail.com wrote:
THANKS MAN !
Finally I got it working.
But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/
users/kaparikh/scripts/.git which is my workspace.
Every developer has different workspace and multiple repo to work
with.
I did not get the part where you mentioned about raw URL stuff.
Thanks
Kunjal
On Feb 10, 10:28 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
Sorry, I'm out of town on vacation and emailing from my phone, do my
answers will be brief.
Subversion, Perforce, etc. give you the ability to talk to a remote
server and request a single file without having a checkout of the
whole repository. Git does not. With Git, you must have a full clone,
on the local computer (in this case, the Review Board server), in
order to access a particular file. This also means keeping it fully in
sync with origin always.
Because of this limitation in Git, you either need to set up this
clone and point Path to that or you needto use the Raw URL. This is a
mask (similar to the bug URL) that points to a path for a raw file on
cgit/gitweb/etc. This is the easiest, most preferred way. See the help
text under that field in the Repository configuration.
Christian
On Wednesday, February 10, 2010, Kunjal kunjal.par...@gmail.com wrote:
Chris,
Are you saying repository path field in the RB Admin GUI?
I set it as
git://mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
which is the server path where our repository resides.
What do you mean when you say GIT works only on local paths? How do I
know developer's local workspace path?
Pl. help. this issue is taking away my sleep !!
Kunjal
On Feb 5, 2:48 pm, Christian Hammond chip...@chipx86.com wrote:
I still need to see the repository Path field to be able to say
what's going
on. Is it a remote path, or a local path on the filesystem? Git can
only
operate on local paths.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Feb 5, 2010 at 11:05 AM, Kunjal kunjal.par...@gmail.com
wrote:
It's failing here in git.py in scmtools folder.
class GitClient:
def __init__(self, path):
if not is_exe_in_path('git'):
# This is technically not the right kind of error, but
it's the
# pattern we use with all the other tools.
raise ImportError
self.path = path
p = subprocess.Popen(
['git', '--git-dir=%s' % self.path, 'config',
'core.repositoryformatversion'],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if failure:
raise ImportError
On Feb 4, 1:31 pm, Kunjal kunjal.par...@gmail.com wrote:
When I look at the error.log for Apache server, It give me this:
Am I not Importing some modules?
Traceback (most recent call last):
File
/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py,
line
92, in get_response
response = callback(request, *callback_args,
**callback_kwargs)
File
/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py,
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File
/projects/mob_tools/xampp/1.6.4-brcm-v2/lib/python2.5/site-
Re: ReviewBoard Error while posting review for GIT
Never saw this e-mail. Must have missed it while on vacation.
With the raw URL stuff, actually you can set Path as the git repo, because
we'll never use it to access files.
cgit has to run on the upstream git repository, so on
mobcom-git.sj.broadcom.com probably. *Something* needs local access to a Git
repository, so if not Review Board, then cgit.
You shouldn't need Review Board or cgit to reference local repositories.
post-review will find the proper upstream (the mobcom-git.sj.broadcom.com)
and reference that.
For information on what to put in the Raw URL mask field with cgit, look at:
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/#cgit
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Thu, Feb 11, 2010 at 2:01 PM, Kunjal kunjal.par...@gmail.com wrote:
So, you are saying that Path variable in Admin GUI should be empty and
Mirror Path: should list the git repository?
Path: Empty string
Mirror Path: git://
mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I also configure cgit as you told but I do not know how to make my
local workspace available in cgit and also what path I put in Path
variable in Admin GUI for cgit.
Right now, posting review only works if there is below config:
Path: /projects/mobcom_andrwks_ext2/users/kaparikh/scripts/.git [ This
is my local workspace and every developer would have its own ]
Mirror Path: git://
mobcom-git.sj.broadcom.com/git_repos/repo_tools/scripts.git
I think I am getting there...
On Feb 10, 5:18 pm, Christian Hammond chip...@chipx86.com wrote:
Awesome :)
You can put the git:// URL in Mirror Path and Review Board will match
it properly. It just won't use it for accessing the repository.
Christian
On Wednesday, February 10, 2010, Kunjal kunjal.par...@gmail.com wrote:
THANKS MAN !
Finally I got it working.
But my Path in RB server looks like: /projects/mobcom_andrwks_ext2/
users/kaparikh/scripts/.git which is my workspace.
Every developer has different workspace and multiple repo to work
with.
I did not get the part where you mentioned about raw URL stuff.
Thanks
Kunjal
On Feb 10, 10:28 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
Sorry, I'm out of town on vacation and emailing from my phone, do my
answers will be brief.
Subversion, Perforce, etc. give you the ability to talk to a remote
server and request a single file without having a checkout of the
whole repository. Git does not. With Git, you must have a full clone,
on the local computer (in this case, the Review Board server), in
order to access a particular file. This also means keeping it fully in
sync with origin always.
Because of this limitation in Git, you either need to set up this
clone and point Path to that or you needto use the Raw URL. This is a
mask (similar to the bug URL) that points to a path for a raw file on
cgit/gitweb/etc. This is the easiest, most preferred way. See the help
text under that field in the Repository configuration.
Christian
On Wednesday, February 10, 2010, Kunjal kunjal.par...@gmail.com
wrote:
Chris,
Are you saying repository path field in the RB Admin GUI?
I set it as git://
mobcom-git.sj.broadcom.com/git_repos/repo_mydroid/vendor.git
which is the server path where our repository resides.
What do you mean when you say GIT works only on local paths? How do
I
know developer's local workspace path?
Pl. help. this issue is taking away my sleep !!
Kunjal
On Feb 5, 2:48 pm, Christian Hammond chip...@chipx86.com wrote:
I still need to see the repository Path field to be able to say
what's going
on. Is it a remote path, or a local path on the filesystem? Git can
only
operate on local paths.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Fri, Feb 5, 2010 at 11:05 AM, Kunjal kunjal.par...@gmail.com
wrote:
It's failing here in git.py in scmtools folder.
class GitClient:
def __init__(self, path):
if not is_exe_in_path('git'):
# This is technically not the right kind of error, but
it's the
# pattern we use with all the other tools.
raise ImportError
self.path = path
p = subprocess.Popen(
['git', '--git-dir=%s' % self.path, 'config',
'core.repositoryformatversion'],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if failure:
raise ImportError
On Feb 4, 1:31
Update dev build instructions
When browsing through the dev list, I got the instructions to build reviewboard from source here: http://www.reviewboard.org/docs/codebase/dev/getting-started/ The instructions seem out-of-date with the current trunk and seem to need 2 more dependency packages. Can someone please update the dev build page. 1. In the Installation dependencies page, add the following recaptcha-client (Can be installed using easy_install recaptcha- client) paramiko (can be installed using easy_install paramiko) -- Raja -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Setting up developer environment
It looks like you need to get django_evolution from easy_install django_evolution or code.google.com/p/django-evolution/ I just created a post with missing packages in the dependency list, but missed this one (as I had installed reviewboard earlier using easy_install). -- Raja On Feb 18, 12:10 am, Tony Bibbs t...@tonybibbs.com wrote: When I run this: python ./contrib/internal/prepare-dev.py I get that: Synchronizing database... Error: No module named django_evolution Did I miss a step or something? -- Tony Bibbs Phone: (515) 554-8046 Twitter, Skype, Facebook: tonybibbs Web:http://www.tonybibbs.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Update dev build instructions
Hi Raja, Would you mind filing a bug for tracking purposes? Or if you want to quickly update them yourself, you could even modify the docs yourself (reviewboard/docs/codebase/getting-started.txt) and submit a patch to http://reviews.reviewboard.org/. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Feb 22, 2010 at 5:12 AM, Raja rajas...@gmail.com wrote: When browsing through the dev list, I got the instructions to build reviewboard from source here: http://www.reviewboard.org/docs/codebase/dev/getting-started/ The instructions seem out-of-date with the current trunk and seem to need 2 more dependency packages. Can someone please update the dev build page. 1. In the Installation dependencies page, add the following recaptcha-client (Can be installed using easy_install recaptcha- client) paramiko (can be installed using easy_install paramiko) -- Raja -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to review an entire application?
Hi Skip, Your versions of post-review and Review Board sound pretty out-of-date, first of all, so I'd recommend setting aside some time to do an upgrade. Let me see if I have this right. You have a directory full of committed code that hasn't been reviewed yet. This code may span multiple revisions. You want to put that code up for review. Is that correct? There's no built-in option for doing this with CVS, but with RBTools 0.2 RC1, you could make use of the new --diff-filename. Basically, you'd generate a diff using cvs diff and covering all revisions of that directory only, and then pass the resulting filename using post-review --diff-filename=filename Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Feb 22, 2010 at 9:49 AM, s...@pobox.com wrote: I'm still getting familiar with Review Boar. I use it like so: * make a branch * edit/debug/lather/rinse/repeat * post-review * visit url fill in description, title, assign reviewers One of my colleagues asked a few of us to review a couple small applications written by a new hire. This stuff had already been checked into our CVS repository. I suspect this is not standard practice, but is there some way to post a review request for an entire application or an entire directory (that is, where there are no changes against the repository for the current directory)? I see nothing obvious in post-review --help output which suggests this is possible. I'm using post-review 0.8 and ReviewBoard 0.9 ATM, but I have the power to upgrade it if necessary (it's just running on my desktop machine). Outside of me and a few other developers ReviewBoard is unknown at work, so I imagine this sort of here, the application is finished, please review it all request is going to pop up for some time to come. I'd really like to be able to accommodate such requests as a way to demonstrate RB's usefulness. Thanks, -- Skip Montanaro - s...@pobox.com - http://www.smontanaro.net/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Review Board and remote user middleware/backend - user not forced to enter first/last names and email address
I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The user is then interrupted and redirected to their account page. Normally (as you know) the user is forced to enter their first/last names and their email address. However, using the remote middleware/backend the user is only asked to enable/disable syntax highlighting. They're not forced to enter their names and email address. Any ideas why this might be? Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address
On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The user is then interrupted and redirected to their account page. Normally (as you know) the user is forced to enter their first/last names and their email address. However, using the remote middleware/backend the user is only asked to enable/disable syntax highlighting. They're not forced to enter their names and email address. Any ideas why this might be? Thanks Data received from the custom auth backend is authoritative. Anything you would enter as a first/last name or email would be overwritten by whatever the backend decided it should be. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to review an entire application?
Christian Let me see if I have this right. You have a directory full of Christian committed code that hasn't been reviewed yet. This code may Christian span multiple revisions. You want to put that code up for Christian review. Is that correct? Yup. Christian There's no built-in option for doing this with CVS, but with Christian RBTools 0.2 RC1, you could make use of the new Christian --diff-filename. Basically, you'd generate a diff using cvs Christian diff and covering all revisions of that directory only, and Christian then pass the resulting filename using post-review Christian --diff-filename=filename Thanks. In looking back at what was installed I think I actually had 1.0.4 installed, not 0.9. I was looking at the version string in __init__.py. I have upgraded to the latest versions of ReviewBoard and RBTools nonetheless. It seems to me that If I'm trying to gather up all the Python files in a directory for submission as a review diff that this should work: for f in $(find . -name '*.py') ; do diff -Nu /dev/null $f done review.diff post-review --diff-filename=review.diff ... I haven't actually tried that yet, but that would seem to be a good first approximation. Skip -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address
Thanks. So I would need to write a custom backend/middleware instead? On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com wrote: On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The user is then interrupted and redirected to their account page. Normally (as you know) the user is forced to enter their first/last names and their email address. However, using the remote middleware/backend the user is only asked to enable/disable syntax highlighting. They're not forced to enter their names and email address. Any ideas why this might be? Thanks Data received from the custom auth backend is authoritative. Anything you would enter as a first/last name or email would be overwritten by whatever the backend decided it should be. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board and remote user middleware/backend - user not forced to enter first/last names and email address
Or we should figure out a scheme to allow for setting that on other backends. Could check an attribute on the backend. Maybe assume that we can set that info and have a flag for turning it off, which LDAP, NIS, etc. can do. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Feb 22, 2010 at 4:39 PM, Stodge sto...@gmail.com wrote: Thanks. So I would need to write a custom backend/middleware instead? On Feb 22, 3:20 pm, Stephen Gallagher step...@gallagherhome.com wrote: On 02/22/2010 03:10 PM, Stodge wrote: I'm using the remote user middleware/backend to support basic http authentication: 'django.contrib.auth.middleware.RemoteUserMiddleware', and it seems to work nicely with Review Board. Apache forces a user to login and then this middleware/backend automatically creates the user in Django. The user is then interrupted and redirected to their account page. Normally (as you know) the user is forced to enter their first/last names and their email address. However, using the remote middleware/backend the user is only asked to enable/disable syntax highlighting. They're not forced to enter their names and email address. Any ideas why this might be? Thanks Data received from the custom auth backend is authoritative. Anything you would enter as a first/last name or email would be overwritten by whatever the backend decided it should be. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Issue 1451 in reviewboard: Base field should be stripped before using
Updates: Status: Fixed Comment #2 on issue 1451 by chipx86: Base field should be stripped before using http://code.google.com/p/reviewboard/issues/detail?id=1451 Fixed on master (3ca1e5a) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1476 in reviewboard: TypeError: character mapping must return integer, None or unicode
Updates: Status: Fixed Comment #15 on issue 1476 by chipx86: TypeError: character mapping must return integer, None or unicode http://code.google.com/p/reviewboard/issues/detail?id=1476 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on ReviewBoardAPI in reviewboard
Comment by evgeny.zislis:
The responses are json, but the requests (in rb 1.5) are strangle multipart
form data! Took me ages to figure out how to request stuff from the server.
Example:
{{{
curl --cookie cookies.txt --cookie-jar cookies.txt -X POST
-F username=xxx -F password=yyy
http://reviewserver.com/api/json/accounts/login/
curl --cookie cookies.txt --cookie-jar cookies.txt -X GET
http://reviewserver.com/api/json/repositories/
}}}
For more information:
http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on ReviewBoardAPI in reviewboard
Comment by evgeny.zislis:
The responses are json, but the requests (in rb 1.5) are strangly sent
using multipart form data! Took me ages to figure out how to request stuff
from the server.
Example:
{{{
curl --cookie cookies.txt --cookie-jar cookies.txt -X POST
-F username=xxx -F password=yyy
http://reviewserver.com/api/json/accounts/login/
curl --cookie cookies.txt --cookie-jar cookies.txt -X GET
http://reviewserver.com/api/json/repositories/
}}}
For more information:
http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Comment on ReviewBoardAPI in reviewboard
Comment by evgeny.zislis:
The responses are json, but the requests (in rb 1.5) are strangely sent
using multipart form data! Took me ages to figure out how to request stuff
from the server.
Example:
{{{
curl --cookie cookies.txt --cookie-jar cookies.txt -X POST
-F username=xxx -F password=yyy
http://reviewserver.com/api/json/accounts/login/
curl --cookie cookies.txt --cookie-jar cookies.txt -X GET
http://reviewserver.com/api/json/repositories/
}}}
For more information:
http://code.google.com/p/reviewboard/wiki/ReviewBoardAPI
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1494 in reviewboard: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command
Comment #4 on issue 1494 by gfbett: post-review on windows vista/7 uses the wrong folder to store the authentication cookie, and it uses the diff command http://code.google.com/p/reviewboard/issues/detail?id=1494 RC1 fixed the application data issue, but not the external diff command -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1281 in reviewboard: Adding comments in diff viewer can delete or overwrite existing comments.
Comment #3 on issue 1281 by kyle.getz: Adding comments in diff viewer can delete or overwrite existing comments. http://code.google.com/p/reviewboard/issues/detail?id=1281 I don't think the line numbers need to go into the thousands for this to be triggered. On the contrary, I perceive the problem as being more related to horizontal length, rather than vertical length. When viewing a diff, the comment bubbles are at the very left of the page and the line numbers for new/updated code are in the middle of the page. I use a 20 widescreen monitor, so when viewing a diff (which expands horizontally to fill the screen), there's a decent amount of physical space (at least 9 inches) between the comment bubbles and the line numbers, so it's easy to miss the correlation and inadvertently erase a comment with no warning from Review Board. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1509 in reviewboard: Throws an exception upon a click on review request
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1509 by kcgade: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 'm seeing this error for reviewboard.twitter.com when I click on a review request. OperationalError at /r/ database is locked Request Method: GET Request URL:https://reviewboard.twitter.com/r/8316/ Exception Type: OperationalError Exception Value: database is locked Exception Location: /usr/lib/python2.4/site-packages/Django- 1.0.2_final-py2.4.egg/django/db/backends/__init__.py in _commit, line 28 Python Executable: /usr/bin/python Python Version: 2.4.3 Python Path:['/var/www/reviewboard/conf', '/usr/lib/python2.4/site- packages/setuptools-0.6c8-py2.4.egg', '/usr/lib/python2.4/site- packages/TracWysiwyg-0.2_r4135-py2.4.egg', '/usr/lib/python2.4/site- packages/TracDiscussion-0.6-py2.4.egg', '/usr/lib/python2.4/site- packages/TracSpamFilter-0.2.1dev_r6990-py2.4.egg', '/usr/lib/python2.4/site-packages/TracAccountManager-0.2.1dev_r3857- py2.4.egg', '/usr/lib64/python2.4/site-packages', '/usr/lib/python2.4/site-packages/django_evolution-0.0.0-py2.4.egg', '/usr/lib/python2.4/site-packages/Django-1.0.2_final-py2.4.egg', '/usr/lib/python2.4/site-packages/PIL-1.1.6-py2.4-linux-x86_64.egg', '/usr/lib/python2.4/site-packages/TracCustomFieldAdmin-0.2- py2.4.egg', '/usr/lib/python2.4/site-packages/TracDateField-1.0.1- py2.4.egg', '/usr/lib/python2.4/site-packages/flup-1.0.1-py2.4.egg', '/usr/lib/python2.4/site-packages/NavAdd-0.1-py2.4.egg', '/usr/lib/python2.4/site-packages/TicketValidator-0.1-py2.4.egg', '/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-py2.4.egg', '/usr/lib/python2.4/site-packages/Djblets-0.5alpha3-py2.4.egg', '/usr/lib/python2.4/site-packages/simplejson-2.0.9-py2.4-linux- x86_64.egg', '/usr/lib/python2.4/site-packages/Pygments-1.0- py2.4.egg', '/usr/lib/python2.4/site-packages/TracXMLRPC-1.0.0- py2.4.egg', '/usr/lib/python2.4/site-packages/Trac-0.11.4-py2.4.egg', '/usr/lib/python2.4/site-packages/GChartWrapper-0.8-py2.4.egg', '/usr/lib/python2.4/site-packages/gchartplugin-0.1-py2.4.egg', '/usr/lib64/python24.zip', '/usr/lib64/python2.4', '/usr/lib64/python2.4/plat-linux2', '/usr/lib64/python2.4/lib-tk', '/usr/lib64/python2.4/lib-dynload', '/usr/lib64/python2.4/site- packages/Numeric', '/usr/lib64/python2.4/site-packages/PIL', '/usr/lib64/python2.4/site-packages/gtk-2.0', '/usr/lib/python2.4/site- packages'] Server time:Mon, 22 Feb 2010 14:24:30 -0800 *NOTE: Do not post confidential information in this bug report.* What version are you running? What's the URL of the page containing the problem? What steps will reproduce the problem? 1. 2. 3. What is the expected output? What do you see instead? What operating system are you using? What browser? Please provide any additional information below. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1509 in reviewboard: Throws an exception upon a click on review request
Updates: Status: NeedInfo Comment #1 on issue 1509 by trowbrds: Throws an exception upon a click on review request http://code.google.com/p/reviewboard/issues/detail?id=1509 Do you have the full traceback? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1491 in reviewboard: LDAP group support
Comment #2 on issue 1491 by psarmstr: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 To me at least, it feels like not wanting this is specific to certain setups (or small shops that don't have LDAP setup properly yet). Managing everything through a single point is a lot easier than having to deal with multiple points and sync processes are annoying. If LDAP is so broken group stuff doesn't work, neither does login and you have bigger issues. Can you please provide a bit more about why you think it's specific to certain setups and why a sync process would be better than just calling LDAP in the same way user login does? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1491 in reviewboard: LDAP group support
Comment #3 on issue 1491 by chipx86: LDAP group support http://code.google.com/p/reviewboard/issues/detail?id=1491 You may want groups for permission purposes, or for review groups, or neither. Some places map review groups to mailman lists, and not anything in LDAP. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade
Comment #2 on issue 1506 by locomocogogo: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 Thanks for your help. Let me give you the info you need first before I try anything... Yes, on our installed copy of reviewboard, I see diffviewer/evolutions/ directory, and the timestamp is Aug 20 2008. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1506 in reviewboard: Get Unable to read settings_local.py. error while running rb-site upgrade
Comment #3 on issue 1506 by chipx86: Get Unable to read settings_local.py. error while running rb-site upgrade http://code.google.com/p/reviewboard/issues/detail?id=1506 That should be new enough to migrate properly. Anything prior to evolutions (which is a few years old now) would be more difficult. Let me know if it works and I'll close this out. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
