Re: gitolite and ReviewBoard
I've got a similar issue on Windows using Git bash. I'm hoping that
the repository does not need to be nfs mounted to the review board.
Git ls -remote works
$ git ls-remote
From @gitolite.hubteam.com:/puppet.git
91ef4590b8c61b7d07ed3c3cfaf2b21b7c38db02HEAD
91ef4590b8c61b7d07ed3c3cfaf2b21b7c38db02refs/heads/master
I've got my .reviewboardrc in $HOME with the repository
@gitolite.hubteam.com:/puppet.git and reviewboard url.
I've got a .gitconfig now with only reviewboard (no repository entry)
the same with .git/config as well.
I had to re-create my ssh keys with git bash ssh-keygen instead of
Putty keygen. Turns out Putty makes a public key that isn't
recognized.
I then imported my id_rsa pub into Putty and created a private key
which was added to the reviewboard.
I then had to initiate a ssh session to the host to cache the server
I then recreated the local repository with git clone from the gitolite
master (was challenged for passphrase)
I created my own branch and made edits, added, committed and diffed
them.
The post review won't work. It will work locally with a -n and if I
redirect that to a file I then upload in the GUI, it will work.
$ post-review --parent=master --server=https://svn.hubteam.com/
reviews
There was an error creating this review request.
The repository path "@gitolite.hubteam.com:/
puppet.git" is not in the
list of known repositories on the server.
Ask the administrator to add this repository to the Review
Board server.
For information on adding repositories, please read
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/
Calling post review without the parent and server gets me a complete
failure
$ post-review
host: svn.hubteam.com
method: GET
selector: /reviews/api/
Traceback (most recent call last):
File "c:\Python27\Scripts\post-review-script.py", line 8, in
load_entry_point('rbtools==0.3.4', 'console_scripts', 'post-
review')()
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 3972, in main
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 510, in check_api_version
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 962, in api_get
File "C:\Python27\lib\site-packages\rbtools-0.3.4-py2.7.egg\rbtools
\postreview
.py", line 932, in http_get
File "C:\Python27\lib\urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "C:\Python27\lib\urllib2.py", line 394, in open
response = self._open(req, data)
File "C:\Python27\lib\urllib2.py", line 412, in _open
'_open', req)
File "C:\Python27\lib\urllib2.py", line 372, in _call_chain
result = func(*args)
File "C:\Python27\lib\urllib2.py", line 1204, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "C:\Python27\lib\urllib2.py", line 1177, in do_open
print "data: " + req.data
TypeError: cannot concatenate 'str' and 'NoneType' objects
Any ideas?
Thanks,
Heidi
On Nov 8, 3:38 pm, Christian Hammond wrote:
> You still need .reviewboardrc so post-review knows which server to talk to
> in the first place. It's actually the recommended setup.
>
> You shouldn't have to rely on NFS.
>
> Looking over your previous e-mail, I noticed the ssh:// URL. Git actually
> doesn't use this format. Rather, if you just do g...@mydomain.com:path/to/git,
> it'll understand that that's SSH, and do the appropriate things. Clearly in
> your case, something else is failing here. Executing the ls-remote command
> with that path appeared to work for you, but it's not working when Review
> Board does it? That smells like an SSH key configuration problem.
>
> Can you show me exactly what happens when Review Board does it? And are you
> 100% certain that Review Board lists the proper SSH key in the Admin UI's
> SSH page?
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
>
>
>
>
> On Tue, Nov 8, 2011 at 9:35 AM, adrian wrote:
> > I have no doubt that the ".reviweboardrc" mechanism will make post-
> > review work... but it's still a work-around to the actual problem. It
> > is kind of cumbersome to have to rely on NFS plus the .reviewboardrc.
> > We would rather connect directly via ssh:// but we can't get this to
> > work properly.
>
> > //adrian
>
> > On Nov 7, 2:59 pm, Christian Hammond wrote:
> > > Hi Adrian,
>
> > > post-review will try to compare the repository paths by default. However,
> > > you can tell it explicitly which repository to use by specifying
> > REPOSITORY
> > > = '' in a .reviewboardrc file committed in the base of the
> > repository.
>
> > > This goes into some detail:
>
> > >http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/#r...
>
> > > So long as the repositories referenced are identical, you should be good.
>
> > > Ch
Re: New security releases: 1.5.7 and 1.6.3
On Nov 15, 2011, at 13:13, Stephen Gallagher wrote:\ > Just to let anyone know that happens to be using Review Board on an > older system running Django 1.1.x, there's an upgrade bug that I've just > opened at http://code.google.com/p/reviewboard/issues/detail?id=2387 How do I know what version of Django I am running? I installed RB a long time ago on a CentOS 5 system, and have upgraded it via easy_install and it's running 1.5.4 now. But unlike yum/rpm, I don't quite understand how easy_install works and what versions of all the components needed to run RB are installed on my system. With rpm, I could do a "rmp -q" to figure it all out. Don't know what the easy_install equivalent is or if there even is one. So I've been wondering if I can switch to using the EPEL RPMs on my existing system. Has anyone ever done this (going from an easy_install RB installation to an RPM based one) on a CentOS 5 system? Will installing the RPMs update all the other components (Django, Djiblets, etc.)? > There's a workaround if you're using Postgres or sqlite (just comment > out the offending code in the mentioned file), but it's going to hurt > anyone with MySQL deployments. I'm running MySQL so this statement worries me a bit. Should it? Alfred -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review error
On Thu, Nov 10, 2011 at 4:16 PM, Krles wrote: > Hello > > I would like you to ask about post-review. > > I've needed install RBtools on RHEL 3. RHEL in default has only python > 2.2.3. Therefore I've installed python 2.4.6, setuptools 0.6c11 fo 2.4 > and RBtools 0.34. > > After that I typed "post-review --help" and I got the error > > Traceback (most recent call last): > File "/usr/local/bin/post-review", line 7, in ? > sys.exit( > File "/usr/local/lib/python2.3/site-packages/setuptools-0.6c11- > py2.4.egg/pkg_resources.py", line 318, in load_entry_point > return get_distribution(dist).load_entry_point(group, name) > File "/usr/local/lib/python2.3/site-packages/setuptools-0.6c11- > py2.4.egg/pkg_resources.py", line 2221, in load_entry_point > return ep.load() > File "/usr/local/lib/python2.3/site-packages/setuptools-0.6c11- > py2.4.egg/pkg_resources.py", line 1954, in load > entry = __import__(self.module_name, globals(),globals(), > ['__name__']) > File "/usr/local/lib/python2.3/site-packages/RBTools-0.3.4-py2.4.egg/ > rbtools/postreview.py", line 2507 > @property > ^ > SyntaxError: invalid syntax > > > Do you know what's wrong ? Looks like you're running python 2.3 after all. Have you installed python 2.4 side by side with python 2.3? Are you calling the right binary? maciek -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewing whole files without repository
I've wanted it myself. I think it's worth doing for this release. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Nov 15, 2011 at 9:28 AM, David Trowbridge wrote: > We've definitely had requests to do this but so far noone has implemented > it. > > -David > > > > On Tue, Nov 15, 2011 at 8:38 AM, Jan Koprowski > wrote: > > Hi, > > I moved to new team at job and right now I'm in spot where I can not > > review diffs because of luck RTC support but I must to review whole > files. > > I'm supprised that there is no support for this in ReviewBoard. Is there > any > > feature request for this? > > -- > > Jan > > > > -- > > Want to help the Review Board project? Donate today at > > http://www.reviewboard.org/donate/ > > Happy user? Let us know at http://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > > http://groups.google.com/group/reviewboard?hl=en > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Noob installation/configuration issue
I'm trying to get reviewboard installed and when I go to http://localhost/review/ it loads the default page, but clicking on any of the links gives me a 404. Any ideas what I've got wrong? Here is the virtualhost conf I'm using: ServerName 172.1.1.22 DocumentRoot "/var/www/me/htdocs" WSGIPassAuthorization On WSGIScriptAlias "/review/" "/var/www/me/htdocs/reviewboard.wsgi" AllowOverride All Alias /review/media "/var/www/me/htdocs/media" Alias /review/errordocs "/var/www/me/htdocs/errordocs" Alias /review/favicon.ico "/var/www/me/htdocs/media/rbcommons/images/ favicon.png" -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New security releases: 1.5.7 and 1.6.3
On Tue, 2011-11-15 at 03:21 -0800, Christian Hammond wrote: > If you're running 1.5.x, you can upgrade to this release by doing: > > $ sudo easy_install -U ReviewBoard==1.5.7 > > Otherwise, just upgrade as normal. Just to let anyone know that happens to be using Review Board on an older system running Django 1.1.x, there's an upgrade bug that I've just opened at http://code.google.com/p/reviewboard/issues/detail?id=2387 There's a workaround if you're using Postgres or sqlite (just comment out the offending code in the mentioned file), but it's going to hurt anyone with MySQL deployments. I don't have the Django know-how to write the correct patch to fix it, but at a quick glance online it seems like it's a pretty easy fix if you know what you're doing. It seems to have bitten a lot of Django 1.1.x->1.2.x migrations. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Reviewing whole files without repository
We've definitely had requests to do this but so far noone has implemented it. -David On Tue, Nov 15, 2011 at 8:38 AM, Jan Koprowski wrote: > Hi, > I moved to new team at job and right now I'm in spot where I can not > review diffs because of luck RTC support but I must to review whole files. > I'm supprised that there is no support for this in ReviewBoard. Is there any > feature request for this? > -- > Jan > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Question about using ReviewBoard with Mercurial
Hi! Our team uses Mercurial. Our workflow involves a central dev repository, cloned by each developer to a local repo on their own machine. When the developer works on a task, they clone their local dev repo to another local, task-specific repo. I'm trying out reviewboard as a potential replacement for our current email-based code review process. I have the server running, and it is aware of our central repo, but when I try using post-review, I get this error message: mwillis@mwillis:~/work/dev-15600$ post-review ... The repository path "/home/mwillis/work/dev" is not in the list of known repositories on the server. After looking around in the post-review docs, I found the --parent parameter, which seems to be what I'm looking for. It warns "This only works with Git right now", but I was hoping that maybe the docs were just outdated. Alas, it gives me the same error: mwillis@mwillis:~/work/dev-15600$ post-review --parent $NAME_OF_OUR_CENTRAL_REPO ... The repository path "/home/mwillis/work/dev" is not in the list of known repositories on the server. Now I'm assuming that the problem is just that --parent doesn't support mercurial. Is that correct? If so, I'm possibly willing to submit a patch to get it working. Thanks! Mike -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New security releases: 1.5.7 and 1.6.3
On Tue, 2011-11-15 at 03:21 -0800, Christian Hammond wrote: > Hi everyone, > > This is the kind of release I never like to have to make, but it was > pointed out to us today that an encoding bug in our comment processing > made Review Board 1.5.x and 1.6.x susceptible to browser-side script > injection. We've patched this and issued two new releases: 1.5.7 and > 1.6.3. > > If you're running 1.5.x, you can upgrade to this release by doing: > > $ sudo easy_install -U ReviewBoard==1.5.7 > > Otherwise, just upgrade as normal. > > Thanks, and sorry for the inconvenience. Fedora and EPEL (RHEL/CentOS) packages are now available as well: https://admin.fedoraproject.org/updates/ReviewBoard-1.6.3-1.fc16 https://admin.fedoraproject.org/updates/ReviewBoard-1.5.7-1.fc15 https://admin.fedoraproject.org/updates/ReviewBoard-1.5.7-1.el5 https://admin.fedoraproject.org/updates/ReviewBoard-1.5.7-1.el6 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Reviewing whole files without repository
Hi, I moved to new team at job and right now I'm in spot where I can not review diffs because of luck RTC support but I must to review whole files. I'm supprised that there is no support for this in ReviewBoard. Is there any feature request for this? -- Jan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
New security releases: 1.5.7 and 1.6.3
Hi everyone, This is the kind of release I never like to have to make, but it was pointed out to us today that an encoding bug in our comment processing made Review Board 1.5.x and 1.6.x susceptible to browser-side script injection. We've patched this and issued two new releases: 1.5.7 and 1.6.3. If you're running 1.5.x, you can upgrade to this release by doing: $ sudo easy_install -U ReviewBoard==1.5.7 Otherwise, just upgrade as normal. Thanks, and sorry for the inconvenience. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to customize "Description" field with a template
Hi Christian Thx for answer Can you give me some guidance on how to do this? I tried to change the template review_request_box.html file. It works for creation but I leave my changes when update. Roger On Nov 15, 11:29 am, Christian Hammond wrote: > Hi Roger, > > There's no functionality built-in for this today. I think it would make > sense as an extension in the next release, but for today, you'd have to > modify your copy of Review Board to include this. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Tue, Nov 15, 2011 at 12:20 AM, Roger Layani > wrote: > > > > > Hi > > I would like to automatically set the "Description" field to include > > the template: > > > Problem : description of the broken functionality > > Root cause: Root analysis of the bug > > Fix : proposed fix > > > when review_request is created. > > > of course I would like to keep "description" details on review_request > > update or publish. > > Can someone help on how to do this? > > > -- > > Want to help the Review Board project? Donate today at > >http://www.reviewboard.org/donate/ > > Happy user? Let us know athttp://www.reviewboard.org/users/ > > -~--~~~~--~~--~--~--- > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - > > - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to customize "Description" field with a template
Hi Roger, There's no functionality built-in for this today. I think it would make sense as an extension in the next release, but for today, you'd have to modify your copy of Review Board to include this. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Tue, Nov 15, 2011 at 12:20 AM, Roger Layani wrote: > Hi > I would like to automatically set the "Description" field to include > the template: > > Problem : description of the broken functionality > Root cause: Root analysis of the bug > Fix : proposed fix > > when review_request is created. > > of course I would like to keep "description" details on review_request > update or publish. > Can someone help on how to do this? > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Query on installing RB in Linux
What pycrypto error did you hit? Regardless of how you install, it should be installing pycrypto (it's very much required). I don't know what the issue is, but it looks as if somehow, not all of Review Board is being found. Try: $ python >>> import reviewboard >>> print reviewboard.__file__ >>> from reviewboard.reviews.models import Group See what that says, and if you get an error. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 14, 2011 at 7:32 PM, Sharmila Saraswathi wrote: > Thanks Christian for the reply. > easy_install doesn't work due to an issue with pycrypto. ( > http://code.google.com/p/reviewboard/issues/detail?id=2346) > So got pycrypto installed explicitly and then tried for the setup.py in > Reviewboard that takes care of all the dependencies installation. > The dependencies installation went on fine. But when I did rb-site install > it failed with the below error. > > Python version is 2.6 and database is mysql. > Any idea? Can you please help us on the same. > > thanks- > Sharmila > > On Tue, Nov 15, 2011 at 1:41 AM, Christian Hammond wrote: > >> Looks like some strange installation issue. You should be installing >> using easy_install, though. >> >> What version of Python, and which database? >> >> Christian >> >> -- >> Christian Hammond - chip...@chipx86.com >> Review Board - http://www.reviewboard.org >> VMware, Inc. - http://www.vmware.com >> >> >> >> On Mon, Nov 14, 2011 at 7:58 AM, Sharmila Saraswathi < >> sharmila...@gmail.com> wrote: >> >>> Hi RB guys, >>> >>> >>> I am using the recent version of RB 1.6.2. Also tried the same in RB 1.6.1 >>> >>> These are the steps that I did. >>> >>> 1. Downloaded the RB recent version >>> >>> >>> 2. Installed them with setup.py >>> >>> 3. Then used rb-site install /rb-site upgrade >>> >>> >>> 4. Both failed with the below error >>> >>> 5. I am installing this in Linux as in solaris I had issues with using >>> pycrypto. >>> >>> This is the error that I am getting when using rb-site install on the newly >>> setup version. >>> >>> >>> >>> * Installing the site... >>> Building site directories ... OK >>> Building site configuration files ... OK >>> Error: One or more models did not validate: >>> scmtools.repository: 'review_groups' has an m2m relation with model >>> reviews.Group, which has either not been installed or is abstract. >>> >>> >>> >>> Can you please let me know from where the error should have occured and >>> why is this happening ? >>> >>> Should I get something else installed also ? >>> >>> thanks in advance for ur help- >>> >>> Sharmila >>> >>> >> > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to customize "Description" field with a template
Hi I would like to automatically set the "Description" field to include the template: Problem : description of the broken functionality Root cause: Root analysis of the bug Fix : proposed fix when review_request is created. of course I would like to keep "description" details on review_request update or publish. Can someone help on how to do this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
