Some doubts
Hello I am using latest version of ReviewBoard. I have some doubts in using post-review functionality. 1) Do i need to create corresponding users in ReviewBoard for svn users to see correct commiter name ? 2) How can i upload full code for ReviewBoard to manage it ? 3) Do ReviewBoard contain built-in code quality checks ? I have lot of users in svn so, it would be a cumbersome task to create corresponding user for each svn user -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Question about running post-review
post-review is usually run from the user's development box, not the server. It will connect to the server over http(s) and upload the review request. -Raghu On Oct 8, 10:47 pm, Alfred von Campe alf...@von-campe.com wrote: I'm still in the process of setting up out ReviewBoard server (struggling with LDAP/AD integration at the moment), but I'm looking slightly ahead. It appears that post-review is the recommended way to create a review (we're using Subversion if that matters), and I can see that post-review has been installed into /usr/bin/post-review. However, the server I installed ReviewBoard on is not a server that allows users to log in, and besides, the user's sandboxes are not on that server anyway. So how is a user supposed to run post-review on his or her system? I'm dealing with a few dozen developers on a few dozen Linux systems; am I supposed to install ReviewBoard on each user's desktop? Alfred --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: New comment moderation in effect
Christian, I would be more than happy to help with that. I am in IST timezone. Thanks, Raghu On Jun 12, 3:28 pm, Christian Hammond chip...@chipx86.com wrote: Hi everyone. As I'm sure you all have seen, we've been getting some spam lately. There was a discussion in an earlier thread about enabling comment moderation, and after thinking it over, I've decided to go ahead and enable this for new users. Existing users who have been approved shouldn't have any trouble posting, but new users may see delays before their first e-mail is sent. I'm going to try recruiting a couple regulars from this mailing list to act as moderators. If you're up for the task, please let me know. Bonus points for people in non-PST timezones. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: need help to integrate post-review with Perforce
You need to have a diff.exe that supports unified output format in your path. If you don't have it, you can get it by installing Cygwin (http://www.cygwin.com/). -Raghu On Jun 11, 3:34 pm, Amit agrawalamit2...@gmail.com wrote: Tanks a lot for response. I could intergate with p4win. Now problem i am facing is Traceback (most recent call last): File post-review, line 2313, in ? main(sys.argv[1:]) File post-review, line 2284, in main diff, parent_diff = tool.diff(args) File post-review, line 1446, in diff dl = execute(diff_cmd, extra_ignore_errors=(1,2)).splitlines(True) File post-review, line 1889, in execute env=env) File C:\Python24\lib\subprocess.py, line 554, in __init__ errread, errwrite) File C:\Python24\lib\subprocess.py, line 718, in _execute_child startupinfo) WindowsError: [Errno 2] The system cannot find the file specified What might be cause for it.What should i do to get rid of it. -Amit On Jun 11, 1:03 am, Paul Scott psc...@vmware.com wrote: Well, everyone who uses p4 will probably rather use post-review. ;) The tool in the rbtools/contrib should probably be renamed something with p4win in it, as it is an extension for p4win, and a lot of people use p4v now since p4win has been deprecated for a few years. I keep starting to make a similar extension (custom tool) for p4v but their terminal isn't a real terminal and can't handle the method post-review uses to collect your password if you need to authenticate. That's certainly something that can be handled pretty easily... post-review, or a wrapper (or preferably a rbapi library) probably needs a way of finding out if you are authenticated or not that doesn't go directly to asking you for your password. -- Paul From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On Behalf Of Joshua Slominski [hoohaa8...@gmail.com] Sent: Wednesday, June 10, 2009 9:44 AM To: reviewboard@googlegroups.com Subject: Re: need help to integrate post-review with Perforce There is a P4 tool located in rbtools/ contrib. If you set that up there is no need to run post-review from the command line. On Tue, Jun 9, 2009 at 4:49 PM, Christian Hammond chip...@chipx86.commailto:chip...@chipx86.com wrote: There's a lot of documentation on this athttp://www.review-board.org/docs/manual/dev/users/tools/post-review/ Christian -- Christian Hammond - chip...@chipx86.commailto:chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Jun 9, 2009 at 1:34 AM, Amit agrawalamit2...@gmail.commailto:agrawalamit2...@gmail.com wrote: Hi, I downloaded RBTools-0.2beta. afterwords i have no clue how to proceed for integrating post-review into Perforce. Any help will be highly appreciated. -Amit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: windows post-review errors while using on server
Before using review board, you should set up a repository as specified
in
http://www.review-board.org/docs/manual/dev/admin/management/repositories/#repositories
I strongly recommend you read the entire user/administration manual.
That'll help you to get started quickly.
-Raghu
On Jun 8, 2:16 pm, mmorgan mmor...@buzanonline.com wrote:
All the svn repository stuff was installed and managed from VisualSVN
Server, that shouldnt really have anything to do with it thinking it
is a clearcase repository though should it?
We have been using it fine as an svn repository from multiple
applications without any problems...
Mark
On Jun 5, 1:48 pm, Raghu raghu...@gmail.com wrote:
It looks as if post-review connected to the server and the server
indicated you have a clearcase repo. Is the repositories configured
correctly at the server?
-Raghu
On Jun 2, 6:34 pm, mmorgan mmor...@buzanonline.com wrote:
Hi,
I pretty new to review board, but want to say firstly it is a great
tool so keep up the good work!
Ive managed to set up review board on my windows server, which also
hosts my svn repository.
Ive decided to try to get post-review set up so that we can
automatically create reviews from the svn hooks, but im having a bit
of trouble getting it to work.
I apologise in advance if someone has answered the same question, ive
search everywhere in the discussion groups but haven't had any luck
finding an answer!
Currently I have python and difftools all installed, and installed
post-review as per the instructions using easy_install -U RBTools,
which seems to work. I have created a .bat file just to see if i can
get post-review working before trying to get it working with the svn
hooks. When i run the following from my .bat file:
C:\Python25\ScriptsC:\Python25\python.exe C:\Python25\Scripts\post-
review --repository-url==https://REPO_IP/svn/prototype--revision-
range=r533:r534 --server=http://127.0.0.1:8080--username=admin--
password=rbAdminPass --debug
I get the following error dump:
svn info =https://REPO_IP/svn/prototype
cleartool pwv -short
Traceback (most recent call last):
File C:\Python25\Scripts\post-review, line 5, in module
pkg_resources.run_script('rbtools==0.2beta1', 'post-review')
File C:\Python25\Lib\site-packages\pkg_resources.py, line 448, in
run_script
self.require(requires)[0].run_script(script_name, ns)
File C:\Python25\Lib\site-packages\pkg_resources.py, line 1173, in
run_script
exec script_code in namespace, namespace
File C:\Python25\Scripts\post-review, line 2313, in module
File C:\Python25\Scripts\post-review, line 2254, in main
File C:\Python25\Scripts\post-review, line 2206, in
determine_client
File C:\Python25\Scripts\post-review, line 744, in
get_repository_info
File C:\Python25\Scripts\post-review, line 1889, in execute
File C:\Python25\Lib\subprocess.py, line 594, in __init__
errread, errwrite)
File C:\Python25\Lib\subprocess.py, line 822, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
Any help would be much appreciated!
Thanks
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: summary or statistic of reviewboard
Hi, 1. There is no page to get the statistics as you mentioned. May be when review board starts supporting extensions something like this can be built (Can any developer comment?). As of now, you will be able to connect to the database and with few simple queries you can extract the statistics. But I don't think you'll get a guarantee that the schema will not change in future releases. 2. You've got the process flow almost correct. The only addition is this. After you get a Ship It, the engineer checks in the code and marks the review request as submitted. This will remove it from everyone's dashboard. Now, depending on your team's process you may need more than one Ship It approval. You can handle that by checking the number in the Ship It column in the dashboard. 3. You are right, review board does not have the concept of owner as you described. But in my personal opinion, that concept is not very useful. In fact, I would consider the engineer to be the owner of the request always. But that's just me. Hope that helps. -Raghu On Jun 1, 3:04 pm, sailor...@gmail.com sailor...@gmail.com wrote: Hi All, I am new for reviewboard. There are a couple of questions need your help. 1. Is there any page or command to get a summary or statistic from reviewboard? My scenario is like below. Assume my team have 10 engineers, and I would like to sort the code review activity for every guy. such as: - How many times review requests per week by someone? - How many feedback or comments per week by someone? 2. How to know one review request is finished for review? Just by ship it indicator? I almost go through all document and faq in the reviewboard web site, but I am still have no clear idea about the workflow of one code review. Below is my understanding about workflow, please help to correct it. a, engineer post review request and publish b, reviewer add comments and publish c, engineer clarify all reviewer's comments or upload a new diff. d, repeat b and c until reviewer click review and enable ship it. e, This time, I can think this review request is finished, but seems I still be able to add comments or more ship it on this request. 3. How can I know the owner of one review request? I means before engineer publish his request, he will be the owner. after he publish the request to reviewer, reviewer will be the owner. after reviewer publish his comments or ship it, who will be the owner? It seems reviewboard do not tend to have the concept of owner, am I right? Sorry to make so many questions. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Review Board
As Christian pointed out, this is more of a process issue. At my work, we have a similar process. Every developer work on a branch and checks in code to the branch. At some suitable time the code is integrated to the mainline. Checkins to the trunk needs permissions through perforce ACLs. -Raghu On May 12, 12:48 am, Christian Hammond chip...@chipx86.com wrote: Hi Chris, Review Board doesn't have any way of preventing code from being checked in. As H M said, you'll need a pre-commit hook for this. I think there's one onhttp://reviews.review-boardorg/somewhere. At some point we may bundle and document one, but not until we have a solid concept of policy control in the project, and we don't have that today. Updating diffs is a manual process, but post-review makes it a lot easier. Just one command and your review request is created/updated. Some people automate this with a post-commit hook as well, but again, we don't have an official one to recommend at this time. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Mon, May 11, 2009 at 8:03 AM, Chris c.d.whitco...@gmail.com wrote: This discussion was moved from another one that was about windows installs. I was hoping to use review board as such: The main development trunk is stable. We want to add something new, so a developer takes a branch to work in leaving trunk alone. Once the developer is happy with their work then add a review request (this may pass first time or need a few iterations) Once the code gets the ok the developer moves the code from the branch into trunk. My main concerns are the process of adding the diffs is quite manual, can it be automated? Also unless code has been given the OK i dont want it to get into trunk, is this possible? i.e. can we stop people committing to trunk, or is that more something we need to deal with at a people level not an automation level? Cheers, Chris --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review tool
Can you provide the complete output of post-review -d? My first guess would be that it is due to a space in the file path. -Raghu On Apr 13, 10:25 am, roshanpius roshanpiustho...@gmail.com wrote: Hi , I've been using post-review tool for posting reviews for Review Board for a Perforce Repository. I've integrated the post-review tool into P4V which is the GUI P4 Client For Windows. This worked fine till now. But now i've created a new workspace and tried using post-review, but the diff didn't fetch the file from my hard disk. It was fetching the correct file from Repository, but not finding the correct edited file on my Workspace. I ran post-review with -d flag to get the debug logs and i noticed that the path on the Workspace that the diff was trying to fetch was completely wrong: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf Transfer/ ConfigReader.cpp It should have been: diff -urNp c:\docume~1\rpius\locals~1\temp\tmpr_q3cf C:\Unicode\jordan- unicode\host\src\Assisted File Transfer/ConfigReader.cpp I'm using post-review with the following arguments in the P4V Client: python C:\Python26\post-review.py %c --p4-client $c --p4-port $p Do i need to change something in the post-review Configuration for the new workspace ? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Fresh review board never lets me register or do anything...
I don't know about the diffviewer error but can answer other questions. 1. Review board only knows about the code that you submit to it. If you want to see version histories of the file, you need to go to Bazaar. However, if you update the diff as the result of a review comment, they will be shown as revisions in review board. This way a reviewer can easily find what changed between the original review request and the update he just got after the developer incorporated the review comments. 2. Correct. Review will not submit the code in SCM. -Raghu On Apr 9, 12:33 am, Ritesh Nadhani rite...@gmail.com wrote: Hi On Tue, Apr 7, 2009 at 7:17 PM, Christian Hammond chip...@chipx86.com wrote: There's a bug that will be fixed in the next beta where registration is turned off by default yet appears on in the settings. You'll need to log in as the admin user you created during install, go into the admin UI - General Settings, make sure registration is enabled, and hit Save. It should then work. Thanks. I went thru the steps you suggested and it worked. I initially had trouble submitting request but I found out that I need to create some default reviewers. But when I submit a patch and go to View Diff, I get: http://paste.pocoo.org/show/111638/ what can I be doing wrong? Also, I have two questions: 1) One more question before I take a leave. I assume that review board does no show complete diffs from the history and only keep tracks of patches etc submitted thru it. 2) When I review a patch and choose ship it, the code is actually not pushed to the repository. Correct? Thanks, this is looking really great. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Apr 7, 2009 at 6:55 PM, riteshn rite...@gmail.com wrote: Hi This is our first time using the product as we review it if suits our needs. We plan to use it with Bazaar. I got the reviewboard and all the dependencies installed. Copying the modpython conf file to apache sites-available directory and when I go to the browser it shows up too. It is always in the login page and when i click on Register it always reverts back to login page. Thus I am not able to setup the site as suggested at: http://www.mail-archive.com/reviewboard@googlegroups.com/msg01548.html During setup, I chose default authentication. Can somebody tell me what simple mistake I am doing? -- Ritesh -- Riteshhttp://www.riteshn.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Database Archival
First of all let me thank all developers and contributors for this wonderful project. I have been using Reviewboard for the past couple of months in my organization and found this extremely useful. This is a great improvement over an internal tool that we had that helped in generating pretty html diffs, but nothing more. By the way I had few questions on the storage side. 1. Are the screenshots stored in DB? 2. How can I archive old review requests from the DB? Obviously after few months my DB will grow and I may want to archive old review requests from the DB and restore them later. Is there a way to do this? Thanks, Raghu --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
