Re: Review Request 50207: Fix LogSearch Solr 'stop'

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50207/#review142904
---


Ship it!




Ship It!

- Dharmesh Makwana


On July 19, 2016, 11:26 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50207/
> ---
> 
> (Updated July 19, 2016, 11:26 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17801
> https://issues.apache.org/jira/browse/AMBARI-17801
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LogSearch Solr stop function should try to kill the process ( first without, 
> then with -9 ) if sending a stop signal did not work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
>  f033b96 
> 
> Diff: https://reviews.apache.org/r/50207/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster. Imitated error in the stop command by intentinally 
> breaking the syntax of the command.
> 
> python unit tests on ambari-server:
> 
> OK
> --
> Total run:1020
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142903
---


Ship it!




Ship It!

- Nahappan Somasundaram


On July 19, 2016, 7:01 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 19, 2016, 7:01 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142896
---


Ship it!




Ship It!

- Swapan Shridhar


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Matt]

> On July 19, 2016, 2:50 p.m., Lav Jain wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 392
> > 
> >
> > Should config-name be set to hawq_rm_memory_limit_perseg?

In YARN mode, hawq_rm_memory_limit_perseg is invisible. 
We would like to show the users the error that the memory is low regardless of 
which mode it is on. Hence we show the error on hawq_global_rm_type property, 
which is always visible.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142847
---


On July 19, 2016, 4:34 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 

Re: Review Request 50210: Add atlas.authentication.method.kerberos property to conf/atlas-application.properties

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50210/#review142891
---


Ship it!




Ship It!

- Sumit Mohanty


On July 20, 2016, 2:07 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50210/
> ---
> 
> (Updated July 20, 2016, 2:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17803
> https://issues.apache.org/jira/browse/AMBARI-17803
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add atlas.authentication.method.kerberos property to 
> conf/atlas-application.properties for Hive, Storm, Falcon, Sqoop
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  947d441 
> 
> Diff: https://reviews.apache.org/r/50210/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with kerberized and unkerberized cluster.
> Unkerberized cluster:
> atlas.authentication.method.kerberos=False
> 
> Kerberized cluster:
> atlas.authentication.method.kerberos=True
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142890
---


Ship it!




Ship It!

- Sumit Mohanty


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142889
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
258)


Is it ok to store it as " " (with one space) when ATLAS is not present?


- Sumit Mohanty


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 50210: Add atlas.authentication.method.kerberos property to conf/atlas-application.properties

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50210/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-17803
https://issues.apache.org/jira/browse/AMBARI-17803


Repository: ambari


Description
---

Add atlas.authentication.method.kerberos property to 
conf/atlas-application.properties for Hive, Storm, Falcon, Sqoop


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 947d441 

Diff: https://reviews.apache.org/r/50210/diff/


Testing
---

Tested manually with kerberized and unkerberized cluster.
Unkerberized cluster:
atlas.authentication.method.kerberos=False

Kerberized cluster:
atlas.authentication.method.kerberos=True


Thanks,

Ajit Kumar

Re: Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/#review142888
---




ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py (line 
237)


Java and Python logic are now the same and won't repeat the same value 
(unless it's already there more than once).



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 (line 5919)


The diff tool did a really bad job at showing what I moved around. 
Basically, testAtlasHiveProperties2 was moved here with the name 
testAtlasHivePropertiesWithHTTPS


- Alejandro Fernandez


On July 20, 2016, 2:01 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50219/
> ---
> 
> (Updated July 20, 2016, 2:01 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
> Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17802
> https://issues.apache.org/jira/browse/AMBARI-17802
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Install Ambari 2.4
> Blueprint for HDP 2.5 with Atlas and Hive
> Because both Blueprints and Stack Advisor have code to append 
> "org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
> config, the value appears twice.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  36cea56 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> e1bedb7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  268bc29 
> 
> Diff: https://reviews.apache.org/r/50219/diff/
> 
> 
> Testing
> ---
> 
> Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared 
> only once.
> 
> Ran unit tests in BlueprintConfigurationProcessorTest.java
> 
> Python unit tests passed
> --
> Total run:1020
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 50219: Blueprint deployment configures "org.apache.atlas.hive.hook.HiveHook" twice for "hive.exec.post.hooks" config

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50219/
---

Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, Sumit 
Mohanty, and Swapan Shridhar.


Bugs: AMBARI-17802
https://issues.apache.org/jira/browse/AMBARI-17802


Repository: ambari


Description
---

STR:
Install Ambari 2.4
Blueprint for HDP 2.5 with Atlas and Hive
Because both Blueprints and Stack Advisor have code to append 
"org.apache.atlas.hive.hook.HiveHook" to hive-site's "hive.exec.post.hooks" 
config, the value appears twice.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 36cea56 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
e1bedb7 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 268bc29 

Diff: https://reviews.apache.org/r/50219/diff/


Testing
---

Deployed cluster and verified org.apache.atlas.hive.hook.HiveHook appeared only 
once.

Ran unit tests in BlueprintConfigurationProcessorTest.java

Python unit tests passed
--
Total run:1020
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 50207: Fix LogSearch Solr 'stop'

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50207/#review142877
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 19, 2016, 11:26 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50207/
> ---
> 
> (Updated July 19, 2016, 11:26 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17801
> https://issues.apache.org/jira/browse/AMBARI-17801
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LogSearch Solr stop function should try to kill the process ( first without, 
> then with -9 ) if sending a stop signal did not work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
>  f033b96 
> 
> Diff: https://reviews.apache.org/r/50207/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster. Imitated error in the stop command by intentinally 
> breaking the syntax of the command.
> 
> python unit tests on ambari-server:
> 
> OK
> --
> Total run:1020
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 50207: Fix LogSearch Solr 'stop'

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50207/#review142874
---


Ship it!




Ship It!

- Oliver Szabo


On July 19, 2016, 11:26 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50207/
> ---
> 
> (Updated July 19, 2016, 11:26 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, 
> Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17801
> https://issues.apache.org/jira/browse/AMBARI-17801
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LogSearch Solr stop function should try to kill the process ( first without, 
> then with -9 ) if sending a stop signal did not work.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
>  f033b96 
> 
> Diff: https://reviews.apache.org/r/50207/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster. Imitated error in the stop command by intentinally 
> breaking the syntax of the command.
> 
> python unit tests on ambari-server:
> 
> OK
> --
> Total run:1020
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Matt]

> On July 19, 2016, 1:59 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 213
> > 
> >
> > this property has no impact on the logic inside this if, maybe move it 
> > out of the if statement ?

Moved it to another if statement


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142831
---


On July 19, 2016, 4:34 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing 

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Matt]

> On July 19, 2016, 2:50 p.m., Lav Jain wrote:
> > ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py, 
> > line 378
> > 
> >
> > Should line 378 be hosts["items"][2] instead of hosts["items"][3]? Same 
> > for line 390.

They should all be 0,1,3
2 does not have HAWQ components.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142847
---


On July 19, 2016, 4:34 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 4:34 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing 

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/
---

(Updated July 19, 2016, 4:34 p.m.)


Review request for Ambari, Alexander Denissov and Lav Jain.


Bugs: AMBARI-17720
https://issues.apache.org/jira/browse/AMBARI-17720


Repository: ambari


Description
---

When a user is running on vagrant or single node with low system memory, 
configurations are not sufficient to allocate containers for "default" 6 vsegs 
per node especially during HASH dist table query or external table query.

Stack advisor should adjust the config values to ensure service checks and 
queries (including Random tables, HASH dist tables, PXF ext tables) do not fail.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 0bddb07 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
dffe57d 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
4089b75 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
f8a9468 
  ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
7510e5f 

Diff: https://reviews.apache.org/r/50198/diff/


Testing
---

Tested on Live cluster

Added unit tests:
```
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-07-19 12:12:33,669 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-07-19 12:12:33,674 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-07-19 12:12:33,680 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-07-19 12:12:33,686 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 

Review Request 50207: Fix LogSearch Solr 'stop'

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50207/
---

Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, Robert 
Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17801
https://issues.apache.org/jira/browse/AMBARI-17801


Repository: ambari


Description
---

LogSearch Solr stop function should try to kill the process ( first without, 
then with -9 ) if sending a stop signal did not work.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py
 f033b96 

Diff: https://reviews.apache.org/r/50207/diff/


Testing
---

Tested on local cluster. Imitated error in the stop command by intentinally 
breaking the syntax of the command.

python unit tests on ambari-server:

OK
--
Total run:1020
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

[Jungtaek Lim]

> On 7 19, 2016, 7:29 오후, Aravindan Vijayan wrote:
> > Jungtaek, Is the metricName generation logic same for both the legacy and 
> > current version of Storm?
> 
> Sriharsha Chintalapani wrote:
> Aravindan, Given that all these metrics coming in HDP-2.5 storm why are 
> we worried about legacy version. We are not even storing topology level 
> metrics in previous version of storm and I am sure we are not even storing 
> the cluster level.
> 
> Aravindan Vijayan wrote:
> Sriharsha, the reason I asked this is because the patch has the same 
> changes in both legacy and current Storm sinks. Just confirming that this 
> will not cause any issue in clusters with Ambari-2.4.0 and HDP 2.4.

Yes they should be same since there's no change on Storm side for topology 
level metrics.
Btw, Reporter (cluster level metrics) should be different between legacy and 
current.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142812
---


On 7 19, 2016, 6:41 오전, Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated 7 19, 2016, 6:41 오전)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50203: AMS: Deleting ZK data in embedded mode results in external phoenix clients unable to connect on AMS restart

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50203/#review142856
---


Ship it!




Ship It!

- Aravindan Vijayan


On July 19, 2016, 9:18 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50203/
> ---
> 
> (Updated July 19, 2016, 9:18 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17799
> https://issues.apache.org/jira/browse/AMBARI-17799
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMS stack script delete ZK data because when standalone HBase restarts, the 
> ZK data quite frequently gets corrupt and the restart is no longer works. 
> 
> This is because all daemon run inside the same JVM. We had to do this as a 
> workaround after which restart of AMS in embedded mode became reliable
> 
> With HBASE-16244, the standalone mode restart will succeed and we do not need 
> to cleanup zookeeper data
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector
>  f75a8e5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
> 
> Diff: https://reviews.apache.org/r/50203/diff/
> 
> 
> Testing
> ---
> 
> Manually verified
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50178/#review142854
---



Pushed to trunk, commit 1ad5e59687232ae1491fd7bfa316030e347013e2
branch-2.4, commit 5db5de89a9f1841bfc5bca48dbb56b3c00dc6abe

- Alejandro Fernandez


On July 19, 2016, 2:03 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50178/
> ---
> 
> (Updated July 19, 2016, 2:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17783
> https://issues.apache.org/jira/browse/AMBARI-17783
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in 
> Oozie
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 0e455e9 
> 
> Diff: https://reviews.apache.org/r/50178/diff/
> 
> 
> Testing
> ---
> 
> Implemented the changes in stack_advisor and ran a test to make sure the 
> configuration changes for admin user is forced
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142847
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 392)


Should config-name be set to hawq_rm_memory_limit_perseg?



ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
(line 378)


Should line 378 be hosts["items"][2] instead of hosts["items"][3]? Same for 
line 390.


- Lav Jain


On July 19, 2016, 7:15 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource 

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142849
---


Ship it!




Ship It!

- Lav Jain


On July 19, 2016, 7:15 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,669 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management 

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142848
---


Ship it!




Ship It!

- Sriharsha Chintalapani


On July 19, 2016, 6:41 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated July 19, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

[Sriharsha Chintalapani]

> On July 19, 2016, 7:29 p.m., Aravindan Vijayan wrote:
> > Jungtaek, Is the metricName generation logic same for both the legacy and 
> > current version of Storm?

Aravindan, Given that all these metrics coming in HDP-2.5 storm why are we 
worried about legacy version. We are not even storing topology level metrics in 
previous version of storm and I am sure we are not even storing the cluster 
level.


- Sriharsha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142812
---


On July 19, 2016, 6:41 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated July 19, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Review Request 50203: AMS: Deleting ZK data in embedded mode results in external phoenix clients unable to connect on AMS restart

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50203/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-17799
https://issues.apache.org/jira/browse/AMBARI-17799


Repository: ambari


Description
---

AMS stack script delete ZK data because when standalone HBase restarts, the ZK 
data quite frequently gets corrupt and the restart is no longer works. 

This is because all daemon run inside the same JVM. We had to do this as a 
workaround after which restart of AMS in embedded mode became reliable

With HBASE-16244, the standalone mode restart will succeed and we do not need 
to cleanup zookeeper data


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-collector
 f75a8e5 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
 eb1b6d7 

Diff: https://reviews.apache.org/r/50203/diff/


Testing
---

Manually verified


Thanks,

Sid Wagle

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142834
---


Ship it!




Ship It!

- Alexander Denissov


On July 19, 2016, 7:15 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
> Kerberized ... 2016-07-19 12:12:33,669 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 11: HDFS-HA, YARN Resource 

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/#review142831
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 213)


this property has no impact on the logic inside this if, maybe move it out 
of the if statement ?


- Alexander Denissov


On July 19, 2016, 7:15 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50198/
> ---
> 
> (Updated July 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov and Lav Jain.
> 
> 
> Bugs: AMBARI-17720
> https://issues.apache.org/jira/browse/AMBARI-17720
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user is running on vagrant or single node with low system memory, 
> configurations are not sufficient to allocate containers for "default" 6 
> vsegs per node especially during HASH dist table query or external table 
> query.
> 
> Stack advisor should adjust the config values to ensure service checks and 
> queries (including Random tables, HASH dist tables, PXF ext tables) do not 
> fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  0bddb07 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  dffe57d 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> 4089b75 
>   ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
> f8a9468 
>   ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
> 7510e5f 
> 
> Diff: https://reviews.apache.org/r/50198/diff/
> 
> 
> Testing
> ---
> 
> Tested on Live cluster
> 
> Added unit tests:
> ```
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 10: HDFS-HA, 

Re: Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/#review142832
---


Ship it!




Ship It!

- Nate Cole


On July 19, 2016, 4:56 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50196/
> ---
> 
> (Updated July 19, 2016, 4:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-17796
> https://issues.apache.org/jira/browse/AMBARI-17796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a specific issues on an EU downgrade from 2.5 to 2.4. Here's the 
> scenario:
> 
> - Ranger supported "Audit to DB" up to HDP 2.5. It was removed in HDP 2.5. 
> Along with it, the properties in {{admin-properties}} were removed as well.
> - The Ranger {{params.py}} uses the {{check_stack_feature}} to determine if 
> "Audit to DB" is supported and if it is, tries to extract the properties it 
> needs.
> 
> All is well and good at this point. The problem comes when a downgrade 
> happens.
> 
> - When downgrading from 2.5 to 2.4 the 2.4 configurations should be restored. 
> However, this doesn't happen on an EU until after the {{STOP}} command is 
> issued for upgraded services. It's during this {{STOP}} command that we run 
> into an issue. Ranger is running on 2.5, so the 2.5 configurations are sent 
> to stop it. However, the version that we're downgrading to is 2.4, so it 
> thinks that it needs to extract the audit properties.
> 
> - On the {{RESTART}} of Ranger on the downgrade, it should be extracting the 
> audit properties since the 2.4 configurations are sent. But the {{STOP}} 
> command is for 2.5 and doesn't have them. 
> 
> So, this means that {{STOP}} and {{RESTART}} are using different 
> configurations on an EU downgrade. We basically need to create a way to 
> reliably determine which stack version should be used for feature checks.
> 
> ```
> Traceback (most recent call last):
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 199, in 
> RangerAdmin().execute()
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute
> method(env)
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 60, in stop
> import params
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/params.py\",
>  line 176, in 
> audit_jdbc_url = 
> format('jdbc:postgresql://{db_host}/{ranger_auditdb_name}') if 
> stack_supports_ranger_audit_db else None
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 95, in format
> return ConfigurationFormatter().format(format_string, args, **result)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 59, in format
> result_protected = self.vformat(format_string, args, all_params)
>   File \"/usr/lib/python2.7/string.py\", line 549, in vformat
> result = self._vformat(format_string, args, kwargs, used_args, 2)
>   File \"/usr/lib/python2.7/string.py\", line 582, in _vformat
> result.append(self.format_field(obj, format_spec))
>   File \"/usr/lib/python2.7/string.py\", line 599, in format_field
> return format(value, format_spec)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
>  line 73, in __getattr__
> raise Fail(\"Configuration parameter '\" + self.name + \"' was not found 
> in configurations dictionary!\")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'audit_db_name' was not found in configurations dictionary!
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  5db1718 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  5a3c723 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  7d1682d 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  93987be 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f8d588 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  9068b0c 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  ac21b49 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6ff833b 
>   

Re: Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/
---

(Updated July 19, 2016, 4:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.


Changes
---

Caught a problem where STOP commands created from `` are 
_CUSTOM COMMANDS_


Bugs: AMBARI-17796
https://issues.apache.org/jira/browse/AMBARI-17796


Repository: ambari


Description
---

This is a specific issues on an EU downgrade from 2.5 to 2.4. Here's the 
scenario:

- Ranger supported "Audit to DB" up to HDP 2.5. It was removed in HDP 2.5. 
Along with it, the properties in {{admin-properties}} were removed as well.
- The Ranger {{params.py}} uses the {{check_stack_feature}} to determine if 
"Audit to DB" is supported and if it is, tries to extract the properties it 
needs.

All is well and good at this point. The problem comes when a downgrade happens.

- When downgrading from 2.5 to 2.4 the 2.4 configurations should be restored. 
However, this doesn't happen on an EU until after the {{STOP}} command is 
issued for upgraded services. It's during this {{STOP}} command that we run 
into an issue. Ranger is running on 2.5, so the 2.5 configurations are sent to 
stop it. However, the version that we're downgrading to is 2.4, so it thinks 
that it needs to extract the audit properties.

- On the {{RESTART}} of Ranger on the downgrade, it should be extracting the 
audit properties since the 2.4 configurations are sent. But the {{STOP}} 
command is for 2.5 and doesn't have them. 

So, this means that {{STOP}} and {{RESTART}} are using different configurations 
on an EU downgrade. We basically need to create a way to reliably determine 
which stack version should be used for feature checks.

```
Traceback (most recent call last):
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
 line 199, in 
RangerAdmin().execute()
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 280, in execute
method(env)
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
 line 60, in stop
import params
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/params.py\",
 line 176, in 
audit_jdbc_url = 
format('jdbc:postgresql://{db_host}/{ranger_auditdb_name}') if 
stack_supports_ranger_audit_db else None
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
 line 95, in format
return ConfigurationFormatter().format(format_string, args, **result)
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
 line 59, in format
result_protected = self.vformat(format_string, args, all_params)
  File \"/usr/lib/python2.7/string.py\", line 549, in vformat
result = self._vformat(format_string, args, kwargs, used_args, 2)
  File \"/usr/lib/python2.7/string.py\", line 582, in _vformat
result.append(self.format_field(obj, format_spec))
  File \"/usr/lib/python2.7/string.py\", line 599, in format_field
return format(value, format_spec)
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
 line 73, in __getattr__
raise Fail(\"Configuration parameter '\" + self.name + \"' was not found in 
configurations dictionary!\")
resource_management.core.exceptions.Fail: Configuration parameter 
'audit_db_name' was not found in configurations dictionary!
```


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 5db1718 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 5a3c723 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 7d1682d 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 93987be 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 6f8d588 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 9068b0c 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 ac21b49 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 6ff833b 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 6814ca2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 9c6f384 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 b5a4c99 
  ambari-server/src/test/python/TestStackFeature.py PRE-CREATION 

Diff: https://reviews.apache.org/r/50196/diff/


Testing
---

Re: Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/#review142824
---


Ship it!




Ship It!

- Jayush Luniya


On July 19, 2016, 6:36 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50196/
> ---
> 
> (Updated July 19, 2016, 6:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-17796
> https://issues.apache.org/jira/browse/AMBARI-17796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a specific issues on an EU downgrade from 2.5 to 2.4. Here's the 
> scenario:
> 
> - Ranger supported "Audit to DB" up to HDP 2.5. It was removed in HDP 2.5. 
> Along with it, the properties in {{admin-properties}} were removed as well.
> - The Ranger {{params.py}} uses the {{check_stack_feature}} to determine if 
> "Audit to DB" is supported and if it is, tries to extract the properties it 
> needs.
> 
> All is well and good at this point. The problem comes when a downgrade 
> happens.
> 
> - When downgrading from 2.5 to 2.4 the 2.4 configurations should be restored. 
> However, this doesn't happen on an EU until after the {{STOP}} command is 
> issued for upgraded services. It's during this {{STOP}} command that we run 
> into an issue. Ranger is running on 2.5, so the 2.5 configurations are sent 
> to stop it. However, the version that we're downgrading to is 2.4, so it 
> thinks that it needs to extract the audit properties.
> 
> - On the {{RESTART}} of Ranger on the downgrade, it should be extracting the 
> audit properties since the 2.4 configurations are sent. But the {{STOP}} 
> command is for 2.5 and doesn't have them. 
> 
> So, this means that {{STOP}} and {{RESTART}} are using different 
> configurations on an EU downgrade. We basically need to create a way to 
> reliably determine which stack version should be used for feature checks.
> 
> ```
> Traceback (most recent call last):
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 199, in 
> RangerAdmin().execute()
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute
> method(env)
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 60, in stop
> import params
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/params.py\",
>  line 176, in 
> audit_jdbc_url = 
> format('jdbc:postgresql://{db_host}/{ranger_auditdb_name}') if 
> stack_supports_ranger_audit_db else None
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 95, in format
> return ConfigurationFormatter().format(format_string, args, **result)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 59, in format
> result_protected = self.vformat(format_string, args, all_params)
>   File \"/usr/lib/python2.7/string.py\", line 549, in vformat
> result = self._vformat(format_string, args, kwargs, used_args, 2)
>   File \"/usr/lib/python2.7/string.py\", line 582, in _vformat
> result.append(self.format_field(obj, format_spec))
>   File \"/usr/lib/python2.7/string.py\", line 599, in format_field
> return format(value, format_spec)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
>  line 73, in __getattr__
> raise Fail(\"Configuration parameter '\" + self.name + \"' was not found 
> in configurations dictionary!\")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'audit_db_name' was not found in configurations dictionary!
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  5db1718 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  5a3c723 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  7d1682d 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  93987be 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f8d588 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  9068b0c 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  ac21b49 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6ff833b 

Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

[Jayush Luniya]

> On July 19, 2016, 12:05 p.m., Tim Thorpe wrote:
> > I really like the ability to add new repos.  I'm not so certain we need 
> > another way of adding services to an existing stack.
> > 
> > Jayush and I already added new code to allow Ambari to add new stacks, 
> > extensions and custom services - see AMBARI_15663.
> > 
> > https://issues.apache.org/jira/browse/AMBARI-15663
> > 
> > A custom service can be added via extension-definitions or 
> > stack-addon-service-definitions management packs.  
> > 
> > I understand that this mechanism is a simple and quick way to add HAWQ and 
> > PXF.  Unfortunately this script only works for those custom services which 
> > are actually part of Ambari's common-services.  Ideally the ability to add 
> > new repos would be done in a separate script to allow it to be used when 
> > adding extension-definitions or stack-addon-service-definitions management 
> > packs.

Agree with Tim. Management packs should be the release vehicle for stacks and 
custom services.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/#review142730
---


On July 18, 2016, 8:51 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50087/
> ---
> 
> (Updated July 18, 2016, 8:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-17717
> https://issues.apache.org/jira/browse/AMBARI-17717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should have a script that users can run to add a custom service and 
> repository to the stack or an existing cluster.
> 
> ```
> Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
> Usage: add_common_service.py [options]
> 
> Options:
>   -h, --helpshow this help message and exit
>   -u USER, --user=USER  Ambari login username (Required)
>   -p PASSWORD, --password=PASSWORD
> Ambari login password. Providing password through
> command line is not recommended. The script prompts
> for the password.
>   -t STACK, --stack=STACK
> Stack Name and Version to be added (Required).(Eg:
> HDP-2.4 or HDP-2.5)
>   -s SERVICE, --service=SERVICE
> Service Name and Version to be added.(Eg: HAWQ/2.0.0
> or PXF/3.0.0)
>   -r REPOURL, --repourl=REPOURL
> Repository URL which points to the rpm packages
>   -i REPOID, --repoid=REPOID
> Repository ID of the new repository
>   -o OSTYPE, --ostype=OSTYPE
> OS for the new repository (Eg: redhat6)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50087/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with various combinations
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

[Anita Jebaraj]

> On July 18, 2016, 10:58 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 18
> > 
> >
> > This is redundant...
> > 
> > `kafka-broker/listeners` = `kafka-broker/listeners`
> 
> Anita Jebaraj wrote:
> Hi Robert, I had to include the declaration for listeners in 
> kerberos.json since the value for listeners wont be displayed in the UI under 
> the kerberos configuration otherwise. There is a change in value for protocol 
> for listeners in specific cases (if the user hasn't added a listener with 
> PLAINTEXTSASL protocol) and I thought it would be appropriate to include it 
> in kerberos.json, even though the handling is done in the stack-advisor.py
> 
> Robert Levas wrote:
> In this case, maybe it is better to do
> 
> ```
> "listeners": ""
> ```
> 
> Else you may wind up with `kafka-broker/listeners` being set to 
> `${kafka-broker/listeners}` (literally).

I am not sure if assigning an empty value for listeners in kerberos.json is the 
right approach, I am thinking if using functions similar to each() in 
templeton.hive.properties in VariableReplacementHelper.java would work out for 
this scenario. May be creating a function replace() for listeners will help, it 
can be {kafka-broker/listeners|replace()}. Please give me your suggestion on 
this.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
---


On July 14, 2016, 9:08 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 14, 2016, 9:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  33275f9 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 2a2a3a3 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> a6baeea 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50201: HiveServer port config change is missing in HDP-2.4 Upgrade Pack

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50201/#review142819
---


Ship it!




Ship It!

- Jonathan Hurley


On July 19, 2016, 3:47 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50201/
> ---
> 
> (Updated July 19, 2016, 3:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17797
> https://issues.apache.org/jira/browse/AMBARI-17797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP-2.4 -> HDP-2.5 upgrade pack is missing the config port change for 
> HiveServer2
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 49ff6da 
> 
> Diff: https://reviews.apache.org/r/50201/diff/
> 
> 
> Testing
> ---
> 
> Manual only.  No automated test for UP changes.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50178/#review142818
---


Ship it!




Please take care of upgrade issue as Alejandro pointed out in separate bug.

- Swapan Shridhar


On July 19, 2016, 2:03 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50178/
> ---
> 
> (Updated July 19, 2016, 2:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17783
> https://issues.apache.org/jira/browse/AMBARI-17783
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in 
> Oozie
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 0e455e9 
> 
> Diff: https://reviews.apache.org/r/50178/diff/
> 
> 
> Testing
> ---
> 
> Implemented the changes in stack_advisor and ran a test to make sure the 
> configuration changes for admin user is forced
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 50201: HiveServer port config change is missing in HDP-2.4 Upgrade Pack

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50201/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17797
https://issues.apache.org/jira/browse/AMBARI-17797


Repository: ambari


Description
---

HDP-2.4 -> HDP-2.5 upgrade pack is missing the config port change for 
HiveServer2


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
49ff6da 

Diff: https://reviews.apache.org/r/50201/diff/


Testing
---

Manual only.  No automated test for UP changes.


Thanks,

Nate Cole

Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

[Venkat Ranganathan]

> On July 19, 2016, 11:01 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 35
> > 
> >
> > This will affect only a brand new cluster install.
> > For a stack upgrade to HDP 2.5, do we need to make a similar change?

Yes,  we need to take care of RU/EU. But we will either have to hardcode the 
values in upgrade configs or do custom code.   Will create a new bug to track 
this


- Venkat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50178/#review142779
---


On July 18, 2016, 7:03 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50178/
> ---
> 
> (Updated July 18, 2016, 7:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17783
> https://issues.apache.org/jira/browse/AMBARI-17783
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in 
> Oozie
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 0e455e9 
> 
> Diff: https://reviews.apache.org/r/50178/diff/
> 
> 
> Testing
> ---
> 
> Implemented the changes in stack_advisor and ran a test to make sure the 
> configuration changes for admin user is forced
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/#review142812
---



Jungtaek, Is the metricName generation logic same for both the legacy and 
current version of Storm?

- Aravindan Vijayan


On July 19, 2016, 6:41 a.m., Jungtaek Lim wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50180/
> ---
> 
> (Updated July 19, 2016, 6:41 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-17784
> https://issues.apache.org/jira/browse/AMBARI-17784
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is follow-up issue for AMBARI-17725.
> 
> After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
> which makes us possible to topology name and component name as variables for 
> templatized dashboard.
> 
> But kafkaOffset metrics still have kafka topic and partition information to 
> middle of metric name which make us hard to pick. Since worker host and 
> worker port, and task id is not needed for kafkaOffset metrics, we can get 
> rid of those things from only kafkaOffset metrics.
> 
> > topology level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag
> 
> > partition level
> 
> * Before applying: topology.kafka-topology.kafka-spout. host>.6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
> * After applying: 
> topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  9e6cc98 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  271c11f 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  dcc3192 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  c76197b 
> 
> Diff: https://reviews.apache.org/r/50180/diff/
> 
> 
> Testing
> ---
> 
> * Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
> * Tested manually
> 
> 
> Thanks,
> 
> Jungtaek Lim
> 
>

Re: Review Request 50198: HAWQ fails to execute queries in low-memory environment

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50198/
---

(Updated July 19, 2016, 12:15 p.m.)


Review request for Ambari, Alexander Denissov and Lav Jain.


Changes
---

Remove unused import


Bugs: AMBARI-17720
https://issues.apache.org/jira/browse/AMBARI-17720


Repository: ambari


Description
---

When a user is running on vagrant or single node with low system memory, 
configurations are not sufficient to allocate containers for "default" 6 vsegs 
per node especially during HASH dist table query or external table query.

Stack advisor should adjust the config values to ensure service checks and 
queries (including Random tables, HASH dist tables, PXF ext tables) do not fail.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
 0bddb07 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
dffe57d 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
4089b75 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
f8a9468 
  ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
7510e5f 

Diff: https://reviews.apache.org/r/50198/diff/


Testing
---

Tested on Live cluster

Added unit tests:
```
test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-07-19 12:12:33,657 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-07-19 12:12:33,660 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-07-19 12:12:33,663 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-07-19 12:12:33,669 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-07-19 12:12:33,674 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-07-19 12:12:33,680 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-07-19 12:12:33,686 - Executing HAWQ Check ...
ok

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

[Robert Levas]

> On July 18, 2016, 6:58 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 18
> > 
> >
> > This is redundant...
> > 
> > `kafka-broker/listeners` = `kafka-broker/listeners`
> 
> Anita Jebaraj wrote:
> Hi Robert, I had to include the declaration for listeners in 
> kerberos.json since the value for listeners wont be displayed in the UI under 
> the kerberos configuration otherwise. There is a change in value for protocol 
> for listeners in specific cases (if the user hasn't added a listener with 
> PLAINTEXTSASL protocol) and I thought it would be appropriate to include it 
> in kerberos.json, even though the handling is done in the stack-advisor.py

In this case, maybe it is better to do

```
"listeners": ""
```

Else you may wind up with `kafka-broker/listeners` being set to 
`${kafka-broker/listeners}` (literally).


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
---


On July 14, 2016, 5:08 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 14, 2016, 5:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  33275f9 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 2a2a3a3 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> a6baeea 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

[Anita Jebaraj]

> On July 18, 2016, 10:58 a.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json, 
> > line 18
> > 
> >
> > This is redundant...
> > 
> > `kafka-broker/listeners` = `kafka-broker/listeners`

Hi Robert, I had to include the declaration for listeners in kerberos.json 
since the value for listeners wont be displayed in the UI under the kerberos 
configuration otherwise. There is a change in value for protocol for listeners 
in specific cases (if the user hasn't added a listener with PLAINTEXTSASL 
protocol) and I thought it would be appropriate to include it in kerberos.json, 
even though the handling is done in the stack-advisor.py


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
---


On July 14, 2016, 9:08 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 14, 2016, 9:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  33275f9 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 2a2a3a3 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> a6baeea 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50165/#review142796
---


Ship it!




Ship It!

- Richard Zang


On July 18, 2016, 10:20 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50165/
> ---
> 
> (Updated July 18, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-1
> https://issues.apache.org/jira/browse/AMBARI-1
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> # Go to SelectVersion page
> # Clear any input with Base URL (for ex. ubuntu14)
> # Click on next button
> 
> Expected: input has now red borders and warning message appears below 
> "Attention: All repo URLs are required before you can proceed."
> 
> Actually: Next button became to disabled state. Next page wasn't loaded.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/installer.js 037e555 
>   ambari-web/app/models/operating_system.js c2588fe 
> 
> Diff: https://reviews.apache.org/r/50165/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 29285 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/#review142792
---


Ship it!




Ship It!

- Nate Cole


On July 19, 2016, 2:36 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50196/
> ---
> 
> (Updated July 19, 2016, 2:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-17796
> https://issues.apache.org/jira/browse/AMBARI-17796
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a specific issues on an EU downgrade from 2.5 to 2.4. Here's the 
> scenario:
> 
> - Ranger supported "Audit to DB" up to HDP 2.5. It was removed in HDP 2.5. 
> Along with it, the properties in {{admin-properties}} were removed as well.
> - The Ranger {{params.py}} uses the {{check_stack_feature}} to determine if 
> "Audit to DB" is supported and if it is, tries to extract the properties it 
> needs.
> 
> All is well and good at this point. The problem comes when a downgrade 
> happens.
> 
> - When downgrading from 2.5 to 2.4 the 2.4 configurations should be restored. 
> However, this doesn't happen on an EU until after the {{STOP}} command is 
> issued for upgraded services. It's during this {{STOP}} command that we run 
> into an issue. Ranger is running on 2.5, so the 2.5 configurations are sent 
> to stop it. However, the version that we're downgrading to is 2.4, so it 
> thinks that it needs to extract the audit properties.
> 
> - On the {{RESTART}} of Ranger on the downgrade, it should be extracting the 
> audit properties since the 2.4 configurations are sent. But the {{STOP}} 
> command is for 2.5 and doesn't have them. 
> 
> So, this means that {{STOP}} and {{RESTART}} are using different 
> configurations on an EU downgrade. We basically need to create a way to 
> reliably determine which stack version should be used for feature checks.
> 
> ```
> Traceback (most recent call last):
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 199, in 
> RangerAdmin().execute()
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute
> method(env)
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
>  line 60, in stop
> import params
>   File 
> \"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/params.py\",
>  line 176, in 
> audit_jdbc_url = 
> format('jdbc:postgresql://{db_host}/{ranger_auditdb_name}') if 
> stack_supports_ranger_audit_db else None
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 95, in format
> return ConfigurationFormatter().format(format_string, args, **result)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
>  line 59, in format
> result_protected = self.vformat(format_string, args, all_params)
>   File \"/usr/lib/python2.7/string.py\", line 549, in vformat
> result = self._vformat(format_string, args, kwargs, used_args, 2)
>   File \"/usr/lib/python2.7/string.py\", line 582, in _vformat
> result.append(self.format_field(obj, format_spec))
>   File \"/usr/lib/python2.7/string.py\", line 599, in format_field
> return format(value, format_spec)
>   File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
>  line 73, in __getattr__
> raise Fail(\"Configuration parameter '\" + self.name + \"' was not found 
> in configurations dictionary!\")
> resource_management.core.exceptions.Fail: Configuration parameter 
> 'audit_db_name' was not found in configurations dictionary!
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  5db1718 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  5a3c723 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  7d1682d 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  93987be 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f8d588 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  9068b0c 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  ac21b49 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  6ff833b 
>   

Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50196/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Nate Cole.


Bugs: AMBARI-17796
https://issues.apache.org/jira/browse/AMBARI-17796


Repository: ambari


Description
---

This is a specific issues on an EU downgrade from 2.5 to 2.4. Here's the 
scenario:

- Ranger supported "Audit to DB" up to HDP 2.5. It was removed in HDP 2.5. 
Along with it, the properties in {{admin-properties}} were removed as well.
- The Ranger {{params.py}} uses the {{check_stack_feature}} to determine if 
"Audit to DB" is supported and if it is, tries to extract the properties it 
needs.

All is well and good at this point. The problem comes when a downgrade happens.

- When downgrading from 2.5 to 2.4 the 2.4 configurations should be restored. 
However, this doesn't happen on an EU until after the {{STOP}} command is 
issued for upgraded services. It's during this {{STOP}} command that we run 
into an issue. Ranger is running on 2.5, so the 2.5 configurations are sent to 
stop it. However, the version that we're downgrading to is 2.4, so it thinks 
that it needs to extract the audit properties.

- On the {{RESTART}} of Ranger on the downgrade, it should be extracting the 
audit properties since the 2.4 configurations are sent. But the {{STOP}} 
command is for 2.5 and doesn't have them. 

So, this means that {{STOP}} and {{RESTART}} are using different configurations 
on an EU downgrade. We basically need to create a way to reliably determine 
which stack version should be used for feature checks.

```
Traceback (most recent call last):
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
 line 199, in 
RangerAdmin().execute()
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 280, in execute
method(env)
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py\",
 line 60, in stop
import params
  File 
\"/var/lib/ambari-agent/cache/common-services/RANGER/0.4.0/package/scripts/params.py\",
 line 176, in 
audit_jdbc_url = 
format('jdbc:postgresql://{db_host}/{ranger_auditdb_name}') if 
stack_supports_ranger_audit_db else None
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
 line 95, in format
return ConfigurationFormatter().format(format_string, args, **result)
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/format.py\",
 line 59, in format
result_protected = self.vformat(format_string, args, all_params)
  File \"/usr/lib/python2.7/string.py\", line 549, in vformat
result = self._vformat(format_string, args, kwargs, used_args, 2)
  File \"/usr/lib/python2.7/string.py\", line 582, in _vformat
result.append(self.format_field(obj, format_spec))
  File \"/usr/lib/python2.7/string.py\", line 599, in format_field
return format(value, format_spec)
  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/config_dictionary.py\",
 line 73, in __getattr__
raise Fail(\"Configuration parameter '\" + self.name + \"' was not found in 
configurations dictionary!\")
resource_management.core.exceptions.Fail: Configuration parameter 
'audit_db_name' was not found in configurations dictionary!
```


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 5db1718 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 5a3c723 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 7d1682d 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 93987be 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 6f8d588 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 9068b0c 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 ac21b49 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 6ff833b 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 6814ca2 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 9c6f384 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 b5a4c99 
  ambari-server/src/test/python/TestStackFeature.py PRE-CREATION 

Diff: https://reviews.apache.org/r/50196/diff/


Testing
---

--
Total run:1025
Total errors:0
Total failures:0
OK


Thanks,

Jonathan 

Re: Review Request 50169: Atlas hooks for Hive, Falcon, Storm missing atlas.jaas.KafkaClient.option.principal & atlas.jaas.KafkaClient.option.keytab

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50169/#review142781
---


Ship it!




Ship It!

- Robert Levas


On July 19, 2016, 1:50 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50169/
> ---
> 
> (Updated July 19, 2016, 1:50 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Jaimin Jetly, Robert Levas, 
> Nahappan Somasundaram, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17780
> https://issues.apache.org/jira/browse/AMBARI-17780
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In HDP 2.5, the following config files are missing two properties when the 
> cluster is Kerberized.
> 
> Files:
> hive-atlas-application.properties
> storm-atlas-application.properties
> falconm-atlas-application.properties
> 
> Properties:
> atlas.jaas.KafkaClient.option.principal
> atlas.jaas.KafkaClient.option.keytab
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
>  947d441 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  939e232 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  e4d2392 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py
>  f2d01fc 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  6f8d588 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
>  5bca720 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  591e548 
>   ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
> 5a9f24c 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 6081a04 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> b5ec1c9 
> 
> Diff: https://reviews.apache.org/r/50169/diff/
> 
> 
> Testing
> ---
> 
> Verified with HDP 2.5 and Kerberizing the cluster with Atlas, Storm, Hive, 
> Falcon, Sqoop
> 
> Python unit tests passed,
> Total run:1019
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50178/#review142779
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
35)


This will affect only a brand new cluster install.
For a stack upgrade to HDP 2.5, do we need to make a similar change?


- Alejandro Fernandez


On July 19, 2016, 2:03 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50178/
> ---
> 
> (Updated July 19, 2016, 2:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17783
> https://issues.apache.org/jira/browse/AMBARI-17783
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in 
> Oozie
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 0e455e9 
> 
> Diff: https://reviews.apache.org/r/50178/diff/
> 
> 
> Testing
> ---
> 
> Implemented the changes in stack_advisor and ran a test to make sure the 
> configuration changes for admin user is forced
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 50195: Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50195/#review142777
---


Ship it!




Ship It!

- Alejandro Fernandez


On July 19, 2016, 5:38 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50195/
> ---
> 
> (Updated July 19, 2016, 5:38 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17794
> https://issues.apache.org/jira/browse/AMBARI-17794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version
> 2) Enable distributed mode for AMS
> 3) Make ambari only upgrade
> 
> Actual result:
> Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0
> {code}
> stderr:   /var/lib/ambari-agent/data/errors-2079.txt
> 
> Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 215, in 
> OozieServer().execute()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 95, in start
> oozie_service(action='start', upgrade_type=upgrade_type)
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
>  line 96, in oozie_service
> os.chmod(params.check_db_connection_jar, 0o755)
> OSError: [Errno 1] Operation not permitted: 
> '/usr/lib/ambari-agent/DBConnectionVerification.jar'
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  0713c97 
> 
> Diff: https://reviews.apache.org/r/50195/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> checking on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50195: Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50195/#review142772
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Липень 19, 2016, 8:38 після полудня, Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50195/
> ---
> 
> (Updated Липень 19, 2016, 8:38 після полудня)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17794
> https://issues.apache.org/jira/browse/AMBARI-17794
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version
> 2) Enable distributed mode for AMS
> 3) Make ambari only upgrade
> 
> Actual result:
> Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0
> {code}
> stderr:   /var/lib/ambari-agent/data/errors-2079.txt
> 
> Traceback (most recent call last):
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 215, in 
> OozieServer().execute()
> File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
>  line 95, in start
> oozie_service(action='start', upgrade_type=upgrade_type)
> File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
> File 
> "/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
>  line 96, in oozie_service
> os.chmod(params.check_db_connection_jar, 0o755)
> OSError: [Errno 1] Operation not permitted: 
> '/usr/lib/ambari-agent/DBConnectionVerification.jar'
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  0713c97 
> 
> Diff: https://reviews.apache.org/r/50195/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> checking on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 50195: Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50195/
---

Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.


Bugs: AMBARI-17794
https://issues.apache.org/jira/browse/AMBARI-17794


Repository: ambari


Description
---

STR:
1) Install old version
2) Enable distributed mode for AMS
3) Make ambari only upgrade

Actual result:
Oozie Server Start is failed after upgrade from 2.2.2.0 to 2.4.0.0
{code}
stderr:   /var/lib/ambari-agent/data/errors-2079.txt

Traceback (most recent call last):
File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
 line 215, in 
OozieServer().execute()
File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 280, in execute
method(env)
File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py",
 line 95, in start
oozie_service(action='start', upgrade_type=upgrade_type)
File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", line 
89, in thunk
return fn(*args, **kwargs)
File 
"/var/lib/ambari-agent/cache/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py",
 line 96, in oozie_service
os.chmod(params.check_db_connection_jar, 0o755)
OSError: [Errno 1] Operation not permitted: 
'/usr/lib/ambari-agent/DBConnectionVerification.jar'
{code}


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 0713c97 

Diff: https://reviews.apache.org/r/50195/diff/


Testing
---

mvn clean test

checking on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 50191: Spark service check fails on node with stopped Livy server

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50191/
---

(Updated Июль 19, 2016, 4:53 п.п.)


Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.


Bugs: AMBARI-17791
https://issues.apache.org/jira/browse/AMBARI-17791


Repository: ambari


Description
---

Spark Livy should be started after ATS. Spark service check should check any 
started Livy API


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 227791a 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 297761e 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
40e8ff8 

Diff: https://reviews.apache.org/r/50191/diff/


Testing (updated)
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [13.666s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Views .. SUCCESS [4.685s]
[INFO] ambari-metrics  SUCCESS [0.799s]
[INFO] Ambari Metrics Common . SUCCESS [0.960s]
[INFO] Ambari Server . SUCCESS [1:22.035s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Re: Review Request 50191: Spark service check fails on node with stopped Livy server

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50191/#review142761
---


Ship it!




Ship It!

- Dmytro Grinenko


On July 19, 2016, 4:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50191/
> ---
> 
> (Updated July 19, 2016, 4:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17791
> https://issues.apache.org/jira/browse/AMBARI-17791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark Livy should be started after ATS. Spark service check should check any 
> started Livy API
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  227791a 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  297761e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 40e8ff8 
> 
> Diff: https://reviews.apache.org/r/50191/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50191: Spark service check fails on node with stopped Livy server

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50191/#review142760
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 19, 2016, 7:15 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50191/
> ---
> 
> (Updated July 19, 2016, 7:15 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17791
> https://issues.apache.org/jira/browse/AMBARI-17791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark Livy should be started after ATS. Spark service check should check any 
> started Livy API
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  227791a 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  297761e 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> 40e8ff8 
> 
> Diff: https://reviews.apache.org/r/50191/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142757
---


Ship it!




Ship It!

- Sid Wagle


On July 19, 2016, 10:54 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 19, 2016, 10:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 51435fe 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  9d2fea5 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

[Gautam Borad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/
---

(Updated July 19, 2016, 3:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Address Jonathan's review comments


Bugs: AMBARI-17771
https://issues.apache.org/jira/browse/AMBARI-17771


Repository: ambari


Description
---

Update alert definition URI after stack is updated.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7d9615568fb3ef02ded4816c02959c882ce43f50 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
964ec3f649cec538af7865aacf51f5c0e18230a4 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 c82e938b7f285107980bdda4efac095e267d3530 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
49ff6da745821e6314dc62ef0bcee78f328460a0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50140/diff/


Testing
---

Tested on a centos 6 cluster after upgrade and checked that the alert works 
fine for Ranger Admin.


Thanks,

Gautam Borad

Re: Review Request 50069: Docker based dev environment for Log Search

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/
---

(Updated July 19, 2016, 3:04 p.m.)


Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.


Changes
---

- cleanup


Bugs: AMBARI-17723
https://issues.apache.org/jira/browse/AMBARI-17723


Repository: ambari


Description
---

Add abillity to setup a qucik dev env for docker with debug capabilities.
Goals:
- setup an env quickly without Ambari (logsearch + logfeeder + solr)
- later create integration test framework based on that (junit/jbehave managed 
containers, pinging solr for results etc.)


Diffs (updated)
-

  ambari-logsearch/README.md 04fdf2f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 15dd5c9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 43d908e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
  ambari-logsearch/docker/.gitignore PRE-CREATION 
  ambari-logsearch/docker/Dockerfile PRE-CREATION 
  ambari-logsearch/docker/bin/start.sh PRE-CREATION 
  ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
  ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
PRE-CREATION 
  ambari-logsearch/pom.xml 81da0f2 

Diff: https://reviews.apache.org/r/50069/diff/


Testing
---

>From Apache jenkins:
++1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in 
ambari-logsearch/ambari-logsearch-logfeeder 
ambari-logsearch/ambari-logsearch-portal.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
This message is automatically generated.


Thanks,

Oliver Szabo

Re: Review Request 50069: Docker based dev environment for Log Search

[Oliver Szabo]

> On July 19, 2016, 12:50 p.m., Nate Cole wrote:
> > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java,
> >  lines 401-403
> > 
> >
> > This entire class needs javadoc

a lot more class needs it, also we need to add much more unit tests. we took 
over the code mostly like this one. we have already planned a lots of 
refactoring in 2.5.0 (it needs it..logsearch-portal also), so we are already 
noticed this kind of issues (mostly testing, better javadoc, also some unneeded 
utils code, which can be replaced with some guava function etc.)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/#review142743
---


On July 19, 2016, 11:23 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50069/
> ---
> 
> (Updated July 19, 2016, 11:23 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
> Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17723
> https://issues.apache.org/jira/browse/AMBARI-17723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abillity to setup a qucik dev env for docker with debug capabilities.
> Goals:
> - setup an env quickly without Ambari (logsearch + logfeeder + solr)
> - later create integration test framework based on that (junit/jbehave 
> managed containers, pinging solr for results etc.)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 04fdf2f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  15dd5c9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  43d908e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
>   ambari-logsearch/docker/.gitignore PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile PRE-CREATION 
>   ambari-logsearch/docker/bin/start.sh PRE-CREATION 
>   ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/pom.xml 81da0f2 
> 
> Diff: https://reviews.apache.org/r/50069/diff/
> 
> 
> Testing
> ---
> 
> From Apache jenkins:
> ++1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 16 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-logsearch/ambari-logsearch-logfeeder 
> ambari-logsearch/ambari-logsearch-portal.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
> Console output: 
> 

Re: Review Request 50069: Docker based dev environment for Log Search

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/#review142743
---


Ship it!





ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 (lines 401 - 403)


This entire class needs javadoc


- Nate Cole


On July 19, 2016, 7:23 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50069/
> ---
> 
> (Updated July 19, 2016, 7:23 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
> Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17723
> https://issues.apache.org/jira/browse/AMBARI-17723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abillity to setup a qucik dev env for docker with debug capabilities.
> Goals:
> - setup an env quickly without Ambari (logsearch + logfeeder + solr)
> - later create integration test framework based on that (junit/jbehave 
> managed containers, pinging solr for results etc.)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 04fdf2f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  15dd5c9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  43d908e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
>   ambari-logsearch/docker/.gitignore PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile PRE-CREATION 
>   ambari-logsearch/docker/bin/start.sh PRE-CREATION 
>   ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/pom.xml 81da0f2 
> 
> Diff: https://reviews.apache.org/r/50069/diff/
> 
> 
> Testing
> ---
> 
> From Apache jenkins:
> ++1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 16 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-logsearch/ambari-logsearch-logfeeder 
> ambari-logsearch/ambari-logsearch-portal.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 50069: Docker based dev environment for Log Search

[Nate Cole]

> On July 15, 2016, 3:08 p.m., Nate Cole wrote:
> > ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.log, lines 
> > 1-3
> > 
> >
> > Checking in a log file?
> 
> Oliver Szabo wrote:
> That is a test file for log processing. I would like to extends the log 
> examples later (so add much more to validate log parsing is work on the 
> examples). I could rename them to .txt if it can confuse others

No need - I was only getting clarification why a log file was getting checked 
in.


> On July 15, 2016, 3:08 p.m., Nate Cole wrote:
> > ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json, line 1
> > 
> >
> > formatting required (it's only a test file, but still)
> 
> Oliver Szabo wrote:
> logsearch-test-log.json is also a log file in json format (its easier to 
> process for logfeeder), we have a specific appender to generate json log 
> files. Currently these are processed per lines, so that is the reason why its 
> not formatted. (that is how the custom appened generates them, but of course 
> later we can fix that behavior)

LogFeeder should work the same whether it's formatted or not.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/#review142389
---


On July 19, 2016, 7:23 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50069/
> ---
> 
> (Updated July 19, 2016, 7:23 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
> Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17723
> https://issues.apache.org/jira/browse/AMBARI-17723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abillity to setup a qucik dev env for docker with debug capabilities.
> Goals:
> - setup an env quickly without Ambari (logsearch + logfeeder + solr)
> - later create integration test framework based on that (junit/jbehave 
> managed containers, pinging solr for results etc.)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 04fdf2f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  15dd5c9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  43d908e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
>   ambari-logsearch/docker/.gitignore PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile PRE-CREATION 
>   ambari-logsearch/docker/bin/start.sh PRE-CREATION 
>   ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/pom.xml 81da0f2 
> 
> Diff: https://reviews.apache.org/r/50069/diff/
> 
> 
> Testing
> ---
> 
> From Apache jenkins:
> ++1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
> 

Re: Review Request 50185: [AMBARI-17786] Enable csrf protection and add superuser in livy

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50185/
---

(Updated July 19, 2016, 12:22 p.m.)


Review request for Ambari and Sumit Mohanty.


Summary (updated)
-

[AMBARI-17786] Enable csrf protection and add superuser in livy


Bugs: AMBARI-17786
https://issues.apache.org/jira/browse/AMBARI-17786


Repository: ambari


Description
---

Just a minor configuration change for livy


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 7d3c78f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
e479354 

Diff: https://reviews.apache.org/r/50185/diff/


Testing
---

No test is needed. Just a minor configburation change.


Thanks,

Jeff Zhang

Re: Review Request 50185: [AMBARI-17786] Enable csrf protection and add superuser

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50185/
---

(Updated July 19, 2016, 12:20 p.m.)


Review request for Ambari and Sumit Mohanty.


Summary (updated)
-

[AMBARI-17786] Enable csrf protection and add superuser


Bugs: AMBARI-17786
https://issues.apache.org/jira/browse/AMBARI-17786


Repository: ambari


Description
---

Just a minor configuration change for livy


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 7d3c78f 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
e479354 

Diff: https://reviews.apache.org/r/50185/diff/


Testing (updated)
---

No test is needed. Just a minor configburation change.


Thanks,

Jeff Zhang

Re: Review Request 50189: Getting error while executing query for adding udf jar

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50189/#review142737
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On July 19, 2016, 12:13 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50189/
> ---
> 
> (Updated July 19, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17727
> https://issues.apache.org/jira/browse/AMBARI-17727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed comment of --Global Settings-- from
>  query and corrected addition of semi colon at end
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  d68d82e 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js
>  df135d3 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
> bbe42cf 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 72f717d 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> df135d3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
> cf87c9d 
> 
> Diff: https://reviews.apache.org/r/50189/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50189: Getting error while executing query for adding udf jar

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50189/#review142736
---


Ship it!




Ship It!

- Gaurav Nagar


On July 19, 2016, 12:13 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50189/
> ---
> 
> (Updated July 19, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17727
> https://issues.apache.org/jira/browse/AMBARI-17727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed comment of --Global Settings-- from
>  query and corrected addition of semi colon at end
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  d68d82e 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js
>  df135d3 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
> bbe42cf 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 72f717d 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> df135d3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
> cf87c9d 
> 
> Diff: https://reviews.apache.org/r/50189/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50189: Getting error while executing query for adding udf jar

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50189/#review142735
---


Ship it!




Ship It!

- Ashwin Rajeev


On July 19, 2016, 12:13 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50189/
> ---
> 
> (Updated July 19, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17727
> https://issues.apache.org/jira/browse/AMBARI-17727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed comment of --Global Settings-- from
>  query and corrected addition of semi colon at end
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js
>  d68d82e 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js
>  df135d3 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
> bbe42cf 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 72f717d 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> df135d3 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
> cf87c9d 
> 
> Diff: https://reviews.apache.org/r/50189/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 50189: Getting error while executing query for adding udf jar

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50189/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17727
https://issues.apache.org/jira/browse/AMBARI-17727


Repository: ambari


Description
---

removed comment of --Global Settings-- from
 query and corrected addition of semi colon at end


Diffs
-

  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js 
d68d82e 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js 
df135d3 
  contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js 
bbe42cf 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
72f717d 
  contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
df135d3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
cf87c9d 

Diff: https://reviews.apache.org/r/50189/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/#review142730
---



I really like the ability to add new repos.  I'm not so certain we need another 
way of adding services to an existing stack.

Jayush and I already added new code to allow Ambari to add new stacks, 
extensions and custom services - see AMBARI_15663.

https://issues.apache.org/jira/browse/AMBARI-15663

A custom service can be added via extension-definitions or 
stack-addon-service-definitions management packs.  

I understand that this mechanism is a simple and quick way to add HAWQ and PXF. 
 Unfortunately this script only works for those custom services which are 
actually part of Ambari's common-services.  Ideally the ability to add new 
repos would be done in a separate script to allow it to be used when adding 
extension-definitions or stack-addon-service-definitions management packs.

- Tim Thorpe


On July 18, 2016, 8:51 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50087/
> ---
> 
> (Updated July 18, 2016, 8:51 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
> Thorpe.
> 
> 
> Bugs: AMBARI-17717
> https://issues.apache.org/jira/browse/AMBARI-17717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should have a script that users can run to add a custom service and 
> repository to the stack or an existing cluster.
> 
> ```
> Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
> Usage: add_common_service.py [options]
> 
> Options:
>   -h, --helpshow this help message and exit
>   -u USER, --user=USER  Ambari login username (Required)
>   -p PASSWORD, --password=PASSWORD
> Ambari login password. Providing password through
> command line is not recommended. The script prompts
> for the password.
>   -t STACK, --stack=STACK
> Stack Name and Version to be added (Required).(Eg:
> HDP-2.4 or HDP-2.5)
>   -s SERVICE, --service=SERVICE
> Service Name and Version to be added.(Eg: HAWQ/2.0.0
> or PXF/3.0.0)
>   -r REPOURL, --repourl=REPOURL
> Repository URL which points to the rpm packages
>   -i REPOID, --repoid=REPOID
> Repository ID of the new repository
>   -o OSTYPE, --ostype=OSTYPE
> OS for the new repository (Eg: redhat6)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50087/diff/
> 
> 
> Testing
> ---
> 
> Tested manually with various combinations
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 50069: Docker based dev environment for Log Search

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/
---

(Updated July 19, 2016, 11:23 a.m.)


Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.


Changes
---

- more tests & refactor a method


Bugs: AMBARI-17723
https://issues.apache.org/jira/browse/AMBARI-17723


Repository: ambari


Description
---

Add abillity to setup a qucik dev env for docker with debug capabilities.
Goals:
- setup an env quickly without Ambari (logsearch + logfeeder + solr)
- later create integration test framework based on that (junit/jbehave managed 
containers, pinging solr for results etc.)


Diffs (updated)
-

  ambari-logsearch/README.md 04fdf2f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 15dd5c9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 43d908e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
  ambari-logsearch/docker/.gitignore PRE-CREATION 
  ambari-logsearch/docker/Dockerfile PRE-CREATION 
  ambari-logsearch/docker/bin/start.sh PRE-CREATION 
  ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
  ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/smartsense/hst-agent-test-log.txt 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
PRE-CREATION 
  ambari-logsearch/pom.xml 81da0f2 

Diff: https://reviews.apache.org/r/50069/diff/


Testing
---

>From Apache jenkins:
++1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in 
ambari-logsearch/ambari-logsearch-logfeeder 
ambari-logsearch/ambari-logsearch-portal.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
This message is automatically generated.


Thanks,

Oliver Szabo

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

[Eugene Chekanskiy]

> On July 15, 2016, 1:54 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java,
> >  line 76
> > 
> >
> > Document why this lock is necessary/important.

Done.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142373
---


On July 19, 2016, 10:54 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 19, 2016, 10:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 51435fe 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  9d2fea5 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

[Eugene Chekanskiy]

> On July 18, 2016, 3:57 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java,
> >  line 76
> > 
> >
> > Important to docuemnt why this is needed.

Done.


> On July 18, 2016, 3:57 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java,
> >  line 513
> > 
> >
> > Remianing comment about why it is on a separate thread is still 
> > relevant.

Done.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142569
---


On July 19, 2016, 10:54 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 19, 2016, 10:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 51435fe 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  9d2fea5 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/
---

(Updated July 19, 2016, 1:54 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sid Wagle.


Changes
---

Added commands


Bugs: AMBARI-17651
https://issues.apache.org/jira/browse/AMBARI-17651


Repository: ambari


Description
---

Restart indicator is not shown after modifying the configs.
Test case modified the hdfs config 'Namenode new generation size'. But still 
after saving the configuration, restart icon is not shown.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
 5934f5a 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 94a8fe0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 d4e3828 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
51435fe 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
92ec843 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 fdb997b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 666111b 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
 dc8017a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
 9d2fea5 

Diff: https://reviews.apache.org/r/49891/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

[Eugene Chekanskiy]

> On July 18, 2016, 9:35 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java,
> >  line 142
> > 
> >
> > Have you considered using a ConcurrentHashMap instead?

This map is not modified in any way. Writing and reading of 
staleConfigCacheDesiredConfigs synchronized with staleConfigCacheLock, so it 
must be safe.


On July 18, 2016, 9:35 p.m., Dmitro Lisnichenko wrote:
> > With these changes do we still need STALE_CONFIGS_CACHE_EXPIRATION_TIME ? 
> > This expiration itself was a workaround for similar/same issue.

Actually we can remove that. But this patch is aimed to fix one most possible 
reason of chache population with stale data because of parallel db sessions, 
when one modifying desiredConfigs and other one trying to read them(and getting 
non modified desiredConfigs). Pontetially we can have some other issues that we 
can catch later on, for example we will add another piece of code that 
modyfying configs, but will not invalidate chache. So i prefer to keep this.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142643
---


On July 15, 2016, 10:26 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 15, 2016, 10:26 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 46a3f3e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  0ff143c 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50069: Docker based dev environment for Log Search

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/#review142714
---


Ship it!




Ship It!

- Dharmesh Makwana


On July 18, 2016, 1:28 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50069/
> ---
> 
> (Updated July 18, 2016, 1:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
> Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17723
> https://issues.apache.org/jira/browse/AMBARI-17723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abillity to setup a qucik dev env for docker with debug capabilities.
> Goals:
> - setup an env quickly without Ambari (logsearch + logfeeder + solr)
> - later create integration test framework based on that (junit/jbehave 
> managed containers, pinging solr for results etc.)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 04fdf2f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  15dd5c9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  43d908e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
>   ambari-logsearch/docker/.gitignore PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile PRE-CREATION 
>   ambari-logsearch/docker/bin/start.sh PRE-CREATION 
>   ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/pom.xml 81da0f2 
> 
> Diff: https://reviews.apache.org/r/50069/diff/
> 
> 
> Testing
> ---
> 
> From Apache jenkins:
> ++1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 16 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-logsearch/ambari-logsearch-logfeeder 
> ambari-logsearch/ambari-logsearch-portal.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50167/#review142713
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 18, 2016, 11:59 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50167/
> ---
> 
> (Updated Июль 18, 2016, 11:59 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17779
> https://issues.apache.org/jira/browse/AMBARI-17779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following set of changes are being done for this patch.
> 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled 
> for AMS tables.
> 2. Fix issue in default TopN behavior for point in time queries
> 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase 
> lib directories, during rpm assembly.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  dd1ae3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  16ebcd9 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  7c6e7f4 
> 
> Diff: https://reviews.apache.org/r/50167/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> Manual testing done.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 50185: [AMBARI-17786] Enable csrf protection in livy by default

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50185/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-17786
https://issues.apache.org/jira/browse/AMBARI-17786


Repository: ambari


Description
---

Just a minor configuration change for livy


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 7d3c78f 

Diff: https://reviews.apache.org/r/50185/diff/


Testing
---

No test is needed. Just a minor configburation chagne.


Thanks,

Jeff Zhang

Re: Review Request 50157: HST agent logs not parsed

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50157/#review142707
---


Ship it!




Ship It!

- Miklos Gergely


On July 18, 2016, 8:09 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50157/
> ---
> 
> (Updated July 18, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17774
> https://issues.apache.org/jira/browse/AMBARI-17774
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hst agent logs are not parsed. I guess that could be because in some point 
> the pattern is changed.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
>  6c216f4 
> 
> Diff: https://reviews.apache.org/r/50157/diff/
> 
> 
> Testing
> ---
> 
> Total run:1020
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 50100: AMBARI-17754 - Issue with modify configs for hive service

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50100/#review142701
---


Ship it!




Ship It!

- Andriy Babiichuk


On Июль 16, 2016, 12:26 д.п., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50100/
> ---
> 
> (Updated Июль 16, 2016, 12:26 д.п.)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-17754
> https://issues.apache.org/jira/browse/AMBARI-17754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix reference to undefined.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js 46744ba 
> 
> Diff: https://reviews.apache.org/r/50100/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
>   29285 tests complete (28 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 50180: AMBARI-17784 AMS Storm Sink: remove redundant information from kafka offset metrics on storm-kafka (including AMBARI-17725)

[Jungtaek Lim]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50180/
---

Review request for Ambari, Aravindan Vijayan, Sriharsha Chintalapani, and Sid 
Wagle.


Bugs: AMBARI-17784
https://issues.apache.org/jira/browse/AMBARI-17784


Repository: ambari


Description
---

This is follow-up issue for AMBARI-17725.

After AMBARI-17725, we can distinguish cluster metrics and topology metrics, 
which makes us possible to topology name and component name as variables for 
templatized dashboard.

But kafkaOffset metrics still have kafka topic and partition information to 
middle of metric name which make us hard to pick. Since worker host and worker 
port, and task id is not needed for kafkaOffset metrics, we can get rid of 
those things from only kafkaOffset metrics.

> topology level

* Before applying: topology.kafka-topology.kafka-spout..6700.14.kafkaOffset.myKafkaTopic/totalSpoutLag
* After applying: topology.kafka-topology.kafka-topic.myKafkaTopic.totalSpoutLag

> partition level

* Before applying: topology.kafka-topology.kafka-spout..6700.14.kafkaOffset.myKafkaTopic/partition-5/earliestTimeOffset
* After applying: 
topology.kafka-topology.kafka-topic.myKafkaTopic.partition-5.earliestTimeOffset


Diffs
-

  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 9e6cc98 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 271c11f 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 dcc3192 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 c76197b 

Diff: https://reviews.apache.org/r/50180/diff/


Testing
---

* Unit test succeed (@ignore is added for trunk. it succeed for branch 2.4)
* Tested manually


Thanks,

Jungtaek Lim