Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

[yao lei]

> On 十一月 10, 2016, 3:02 p.m., Jonathan Hurley wrote:
> > What's the state of this review? Has it been abandoned? If so, can we close 
> > it?

jhurley,thanks for your attention.
There seem not have more feedbacks about this review request.
If you are sure this funciton is repeated in new "wizard" workflow for alerts,i 
will close it later


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review155589
---


On 十月 13, 2016, 7:43 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated 十月 13, 2016, 7:43 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Zhe (Joe) Wang, 
> Oleg Tikhonov, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

[Oliver Szabo]

> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml,
> >  line 22
> > 
> >
> > what happens if i want to add multiple custom labels/components to 
> > logsearch?
> 
> Miklos Gergely wrote:
> This solution supports only one label, which may have as many 
> components/logs as we wish for. Do we want to allow the user to add multiple 
> labels tis way? That would be a bit tricky, but certainly possible.

yes, that should be flexible, we should not force to user the have only one 
label. maybe you can find different way to do it if its easier (not as the same 
how we do in the conifg agregator...e.g.: extend the json content through 
configs for HadoopServicesConfig.json)


> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 150
> > 
> >
> > why add this is needed in this patch? 
> > we should remove these with hst anyway after nifi/hst is updated. if 
> > ambari 2.4 is used its there, for ambari 2.5 that wont be here
> 
> Miklos Gergely wrote:
> Currently input.config-nifi.json.j2 is still present in the ambari-server 
> project, so this should be in the params.py as well in order to be 
> consistent. Or we may as well remove both, would that be OK?

you can keep this as is, but we will remove it anyway


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53663/#review155679
---


On Nov. 11, 2016, 12:39 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53663/
> ---
> 
> (Updated Nov. 11, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18854
> https://issues.apache.org/jira/browse/AMBARI-18854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Offer some properties in the logsearch configuration via which the user can 
> set up some other input logs in a similar way as the component logs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
>  2e9dda3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  1f5064a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  e90d623 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  7e9153f 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 7a13637 
> 
> Diff: https://reviews.apache.org/r/53663/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

[Miklos Gergely]

> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py,
> >  line 150
> > 
> >
> > why add this is needed in this patch? 
> > we should remove these with hst anyway after nifi/hst is updated. if 
> > ambari 2.4 is used its there, for ambari 2.5 that wont be here

Currently input.config-nifi.json.j2 is still present in the ambari-server 
project, so this should be in the params.py as well in order to be consistent. 
Or we may as well remove both, would that be OK?


> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py,
> >  line 70
> > 
> >
> > why is that file deleted?

Because if the user enters some custom input config first, and later deletes it 
then the generated custom input file should disappear too. To ensure this the 
file should be deleted every time, and potentially re-generated if there is 
some custom configured input.


> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote:
> > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml,
> >  line 22
> > 
> >
> > what happens if i want to add multiple custom labels/components to 
> > logsearch?

This solution supports only one label, which may have as many components/logs 
as we wish for. Do we want to allow the user to add multiple labels tis way? 
That would be a bit tricky, but certainly possible.


- Miklos


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53663/#review155679
---


On Nov. 11, 2016, 12:39 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53663/
> ---
> 
> (Updated Nov. 11, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18854
> https://issues.apache.org/jira/browse/AMBARI-18854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Offer some properties in the logsearch configuration via which the user can 
> set up some other input logs in a similar way as the component logs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
>  2e9dda3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  1f5064a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  e90d623 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  7e9153f 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 7a13637 
> 
> Diff: https://reviews.apache.org/r/53663/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53663/#review155679
---




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
 (line 22)


what happens if i want to add multiple custom labels/components to 
logsearch?



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 150)


why add this is needed in this patch? 
we should remove these with hst anyway after nifi/hst is updated. if ambari 
2.4 is used its there, for ambari 2.5 that wont be here



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 (line 70)


why is that file deleted?


- Oliver Szabo


On Nov. 11, 2016, 12:39 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53663/
> ---
> 
> (Updated Nov. 11, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18854
> https://issues.apache.org/jira/browse/AMBARI-18854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Offer some properties in the logsearch configuration via which the user can 
> set up some other input logs in a similar way as the component logs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
>  2e9dda3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  1f5064a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  e90d623 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  7e9153f 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 7a13637 
> 
> Diff: https://reviews.apache.org/r/53663/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 53663: Add ability to add custom input descriptor to logfeeder

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53663/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-18854
https://issues.apache.org/jira/browse/AMBARI-18854


Repository: ambari


Description
---

Offer some properties in the logsearch configuration via which the user can set 
up some other input logs in a similar way as the component logs.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
 2e9dda3 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 1f5064a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 e90d623 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
 7e9153f 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 7a13637 

Diff: https://reviews.apache.org/r/53663/diff/


Testing
---

Tested on local cluster.


Thanks,

Miklos Gergely

Review Request 53664: AMBARI-18855 - Manage JournalNode Wizard: While assigning new JournalNodes, Current JournalNode selection value changes

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53664/
---

Review request for Ambari and Jaimin Jetly.


Bugs: AMBARI-18855
https://issues.apache.org/jira/browse/AMBARI-18855


Repository: ambari


Description
---

Sort old components by serviceComponentId before assigning new id to 
lastObject.serviceComponentId + 1;
Force reevaluation of next button status after rendering components.


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js
 c834517 
  ambari-web/app/mixins/wizard/assign_master_components.js 46409b2 

Diff: https://reviews.apache.org/r/53664/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.
  25349 tests complete (21 seconds)
  57 tests pending


Thanks,

Richard Zang

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Shi Wang]

> On Nov. 10, 2016, 7:33 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py,
> >  line 79
> > 
> >
> > Can you try to do "kdestroy" for webhcat user. And than start Webhcat 
> > if that works +1.
> 
> Andrew Onischuk wrote:
> Also did you do full stack deploy to make sure that nobody else it using 
> hdfs.headless keytab?
> 
> Robert Levas wrote:
> Andrew, I tried this patch and I didnt see any issues starting up webhcat 
> after removing that kinit. There are no alerts in my cluster as well... but I 
> only have HDFS, Yarn/MR2, Tez, Hive, Zookeeper, Slider, Kerberos, and Pig 
> installed.  
> 
> ```
> [hcat@c6402 ~]$ klist
> klist: No credentials cache found (ticket cache FILE:/tmp/krb5cc_1019)
> ```

Thanks Andrew and Robert, I did kdestroy in my test. My cluster installed HDFS, 
Yarn/MR2, Hive, HBase, Zookeeper, Sqoop, Kerberos, Oozie, AMS, Kafka, Knox, 
Solr, Spark.


- Shi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review18
---


On Nov. 10, 2016, 9:28 p.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> e8c96cb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  a7feb60 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
> 974a69c 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Shi Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/
---

(Updated Nov. 10, 2016, 9:28 p.m.)


Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.


Bugs: AMBARI-18836
https://issues.apache.org/jira/browse/AMBARI-18836


Repository: ambari


Description
---

The Smoke and “Headless” Service users are used by Ambari to perform service 
“smoke” checks and run alert health checks. 
The permission for hdfs.headless.keytab is 440. But it will cause security 
concern to allow other service user in hadoop group to kinit hdfs headless 
principal using hdfs.headless.keytab. In this way, other service user could 
"pretend" to be hdfs user and be granted hdfs user's authorities.


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
e8c96cb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 a7feb60 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/kerberos.json 
974a69c 

Diff: https://reviews.apache.org/r/53629/diff/


Testing
---

Hi Robert, 
What will be your opinion on this?
Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
headless principal operation for webhcat seems useless, I kdestroy the hdfs 
ticket for hcat user and hive service check/start/stop all works fine. Is there 
any other tests I should try? Thanks.


Thanks,

Shi Wang

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Shi Wang]

> On Nov. 10, 2016, 12:14 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json,
> >  line 59
> > 
> >
> > You need to also edit the Kerberos descriptor file at 
> > `stacks/HDP/2.5/services/HDFS/kerberos.json:69`

Thanks for point this out Robert. I updated my branch to trunk and add this 
change in stacks/HDP/2.5/services/HDFS/kerberos.json


- Shi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review155569
---


On Nov. 10, 2016, 6:49 a.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 6:49 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 3d6e25c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  816b6af 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review155627
---




ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 (lines 78 - 88)


This is a poor test and is pretty much like the negative test named 
`testBadCredential`.  Is there a better positive test for this?


- Robert Levas


On Nov. 10, 2016, 10:35 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Nov. 10, 2016, 10:35 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e02b7a5 
>   ambari-server/sbin/ambari-server bdbdd0f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f9557a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  09e49ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  6351720 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  ba32a5f 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java 
> 255c5e6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  eee721a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  3425dd7 
>   ambari-server/src/main/python/ambari-server.py d6c6c10 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py ef27ced 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 37a9757 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 15d6120 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a82a52 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 659e4dc 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e9a258a 
>   ambari-server/src/main/resources/properties.json 6bbb323 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  f54ac5c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  8ed81df 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263.patch_base
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/
---

(Updated Nov. 10, 2016, 6:34 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sumit Mohanty.


Changes
---

Modified: CLIENT_THREAD_POOL_NAME = "ambari-client-thread";


Bugs: AMBARI-18827
https://issues.apache.org/jira/browse/AMBARI-18827


Repository: ambari


Description
---

_Objectives_:
- Allow acceptors for agent and api connectors to be configurable
- The thread pool configuration did not take into account both 2-way and 1-way 
connectors are configured for agent every time although only one is used and 
not a mixed-mode. This causes insufficient threads in agent threadpool for a 
high cpu core environment.
- Includes refactoring to remove code duplication.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 9d793ff 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 6a4eabf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 ce3fe85 
  
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
 a1b5a6e 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 844f022 

Diff: https://reviews.apache.org/r/53588/diff/


Testing
---

Verified manually.

2-core VM ==>
Before patch:
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Acceptor" 
| wc -l
4
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Selector" 
| wc -l
4
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Acceptor" | wc -l
1

Default after patch:
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Selector" | wc -l
1

Setting configurations = 2:
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Acceptor" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Acceptor" | wc -l
2


Thanks,

Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/
---

(Updated Nov. 10, 2016, 6:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sumit Mohanty.


Changes
---

Generated new index.md with new markdown properties.


Bugs: AMBARI-18827
https://issues.apache.org/jira/browse/AMBARI-18827


Repository: ambari


Description
---

_Objectives_:
- Allow acceptors for agent and api connectors to be configurable
- The thread pool configuration did not take into account both 2-way and 1-way 
connectors are configured for agent every time although only one is used and 
not a mixed-mode. This causes insufficient threads in agent threadpool for a 
high cpu core environment.
- Includes refactoring to remove code duplication.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 9d793ff 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 6a4eabf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 ce3fe85 
  
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
 a1b5a6e 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 844f022 

Diff: https://reviews.apache.org/r/53588/diff/


Testing
---

Verified manually.

2-core VM ==>
Before patch:
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Acceptor" 
| wc -l
4
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Selector" 
| wc -l
4
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Acceptor" | wc -l
1

Default after patch:
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Selector" | wc -l
1

Setting configurations = 2:
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Acceptor" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Acceptor" | wc -l
2


Thanks,

Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/
---

(Updated Nov. 10, 2016, 6:32 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
Papirkovskyy, and Sumit Mohanty.


Changes
---

Minor nit: Removed unwanted dummy code change done to genetate index file.


Bugs: AMBARI-18827
https://issues.apache.org/jira/browse/AMBARI-18827


Repository: ambari


Description
---

_Objectives_:
- Allow acceptors for agent and api connectors to be configurable
- The thread pool configuration did not take into account both 2-way and 1-way 
connectors are configured for agent every time although only one is used and 
not a mixed-mode. This causes insufficient threads in agent threadpool for a 
high cpu core environment.
- Includes refactoring to remove code duplication.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 9d793ff 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 6a4eabf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 ce3fe85 
  
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
 a1b5a6e 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 844f022 

Diff: https://reviews.apache.org/r/53588/diff/


Testing
---

Verified manually.

2-core VM ==>
Before patch:
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Acceptor" 
| wc -l
4
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Selector" 
| wc -l
4
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
"ambari-client.*Acceptor" | wc -l
1

Default after patch:
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
"ambari-agent.*Selector" | wc -l
1

Setting configurations = 2:
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-agent.*Acceptor" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
"ambari-client.*Acceptor" | wc -l
2


Thanks,

Sid Wagle

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Jonathan Hurley]

> On Nov. 10, 2016, 9:58 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 170
> > 
> >
> > Can we keep these the same name as before?
> 
> Sid Wagle wrote:
> Ok, currently (2.4.2.0-101) we name agent threads as: qtp-ambari-agent 
> and client as ambari-client-thread. Both used QueuedThreadPool, this make it 
> consistent.
> 
> Sid Wagle wrote:
> Let me know if you are ok with naming them qtp-ambari-agent and 
> qtp-ambari-client vs qtp-ambari-agent and ambari-client-thread. Dropping the 
> issue for now.

If you want to change them back, then OK - I'll have to update a bunch of 
scripts I have which are used for evaluating jstacks. If there's no real reason 
to change them back to their old values, then I'd suggest leaving them.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/#review155585
---


On Nov. 10, 2016, 1:27 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53588/
> ---
> 
> (Updated Nov. 10, 2016, 1:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18827
> https://issues.apache.org/jira/browse/AMBARI-18827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Objectives_:
> - Allow acceptors for agent and api connectors to be configurable
> - The thread pool configuration did not take into account both 2-way and 
> 1-way connectors are configured for agent every time although only one is 
> used and not a mixed-mode. This causes insufficient threads in agent 
> threadpool for a high cpu core environment.
> - Includes refactoring to remove code duplication.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 9d793ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6a4eabf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  ce3fe85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
>  a1b5a6e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  844f022 
> 
> Diff: https://reviews.apache.org/r/53588/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> 2-core VM ==>
> Before patch:
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 4
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Selector" | wc -l
> 4
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> 
> Default after patch:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Selector" | wc -l
> 1
> 
> Setting configurations = 2:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 2
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 646
> > 
> >
> > JavaDoc.

Added.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/#review155585
---


On Nov. 10, 2016, 6:27 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53588/
> ---
> 
> (Updated Nov. 10, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18827
> https://issues.apache.org/jira/browse/AMBARI-18827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Objectives_:
> - Allow acceptors for agent and api connectors to be configurable
> - The thread pool configuration did not take into account both 2-way and 
> 1-way connectors are configured for agent every time although only one is 
> used and not a mixed-mode. This causes insufficient threads in agent 
> threadpool for a high cpu core environment.
> - Includes refactoring to remove code duplication.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 9d793ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6a4eabf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  ce3fe85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
>  a1b5a6e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  844f022 
> 
> Diff: https://reviews.apache.org/r/53588/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> 2-core VM ==>
> Before patch:
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 4
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Selector" | wc -l
> 4
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> 
> Default after patch:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Selector" | wc -l
> 1
> 
> Setting configurations = 2:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 2
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 170
> > 
> >
> > Can we keep these the same name as before?
> 
> Sid Wagle wrote:
> Ok, currently (2.4.2.0-101) we name agent threads as: qtp-ambari-agent 
> and client as ambari-client-thread. Both used QueuedThreadPool, this make it 
> consistent.

Let me know if you are ok with naming them qtp-ambari-agent and 
qtp-ambari-client vs qtp-ambari-agent and ambari-client-thread. Dropping the 
issue for now.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/#review155585
---


On Nov. 10, 2016, 6:27 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53588/
> ---
> 
> (Updated Nov. 10, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18827
> https://issues.apache.org/jira/browse/AMBARI-18827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Objectives_:
> - Allow acceptors for agent and api connectors to be configurable
> - The thread pool configuration did not take into account both 2-way and 
> 1-way connectors are configured for agent every time although only one is 
> used and not a mixed-mode. This causes insufficient threads in agent 
> threadpool for a high cpu core environment.
> - Includes refactoring to remove code duplication.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 9d793ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6a4eabf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  ce3fe85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
>  a1b5a6e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  844f022 
> 
> Diff: https://reviews.apache.org/r/53588/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> 2-core VM ==>
> Before patch:
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 4
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Selector" | wc -l
> 4
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> 
> Default after patch:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Selector" | wc -l
> 1
> 
> Setting configurations = 2:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 2
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

[Attila Doroszlai]

> On Nov. 10, 2016, 5:18 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 1
> > 
> >
> > I think if we want to change this, it should be project-wide ... and 
> > that means a new Jira and an update to the style wiki.
> > 
> > However, it seems that Apache projects tend to use this format:
> > 
> > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Content.java
> > 
> > Is the dangling javadoc warning something in your IDE?

Even Ambari Server has both styles.  From current trunk (b847a0c):

```
$ find ambari-server/src/main/java -type f -name '*.java' | xargs grep -n -m1 
'^/*' | grep ':1:' | cut -f3 -d':' | sort | uniq -c
 449 /*
1291 /**
```


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53576/#review155601
---


On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53576/
> ---
> 
> (Updated Nov. 9, 2016, 4:07 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18569
> https://issues.apache.org/jira/browse/AMBARI-18569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Configurable number of threads
>* Enable/disable flag
>* Removed synchronization at bottlenecks
>* Added cache for `StackEntity.findByNameAndVersion` query
>* Added log for all 4 types of topology tasks
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f9557a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  09e49ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  241a48f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  87eb266 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a08d153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
>  c425969 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java
>  2932581 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  6a65b48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  3aaf589 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  bba0325 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  f90cf76 
> 
> Diff: https://reviews.apache.org/r/53576/diff/
> 
> 
> Testing
> ---
> 
> Created several clusters (size = 8-64 nodes) via blueprint
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Amruta Borkar]

> On Nov. 10, 2016, 4:22 p.m., Nate Cole wrote:
> > Ship It!

Thank you Nate, could you please help me push the patch to trunk? I do not have 
that access.


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review155603
---


On Nov. 1, 2016, 6:57 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Nov. 1, 2016, 6:57 p.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 9c1387d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  ff9af17 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Sid Wagle]

> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 170
> > 
> >
> > Can we keep these the same name as before?

Ok, currently (2.4.2.0-101) we name agent threads as: qtp-ambari-agent and 
client as ambari-client-thread. Both used QueuedThreadPool, this make it 
consistent.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/#review155585
---


On Nov. 9, 2016, 10:09 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53588/
> ---
> 
> (Updated Nov. 9, 2016, 10:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18827
> https://issues.apache.org/jira/browse/AMBARI-18827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Objectives_:
> - Allow acceptors for agent and api connectors to be configurable
> - The thread pool configuration did not take into account both 2-way and 
> 1-way connectors are configured for agent every time although only one is 
> used and not a mixed-mode. This causes insufficient threads in agent 
> threadpool for a high cpu core environment.
> - Includes refactoring to remove code duplication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6a4eabf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  ce3fe85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
>  a1b5a6e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  844f022 
> 
> Diff: https://reviews.apache.org/r/53588/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> 2-core VM ==>
> Before patch:
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 4
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Selector" | wc -l
> 4
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> 
> Default after patch:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Selector" | wc -l
> 1
> 
> Setting configurations = 2:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 2
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53651/#review155608
---


Ship it!




Ship It!

- Dmytro Sen


On Ноя. 10, 2016, 4:23 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53651/
> ---
> 
> (Updated Ноя. 10, 2016, 4:23 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Dmytro Sen, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18640
> https://issues.apache.org/jira/browse/AMBARI-18640
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed errors in today's run during Ambari upgrade from 2.2.1.1 to 
> 2.4.2.0-36
> ambari-server --hash
> c6da6776f029f15d3a7d6009697371eee4e5f4c5
> 
> Ambari DB - MySQL; Secure HDP-2.4.0.0 cluster deployed via UI
> 
> *Upgrade Log indicates below:*
> {code}
> 18 Oct 2016 14:17:59,115  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100)
> 18 Oct 2016 14:17:59,154  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100) NOT NULL
> 18 Oct 2016 14:17:59,191  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY role VARCHAR(100)
> 18 Oct 2016 14:17:59,428  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY status VARCHAR(100)
> 18 Oct 2016 14:17:59,656  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> 18 Oct 2016 14:17:59,678 ERROR [main] DBAccessorImpl:830 - Error executing 
> query: ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:827)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:819)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.alterColumn(DBAccessorImpl.java:610)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.updateTablesForMysql(UpgradeCatalog242.java:120)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDDLUpdates(UpgradeCatalog242.java:95)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:889)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:206)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:349)
> 18 Oct 2016 14:17:59,680 ERROR [main] SchemaUpgradeHelper:208 - Upgrade 
> failed.
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> 
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  f5445ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  8cfcee5 
> 
> Diff: https://reviews.apache.org/r/53651/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53651/#review155606
---


Ship it!




Ship It!

- Andrew Onischuk


On Nov. 10, 2016, 4:23 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53651/
> ---
> 
> (Updated Nov. 10, 2016, 4:23 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Dmytro Sen, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18640
> https://issues.apache.org/jira/browse/AMBARI-18640
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed errors in today's run during Ambari upgrade from 2.2.1.1 to 
> 2.4.2.0-36
> ambari-server --hash
> c6da6776f029f15d3a7d6009697371eee4e5f4c5
> 
> Ambari DB - MySQL; Secure HDP-2.4.0.0 cluster deployed via UI
> 
> *Upgrade Log indicates below:*
> {code}
> 18 Oct 2016 14:17:59,115  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100)
> 18 Oct 2016 14:17:59,154  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100) NOT NULL
> 18 Oct 2016 14:17:59,191  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY role VARCHAR(100)
> 18 Oct 2016 14:17:59,428  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY status VARCHAR(100)
> 18 Oct 2016 14:17:59,656  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> 18 Oct 2016 14:17:59,678 ERROR [main] DBAccessorImpl:830 - Error executing 
> query: ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:827)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:819)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.alterColumn(DBAccessorImpl.java:610)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.updateTablesForMysql(UpgradeCatalog242.java:120)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDDLUpdates(UpgradeCatalog242.java:95)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:889)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:206)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:349)
> 18 Oct 2016 14:17:59,680 ERROR [main] SchemaUpgradeHelper:208 - Upgrade 
> failed.
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> 
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  f5445ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  8cfcee5 
> 
> Diff: https://reviews.apache.org/r/53651/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

[Victor Galgo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53651/#review155605
---


Ship it!




Ship It!

- Victor Galgo


On Nov. 10, 2016, 4:23 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53651/
> ---
> 
> (Updated Nov. 10, 2016, 4:23 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Dmytro Sen, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18640
> https://issues.apache.org/jira/browse/AMBARI-18640
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed errors in today's run during Ambari upgrade from 2.2.1.1 to 
> 2.4.2.0-36
> ambari-server --hash
> c6da6776f029f15d3a7d6009697371eee4e5f4c5
> 
> Ambari DB - MySQL; Secure HDP-2.4.0.0 cluster deployed via UI
> 
> *Upgrade Log indicates below:*
> {code}
> 18 Oct 2016 14:17:59,115  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100)
> 18 Oct 2016 14:17:59,154  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE users  MODIFY user_name VARCHAR(100) NOT NULL
> 18 Oct 2016 14:17:59,191  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY role VARCHAR(100)
> 18 Oct 2016 14:17:59,428  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE host_role_command  MODIFY status VARCHAR(100)
> 18 Oct 2016 14:17:59,656  INFO [main] DBAccessorImpl:824 - Executing query: 
> ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> 18 Oct 2016 14:17:59,678 ERROR [main] DBAccessorImpl:830 - Error executing 
> query: ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:827)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:819)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.alterColumn(DBAccessorImpl.java:610)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.updateTablesForMysql(UpgradeCatalog242.java:120)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDDLUpdates(UpgradeCatalog242.java:95)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:889)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:206)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:349)
> 18 Oct 2016 14:17:59,680 ERROR [main] SchemaUpgradeHelper:208 - Upgrade 
> failed.
> java.sql.SQLException: Cannot change column 'blueprint_name': used in a 
> foreign key constraint 'FK_blueprint_setting_name' of table 
> 'ambaricustom.blueprint_setting'
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> 
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  f5445ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  8cfcee5 
> 
> Diff: https://reviews.apache.org/r/53651/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53651/
---

Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Dmytro Sen, and 
Sumit Mohanty.


Bugs: AMBARI-18640
https://issues.apache.org/jira/browse/AMBARI-18640


Repository: ambari


Description
---

Observed errors in today's run during Ambari upgrade from 2.2.1.1 to 2.4.2.0-36
ambari-server --hash
c6da6776f029f15d3a7d6009697371eee4e5f4c5

Ambari DB - MySQL; Secure HDP-2.4.0.0 cluster deployed via UI

*Upgrade Log indicates below:*
{code}
18 Oct 2016 14:17:59,115  INFO [main] DBAccessorImpl:824 - Executing query: 
ALTER TABLE users  MODIFY user_name VARCHAR(100)
18 Oct 2016 14:17:59,154  INFO [main] DBAccessorImpl:824 - Executing query: 
ALTER TABLE users  MODIFY user_name VARCHAR(100) NOT NULL
18 Oct 2016 14:17:59,191  INFO [main] DBAccessorImpl:824 - Executing query: 
ALTER TABLE host_role_command  MODIFY role VARCHAR(100)
18 Oct 2016 14:17:59,428  INFO [main] DBAccessorImpl:824 - Executing query: 
ALTER TABLE host_role_command  MODIFY status VARCHAR(100)
18 Oct 2016 14:17:59,656  INFO [main] DBAccessorImpl:824 - Executing query: 
ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
18 Oct 2016 14:17:59,678 ERROR [main] DBAccessorImpl:830 - Error executing 
query: ALTER TABLE blueprint  MODIFY blueprint_name VARCHAR(100)
java.sql.SQLException: Cannot change column 'blueprint_name': used in a foreign 
key constraint 'FK_blueprint_setting_name' of table 
'ambaricustom.blueprint_setting'
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:827)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:819)
at 
org.apache.ambari.server.orm.DBAccessorImpl.alterColumn(DBAccessorImpl.java:610)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog242.updateTablesForMysql(UpgradeCatalog242.java:120)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog242.executeDDLUpdates(UpgradeCatalog242.java:95)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:889)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:206)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:349)
18 Oct 2016 14:17:59,680 ERROR [main] SchemaUpgradeHelper:208 - Upgrade failed.
java.sql.SQLException: Cannot change column 'blueprint_name': used in a foreign 
key constraint 'FK_blueprint_setting_name' of table 
'ambaricustom.blueprint_setting'
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)

{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
 f5445ea 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 8cfcee5 

Diff: https://reviews.apache.org/r/53651/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 53650: Stack Versions page: fix styles

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53650/#review155604
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Nov. 10, 2016, 4:18 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53650/
> ---
> 
> (Updated Nov. 10, 2016, 4:18 p.m.)
> 
> 
> Review request for Ambari and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-18849
> https://issues.apache.org/jira/browse/AMBARI-18849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Versions page: fix styles
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> 4429bf4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  ae9471c 
>   ambari-web/app/routes/stack_upgrade_routes.js 7cf83b6 
>   ambari-web/app/styles/application.less df2d054 
>   ambari-web/app/styles/stack_versions.less b183303 
>   ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
> 6548ea0 
>   ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs 6e45868 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js 
> fda0c7e 
> 
> Diff: https://reviews.apache.org/r/53650/diff/
> 
> 
> Testing
> ---
> 
> 30497 tests complete (30 seconds)
>   151 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review155603
---


Ship it!




Ship It!

- Nate Cole


On Nov. 1, 2016, 2:57 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Nov. 1, 2016, 2:57 p.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 9c1387d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
>  ff9af17 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53576/#review155601
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 1)


I think if we want to change this, it should be project-wide ... and that 
means a new Jira and an update to the style wiki.

However, it seems that Apache projects tend to use this format:

https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Content.java

Is the dangling javadoc warning something in your IDE?


- Jonathan Hurley


On Nov. 9, 2016, 10:07 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53576/
> ---
> 
> (Updated Nov. 9, 2016, 10:07 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18569
> https://issues.apache.org/jira/browse/AMBARI-18569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Configurable number of threads
>* Enable/disable flag
>* Removed synchronization at bottlenecks
>* Added cache for `StackEntity.findByNameAndVersion` query
>* Added log for all 4 types of topology tasks
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f9557a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  09e49ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  241a48f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  87eb266 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a08d153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
>  c425969 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java
>  2932581 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  6a65b48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  3aaf589 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  bba0325 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  f90cf76 
> 
> Diff: https://reviews.apache.org/r/53576/diff/
> 
> 
> Testing
> ---
> 
> Created several clusters (size = 8-64 nodes) via blueprint
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 53650: Stack Versions page: fix styles

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53650/
---

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-18849
https://issues.apache.org/jira/browse/AMBARI-18849


Repository: ambari


Description
---

Stack Versions page: fix styles


Diffs
-

  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 4429bf4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
ae9471c 
  ambari-web/app/routes/stack_upgrade_routes.js 7cf83b6 
  ambari-web/app/styles/application.less df2d054 
  ambari-web/app/styles/stack_versions.less b183303 
  ambari-web/app/templates/main/admin/stack_upgrade/stack_upgrade_wizard.hbs 
6548ea0 
  ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs 6e45868 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js fda0c7e 

Diff: https://reviews.apache.org/r/53650/diff/


Testing
---

30497 tests complete (30 seconds)
  151 tests pending


Thanks,

Andrii Tkach

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Nov. 10, 2016, 7:35 a.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs (updated)
-

  ambari-server/pom.xml e02b7a5 
  ambari-server/sbin/ambari-server bdbdd0f 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f9557a5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 09e49ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 6351720 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 ba32a5f 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/GroupDAO.java 
255c5e6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 eee721a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 3425dd7 
  ambari-server/src/main/python/ambari-server.py d6c6c10 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py ef27ced 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 37a9757 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 15d6120 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 5a82a52 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 659e4dc 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e9a258a 
  ambari-server/src/main/resources/properties.json 6bbb323 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 f54ac5c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 8ed81df 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments


AMBARI-12263.patch_base
  
https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base


Thanks,

Vishal Ghugare

Re: Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53649/#review155596
---


Ship it!




Ship It!

- Tim Thorpe


On Nov. 10, 2016, 3:33 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53649/
> ---
> 
> (Updated Nov. 10, 2016, 3:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Tim Thorpe.
> 
> 
> Bugs: AMBARI-18838
> https://issues.apache.org/jira/browse/AMBARI-18838
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There are still a few references to ganglias and nagios in ambari agent 
> source code. Use this JIRA to remove them.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 9a0b537 
>   ambari-agent/conf/windows/ambari-agent.ini b7a0a4d 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 6e4d74a 
> 
> Diff: https://reviews.apache.org/r/53649/diff/
> 
> 
> Testing
> ---
> 
> existing unit tests for Ambari Agent
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53649/
---

(Updated Nov. 10, 2016, 3:33 p.m.)


Review request for Ambari, Alejandro Fernandez and Tim Thorpe.


Bugs: AMBARI-18838
https://issues.apache.org/jira/browse/AMBARI-18838


Repository: ambari


Description
---

There are still a few references to ganglias and nagios in ambari agent source 
code. Use this JIRA to remove them.


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 9a0b537 
  ambari-agent/conf/windows/ambari-agent.ini b7a0a4d 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 6e4d74a 

Diff: https://reviews.apache.org/r/53649/diff/


Testing
---

existing unit tests for Ambari Agent


Thanks,

Di Li

Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53649/
---

Review request for Ambari, Alejandro Fernandez and Tim Thorpe.


Bugs: AMBARI-18838
https://issues.apache.org/jira/browse/AMBARI-18838


Repository: ambari


Description
---

There are still a few references to ganglias and nagios in ambari agent source 
code. Use this JIRA to remove them.


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 9a0b537 
  ambari-agent/conf/windows/ambari-agent.ini b7a0a4d 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 6e4d74a 

Diff: https://reviews.apache.org/r/53649/diff/


Testing
---

existing unit tests for Ambari Agent


Thanks,

Di Li

Re: Review Request 53647: Issues after fast switching service page tabs

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53647/
---

(Updated Ноя. 10, 2016, 3:21 п.п.)


Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-18847
https://issues.apache.org/jira/browse/AMBARI-18847


Repository: ambari


Description
---

Sometimes after fast switching between service page tabs (Summary, Heatmaps, 
Configs) we get some js errors, that can abort tab loading.


Diffs
-

  ambari-web/app/controllers/main/service/info/configs.js 31ea248 
  ambari-web/app/mappers/configs/themes_mapper.js f141156 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 0ccc93e 
  ambari-web/app/mixins/main/service/groups_mapping.js 3271714 
  ambari-web/app/models/configs/objects/service_config.js a0800fa 
  ambari-web/app/utils/blueprint.js 1148d3d 
  ambari-web/app/utils/ember_reopen.js a616e49 
  ambari-web/app/views/common/configs/config_category_container_view.js 08cdb2c 
  ambari-web/app/views/common/configs/config_history_flow.js 931d994 

Diff: https://reviews.apache.org/r/53647/diff/


Testing (updated)
---

30497 tests complete (34 seconds)
151 tests pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review155589
---



What's the state of this review? Has it been abandoned? If so, can we close it?

- Jonathan Hurley


On Oct. 13, 2016, 3:43 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated Oct. 13, 2016, 3:43 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Zhe (Joe) Wang, 
> Oleg Tikhonov, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 53446: AMBARI-18793: Ambari-server: Support stack inheritance for credential store information

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53446/#review155588
---



Ping. Can this review be closed now?

- Jonathan Hurley


On Nov. 3, 2016, 8:30 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53446/
> ---
> 
> (Updated Nov. 3, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18793
> https://issues.apache.org/jira/browse/AMBARI-18793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18793: Ambari-server: Support stack inheritance for credential store 
> information
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b6a0da53dfd796dea739da97c994e1fc37a3d155 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java
>  605de999bb1a87dcd74708a14b6cca8ff330a853 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 16042e12017745a674facbe70940ece80f83e56a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  47f5eb9b367e76ef7fd81b8c0ee3c8c5d82ea61f 
> 
> Diff: https://reviews.apache.org/r/53446/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [6.599s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [1:14.514s]
> [INFO] Ambari Views .. SUCCESS [0.983s]
> [INFO] Ambari Admin View . SUCCESS [7.031s]
> [INFO] utility ... SUCCESS [0.309s]
> [INFO] ambari-metrics  SUCCESS [0.594s]
> [INFO] Ambari Metrics Common . SUCCESS [3.898s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.938s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.139s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.203s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [3.223s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.378s]
> [INFO] Ambari Metrics Collector .. SUCCESS [8.550s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.966s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.243s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:11.798s]
> [INFO] Ambari Server . SUCCESS [3:01.245s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.651s]
> [INFO] Ambari Agent .. SUCCESS [26.446s]
> [INFO] Ambari Client . SUCCESS [0.049s]
> [INFO] Ambari Python Client .. SUCCESS [0.941s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.149s]
> [INFO] Ambari Shell .. SUCCESS [0.045s]
> [INFO] Ambari Python Shell ... SUCCESS [0.695s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.932s]
> [INFO] ambari-logsearch .. SUCCESS [0.394s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.241s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.363s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.995s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [4.183s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.083s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:57.041s
> [INFO] Finished at: Thu Nov 03 17:29:33 PDT 2016
> [INFO] Final Memory: 305M/1110M
> [INFO] 
> 
> 
> *** 2. mvn -DskipPythonTests -Dtest=*Provider*,*Service*,StackModuleTest **
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:41.191s
> [INFO] Finished at: Thu Nov 03 17

Re: Review Request 53412: AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or disabling credential store

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53412/#review155587
---



Ping. Can this review be closed now?

- Jonathan Hurley


On Nov. 3, 2016, 11:51 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53412/
> ---
> 
> (Updated Nov. 3, 2016, 11:51 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Robert 
> Nettleton, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18778
> https://issues.apache.org/jira/browse/AMBARI-18778
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or 
> disabling credential store
> 
> ** Blueprint deployments **
> Use the *settings/service_settings* section of the blueprint to specify 
> whether a service uses credential store or not. For example:
> 
> ```json
> { "settings" :
>   {
> "service_settings" : [
> { "name" : "RANGER",
>   "recovery_enabled" : "true",
>   "credential_store_enabled" : "true"
> },
> { "name" : "HIVE",
>   "recovery_enabled" : "true",
>   "credential_store_enabled" : "false"
> },
> { "name" : "TEZ",
>   "recovery_enabled" : "false"
> }
> ]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  b11d9d3a32d10ed12fe51e7e72211e4fa007920b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java 
> 8061f37a78aa3d25cef0b318af77175fc4a0df9d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
>  df0187e1d625e1441b548e4a845b1af79a75ef34 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java 
> 601cbfd1bc7aa6abdb3c8879ffe252724991cd37 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
>  6ef240de33d2875c1ab2fafc61472aa5c64e0cee 
> 
> Diff: https://reviews.apache.org/r/53412/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [12.938s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.060s]
> [INFO] Ambari Web  SUCCESS [1:12.696s]
> [INFO] Ambari Views .. SUCCESS [1.173s]
> [INFO] Ambari Admin View . SUCCESS [6.390s]
> [INFO] utility ... SUCCESS [0.322s]
> [INFO] ambari-metrics  SUCCESS [0.658s]
> [INFO] Ambari Metrics Common . SUCCESS [6.547s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [3.451s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.450s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.412s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [3.927s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.862s]
> [INFO] Ambari Metrics Collector .. SUCCESS [10.291s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.198s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.895s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:15.344s]
> [INFO] Ambari Server . SUCCESS [2:44.173s]
> [INFO] Ambari Functional Tests ... SUCCESS [0.910s]
> [INFO] Ambari Agent .. SUCCESS [24.648s]
> [INFO] Ambari Client . SUCCESS [0.039s]
> [INFO] Ambari Python Client .. SUCCESS [0.826s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.967s]
> [INFO] Ambari Shell .. SUCCESS [0.033s]
> [INFO] Ambari Python Shell ... SUCCESS [0.709s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.905s]
> [INFO] ambari-logsearch .. SUCCESS [0.217s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.199s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.084s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [5.976s]
> [INFO] Ambari Logsearch Log Feeder ...

Re: Review Request 53647: Issues after fast switching service page tabs

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53647/#review155590
---


Ship it!




Ship It!

- Alexandr Antonenko


On Nov. 10, 2016, 2:51 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53647/
> ---
> 
> (Updated Nov. 10, 2016, 2:51 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-18847
> https://issues.apache.org/jira/browse/AMBARI-18847
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sometimes after fast switching between service page tabs (Summary, Heatmaps, 
> Configs) we get some js errors, that can abort tab loading.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/configs.js 31ea248 
>   ambari-web/app/mappers/configs/themes_mapper.js f141156 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 0ccc93e 
>   ambari-web/app/mixins/main/service/groups_mapping.js 3271714 
>   ambari-web/app/models/configs/objects/service_config.js a0800fa 
>   ambari-web/app/utils/blueprint.js 1148d3d 
>   ambari-web/app/utils/ember_reopen.js a616e49 
>   ambari-web/app/views/common/configs/config_category_container_view.js 
> 08cdb2c 
>   ambari-web/app/views/common/configs/config_history_flow.js 931d994 
> 
> Diff: https://reviews.apache.org/r/53647/diff/
> 
> 
> Testing
> ---
> 
> 25352 tests complete (25 seconds)
> 57 tests pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Re: Review Request 53446: AMBARI-18793: Ambari-server: Support stack inheritance for credential store information

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53446/#review155586
---



What's the status of this review?

- Nate Cole


On Nov. 3, 2016, 8:30 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53446/
> ---
> 
> (Updated Nov. 3, 2016, 8:30 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, Sumit 
> Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18793
> https://issues.apache.org/jira/browse/AMBARI-18793
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18793: Ambari-server: Support stack inheritance for credential store 
> information
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b6a0da53dfd796dea739da97c994e1fc37a3d155 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/CredentialStoreInfo.java
>  605de999bb1a87dcd74708a14b6cca8ff330a853 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 16042e12017745a674facbe70940ece80f83e56a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
>  47f5eb9b367e76ef7fd81b8c0ee3c8c5d82ea61f 
> 
> Diff: https://reviews.apache.org/r/53446/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install -DskipTests **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [6.599s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [1:14.514s]
> [INFO] Ambari Views .. SUCCESS [0.983s]
> [INFO] Ambari Admin View . SUCCESS [7.031s]
> [INFO] utility ... SUCCESS [0.309s]
> [INFO] ambari-metrics  SUCCESS [0.594s]
> [INFO] Ambari Metrics Common . SUCCESS [3.898s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.938s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [1.139s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [1.203s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [3.223s]
> [INFO] Ambari Metrics Storm Sink (Legacy)  SUCCESS [1.378s]
> [INFO] Ambari Metrics Collector .. SUCCESS [8.550s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.966s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.243s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:11.798s]
> [INFO] Ambari Server . SUCCESS [3:01.245s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.651s]
> [INFO] Ambari Agent .. SUCCESS [26.446s]
> [INFO] Ambari Client . SUCCESS [0.049s]
> [INFO] Ambari Python Client .. SUCCESS [0.941s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.149s]
> [INFO] Ambari Shell .. SUCCESS [0.045s]
> [INFO] Ambari Python Shell ... SUCCESS [0.695s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.932s]
> [INFO] ambari-logsearch .. SUCCESS [0.394s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.241s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.363s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [6.995s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [4.183s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.083s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:57.041s
> [INFO] Finished at: Thu Nov 03 17:29:33 PDT 2016
> [INFO] Final Memory: 305M/1110M
> [INFO] 
> 
> 
> *** 2. mvn -DskipPythonTests -Dtest=*Provider*,*Service*,StackModuleTest **
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 2:41.191s
> [INFO] Finished at: Thu Nov 03 17:14:26 PD

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/#review155585
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (lines 5510 - 5526)


Don't forget to run
`java org.apache.ambari.server.configuration.Configuration -output 
../docs/configuration/index.md` to generate a new MD file.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 170)


Can we keep these the same name as before?



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 574)


JavaDoc.


- Jonathan Hurley


On Nov. 9, 2016, 5:09 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53588/
> ---
> 
> (Updated Nov. 9, 2016, 5:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18827
> https://issues.apache.org/jira/browse/AMBARI-18827
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> _Objectives_:
> - Allow acceptors for agent and api connectors to be configurable
> - The thread pool configuration did not take into account both 2-way and 
> 1-way connectors are configured for agent every time although only one is 
> used and not a mixed-mode. This causes insufficient threads in agent 
> threadpool for a high cpu core environment.
> - Includes refactoring to remove code duplication.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  6a4eabf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  ce3fe85 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
>  a1b5a6e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  844f022 
> 
> Diff: https://reviews.apache.org/r/53588/diff/
> 
> 
> Testing
> ---
> 
> Verified manually.
> 
> 2-core VM ==>
> Before patch:
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 4
> [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep 
> "ambari-agent.*Selector" | wc -l
> 4
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> 
> Default after patch:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-client.*Selector" | wc -l
> 1
> [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep 
> "ambari-agent.*Selector" | wc -l
> 1
> 
> Setting configurations = 2:
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Selector" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-agent.*Acceptor" | wc -l
> 2
> [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep 
> "ambari-client.*Acceptor" | wc -l
> 2
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 53647: Issues after fast switching service page tabs

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53647/
---

Review request for Ambari and Alexandr Antonenko.


Bugs: AMBARI-18847
https://issues.apache.org/jira/browse/AMBARI-18847


Repository: ambari


Description
---

Sometimes after fast switching between service page tabs (Summary, Heatmaps, 
Configs) we get some js errors, that can abort tab loading.


Diffs
-

  ambari-web/app/controllers/main/service/info/configs.js 31ea248 
  ambari-web/app/mappers/configs/themes_mapper.js f141156 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 0ccc93e 
  ambari-web/app/mixins/main/service/groups_mapping.js 3271714 
  ambari-web/app/models/configs/objects/service_config.js a0800fa 
  ambari-web/app/utils/blueprint.js 1148d3d 
  ambari-web/app/utils/ember_reopen.js a616e49 
  ambari-web/app/views/common/configs/config_category_container_view.js 08cdb2c 
  ambari-web/app/views/common/configs/config_history_flow.js 931d994 

Diff: https://reviews.apache.org/r/53647/diff/


Testing
---

25352 tests complete (25 seconds)
57 tests pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53643/#review155584
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 10, 2016, 2:52 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53643/
> ---
> 
> (Updated Nov. 10, 2016, 2:52 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18845
> https://issues.apache.org/jira/browse/AMBARI-18845
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> testRegistrationRecoveryConfig seems to fail randomly. We should investigate 
> why it randomly fails and either try to fix it or mark as an @Flaky test.
> 
> https://builds.apache.org/job/Ambari-trunk-Commit/5926/testReport/junit/org.apache.ambari.server.agent/TestHeartbeatHandler/testRegistrationRecoveryConfig/
> 
> 
> java.lang.AssertionError
>   at 
> org.apache.ambari.server.agent.TestHeartbeatHandler.testRegistrationRecoveryConfig(TestHeartbeatHandler.java:432)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  e50b8c9 
> 
> Diff: https://reviews.apache.org/r/53643/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53643/#review155583
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 10, 2016, 7:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53643/
> ---
> 
> (Updated Nov. 10, 2016, 7:52 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18845
> https://issues.apache.org/jira/browse/AMBARI-18845
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> testRegistrationRecoveryConfig seems to fail randomly. We should investigate 
> why it randomly fails and either try to fix it or mark as an @Flaky test.
> 
> https://builds.apache.org/job/Ambari-trunk-Commit/5926/testReport/junit/org.apache.ambari.server.agent/TestHeartbeatHandler/testRegistrationRecoveryConfig/
> 
> 
> java.lang.AssertionError
>   at 
> org.apache.ambari.server.agent.TestHeartbeatHandler.testRegistrationRecoveryConfig(TestHeartbeatHandler.java:432)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  e50b8c9 
> 
> Diff: https://reviews.apache.org/r/53643/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53643/#review155582
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лис. 10, 2016, 12:52 після полудня, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53643/
> ---
> 
> (Updated Лис. 10, 2016, 12:52 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18845
> https://issues.apache.org/jira/browse/AMBARI-18845
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> testRegistrationRecoveryConfig seems to fail randomly. We should investigate 
> why it randomly fails and either try to fix it or mark as an @Flaky test.
> 
> https://builds.apache.org/job/Ambari-trunk-Commit/5926/testReport/junit/org.apache.ambari.server.agent/TestHeartbeatHandler/testRegistrationRecoveryConfig/
> 
> 
> java.lang.AssertionError
>   at 
> org.apache.ambari.server.agent.TestHeartbeatHandler.testRegistrationRecoveryConfig(TestHeartbeatHandler.java:432)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
>  e50b8c9 
> 
> Diff: https://reviews.apache.org/r/53643/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53643/
---

Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav 
Papirkovskyy, and Vitalyi Brodetskyi.


Bugs: AMBARI-18845
https://issues.apache.org/jira/browse/AMBARI-18845


Repository: ambari


Description
---

testRegistrationRecoveryConfig seems to fail randomly. We should investigate 
why it randomly fails and either try to fix it or mark as an @Flaky test.

https://builds.apache.org/job/Ambari-trunk-Commit/5926/testReport/junit/org.apache.ambari.server.agent/TestHeartbeatHandler/testRegistrationRecoveryConfig/


java.lang.AssertionError
at 
org.apache.ambari.server.agent.TestHeartbeatHandler.testRegistrationRecoveryConfig(TestHeartbeatHandler.java:432)


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
 e50b8c9 

Diff: https://reviews.apache.org/r/53643/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Robert Levas]

> On Nov. 10, 2016, 2:33 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py,
> >  line 79
> > 
> >
> > Can you try to do "kdestroy" for webhcat user. And than start Webhcat 
> > if that works +1.
> 
> Andrew Onischuk wrote:
> Also did you do full stack deploy to make sure that nobody else it using 
> hdfs.headless keytab?

Andrew, I tried this patch and I didnt see any issues starting up webhcat after 
removing that kinit. There are no alerts in my cluster as well... but I only 
have HDFS, Yarn/MR2, Tez, Hive, Zookeeper, Slider, Kerberos, and Pig installed. 
 

```
[hcat@c6402 ~]$ klist
klist: No credentials cache found (ticket cache FILE:/tmp/krb5cc_1019)
```


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review18
---


On Nov. 10, 2016, 1:49 a.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 1:49 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 3d6e25c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  816b6af 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53629/#review155569
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
(line 59)


You need to also edit the Kerberos descriptor file at 
`stacks/HDP/2.5/services/HDFS/kerberos.json:69`


- Robert Levas


On Nov. 10, 2016, 1:49 a.m., Shi Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53629/
> ---
> 
> (Updated Nov. 10, 2016, 1:49 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, and Robert Levas.
> 
> 
> Bugs: AMBARI-18836
> https://issues.apache.org/jira/browse/AMBARI-18836
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Smoke and “Headless” Service users are used by Ambari to perform service 
> “smoke” checks and run alert health checks. 
> The permission for hdfs.headless.keytab is 440. But it will cause security 
> concern to allow other service user in hadoop group to kinit hdfs headless 
> principal using hdfs.headless.keytab. In this way, other service user could 
> "pretend" to be hdfs user and be granted hdfs user's authorities.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json 
> 3d6e25c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  816b6af 
> 
> Diff: https://reviews.apache.org/r/53629/diff/
> 
> 
> Testing
> ---
> 
> Hi Robert, 
> What will be your opinion on this?
> Is it necessary to set 440 permission to hdfs headless keytab? The kinit hdfs 
> headless principal operation for webhcat seems useless, I kdestroy the hdfs 
> ticket for hcat user and hive service check/start/stop all works fine. Is 
> there any other tests I should try? Thanks.
> 
> 
> Thanks,
> 
> Shi Wang
> 
>

Re: Review Request 53642: Web Client Should Support HOST_ORDERED Upgrades In Progress

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53642/#review155566
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 10, 2016, 11:36 д.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53642/
> ---
> 
> (Updated Ноя. 10, 2016, 11:36 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-18844
> https://issues.apache.org/jira/browse/AMBARI-18844
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HOST_ORDERED upgrades which are initiated from the APIs currently don't show 
> up as an upgrade "In Progress" in the web client. Although this upgrade type 
> is not going to be exposed as a first-class upgrade type for Ambari 2.5, the 
> web client must still behave correctly when encountering a HOST_ORDERED 
> upgrade already running.
> The following criteria should be met:
> The web client displays a banner that there is an upgrade in progress (or 
> holding or waiting for input, etc) just like it would for other upgrade types.
> Destructive behavior such as running commands, adding/remove hosts/services, 
> changing configs, etc, should be prevented.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/config.js a2028ad 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> 3c69b84 
>   ambari-web/app/messages.js e707576 
>   ambari-web/app/styles/application.less f24f355 
>   ambari-web/app/styles/stack_versions.less 9d4190a 
>   ambari-web/app/templates/application.hbs 669daa7 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 
> cb91bd7 
>   
> ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_column.hbs 
> b7477ca 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 
> ebcd423 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 
> 21def14 
>   
> ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js
>  c64e5af 
> 
> Diff: https://reviews.apache.org/r/53642/diff/
> 
> 
> Testing
> ---
> 
> 30497 tests complete (29 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Review Request 53642: Web Client Should Support HOST_ORDERED Upgrades In Progress

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53642/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-18844
https://issues.apache.org/jira/browse/AMBARI-18844


Repository: ambari


Description
---

HOST_ORDERED upgrades which are initiated from the APIs currently don't show up 
as an upgrade "In Progress" in the web client. Although this upgrade type is 
not going to be exposed as a first-class upgrade type for Ambari 2.5, the web 
client must still behave correctly when encountering a HOST_ORDERED upgrade 
already running.
The following criteria should be met:
The web client displays a banner that there is an upgrade in progress (or 
holding or waiting for input, etc) just like it would for other upgrade types.
Destructive behavior such as running commands, adding/remove hosts/services, 
changing configs, etc, should be prevented.


Diffs
-

  ambari-web/app/config.js a2028ad 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 3c69b84 
  ambari-web/app/messages.js e707576 
  ambari-web/app/styles/application.less f24f355 
  ambari-web/app/styles/stack_versions.less 9d4190a 
  ambari-web/app/templates/application.hbs 669daa7 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs 
cb91bd7 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_column.hbs 
b7477ca 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 
ebcd423 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 
21def14 
  
ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 
c64e5af 

Diff: https://reviews.apache.org/r/53642/diff/


Testing
---

30497 tests complete (29 seconds)
151 tests pending


Thanks,

Andrii Tkach

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

[Attila Doroszlai]

> On Nov. 10, 2016, 11:04 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 1
> > 
> >
> > Add * to be consistent with the licensing header across all the src 
> > files.

I'm deliberately changing these, since the licensing header is not a javadoc 
comment.  The original `/**` above the `package` statement produces "Dangling 
Javadoc comment" warning.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53576/#review155560
---


On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53576/
> ---
> 
> (Updated Nov. 9, 2016, 4:07 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18569
> https://issues.apache.org/jira/browse/AMBARI-18569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Configurable number of threads
>* Enable/disable flag
>* Removed synchronization at bottlenecks
>* Added cache for `StackEntity.findByNameAndVersion` query
>* Added log for all 4 types of topology tasks
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f9557a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  09e49ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  241a48f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  87eb266 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a08d153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
>  c425969 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java
>  2932581 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  6a65b48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  3aaf589 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  bba0325 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  f90cf76 
> 
> Diff: https://reviews.apache.org/r/53576/diff/
> 
> 
> Testing
> ---
> 
> Created several clusters (size = 8-64 nodes) via blueprint
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53576/#review155560
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 1)


Add * to be consistent with the licensing header across all the src files.



ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
 (line 1)


Add * to be consistent with the licensing header across all the src files.



ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java
 (line 1)


Add * to be consistent with the licensing header across all the src files.



ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
(line 1)


Add * to be consistent with the licensing header across all the src files.



ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
 (line 1)


Add * to be consistent with the licensing header across all the src files.



ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 (line 1)


Add * to be consistent with the licensing header across all the src files.


- Sebastian Toader


On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53576/
> ---
> 
> (Updated Nov. 9, 2016, 4:07 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18569
> https://issues.apache.org/jira/browse/AMBARI-18569
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Configurable number of threads
>* Enable/disable flag
>* Removed synchronization at bottlenecks
>* Added cache for `StackEntity.findByNameAndVersion` query
>* Added log for all 4 types of topology tasks
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f9557a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  09e49ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  241a48f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  87eb266 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  a08d153 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java
>  c425969 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java
>  2932581 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  6a65b48 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
>  3aaf589 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  bba0325 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  f90cf76 
> 
> Diff: https://reviews.apache.org/r/53576/diff/
> 
> 
> Testing
> ---
> 
> Created several clusters (size = 8-64 nodes) via blueprint
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53602/
---

(Updated Nov. 10, 2016, 8:50 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, 
and Sid Wagle.


Bugs: AMBARI-18832
https://issues.apache.org/jira/browse/AMBARI-18832


Repository: ambari


Description
---

A single missing directory named `namenode-formatted` can result in Ambari
reformatting the NameNode and causing total data loss in a cluster.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 b7735f4 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 4cfa2b2 

Diff: https://reviews.apache.org/r/53602/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk