Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179169
---




ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
Lines 1416 (patched)


Ok, I originally thought that it would also create the target column in the 
target table.


- Alejandro Fernandez


On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60516/#review179165
---


Ship it!




Ship It!

- Jaimin Jetly


On June 28, 2017, 8:31 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60516/
> ---
> 
> (Updated June 28, 2017, 8:31 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Aleksandr Kovalenko, Denys 
> Buzhor, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21371
> https://issues.apache.org/jira/browse/AMBARI-21371
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> propertyDependsOn is only available for stack level configuration. Add a null 
> check.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/enhanced_configs.js 4561f77 
> 
> 
> Diff: https://reviews.apache.org/r/60516/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster. All unit tests passed.
> 
> 21208 passing (22s)
>   128 pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Review Request 60516: AMBARI-21371 - Adding ranger failed when user has custom properties

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60516/
---

Review request for Ambari, Andrii Babiichuk, Aleksandr Kovalenko, Denys Buzhor, 
Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-21371
https://issues.apache.org/jira/browse/AMBARI-21371


Repository: ambari


Description
---

propertyDependsOn is only available for stack level configuration. Add a null 
check.


Diffs
-

  ambari-web/app/mixins/common/configs/enhanced_configs.js 4561f77 


Diff: https://reviews.apache.org/r/60516/diff/1/


Testing
---

Manually tested on live cluster. All unit tests passed.

21208 passing (22s)
  128 pending


Thanks,

Richard Zang

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Attila Doroszlai]

> On June 28, 2017, 10:20 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
> > Lines 1416 (patched)
> > 
> >
> > Is this a copy of data or adding a column in the target table if it 
> > doesn't already exist?

It adds `targetColumn` in the target table, then copies data from 
`sourceColumn`, matching rows in the two tables by `sourceIDFieldName` and 
`targetIDFieldName`.  So the latter 3 must exist for the move.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179163
---


On June 28, 2017, 2:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179163
---




ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
Lines 1416 (patched)


Is this a copy of data or adding a column in the target table if it doesn't 
already exist?


- Alejandro Fernandez


On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Dmytro Grinenko]

> On June 28, 2017, 8:09 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
> > Lines 1416 (patched)
> > 
> >
> > This should be !tableHasColumn(targetTableName, targetIDFieldName)

why it should be so?   Both targetID and sourceID need to be exists so realize 
one-to-one connection


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179160
---


On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179160
---




ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
Lines 1416 (patched)


This should be !tableHasColumn(targetTableName, targetIDFieldName)


- Alejandro Fernandez


On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 7:51 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 118 (patched)
> > 
> >
> > This is missing 

right, I removed it per Jonathan's comment. Or I can add it back but set to 
false ( not seeing the point of that comparing to not having the line at all)

" This will cause upgrades to change configs and have Hive report staleness and 
require a restart. Instead, it seems like we should default to False if not 
found and use the upgrade packs to update this.

In other words; since Stack-A might need this when moving to Stack-B, then it 
should provide this as a configuration setting. "


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179157
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Lines 118 (patched)


This is missing 


- Alejandro Fernandez


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 60514: Use JDK 8 maven compiler plugin for Log Search and Infra projects

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60514/
---

Review request for Ambari, Attila Doroszlai, Miklos Gergely, Robert Nettleton, 
and Sebastian Toader.


Bugs: AMBARI-21369
https://issues.apache.org/jira/browse/AMBARI-21369


Repository: ambari


Description
---

Start to use jdk 8 compiler maven plugin for Log Search and Infra


Diffs
-

  ambari-infra/ambari-infra-manager/pom.xml b7708c2 
  ambari-infra/ambari-infra-solr-plugin/pom.xml c890cec 
  ambari-infra/pom.xml 07adb3e 
  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ae2150e 
  ambari-logsearch/ambari-logsearch-server/pom.xml fc4029b 
  ambari-logsearch/pom.xml af1dc6a 


Diff: https://reviews.apache.org/r/60514/diff/1/


Testing
---

done. (fails with jdk 7)


Thanks,

Oliver Szabo

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

(Updated June 28, 2017, 6:23 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 1cf9016 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b7cb148 


Diff: https://reviews.apache.org/r/60480/diff/3/

Changes: https://reviews.apache.org/r/60480/diff/2-3/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 6:04 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Lines 119 (patched)
> > 
> >
> > This will cause upgrades to change configs and have Hive report 
> > staleness and require a restart. Instead, it seems like we should default 
> > to False if not found and use the upgrade packs to update this.
> > 
> > In other words; since Stack-A might need this when moving to Stack-B, 
> > then it should provide this as a configuration setting.

yes, I agree. I thought on ambari upgrade wasn't functional (at least my 
experience with IOP Ambari upgrade...). I removed it from the latest patch.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179142
---


On June 28, 2017, 6:23 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 6:23 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/3/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60509/#review179146
---


Ship it!




Ship It!

- Tim Thorpe


On June 28, 2017, 6:03 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60509/
> ---
> 
> (Updated June 28, 2017, 6:03 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21368
> https://issues.apache.org/jira/browse/AMBARI-21368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Ambari server rat exclude list with BI AMS files
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 51759d4 
> 
> 
> Diff: https://reviews.apache.org/r/60509/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean install -pl ambari-server
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60509/#review179144
---


Ship it!




Ship It!

- Jonathan Hurley


On June 28, 2017, 2:03 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60509/
> ---
> 
> (Updated June 28, 2017, 2:03 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21368
> https://issues.apache.org/jira/browse/AMBARI-21368
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Ambari server rat exclude list with BI AMS files
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 51759d4 
> 
> 
> Diff: https://reviews.apache.org/r/60509/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean install -pl ambari-server
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179142
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
Lines 119 (patched)


This will cause upgrades to change configs and have Hive report staleness 
and require a restart. Instead, it seems like we should default to False if not 
found and use the upgrade packs to update this.

In other words; since Stack-A might need this when moving to Stack-B, then 
it should provide this as a configuration setting.


- Jonathan Hurley


On June 28, 2017, 1:31 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 1:31 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/2/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 60509: AMBARI-21368 Update Ambari server rat exclude list with BI AMS files

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60509/
---

Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21368
https://issues.apache.org/jira/browse/AMBARI-21368


Repository: ambari


Description
---

Update Ambari server rat exclude list with BI AMS files


Diffs
-

  ambari-server/pom.xml 51759d4 


Diff: https://reviews.apache.org/r/60509/diff/1/


Testing
---

mvn clean install -pl ambari-server


Thanks,

Di Li

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179141
---


Ship it!




Ship It!

- Jonathan Hurley


On June 28, 2017, 11:16 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 28, 2017, 11:16 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote:
> > Should this also be put into trunk? We would still need to support this 
> > moving forward. Maybe we need a Jira to track an actual property which 
> > governs which database executable to invoke.
> 
> Di Li wrote:
> An updated version should be pushed to trunk as HDP will probably have to 
> support Hive/MariaDB on migrated IOP clusters until all these clusters reach 
> the end of support terms. I can propose a new patch for trunk later on.

I just uploaded a new patch that uses a property to determine the daemon name - 
 mysqld vs mariadb. If we use this new patch, it'd be easier for HDP to future 
support this migrated clusters ( same patch to be pushed to trunk, no need to 
have special change for the feature branch.)


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---


On June 28, 2017, 5:31 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 28, 2017, 5:31 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  1cf9016 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/2/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/
---

(Updated June 28, 2017, 5:31 p.m.)


Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21351
https://issues.apache.org/jira/browse/AMBARI-21351


Repository: ambari


Description
---

Some stacks, such as BigInights, support MariaDB as the database for Hive. When 
upgrading from BigInights to another stack, such as HDP, this causes the 
following exception when starting the Hive service:
```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
Failed to stop mysqld.service: Unit mysqld.service not loaded.```
This looks to be caused by the hard-coded reliance of mysqld in the Python 
scripts.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
 1cf9016 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 b7cb148 


Diff: https://reviews.apache.org/r/60480/diff/2/

Changes: https://reviews.apache.org/r/60480/diff/1-2/


Testing
---

Tim and I patched a cluster with basically the same fix when migrating an IOP 
4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
that's to set StackFeature boolean in case this code gets merged back to trunk 
later on. 

If the code only stays in this branch, the StackFeature boolean change can be 
omitted.


Thanks,

Di Li

Re: Review Request 60506: Fix Unit Test Failures Caused by AMBARI-21358

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60506/#review179129
---


Ship it!




Ship It!

- Sid Wagle


On June 28, 2017, 4:47 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60506/
> ---
> 
> (Updated June 28, 2017, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
> 
> 
> Bugs: AMBARI-21367
> https://issues.apache.org/jira/browse/AMBARI-21367
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix Unit Test Failures Caused by AMBARI-21358
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  81bc80fb55 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  da716b3175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  9652c69f65 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
>  f63825b69c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
>  ceaa83aed7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
>  b5dec7fd0a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
>  22183baaae 
> 
> 
> Diff: https://reviews.apache.org/r/60506/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 60506: Fix Unit Test Failures Caused by AMBARI-21358

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60506/
---

Review request for Ambari, Alejandro Fernandez and Sid Wagle.


Bugs: AMBARI-21367
https://issues.apache.org/jira/browse/AMBARI-21367


Repository: ambari


Description
---

Fix Unit Test Failures Caused by AMBARI-21358


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 81bc80fb55 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 da716b3175 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 9652c69f65 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
 f63825b69c 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
 ceaa83aed7 
  
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java
 b5dec7fd0a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
 22183baaae 


Diff: https://reviews.apache.org/r/60506/diff/1/


Testing
---


Thanks,

Jonathan Hurley

Re: Review Request 60501: Create property descriptions for internal Log Search configs

[Oliver Szabo]

> On June 28, 2017, 4:23 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
> > Lines 47 (patched)
> > 
> >
> > I would recommend making the example value be an array of list (or some 
> > other Collection) of Strings.  
> > 
> > If the property only accepts an enumerated set of options, it would be 
> > a good idea to be able to specify these in the markup.  It would also be 
> > good to be able to distinguish between a property that takes a 
> > comma-separated list of values, as opposed to a property that lists the 
> > possible valid values.  
> > 
> > Check out the following class in ambari-server, which provides a 
> > similar markdown for config properties:
> > 
> > org.apache.ambari.annotations.Markdown

I already saw the @Markdown interface, in our case i did not feel that 
necesarry to be an array of examples, as we have only just a few properties 
where we can have enumerated values (like http headers , or like protocol: 
http/https), if we do not count the boolean values, can be a good idea to do 
that, but im not sure we need that.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/#review179121
---


On June 28, 2017, 3:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60501/
> ---
> 
> (Updated June 28, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21366
> https://issues.apache.org/jira/browse/AMBARI-21366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - added new annotation to create descrptions for all internal logsearch 
> properties (currently only for logsearch.properties, not logfeeder.properties)
> - create /info endpoints to get access the property descriptions 
> (/api/v1/info/properties)
> - speed up doc generation (for this change and for swagger as well...as it 
> generated every time you hit the rest api call, now it will generated during 
> startup on a thread, from that point you will be able to acces the docs from 
> the memory)
> 
> Also some UI changes:
> - there was a /api/v1/pulbic/config call, instead of it, uses 
> /api/v1/info/auth with returning a simple map json (not that weird name value 
> structure)...use that endpoint in login.html
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  45281b6 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  a2a7f5e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  9d4e96e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
>  cb8c097 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  441b628 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  5981bcc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
>  7d37efd 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
>  a117501 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  7cf79b0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  482438a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  73de0ee 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179125
---


Ship it!




Ship It!

- Attila Doroszlai


On June 28, 2017, 5:16 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 28, 2017, 5:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60501: Create property descriptions for internal Log Search configs

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/#review179121
---


Fix it, then Ship it!




Patch looks fine to me, other than the minor issue listed below.


ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
Lines 47 (patched)


I would recommend making the example value be an array of list (or some 
other Collection) of Strings.  

If the property only accepts an enumerated set of options, it would be a 
good idea to be able to specify these in the markup.  It would also be good to 
be able to distinguish between a property that takes a comma-separated list of 
values, as opposed to a property that lists the possible valid values.  

Check out the following class in ambari-server, which provides a similar 
markdown for config properties:

org.apache.ambari.annotations.Markdown


- Robert Nettleton


On June 28, 2017, 3:51 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60501/
> ---
> 
> (Updated June 28, 2017, 3:51 p.m.)
> 
> 
> Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-21366
> https://issues.apache.org/jira/browse/AMBARI-21366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - added new annotation to create descrptions for all internal logsearch 
> properties (currently only for logsearch.properties, not logfeeder.properties)
> - create /info endpoints to get access the property descriptions 
> (/api/v1/info/properties)
> - speed up doc generation (for this change and for swagger as well...as it 
> generated every time you hit the rest api call, now it will generated during 
> startup on a thread, from that point you will be able to acces the docs from 
> the memory)
> 
> Also some UI changes:
> - there was a /api/v1/pulbic/config call, instead of it, uses 
> /api/v1/info/auth with returning a simple map json (not that weird name value 
> structure)...use that endpoint in login.html
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  45281b6 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  a2a7f5e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  9d4e96e 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
>  54cc10c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
>  cb8c097 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
>  441b628 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
>  5981bcc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
>  7d37efd 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
>  a117501 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
>  7cf79b0 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
>  482438a 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  73de0ee 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/PublicManager.java
>  cbab651 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/PropertyDescriptionData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java
>  PRE-CREATION 
>   
>

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Di Li]

> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
> > Lines 57 (patched)
> > 
> >
> > Probably not necessary...

you are right, I removed it.


> On June 28, 2017, 2:45 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
> > Lines 64 (patched)
> > 
> >
> > Is there an extra S on the end of this?

yeah, removed it.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179106
---


On June 28, 2017, 3:16 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 28, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60501: Create property descriptions for internal Log Search configs

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/
---

(Updated June 28, 2017, 3:51 p.m.)


Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
Nettleton.


Changes
---

fix swagger doc


Bugs: AMBARI-21366
https://issues.apache.org/jira/browse/AMBARI-21366


Repository: ambari


Description
---

- added new annotation to create descrptions for all internal logsearch 
properties (currently only for logsearch.properties, not logfeeder.properties)
- create /info endpoints to get access the property descriptions 
(/api/v1/info/properties)
- speed up doc generation (for this change and for swagger as well...as it 
generated every time you hit the rest api call, now it will generated during 
startup on a thread, from that point you will be able to acces the docs from 
the memory)

Also some UI changes:
- there was a /api/v1/pulbic/config call, instead of it, uses /api/v1/info/auth 
with returning a simple map json (not that weird name value structure)...use 
that endpoint in login.html


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 45281b6 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 a2a7f5e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 9d4e96e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
 54cc10c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
 cb8c097 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 441b628 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 5981bcc 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 7d37efd 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
 a117501 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
 7cf79b0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
 482438a 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 73de0ee 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/PublicManager.java
 cbab651 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/PropertyDescriptionData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/PublicResource.java
 df83d44 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/SwaggerResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 d4b6544 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 1b77753 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 1dab126 
  
ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
 d6247a1 
  ambari-logsearch/ambari-logsearch-web/src/main/webapp/login.html f2cb2c7 


Diff: https://reviews.apache.org/r/60501/diff/3/

Changes: https://reviews.apache.org/r/60501/diff/2-3/


Testing
---

done. manually & check /docs endpoint


Thanks,

Oliver Szabo

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

[Robert Levas]

> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 72 (patched)
> > 
> >
> > Should probably be named `getComponentDescriptor`
> 
> Attila Magyar wrote:
> Is this an Ambari convention? Under what circumstances do we like using 
> the get prefix? I feel most of the times this doesn't add too much extra 
> information. Yes, this method returns a value, but most of the methods return 
> a value anyway (there are programming languages where every function returns 
> a value), and I would rather highlight the differences instead of the 
> similarities.
> Some people like using the get prefix when the method returns a stored 
> value instead of a calculated one. This is also debatable IMO, but here it's 
> not the case, because these methods do calculations. And also they're private 
> with very little scope.

Your argument makes sense.  I will drop this.


> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 77 (patched)
> > 
> >
> > Should be named `getIdentityNames`
> 
> Attila Magyar wrote:
> See my comment above.

Your argument makes sense.  I will drop this.


> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 96 (patched)
> > 
> >
> > Should be named `getActiveIdentities`
> 
> Attila Magyar wrote:
> See my comment above.

Your argument makes sense.  I will drop this.


> On June 27, 2017, 2:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 114 (patched)
> > 
> >
> > Should be named `isSameComponent`
> 
> Attila Magyar wrote:
> See my comment above.

Your argument makes sense.  I will drop this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review179008
---


On June 28, 2017, 4:06 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> ---
> 
> (Updated June 28, 2017, 4:06 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upon removing a component from a host, the relevant Kerberos identities 
> should be removed as well. This includes any principals and keytab files. 
> Care must be taken not to remove any principals or keytab files that are 
> still in use in the cluster.
> 
> 
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of 
> the identities of the uninstalled component, except the ones that are still 
> used by other services/components.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e8c986b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  d000571 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  e4b70fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7824019 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
>  0b845d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  9755bd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  2112fcc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponen

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179117
---


Ship it!




Ship It!

- Tim Thorpe


On June 28, 2017, 3:16 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 28, 2017, 3:16 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/3/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/
---

(Updated June 28, 2017, 3:16 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21359
https://issues.apache.org/jira/browse/AMBARI-21359


Repository: ambari


Description
---

This is for the JavaVersionCheck check defined in the cross stack upgrade pack 
EU xml file.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 71c5857 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60481/diff/3/

Changes: https://reviews.apache.org/r/60481/diff/2-3/


Testing
---

to be tested later on with the integrated tests.


Thanks,

Di Li

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Di Li]

> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote:
> > Should this also be put into trunk? We would still need to support this 
> > moving forward. Maybe we need a Jira to track an actual property which 
> > governs which database executable to invoke.

An updated version should be pushed to trunk as HDP will probably have to 
support Hive/MariaDB on migrated IOP clusters until all these clusters reach 
the end of support terms. I can propose a new patch for trunk later on.


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---


On June 27, 2017, 8:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 8:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60501: Create property descriptions for internal Log Search configs

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/
---

(Updated June 28, 2017, 2:51 p.m.)


Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
Nettleton.


Changes
---

update unit tests


Bugs: AMBARI-21366
https://issues.apache.org/jira/browse/AMBARI-21366


Repository: ambari


Description
---

- added new annotation to create descrptions for all internal logsearch 
properties (currently only for logsearch.properties, not logfeeder.properties)
- create /info endpoints to get access the property descriptions 
(/api/v1/info/properties)
- speed up doc generation (for this change and for swagger as well...as it 
generated every time you hit the rest api call, now it will generated during 
startup on a thread, from that point you will be able to acces the docs from 
the memory)

Also some UI changes:
- there was a /api/v1/pulbic/config call, instead of it, uses /api/v1/info/auth 
with returning a simple map json (not that weird name value structure)...use 
that endpoint in login.html


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 45281b6 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 a2a7f5e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 9d4e96e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
 54cc10c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
 cb8c097 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 441b628 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 5981bcc 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 7d37efd 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
 a117501 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
 7cf79b0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
 482438a 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 73de0ee 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/PublicManager.java
 cbab651 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/PropertyDescriptionData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/PublicResource.java
 df83d44 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/SwaggerResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 d4b6544 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 1b77753 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 1dab126 
  
ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
 d6247a1 
  ambari-logsearch/ambari-logsearch-web/src/main/webapp/login.html f2cb2c7 


Diff: https://reviews.apache.org/r/60501/diff/2/

Changes: https://reviews.apache.org/r/60501/diff/1-2/


Testing
---

done. manually & check /docs endpoint


Thanks,

Oliver Szabo

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179109
---



Should this also be put into trunk? We would still need to support this moving 
forward. Maybe we need a Jira to track an actual property which governs which 
database executable to invoke.

- Jonathan Hurley


On June 27, 2017, 4:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 4:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60480/#review179108
---


Ship it!




Ship It!

- Jonathan Hurley


On June 27, 2017, 4:08 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60480/
> ---
> 
> (Updated June 27, 2017, 4:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21351
> https://issues.apache.org/jira/browse/AMBARI-21351
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, such as BigInights, support MariaDB as the database for Hive. 
> When upgrading from BigInights to another stack, such as HDP, this causes the 
> following exception when starting the Hive service:
> ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service 
> mysqld stop' returned 5. Redirecting to /bin/systemctl stop  mysqld.service
> Failed to stop mysqld.service: Unit mysqld.service not loaded.```
> This looks to be caused by the hard-coded reliance of mysqld in the Python 
> scripts.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  c74e029 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  b7cb148 
> 
> 
> Diff: https://reviews.apache.org/r/60480/diff/1/
> 
> 
> Testing
> ---
> 
> Tim and I patched a cluster with basically the same fix when migrating an IOP 
> 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change 
> that's to set StackFeature boolean in case this code gets merged back to 
> trunk later on. 
> 
> If the code only stays in this branch, the StackFeature boolean change can be 
> omitted.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179106
---




ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 42 (patched)


Is this the minimum version for Ambari? Configuration defines this 
differently:


https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java#L180-L183

Should we be using that instead?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 57 (patched)


Probably not necessary...



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 64 (patched)


Is there an extra S on the end of this?


- Jonathan Hurley


On June 28, 2017, 9:34 a.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 28, 2017, 9:34 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/2/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 60501: Create property descriptions for internal Log Search configs

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60501/
---

Review request for Ambari, Andrii Babiichuk, Miklos Gergely, and Robert 
Nettleton.


Bugs: AMBARI-21366
https://issues.apache.org/jira/browse/AMBARI-21366


Repository: ambari


Description
---

- added new annotation to create descrptions for all internal logsearch 
properties (currently only for logsearch.properties, not logfeeder.properties)
- create /info endpoints to get access the property descriptions 
(/api/v1/info/properties)
- speed up doc generation (for this change and for swagger as well...as it 
generated every time you hit the rest api call, now it will generated during 
startup on a thread, from that point you will be able to acces the docs from 
the memory)

Also some UI changes:
- there was a /api/v1/pulbic/config call, instead of it, uses /api/v1/info/auth 
with returning a simple map json (not that weird name value structure)...use 
that endpoint in login.html


Diffs
-

  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchPropertyDescription.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 45281b6 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/ApiDocStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 a2a7f5e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/PropertyDescriptionStorage.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 9d4e96e 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/AuthPropsConfig.java
 54cc10c 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchHttpHeaderConfig.java
 cb8c097 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 441b628 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 5981bcc 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 7d37efd 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrEventHistoryPropsConfig.java
 a117501 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrKerberosConfig.java
 7cf79b0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SolrServiceLogPropsConfig.java
 482438a 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 73de0ee 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/PublicManager.java
 cbab651 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/response/PropertyDescriptionData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/PublicResource.java
 df83d44 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/SwaggerResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 d4b6544 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
 1b77753 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 1dab126 
  ambari-logsearch/ambari-logsearch-web/src/main/webapp/login.html f2cb2c7 


Diff: https://reviews.apache.org/r/60501/diff/1/


Testing
---

done. manually & check /docs endpoint


Thanks,

Oliver Szabo

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179104
---


Ship it!




Ship It!

- Jonathan Hurley


On June 28, 2017, 8:27 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 8:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/
---

(Updated June 28, 2017, 1:34 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.


Bugs: AMBARI-21359
https://issues.apache.org/jira/browse/AMBARI-21359


Repository: ambari


Description
---

This is for the JavaVersionCheck check defined in the cross stack upgrade pack 
EU xml file.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 71c5857 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60481/diff/2/

Changes: https://reviews.apache.org/r/60481/diff/1-2/


Testing
---

to be tested later on with the integrated tests.


Thanks,

Di Li

Re: Review Request 60488: Ability to delete a view instance from view instance list

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60488/#review179098
---


Ship it!




Ship It!

- Di Li


On June 28, 2017, 5:21 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60488/
> ---
> 
> (Updated June 28, 2017, 5:21 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21360
> https://issues.apache.org/jira/browse/AMBARI-21360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, a view instance is deleted by editing the instance and clicking on 
> 'Deleting instance'.
> It helps to be able to delete the instance directly from the view instance 
> list without having to edit the view instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js
>  c41e5d4 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  59c322f 
> 
> 
> Diff: https://reviews.apache.org/r/60488/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/#review179097
---


Ship it!




Ship It!

- Di Li


On June 28, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60489/
> ---
> 
> (Updated June 28, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21274
> https://issues.apache.org/jira/browse/AMBARI-21274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If there are issues with yarn service check queue or mapreduce job queue 
> configurations, service advisor throws an error with a typo.
> 
> Queue is not exist or not corresponds to existing YARN leaf queue
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> b6f1965 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> e62e00c 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py
>  5a95fe3 
> 
> 
> Diff: https://reviews.apache.org/r/60489/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Ran python tests cleanly.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179096
---


Ship it!




Ship It!

- Dmytro Grinenko


On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/
---

(Updated June 28, 2017, 2:27 p.m.)


Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
Lisnichenko, and Jonathan Hurley.


Changes
---

removed unnecessary test logic


Bugs: AMBARI-21362
https://issues.apache.org/jira/browse/AMBARI-21362


Repository: ambari


Description
---

Check for source column existence, too.


Diffs (updated)
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
13e7d7d148795325cd0d1c698eae084f2f00a411 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
 ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 


Diff: https://reviews.apache.org/r/60498/diff/2/

Changes: https://reviews.apache.org/r/60498/diff/1-2/


Testing
---

Manually tested:
 * real upgrade from 2.4.2 for any regression
 * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0

New unit test.


Thanks,

Attila Doroszlai

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Dmytro Grinenko]

> On June 28, 2017, 12:10 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
> > Lines 683 (patched)
> > 
> >
> > If we checking here for idempotent issue, does we need to check the 
> > resulset?
> > 
> > In case if function would be not idempotent, second update call will 
> > cause exception, hence we need to check for this
> 
> Attila Doroszlai wrote:
> Yes, it's not strictly necessary.  Should I remove everything after the 
> `moveColumnToAnotherTable` call then?

yes, it will help to better understand for what this test is needed. thanks


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179091
---


On June 28, 2017, 8:59 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 8:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Attila Doroszlai]

> On June 28, 2017, 2:10 p.m., Dmytro Grinenko wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
> > Lines 683 (patched)
> > 
> >
> > If we checking here for idempotent issue, does we need to check the 
> > resulset?
> > 
> > In case if function would be not idempotent, second update call will 
> > cause exception, hence we need to check for this

Yes, it's not strictly necessary.  Should I remove everything after the 
`moveColumnToAnotherTable` call then?


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179091
---


On June 28, 2017, 10:59 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 10:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/#review179091
---




ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
Lines 683 (patched)


If we checking here for idempotent issue, does we need to check the 
resulset?

In case if function would be not idempotent, second update call will cause 
exception, hence we need to check for this


- Dmytro Grinenko


On June 28, 2017, 8:59 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60498/
> ---
> 
> (Updated June 28, 2017, 8:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
> Lisnichenko, and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21362
> https://issues.apache.org/jira/browse/AMBARI-21362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Check for source column existence, too.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
> 13e7d7d148795325cd0d1c698eae084f2f00a411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
>  ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 
> 
> 
> Diff: https://reviews.apache.org/r/60498/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested:
>  * real upgrade from 2.4.2 for any regression
>  * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0
> 
> New unit test.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60489/#review179089
---


Ship it!




Ship It!

- Tim Thorpe


On June 28, 2017, 5:23 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60489/
> ---
> 
> (Updated June 28, 2017, 5:23 a.m.)
> 
> 
> Review request for Ambari, Di Li and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21274
> https://issues.apache.org/jira/browse/AMBARI-21274
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If there are issues with yarn service check queue or mapreduce job queue 
> configurations, service advisor throws an error with a typo.
> 
> Queue is not exist or not corresponds to existing YARN leaf queue
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 3a39a34 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> b6f1965 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> e62e00c 
>   
> contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/stack_advisor.py
>  5a95fe3 
> 
> 
> Diff: https://reviews.apache.org/r/60489/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> Ran python tests cleanly.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 60459: Workflow Manager view build failure

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:25 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description (updated)
---

Changed package.json to fix the build failure.
Due to version mismatch in meta data of bower repository, the latest version 
shown doesnt have the required modules to import.
Downgrading verison to fix the issue.


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 3f9de44 


Diff: https://reviews.apache.org/r/60459/diff/3/

Changes: https://reviews.apache.org/r/60459/diff/2-3/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 60459: Workflow Manager view build failure

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:15 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description (updated)
---

Changed pom.xml to fix the build failure.
Due to version mismatch in meta data of bower repository, the latest version 
shown doesnt have the required modules to import.
Downgrading verison to fix the issue.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 


Diff: https://reviews.apache.org/r/60459/diff/2/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Re: Review Request 60459: Workflow Manager view build failure

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60459/
---

(Updated June 28, 2017, 9:13 a.m.)


Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav 
Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-21352
https://issues.apache.org/jira/browse/AMBARI-21352


Repository: ambari


Description
---

Changed pom.xml to fix the build failure


Diffs (updated)
-

  contrib/views/wfmanager/src/main/resources/ui/bower.json 06fc3e3 


Diff: https://reviews.apache.org/r/60459/diff/2/

Changes: https://reviews.apache.org/r/60459/diff/1-2/


Testing
---

Manual testing done.


Thanks,

venkat sairam

Review Request 60498: AMBARI-21362. Ambari upgrade not idempotent due to column move

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60498/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro 
Lisnichenko, and Jonathan Hurley.


Bugs: AMBARI-21362
https://issues.apache.org/jira/browse/AMBARI-21362


Repository: ambari


Description
---

Check for source column existence, too.


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 
13e7d7d148795325cd0d1c698eae084f2f00a411 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java
 ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 


Diff: https://reviews.apache.org/r/60498/diff/1/


Testing
---

Manually tested:
 * real upgrade from 2.4.2 for any regression
 * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0

New unit test.


Thanks,

Attila Doroszlai

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

[Attila Magyar]

> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 72 (patched)
> > 
> >
> > Should probably be named `getComponentDescriptor`

Is this an Ambari convention? Under what circumstances do we like using the get 
prefix? I feel most of the times this doesn't add too much extra information. 
Yes, this method returns a value, but most of the methods return a value anyway 
(there are programming languages where every function returns a value), and I 
would rather highlight the differences instead of the similarities.
Some people like using the get prefix when the method returns a stored value 
instead of a calculated one. This is also debatable IMO, but here it's not the 
case, because these methods do calculations. And also they're private with very 
little scope.


> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 77 (patched)
> > 
> >
> > Should be named `getIdentityNames`

See my comment above.


> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 96 (patched)
> > 
> >
> > Should be named `getActiveIdentities`

See my comment above.


> On June 27, 2017, 6:45 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
> > Lines 114 (patched)
> > 
> >
> > Should be named `isSameComponent`

See my comment above.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/#review179008
---


On June 28, 2017, 8:06 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60431/
> ---
> 
> (Updated June 28, 2017, 8:06 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, 
> Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-21343
> https://issues.apache.org/jira/browse/AMBARI-21343
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upon removing a component from a host, the relevant Kerberos identities 
> should be removed as well. This includes any principals and keytab files. 
> Care must be taken not to remove any principals or keytab files that are 
> still in use in the cluster.
> 
> 
> Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of 
> the identities of the uninstalled component, except the ones that are still 
> used by other services/components.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e8c986b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  d000571 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  e4b70fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  7824019 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
>  0b845d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  9755bd6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
>  2112fcc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
>  ca9f013 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
>  86a5e01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
>  a606954 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/K

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179081
---




ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 100-101 (patched)


`Configuration.getJavaVersion` does not require any information from the 
`Configuration` instance, it only checks a system property.  Can you please 
make it `static` to avoid unnecessarily reading the config file?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 105 (patched)


This method duplicates most of `Configuration.getJavaVersion`.  This 
duplication could be reduced by making this method `public static`, and reusing 
it from `Configuration`.  Ideally, put it in some utility class.


- Attila Doroszlai


On June 27, 2017, 11:02 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 27, 2017, 11:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60488: Ability to delete a view instance from view instance list

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60488/#review179080
---


Ship it!




Ship It!

- Alexandr Antonenko


On June 28, 2017, 5:21 a.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60488/
> ---
> 
> (Updated June 28, 2017, 5:21 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-21360
> https://issues.apache.org/jira/browse/AMBARI-21360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently, a view instance is deleted by editing the instance and clicking on 
> 'Deleting instance'.
> It helps to be able to delete the instance directly from the view instance 
> list without having to edit the view instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js
>  c41e5d4 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  59c322f 
> 
> 
> Diff: https://reviews.apache.org/r/60488/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60481/#review179074
---




ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 336 (patched)


Why put a specific version in the message here?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 34-35 (patched)


"Hive Metastore"?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 44 (patched)


Comment belongs to previous line, doesn't it?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 82 (patched)


Seems to have 2 arguments for single `%s`.

What does the message turn out in this case?  Isn't it something like "... 
requires at least JDK Java ..."?



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 93 (patched)


`javaVersionS` may be null, which shouldn't be displayed in the formatted 
message



ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
Lines 95 (patched)


unnecessary


- Attila Doroszlai


On June 27, 2017, 11:02 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60481/
> ---
> 
> (Updated June 27, 2017, 11:02 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21359
> https://issues.apache.org/jira/browse/AMBARI-21359
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is for the JavaVersionCheck check defined in the cross stack upgrade 
> pack EU xml file.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  71c5857 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/JavaVersionCheck.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60481/diff/1/
> 
> 
> Testing
> ---
> 
> to be tested later on with the integrated tests.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60431/
---

(Updated June 28, 2017, 8:06 a.m.)


Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Laszlo Puskas, 
Robert Levas, and Sebastian Toader.


Changes
---

added missing copyrights and javadocs


Bugs: AMBARI-21343
https://issues.apache.org/jira/browse/AMBARI-21343


Repository: ambari


Description
---

Upon removing a component from a host, the relevant Kerberos identities should 
be removed as well. This includes any principals and keytab files. Care must be 
taken not to remove any principals or keytab files that are still in use in the 
cluster.


Entry point is KerberosIdentityCleaner>>componentRemoved. It removes all of the 
identities of the uninstalled component, except the ones that are still used by 
other services/components.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 e8c986b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 d000571 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 e4b70fd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/OrderedRequestStageContainer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleaner.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 7824019 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/Component.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
 0b845d9 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 9755bd6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptor.java
 2112fcc 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptor.java
 ca9f013 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosDescriptor.java
 86a5e01 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 a606954 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptor.java
 0f14ca6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/KerberosIdentityCleanerTest.java
 PRE-CREATION 
  ambari-web/app/controllers/main/service/item.js 09c7a9c 


Diff: https://reviews.apache.org/r/60431/diff/6/

Changes: https://reviews.apache.org/r/60431/diff/5-6/


Testing
---

Added new unittests
End to end tested manually:

before all:
 - created a cluster with oozie
 - enabled kerberos
1.
 - removed oozie
 - checked if oozie_server principal and keytab was removed, and other 
identites weren't touched
2.
 - made the kdc admin credentials expired
 - removed oozie
 - supplied kdc admin credentials on the ui
 - checked if oozie_server principal and keytab was removed
3.
 - added oozie_server principal to a kerberos.json of an other service (so that 
the principal was shared)
 - removed oozie
 - checked if the oozie_server principal and keytab was NOT removed
4.
 - disabled kerberos
 - removed oozie
 - checked that there was no identity deletion attempt


Existing Tests:
Results :
Tests run: 4790, Failures: 0, Errors: 0, Skipped: 35
Ran 244 tests in 7.122s

OK
--
Total run:1146
Total errors:0
Total failures:0
OK


Thanks,

Attila Magyar