Re: Review Request 62949: RU: Downgrade is failed ZKFC

[Nate Cole]

> On Oct. 12, 2017, 5:46 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
> > Lines 365-375 (original), 364-371 (patched)
> > 
> >
> > Does this change work for revert? If you've finallized, then we've send 
> > the event which tells services to reload their components from the new 
> > desired stack IDs.
> > 
> > On revert of that patch, at this point, they would still be the new 
> > stack IDs, right?
> > 
> > I guess no componenents should be changing this between 3rd and 4th 
> > digits anyway. Just wanted to check - if you think this case isn't valid, 
> > then drop the issue.
> 
> Nate Cole wrote:
> I'll test that scenario.

Tested RU/Downgrade, RU/Finalize, EU/Downgrade, EU/Finalize and PU/Downgrade, 
PU/Finalize and they all worked as expected.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187876
---


On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62949/
> ---
> 
> (Updated Oct. 12, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-6
> https://issues.apache.org/jira/browse/AMBARI-6
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The code to check versions was only looking at the upgrade context repo 
> version, not the target service repo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
>  f80d06accc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  0ce5d30b0b 
> 
> 
> Diff: https://reviews.apache.org/r/62949/diff/1/
> 
> 
> Testing
> ---
> 
> No new tests, just verify existing tests pass.
> Manual.  Unit tests:
> 
> [INFO]
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4919, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:49.685s
> [INFO] Finished at: Thu Oct 12 17:00:33 EDT 2017
> [INFO] Final Memory: 108M/1943M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/
---

(Updated Oct. 12, 2017, 11:47 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan Shridhar.


Changes
---

Review comments


Bugs: AMBARI-22181
https://issues.apache.org/jira/browse/AMBARI-22181


Repository: ambari


Description
---

Remove cluster-stackid dependency related to Configs


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 6726d30e80 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d0dd7e0d9c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 98b1edf6a4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
 29f8e2acbd 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
bb7fcbed3d 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
 cf556609a4 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
8f9d8e1b0b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 3bde889b4b 


Diff: https://reviews.apache.org/r/62856/diff/3/

Changes: https://reviews.apache.org/r/62856/diff/2-3/


Testing
---

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 11:01 min
[INFO] Finished at: 2017-10-09T21:40:34-07:00
[INFO] Final Memory: 359M/1174M
[INFO] 


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

[Madhuvanthi Radhakrishnan]

> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Line 664 (original), 664 (patched)
> > 
> >
> > We have to look at references to this function and see how the 
> > servicesMap is populated. 
> > 
> > For example in configHelper.createUserGroupMap() we will end up 
> > creating user to group mapping only for a single mpack instead of multiple 
> > mpacks.
> 
> Madhuvanthi Radhakrishnan wrote:
> Hi Jayush,
> The reason I went ahead with the change was that all the references to 
> this and its overloaded counterpart populates servicesMap based on a stackId 
> that is obtained from either a service or a serviceComponent. So it seemed 
> that it is not coming from the cluster's stackid.
> For eg:
> AmbariManagementControllerImpl
> StackId stackId = scHost.getServiceComponent().getDesiredStackId();
> StackInfo stackInfo = ambariMetaInfo.getStack(stackId.getStackName(),
> stackId.getStackVersion());
> Map servicesMap = 
> ambariMetaInfo.getServices(stackInfo.getName(), stackInfo.getVersion());
> Map userGroupsMap = configHelper.createUserGroupsMap(
>   cluster, clusterDesiredConfigs, servicesMap, stackProperties);
>   
> public Map createUserGroupsMap(
> Cluster cluster, Map desiredConfigs,
> Map servicesMap, Set 
> stackProperties) throws AmbariException {

I have made a fix in createHostAction to the way the servicesMap is being 
populated.
Currently, it is using service stackId to get the serviceInfo list from the 
ambariMetaInfo.
I have changed it to put all the cluster services in the servicesMap.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62856/#review187503
---


On Oct. 12, 2017, 11:47 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62856/
> ---
> 
> (Updated Oct. 12, 2017, 11:47 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22181
> https://issues.apache.org/jira/browse/AMBARI-22181
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove cluster-stackid dependency related to Configs
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  6726d30e80 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d0dd7e0d9c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  98b1edf6a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java
>  29f8e2acbd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> bb7fcbed3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigMergeHelper.java
>  cf556609a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 8f9d8e1b0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3bde889b4b 
> 
> 
> Diff: https://reviews.apache.org/r/62856/diff/3/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 11:01 min
> [INFO] Finished at: 2017-10-09T21:40:34-07:00
> [INFO] Final Memory: 359M/1174M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 62949: RU: Downgrade is failed ZKFC

[Nate Cole]

> On Oct. 12, 2017, 5:46 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
> > Lines 365-375 (original), 364-371 (patched)
> > 
> >
> > Does this change work for revert? If you've finallized, then we've send 
> > the event which tells services to reload their components from the new 
> > desired stack IDs.
> > 
> > On revert of that patch, at this point, they would still be the new 
> > stack IDs, right?
> > 
> > I guess no componenents should be changing this between 3rd and 4th 
> > digits anyway. Just wanted to check - if you think this case isn't valid, 
> > then drop the issue.

I'll test that scenario.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187876
---


On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62949/
> ---
> 
> (Updated Oct. 12, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-6
> https://issues.apache.org/jira/browse/AMBARI-6
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The code to check versions was only looking at the upgrade context repo 
> version, not the target service repo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
>  f80d06accc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  0ce5d30b0b 
> 
> 
> Diff: https://reviews.apache.org/r/62949/diff/1/
> 
> 
> Testing
> ---
> 
> No new tests, just verify existing tests pass.
> Manual.  Unit tests:
> 
> [INFO]
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4919, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 26:49.685s
> [INFO] Finished at: Thu Oct 12 17:00:33 EDT 2017
> [INFO] Final Memory: 108M/1943M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62949: RU: Downgrade is failed ZKFC

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187878
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62949/
> ---
> 
> (Updated Oct. 12, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-6
> https://issues.apache.org/jira/browse/AMBARI-6
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The code to check versions was only looking at the upgrade context repo 
> version, not the target service repo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
>  f80d06accc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  0ce5d30b0b 
> 
> 
> Diff: https://reviews.apache.org/r/62949/diff/1/
> 
> 
> Testing
> ---
> 
> No new tests, just verify existing tests pass.
> Manual.  Unit pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62949: RU: Downgrade is failed ZKFC

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187876
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
Line 87 (original), 86 (patched)


Thank you! I think this was my fault anyway from like 3 months ago :)



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
Lines 365-375 (original), 364-371 (patched)


Does this change work for revert? If you've finallized, then we've send the 
event which tells services to reload their components from the new desired 
stack IDs.

On revert of that patch, at this point, they would still be the new stack 
IDs, right?

I guess no componenents should be changing this between 3rd and 4th digits 
anyway. Just wanted to check - if you think this case isn't valid, then drop 
the issue.


- Jonathan Hurley


On Oct. 12, 2017, 4:46 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62949/
> ---
> 
> (Updated Oct. 12, 2017, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-6
> https://issues.apache.org/jira/browse/AMBARI-6
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The code to check versions was only looking at the upgrade context repo 
> version, not the target service repo
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
>  f80d06accc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  0ce5d30b0b 
> 
> 
> Diff: https://reviews.apache.org/r/62949/diff/1/
> 
> 
> Testing
> ---
> 
> No new tests, just verify existing tests pass.
> Manual.  Unit pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62948/#review187871
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 12, 2017, 8:33 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62948/
> ---
> 
> (Updated Oct. 12, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Nate Cole, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-5
> https://issues.apache.org/jira/browse/AMBARI-5
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster created with Blueprint using host predicates rejects hosts even 
> though their host_name matches the host predicate.
> 
> `{ "name": "workernode", "host_count": "2", "host_predicate": 
> "Hosts/host_name.matches(agent-*)" }`
> 
> ```
> 11 Oct 2017 17:03:11,296  INFO [qtp-ambari-agent-56] TopologyManager:698 - 
> TopologyManager: Queueing available host agent-1
> 11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] TopologyManager:876 
> - TopologyManager.processRequest: offering host name = agent-1 to 
> LogicalRequest ID = 1
> 11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] LogicalRequest:101 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,784  INFO [ambari-client-thread-45] LogicalRequest:125 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> non-reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,791  INFO [ambari-client-thread-45] LogicalRequest:138 - 
> LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
> agent-1
> 11 Oct 2017 17:04:56,792  INFO [ambari-client-thread-45] LogicalRequest:125 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> non-reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,793  INFO [ambari-client-thread-45] LogicalRequest:138 - 
> LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
> agent-1
> 11 Oct 2017 17:04:56,794  INFO [ambari-client-thread-45] TopologyManager:896 
> - TopologyManager.processRequest: host name = agent-1 was DECLINED_PREDICATE 
> by LogicalRequest ID = 1
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  784c923 
> 
> 
> Diff: https://reviews.apache.org/r/62948/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint with host predicates.
> 
> Unit tests:
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [ 35.702 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.008 
> s]
> [INFO] Ambari Views ... SUCCESS [  4.404 
> s]
> [INFO] utility  SUCCESS [  1.716 
> s]
> [INFO] ambari-metrics . SUCCESS [  1.187 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.373 
> s]
> [INFO] Ambari Server .. SUCCESS [24:04 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62948/#review187865
---


Ship it!




Ship It!

- Robert Levas


On Oct. 12, 2017, 4:33 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62948/
> ---
> 
> (Updated Oct. 12, 2017, 4:33 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Nate Cole, Robert Levas, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-5
> https://issues.apache.org/jira/browse/AMBARI-5
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster created with Blueprint using host predicates rejects hosts even 
> though their host_name matches the host predicate.
> 
> `{ "name": "workernode", "host_count": "2", "host_predicate": 
> "Hosts/host_name.matches(agent-*)" }`
> 
> ```
> 11 Oct 2017 17:03:11,296  INFO [qtp-ambari-agent-56] TopologyManager:698 - 
> TopologyManager: Queueing available host agent-1
> 11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] TopologyManager:876 
> - TopologyManager.processRequest: offering host name = agent-1 to 
> LogicalRequest ID = 1
> 11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] LogicalRequest:101 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,784  INFO [ambari-client-thread-45] LogicalRequest:125 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> non-reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,791  INFO [ambari-client-thread-45] LogicalRequest:138 - 
> LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
> agent-1
> 11 Oct 2017 17:04:56,792  INFO [ambari-client-thread-45] LogicalRequest:125 - 
> LogicalRequest.offer: attempting to match a request to a request for a 
> non-reserved host to hostname = agent-1
> 11 Oct 2017 17:04:56,793  INFO [ambari-client-thread-45] LogicalRequest:138 - 
> LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
> agent-1
> 11 Oct 2017 17:04:56,794  INFO [ambari-client-thread-45] TopologyManager:896 
> - TopologyManager.processRequest: host name = agent-1 was DECLINED_PREDICATE 
> by LogicalRequest ID = 1
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
>  784c923 
> 
> 
> Diff: https://reviews.apache.org/r/62948/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing with Blueprint with host predicates.
> 
> Unit tests:
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [ 35.702 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.008 
> s]
> [INFO] Ambari Views ... SUCCESS [  4.404 
> s]
> [INFO] utility  SUCCESS [  1.716 
> s]
> [INFO] ambari-metrics . SUCCESS [  1.187 
> s]
> [INFO] Ambari Metrics Common .. SUCCESS [  7.373 
> s]
> [INFO] Ambari Server .. SUCCESS [24:04 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 62949: RU: Downgrade is failed ZKFC

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-6
https://issues.apache.org/jira/browse/AMBARI-6


Repository: ambari


Description
---

The code to check versions was only looking at the upgrade context repo 
version, not the target service repo


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java
 f80d06accc 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 0ce5d30b0b 


Diff: https://reviews.apache.org/r/62949/diff/1/


Testing
---

No new tests, just verify existing tests pass.
Manual.  Unit pending.


Thanks,

Nate Cole

Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62948/
---

Review request for Ambari, Balázs Bence Sári, Nate Cole, Robert Levas, and 
Sandor Magyari.


Bugs: AMBARI-5
https://issues.apache.org/jira/browse/AMBARI-5


Repository: ambari


Description
---

Cluster created with Blueprint using host predicates rejects hosts even though 
their host_name matches the host predicate.

`{ "name": "workernode", "host_count": "2", "host_predicate": 
"Hosts/host_name.matches(agent-*)" }`

```
11 Oct 2017 17:03:11,296  INFO [qtp-ambari-agent-56] TopologyManager:698 - 
TopologyManager: Queueing available host agent-1
11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] TopologyManager:876 - 
TopologyManager.processRequest: offering host name = agent-1 to LogicalRequest 
ID = 1
11 Oct 2017 17:04:56,783  INFO [ambari-client-thread-45] LogicalRequest:101 - 
LogicalRequest.offer: attempting to match a request to a request for a reserved 
host to hostname = agent-1
11 Oct 2017 17:04:56,784  INFO [ambari-client-thread-45] LogicalRequest:125 - 
LogicalRequest.offer: attempting to match a request to a request for a 
non-reserved host to hostname = agent-1
11 Oct 2017 17:04:56,791  INFO [ambari-client-thread-45] LogicalRequest:138 - 
LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
agent-1
11 Oct 2017 17:04:56,792  INFO [ambari-client-thread-45] LogicalRequest:125 - 
LogicalRequest.offer: attempting to match a request to a request for a 
non-reserved host to hostname = agent-1
11 Oct 2017 17:04:56,793  INFO [ambari-client-thread-45] LogicalRequest:138 - 
LogicalRequest.offer: host request returned DECLINED_PREDICATE for hostname = 
agent-1
11 Oct 2017 17:04:56,794  INFO [ambari-client-thread-45] TopologyManager:896 - 
TopologyManager.processRequest: host name = agent-1 was DECLINED_PREDICATE by 
LogicalRequest ID = 1
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
784c923 


Diff: https://reviews.apache.org/r/62948/diff/1/


Testing
---

Manual testing with Blueprint with host predicates.

Unit tests:
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main  SUCCESS [ 35.702 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.008 s]
[INFO] Ambari Views ... SUCCESS [  4.404 s]
[INFO] utility  SUCCESS [  1.716 s]
[INFO] ambari-metrics . SUCCESS [  1.187 s]
[INFO] Ambari Metrics Common .. SUCCESS [  7.373 s]
[INFO] Ambari Server .. SUCCESS [24:04 min]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 


Thanks,

Sebastian Toader

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62941/#review187849
---


Ship it!




Ship It!

- Aravindan Vijayan


On Oct. 12, 2017, 7:10 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62941/
> ---
> 
> (Updated Oct. 12, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-22192
> https://issues.apache.org/jira/browse/AMBARI-22192
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Investigate Play Server / Dropwizard / Akka for HTTP server needs. 
> * Setup the server for configuration
> * Simple startup ('do nothing' is good enough).
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 6f8f8c1 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/DefaultHealthCheck.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/GuiceInjector.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
>  5e90d2b 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryService.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryServiceImpl.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardAppRuleHelper.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardResourceTestRuleHelper.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/ADManagerConfigurationTest.scala
>  535dc9e 
>   ambari-metrics/ambari-metrics-common/pom.xml e868557 
>   ambari-metrics/pom.xml fb2997a 
>   ambari-utility/pom.xml 1e86d40 
> 
> 
> Diff: https://reviews.apache.org/r/62941/diff/2/
> 
> 
> Testing
> ---
> 
> Issue with drop wizard logging still to be resolved.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/#review187845
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 12, 2017, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62945/
> ---
> 
> (Updated Oct. 12, 2017, 2:57 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-4
> https://issues.apache.org/jira/browse/AMBARI-4
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The host and hostname built-in variables are not populated when performing 
> Kerberos-related operations.  These variables may be used like 
> 
> ```
> service-${host}
> ```
> 
> If the current host being processed is host1.example.com, the value should be 
> converted to
> 
> ```
> service-host1.example.com
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f8fe31a33d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  3db844ad2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  d18f333e6b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  8ff5ad27c3 
> 
> 
> Diff: https://reviews.apache.org/r/62945/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:35 min
> [INFO] Finished at: 2017-10-12T13:44:20-04:00
> [INFO] Final Memory: 72M/877M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62941/
---

(Updated Oct. 12, 2017, 7:10 p.m.)


Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-22192
https://issues.apache.org/jira/browse/AMBARI-22192


Repository: ambari


Description
---

* Investigate Play Server / Dropwizard / Akka for HTTP server needs. 
* Setup the server for configuration
* Simple startup ('do nothing' is good enough).


Diffs (updated)
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 6f8f8c1 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/DefaultHealthCheck.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/GuiceInjector.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
 5e90d2b 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryService.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryServiceImpl.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardAppRuleHelper.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardResourceTestRuleHelper.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/ADManagerConfigurationTest.scala
 535dc9e 
  ambari-metrics/ambari-metrics-common/pom.xml e868557 
  ambari-metrics/pom.xml fb2997a 
  ambari-utility/pom.xml 1e86d40 


Diff: https://reviews.apache.org/r/62941/diff/2/

Changes: https://reviews.apache.org/r/62941/diff/1-2/


Testing
---

Issue with drop wizard logging still to be resolved.


Thanks,

Sid Wagle

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/#review187843
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 12, 2017, 8:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62945/
> ---
> 
> (Updated Oct. 12, 2017, 8:57 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-4
> https://issues.apache.org/jira/browse/AMBARI-4
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The host and hostname built-in variables are not populated when performing 
> Kerberos-related operations.  These variables may be used like 
> 
> ```
> service-${host}
> ```
> 
> If the current host being processed is host1.example.com, the value should be 
> converted to
> 
> ```
> service-host1.example.com
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f8fe31a33d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  3db844ad2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  d18f333e6b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  8ff5ad27c3 
> 
> 
> Diff: https://reviews.apache.org/r/62945/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:35 min
> [INFO] Finished at: 2017-10-12T13:44:20-04:00
> [INFO] Final Memory: 72M/877M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/#review187842
---


Ship it!




Ship It!

- Nate Cole


On Oct. 12, 2017, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62945/
> ---
> 
> (Updated Oct. 12, 2017, 2:57 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-4
> https://issues.apache.org/jira/browse/AMBARI-4
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The host and hostname built-in variables are not populated when performing 
> Kerberos-related operations.  These variables may be used like 
> 
> ```
> service-${host}
> ```
> 
> If the current host being processed is host1.example.com, the value should be 
> converted to
> 
> ```
> service-host1.example.com
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f8fe31a33d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  3db844ad2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  d18f333e6b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  8ff5ad27c3 
> 
> 
> Diff: https://reviews.apache.org/r/62945/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:35 min
> [INFO] Finished at: 2017-10-12T13:44:20-04:00
> [INFO] Final Memory: 72M/877M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62941/#review187840
---




ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
Lines 33 (patched)


Can we change this to something AD specific ?


- Aravindan Vijayan


On Oct. 12, 2017, 6:09 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62941/
> ---
> 
> (Updated Oct. 12, 2017, 6:09 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-22192
> https://issues.apache.org/jira/browse/AMBARI-22192
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Investigate Play Server / Dropwizard / Akka for HTTP server needs. 
> * Setup the server for configuration
> * Simple startup ('do nothing' is good enough).
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 6f8f8c1 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/DefaultHealthCheck.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/GuiceInjector.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
>  5e90d2b 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryService.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryServiceImpl.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardAppRuleHelper.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardResourceTestRuleHelper.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/ADManagerConfigurationTest.scala
>  535dc9e 
>   ambari-metrics/ambari-metrics-common/pom.xml e868557 
>   ambari-metrics/pom.xml fb2997a 
>   ambari-utility/pom.xml 1e86d40 
> 
> 
> Diff: https://reviews.apache.org/r/62941/diff/1/
> 
> 
> Testing
> ---
> 
> Issue with drop wizard logging still to be resolved.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/#review187837
---




ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Line 1647 (original), 1647 (patched)


There was no reason to change the Ambari server host to `null`.  It must 
have been left over from old code or a quick refactoring.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
Lines 145-156 (patched)


This had been previously optimized out trying to not _recompile_ 
configuration data for every processed host.  So now the host information needs 
to be added to the configuration conext used for variable replacement 
operations.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
Lines 308-319 (patched)


This had been previously optimized out trying to not _recompile_ 
configuration data for every processed host.  So now the host information needs 
to be added to the configuration conext used for variable replacement 
operations.


- Robert Levas


On Oct. 12, 2017, 2:57 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62945/
> ---
> 
> (Updated Oct. 12, 2017, 2:57 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-4
> https://issues.apache.org/jira/browse/AMBARI-4
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The host and hostname built-in variables are not populated when performing 
> Kerberos-related operations.  These variables may be used like 
> 
> ```
> service-${host}
> ```
> 
> If the current host being processed is host1.example.com, the value should be 
> converted to
> 
> ```
> service-host1.example.com
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f8fe31a33d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  3db844ad2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
>  d18f333e6b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
>  8ff5ad27c3 
> 
> 
> Diff: https://reviews.apache.org/r/62945/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:35 min
> [INFO] Finished at: 2017-10-12T13:44:20-04:00
> [INFO] Final Memory: 72M/877M
> [INFO] 
> 
> ```
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62945/
---

Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Jonathan Hurley, Laszlo Puskas, Nate Cole, and Sebastian Toader.


Bugs: AMBARI-4
https://issues.apache.org/jira/browse/AMBARI-4


Repository: ambari


Description
---

The host and hostname built-in variables are not populated when performing 
Kerberos-related operations.  These variables may be used like 

```
service-${host}
```

If the current host being processed is host1.example.com, the value should be 
converted to

```
service-host1.example.com
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 f8fe31a33d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 3db844ad2a 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java
 d18f333e6b 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerActionTest.java
 8ff5ad27c3 


Diff: https://reviews.apache.org/r/62945/diff/1/


Testing
---

Manually tested

# Local test results: 
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:35 min
[INFO] Finished at: 2017-10-12T13:44:20-04:00
[INFO] Final Memory: 72M/877M
[INFO] 
```


Thanks,

Robert Levas

Review Request 62943: AMBARI-22220 - Should be able to switch the extension version to which a stack version is linked

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62943/
---

Review request for Ambari, Di Li, Jonathan Hurley, and Jayush Luniya.


Bugs: AMBARI-0
https://issues.apache.org/jira/browse/AMBARI-0


Repository: ambari


Description
---

Currently the only way to switch the extension version to which a stack version 
is linked is to perform the following actions:

Stop the extension services
Reregister (delete) the extension services
Unlink the old extension version
Link the new extension version
Add the extension services back

The REST API should allow us to do an update action on the extension link. In 
this manner, if we were running an upgrade from HDP 2.6.1 to 2.6.3 (or 
something similar) which both use the HDP 2.6 stack version then we could 
perform the extension link switch as a manual step during the upgrade process.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 f0f13e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 b0eb8ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java
 0c8edfe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 9b894ff 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionHelper.java 
91dc870 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java
 cef30b5 
  ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml c95a20f 
  ambari-server/src/test/resources/extensions/EXT/0.4/metainfo.xml PRE-CREATION 
  
ambari-server/src/test/resources/extensions/EXT/0.4/services/OOZIE2/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/extensions/EXT/0.4/services/OOZIE2/themes/broken_theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62943/diff/1/


Testing
---

mvn test 
-Dtest=StackManagerCommonServicesTest,StackManagerTest,StackManagerMiscTest,StackManagerExtensionTest

Manual testing both valid and invalid extension version updates


Thanks,

Tim Thorpe

Review Request 62941: [Preliminary] Setup an application server for hosting the AD System Manager

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62941/
---

Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-22192
https://issues.apache.org/jira/browse/AMBARI-22192


Repository: ambari


Description
---

* Investigate Play Server / Dropwizard / Akka for HTTP server needs. 
* Setup the server for configuration
* Simple startup ('do nothing' is good enough).


Diffs
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 6f8f8c1 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/DefaultHealthCheck.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/GuiceInjector.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
 5e90d2b 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/AnomalyResource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/resource/RootResource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryService.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/service/ADQueryServiceImpl.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DefaultADResourceSpecTest.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardAppRuleHelper.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/app/DropwizardResourceTestRuleHelper.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/common/ADManagerConfigurationTest.scala
 535dc9e 
  ambari-metrics/ambari-metrics-common/pom.xml e868557 
  ambari-metrics/pom.xml fb2997a 
  ambari-utility/pom.xml 1e86d40 


Diff: https://reviews.apache.org/r/62941/diff/1/


Testing
---

Issue with drop wizard logging still to be resolved.


Thanks,

Sid Wagle

Re: Review Request 62932: Deploy fails due to PU code related issues (post-merge)

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62932/#review187819
---


Ship it!




Ship It!

- Sid Wagle


On Oct. 12, 2017, 12:38 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62932/
> ---
> 
> (Updated Oct. 12, 2017, 12:38 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22217
> https://issues.apache.org/jira/browse/AMBARI-22217
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
> 2270dcef32 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  a6a05bf39b 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  26b0af0a99 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
>  a76a6e327a 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
>  d9233a3151 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> 9a046b9404 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
>  852a9cb664 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
>  869c329a5e 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/status_params.py
>  3cbd920b23 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/status_params.py
>  ce990cf8fa 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py
>  b88f1a4d96 
>   
> ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/status_params.py
>  842430ba46 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py
>  da8eb8ca40 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/status_params.py
>  34d008208b 
>   
> ambari-server/src/main/resources/common-services/SQOOP/1.4.4.3.0/package/scripts/params_linux.py
>  400c87c828 
>   
> ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/status_params.py
>  d84b0950a9 
>   
> ambari-server/src/main/resources/common-services/SUPERSET/0.15.0/package/scripts/params.py
>  b38d6438aa 
>   ambari-server/src/test/python/custom_actions/test_ru_execute_tasks.py 
> 0d12a91276 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py de83f7e07b 
> 
> 
> Diff: https://reviews.apache.org/r/62932/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/
---

(Updated Oct. 12, 2017, 6:36 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22216
https://issues.apache.org/jira/browse/AMBARI-22216


Repository: ambari


Description
---

For now, patch with workaround for issue on QA cluster.

Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 2430 
to 2600)
ambari-server.log
{code}
03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT NOT 
NULL DEFAULT 1
03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id BIGINT
03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id BIGINT 
NOT NULL
03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
DEFAULT 'CURRENT'
03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
NULL
03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT FK_scds_desired_repo_id 
FOREIGN KEY (desired_repo_version_id) REFERENCES repo_version (repo_version_id)
03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
FK_scds_desired_stack_id
03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
java.sql.SQLException: Cannot drop index 
'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
constraint
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 5a24bbb22b 


Diff: https://reviews.apache.org/r/62931/diff/1/


Testing (updated)
---

mvn clean test

Also checked Ambari upgrade with this patch and affected DB  from QA cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Jonathan Hurley]

> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 217-222 (patched)
> > 
> >
> > Should these oddly named FKs go in a try/catch since they're not ALWAYS 
> > present?
> 
> Jonathan Hurley wrote:
> I think the dropConstraint queries first before it drops it, so that if 
> it doesn't exist it won't throw an exception.
> 
> Nate Cole wrote:
> They all throw SQLException which implies something can go wrong.

```
String checkedConstraintName = 
getCheckedForeignKey(convertObjectName(tableName), constraintName);
if (checkedConstraintName != null) {
```

It can throw a SQL exception, but it won't throw one if it's missing.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review187784
---


On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62931/
> ---
> 
> (Updated Oct. 12, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22216
> https://issues.apache.org/jira/browse/AMBARI-22216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For now, patch with workaround for issue on QA cluster.
> 
> Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 
> 2430 to 2600)
> ambari-server.log
> {code}
> 03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT 
> NOT NULL DEFAULT 1
> 03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT
> 03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT NOT NULL
> 03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
> DEFAULT 'CURRENT'
> 03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
> 03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
> NULL
> 03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT 
> FK_scds_desired_repo_id FOREIGN KEY (desired_repo_version_id) REFERENCES 
> repo_version (repo_version_id)
> 03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
> FK_scds_desired_stack_id
> 03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> 03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> java.sql.SQLException: Cannot drop index 
> 'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
> constraint
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> 

Re: Review Request 62934: Set current_version for Backward Compatibility

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/#review187796
---


Ship it!




Ship It!

- Dmytro Grinenko


On Oct. 12, 2017, 1:57 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62934/
> ---
> 
> (Updated Oct. 12, 2017, 1:57 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22219
> https://issues.apache.org/jira/browse/AMBARI-22219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, mpacks, and extension services may have been relying on the 
> deprecated and removed {{hostLevelParams/current_version}}. Although this 
> value was removed since there is no longer a single version for the cluster, 
> we can continue to set it using the version of the repository associated with 
> the current command.
> 
> This will allow existing mpacks and services which were relying on this value 
> to continue to using it until they can switch over to 
> {{componentVersionMapping}} structure.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  f37bdd5e6f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  6ffc9c11b3 
> 
> 
> Diff: https://reviews.apache.org/r/62934/diff/1/
> 
> 
> Testing
> ---
> 
> Audit done.
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:43 min
> [INFO] Finished at: 2017-10-12T10:38:56-04:00
> [INFO] Final Memory: 71M/881M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

[Piyush Chavhan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62930/
---

Review request for Ambari.


Bugs: AMBARI-22187
https://issues.apache.org/jira/browse/AMBARI-22187


Repository: ambari


Description
---

If ambari-server and ambari-agents running using non-root user and tried to 
upgrade from BigInsights stack 4.1 to 4.2.5. Perform Backups fails due to "get 
safemode state" fails for NameNode


Diffs
-

  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HDFS/package/scripts/namenode_upgrade.py
 5969fcf 


Diff: https://reviews.apache.org/r/62930/diff/1/


Testing
---

Tested this change on the running cluster by performing express upgrade from 
BigInsights 4.1 stack to 4.2.5 with HDFS and Zookeeper services running on the 
cluster.

UTs are still running for this.


Thanks,

Piyush Chavhan

Re: Review Request 62934: Set current_version for Backward Compatibility

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/#review187795
---


Ship it!




Ship It!

- Nate Cole


On Oct. 12, 2017, 9:57 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62934/
> ---
> 
> (Updated Oct. 12, 2017, 9:57 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22219
> https://issues.apache.org/jira/browse/AMBARI-22219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some stacks, mpacks, and extension services may have been relying on the 
> deprecated and removed {{hostLevelParams/current_version}}. Although this 
> value was removed since there is no longer a single version for the cluster, 
> we can continue to set it using the version of the repository associated with 
> the current command.
> 
> This will allow existing mpacks and services which were relying on this value 
> to continue to using it until they can switch over to 
> {{componentVersionMapping}} structure.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  f37bdd5e6f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  6ffc9c11b3 
> 
> 
> Diff: https://reviews.apache.org/r/62934/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 62934: Set current_version for Backward Compatibility

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62934/
---

Review request for Ambari, Dmytro Grinenko and Nate Cole.


Bugs: AMBARI-22219
https://issues.apache.org/jira/browse/AMBARI-22219


Repository: ambari


Description
---

Some stacks, mpacks, and extension services may have been relying on the 
deprecated and removed {{hostLevelParams/current_version}}. Although this value 
was removed since there is no longer a single version for the cluster, we can 
continue to set it using the version of the repository associated with the 
current command.

This will allow existing mpacks and services which were relying on this value 
to continue to using it until they can switch over to 
{{componentVersionMapping}} structure.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 f37bdd5e6f 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 6ffc9c11b3 


Diff: https://reviews.apache.org/r/62934/diff/1/


Testing
---

Manual.


Thanks,

Jonathan Hurley

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Nate Cole]

> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 217-222 (patched)
> > 
> >
> > Should these oddly named FKs go in a try/catch since they're not ALWAYS 
> > present?
> 
> Jonathan Hurley wrote:
> I think the dropConstraint queries first before it drops it, so that if 
> it doesn't exist it won't throw an exception.

They all throw SQLException which implies something can go wrong.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review187784
---


On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62931/
> ---
> 
> (Updated Oct. 12, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22216
> https://issues.apache.org/jira/browse/AMBARI-22216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For now, patch with workaround for issue on QA cluster.
> 
> Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 
> 2430 to 2600)
> ambari-server.log
> {code}
> 03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT 
> NOT NULL DEFAULT 1
> 03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT
> 03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT NOT NULL
> 03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
> DEFAULT 'CURRENT'
> 03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
> 03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
> NULL
> 03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT 
> FK_scds_desired_repo_id FOREIGN KEY (desired_repo_version_id) REFERENCES 
> repo_version (repo_version_id)
> 03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
> FK_scds_desired_stack_id
> 03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> 03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> java.sql.SQLException: Cannot drop index 
> 'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
> constraint
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> 03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> {code}
> 
> 
> Diffs
> -
> 
>   
> 

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Jonathan Hurley]

> On Oct. 12, 2017, 9:01 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 217-222 (patched)
> > 
> >
> > Should these oddly named FKs go in a try/catch since they're not ALWAYS 
> > present?

I think the dropConstraint queries first before it drops it, so that if it 
doesn't exist it won't throw an exception.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review187784
---


On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62931/
> ---
> 
> (Updated Oct. 12, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22216
> https://issues.apache.org/jira/browse/AMBARI-22216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For now, patch with workaround for issue on QA cluster.
> 
> Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 
> 2430 to 2600)
> ambari-server.log
> {code}
> 03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT 
> NOT NULL DEFAULT 1
> 03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT
> 03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT NOT NULL
> 03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
> DEFAULT 'CURRENT'
> 03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
> 03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
> NULL
> 03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT 
> FK_scds_desired_repo_id FOREIGN KEY (desired_repo_version_id) REFERENCES 
> repo_version (repo_version_id)
> 03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
> FK_scds_desired_stack_id
> 03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> 03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> java.sql.SQLException: Cannot drop index 
> 'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
> constraint
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> 03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  5a24bbb22b 
> 
> 
> Diff: https://reviews.apache.org/r/62931/diff/1/
> 
> 
> Testing
> 

Re: Review Request 62933: Log Search UI generated by maven build uses mock data instead of real API

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62933/#review187785
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Окт. 12, 2017, 1 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62933/
> ---
> 
> (Updated Окт. 12, 2017, 1 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22218
> https://issues.apache.org/jira/browse/AMBARI-22218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```pom.xml``` contains incorrect ```webpack``` task configuration, so that UI 
> is built with mock data usage.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/package.json f8525c4 
>   ambari-logsearch/ambari-logsearch-web/pom.xml a0621d9 
> 
> 
> Diff: https://reviews.apache.org/r/62933/diff/1/
> 
> 
> Testing
> ---
> 
> 1. maven build
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main  SUCCESS [ 28.513 
> s]
> [INFO] Apache Ambari Project POM .. SUCCESS [  0.094 
> s]
> [INFO] ambari-utility . SUCCESS [  7.669 
> s]
> [INFO] ambari-logsearch ... SUCCESS [  1.971 
> s]
> [INFO] Ambari Logsearch Web ... SUCCESS [02:24 
> min]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 2. tested generated files manually
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review187784
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 217-222 (patched)


Should these oddly named FKs go in a try/catch since they're not ALWAYS 
present?


- Nate Cole


On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62931/
> ---
> 
> (Updated Oct. 12, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22216
> https://issues.apache.org/jira/browse/AMBARI-22216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For now, patch with workaround for issue on QA cluster.
> 
> Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 
> 2430 to 2600)
> ambari-server.log
> {code}
> 03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT 
> NOT NULL DEFAULT 1
> 03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT
> 03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT NOT NULL
> 03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
> DEFAULT 'CURRENT'
> 03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
> 03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
> NULL
> 03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT 
> FK_scds_desired_repo_id FOREIGN KEY (desired_repo_version_id) REFERENCES 
> repo_version (repo_version_id)
> 03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
> FK_scds_desired_stack_id
> 03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> 03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> java.sql.SQLException: Cannot drop index 
> 'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
> constraint
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> 03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  5a24bbb22b 
> 
> 
> Diff: https://reviews.apache.org/r/62931/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 62933: Log Search UI generated by maven build uses mock data instead of real API

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62933/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22218
https://issues.apache.org/jira/browse/AMBARI-22218


Repository: ambari


Description
---

```pom.xml``` contains incorrect ```webpack``` task configuration, so that UI 
is built with mock data usage.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/package.json f8525c4 
  ambari-logsearch/ambari-logsearch-web/pom.xml a0621d9 


Diff: https://reviews.apache.org/r/62933/diff/1/


Testing
---

1. maven build
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main  SUCCESS [ 28.513 s]
[INFO] Apache Ambari Project POM .. SUCCESS [  0.094 s]
[INFO] ambari-utility . SUCCESS [  7.669 s]
[INFO] ambari-logsearch ... SUCCESS [  1.971 s]
[INFO] Ambari Logsearch Web ... SUCCESS [02:24 min]
[INFO] 
[INFO] BUILD SUCCESS

2. tested generated files manually


Thanks,

Andrii Babiichuk

Re: Review Request 62744: Alerts for OneFS mpack

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review187778
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 12, 2017, 7:39 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 12, 2017, 7:39 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 9dbe9c4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  1b4d741 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  968e9b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java
>  d3237a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/5/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   "java.lang:type=OperatingSystem/AvailableProcessors"
>  ]
>}
>   }
>   }
> ]
>   }
> }
> 1,1   Top
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22216
https://issues.apache.org/jira/browse/AMBARI-22216


Repository: ambari


Description
---

For now, patch with workaround for issue on QA cluster.

Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 2430 
to 2600)
ambari-server.log
{code}
03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT NOT 
NULL DEFAULT 1
03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id BIGINT
03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id BIGINT 
NOT NULL
03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
DEFAULT 'CURRENT'
03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
NULL
03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT FK_scds_desired_repo_id 
FOREIGN KEY (desired_repo_version_id) REFERENCES repo_version (repo_version_id)
03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
FK_scds_desired_stack_id
03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
java.sql.SQLException: Cannot drop index 
'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
constraint
at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
at 
org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
at 
org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
at 
org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
at 
org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
at 
org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade failed.
{code}


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 5a24bbb22b 


Diff: https://reviews.apache.org/r/62931/diff/1/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62931/#review187779
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 12, 2017, 8:29 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62931/
> ---
> 
> (Updated Oct. 12, 2017, 8:29 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22216
> https://issues.apache.org/jira/browse/AMBARI-22216
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For now, patch with workaround for issue on QA cluster.
> 
> Ambari Schema Upgrade Failed, Upgrade from : 2510 to 2600 (Also seen from 
> 2430 to 2600)
> ambari-server.log
> {code}
> 03 Oct 2017 06:30:26,349  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD desired_repo_version_id BIGINT 
> NOT NULL DEFAULT 1
> 03 Oct 2017 06:30:26,389  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT
> 03 Oct 2017 06:30:26,435  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY desired_repo_version_id 
> BIGINT NOT NULL
> 03 Oct 2017 06:30:26,490  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD repo_state VARCHAR(255) NOT NULL 
> DEFAULT 'CURRENT'
> 03 Oct 2017 06:30:26,549  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255)
> 03 Oct 2017 06:30:26,598  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate  MODIFY repo_state VARCHAR(255) NOT 
> NULL
> 03 Oct 2017 06:30:26,742  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate ADD CONSTRAINT 
> FK_scds_desired_repo_id FOREIGN KEY (desired_repo_version_id) REFERENCES 
> repo_version (repo_version_id)
> 03 Oct 2017 06:30:26,782  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP FOREIGN KEY 
> FK_scds_desired_stack_id
> 03 Oct 2017 06:30:26,802  INFO [main] DBAccessorImpl:874 - Executing query: 
> ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> 03 Oct 2017 06:30:26,817 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: ALTER TABLE servicecomponentdesiredstate DROP COLUMN desired_stack_id
> java.sql.SQLException: Cannot drop index 
> 'FK_servicecomponentdesiredstate_desired_stack_id': needed in a foreign key 
> constraint
> at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:996)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3887)
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3823)
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2435)
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2582)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2526)
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2484)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:848)
> at com.mysql.jdbc.StatementImpl.execute(StatementImpl.java:742)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.dropColumn(DBAccessorImpl.java:974)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.updateServiceComponentDesiredStateTable(UpgradeCatalog260.java:386)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog260.executeDDLUpdates(UpgradeCatalog260.java:185)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> 03 Oct 2017 06:30:26,822 ERROR [main] SchemaUpgradeHelper:202 - Upgrade 
> failed.
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  5a24bbb22b 
> 
> 
> Diff: https://reviews.apache.org/r/62931/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 62932: Deploy fails due to PU code related issues (post-merge)

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62932/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22217
https://issues.apache.org/jira/browse/AMBARI-22217


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
2270dcef32 
  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 a6a05bf39b 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 26b0af0a99 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py
 a76a6e327a 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 d9233a3151 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
9a046b9404 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/package/scripts/status_params.py
 852a9cb664 
  
ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/package/scripts/params.py
 869c329a5e 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.3.0/package/scripts/status_params.py
 3cbd920b23 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/status_params.py
 ce990cf8fa 
  
ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/params.py
 b88f1a4d96 
  
ambari-server/src/main/resources/common-services/RANGER/1.0.0.3.0/package/scripts/status_params.py
 842430ba46 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/params.py
 da8eb8ca40 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/1.0.0.3.0/package/scripts/status_params.py
 34d008208b 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.3.0/package/scripts/params_linux.py
 400c87c828 
  
ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/status_params.py
 d84b0950a9 
  
ambari-server/src/main/resources/common-services/SUPERSET/0.15.0/package/scripts/params.py
 b38d6438aa 
  ambari-server/src/test/python/custom_actions/test_ru_execute_tasks.py 
0d12a91276 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py de83f7e07b 


Diff: https://reviews.apache.org/r/62932/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62744: Alerts for OneFS mpack

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/#review187773
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 12, 2017, 1:39 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62744/
> ---
> 
> (Updated Oct. 12, 2017, 1:39 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22115
> https://issues.apache.org/jira/browse/AMBARI-22115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is part of AMBARI-22115. We need to define alerts on JMX metrics which 
> are pulled from a cluster that is not necessarily managed by Ambari. 
> Therefore alerts can't run on ambari-agent host. I introduced a new SERVER 
> type alert called JmxServerSideAlert that can pull the jmx metrics from a 
> arbitrary url. The url comes from the alerts.json and it may contain 
> placeholders like ${hdfs-site/dfs.namenode.http-address}. This works 
> similarly than the Python class MetricAlert.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 9dbe9c4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  1b4d741 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  968e9b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
>  81d72fb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 
> 5d2ecc6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java
>  93801d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
>  11eee05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java
>  4aeba45 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
>  c58867a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java
>  d3237a9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62744/diff/5/
> 
> 
> Testing
> ---
> 
> Used the following alerts.json to test it
> 
> {   
>   "ONEFS":{
> "service": [
>   { 
> "name": "onefs_namenode_cpu",
> "label": "OneFS NameNode Host CPU Utilization",
> "description": "This host-level alert is triggered if CPU utilization 
> of the NameNode exceeds certain warning and critical thresholds. It checks 
> the NameNode JMX Servlet for the SystemCPULoad property. The threshold values 
> are in percent.",
> "interval": 1,
> "help_url": 
> "https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
> "scope": "HOST",
> "enabled": true,
> "source": {
>   "type": "SERVER",
>   "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
>   "uri": {
> "http": "${hdfs-site/dfs.namenode.http-address}",
> "https": "${hdfs-site/dfs.namenode.https-address}",
> "https_property": "${hdfs-site/dfs.http.policy}",
> "https_property_value": "HTTPS_ONLY",
> "connection_timeout": 5.0
>   },
>   "reporting": {
> "ok": {
>   "text": "{1} CPU, load {0,number,percent}"
> },
> "warning": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 5
> },
> "critical": {
>   "text": "{1} CPU, load {0,number,percent}",
>   "value": 20
> },
> "units" : "%",
> "type": "PERCENT"
>},
>"jmx": {
>  "property_list": [
>   "java.lang:type=OperatingSystem/SystemCpuLoad",
>   "java.lang:type=OperatingSystem/AvailableProcessors"
>  ]
>}
>   }
>   }
> ]
>   }
> }
> 1,1   Top
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 62744: Alerts for OneFS mpack

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62744/
---

(Updated Oct. 12, 2017, 11:39 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.


Changes
---

configurable thread pool size


Bugs: AMBARI-22115
https://issues.apache.org/jira/browse/AMBARI-22115


Repository: ambari


Description
---

This is part of AMBARI-22115. We need to define alerts on JMX metrics which are 
pulled from a cluster that is not necessarily managed by Ambari. Therefore 
alerts can't run on ambari-agent host. I introduced a new SERVER type alert 
called JmxServerSideAlert that can pull the jmx metrics from a arbitrary url. 
The url comes from the alerts.json and it may contain placeholders like 
${hdfs-site/dfs.namenode.http-address}. This works similarly than the Python 
class MetricAlert.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 9dbe9c4 
  
ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/alerts/Threshold.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 1b4d741 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 968e9b6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java
 81d72fb 
  ambari-server/src/main/java/org/apache/ambari/server/state/Alert.java 5d2ecc6 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java 
93801d5 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/MetricSource.java
 11eee05 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/Reporting.java 
4aeba45 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/ServerSource.java
 c58867a 
  
ambari-server/src/main/java/org/apache/ambari/server/state/services/AmbariServerAlertService.java
 d3237a9 
  
ambari-server/src/test/java/org/apache/ambari/server/alerts/ThresholdTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/jmx/JMXMetricHolderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alert/AlertUriTest.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62744/diff/5/

Changes: https://reviews.apache.org/r/62744/diff/4-5/


Testing
---

Used the following alerts.json to test it

{   
  "ONEFS":{
"service": [
  { 
"name": "onefs_namenode_cpu",
"label": "OneFS NameNode Host CPU Utilization",
"description": "This host-level alert is triggered if CPU utilization 
of the NameNode exceeds certain warning and critical thresholds. It checks the 
NameNode JMX Servlet for the SystemCPULoad property. The threshold values are 
in percent.",
"interval": 1,
"help_url": 
"https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Alerts#AmbariAlerts-ambari_agent_heartbeat;,
"scope": "HOST",
"enabled": true,
"source": {
  "type": "SERVER",
  "class": "org.apache.ambari.server.alerts.JmxServerSideAlert",
  "uri": {
"http": "${hdfs-site/dfs.namenode.http-address}",
"https": "${hdfs-site/dfs.namenode.https-address}",
"https_property": "${hdfs-site/dfs.http.policy}",
"https_property_value": "HTTPS_ONLY",
"connection_timeout": 5.0
  },
  "reporting": {
"ok": {
  "text": "{1} CPU, load {0,number,percent}"
},
"warning": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 5
},
"critical": {
  "text": "{1} CPU, load {0,number,percent}",
  "value": 20
},
"units" : "%",
"type": "PERCENT"
   },
   "jmx": {
 "property_list": [
  "java.lang:type=OperatingSystem/SystemCpuLoad",
  "java.lang:type=OperatingSystem/AvailableProcessors"
 ]
   }
  }
  }
]
  }
}
1,1   Top


Thanks,

Attila Magyar

Re: Review Request 62924: Alter logic for storing interpreter.json

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/
---

(Updated Oct. 12, 2017, 4:56 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22212
https://issues.apache.org/jira/browse/AMBARI-22212


Repository: ambari


Description
---

Right now Ambari assumes if "FileSystemNotebookRepo" is set for 
"zeppelin.notebook.storage" then both notebook and conf are in HDFS.

But the right logic will be if ("zeppelin.config.fs.dir" is empty or 
"zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS and 
also check for "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if 
exists.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 09944bd277 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
 3242f2621a 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
3adb94ce1a 


Diff: https://reviews.apache.org/r/62924/diff/1/


Testing
---

Manually


File Attachments (updated)


AMBARI-22212_branch-2.6_v1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/10/12/ba6ec3df-596e-4e8c-9697-fdbcd42a492d__AMBARI-22212_branch-2.6_v1.patch


Thanks,

Prabhjyot Singh

Re: Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62922/#review187768
---


Ship it!




Ship It!

- Dmytro Grinenko


On Oct. 12, 2017, 5:30 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62922/
> ---
> 
> (Updated Oct. 12, 2017, 5:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22213
> https://issues.apache.org/jira/browse/AMBARI-22213
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Manual check:
> {code}
> tr-e134-1499953498516-213280-01-12:~ # ambari-server upgrade
> Using python  /usr/bin/python
> Upgrading ambari-server
> INFO: Upgrade Ambari Server
> INFO: Updating Ambari Server properties in ambari.properties ...
> WARNING: Can not find ambari.properties.rpmsave file from previous version, 
> skipping import of settings
> INFO: Updating Ambari Server properties in ambari-env.sh ...
> INFO: Can not find ambari-env.sh.rpmsave file from previous version, skipping 
> restore of environment settings. ambari-env.sh may not include any user 
> customization.
> INFO: Fixing database objects owner
> Ambari Server configured for Postgres. Confirm you have made a backup of the 
> Ambari Server database [y/n] (y)?
> INFO: Upgrading database schema
> INFO: Return code from schema upgrade command, retcode = 1
> ERROR: Error executing schema upgrade, please check the server logs.
> ERROR: Error output from schema upgrade command:
> ERROR: Exception in thread "main" org.apache.ambari.server.AmbariException: 
> ERROR: relation "servicecomponent_history" does not exist
> Position: 13
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:203)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.main(SchemaUpgradeHelper.java:418)
> Caused by: org.postgresql.util.PSQLException: ERROR: relation 
> "servicecomponent_history" does not exist
> Position: 13
> at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.clearTable(DBAccessorImpl.java:1500)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog252.addRepositoryColumnsToUpgradeTable(UpgradeCatalog252.java:169)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog252.executeDDLUpdates(UpgradeCatalog252.java:122)
> at 
> org.apache.ambari.server.upgrade.AbstractUpgradeCatalog.upgradeSchema(AbstractUpgradeCatalog.java:923)
> at 
> org.apache.ambari.server.upgrade.SchemaUpgradeHelper.executeUpgrade(SchemaUpgradeHelper.java:200)
> ... 1 more
> 
> 
> ERROR: Ambari server upgrade failed. Please look at 
> /var/log/ambari-server/ambari-server.log, for more details.
> ERROR: Exiting with exit code 11.
> REASON: Schema upgrade failed.
> {code}
> {code}
> 11 Oct 2017 13:49:16,918 ERROR [main] DBAccessorImpl:880 - Error executing 
> query: DELETE FROM servicecomponent_history
> org.postgresql.util.PSQLException: ERROR: relation "servicecomponent_history" 
> does not exist
> Position: 13
> at 
> org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2161)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1890)
> at 
> org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:559)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
> at 
> org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:877)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.executeQuery(DBAccessorImpl.java:869)
> at 
> org.apache.ambari.server.orm.DBAccessorImpl.clearTable(DBAccessorImpl.java:1500)
> at 
> org.apache.ambari.server.upgrade.UpgradeCatalog252.addRepositoryColumnsToUpgradeTable(UpgradeCatalog252.java:169)
> at 
> 

Re: Review Request 62924: Alter logic for storing interpreter.json

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/#review187764
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 12, 2017, 6:37 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62924/
> ---
> 
> (Updated Oct. 12, 2017, 6:37 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22212
> https://issues.apache.org/jira/browse/AMBARI-22212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now Ambari assumes if "FileSystemNotebookRepo" is set for 
> "zeppelin.notebook.storage" then both notebook and conf are in HDFS.
> 
> But the right logic will be if ("zeppelin.config.fs.dir" is empty or 
> "zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS 
> and also check for 
> "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 3adb94ce1a 
> 
> 
> Diff: https://reviews.apache.org/r/62924/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/#review187765
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Oct. 12, 2017, 9:03 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62925/
> ---
> 
> (Updated Oct. 12, 2017, 9:03 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22214
> https://issues.apache.org/jira/browse/AMBARI-22214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Livy is running on https mode then Livy protocol to be set to https in 
> Zeppelin's interpreter setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
> 
> 
> Diff: https://reviews.apache.org/r/62925/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[Prabhjyot Singh]

> On Oct. 12, 2017, 2:29 p.m., Jeff Zhang wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
> > Lines 230 (patched)
> > 
> >
> > livy.key-password is optional, it is better to check livy.keystore

Thanks for the review have fixed it.


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/#review187756
---


On Oct. 12, 2017, 2:33 p.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62925/
> ---
> 
> (Updated Oct. 12, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22214
> https://issues.apache.org/jira/browse/AMBARI-22214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Livy is running on https mode then Livy protocol to be set to https in 
> Zeppelin's interpreter setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
> 
> 
> Diff: https://reviews.apache.org/r/62925/diff/2/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/
---

(Updated Oct. 12, 2017, 2:33 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22214
https://issues.apache.org/jira/browse/AMBARI-22214


Repository: ambari


Description
---

If Livy is running on https mode then Livy protocol to be set to https in 
Zeppelin's interpreter setting.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 09944bd277 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
 3242f2621a 


Diff: https://reviews.apache.org/r/62925/diff/2/

Changes: https://reviews.apache.org/r/62925/diff/1-2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62890: AMBARI-22204 Updating Ranger Admin pre-upgrade task

[Mugdha Varadkar]

> On Oct. 11, 2017, 2:08 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
> > Lines 201-205 (original), 201-207 (patched)
> > 
> >
> > Why not just use the upgrade_summary module for all of this - would 
> > protect you against changes in the future.

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62890/#review187657
---


On Oct. 12, 2017, 9 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62890/
> ---
> 
> (Updated Oct. 12, 2017, 9 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Nate Cole, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-22204
> https://issues.apache.org/jira/browse/AMBARI-22204
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After AMBARI-21581 changes, need to update Ranger Admin pre-upgrade task.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  f779c18 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  74439bf 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/RANGER/package/scripts/ranger_admin.py
>  37555cc 
> 
> 
> Diff: https://reviews.apache.org/r/62890/diff/2/
> 
> 
> Testing
> ---
> 
> Tested EU & RU for Ranger Admin.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 62890: AMBARI-22204 Updating Ranger Admin pre-upgrade task

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62890/
---

(Updated Oct. 12, 2017, 9 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Nate Cole, and Velmurugan Periasamy.


Changes
---

Handle Jonathan Hurley changes


Bugs: AMBARI-22204
https://issues.apache.org/jira/browse/AMBARI-22204


Repository: ambari


Description
---

After AMBARI-21581 changes, need to update Ranger Admin pre-upgrade task.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 f779c18 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
 74439bf 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/RANGER/package/scripts/ranger_admin.py
 37555cc 


Diff: https://reviews.apache.org/r/62890/diff/2/

Changes: https://reviews.apache.org/r/62890/diff/1-2/


Testing
---

Tested EU & RU for Ranger Admin.


Thanks,

Mugdha Varadkar

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/#review187756
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
Lines 230 (patched)


livy.key-password is optional, it is better to check livy.keystore


- Jeff Zhang


On Oct. 12, 2017, 7:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62925/
> ---
> 
> (Updated Oct. 12, 2017, 7:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22214
> https://issues.apache.org/jira/browse/AMBARI-22214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Livy is running on https mode then Livy protocol to be set to https in 
> Zeppelin's interpreter setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
> 
> 
> Diff: https://reviews.apache.org/r/62925/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62895/#review187753
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 11, 2017, 7:17 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62895/
> ---
> 
> (Updated Oct. 11, 2017, 7:17 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi 
> Radhakrishnan.
> 
> 
> Bugs: AMBARI-22209
> https://issues.apache.org/jira/browse/AMBARI-22209
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix quick links in mpacks.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 1cad4df 
> 
> 
> Diff: https://reviews.apache.org/r/62895/diff/1/
> 
> 
> Testing
> ---
> 
> will check tests after approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/#review187748
---


Ship it!




Ship It!

- venkat sairam


On Oct. 12, 2017, 7:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62925/
> ---
> 
> (Updated Oct. 12, 2017, 7:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22214
> https://issues.apache.org/jira/browse/AMBARI-22214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If Livy is running on https mode then Livy protocol to be set to https in 
> Zeppelin's interpreter setting.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
> 
> 
> Diff: https://reviews.apache.org/r/62925/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62924: Alter logic for storing interpreter.json

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/#review187747
---


Ship it!




Ship It!

- venkat sairam


On Oct. 12, 2017, 6:37 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62924/
> ---
> 
> (Updated Oct. 12, 2017, 6:37 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, 
> Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-22212
> https://issues.apache.org/jira/browse/AMBARI-22212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now Ambari assumes if "FileSystemNotebookRepo" is set for 
> "zeppelin.notebook.storage" then both notebook and conf are in HDFS.
> 
> But the right logic will be if ("zeppelin.config.fs.dir" is empty or 
> "zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS 
> and also check for 
> "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if exists.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  09944bd277 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
>  3242f2621a 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> 3adb94ce1a 
> 
> 
> Diff: https://reviews.apache.org/r/62924/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 62925: Livy protocol to be set to https in Zeppelin's interpreter setting

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62925/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22214
https://issues.apache.org/jira/browse/AMBARI-22214


Repository: ambari


Description
---

If Livy is running on https mode then Livy protocol to be set to https in 
Zeppelin's interpreter setting.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 09944bd277 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
 3242f2621a 


Diff: https://reviews.apache.org/r/62925/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Review Request 62924: Alter logic for storing interpreter.json

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62924/
---

Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit 
Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-22212
https://issues.apache.org/jira/browse/AMBARI-22212


Repository: ambari


Description
---

Right now Ambari assumes if "FileSystemNotebookRepo" is set for 
"zeppelin.notebook.storage" then both notebook and conf are in HDFS.

But the right logic will be if ("zeppelin.config.fs.dir" is empty or 
"zeppelin.config.fs.dir" start with "file://") it is stored in FS else HDFS and 
also check for "/etc/zeppelin/conf/external-dependency-conf/hdfs-site.xml" if 
exists.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 09944bd277 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/params.py
 3242f2621a 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
3adb94ce1a 


Diff: https://reviews.apache.org/r/62924/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

[Yussuf Shaikh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62923/
---

(Updated Oct. 12, 2017, 6:20 a.m.)


Review request for Ambari and Nate Cole.


Bugs: AMBARI-22200
https://issues.apache.org/jira/browse/AMBARI-22200


Repository: ambari


Description
---

We need to add a new function in ambari-server Configuration class to read a 
property from file read.
This is required for reading custom properties added to the ambari.properties 
file from backend (eg:python script) without restarting the server.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 1b4d741 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 1b8de79 


Diff: https://reviews.apache.org/r/62923/diff/1/


Testing
---

all tests pass on ambari-server


Thanks,

Yussuf Shaikh

Review Request 62923: Provide a function in Configuration class to reload the properties file for new custom properties

[Yussuf Shaikh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62923/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-22200
https://issues.apache.org/jira/browse/AMBARI-22200


Repository: ambari


Description
---

We need to add a new function in ambari-server Configuration class to read a 
property from file read.
This is required for reading custom properties added to the ambari.properties 
file from backend (eg:python script) without restarting the server.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 1b4d741 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 1b8de79 


Diff: https://reviews.apache.org/r/62923/diff/1/


Testing
---

all tests pass on ambari-server


Thanks,

Yussuf Shaikh