date:20141023

Re: Review Request 27129: Upgrade psutil to 2.1.3

2014-10-23 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/#review58247
---

Ship it!


Ship It!

- Brian Wickman


On Oct. 24, 2014, 2:13 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27129/
> ---
> 
> (Updated Oct. 24, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-627
> https://issues.apache.org/jira/browse/AURORA-627
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade psutil to 2.1.3
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 4493bf1ec763f367d1549f84e9a627a35254bcc5 
> 
> Diff: https://reviews.apache.org/r/27129/diff/
> 
> 
> Testing
> ---
> 
> e2e tests and on OS X 10.10 and from within the vagrant image:
> 
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.cron 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.help 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.inspect  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.logging  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.quota
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.supdate  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.update   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> src.test.python.apache.aurora.client.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key  
>   .   SUCCESS
>

Re: Review Request 27129: Upgrade psutil to 2.1.3

2014-10-23 Thread Joshua Cohen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/#review58237
---

Ship it!


Ship It!

- Joshua Cohen


On Oct. 24, 2014, 2:13 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27129/
> ---
> 
> (Updated Oct. 24, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-627
> https://issues.apache.org/jira/browse/AURORA-627
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade psutil to 2.1.3
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 4493bf1ec763f367d1549f84e9a627a35254bcc5 
> 
> Diff: https://reviews.apache.org/r/27129/diff/
> 
> 
> Testing
> ---
> 
> e2e tests and on OS X 10.10 and from within the vagrant image:
> 
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.cron 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.help 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.inspect  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.logging  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.quota
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.supdate  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.update   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> src.test.python.apache.aurora.client.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key  
>   .   SUCCESS
> s

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread John Sirois


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/#review58231
---

Ship it!


Ship It!

- John Sirois


On Oct. 23, 2014, 4:19 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27114/
> ---
> 
> (Updated Oct. 23, 2014, 4:19 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move from github to bintray for pants support binaries.
> 
> This is from advice from jsirois on 
> https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J
> 
> 
> Diffs
> -
> 
>   pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 
> 
> Diff: https://reviews.apache.org/r/27114/diff/
> 
> 
> Testing
> ---
> 
> [tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
> ./src/test/python/apache/aurora/admin:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
>  all)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 11 items 
> 
> src/test/python/apache/aurora/admin/test_host_maintenance.py ...
> 
> =
>  11 passed in 0.62 seconds 
> ==
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 2 items 
> 
> src/test/python/apache/aurora/admin/test_admin_util.py ..
> 
> ==
>  2 passed in 0.19 seconds 
> ==
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 27129: Upgrade psutil to 2.1.3

2014-10-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/#review58230
---

Ship it!


Ship It!

- Bill Farner


On Oct. 24, 2014, 2:13 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27129/
> ---
> 
> (Updated Oct. 24, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: AURORA-627
> https://issues.apache.org/jira/browse/AURORA-627
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade psutil to 2.1.3
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 4493bf1ec763f367d1549f84e9a627a35254bcc5 
> 
> Diff: https://reviews.apache.org/r/27129/diff/
> 
> 
> Testing
> ---
> 
> e2e tests and on OS X 10.10 and from within the vagrant image:
> 
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.disambiguator
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.instance_watcher 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.job_monitor  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.mux  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.quota_check  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.restarter
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.scheduler_client 
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater  
>   .   SUCCESS
> src.test.python.apache.aurora.client.api.updater_util 
>   .   SUCCESS
> src.test.python.apache.aurora.client.binding_helper   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.api  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.bridge   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.cron 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.help 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.inspect  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.job  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.logging  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.quota
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.sla  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.supdate  
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.task 
>   .   SUCCESS
> src.test.python.apache.aurora.client.cli.update   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.admin   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.core
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.hooks   
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.maintenance 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.run 
>   .   SUCCESS
> src.test.python.apache.aurora.client.commands.ssh 
>   .   SUCCESS
> src.test.python.apache.aurora.client.config   
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.client.hooks.non_hooked_api 
>   .   SUCCESS
> src.test.python.apache.aurora.common.test_aurora_job_key  
>   .   SUCCESS
> sr

Review Request 27129: Upgrade psutil to 2.1.3

2014-10-23 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27129/
---

Review request for Aurora, Kevin Sweeney and Brian Wickman.


Bugs: AURORA-627
https://issues.apache.org/jira/browse/AURORA-627


Repository: aurora


Description
---

Upgrade psutil to 2.1.3


Diffs
-

  3rdparty/python/BUILD 4493bf1ec763f367d1549f84e9a627a35254bcc5 

Diff: https://reviews.apache.org/r/27129/diff/


Testing
---

e2e tests and on OS X 10.10 and from within the vagrant image:

src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS
src.test.python.apache.aurora.client.api.api
.   SUCCESS
src.test.python.apache.aurora.client.api.disambiguator  
.   SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher   
.   SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
.   SUCCESS
src.test.python.apache.aurora.client.api.mux
.   SUCCESS
src.test.python.apache.aurora.client.api.quota_check
.   SUCCESS
src.test.python.apache.aurora.client.api.restarter  
.   SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client   
.   SUCCESS
src.test.python.apache.aurora.client.api.sla
.   SUCCESS
src.test.python.apache.aurora.client.api.updater
.   SUCCESS
src.test.python.apache.aurora.client.api.updater_util   
.   SUCCESS
src.test.python.apache.aurora.client.binding_helper 
.   SUCCESS
src.test.python.apache.aurora.client.cli.api
.   SUCCESS
src.test.python.apache.aurora.client.cli.bridge 
.   SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks  
.   SUCCESS
src.test.python.apache.aurora.client.cli.config 
.   SUCCESS
src.test.python.apache.aurora.client.cli.cron   
.   SUCCESS
src.test.python.apache.aurora.client.cli.help   
.   SUCCESS
src.test.python.apache.aurora.client.cli.inspect
.   SUCCESS
src.test.python.apache.aurora.client.cli.job
.   SUCCESS
src.test.python.apache.aurora.client.cli.logging
.   SUCCESS
src.test.python.apache.aurora.client.cli.plugins
.   SUCCESS
src.test.python.apache.aurora.client.cli.quota  
.   SUCCESS
src.test.python.apache.aurora.client.cli.sla
.   SUCCESS
src.test.python.apache.aurora.client.cli.supdate
.   SUCCESS
src.test.python.apache.aurora.client.cli.task   
.   SUCCESS
src.test.python.apache.aurora.client.cli.update 
.   SUCCESS
src.test.python.apache.aurora.client.commands.admin 
.   SUCCESS
src.test.python.apache.aurora.client.commands.core  
.   SUCCESS
src.test.python.apache.aurora.client.commands.hooks 
.   SUCCESS
src.test.python.apache.aurora.client.commands.maintenance   
.   SUCCESS
src.test.python.apache.aurora.client.commands.run   
.   SUCCESS
src.test.python.apache.aurora.client.commands.ssh   
.   SUCCESS
src.test.python.apache.aurora.client.config 
.   SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api   
.   SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api   
.   SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key
.   SUCCESS
src.test.python.apache.aurora.common.test_cluster   
.   SUCCESS
src.test.python.apache.aurora.common.test_cluster_option
.   SUCCESS
src.test.python.apache.aurora.common.test_clusters  
.   SUCCESS
src.test.python.apache.aurora.common.test_http_signaler 
.   SUCCESS
src.test.python.apache.aurora.common.test_shellify  
.   SUCCESS
src.test.python.apache.aurora.common.test_transport 
.   SUCCESS
src.

Re: Review Request 26802: Set a default for the error log dir

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/#review58217
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 16, 2014, 8:22 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26802/
> ---
> 
> (Updated Oct. 16, 2014, 8:22 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-827
> https://issues.apache.org/jira/browse/AURORA-827
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set a default for the error log dir
> 
> This has been a weird  issue to wrap my head around, it's really using lots 
> of low-level systems (writing tracebacks to files) so I feel like I've done 
> some weird things in the tests. Feedback and critque welcome + appreciated.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 
>   src/test/python/apache/aurora/client/cli/BUILD 
> d33e86643a59879c115876c98bd1dc19aa7ae61c 
>   src/test/python/apache/aurora/client/cli/test_aurora_command_line.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26802/diff/
> 
> 
> Testing
> ---
> 
> [tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants 
> src/test/python/apache/aurora/client/cli:aurora_command_line
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
>  aurora_command_line)])
>  test 
> session starts 
> =
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 1 items 
> 
> src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .
> 
> == 1 passed 
> in 0.63 seconds 
> ==
> src.test.python.apache.aurora.client.cli.aurora_command_line  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 26753: Start removing clientv1.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/#review58215
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 21, 2014, 6:34 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26753/
> ---
> 
> (Updated Oct. 21, 2014, 6:34 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: aurora-131
> https://issues.apache.org/jira/browse/aurora-131
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Make the "aurora2" main target be the standalone clientv2;
> - Don't build the bridged client by default; but allow forced build using 
> "aurora2_bridge".
> - Modify cli tests so that they only depend on the standalone clientv2.
> - Modify vagrant config to make clientv2 the primary client.
> - Modify end-to-end tests to match the vagrant changes.
> 
> (Note: end-to-end tests are failing, but in the same way as they fail without 
> this change. I'm working on debugging that, but it should be its own 
> change/review, and I don't want to delay reviewing this.)
> 
> 
> Diffs
> -
> 
>   docs/developing-aurora-client.md b9912bce44d65ddd7f1e35f0ea9356a89d5fe767 
>   examples/vagrant/aurorabuild.sh 8659bffb8fb6170c02aef0edce92349540d4366a 
>   examples/vagrant/provision-dev-cluster.sh 
> 1d4fd77a83dbfc6724a3a3b5f44301dc54b3085c 
>   examples/vagrant/test_tutorial.sh a5557cb57010cd541cc753e8c74c7a3a99425477 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 995570325bbb09ecbcc2ace5d223760c5d49367f 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_cancel_update.py 
> e7052465411165acb3d5145664f2f166ac052500 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 9fc6fe2c2063cda494437d83044557b345acacea 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> dfcbd7217b1d51609fa01c4d9cefed5471c91718 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 328297ab1d29efb0adce8f4931a13929a04dcd9c 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> c7b71c29d44150162fec8066947623fa91815424 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_help.py 
> 551c9f949cda3971a370cb696216ec9584584336 
>   src/test/python/apache/aurora/client/cli/test_inspect.py 
> e997b9743b63d71f8624ecf5ca1dcae0227be70d 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> f7601d82dbb45900bec2939dca2b921bf147961d 
>   src/test/python/apache/aurora/client/cli/test_logging.py 
> 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e 
>   src/test/python/apache/aurora/client/cli/test_open.py 
> c20649f5cada241d0f6e9ae5f88d300eac073517 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> dc5edd4f03cee062673231a04908193480c8071c 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> 88fb9aec4d1eae6ad05da01752a670f902bafb1b 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a753ab4aead7e2560cae77c441562811924f8f1b 
>   src/test/python/apache/aurora/client/cli/test_sla.py 
> a1a3d8161ba747aa23a5e614e9ae31473d2058c1 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> f3fa6cf6e9e080689593c40e787018eff46f8ede 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> cff1b6578aec6f5bcc1e610e58b47af233f32b41 
>   src/test/sh/org/apache/aurora/e2e/test_common.sh 
> 43d2516133c6d6cdb4236358f942396f057f739c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 324aa4dbeff00e673fe73b87e3a0766856cd213c 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> bbbf90b95e91bcdf8aaf8b2a7b577dee70a7c8a7 
> 
> Diff: https://reviews.apache.org/r/26753/diff/
> 
> 
> Testing
> ---
> 
> - Ran all unit tests, confirmed they continue to pass.
> - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and 
> verified that they fail in exactly the same way as before this change.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 26899: Require StateManager callers to open their own transactions.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26899/#review58216
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 21, 2014, 1:09 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26899/
> ---
> 
> (Updated Oct. 21, 2014, 1:09 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Apologies for the large diff - `StateManager` has a large fan-out.  This is a 
> pure functional no-op - just moving the call to `storage.write` up in the 
> stack.
> 
> This change is to prepare for AURORA-871 [1], as well as generally make use 
> of `StateManager` safer.  With the API prior to this diff, it would be easy 
> to unintentionally attempt a fateful read->write lock upgrade.  This firms up 
> the API by requiring the caller to bring their own transaction, removing the 
> implementation detail that a write transaction is opened behind the scenes.
> 
> [1] https://issues.apache.org/jira/browse/AURORA-871
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
> 250c2df8113adfd62b3a7e124f7994156c82b5f7 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 345cd8959045302fe3711e22396f5f7244a88c44 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 1189ed0318ae0cf9663f0fa41775c4dd625bb397 
>   src/main/java/org/apache/aurora/scheduler/async/TaskThrottler.java 
> ca6129c7e0225530336c88f91a1451892f2ce234 
>   src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java 
> 89140223f4f3acd02ade6fb95734744ef19d89bc 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 9388657ccb904364e460ec612c3da562b8952d7e 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> 21cfebdf11e0652e192cf08e35c8581b1246f7b5 
>   src/main/java/org/apache/aurora/scheduler/state/StateManager.java 
> 3a2fd279c2953d564b7fddabf31afda001bb3dfe 
>   src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
> 58b94c2f2f3bac00f0692579974e8bdf159b6e40 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  e792d23d6bb13b4e61b078beea6d063f72f0d8fc 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java 
> 3774c851b58e747acf25735d24334408b1c5386d 
>   
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
> f4363aa8ce9ef9f583b52251f351c8c971ef8119 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  6ec130f4a9a5075b34452efb27c8fd0f08f93a63 
>   src/test/java/org/apache/aurora/scheduler/UserTaskLauncherTest.java 
> 083a63543e5f9041f13fc6be66877f7173a5bf32 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 
> b3e4ae39067b1dfb632f5d685d69fcbd7d4705da 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   src/test/java/org/apache/aurora/scheduler/async/TaskThrottlerTest.java 
> a28e512afde584fb94ff7686d7a3e3fbb51f8b7b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskTimeoutTest.java 
> e79327c3b8ead01495e063e5c0e9270568e16f69 
>   
> src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
> b6b1bcbf8080eb7d1e7eca4a486cc063f28db75d 
>   
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
>  4d96761e04a342ad3564bdba4afdc889f27ac123 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
> cf4a015a040338a642fb07eec1fb7b5c11058fe5 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  f36a88fda3539553800bd727c3d2a77a54f1e71c 
>   src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 
> f9ed46f56bb11e9c158268c16f29557f3e99c84e 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> f739e6d1b1af6eea4875e03d32bfe88cef87b3ff 
> 
> Diff: https://reviews.apache.org/r/26899/diff/
>

Re: Review Request 22457: Improve aurora "job diff" command.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22457/#review58220
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Sept. 9, 2014, 2:07 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22457/
> ---
> 
> (Updated Sept. 9, 2014, 2:07 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Brian Wickman.
> 
> 
> Bugs: aurora-520
> https://issues.apache.org/jira/browse/aurora-520
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a new diff method, which uses field-by-field comparison of JSON trees for 
> comparing running job configurations to potentially updated configs.
> 
> - Allow exclusion of semantically irrelevant fields.
> - Provide a clearer list of the differences between configs.
> - Provide a scripting-friendly alternative JSON syntax for diffs.
> 
> The old diff behavior is still available under the "--use-shell-diff" option.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/BUILD 
> ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/main/python/apache/aurora/client/cli/json_tree_diff.py PRE-CREATION 
>   src/test/python/apache/aurora/client/cli/BUILD 
> e1f9ebf96774b8f5c75de8570c6ba87d953ab649 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 38629b63c082cf81cb891dace2a70d9e8f418e18 
>   src/test/python/apache/aurora/client/cli/test_json_diff.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22457/diff/
> 
> 
> Testing
> ---
> 
> New unit tests of the JSON tree diff code, plus a bunch of new "job diff" 
> tests of the new functionality.
> All tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 25794: Add a mock scheduler client to the AuroraClient service

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25794/#review58219
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Sept. 18, 2014, 9:38 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25794/
> ---
> 
> (Updated Sept. 18, 2014, 9:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a mock scheduler client to the AuroraClient service.
> 
> There is probably a more Angular way to get this done which involves creating 
> a mock service, but this seemed like the simplest approach.
> 
> Interested in whether this is the right place to do mocking (or should it 
> come from the server so that we have more coverage of the client code?) or if 
> we should mock at all. 
> 
> Code itself needs cleaned up - I just want to solicit feedback before I go 
> too far down a bad path. 
> 
> 
> Diffs
> -
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 
> 8a719f85b0a095a93b723c04b0a5e8306093c572 
> 
> Diff: https://reviews.apache.org/r/25794/diff/
> 
> 
> Testing
> ---
> 
> In Chrome -> Developer Console:
> 
> window.__mockAPI__ = true;
> 
> Now I have updates in the UI. 
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Re: Review Request 27080: Improve status command output ordering.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27080/#review58214
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 2:50 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27080/
> ---
> 
> (Updated Oct. 23, 2014, 2:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-885
> https://issues.apache.org/jira/browse/aurora-885
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Sort tasks by instance number.
> - Sort events by timestamp.
> 
> Bugs closed: aurora-879
> 
> Reviewed at https://reviews.apache.org/r/27047/
> 
> Improve error messages when commands fail because jobs are locked.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 376106c88abe6d06ef6f3cb7027ab8f66f052686 
>   src/main/python/apache/aurora/client/cli/context.py 
> 0a3c2236916f52919b48e9254929c2fbe9eb5252 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/test/python/apache/aurora/client/cli/test_kill.py 
> f7601d82dbb45900bec2939dca2b921bf147961d 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
> 
> Diff: https://reviews.apache.org/r/27080/diff/
> 
> 
> Testing
> ---
> 
> Added new unit tests; ran all client tests.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 27084: Fix error when "job create" is called with "--open-browser".

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/#review58213
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 4:50 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27084/
> ---
> 
> (Updated Oct. 23, 2014, 4:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-886
> https://issues.apache.org/jira/browse/aurora-886
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Fix error when "job create" is called with "--open-browser".
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> 328297ab1d29efb0adce8f4931a13929a04dcd9c 
> 
> Diff: https://reviews.apache.org/r/27084/diff/
> 
> 
> Testing
> ---
> 
> Added new test; all unit tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 23329: remove embedded jquery

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23329/#review58218
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On July 9, 2014, 9:50 p.m., David Robinson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23329/
> ---
> 
> (Updated July 9, 2014, 9:50 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-578
> https://issues.apache.org/jira/browse/AURORA-578
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> remove embedded jquery
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 
> 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 
> 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl 
> b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23329/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Robinson
> 
>

Re: Review Request 27089: Add documentation for the beta-update command.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27089/#review58212
---


LGTM! Master (53f4e73) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 23, 2014, 5:31 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27089/
> ---
> 
> (Updated Oct. 23, 2014, 5:31 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-763
> https://issues.apache.org/jira/browse/AURORA-763
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add documentation for the beta-update command.
> 
> 
> Diffs
> -
> 
>   docs/client-commands.md 0424e8f5b386e0342a4c06870bbcbc01c0f20323 
> 
> Diff: https://reviews.apache.org/r/27089/diff/
> 
> 
> Testing
> ---
> 
> Rendered at 
> https://github.com/wfarner/incubator-aurora/blob/wfarner/document_updater/docs/client-commands.md
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 27097: Add a script to update build-support/pants_requirements.txt.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27097/#review58206
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 6:43 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27097/
> ---
> 
> (Updated Oct. 23, 2014, 6:43 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add a script to update build-support/pants_requirements.txt.
> Ran that script and it generated a slightly different output (no more system 
> dependencies).
> 
> Also fix a bug in the pants script that causes us to bootstrap pants
> on every run (missing $PANTS_VERSION).
> 
> 
> Diffs
> -
> 
>   build-support/pants_requirements.txt 
> bd46f439e32b84a24fad9f50be9d627906ec7c58 
>   build-support/python/update-pants-requirements PRE-CREATION 
>   pants e53de99c7762367a524d18e3641785dd7d1a459f 
> 
> Diff: https://reviews.apache.org/r/27097/diff/
> 
> 
> Testing
> ---
> 
> Ran the update requirements script and ran pants multiple times to confirm it 
> doesn't bootstrap.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58204
---

Master (53f4e73) is red with this patch.
  ./build-support/jenkins/build.sh

at org.gradle.util.ConfigureUtil.configure(ConfigureUtil.java:130)
at org.gradle.util.ConfigureUtil.configure(ConfigureUtil.java:91)
at org.gradle.util.ConfigureUtil$configure.call(Unknown Source)
at 
org.gradle.api.internal.project.DefaultIsolatedAntBuilder.execute(DefaultIsolatedAntBuilder.groovy:116)
at 
org.gradle.api.internal.project.IsolatedAntBuilder$execute$0.call(Unknown 
Source)
at org.gradle.api.plugins.quality.Checkstyle.run(Checkstyle.groovy:120)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:63)
at 
org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.doExecute(AnnotationProcessingTaskFactory.java:218)
at 
org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:211)
at 
org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$StandardTaskAction.execute(AnnotationProcessingTaskFactory.java:200)
at 
org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:579)
at 
org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:562)
at 
org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:80)
at 
org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:61)
... 47 more

BUILD FAILED

Total time: 51.003 secs

- Aurora ReviewBot

On Oct. 24, 2014, 12:24 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 24, 2014, 12:24 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58205
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 9:47 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 23, 2014, 9:47 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-248
> https://issues.apache.org/jira/browse/AURORA-248
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use of Mock() without a specification considered harmful. I went through and 
> updated as many mocks as I could. 
> 
> Any remaining can be classified as:
> 
> 1) Mocks of classes that cannot be spec'd. Almost all instances of 
> SchedulerProxy, which uses __getattr__ to delegate to the read or write 
> client. 
> 2) Primitives like strings and callback functions or data objects like dicts 
> and pystachio structs.
> 3) Weird mocks that broke code where they really shouldn't have (off the top 
> of my head - in test_diff.py and commands/test_run.py) - both when they were 
> spec'd and when they were replaced with real thrift structs. 
> 
> 
> The remaining offenders:
> 
> $ grep -r --include="*.py" "Mock()" src/test/python 
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_proxy = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_get = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_task_config = 
> Mock()
> src/test/python/apache/aurora/client/api/test_job_monitor.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_quota_check.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_scheduler_client.py:
> client._connect_scheduler = mock.MagicMock()
> src/test/python/apache/aurora/client/api/test_sla.py:self._scheduler = 
> Mock()
> src/test/python/apache/aurora/client/api/test_task_util.py:scheduler = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  job = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  
> job.assignedTask.task.executorConfig.data = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (_, _, subprocess_patch, _):
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_inspect.py:raw_config = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_task = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_process = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_proxy = 
> Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler = Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_client = 
> Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_api_factory = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:  job = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:  
> job.assignedTask.task.executorConfig.data = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_listjobs.py:
> mock_options = Mock()
> src/test/python/apache/aurora/client/commands/test_listjobs.py:  job = 
> Mock()
> src/test/python/apache/aurora/client/commands/test_maintenance.py:
> mock_callback = Mock()
> src/test/python/apache/aurora/client/commands/test_maintenance.py:  
> mock_wait = Mock()
> src/test/pytho

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/#review58203
---


LGTM! Master (53f4e73) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Oct. 23, 2014, 10:19 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27114/
> ---
> 
> (Updated Oct. 23, 2014, 10:19 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move from github to bintray for pants support binaries.
> 
> This is from advice from jsirois on 
> https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J
> 
> 
> Diffs
> -
> 
>   pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 
> 
> Diff: https://reviews.apache.org/r/27114/diff/
> 
> 
> Testing
> ---
> 
> [tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
> ./src/test/python/apache/aurora/admin:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
>  all)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 11 items 
> 
> src/test/python/apache/aurora/admin/test_host_maintenance.py ...
> 
> =
>  11 passed in 0.62 seconds 
> ==
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 2 items 
> 
> src/test/python/apache/aurora/admin/test_admin_util.py ..
> 
> ==
>  2 passed in 0.19 seconds 
> ==
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/
---

(Updated Oct. 23, 2014, 6:50 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Rebase to appease the robot.


Bugs: AURORA-878
https://issues.apache.org/jira/browse/AURORA-878


Repository: aurora


Description
---

Cache the host's maintenance status with the offer. By caching the status
alongside the offer the scheduler does not need to access the attribute store
for every offer it considers for a task.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
92c843830df7a779abace38bb0ce84d4cbeb5af4 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/http/Offers.java 
b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
  src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
9970948bace4c0ecbc51d6fc79270d77fb17bf87 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27100/diff/


Testing
---

./gradlew clean build -Pq


Thanks,

Zameer Manji

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Aurora ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58202
---


This patch does not apply cleanly on master (53f4e73), do you need to rebase?

- Aurora ReviewBot


On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 23, 2014, 6:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27100: Cache the host's maintenance status with offer.

2014-10-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27100/#review58198
---



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java


`getOnlyElement` feels risky here, since you're getting data from two 
sources that might not be synchronized.  i suggest we handle size > 1 and break 
out of the function by not preempting.



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java


s/this.//



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java


I'm tempted to suggest that we inspect the mode before calling `filter`.  I 
can't think of a reason this would be problematic.  All vetoes are collected 
(as opposed to failing on the first one) to supply an accurate pending reason, 
but the maintenance veto uses `MAX_SCORE` meaning it will trump everything else 
anyways.  This matches what we do for dedicated host mismatches as well.


- Bill Farner


On Oct. 23, 2014, 6:27 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27100/
> ---
> 
> (Updated Oct. 23, 2014, 6:27 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-878
> https://issues.apache.org/jira/browse/AURORA-878
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Cache the host's maintenance status with the offer. By caching the status
> alongside the offer the scheduler does not need to access the attribute store
> for every offer it considers for a task.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 
> 92c843830df7a779abace38bb0ce84d4cbeb5af4 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 
> 882cdfd9b79b262befb81437cbd9a31a6bc1e40f 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> c4435cb74925c9ed04a37820b22c3ecdfcad49d4 
>   src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java 
> ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
> 6534329a92bf005223fa8907cbe4a8a3a511e142 
>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
> 9970948bace4c0ecbc51d6fc79270d77fb17bf87 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27100/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26845: Adding Aurora scheduler storage doc.

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/
---

(Updated Oct. 24, 2014, 12:54 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Addressing jaybuff's comments.


Bugs: AURORA-839
https://issues.apache.org/jira/browse/AURORA-839


Repository: aurora


Description
---

Created a high level storage architecture write up.


Diffs (updated)
-

  docs/storage.md b6266c64248f827f74be9c77a76f11e7f3cbda78 

Diff: https://reviews.apache.org/r/26845/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md


Thanks,

Maxim Khutornenko

Re: Review Request 26845: Adding Aurora scheduler storage doc.

2014-10-23 Thread Maxim Khutornenko



> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 16
> > 
> >
> > I haven't really looked at the update features, yet.  Is this live and 
> > ready to go?  If not maybe defer referencing this until the updater work is 
> > shipped?

Yes, it's in beta and is available under "aurora beta-update" in the client.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 18
> > 
> >
> > This is pretty much the complete list of what is stored in the 
> > replicated log, right?  s/For Example/Aurora stores the follow data/

Not, really. There are other stores handling job locks and scheduler internal 
data (i.e. framework ID) that are insignificant for explicit mentioning.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 36
> > 
> >
> > Link to your doc that describes how to config and recover backups.  
> > When I read this I immediatly want to know how often the snapshots are 
> > taken and what negative impact there is from taking snapshots too 
> > frequently.

It was not available at the time of writing :), will make sure to add it.


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 11
> > 
> >
> > I'd like the see a paragraphic justifying avoiding the more traditional 
> > approaching of writing this data to a database like mysql or cassandra.  I 
> > think the justification is to remove deployment dependencies?

That and the high availability of a distributed storage. However, I'd avoid 
adding any comparative analysis here as we are currently re-evaluating our 
options ;)


> On Oct. 17, 2014, 3:19 p.m., Jay Buffington wrote:
> > docs/storage.md, line 40
> > 
> >
> > The ellipses serve no purpose. I'd remove them, but this is a minor 
> > knit.

Dropped.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57143
---


On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26845/
> ---
> 
> (Updated Oct. 17, 2014, 12:21 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
> https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Created a high level storage architecture write up.
> 
> 
> Diffs
> -
> 
>   docs/images/storage_hierarchy.png PRE-CREATION 
>   docs/storage.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26845/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_doc/docs/storage.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/#review58187
---

Ship it!


Ship It!

- Bill Farner


On Oct. 23, 2014, 10:19 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27114/
> ---
> 
> (Updated Oct. 23, 2014, 10:19 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move from github to bintray for pants support binaries.
> 
> This is from advice from jsirois on 
> https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J
> 
> 
> Diffs
> -
> 
>   pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 
> 
> Diff: https://reviews.apache.org/r/27114/diff/
> 
> 
> Testing
> ---
> 
> [tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
> ./src/test/python/apache/aurora/admin:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
>  all)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 11 items 
> 
> src/test/python/apache/aurora/admin/test_host_maintenance.py ...
> 
> =
>  11 passed in 0.62 seconds 
> ==
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 2 items 
> 
> src/test/python/apache/aurora/admin/test_admin_util.py ..
> 
> ==
>  2 passed in 0.19 seconds 
> ==
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 27098: Add Junit XML output for Python tests.

2014-10-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27098/#review58188
---

Ship it!


Ship It!

- Bill Farner


On Oct. 23, 2014, 6:28 p.m., Kevin Sweeney wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27098/
> ---
> 
> (Updated Oct. 23, 2014, 6:28 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Verified that this is the correct directory in Jenkins by peeking over 
> wfarner's shoulder.
> 
> Attempted to add coverage as well but it looks like pants doesn't support 
> anything beyond console output yet (even though pycov supports 
> coberatura-style output).
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/build.sh 26e5d13d09271d9604bf0de2c6e2ccbad9582ee1 
> 
> Diff: https://reviews.apache.org/r/27098/diff/
> 
> 
> Testing
> ---
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/
---

(Updated Oct. 23, 2014, 5:24 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Maxim's feedback.


Bugs: AURORA-830
https://issues.apache.org/jira/browse/AURORA-830


Repository: aurora


Description
---

This patch changes the scheduler such that the executor overhead can be 
configured from the commandline.


Diffs (updated)
-

  config/legacy_untested_classes.txt PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
e96974764844b5d1a3a05f6996075fccee209594 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27044/diff/


Testing
---

./gradlew clean build


Thanks,

Zameer Manji

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji



> On Oct. 23, 2014, 4:47 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java, line 52
> > 
> >
> > private? Does not seem to be used outside.

Making it private is a PMD violation: "Avoid instantiation through private 
constructors from outside of the constructors class."


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58170
---


On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 23, 2014, 4:06 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26851: Adding storage recovery from backup doc.

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/
---

(Updated Oct. 24, 2014, 12:18 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased.


Bugs: AURORA-839
https://issues.apache.org/jira/browse/AURORA-839


Repository: aurora


Description
---

Summarizing recovery from backup steps.


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 5f957c74a03621107edf881a1dd1f75f0c7ac007 
  docs/storage-config.md PRE-CREATION 

Diff: https://reviews.apache.org/r/26851/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md


Thanks,

Maxim Khutornenko

Re: Review Request 26851: Adding storage recovery from backup doc.

2014-10-23 Thread Maxim Khutornenko



> On Oct. 24, 2014, 12:09 a.m., Kevin Sweeney wrote:
> > docs/storage-config.md, line 81
> > 
> >
> > "restore a backup that is not extremely recent"

Good catch. Thanks.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/#review58175
---


On Oct. 24, 2014, 12:05 a.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26851/
> ---
> 
> (Updated Oct. 24, 2014, 12:05 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
> https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Summarizing recovery from backup steps.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 380577e0f5a45dd0d521f3379d76febde841927b 
>   docs/storage-config.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26851/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26851: Adding storage recovery from backup doc.

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/
---

(Updated Oct. 24, 2014, 12:13 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-839
https://issues.apache.org/jira/browse/AURORA-839


Repository: aurora


Description
---

Summarizing recovery from backup steps.


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 380577e0f5a45dd0d521f3379d76febde841927b 
  docs/storage-config.md PRE-CREATION 

Diff: https://reviews.apache.org/r/26851/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md


Thanks,

Maxim Khutornenko

Re: Review Request 26851: Adding storage recovery from backup doc.

2014-10-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/#review58175
---

Ship it!



docs/storage-config.md


"restore a backup that is not extremely recent"


- Kevin Sweeney


On Oct. 23, 2014, 5:05 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26851/
> ---
> 
> (Updated Oct. 23, 2014, 5:05 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
> https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Summarizing recovery from backup steps.
> 
> 
> Diffs
> -
> 
>   docs/deploying-aurora-scheduler.md 380577e0f5a45dd0d521f3379d76febde841927b 
>   docs/storage-config.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26851/diff/
> 
> 
> Testing
> ---
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 26851: Adding storage recovery from backup doc.

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/
---

(Updated Oct. 24, 2014, 12:05 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Added link from deploying-aurora-scheduler.md


Bugs: AURORA-839
https://issues.apache.org/jira/browse/AURORA-839


Repository: aurora


Description
---

Summarizing recovery from backup steps.


Diffs (updated)
-

  docs/deploying-aurora-scheduler.md 380577e0f5a45dd0d521f3379d76febde841927b 
  docs/storage-config.md PRE-CREATION 

Diff: https://reviews.apache.org/r/26851/diff/


Testing
---

https://github.com/maxim111333/incubator-aurora/blob/storage_config_doc/docs/storage-config.md


Thanks,

Maxim Khutornenko

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58170
---



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


private? Does not seem to be used outside.



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


newline



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


newline



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


missing param and return here and below



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


newline



src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java


missing javadoc from here down



src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java


newline


- Maxim Khutornenko


On Oct. 23, 2014, 11:06 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 23, 2014, 11:06 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji



> On Oct. 23, 2014, 3:32 p.m., Kevin Sweeney wrote:
> > Driveby comment: Consider using Guice's FactoryModuleBuilder to minimize 
> > the factory boilerplate needed. IMO this should be the default anytime you 
> > want a factory that gets some of its dependencies from Guice, as the 
> > created objects will be instrumentable by Guice AOP.

This is a great idea. I'm looking into it now.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58146
---


On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 23, 2014, 4:06 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 40b652c679d8e340f585e28cbed066335d9d760d 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 4088559c39014befaddb0b29dad45fac9f4545c4 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 899416fceae498353880012b8a93491cff461064 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/
---

(Updated Oct. 23, 2014, 4:06 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
---

Most feedback.


Bugs: AURORA-830
https://issues.apache.org/jira/browse/AURORA-830


Repository: aurora


Description
---

This patch changes the scheduler such that the executor overhead can be 
configured from the commandline.


Diffs (updated)
-

  config/legacy_untested_classes.txt PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
  src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
40b652c679d8e340f585e28cbed066335d9d760d 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
4088559c39014befaddb0b29dad45fac9f4545c4 
  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
  src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
da29428adaebcb27b20a10a8c6b7e380662fce4a 
  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
4db9be86f2e7db08d12e0182914a7c5130301b13 
  src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
e96974764844b5d1a3a05f6996075fccee209594 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
899416fceae498353880012b8a93491cff461064 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 4065629e9d488b122aa811b9802def0b51a21294 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
6a9c4ee278ed3ee8222404504e571f20991c2ae2 
  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
c48cbae4864127e7799917182439f7670285b0d3 

Diff: https://reviews.apache.org/r/27044/diff/


Testing
---

./gradlew clean build


Thanks,

Zameer Manji

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/
---

(Updated Oct. 23, 2014, 10:58 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased


Bugs: AURORA-84
https://issues.apache.org/jira/browse/AURORA-84


Repository: aurora


Description
---

Python side of changes for deprecating identity struct. Accounting for the 
upcoming deprecation by backfilling missing fields and switching between 
old/new fields (whichever is available).

Branched off of https://reviews.apache.org/r/26762/ and will have to be pushed 
together.

Summary of changes:
- TaskConfig - backfilling _key_ field in job diff and update commands.

Also, some unit test refactoring to avoid copy-pasted fragments.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/instance_watcher.py 
b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
  src/main/python/apache/aurora/client/api/sla.py 
b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
  src/main/python/apache/aurora/client/cli/jobs.py 
493ba21bd54768412ea3d293b6f0ccafada8158a 
  src/main/python/apache/aurora/client/cli/task.py 
c41484bdc27266443bc4e139e1ebb362a59be0f9 
  src/main/python/apache/aurora/client/commands/admin.py 
deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
  src/main/python/apache/aurora/client/commands/core.py 
58f419e674f1a9a0ae9da6faa2e39c8167bab597 
  src/main/python/apache/aurora/client/commands/ssh.py 
d2b8bf675556b924d3d63b545d036dc48a081486 
  src/main/python/apache/aurora/config/thrift.py 
9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
  src/main/python/apache/aurora/executor/aurora_executor.py 
2c6423d096656f426a4385f4edef6875ebad7049 
  src/main/python/apache/aurora/executor/common/announcer.py 
74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
  src/test/python/apache/aurora/client/api/test_sla.py 
1117f24d5ad3640632a1dd728913ba73c8bec707 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
95aa649cfff9166dd10aa432c4d470739e8f06c5 
  src/test/python/apache/aurora/client/cli/test_diff.py 
10817695352687cdb5b0c3ed9720e3091b230e68 
  src/test/python/apache/aurora/client/cli/test_status.py 
49ac2a46b4ae2546f7012915076b6659f42e3100 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
16fde14c03f6fd2c000e76625fad174835763f1b 
  src/test/python/apache/aurora/client/cli/test_update.py 
1ec5483506a22a774340acccd33f09f1742be8b7 
  src/test/python/apache/aurora/client/cli/util.py 
3fa609a5f71525393ca0a5dbd81423005fadb583 
  src/test/python/apache/aurora/client/commands/test_diff.py 
c8d01456aa52fd61374b4f0960b5159da2cb235b 
  src/test/python/apache/aurora/client/commands/test_ssh.py 
abb657ba397c23ddac6c6b188f70d1c4e34597a6 
  src/test/python/apache/aurora/client/commands/test_status.py 
639763501348a35bff2f127e18780ac74852f51b 
  src/test/python/apache/aurora/client/commands/test_update.py 
07cbe53109e8bcdd09dcac47f6353b10e095717d 
  src/test/python/apache/aurora/config/test_thrift.py 
1dd9e79099793aa7bb377c20c2a6a0c4b750be33 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
56943351ca09c29580dd764bb2442f0fcd9fde74 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
65e8cce60a5543081175c574aaaf92f200bc6233 

Diff: https://reviews.apache.org/r/26954/diff/


Testing
---

./pants src/test/python:all
test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Joshua Cohen



> On Oct. 22, 2014, 5:32 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java, 
> > line 67
> > 
> >
> > Do we actually need to use a ResourceSlotFactory here? The usage seems 
> > to be entirely internal to the test. We could just use constants?
> 
> Zameer Manji wrote:
> We need the slot factory to create the task factory in this test.

derp, missed that.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57825
---


On Oct. 22, 2014, 4:57 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 22, 2014, 4:57 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji



> On Oct. 22, 2014, 4:02 p.m., Maxim Khutornenko wrote:
> > config/legacy_untested_classes.txt, line 1
> > 
> >
> > This seems to be out of order, revert?

This is the output of the unix `sort` command.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57819
---


On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 22, 2014, 9:57 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji



> On Oct. 22, 2014, 3:07 p.m., Bill Farner wrote:
> > config/legacy_untested_classes.txt, line 9
> > 
> >
> > In the interest of this file being delete only, can you bite the bullet 
> > and create a unit test to cover these in a test?

That invovles doing this "TODO(wfarner): Try to accomplish all this by 
subclassing SchedulerMain and actually using AppLauncher." in SchedulerIT. I 
feel that deserves its own RB.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57917
---


On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 22, 2014, 9:57 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review58146
---


Driveby comment: Consider using Guice's FactoryModuleBuilder to minimize the 
factory boilerplate needed. IMO this should be the default anytime you want a 
factory that gets some of its dependencies from Guice, as the created objects 
will be instrumentable by Guice AOP.

- Kevin Sweeney


On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 22, 2014, 9:57 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/#review58143
---

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 23, 2014, 3:19 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27114/
> ---
> 
> (Updated Oct. 23, 2014, 3:19 p.m.)
> 
> 
> Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Move from github to bintray for pants support binaries.
> 
> This is from advice from jsirois on 
> https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J
> 
> 
> Diffs
> -
> 
>   pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 
> 
> Diff: https://reviews.apache.org/r/27114/diff/
> 
> 
> Testing
> ---
> 
> [tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
> ./src/test/python/apache/aurora/admin:all
> Build operating on top level addresses: 
> set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
>  all)])
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 11 items 
> 
> src/test/python/apache/aurora/admin/test_host_maintenance.py ...
> 
> =
>  11 passed in 0.62 seconds 
> ==
> 
>  test session starts 
> =
> platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 2 items 
> 
> src/test/python/apache/aurora/admin/test_admin_util.py ..
> 
> ==
>  2 passed in 0.19 seconds 
> ==
> src.test.python.apache.aurora.admin.admin_util
>   .   SUCCESS
> src.test.python.apache.aurora.admin.host_maintenance  
>   .   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Re: Review Request 27044: Make executor overhead configurable

2014-10-23 Thread Zameer Manji



> On Oct. 22, 2014, 10:32 a.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java, 
> > line 67
> > 
> >
> > Do we actually need to use a ResourceSlotFactory here? The usage seems 
> > to be entirely internal to the test. We could just use constants?

We need the slot factory to create the task factory in this test.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27044/#review57825
---


On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27044/
> ---
> 
> (Updated Oct. 22, 2014, 9:57 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-830
> https://issues.apache.org/jira/browse/AURORA-830
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This patch changes the scheduler such that the executor overhead can be 
> configured from the commandline.
> 
> 
> Diffs
> -
> 
>   config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 
>   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
> 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
> ed60447c798a97daceda4a3bba6ee9bcdcaedd0f 
>   src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 048740953629a950c136179c9b880b8dce8fa932 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> e9f251508257cd7287ff00773e0073a3cd130df8 
>   
> src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
>  283f7e1e22decfe1053bd5640e8283b40eeac592 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 
> 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 
>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 
> da29428adaebcb27b20a10a8c6b7e380662fce4a 
>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 
> 4db9be86f2e7db08d12e0182914a7c5130301b13 
>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
> e96974764844b5d1a3a05f6996075fccee209594 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> c405d4c8b127c2dd7054c9520064da0346690f02 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
>   
> src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
>  4065629e9d488b122aa811b9802def0b51a21294 
>   
> src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java
>  6a9c4ee278ed3ee8222404504e571f20991c2ae2 
>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 
> c48cbae4864127e7799917182439f7670285b0d3 
> 
> Diff: https://reviews.apache.org/r/27044/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/#review58141
---

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 23, 2014, 3:02 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26954/
> ---
> 
> (Updated Oct. 23, 2014, 3:02 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-84
> https://issues.apache.org/jira/browse/AURORA-84
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Python side of changes for deprecating identity struct. Accounting for the 
> upcoming deprecation by backfilling missing fields and switching between 
> old/new fields (whichever is available).
> 
> Branched off of https://reviews.apache.org/r/26762/ and will have to be 
> pushed together.
> 
> Summary of changes:
> - TaskConfig - backfilling _key_ field in job diff and update commands.
> 
> Also, some unit test refactoring to avoid copy-pasted fragments.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
>   src/main/python/apache/aurora/client/api/sla.py 
> b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/main/python/apache/aurora/client/cli/task.py 
> c41484bdc27266443bc4e139e1ebb362a59be0f9 
>   src/main/python/apache/aurora/client/commands/admin.py 
> deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 58f419e674f1a9a0ae9da6faa2e39c8167bab597 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> d2b8bf675556b924d3d63b545d036dc48a081486 
>   src/main/python/apache/aurora/config/thrift.py 
> 9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 2c6423d096656f426a4385f4edef6875ebad7049 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 1117f24d5ad3640632a1dd728913ba73c8bec707 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 1ec5483506a22a774340acccd33f09f1742be8b7 
>   src/test/python/apache/aurora/client/cli/util.py 
> 3fa609a5f71525393ca0a5dbd81423005fadb583 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> c8d01456aa52fd61374b4f0960b5159da2cb235b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> abb657ba397c23ddac6c6b188f70d1c4e34597a6 
>   src/test/python/apache/aurora/client/commands/test_status.py 
> 639763501348a35bff2f127e18780ac74852f51b 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> 07cbe53109e8bcdd09dcac47f6353b10e095717d 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 1dd9e79099793aa7bb377c20c2a6a0c4b750be33 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> 56943351ca09c29580dd764bb2442f0fcd9fde74 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 65e8cce60a5543081175c574aaaf92f200bc6233 
> 
> Diff: https://reviews.apache.org/r/26954/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

(Updated Oct. 23, 2014, 3:19 p.m.)


Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Changes
---

Actually use https


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs (updated)
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

(Updated Oct. 23, 2014, 3:19 p.m.)


Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Changes
---

Use https


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs (updated)
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Bill Farner


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/#review58132
---

Ship it!


Ship It!

- Bill Farner


On Oct. 23, 2014, 10:02 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26954/
> ---
> 
> (Updated Oct. 23, 2014, 10:02 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-84
> https://issues.apache.org/jira/browse/AURORA-84
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Python side of changes for deprecating identity struct. Accounting for the 
> upcoming deprecation by backfilling missing fields and switching between 
> old/new fields (whichever is available).
> 
> Branched off of https://reviews.apache.org/r/26762/ and will have to be 
> pushed together.
> 
> Summary of changes:
> - TaskConfig - backfilling _key_ field in job diff and update commands.
> 
> Also, some unit test refactoring to avoid copy-pasted fragments.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
>   src/main/python/apache/aurora/client/api/sla.py 
> b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 10f8e0d331ca607e55e3aa6f96014caea744ed9f 
>   src/main/python/apache/aurora/client/cli/task.py 
> c41484bdc27266443bc4e139e1ebb362a59be0f9 
>   src/main/python/apache/aurora/client/commands/admin.py 
> deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 58f419e674f1a9a0ae9da6faa2e39c8167bab597 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> d2b8bf675556b924d3d63b545d036dc48a081486 
>   src/main/python/apache/aurora/config/thrift.py 
> 9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 2c6423d096656f426a4385f4edef6875ebad7049 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 1117f24d5ad3640632a1dd728913ba73c8bec707 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 1ec5483506a22a774340acccd33f09f1742be8b7 
>   src/test/python/apache/aurora/client/cli/util.py 
> 3fa609a5f71525393ca0a5dbd81423005fadb583 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> c8d01456aa52fd61374b4f0960b5159da2cb235b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> abb657ba397c23ddac6c6b188f70d1c4e34597a6 
>   src/test/python/apache/aurora/client/commands/test_status.py 
> 639763501348a35bff2f127e18780ac74852f51b 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> 07cbe53109e8bcdd09dcac47f6353b10e095717d 
>   src/test/python/apache/aurora/config/test_thrift.py 
> 1dd9e79099793aa7bb377c20c2a6a0c4b750be33 
>   src/test/python/apache/aurora/executor/common/test_announcer.py 
> 56943351ca09c29580dd764bb2442f0fcd9fde74 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 65e8cce60a5543081175c574aaaf92f200bc6233 
> 
> Diff: https://reviews.apache.org/r/26954/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python:all
> test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Joe Smith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27114/
---

Review request for Aurora, John Sirois, Kevin Sweeney, and Bill Farner.


Repository: aurora


Description
---

Move from github to bintray for pants support binaries.

This is from advice from jsirois on 
https://groups.google.com/d/msg/pants-devel/khP3TuSqWmo/nLqgc671Og0J


Diffs
-

  pants.ini 6f49f94236d1e1ed721578365173c96dc4420b02 

Diff: https://reviews.apache.org/r/27114/diff/


Testing
---

[tw-mbp13-jsmith aurora (yasumoto/pants_bintray)]$ ./pants 
./src/test/python/apache/aurora/admin:all
Build operating on top level addresses: 
set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/admin/BUILD,
 all)])

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 11 items 

src/test/python/apache/aurora/admin/test_host_maintenance.py ...

=
 11 passed in 0.62 seconds 
==

 test session starts 
=
platform darwin -- Python 2.7.6 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 2 items 

src/test/python/apache/aurora/admin/test_admin_util.py ..

==
 2 passed in 0.19 seconds 
==
src.test.python.apache.aurora.admin.admin_util  
.   SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
.   SUCCESS


Thanks,

Joe Smith

Re: Review Request 26762: Preparing for Identity struct deprecation (scheduler).

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26762/
---

(Updated Oct. 23, 2014, 10:06 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Minor comment changes.


Bugs: AURORA-84
https://issues.apache.org/jira/browse/AURORA-84


Repository: aurora


Description
---

This patch replaces the Identity struct use within the scheduler and makes it 
ready for removal (i.e. when the JobStore is ready). 

Sending it as a separate CR for easier reviewing. 

Will have to be committed along with python changes 
(https://reviews.apache.org/r/26954/) to avoid breaking client diff 
functionality.

Summary of the changes:
* TaskConfig - dual write in StorageBackfill to populate new _key_ field. 
Incoming thrift objects are populated in ConfigurationManager during sanitizing.
* TaskQuery - _owner_ to _role_ switch is handled in Query.Builder. All 
internal searching is now handled via _role_.
* JobConfiguration - internal _owner_ refs redirected to _key.role_ 0.7.0.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
5c75cc8cae53edfa069c85c37ebad34774682081 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
f1ab934541ad6d9ae74927f80a9c654a04922eb5 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
e9f251508257cd7287ff00773e0073a3cd130df8 
  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
a76c3fac71b35115064fba6644cff0066fd9e630 
  src/main/java/org/apache/aurora/scheduler/base/Query.java 
d518acbff04fecda5c3592340e78fc77da9e339d 
  src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
6ad79270c35c4fccb01f29d34ef1c4bbd7c953c8 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 5871dcad819b27db7379c69c6f8ff69f4a1b0104 
  src/main/java/org/apache/aurora/scheduler/http/Utilization.java 
a0cb7bf56aeb7edd92b25d8d69a739d87452777a 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
5f08997f04ffa7d9610c2b41551943b563412626 
  src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 
2d27ad953c5f3763bf23f7e6efc26710f32906b6 
  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 
58b94c2f2f3bac00f0692579974e8bdf159b6e40 
  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
3b3cef2a1b09c85aa06e45e734164f87f2510c55 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 
37176237fac336413267f3c8bb4e1b9a6255150c 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
610fe02b96c5d5fc3506aff6bf518220bc1ae0cd 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
6ec130f4a9a5075b34452efb27c8fd0f08f93a63 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
7a4aa73178299651c21e44699ec3e9e494eaa4ab 
  src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java 
e96974764844b5d1a3a05f6996075fccee209594 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
371ae87f5954fa5f092db1f6d21e2291d7576173 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
c405d4c8b127c2dd7054c9520064da0346690f02 
  src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
8ee84cda8670d117e2efa2d1a114da6f0d8315d6 
  src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 
b3e4ae39067b1dfb632f5d685d69fcbd7d4705da 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 
6534329a92bf005223fa8907cbe4a8a3a511e142 
  src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 
919c79e8cec6441a19db2afdd4c414dc6f0e0dc5 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
d2d3e86bb5acf3402f55188b9ae440412ef14b5a 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
33790b118e788d7c894f7635f896619a3266192a 
  src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 
21640f7ec2172d4c1b1bc744a4d71a6fa0a29376 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
cf4a015a040338a642fb07eec1fb7b5c11058fe5 
  src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
fc12933cefdbfc03de5918de04172c0744d34588 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
0c1a271972702c64d8a4db3d3d1127a00d48d679 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 
581f6391c59244b3376d2796b2c7cd8650549c3b 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 3fde3f75f8476338af2dde12862af39c8ad67226 
  
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
 5242a43b1c8a236b9420625a64ff24ad9ff75643 
  src/test/java/org/apache/aurora/s

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/
---

(Updated Oct. 23, 2014, 10:02 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Fixed status command changes escaped rebasing.


Bugs: AURORA-84
https://issues.apache.org/jira/browse/AURORA-84


Repository: aurora


Description
---

Python side of changes for deprecating identity struct. Accounting for the 
upcoming deprecation by backfilling missing fields and switching between 
old/new fields (whichever is available).

Branched off of https://reviews.apache.org/r/26762/ and will have to be pushed 
together.

Summary of changes:
- TaskConfig - backfilling _key_ field in job diff and update commands.

Also, some unit test refactoring to avoid copy-pasted fragments.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/instance_watcher.py 
b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
  src/main/python/apache/aurora/client/api/sla.py 
b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
  src/main/python/apache/aurora/client/cli/jobs.py 
10f8e0d331ca607e55e3aa6f96014caea744ed9f 
  src/main/python/apache/aurora/client/cli/task.py 
c41484bdc27266443bc4e139e1ebb362a59be0f9 
  src/main/python/apache/aurora/client/commands/admin.py 
deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
  src/main/python/apache/aurora/client/commands/core.py 
58f419e674f1a9a0ae9da6faa2e39c8167bab597 
  src/main/python/apache/aurora/client/commands/ssh.py 
d2b8bf675556b924d3d63b545d036dc48a081486 
  src/main/python/apache/aurora/config/thrift.py 
9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
  src/main/python/apache/aurora/executor/aurora_executor.py 
2c6423d096656f426a4385f4edef6875ebad7049 
  src/main/python/apache/aurora/executor/common/announcer.py 
74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
  src/test/python/apache/aurora/client/api/test_sla.py 
1117f24d5ad3640632a1dd728913ba73c8bec707 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
95aa649cfff9166dd10aa432c4d470739e8f06c5 
  src/test/python/apache/aurora/client/cli/test_diff.py 
10817695352687cdb5b0c3ed9720e3091b230e68 
  src/test/python/apache/aurora/client/cli/test_status.py 
4f62cf0c52e5837309cf7ad702df6d907df8f510 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
16fde14c03f6fd2c000e76625fad174835763f1b 
  src/test/python/apache/aurora/client/cli/test_update.py 
1ec5483506a22a774340acccd33f09f1742be8b7 
  src/test/python/apache/aurora/client/cli/util.py 
3fa609a5f71525393ca0a5dbd81423005fadb583 
  src/test/python/apache/aurora/client/commands/test_diff.py 
c8d01456aa52fd61374b4f0960b5159da2cb235b 
  src/test/python/apache/aurora/client/commands/test_ssh.py 
abb657ba397c23ddac6c6b188f70d1c4e34597a6 
  src/test/python/apache/aurora/client/commands/test_status.py 
639763501348a35bff2f127e18780ac74852f51b 
  src/test/python/apache/aurora/client/commands/test_update.py 
07cbe53109e8bcdd09dcac47f6353b10e095717d 
  src/test/python/apache/aurora/config/test_thrift.py 
1dd9e79099793aa7bb377c20c2a6a0c4b750be33 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
56943351ca09c29580dd764bb2442f0fcd9fde74 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
65e8cce60a5543081175c574aaaf92f200bc6233 

Diff: https://reviews.apache.org/r/26954/diff/


Testing
---

./pants src/test/python:all
test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin



> On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252
> > 
> >
> > I don't think this needs to be a mock at all - I'm pretty sure that you 
> > can just populate a real Response object directly. It looks like a lot of 
> > the others are like this.
> 
> Kevin Sweeney wrote:
> +1, and since the thrift structs work off dynamic properties, spec is 
> useless here. Calling the generated kwargs constructor gives you better 
> coverage here, as you can't accidentally create a thrift struct with a field 
> that doesn't exist without a TypeError
> 
> Maxim Khutornenko wrote:
> That's not true. Spec works just fine with thrift objects. For example, 
> adding 'spec=TaskConfig' generates an error where the same test would 
> previously pass:
> 
> AttributeError: Mock object has no attribute 'executorConfig'
> 
> David McLaughlin wrote:
> This is the behavior I observed as well. For example, see where I had to 
> update failure_count to failureCount because I added the spec. 
> 
> I'd really prefer a separate ticket for swapping out mocks for real 
> thrift objects.
> 
> Joe Smith wrote:
> +1 on specs for thrift structs.
> 
> @dmcg: I'm good with a separate JIRA if you cut it and add the 'newbie' 
> label.
> 
> David McLaughlin wrote:
> https://issues.apache.org/jira/browse/AURORA-890
> 
> Kevin Sweeney wrote:
> @Maxim spec=TaskConfig did nothing there; spec=object does the same thing.
> 
> David McLaughlin wrote:
> This whole conversation is redundant. You create a mock to make sure that 
> the code under test can access the properties it needs from other objects you 
> are not testing. If the calling code tries to access a property and there is 
> 
> a) a typo in your mock/spec/real object
> b) an old/obsolete property name on your mock/spec/real object
> 
> Then the test would fail with "object has no attribute 'blah'". If the 
> calling code doesn't trigger such an error, then those attributes are not 
> relevant to this unit test.
> 
> Kevin Sweeney wrote:
> As a code reader using the struct type name gives me a false sense of 
> security - there's nothing to prevent you from doing
> 
> ```py
> config = Mock(spec=TaskConfig)
> config.fake_value = "bogus"
> assert config.fake_value == "bogus"
> ```
> 
> whereas:
> 
> ```py
> config = TaskConfig(fake_value="bogus")
> assert config.fake_value == "bogus"
> ```
> 
> will raise a `TypeError`.
> 
> David McLaughlin wrote:
> This code is an example of you testing the code you've written in a test. 
> I feel this is not really relevant to the spirit of this particular ticket. 
> Does the ticket I've filed satisfy you or do you want to block this review on 
> this issue?
> 
> Kevin Sweeney wrote:
> I disagree - that change is exactly what's in scope of this particular 
> ticket. The point of spec is to prevent typos by speccing against the API. 
> The particular mocking technique of using spec=StructName doesn't work here 
> because the generated class doesn't have any attributes. However it is 
> possible, by using the arg names as a `spec_set` argument:
> 
> ```py
> TaskConfig_argnames = inspect.getargspec(TaskConfig.__init__)[0][1:]
> Mock(spec_set=TaskConfig_argnames)
> ```
> 
> Then sets to properties that aren't defined in the Thrift API will fail.
> 
> David McLaughlin wrote:
> If you look at the rb that was filed for this ticket you'll see the 
> 'spirit' I was referring to. I mean we literally have specs that look like 
> this:
> 
> 
> mock_options = Mock(spec=['bindings', 'cluster', 'env', 'json', 
> 'open_browser', 'rename_from'])
> 
> 
> These strings are duplicated from the option names defined in 
> argparse/our layers of wrappers. And this is where we've actually seen bugs, 
> not thrift field renames.
> 
> David McLaughlin wrote:
> /s/rb/JIRA description/

I filed another ticket to try and solve the problem above: 

https://issues.apache.org/jira/browse/AURORA-892

In the meantime I've switched to spec_set as spec alone was a no-op the way we 
were using it.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review57926
---


On Oct. 23, 2014, 9:47 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 23, 2014, 9:47 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bug

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread Kevin Sweeney


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review58120
---

Ship it!


Ship It!

- Kevin Sweeney


On Oct. 23, 2014, 2:47 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 23, 2014, 2:47 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-248
> https://issues.apache.org/jira/browse/AURORA-248
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use of Mock() without a specification considered harmful. I went through and 
> updated as many mocks as I could. 
> 
> Any remaining can be classified as:
> 
> 1) Mocks of classes that cannot be spec'd. Almost all instances of 
> SchedulerProxy, which uses __getattr__ to delegate to the read or write 
> client. 
> 2) Primitives like strings and callback functions or data objects like dicts 
> and pystachio structs.
> 3) Weird mocks that broke code where they really shouldn't have (off the top 
> of my head - in test_diff.py and commands/test_run.py) - both when they were 
> spec'd and when they were replaced with real thrift structs. 
> 
> 
> The remaining offenders:
> 
> $ grep -r --include="*.py" "Mock()" src/test/python 
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/admin/test_host_maintenance.py:
> mock_callback = mock.Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_proxy = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_get = Mock()
> src/test/python/apache/aurora/client/api/test_api.py:mock_task_config = 
> Mock()
> src/test/python/apache/aurora/client/api/test_job_monitor.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_quota_check.py:
> self._scheduler = Mock()
> src/test/python/apache/aurora/client/api/test_scheduler_client.py:
> client._connect_scheduler = mock.MagicMock()
> src/test/python/apache/aurora/client/api/test_sla.py:self._scheduler = 
> Mock()
> src/test/python/apache/aurora/client/api/test_task_util.py:scheduler = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  job = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:  
> job.assignedTask.task.executorConfig.data = Mock()
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (_, _, subprocess_patch, _):
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/cli/test_inspect.py:raw_config = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_task = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_inspect.py:mock_process = 
> Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/test_kill.py:
> mock_scheduler_proxy = Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_proxy = 
> Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler = Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_client = 
> Mock()
> src/test/python/apache/aurora/client/cli/util.py:mock_api_factory = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:  job = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:  
> job.assignedTask.task.executorConfig.data = Mock()
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_diff.py:
> patch('json.loads', return_value=Mock())) as (
> src/test/python/apache/aurora/client/commands/test_listjobs.py:
> mock_options = Mock()
> src/test/python/apache/aurora/client/commands/test_listjobs.py:  job = 
> Mock()
> src/test/python/apache/aurora/client/commands/test_maintenance.py:
> mock_callback = Mock()
> src/test/python/apache/aurora/client/commands/test_maintenance.py:  
> mock_wait = Mock()
> src/test/python/apache/aurora/client/commands/util.py:
> mock_scheduler_

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/
---

(Updated Oct. 23, 2014, 9:47 p.m.)


Review request for Aurora, Mark Chu-Carroll and Zameer Manji.


Changes
---

Use spec_set instead of spec for mock options. 


Bugs: AURORA-248
https://issues.apache.org/jira/browse/AURORA-248


Repository: aurora


Description
---

Use of Mock() without a specification considered harmful. I went through and 
updated as many mocks as I could. 

Any remaining can be classified as:

1) Mocks of classes that cannot be spec'd. Almost all instances of 
SchedulerProxy, which uses __getattr__ to delegate to the read or write client. 
2) Primitives like strings and callback functions or data objects like dicts 
and pystachio structs.
3) Weird mocks that broke code where they really shouldn't have (off the top of 
my head - in test_diff.py and commands/test_run.py) - both when they were 
spec'd and when they were replaced with real thrift structs. 


The remaining offenders:

$ grep -r --include="*.py" "Mock()" src/test/python 
src/test/python/apache/aurora/admin/test_host_maintenance.py:mock_callback 
= mock.Mock()
src/test/python/apache/aurora/admin/test_host_maintenance.py:mock_callback 
= mock.Mock()
src/test/python/apache/aurora/client/api/test_api.py:mock_proxy = Mock()
src/test/python/apache/aurora/client/api/test_api.py:mock_get = Mock()
src/test/python/apache/aurora/client/api/test_api.py:mock_task_config = 
Mock()
src/test/python/apache/aurora/client/api/test_job_monitor.py:
self._scheduler = Mock()
src/test/python/apache/aurora/client/api/test_quota_check.py:
self._scheduler = Mock()
src/test/python/apache/aurora/client/api/test_scheduler_client.py:
client._connect_scheduler = mock.MagicMock()
src/test/python/apache/aurora/client/api/test_sla.py:self._scheduler = 
Mock()
src/test/python/apache/aurora/client/api/test_task_util.py:scheduler = 
Mock()
src/test/python/apache/aurora/client/cli/test_diff.py:  job = Mock()
src/test/python/apache/aurora/client/cli/test_diff.py:  
job.assignedTask.task.executorConfig.data = Mock()
src/test/python/apache/aurora/client/cli/test_diff.py:
patch('json.loads', return_value=Mock())) as (_, _, subprocess_patch, _):
src/test/python/apache/aurora/client/cli/test_diff.py:
patch('json.loads', return_value=Mock())) as (
src/test/python/apache/aurora/client/cli/test_diff.py:
patch('json.loads', return_value=Mock())) as (
src/test/python/apache/aurora/client/cli/test_inspect.py:raw_config = Mock()
src/test/python/apache/aurora/client/cli/test_inspect.py:mock_task = Mock()
src/test/python/apache/aurora/client/cli/test_inspect.py:mock_process = 
Mock()
src/test/python/apache/aurora/client/cli/test_kill.py:mock_scheduler_proxy 
= Mock()
src/test/python/apache/aurora/client/cli/test_kill.py:mock_scheduler_proxy 
= Mock()
src/test/python/apache/aurora/client/cli/test_kill.py:mock_scheduler_proxy 
= Mock()
src/test/python/apache/aurora/client/cli/test_kill.py:mock_scheduler_proxy 
= Mock()
src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_proxy = 
Mock()
src/test/python/apache/aurora/client/cli/util.py:mock_scheduler = Mock()
src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_client = 
Mock()
src/test/python/apache/aurora/client/cli/util.py:mock_api_factory = Mock()
src/test/python/apache/aurora/client/commands/test_diff.py:  job = Mock()
src/test/python/apache/aurora/client/commands/test_diff.py:  
job.assignedTask.task.executorConfig.data = Mock()
src/test/python/apache/aurora/client/commands/test_diff.py:
patch('json.loads', return_value=Mock())) as (
src/test/python/apache/aurora/client/commands/test_diff.py:
patch('json.loads', return_value=Mock())) as (
src/test/python/apache/aurora/client/commands/test_diff.py:
patch('json.loads', return_value=Mock())) as (
src/test/python/apache/aurora/client/commands/test_listjobs.py:mock_options 
= Mock()
src/test/python/apache/aurora/client/commands/test_listjobs.py:  job = 
Mock()
src/test/python/apache/aurora/client/commands/test_maintenance.py:
mock_callback = Mock()
src/test/python/apache/aurora/client/commands/test_maintenance.py:  
mock_wait = Mock()
src/test/python/apache/aurora/client/commands/util.py:mock_scheduler_proxy 
= Mock()
src/test/python/apache/aurora/client/commands/util.py:mock_api_factory = 
Mock()


Diffs (updated)
-

  src/test/python/apache/aurora/admin/test_admin_util.py 
f5c8c69c1109d15ee3886fb863014c3285240db1 
  src/test/python/apache/aurora/client/cli/test_command_hooks.py 
9fc6fe2c2063cda494437d83044557b345acacea 
  src/test/python/apache/aurora/client/cli/test_cron.py 
c7b71c29d44150162fec8066947623fa91815424 
  src/test/python/apache/aurora/client

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Maxim Khutornenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/
---

(Updated Oct. 23, 2014, 8:40 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Rebased and addressed comments.


Bugs: AURORA-84
https://issues.apache.org/jira/browse/AURORA-84


Repository: aurora


Description
---

Python side of changes for deprecating identity struct. Accounting for the 
upcoming deprecation by backfilling missing fields and switching between 
old/new fields (whichever is available).

Branched off of https://reviews.apache.org/r/26762/ and will have to be pushed 
together.

Summary of changes:
- TaskConfig - backfilling _key_ field in job diff and update commands.

Also, some unit test refactoring to avoid copy-pasted fragments.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/instance_watcher.py 
b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
  src/main/python/apache/aurora/client/api/sla.py 
b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
  src/main/python/apache/aurora/client/cli/task.py 
c41484bdc27266443bc4e139e1ebb362a59be0f9 
  src/main/python/apache/aurora/client/commands/admin.py 
deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
  src/main/python/apache/aurora/client/commands/core.py 
58f419e674f1a9a0ae9da6faa2e39c8167bab597 
  src/main/python/apache/aurora/client/commands/ssh.py 
d2b8bf675556b924d3d63b545d036dc48a081486 
  src/main/python/apache/aurora/config/thrift.py 
9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
  src/main/python/apache/aurora/executor/aurora_executor.py 
2c6423d096656f426a4385f4edef6875ebad7049 
  src/main/python/apache/aurora/executor/common/announcer.py 
74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
  src/test/python/apache/aurora/client/api/test_instance_watcher.py 
ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
  src/test/python/apache/aurora/client/api/test_sla.py 
1117f24d5ad3640632a1dd728913ba73c8bec707 
  src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
95aa649cfff9166dd10aa432c4d470739e8f06c5 
  src/test/python/apache/aurora/client/cli/test_diff.py 
10817695352687cdb5b0c3ed9720e3091b230e68 
  src/test/python/apache/aurora/client/cli/test_status.py 
4f62cf0c52e5837309cf7ad702df6d907df8f510 
  src/test/python/apache/aurora/client/cli/test_task_run.py 
16fde14c03f6fd2c000e76625fad174835763f1b 
  src/test/python/apache/aurora/client/cli/test_update.py 
1ec5483506a22a774340acccd33f09f1742be8b7 
  src/test/python/apache/aurora/client/cli/util.py 
3fa609a5f71525393ca0a5dbd81423005fadb583 
  src/test/python/apache/aurora/client/commands/test_diff.py 
c8d01456aa52fd61374b4f0960b5159da2cb235b 
  src/test/python/apache/aurora/client/commands/test_ssh.py 
abb657ba397c23ddac6c6b188f70d1c4e34597a6 
  src/test/python/apache/aurora/client/commands/test_status.py 
639763501348a35bff2f127e18780ac74852f51b 
  src/test/python/apache/aurora/client/commands/test_update.py 
07cbe53109e8bcdd09dcac47f6353b10e095717d 
  src/test/python/apache/aurora/config/test_thrift.py 
1dd9e79099793aa7bb377c20c2a6a0c4b750be33 
  src/test/python/apache/aurora/executor/common/test_announcer.py 
56943351ca09c29580dd764bb2442f0fcd9fde74 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
65e8cce60a5543081175c574aaaf92f200bc6233 

Diff: https://reviews.apache.org/r/26954/diff/


Testing
---

./pants src/test/python:all
test_end_to_end.sh


Thanks,

Maxim Khutornenko

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Maxim Khutornenko



> On Oct. 22, 2014, 11:51 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_diff.py, line 60
> > 
> >
> > While you're here, please change this to not use Mock, all down the 
> > hierarchy.
> > 
> > Ditto for other cargo cults (thanks for collapsing a few, btw).
> 
> Maxim Khutornenko wrote:
> I collapsed all related cli methods into util.py and using specs for all 
> Mocks now. Did not modify the commands (v1) tests to let them die out 
> naturally.
> 
> I actually like mocks here as tests fail when accessing a field that is 
> not populated.
> 
> Bill Farner wrote:
> Please chime in on https://reviews.apache.org/r/27058/, where the exact 
> opposite perspective exists.
> 
> Maxim Khutornenko wrote:
> Commented there. Having a Mock with spec here really helps identifying 
> the usage.
> 
> Kevin Sweeney wrote:
> See my comments there - tl;dr `Mock(spec=ThriftStruct)` should be 
> considered harmful as it's no better than `Mock(spec=object)`.
> 
> Either calling the kwargs constructor or using `spec_set` with the 
> constructor kwargs retrieved via reflection gets us the correct behavior 
> here. Since this seems to be a source of confusion for several people we're 
> probably well-served factoring out a thrift_test_util library or moving to 
> kwargs everywhere.

Agree, spec is not deterministic enough in this case. Refactored.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/#review57933
---


On Oct. 22, 2014, 11:59 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26954/
> ---
> 
> (Updated Oct. 22, 2014, 11:59 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-84
> https://issues.apache.org/jira/browse/AURORA-84
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Python side of changes for deprecating identity struct. Accounting for the 
> upcoming deprecation by backfilling missing fields and switching between 
> old/new fields (whichever is available).
> 
> Branched off of https://reviews.apache.org/r/26762/ and will have to be 
> pushed together.
> 
> Summary of changes:
> - TaskConfig - backfilling _key_ field in job diff and update commands.
> 
> Also, some unit test refactoring to avoid copy-pasted fragments.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
>   src/main/python/apache/aurora/client/api/sla.py 
> b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
>   src/main/python/apache/aurora/client/cli/task.py 
> c41484bdc27266443bc4e139e1ebb362a59be0f9 
>   src/main/python/apache/aurora/client/commands/admin.py 
> deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 58f419e674f1a9a0ae9da6faa2e39c8167bab597 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> d2b8bf675556b924d3d63b545d036dc48a081486 
>   src/main/python/apache/aurora/config/thrift.py 
> 9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 2c6423d096656f426a4385f4edef6875ebad7049 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 1117f24d5ad3640632a1dd728913ba73c8bec707 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 1ec5483506a22a774340acccd33f09f1742be8b7 
>   src/test/python/apache/aurora/client/cli/util.py 
> 3fa609a5f71525393ca0a5dbd81423005fadb583 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> c8d01456aa52fd61374b4f0960b5159da2cb235b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> abb657ba397c23ddac6c6b188f70d1c4e34597a6 
>   src/test/python/apache/aurora/client/commands/test_status.py 
> 639763501348a35bff2f127e18780ac74852f51b 
>   src/test/python/apache/aurora/client

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin



> On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252
> > 
> >
> > I don't think this needs to be a mock at all - I'm pretty sure that you 
> > can just populate a real Response object directly. It looks like a lot of 
> > the others are like this.
> 
> Kevin Sweeney wrote:
> +1, and since the thrift structs work off dynamic properties, spec is 
> useless here. Calling the generated kwargs constructor gives you better 
> coverage here, as you can't accidentally create a thrift struct with a field 
> that doesn't exist without a TypeError
> 
> Maxim Khutornenko wrote:
> That's not true. Spec works just fine with thrift objects. For example, 
> adding 'spec=TaskConfig' generates an error where the same test would 
> previously pass:
> 
> AttributeError: Mock object has no attribute 'executorConfig'
> 
> David McLaughlin wrote:
> This is the behavior I observed as well. For example, see where I had to 
> update failure_count to failureCount because I added the spec. 
> 
> I'd really prefer a separate ticket for swapping out mocks for real 
> thrift objects.
> 
> Joe Smith wrote:
> +1 on specs for thrift structs.
> 
> @dmcg: I'm good with a separate JIRA if you cut it and add the 'newbie' 
> label.
> 
> David McLaughlin wrote:
> https://issues.apache.org/jira/browse/AURORA-890
> 
> Kevin Sweeney wrote:
> @Maxim spec=TaskConfig did nothing there; spec=object does the same thing.
> 
> David McLaughlin wrote:
> This whole conversation is redundant. You create a mock to make sure that 
> the code under test can access the properties it needs from other objects you 
> are not testing. If the calling code tries to access a property and there is 
> 
> a) a typo in your mock/spec/real object
> b) an old/obsolete property name on your mock/spec/real object
> 
> Then the test would fail with "object has no attribute 'blah'". If the 
> calling code doesn't trigger such an error, then those attributes are not 
> relevant to this unit test.
> 
> Kevin Sweeney wrote:
> As a code reader using the struct type name gives me a false sense of 
> security - there's nothing to prevent you from doing
> 
> ```py
> config = Mock(spec=TaskConfig)
> config.fake_value = "bogus"
> assert config.fake_value == "bogus"
> ```
> 
> whereas:
> 
> ```py
> config = TaskConfig(fake_value="bogus")
> assert config.fake_value == "bogus"
> ```
> 
> will raise a `TypeError`.
> 
> David McLaughlin wrote:
> This code is an example of you testing the code you've written in a test. 
> I feel this is not really relevant to the spirit of this particular ticket. 
> Does the ticket I've filed satisfy you or do you want to block this review on 
> this issue?
> 
> Kevin Sweeney wrote:
> I disagree - that change is exactly what's in scope of this particular 
> ticket. The point of spec is to prevent typos by speccing against the API. 
> The particular mocking technique of using spec=StructName doesn't work here 
> because the generated class doesn't have any attributes. However it is 
> possible, by using the arg names as a `spec_set` argument:
> 
> ```py
> TaskConfig_argnames = inspect.getargspec(TaskConfig.__init__)[0][1:]
> Mock(spec_set=TaskConfig_argnames)
> ```
> 
> Then sets to properties that aren't defined in the Thrift API will fail.
> 
> David McLaughlin wrote:
> If you look at the rb that was filed for this ticket you'll see the 
> 'spirit' I was referring to. I mean we literally have specs that look like 
> this:
> 
> 
> mock_options = Mock(spec=['bindings', 'cluster', 'env', 'json', 
> 'open_browser', 'rename_from'])
> 
> 
> These strings are duplicated from the option names defined in 
> argparse/our layers of wrappers. And this is where we've actually seen bugs, 
> not thrift field renames.

/s/rb/JIRA description/


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review57926
---


On Oct. 23, 2014, 6:14 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 23, 2014, 6:14 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-248
> https://issues.apache.org/jira/browse/AURORA-248
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use of Mock() without a specification considered harmful. I went through and 
> updated as many mocks as I cou

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-23 Thread David McLaughlin



> On Oct. 22, 2014, 11:24 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252
> > 
> >
> > I don't think this needs to be a mock at all - I'm pretty sure that you 
> > can just populate a real Response object directly. It looks like a lot of 
> > the others are like this.
> 
> Kevin Sweeney wrote:
> +1, and since the thrift structs work off dynamic properties, spec is 
> useless here. Calling the generated kwargs constructor gives you better 
> coverage here, as you can't accidentally create a thrift struct with a field 
> that doesn't exist without a TypeError
> 
> Maxim Khutornenko wrote:
> That's not true. Spec works just fine with thrift objects. For example, 
> adding 'spec=TaskConfig' generates an error where the same test would 
> previously pass:
> 
> AttributeError: Mock object has no attribute 'executorConfig'
> 
> David McLaughlin wrote:
> This is the behavior I observed as well. For example, see where I had to 
> update failure_count to failureCount because I added the spec. 
> 
> I'd really prefer a separate ticket for swapping out mocks for real 
> thrift objects.
> 
> Joe Smith wrote:
> +1 on specs for thrift structs.
> 
> @dmcg: I'm good with a separate JIRA if you cut it and add the 'newbie' 
> label.
> 
> David McLaughlin wrote:
> https://issues.apache.org/jira/browse/AURORA-890
> 
> Kevin Sweeney wrote:
> @Maxim spec=TaskConfig did nothing there; spec=object does the same thing.
> 
> David McLaughlin wrote:
> This whole conversation is redundant. You create a mock to make sure that 
> the code under test can access the properties it needs from other objects you 
> are not testing. If the calling code tries to access a property and there is 
> 
> a) a typo in your mock/spec/real object
> b) an old/obsolete property name on your mock/spec/real object
> 
> Then the test would fail with "object has no attribute 'blah'". If the 
> calling code doesn't trigger such an error, then those attributes are not 
> relevant to this unit test.
> 
> Kevin Sweeney wrote:
> As a code reader using the struct type name gives me a false sense of 
> security - there's nothing to prevent you from doing
> 
> ```py
> config = Mock(spec=TaskConfig)
> config.fake_value = "bogus"
> assert config.fake_value == "bogus"
> ```
> 
> whereas:
> 
> ```py
> config = TaskConfig(fake_value="bogus")
> assert config.fake_value == "bogus"
> ```
> 
> will raise a `TypeError`.
> 
> David McLaughlin wrote:
> This code is an example of you testing the code you've written in a test. 
> I feel this is not really relevant to the spirit of this particular ticket. 
> Does the ticket I've filed satisfy you or do you want to block this review on 
> this issue?
> 
> Kevin Sweeney wrote:
> I disagree - that change is exactly what's in scope of this particular 
> ticket. The point of spec is to prevent typos by speccing against the API. 
> The particular mocking technique of using spec=StructName doesn't work here 
> because the generated class doesn't have any attributes. However it is 
> possible, by using the arg names as a `spec_set` argument:
> 
> ```py
> TaskConfig_argnames = inspect.getargspec(TaskConfig.__init__)[0][1:]
> Mock(spec_set=TaskConfig_argnames)
> ```
> 
> Then sets to properties that aren't defined in the Thrift API will fail.

If you look at the rb that was filed for this ticket you'll see the 'spirit' I 
was referring to. I mean we literally have specs that look like this:


mock_options = Mock(spec=['bindings', 'cluster', 'env', 'json', 
'open_browser', 'rename_from'])


These strings are duplicated from the option names defined in argparse/our 
layers of wrappers. And this is where we've actually seen bugs, not thrift 
field renames.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27058/#review57926
---


On Oct. 23, 2014, 6:14 p.m., David McLaughlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27058/
> ---
> 
> (Updated Oct. 23, 2014, 6:14 p.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Zameer Manji.
> 
> 
> Bugs: AURORA-248
> https://issues.apache.org/jira/browse/AURORA-248
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Use of Mock() without a specification considered harmful. I went through and 
> updated as many mocks as I could. 
> 
> Any remaining can be classified as:
> 
> 1) Mocks of classes that cannot be spec'd. Almost all i

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

2014-10-23 Thread Zameer Manji



> On Oct. 23, 2014, 12:28 p.m., Kevin Sweeney wrote:
> > Any progress here?
> 
> Bill Farner wrote:
> FYI - i believe this may be a dangerous feature until 
> https://issues.apache.org/jira/browse/MESOS-703 is complete.
> 
> Kevin Sweeney wrote:
> Yikes, thoughts on linking that as a blocker to AURORA-867 and 
> unassigning for now?

Done.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review58064
---


On Sept. 4, 2014, 4:36 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> ---
> 
> (Updated Sept. 4, 2014, 4:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set principal field in FrameworkInfo struct.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
> 9cc04a84a37374ffca418e2ff767992ee23b9f3e 
> 
> Diff: https://reviews.apache.org/r/25366/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 26954: Preparing for Identity struct deprecation (client and executor).

2014-10-23 Thread Kevin Sweeney



> On Oct. 22, 2014, 4:51 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/cli/test_diff.py, line 60
> > 
> >
> > While you're here, please change this to not use Mock, all down the 
> > hierarchy.
> > 
> > Ditto for other cargo cults (thanks for collapsing a few, btw).
> 
> Maxim Khutornenko wrote:
> I collapsed all related cli methods into util.py and using specs for all 
> Mocks now. Did not modify the commands (v1) tests to let them die out 
> naturally.
> 
> I actually like mocks here as tests fail when accessing a field that is 
> not populated.
> 
> Bill Farner wrote:
> Please chime in on https://reviews.apache.org/r/27058/, where the exact 
> opposite perspective exists.
> 
> Maxim Khutornenko wrote:
> Commented there. Having a Mock with spec here really helps identifying 
> the usage.

See my comments there - tl;dr `Mock(spec=ThriftStruct)` should be considered 
harmful as it's no better than `Mock(spec=object)`.

Either calling the kwargs constructor or using `spec_set` with the constructor 
kwargs retrieved via reflection gets us the correct behavior here. Since this 
seems to be a source of confusion for several people we're probably well-served 
factoring out a thrift_test_util library or moving to kwargs everywhere.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26954/#review57933
---


On Oct. 22, 2014, 4:59 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26954/
> ---
> 
> (Updated Oct. 22, 2014, 4:59 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-84
> https://issues.apache.org/jira/browse/AURORA-84
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Python side of changes for deprecating identity struct. Accounting for the 
> upcoming deprecation by backfilling missing fields and switching between 
> old/new fields (whichever is available).
> 
> Branched off of https://reviews.apache.org/r/26762/ and will have to be 
> pushed together.
> 
> Summary of changes:
> - TaskConfig - backfilling _key_ field in job diff and update commands.
> 
> Also, some unit test refactoring to avoid copy-pasted fragments.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/instance_watcher.py 
> b390aa8993205f1f6938f8c295e3c16a0bf4df6d 
>   src/main/python/apache/aurora/client/api/sla.py 
> b9b64680b15f5395ed6aca681b9b1c30ffe2822c 
>   src/main/python/apache/aurora/client/cli/task.py 
> c41484bdc27266443bc4e139e1ebb362a59be0f9 
>   src/main/python/apache/aurora/client/commands/admin.py 
> deee0250f3ba9837feeb92acc654f5b3b68b4e0f 
>   src/main/python/apache/aurora/client/commands/core.py 
> 58f419e674f1a9a0ae9da6faa2e39c8167bab597 
>   src/main/python/apache/aurora/client/commands/ssh.py 
> d2b8bf675556b924d3d63b545d036dc48a081486 
>   src/main/python/apache/aurora/config/thrift.py 
> 9ca806db6d2c59836196ea2fdd3fc015b9f6b71f 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> 2c6423d096656f426a4385f4edef6875ebad7049 
>   src/main/python/apache/aurora/executor/common/announcer.py 
> 74b2114d1ede7a4a4a68b78144f9b08bc994bd87 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> bb99bd12d7387e080d8d4c0557d2afa3bf5e7c60 
>   src/test/python/apache/aurora/client/api/test_instance_watcher.py 
> ae1b24bf4e3291cb31b3129cabcacdf32db0c560 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 1117f24d5ad3640632a1dd728913ba73c8bec707 
>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 
> 95aa649cfff9166dd10aa432c4d470739e8f06c5 
>   src/test/python/apache/aurora/client/cli/test_diff.py 
> 10817695352687cdb5b0c3ed9720e3091b230e68 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4f62cf0c52e5837309cf7ad702df6d907df8f510 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 16fde14c03f6fd2c000e76625fad174835763f1b 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> 1ec5483506a22a774340acccd33f09f1742be8b7 
>   src/test/python/apache/aurora/client/cli/util.py 
> 3fa609a5f71525393ca0a5dbd81423005fadb583 
>   src/test/python/apache/aurora/client/commands/test_diff.py 
> c8d01456aa52fd61374b4f0960b5159da2cb235b 
>   src/test/python/apache/aurora/client/commands/test_ssh.py 
> abb657ba397c23ddac6c6b188f70d1c4e34597a6 
>   src/test/python/apache/aurora/client/commands/test_status.py 
> 639763501348a35bff2f127e18780ac74852f51b 
>   src/test/python/apache/aurora/client/commands/test_update.py 
> 07cbe53109e8bcdd09dcac47f6353b10e095717d 
>   src/test/python/apache/aurora/config/test_thrift.p

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

2014-10-23 Thread Kevin Sweeney



> On Oct. 23, 2014, 12:28 p.m., Kevin Sweeney wrote:
> > Any progress here?
> 
> Bill Farner wrote:
> FYI - i believe this may be a dangerous feature until 
> https://issues.apache.org/jira/browse/MESOS-703 is complete.

Yikes, thoughts on linking that as a blocker to AURORA-867 and unassigning for 
now?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review58064
---


On Sept. 4, 2014, 4:36 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> ---
> 
> (Updated Sept. 4, 2014, 4:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set principal field in FrameworkInfo struct.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
> 9cc04a84a37374ffca418e2ff767992ee23b9f3e 
> 
> Diff: https://reviews.apache.org/r/25366/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Re: Review Request 25366: Set principal field in FrameworkInfo struct.

2014-10-23 Thread Bill Farner



> On Oct. 23, 2014, 7:28 p.m., Kevin Sweeney wrote:
> > Any progress here?

FYI - i believe this may be a dangerous feature until 
https://issues.apache.org/jira/browse/MESOS-703 is complete.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25366/#review58064
---


On Sept. 4, 2014, 11:36 p.m., Zameer Manji wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25366/
> ---
> 
> (Updated Sept. 4, 2014, 11:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, 
> and Bill Farner.
> 
> 
> Bugs: AURORA-687
> https://issues.apache.org/jira/browse/AURORA-687
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Set principal field in FrameworkInfo struct.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
> 9cc04a84a37374ffca418e2ff767992ee23b9f3e 
> 
> Diff: https://reviews.apache.org/r/25366/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

60 matches

Mail list logo