[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 7: Code-Review+1

Hi Bharath, I have merged the test case and carried your Code-Review+1. Would 
Jim please review this code again? Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 7: Code-Review+1

Thank you for the suggestion that I have modified the code.

-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Hello Bharath Vissapragada,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7187

to look at the new patch set (#7).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function print_to_stderr() has a syntax error when an error message is
displayed.

I solved this problem by exchanging the position of variable and the
subsequent strings in function print_to_stderr().

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
2 files changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/7
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 6:

Please review this code. Thanks a lot.

-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth

[Donghui Xu (Code Review)]

Hello Bharath Vissapragada,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7188

to look at the new patch set (#4).

Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used 
without LDAP auth
..

IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth

When only with ldap_password_cmd option, impala-shell runs successfully.

I solved this problem by throwing an error when --ldap_password_cmd is
used without LDAP auth, that is, ldap_password_cmd option will only
take effect if ldap option presents.

Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Hello Impala Public Jenkins, Jim Apple,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7179

to look at the new patch set (#11).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/11
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#10).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/10
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 9:

Hi,Jim.I pull this patch by download the url, rebase it to master branch, then 
submit new code, but it doesn't resolve the conflict.
Would you please resolve the conflict please?
Thank you.

-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#9).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/9
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 8:

There are errors as follows when git push:
error: unpack failed: error Missing tree 
72a38838092b37a5d0df2eb6cd3afbad419956f8
To http://david...@gerrit.cloudera.org:8080/Impala-ASF
 ! [remote rejected] HEAD -> refs/for/master (n/a (unpacker error))
error: failed to push some refs to 
'http://david...@gerrit.cloudera.org:8080/Impala-ASF'

-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 6:

This is a abnormal test case which terminated immediately. This is different 
from test case test_var_substitution which execute sql file and verify the 
results of the file execution.
So, I think we should not move this test into test_var_substitution().

-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 8:

I have tried to merge code, but IMPALA-5506 modified the same code.
I don't know how to resolve it. Can you help me to merger code? Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#8).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/8
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#7).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/7
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 6:

(1 comment)

I have modified comit message.

http://gerrit.cloudera.org:8080/#/c/7187/5//COMMIT_MSG
Commit Message:

PS5, Line 9: 
> Prose lines in commit messages  should neither begin nor end with spaces.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#6).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function print_to_stderr() has a syntax error when an error message is
displayed.

I solved this problem by exchanging the position of variable and the
subsequent strings in function print_to_stderr().

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 6:

(1 comment)

I hava added description about underscores. Than you.

http://gerrit.cloudera.org:8080/#/c/7179/5/shell/option_parser.py
File shell/option_parser.py:

Line 164:  " contains alphanumeric characters or 
underscores.")
> This actually is incorrect - it can also contain underscores.
Sorry for missing underline.


-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#6).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used 
without LDAP auth
..


Patch Set 3:

(3 comments)

Thank you for the suggestion. I have modified the code.

http://gerrit.cloudera.org:8080/#/c/7188/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Throw an error when --ldap_password_cmd is used with
> Sorry for nitpicking, I don't think judgement is the right word here. How a
Done


PS2, Line 11: 
> nit: Please remove trailing spaces (here and below)
Done


http://gerrit.cloudera.org:8080/#/c/7188/2/shell/impala_shell.py
File shell/impala_shell.py:

PS2, Line 1333: Option --ldap_password_cmd requires using LDAP authentication m
> IMO something like "Option --ldap_password_cmd requires using LDAP authenti
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 5:

(4 comments)

I have modified the code according to your opinion and added the test case.

http://gerrit.cloudera.org:8080/#/c/7187/4//COMMIT_MSG
Commit Message:

PS4, Line 9: print_to_stderr
> Please fix as you did below.
Done


PS4, Line 10: d
> The usual commit message style is that prose lines do not begin with spaces
Done


http://gerrit.cloudera.org:8080/#/c/7187/4/shell/impala_shell.py
File shell/impala_shell.py:

PS4, Line 1252: 
> Don't think this is needed.
Done


Line 1253: 'It must follow the pattern "KEY=VALUE".')
> Mind adding a quick test in test_var_replacement() to cover this?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#5).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function print_to_stderr() has a syntax error when an error message is 
displayed.

I solved this problem by exchanging the position of variable and the 
subsequent strings in function print_to_stderr().

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
2 files changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 5:

(3 comments)

I have solved the suggestion you have mentioned.

http://gerrit.cloudera.org:8080/#/c/7179/4/shell/option_parser.py
File shell/option_parser.py:

PS4, Line 88: If the argument to -f is "-", then queries are read from stdin"
:  " and terminated with ctrl-d
> Try "If the argument to -f is "-", then queries are read from stdin and ter
Done


PS4, Line 163: starts with an alphabetic character and"
> "starts with an alphabetic character"
Done


PS4, Line 164: only alphanumeric characters.")
> "only alphanumeric characters."
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#5).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..


Patch Set 4:

(2 comments)

I have modified the code according to your opinion.
I think your advice is fine, but how do i know who is familiar with that file?

http://gerrit.cloudera.org:8080/#/c/7187/2//COMMIT_MSG
Commit Message:

PS2, Line 9: 
> Please do not end lines in spaces.
Done


PS2, Line 13:  print_to_stder
> Functions are usually written "print_to_stderr()" - preserving capitalizati
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#4).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function Print_to_stderr has a syntax error when an error message is
 displayed.

I solved this problem by exchanging the position of variable and the
 subsequent strings in function print_to_stderr().

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#3).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function Print_to_stderr has a syntax error when an error message is
 displayed.

I solved this problem by exchanging the position of variable and the 
subsequent strings in function print_to_stderr().

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..


Patch Set 4:

(3 comments)

I have modified the code according to your opinion, please check again.
Thank you.

http://gerrit.cloudera.org:8080/#/c/7179/3/shell/option_parser.py
File shell/option_parser.py:

PS3, Line 88: rea
> "will"
Done


PS3, Line 162: follow th
> What exactly do you mean by character - do you mean a-z and A-Z?
Done


PS3, Line 163: KEY has 
> What contains characters and/or numbers - KEY? VALUE?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Jim Apple 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#4).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Jim Apple 

[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and 
ldap
..


Patch Set 2:

Can anyone review this issue please? Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#2).

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function Print_to_stderr has a syntax error when an error message is 
displayed.

I solved this problem by exchanging the position of variable and the 
subsequent strings in function Print_to_stderr.

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#2).

Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and 
ldap
..

IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap

When only with ldap_password_cmd option, impala-shell runs successfully.

I solved this problem by adding the joint judgment of ldap_password_cmd 
and ldap, that is, ldap_password_cmd option will only take effect if 
ldap option presents.

Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5514: Add the joint judgment of ldap password cmd and ldap

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7188

Change subject: IMPALA-5514: Add the joint judgment of ldap_password_cmd and 
ldap
..

IMPALA-5514: Add the joint judgment of ldap_password_cmd and ldap

When only with ldap_password_cmd option, impala-shell runs successfully.

I solved this problem by adding the joint judgment of ldap_password_cmd and 
ldap,
that is, ldap_password_cmd option will only appear if ldap option appears.

Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
---
M shell/impala_shell.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/7188/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3711d8a0eca2fa8612e2943fa9121945db6b012e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7187

Change subject: IMPALA-5513: Fix display message exception when using invalid 
KEYVAL
..

IMPALA-5513: Fix display message exception when using invalid KEYVAL

Function Print_to_stderr has a syntax error when an error message is displayed.

I solved this problem by exchanging the position of variable and the subsequent
strings in function Print_to_stderr.

Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
---
M shell/impala_shell.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/7187/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib883499a88f39d91b69bea4291f1ce5dd264ccf6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#3).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#2).

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7179

Change subject: IMPALA-5507: Add clear description to help information of 
KEYVAL option
..

IMPALA-5507: Add clear description to help information of KEYVAL option

Help information of KEYVAL option in impala-shell is not clear enough.

I fix this issue by adding clear description to help information of
KEYVAL option.

Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5506: Add stdin description to help information of 
query_file option
..


Patch Set 2:

(1 comment)

I have modified the code according to your opinion.

http://gerrit.cloudera.org:8080/#/c/7178/1/shell/option_parser.py
File shell/option_parser.py:

Line 87: help="Execute the queries in the query file, 
delimited by ;."
> Please wrap to 90 chars.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#2).

Change subject: IMPALA-5506: Add stdin description to help information of 
query_file option
..

IMPALA-5506: Add stdin description to help information of query_file option

Help information of query_file option in impala-shell misses stdin
description.

I fix this issue by adding stdin description to help information of
query_file option.

Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
---
M shell/option_parser.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/7178/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7178

Change subject: IMPALA-5506: Add stdin description to help information of 
query_file option
..

IMPALA-5506: Add stdin description to help information of query_file option

Help information of query_file option in impala-shell misses stdin
description.

I fix this issue by adding stdin description to help information of
query_file option.

Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
---
M shell/option_parser.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/7178/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message

[Donghui Xu (Code Review)]

Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7166

to look at the new patch set (#6).

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP message
..

IMPALA-5492: Fix incorrect newline character in the LDAP message

The introduction has redundant '\' in impala-shell when using LDAP.

I fix this issue by removing extraneous '\' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Donghui Xu (Code Review)]

Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7166

to look at the new patch set (#5).

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP 
message within  impala-shell introduction
..

IMPALA-5492: Fix incorrect newline character in the LDAP message within 
impala-shell introduction

The introduction has redundant '\' in impala-shell when using LDAP.

I fix this issue by removing extraneous '\' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Donghui Xu (Code Review)]

Hello Henry Robinson,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7166

to look at the new patch set (#4).

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP 
message within impala-shell introduction
..

IMPALA-5492: Fix incorrect newline character in the LDAP message within 
impala-shell introduction

The introduction has redundant '\' in impala-shell when using LDAP.

I fix this issue by removing extraneous '\' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP 
message within impala-shell introduction
..


Patch Set 3:

(2 comments)

I have resolved the problems you mentioned. Please review again. Thanks.

http://gerrit.cloudera.org:8080/#/c/7166/2//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5492: Fix incorrect newline character in the LDAP message within 
impala-shell introduction
> nit: Space after the jira key, something like "IMPALA-5492: ". (Th
Done


PS2, Line 9: The introduction has redundant '\' in impala-shell when using LDAP.
   : 
   : I fix this issue by removing extraneous '\' in introduction when
   : impala-shell using LDAP.
> May be reword to "Remove extraneous '\' .."?  Looks like you are not removi
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Henry Robinson 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5492: Fix incorrect newline character in the LDAP message within impala-shell introduction

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#3).

Change subject: IMPALA-5492: Fix incorrect newline character in the LDAP 
message within impala-shell introduction
..

IMPALA-5492: Fix incorrect newline character in the LDAP message within 
impala-shell introduction

The introduction has redundant '\' in impala-shell when using LDAP.

I fix this issue by removing extraneous '\' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Bharath Vissapragada 

[Impala-ASF-CR] IMPALA-5492:There is an error in impala-shell introduction when using LDAP

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#2).

Change subject: IMPALA-5492:There is an error in impala-shell introduction when 
using LDAP
..

IMPALA-5492:There is an error in impala-shell introduction when using LDAP

The introduction has redundant '\n' in impala-shell when using LDAP.

I fix this issue by deleting the redundant '\n' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-5492:There is an error in impala-shell introduction when using LDAP

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7166

Change subject: IMPALA-5492:There is an error in impala-shell introduction when 
using LDAP
..

IMPALA-5492:There is an error in impala-shell introduction
when using LDAP

The introduction has redundant '\n' in impala-shell when using LDAP.

I fix this issue by deleting the redundant '\n' in introduction when
impala-shell using LDAP.

Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
---
M shell/impala_shell.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/7166/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30c601ab255a4882260f7be23b5763ef8ec76d28
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4710: There is an error in control audit log file size 
number
..


Patch Set 3:

I have resolved the JIRA and changed it's status to resolved.

-- 
To view, visit http://gerrit.cloudera.org:8080/5582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 14:

I have resolved the JIRA and changed it's status to resolved.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 14
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4710: There is an error in control audit log file size number

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5582

Change subject: IMPALA-4710: There is an error in control audit log file size 
number
..

IMPALA-4710: There is an error in control audit log file size number

The comparison logic of log file size and maximum config is wrong,
leading to log file size is greater than the maximum config.

This patch corrects the error, makes both are consistent.

Change-Id: I1808d69359102d63b732469b440c9c7675a371b7
---
M be/src/util/simple-logger.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/5582/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1808d69359102d63b732469b440c9c7675a371b7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 12:

(2 comments)

Thank you. I have modified the code according to your opinion.

http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/common/logging.cc
File be/src/common/logging.cc:

PS11, Line 181: max_log_files <= 
> nit: rewrite as <= 0 to be consistent with other places
Done


http://gerrit.cloudera.org:8080/#/c/4971/11/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 272:   static const string AUDIT_EVENT_LOG_FILE_PREFIX;
> Let's remove this function and simplify things by making AUDIT_EVENT_LOG_FI
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Hello Lars Volker,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4971

to look at the new patch set (#12).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow

There is no limit to the number of audit event log files. When audit
event log is enabled the growing number of log files will fill up the
disk space.

This patch adds checking and rotation mechanism on audit event log
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
5 files changed, 33 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/12
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-Reviewer: Tim Armstrong 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 11:

Is there any expert review my code? Thanks.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 11:

Audit event log has no link file, so there is no link file switch problem. 
we don't need to limit the minimum number of log file to 2. It can be 1. It is 
0 means no limit.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 11:

I have tested that set max_audit_event_log_files to 1. That worked as expected.

I have researched CheckAndRotateLogFiles and associated glog codes.
Each severity of the log creates a soft link file always point to the latest 
log file with the severity. The log switch process includes creating a new log 
file, delete the old link file, create new link file, so involved in the old 
and new log files. I think that restrict the minimum log file number greater 
than 1(>=2) is to ensure  the link files to switch correctly while deleting old 
log files.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#10).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow

There is no limit to the number of audit event log files. When audit
event log is enabled the growing number of log files will fill up the
disk space.

This patch adds checking and rotation mechanism on audit event log
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
5 files changed, 38 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/10
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 9:

Use clang-format-diff.py to correct code format.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#9).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow

There is no limit to the number of audit event log files. When audit
event log is enabled the growing number of log files will fill up the
disk space.

This patch adds checking and rotation mechanism on audit event log
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
5 files changed, 39 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/9
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..


Patch Set 8:

(3 comments)

Thank you for reviewing my low level format errors so many time.
I will learn to use clang-format tool.:)

http://gerrit.cloudera.org:8080/#/c/4971/7//COMMIT_MSG
Commit Message:

Line 11: event log is enabled the growing number of log files will fill up the
> nit: comma
Done


http://gerrit.cloudera.org:8080/#/c/4971/7/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 17: 
> Please move this to the block of impala includes, starting in L34. Please k
Done


Line 57: mutex logging_mutex;
> Please remove this new line.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#8).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow

There is no limit to the number of audit event log files. When audit
event log is enabled the growing number of log files will fill up the
disk space.

This patch adds checking and rotation mechanism on audit event log
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
5 files changed, 37 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/8
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow.
..


Patch Set 6:

I have added static method GetAuditEventLogFilePrefix in class ImpalaServer. 
Thus reduplicate definition of AUDIT_EVENT_LOG_FILE_PREFIX in logging.cc can  
be deleted, function CheckAndRotateAuditEventLogFiles can use 
GetAuditEventLogFilePrefix to get AUDIT_EVENT_LOG_FILE_PREFIX defined in 
impala-server.cc

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#6).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow.
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow.

There is no limit to the number of audit event log files. When audit 
event log is enabled,the growing number of log files will fill up the 
disk space.

This patch adds checking and rotation mechanism on audit event log 
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
5 files changed, 38 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Donghui Xu (Code Review)]

Donghui Xu has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow.
..


Patch Set 5:

(9 comments)

logging.cc Line 58: I can't use it by include impala-server.h, because this 
variable is const type, while impala-server.h only contains methods and member 
variables. It does not include this variable.

http://gerrit.cloudera.org:8080/#/c/4971/1//COMMIT_MSG
Commit Message:

PS1, Line 2: davidxdh
> nit: you might want to configure git to include your name here
Done


PS1, Line 10: dit e
> fill up
Done


http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/init.cc
File be/src/common/init.cc:

PS1, Line 68: 0, 
> I don't think we should set a default here, because audit information might
Done


Line 69:  "to retain. The most recent audit event log files are 
retained. If set to 0, "
> Use spaces instead of tabs, wrap lines at 90 characters. You can use git-cl
Done


http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/init.cc
File be/src/common/init.cc:

Line 69:  "to retain. The most recent audit event log files are 
retained. If set to 0, "
> Please follow the indentation of the surrounding code
Done


http://gerrit.cloudera.org:8080/#/c/4971/1/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 58: // Prefix of audit event log filename. The version number is
> Where in the code do we make sure that event log files are always written w
This variable is referenced from AUDIT_EVENT_LOG_FILE_PREFIX at line 195 in 
be/src/service/impala-server.cc.
I can't use it by include impala-server.h, because this variable is const while 
impala-server.h only contains methods and member variables.


http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/logging.cc
File be/src/common/logging.cc:

Line 185:   if (max_log_files <= 1) return;
> This line looks wrong, please update comment.
Done


http://gerrit.cloudera.org:8080/#/c/4971/4/be/src/common/logging.cc
File be/src/common/logging.cc:

PS4, Line 61: AUDIT_EVENT_LOG_FILE_PREFIX
I can't use it by include impala-server.h, because this variable is const type, 
while impala-server.h only contains methods and member variables. It does not 
include this variable.


http://gerrit.cloudera.org:8080/#/c/4971/4/be/src/common/logging.h
File be/src/common/logging.h:

PS4, Line 85: /// Helper function that checks for the number of logfiles in the 
log directory and
> please wrap this paragraph and the one below at 90 characters.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Donghui Xu 
Gerrit-Reviewer: Lars Volker 
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#5).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow.
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow.

There is no limit to the number of audit event log files. When audit 
event log is enabled,the growing number of log files will fill up the 
disk space.

This patch adds checking and rotation mechanism on audit event log 
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
3 files changed, 34 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Lars Volker 

[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow.

[Donghui Xu (Code Review)]

Donghui Xu has uploaded a new patch set (#3).

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent 
disk  overflow.
..

IMPALA-4431: Add audit event log control mechanism to prevent disk 
overflow.

There is no limit to the number of audit event log files. When audit 
event log is enabled,the growing number of log files will fill up the 
disk space.

This patch adds checking and rotation mechanism on audit event log 
files to prevent file number out of control which causes disk overflow.

Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
---
M be/src/common/init.cc
M be/src/common/logging.cc
M be/src/common/logging.h
3 files changed, 29 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/4971/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu 
Gerrit-Reviewer: Lars Volker